From nobody Sat Jul 25 18:53:09 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DE8743C056 for ; Wed, 15 Jul 2026 10:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; cv=none; b=cthZ5PRWnrwxjatQyVIlRwtKEzJzp2tjxt+LcWpxYXsUJYWjTJP4PqvOkChHvMqhvSsaP3Xqssqseg3sYwhcrNPI6ybYTFt60i7QkGjybkv/LZi6vBg0GF7sGkBX5+FI6gViVfPIHkXU0dm99CKUWhPgGAYOLzprMGp4xLSkpgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; c=relaxed/simple; bh=DO4pUTloSCmd0KOmrWJsUS2U9gK6DNRCgmxLFrZRTyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aWMSgvDkacvuznoLHuY26MhofU+V+BbhivI5bhNxktn3ywZD+8uTWMYk5AvY6K2O7AVZ5cjBs0dKskv81pPaPSrV43bSqbX1+JS0o9GjhEFnW3FQSk1UE69uaRufQlxiVR40mdfjorkwCQkSga7nJ27KC64w1bwFR7CeSfi8ZX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FVTXlJC1; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FVTXlJC1" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-383adaa461fso1418039a91.3 for ; Wed, 15 Jul 2026 03:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784110259; x=1784715059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VNXyVM0mnowONm4346tNECsZGvG1q+nnKtqJNufizQw=; b=FVTXlJC117BcjWQdJBRHKPXSTi5H9rrFFEDofRSu3aMPyn0emuR1LG5I/lFnfq6y8A hom1aVRIV9N057hMQNkvFW7ukOgJ11LzU/6vWPN/A80ddE+zFzLUoTFBgb3I4Gw8rQxj Q0ZOm7TJUkyZIczLXfP9r5l5fKbe+h5mxVYfMoof9o6bGbjy+fpq9PU2ASlN00YI/bas dGLKdIQGmv6tNInT8NIt4yocE3PtXhhF7wjD+kR9Q9u13Ov08WzfY0MeIvwICMHJias+ bfEGpm0itCMBazmuxtN5l2FY5NCGF/QAcCPvEP++NzBWBzIlG2MeB1m4WDqjNb6UiCrY JSGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784110259; x=1784715059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VNXyVM0mnowONm4346tNECsZGvG1q+nnKtqJNufizQw=; b=fbjLflyNOyqkRsy/fwJHXE43FylBD65TT2ycWYHgfRegUoi3xveRrDluw3w3AfHHnb 3rhxobEFFhJfLK5z10vgTOHBpHcePQlTTS27EIa1r0AK7dr8zKv2lq0ZGwPT5xSX6YVr 633kWTFhzDEmcSdQup0T32O7RINp6t+LWOJYpdyT3qf900Kokfd6eX+5tZk2vsEEddCx a9hGgujmTZWswTeU2WgbPj06h+gEfVHcENlUDsvW6A/sc2+nUcmQfRghSGAV0mdn2o+F 9rQgt7Rhkoe08woB6/LKx2sUOZ73Gy2dZoRBj3Ajw95zVCX56yc18+iJ1OeL1tCzzvBe /UWQ== X-Forwarded-Encrypted: i=1; AHgh+RovGYqMppNmjTpzKbfLrEVTtSHFB8tXs9H/FV2ybmpJzoY2gzcucSFdQLtTo1A3MuiUMADD9Zv8eOa68qI=@vger.kernel.org X-Gm-Message-State: AOJu0YzIZ7REul3SzS3kYSPAzJJDPMbkPdtrqwqXuCetXfw+ZdI3OUjT d2XsY7NT3pWYKVdP2syLF/xPKZEAyfDr7XmrVtMSlJa/QKhRsxfnazvt5WgeYA== X-Gm-Gg: AfdE7clzocbWjr0f83N4k/KgfWIxtTcTiajkp7CpfjGg8PjG0b/ej5YhilI0a3oELwJ TwmeJPtSGPPM+Ep9lNiTaflBPJHQiKTreLcC9Kt2LR+qrisRcM86FUwrBO6ZG7gIdMKVtDlzzI5 kbqiZQojms9bLL1NKHQRJ293TAe5jPkxmo3Tlt0e+pQij8HxD3DdbJmXKQnu0LOkeVdurHtyZr/ EQCGWm1HYBEkc6X6hjxth52ogmZmQA/trsqSNo8VQduIkkFN1hyRIuXKtceSb4OAcU6to7tOJL4 33Wrbh5HWBg+b7XFGFi0BS+KLVkEdZbc7hou89pj950D65AkJi5dxmkZpItlFfjb3h0NInx+hm9 a+6v0WZyvHh1CHZBMzhlsYfh9ZbAvSXuG0BWDAr9N2L/dJcFE4UirYpL+f0xZA3ktpTLuh5xY/o 4BRqckVo4sMh2MzRx3JwNa6wKdg0ZX/YN2VSMXFUrY X-Received: by 2002:a17:90b:2b43:b0:380:21b7:e727 with SMTP id 98e67ed59e1d1-38dc7a494a6mr16685376a91.14.1784110259262; Wed, 15 Jul 2026 03:10:59 -0700 (PDT) Received: from primary ([223.181.23.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3119c2a7bb5sm62079757eec.25.2026.07.15.03.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 03:10:58 -0700 (PDT) From: Vidhu Sarwal To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Per-Daniel Olsson , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH 1/3] iio: light: opt4060: Reject integration times with a non-zero seconds part Date: Wed, 15 Jul 2026 06:45:42 +0530 Message-ID: <20260715011544.281148-2-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260715011544.281148-1-vidhu.linux@gmail.com> References: <20260715011544.281148-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When setting the integration time, opt4060_write_raw() only uses val2 and ignores val. As a result, a write such as 1.000600 is accepted and programmed as 600 us, silently discarding the whole seconds part. Since all supported integration times are less than one second, any non-zero val represents an invalid input. Reject such values instead of silently accepting them. Fixes: 0c6db4506ad0 ("iio: light: Add support for TI OPT4060 color sensor") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/opt4060.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c index c391ad3271c6..cf6f69e5be35 100644 --- a/drivers/iio/light/opt4060.c +++ b/drivers/iio/light/opt4060.c @@ -632,6 +632,9 @@ static int opt4060_write_raw(struct iio_dev *indio_dev, =20 switch (mask) { case IIO_CHAN_INFO_INT_TIME: + if (val) + return -EINVAL; + int_time =3D opt4060_als_time_to_index(val2); if (int_time < 0) return int_time; --=20 2.53.0 From nobody Sat Jul 25 18:53:09 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2914843C065 for ; Wed, 15 Jul 2026 10:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; cv=none; b=slEea1n/Mgbby1pALBO0qSawkB9Gk7QiocrRyBd4AEHSeyUe+x9VcGLJsAXAlyuDYyHwKtZ3BbwDns7NUMHtMnLV1efuOR6sS5t9+Qv/icAqmiP9R3sc9l11KmLUygaAqLw17jz0iU5Qyolem/SU9OxkLmgLxpzNYkvTuJG8zSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; c=relaxed/simple; bh=yXQameaNSRa+QXBKj6CBG0heh79Z1cjYE9sx8sHKO3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=djsP+qv756JKiObTp/AfX9thamfq4ecdP7yMreK/YTGxA27NMFSSQ9TdgIyG0NydTir+aPnYzyGk4cWSU4x3VthYty7eMZpPBmlBK412JLJBLz0YZLGhiNWw0tu4vsz2/JNHQ2ZdRd8oRmR1Kb0OxXTIWNuhJIX8wc8wZ5Xbtm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y4/onsmn; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y4/onsmn" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso4121059a91.1 for ; Wed, 15 Jul 2026 03:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784110263; x=1784715063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gBNL9jZr+BjLwoEnPOS4tAnKcJKl6B6YE59NAlSHzw0=; b=Y4/onsmnAskXenXpCeVxbGxc+TXpe3pIuBFrpYX7Y1kB0MGKCONi3s/d+yeh+GEqyF LndMf2Bv+Pq5oN2MWyeKdvsY+XHU0RZXVkLX1O4AGqPxLQH62i+qDED05lVFxmm9ftlH BZzWszxQgy3fPeUNdrO8PLoTmQzMxju49NZkUL+yVTrA3mQM7dZTBt6tsGLUPHjhvUyo QnxCOTQ1MEkBNJ3Nza5qsxlyUhUBRyGli5lbZIx7FyhXDw7fEeGzbwizZqkr6TygtBBI DKd351njxAWtFmm599MYrg3fVsNymSyhqaju7xlYpAlvSVjrPW3OtE2nvmo/I7e5ZMKj jLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784110263; x=1784715063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gBNL9jZr+BjLwoEnPOS4tAnKcJKl6B6YE59NAlSHzw0=; b=BXsweSRCMwRc6Mer+m9VTOUYw/kOEQ87QsMGsIL/vZ6/yl/F+nAb+CNHUdb6tYYqJy FXrVdSfnDKWG8ItLvogdML4O8ybkzRL3MgE6CepwEapdnSEHTQEeFxjwwpRfvErRW85z h5DbHi4GxUgFoCCXGGb9TvbcriBQ9c1JY6SGvq9KWJIiPYNTC5S1l64ue2bAoO5ePkBp zOSPMhchh1NqjaMq98qFSanH4Reb4SZb0oxRqcKdE7N5s6J6nOHULWtNYPGGQc3IuEZg kF1FSp95bggAAtXQ3h5hKgbdyVNUJ4fVG8YoDOOSwykGQ7aK2Q7d8hj28NmIL6tSlzrp j26g== X-Forwarded-Encrypted: i=1; AHgh+RqrZFy/zovn30+FulemWV4LwDf77puWgLvyd5fqWWiYf4gRW08ydzTRLMGoYxNfh7/hU+JhLi7VHnHLH4c=@vger.kernel.org X-Gm-Message-State: AOJu0YwXqdAobZ66JcgeWo+SZerb1Fl/UTVKkk5QGtIWY/2OH6jzuLCs rbA50J7HmLnEKeCzGIelL3Aa/GY/Ld4S/XtfI2s6UdKOwTtkRU+bTjMb X-Gm-Gg: AfdE7ckRXA6Hh+0ecmZImjRwC9MsHcFjH+utY2KZBGFasBA95EnQidK8oGNzaF5Ohuv OOw8KLoB7twj9lFI4GfZm91g2CYrX7A7PPbVU3AW6dwH2twcZy/GNf5kWYUwz5yvFj++RsHcvCS 15bjY+T9+5wSgbnyNOiFWGoZ/i+NFOPywEJMmrjIIM1gGm41b4CY7JM+0nrijkUK8hAVBTr8zwW 0hxwvH4NxNYTt36F0oAO8rQBtEkLL/S0oqwk5qgeAaQl03GoHs1Bjv49omK9W+xOKj12Yp9IU2Y 1pihXDaqDVl63n8bw12vNwKS5TnTregNJxxCcO2pnlLE8g+CAxlD/wo+cLg6g8A+dUe4TCY+ryg /WEhq2FKUfIfR70QEcHx6of7xUcIufyXgxyhFlicv3U6oQ+sTm1btDTgUViv2ubpSon9js95awq AGXopExlcJarRbu6SRXhTpPCLXCCaQT9cnfd55r6fwwhF1Mht+z9w= X-Received: by 2002:a17:90b:55c5:b0:381:77cd:38d1 with SMTP id 98e67ed59e1d1-38e1ae2679fmr5266216a91.10.1784110263189; Wed, 15 Jul 2026 03:11:03 -0700 (PDT) Received: from primary ([223.181.23.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3119c2a7bb5sm62079757eec.25.2026.07.15.03.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 03:11:02 -0700 (PDT) From: Vidhu Sarwal To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Per-Daniel Olsson , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH 2/3] iio: light: opt4060: Fix pointer type passed to div_u64_rem() Date: Wed, 15 Jul 2026 06:45:43 +0530 Message-ID: <20260715011544.281148-3-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260715011544.281148-1-vidhu.linux@gmail.com> References: <20260715011544.281148-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" div_u64_rem() expects a u32 * for the remainder, but opt4060_read_ev_period() passes val2, which is declared as an int *. While this has no functional impact, it triggers a pointer type mismatch. There is no behavioural change because int and u32 have the same size and representation on all supported architectures, and the remainder is always less than MICRO, so it fits within the positive range of int. Use a local u32 to receive the remainder before assigning it to *val2. Fixes: 0c6db4506ad0 ("iio: light: Add support for TI OPT4060 color sensor") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/opt4060.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c index cf6f69e5be35..e3aabfb14d5d 100644 --- a/drivers/iio/light/opt4060.c +++ b/drivers/iio/light/opt4060.c @@ -713,6 +713,7 @@ static ssize_t opt4060_read_ev_period(struct opt4060_ch= ip *chip, int *val, { int ret, pers, fault_count, int_time; u64 uval; + u32 rem; =20 int_time =3D opt4060_int_time_reg[chip->int_time][0]; =20 @@ -738,7 +739,8 @@ static ssize_t opt4060_read_ev_period(struct opt4060_ch= ip *chip, int *val, } =20 uval =3D mul_u32_u32(int_time, pers); - *val =3D div_u64_rem(uval, MICRO, val2); + *val =3D div_u64_rem(uval, MICRO, &rem); + *val2 =3D rem; =20 return IIO_VAL_INT_PLUS_MICRO; } --=20 2.53.0 From nobody Sat Jul 25 18:53:09 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2E8943E9F9 for ; Wed, 15 Jul 2026 10:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110269; cv=none; b=tV0qY11aOf2I+h6wgFwboAq1qjrf+GBArpwFs2FfG0OFZSEX6ql479yzy2THKVp6ONiLTaTfGp7WwU7smqD7QQ48DRGWxRFXv1hS6AnY+OGX6/gmMp3YAvg1NlxuF87cdbc/TpZTCtLJfyvCTQr2LoLdGbx8DOVA9GRID4660/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110269; c=relaxed/simple; bh=td8hsDBlRWSg1I0yceKl73dTjjAo8acQBy8lu2qEcxc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jJYRuA+I/DHxHM/or6+86xSHYspGPjKo9TXNmMPzMsvzmRqt88Nz6G/FqzlX146bwcn9AfmZN6Lz0eqnaObTobeFh5GqQS8jinWihS/fO9DqYZWon0X78x1b18U9FQORRKH3tPserhnuxL6yTHJy5CMUFdH+IphG5lCnBfwtOQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rwo6605b; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rwo6605b" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38a0c7e841fso2107767a91.2 for ; Wed, 15 Jul 2026 03:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784110267; x=1784715067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1AtJCx4n0Ha80Zli2eWFQ1VWt2rCUOGYpij+i9kLvvo=; b=Rwo6605beSeXTU8rKWn5qfWfmtbPOHJ6EsRfaz+AZQxILPh6CBv/+AF+2kAayx7OzL /2EHDWBnoOhOgxJ1uuZhisQjVgspeXKy0r79kq5TA/+KYG2Q9YqcggV4GCqMZlaH4MOJ duB0Ajdp265s7oJOjiF85yz8Xj75uUkHegLrNZghs+Dn7Qq9lRAc5UKRXKggNAO36c20 gc9u4OZcm2CH6wD0Erxn9DzwZl8oX+0snRGXXt+OYPFt4/LO4FtqV77IxXYNYpmzrkp6 MfaGXyxcNV038XJlW28jWEe8nsNjOsKCcw/mLuEiAvkgAc/ODWoHHWlZZKwrQ6Kfb29z o3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784110267; x=1784715067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1AtJCx4n0Ha80Zli2eWFQ1VWt2rCUOGYpij+i9kLvvo=; b=oFwKYvUfQGTWtmcVexIs7/e5yf4Ttvyr6qXzLqnYUohDicGnOufflwKWSVGNW/Y25y gKOjkx3nQfxtucpdF8EbUlmakw770f26+ROhhZULncPlZKTXu5heSQHipnc2x6nrXazU WsT+Xd/soTElvtDCWoVKzFtwXULt1DAOkf3cL1acU6lbtqCoMy1Erp9X7/k2bYUwmjiD P1N2RJxn3yXhjYJU3L77Xpej8WvkmJhNj1sNEZfi34o5pB2GXRyJKNO8JMnFVfA9V+hk z8uhi/EQn1ASMPoFviGiYuZ46iUxlu/ZUQKfnjFoRY7SvMFs2GG7uxBiCECW6B73EAtK 7cTg== X-Forwarded-Encrypted: i=1; AHgh+RrBthbc0yRWYkCMq7eSPAiK4svxUeqxzWGl+a0E5Zta1tzQzaooE073KHlgEgOHDLxkl80uKXkdCQL2zKU=@vger.kernel.org X-Gm-Message-State: AOJu0YxS+3/Jr/ZTBdEQhpwUIT+s4OttJsk7fqQadHg76rejJPUoBCDV VbuI+iJjN2Le8rCj72qFP/98j9Xx9La3lbSvn2SeFbQRaRQAMWIsIC/M X-Gm-Gg: AfdE7cl2sBYHUwI/ietLbv13FJ/PQ6yvgjWYBjqopn0ZHU2LrgDS0o6yPtrSBGXBGOZ iUjeGhEpqqiSyB6qfnVnhdt55vaOxh6YKuI8zFEdq1xkuXz9brjT9kbUKYoQu5VKsy2N4z/pYXz mjRjKnQYOyybjSPE0dg1MO5gXIMXRjdtti+W9lx69JUoViMONNDvlnL8Z0K0WcIF4ey8v8p1YJp FJBzNAfUZvboLaa3H6ZNbgWVDNDTXoFPjr2E55UJsywivbppVx/YSQJ6GfclB2DIW/oJrdN5MWz dSAJARnmRT9Uj3yq7b4nDUxsrblrA3rAubN/Zjx6s/qDRSL/BZkGhZMxKMOcuNxZiaeycYLv3Q4 lreuRQsDVCLthWLbzoPZy4Ieb5FmE/5PZPi2AodSca1++gYDTsY7p7NW0Ia5QKtIedQBE2bZGt2 EmJGf9Fhy4fjcHIM78zlnDPX1XqrPyK2Tg2cuTgFmH X-Received: by 2002:a17:90b:498f:b0:368:af5c:5925 with SMTP id 98e67ed59e1d1-38dc77384c6mr15626367a91.23.1784110267074; Wed, 15 Jul 2026 03:11:07 -0700 (PDT) Received: from primary ([223.181.23.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3119c2a7bb5sm62079757eec.25.2026.07.15.03.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 03:11:06 -0700 (PDT) From: Vidhu Sarwal To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Per-Daniel Olsson , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH 3/3] iio: light: opt4060: Fix incorrect register name in threshold read error message Date: Wed, 15 Jul 2026 06:45:44 +0530 Message-ID: <20260715011544.281148-4-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260715011544.281148-1-vidhu.linux@gmail.com> References: <20260715011544.281148-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" opt4060_get_thresholds() correctly reads OPT4060_THRESHOLD_HIGH, but logs "Failed to read THRESHOLD_LOW." if the read fails. This is a copy-and-paste mistake, as the preceding low-threshold read already uses the correct error message. Update the error message to reference OPT4060_THRESHOLD_HIGH. Fixes: 0c6db4506ad0 ("iio: light: Add support for TI OPT4060 color sensor") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/opt4060.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c index e3aabfb14d5d..f79dd342937d 100644 --- a/drivers/iio/light/opt4060.c +++ b/drivers/iio/light/opt4060.c @@ -810,7 +810,7 @@ static int opt4060_get_thresholds(struct opt4060_chip *= chip, u32 *th_lo, u32 *th =20 ret =3D regmap_read(chip->regmap, OPT4060_THRESHOLD_HIGH, ®val); if (ret) { - dev_err(chip->dev, "Failed to read THRESHOLD_LOW.\n"); + dev_err(chip->dev, "Failed to read THRESHOLD_HIGH.\n"); return ret; } *th_hi =3D opt4060_calc_val_from_th_reg(regval); --=20 2.53.0