From nobody Sat Jul 25 18:53:40 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B413242D9 for ; Wed, 15 Jul 2026 01:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784078082; cv=none; b=AgrhWqDgpDMxShGMEfeDE82faRzGtprIU49/D6f0UwGTws7Ui3jf5wnwFFBGBUrKfcb84DWDQW9M2RWI4MEHm2JblOMBrwD/UJvzxiqfv8XMJIOO7RdsVcvWDhe3SR0gvGKMTKFZe3PD+IGQRR527c/hjQVCMB0/5IdE7JQ5eew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784078082; c=relaxed/simple; bh=/cAePJoFLFQ0qWUgua+YcI2anEkgrMTozN9FQTusvEc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=h/YjqEJue+efvBPlGteJIfUQk3oUn4TO765At9YhLvgxsfTo/Qd8KlE8xe7//2rnunFdCmsseo5WHztizdGFeb2y7ofYD6WfgxFs9z4Nap+2DNb5+UuB/eJq0hYiENNtIKtly4vbkCgynXEdXk8vyCxiCVI0RTk0sJ+rXmAabws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FcH9aAYt; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FcH9aAYt" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8487088510aso4861116b3a.0 for ; Tue, 14 Jul 2026 18:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784078081; x=1784682881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7ZKIboljlMl2BHS7OS/1CYKXR7VTo24iT4oUvOKxEkI=; b=FcH9aAYtpJGscaLWmZS2UMHIOpiHYcW9qN2JO321FbzcmBI2PI+tQwTVkEnKBvig5A ksglqYV8P7uf1wn9Q6svdGra5PzhfKo83VTT62a/IcTYXkBmNCG68bqfd4oU72v9Wr55 dyHU6eaMwiwoDeSbSVXIfxlUapLJVFvRJv8QcEYUl7s/bCuB9GCDNLLVMiNUqtf2N+Jc /L9JViE9aSCHWi66NRsdi+3WTtpaESo2W0uBtmMWI7w+vQzgIOvwBk2enU3mVFJEtMPB GBuIfqKF6HYpWQtns+lKy1aVgfwhhwVlreo7V7kfnKT/Q4b10DHw5aYQiCzFIw6IJeEw GP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784078081; x=1784682881; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7ZKIboljlMl2BHS7OS/1CYKXR7VTo24iT4oUvOKxEkI=; b=ebKNNhb/+lRvsgpMc5cSTMeduSZjePR0LO/5DlrJAXV4koJdF2vOO4RSqL9l0F9MxO k/yiiC6vQfn1HhMrQQ00qGVn/9T9sI09GX+TlXfQQM7Vvc5ZQypigrDlXPYOV5nlELIl CPztJ7Y/kxk6JwXi2o8Dz/s9Q5ALZAPGE+yEnLZQUN4CrS7WuEKeEAmgZjobctFA5RGU /es3rMYbd8BCtEYDa7UDjFOfkWx4MxLpzPceSgJOxof9eMqNSWn5dw68+DAug9iduL2S 7Y1zyIKzUk0p4awXPpHE6nhgZPpeEU5QMSDr5TyMci+luPpP0JSr7afTaI3Zhe1NilE2 +DUQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5J3QqTmyL1A6cx2SJWOsAfdJN1AtiEUSG+ki4GChxicQfrozMefpG5ZRPV1z7SnUDQO3oEYOsEFp0j5I=@vger.kernel.org X-Gm-Message-State: AOJu0YwQwLeKa1ZUMuMmz1cmylq7B7gojSa1NZATxcboBxvUHkqSE0AP RgZFW2FVRQrgi2rFGTzNDV9qsOKYqlWMuIknKAR0PsHPNKpnAUCOqVn2VJ8EwA== X-Gm-Gg: AfdE7cl/ehTvMrOXQ4R5HrhLWf6CG6TFBhHngqHWz3J0l/mEZfb4i72kCQXCKeDn5aw TSJmSNPC5QCTacxbSfbgNsZgr0lXOGqGnBsCZHxC5aO3icE3qmkSLkV7IcGsEu9UiFX43O20ITC oqYtN01smXgEniO4mHJNMNGCSVug6eizYDhTm/beXMwuhOyOIOR6pU95iCfT0t9WkALDS0Zaagv pCZNPKiMsurP4s4cFDprdM7JN8eHIFVWCxtoYXYMh+ICP2mJMB27nbVZ4ecKr8oJjuRWfQPBVT7 jYDYIrS94V6UDsnVEDdIYlxuv+zgZvXthoWhHVHCQz4EQtW4IUT/S8AJyTilaVf3OSD1ZkSHIl+ lAtoJ6OREfScDGj6nok3ueHWoT/s6KURM2UF4YR9RR/MElRTwNsPRMlRQuIXOwHeS13J318sYxy OXliL48dWo18YOjbAI3lTjxErmbh3zyuFGB+5afKOXMCBnKmeoztrtMuZLScGPB/yNEIW2P/Ubj IGyBT07FF/9fNZjw9h6W7X192DLudrcLbdnD2mGZe5Zi3OssaFMMDsVrnJoEXlcyA== X-Received: by 2002:a05:6a21:9203:b0:3c1:142e:762d with SMTP id adf61e73a8af0-3c34d5299f3mr7430640637.1.1784078081000; Tue, 14 Jul 2026 18:14:41 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3c1f77fsm10621994a12.32.2026.07.14.18.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 18:14:40 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] ata: sata_highbank: use devm_platform_ioremap_resource Date: Tue, 14 Jul 2026 18:14:38 -0700 Message-ID: <20260715011438.1274211-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded platform_get_resource() plus devm_ioremap() sequence with devm_platform_ioremap_resource(), which fetches the resource, requests the region and maps it in one call. Switch the error check to IS_ERR()/PTR_ERR() and drop the now-unused struct resource pointer. There is a single IORESOURCE_MEM resource, and the SATA PHY registers are mapped separately via of_iomap() from distinct DT nodes, so the region reservation added by devm_ioremap_resource() is exclusive and does not introduce overlap failures. The mem-based ata_port_desc() line is dropped along with the resource pointer; the remaining per-port description is retained. Built for ARM (drivers/ata/sata_highbank.o) with LLVM=3D1. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/ata/sata_highbank.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index 3421039f4bae..a0b6e197cfb5 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -455,7 +455,7 @@ static int ahci_highbank_probe(struct platform_device *= pdev) struct ahci_host_priv *hpriv; struct ecx_plat_data *pdata; struct ata_host *host; - struct resource *mem; + void __iomem *mmio; int irq; int i; int rc; @@ -463,11 +463,9 @@ static int ahci_highbank_probe(struct platform_device = *pdev) struct ata_port_info pi =3D ahci_highbank_port_info; const struct ata_port_info *ppi[] =3D { &pi, NULL }; =20 - mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) { - dev_err(dev, "no mmio space\n"); - return -EINVAL; - } + mmio =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(mmio)) + return PTR_ERR(mmio); =20 irq =3D platform_get_irq(pdev, 0); if (irq < 0) @@ -488,12 +486,7 @@ static int ahci_highbank_probe(struct platform_device = *pdev) =20 hpriv->irq =3D irq; hpriv->flags |=3D (unsigned long)pi.private_data; - - hpriv->mmio =3D devm_ioremap(dev, mem->start, resource_size(mem)); - if (!hpriv->mmio) { - dev_err(dev, "can't map %pR\n", mem); - return -ENOMEM; - } + hpriv->mmio =3D mmio; =20 rc =3D highbank_initialize_phys(dev, hpriv->mmio); if (rc) @@ -537,7 +530,6 @@ static int ahci_highbank_probe(struct platform_device *= pdev) for (i =3D 0; i < host->n_ports; i++) { struct ata_port *ap =3D host->ports[i]; =20 - ata_port_desc(ap, "mmio %pR", mem); ata_port_desc(ap, "port 0x%x", 0x100 + ap->port_no * 0x80); =20 /* set enclosure management message type */ --=20 2.55.0