From nobody Sat Jul 25 18:53:28 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 326EF3191BB for ; Wed, 15 Jul 2026 01:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784077941; cv=none; b=c8pGyjsRyOHWrWFabHtQFGDVcWN6dbEazxlifk/eTnTE301qlpaXFrkX1kwyNAI1X5X9XNkqJB4cy3WAmZ6YsYaGB46I2UGx/Kb+O+1cqpqhG0e8sv6jhuUslHnkwFalTiBrHjHwWBVLoPr+X4On6obwmhqjdpJBH614VVM/BzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784077941; c=relaxed/simple; bh=Y0hr3eibh9wzp7acg7/DbBtlU/G4AyrRZaiGVnITVR0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KudPTlmwlD/OPHbAPvSlpvdD4kLAOS9z0abaeSeXswMN4tnfLLc2UdfNPB5ieDgPhXtvC2Fr1NcEmkOp4HOdcRbVTtK78T39UBuSDGnZPTUJ1YiZchUru0/5xb/CcpeqYHkOcVdaV05gg/W5NgYyVs2nL6XxddnQCQsclwp956A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LnIZg6Qh; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LnIZg6Qh" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so5085499a91.3 for ; Tue, 14 Jul 2026 18:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784077938; x=1784682738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lCUYlxb6BsnAbaXQaOLOynpXjnyMHB9hBKlRYLAY5As=; b=LnIZg6QhNGTNvz0CwltbMeg1McRYXE/Fs4Qq4hjy4G1Ur0Oa0nbdPMUsVOPUahHObK KNLFNhkwS1NCslR/XUvqzXlCndtUOYlgz50+VLqCsew6r5dVD7kW5kfN+xeZ12lhh9cQ uNkc0m1rkhLbHuPEBkC9MFgygG0tACcBgRYuErLAU+tyHxR1o3Tq6buKntPmKQjn2qoi 4TAXwsX98wedU1/udV4+cCAiCKFzSDqClx8mzc9RdQIzVN6jC6M/HbU+FyznCWqSnvx7 Clq20F1X9L2Hu6+hVM97NtS7r+Fcpgyb5NCyP2VdzUbvN6WTkvYrf2X/KEvKVfPPW+AC aD6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784077938; x=1784682738; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lCUYlxb6BsnAbaXQaOLOynpXjnyMHB9hBKlRYLAY5As=; b=KiQ+GVbr7BkzwEf0Phor2WswQjBBTO2afKfd93dY542833ZJkK3fVbStFDPDU/OJyK X8JK35OL0wUeiqBp9dFLX22XxFcZYX/9a1gWnYuHnLG8h7GVSVj+H6tALk43Npl5+qMW d7119o+d9AMut30NRMEqixefuit/1Cob1O1hCPUz/eb6CWRWWTD+i/qMbnCM4BMFg4hJ W9tZoZ4e71yuuUqzQBMASVucfyEiuGvicqNcSMysTxNIk7wHZC1kVa3A7F5fPcJOEuWE TVBEhCmRUuUxlhm5xWyItqajNwqpWZGW4TI8N31ZsbWX5WRi+02qKA9w89XbGmUm1/ed sRUA== X-Forwarded-Encrypted: i=1; AHgh+Rp+5zcTbS5oVN63LvLwq/3jrrOzmgGBOjy1YbyeQ6et5bfKIhPuvg3YMnhk1xSsY2Z08dRGKPrtLufGznE=@vger.kernel.org X-Gm-Message-State: AOJu0YyQQeRnuUn4d+gnCoT9zBPsVOuv0SWIDQB5GnlcN6Ypvh9al4kv 4d4x/v3X9jI5QzuPiEUorDqzYp7T+e1RPWKeAELrCnXJvhUfyVWgQPSA X-Gm-Gg: AfdE7ck8xfjnPiv7KBRnWvRbAYIWysHbcH9UBJzYTO1vPfwoeRl5xxnQgneh2ASHOSS kKXew9iui0OFFyhtE5ZaY0935Uc0X5vs03VnHeZOMyXEdp2ZW2QMS1WtP026ddweut9vAkHUBmO /H0JLrYMaGYvUM6RoDxbHbOqA55/l7yOKGpFb6vI48sz2Nu7ewrvsjEq9tYb76eZZka7j3jQ6GG i3gRcZyL6diLcV1cA8xiRm/AOeyNKjNnEKhHsp+kUmN04ORZj4rZx+nxdhFSDXgzNwMayJ8Q7Hs eX34ytyMFjHAKQWw5qjqlanWOKkw2vyv33IrY9R4B6mqR+C+JdcrO/TWU8Ug2dsGEy5ZmyWWenJ 8Lsb4mei9x1OD0Qr/rR+inykFAsN71L051TyB3v/r/DH/vs/zXPsQhWtxqpdmM/D7Fyuul7K/qR I37RMbXFCJjYnXjDgZ415dOkx0CUWjb0w2ASqeF2wU3WaSiW5l5xZcUiXWF+3VgSUaIYfxy3x/A vFKqaQBfeiP8fBE7+GZFjWnRLaVl36xdwhXkcm0xqyf1Hvl7Etv3UTKgWhb3qmiyw== X-Received: by 2002:a17:90b:51cb:b0:38e:7eb:d07b with SMTP id 98e67ed59e1d1-38e2a06179cmr845415a91.34.1784077937648; Tue, 14 Jul 2026 18:12:17 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e1730accesm2235481a91.15.2026.07.14.18.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 18:12:17 -0700 (PDT) From: Rosen Penev To: linux-pci@vger.kernel.org Cc: Kunihiko Hayashi , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Masami Hiramatsu , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org (moderated list:ARM/UNIPHIER ARCHITECTURE), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] PCI: dwc: uniphier: use fwnode API for legacy-interrupt-controller Date: Tue, 14 Jul 2026 18:12:15 -0700 Message-ID: <20260715011215.1263935-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert uniphier_pcie_config_intx_irq() from the OF-specific to the generic firmware-node API: of_get_child_by_name() to device_get_named_child_node(), irq_of_parse_and_map() to fwnode_irq_get(), of_fwnode_handle() on the child node to passing the fwnode directly, and of_node_put() to fwnode_handle_put(). Unlike irq_of_parse_and_map(), fwnode_irq_get() returns a positive IRQ or a negative errno and never 0 (it rewrites 0 to -EINVAL), so check pp->irq < 0 and propagate the error. pp->irq is an int, so the negative value is preserved. Drop the now-unused np / dev_fwnode() locals, since device_get_named_child_node() operates on the device directly. Built for arm64 (defconfig + CONFIG_PCIE_UNIPHIER) with LLVM=3D1; drivers/pci/controller/dwc/pcie-uniphier.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/pci/controller/dwc/pcie-uniphier.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/contr= oller/dwc/pcie-uniphier.c index 297e7a3d9b36..6516264fdfc1 100644 --- a/drivers/pci/controller/dwc/pcie-uniphier.c +++ b/drivers/pci/controller/dwc/pcie-uniphier.c @@ -262,27 +262,27 @@ static int uniphier_pcie_config_intx_irq(struct dw_pc= ie_rp *pp) { struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); struct uniphier_pcie *pcie =3D to_uniphier_pcie(pci); - struct device_node *np =3D pci->dev->of_node; - struct device_node *np_intc; + struct device *dev =3D pci->dev; + struct fwnode_handle *fw_intc; int ret =3D 0; =20 - np_intc =3D of_get_child_by_name(np, "legacy-interrupt-controller"); - if (!np_intc) { - dev_err(pci->dev, "Failed to get legacy-interrupt-controller node\n"); + fw_intc =3D device_get_named_child_node(dev, "legacy-interrupt-controller= "); + if (!fw_intc) { + dev_err(dev, "Failed to get legacy-interrupt-controller node\n"); return -EINVAL; } =20 - pp->irq =3D irq_of_parse_and_map(np_intc, 0); - if (!pp->irq) { - dev_err(pci->dev, "Failed to get an IRQ entry in legacy-interrupt-contro= ller\n"); + pp->irq =3D fwnode_irq_get(fw_intc, 0); + if (pp->irq < 0) { + dev_err(dev, "Failed to get an IRQ entry in legacy-interrupt-controller\= n"); ret =3D -EINVAL; goto out_put_node; } =20 - pcie->intx_irq_domain =3D irq_domain_create_linear(of_fwnode_handle(np_in= tc), PCI_NUM_INTX, + pcie->intx_irq_domain =3D irq_domain_create_linear(fw_intc, PCI_NUM_INTX, &uniphier_intx_domain_ops, pp); if (!pcie->intx_irq_domain) { - dev_err(pci->dev, "Failed to get INTx domain\n"); + dev_err(dev, "Failed to get INTx domain\n"); ret =3D -ENODEV; goto out_put_node; } @@ -291,7 +291,7 @@ static int uniphier_pcie_config_intx_irq(struct dw_pcie= _rp *pp) pp); =20 out_put_node: - of_node_put(np_intc); + fwnode_handle_put(fw_intc); return ret; } =20 --=20 2.55.0