From nobody Sat Jul 25 17:35:03 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957B944C66E for ; Wed, 15 Jul 2026 11:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784116544; cv=none; b=IOtrlHHcOxiRf7/zFEjR9fvm0c07HL3L40mq+5E644tdohOaw5eZIpf6yHGYoJHWaq0vM+p5mRBbQm67VqI5TAIOKXkwRd7UotSju7O3S/SwdlU2hJgiPaqV/81hSQlMUSfnxDxM9dxHzVEGQychXpaYdj42OdmS9yiEh4t9dNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784116544; c=relaxed/simple; bh=4AQ54cmWPnFr+3twy3tWFaNtgWbMsdIwWCHjq4Tfy8o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VquB7gA+pMvRBOAJTaJCBQkv16hOLUgnYOFGDbMSCtwTZCz8Ucvg8i3/gMzgSr1jYihe/BzQQLkFWF/4GotFhmREheHnx9FyixR5iJ9YYriqxTYfFyFEEImb637r6WwdHPfWIb/nONaOY7vH+7MKTi0I17zGk2Db02Zo1lhQMw8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iJxxydr4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d1p5T6dA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iJxxydr4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d1p5T6dA" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66FBcqEO523524 for ; Wed, 15 Jul 2026 11:55:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yofOFhOUZ2WUf0mVwglBwOGTWyTf8BugNAcaGQjT+eA=; b=iJxxydr4g2n8GI1W /L1dnOmQJ5XK0MOqkPemV1kPlPlgkZ5mqObSbGD8oE6fdQQPUv6wcl7zMgwCGXXh 4gN3pZMnZjatSuRqMI8pp2az50cLbA6tCK05AKzEDuqOpD6x2czdD9xG0CDiNMbE Ad0mzfRsX1OFLgRw05eSAV2XVC9g8mjatDq5daa1RfX+FMcSefFUxJWbDsxjX3B4 le5wpgFf+RfxIYhw4yo55KFwWho99fEMRlnrv7Da5XOErhYVSB3NUfJoM46pkwsd jzXPT4C9Ji0gHzzUEm/pa57H18WINsC0ALgkXECP3ynu9QimzTUBsionGPGkNhtF 1NWPUg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fe68wrxa0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 11:55:40 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-381abcccbf4so2113765a91.3 for ; Wed, 15 Jul 2026 04:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784116540; x=1784721340; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yofOFhOUZ2WUf0mVwglBwOGTWyTf8BugNAcaGQjT+eA=; b=d1p5T6dAPWOibE4Voj5s/7cFy5XvAYeEP9pOpgmagRxS0Ugx1bZrHkqRwVrXbi2zZg I3nufVzdKLq+Yh1S9uetNYjlrmvcViIppZBfiVbt5l1KdNwUzoi4FEIJcqutpVbkX1ZL YiuvVdwtkBQv/gp5jFxBQnKLo9sJsA2lEdVtJ5Kh+7Hfed5xSwoPwEE/skx1R4NcbkF1 6D8U5RLJg18FVmGiONLa3Fk6VoBlfHW0aCdCuvpXz5M4AkZft3kd2t1l2i63r56vmV0M xIBrRo9Ffr3KPyy0fI/oNdRdIOZSqMCztg2ekVRiDZK1nZjMdNpPUb1mHqvOD4Wr4z5r vRpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784116540; x=1784721340; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yofOFhOUZ2WUf0mVwglBwOGTWyTf8BugNAcaGQjT+eA=; b=US1soGWx8/FFY8efwK/iHgL9AD2iyUjqzEAsw0f7tqivyb1T41nahdN41eCRpHg45W Ppa6RhWGfhwRGcmA/HgfWCQY3FkqgCB3TCEpXHp1C5a0GSKw8lXdYdNw427/pZuUTogY kWvekpySQ/kdo5o+5qRexWqFpnYd/dUZdWW74GSarssLw7TRDq60iuvM4DkqsnHeLdb9 hs/MlyQL6PxNd7ddZonKSdJjevaNxaFJkFpE6Gd+Llc6CEtjI1ay6hXb8gTN+NfL1BSG 5WMNaART9RCvdOhTG5nJDuIsT5z+zyijUthmTSq1XK1sxSkTYsy1drWbljMkbhQijUus LOVQ== X-Forwarded-Encrypted: i=1; AHgh+RqbyF8gala7RjXeRu29exFWji5PbzC/nGJ94GeKAEDzHZTOHF/E44J8qnNgSUh+tMEmKq0GHxdz3YGui5w=@vger.kernel.org X-Gm-Message-State: AOJu0YxDZTW0wRP3p7k4Lr0espa2wVm8NcaujYplQImgfmVyWWCSE4Q+ KaMHwTVxHqQs6wdp7CFcrKDeynEiFDJadqldIaBp1MiQu2QRCiXBup/L5QU3/Crb59PIv1n6VHK qHoIY0EdV4J66QPoHdEDyoa+2dfI71w559NPKe561xUc+8jBMBdUZM6sgrN2DTEPfu88= X-Gm-Gg: AfdE7cmuq6cHKOA5V6ztYajG9WfRllLDV0swFe7yA8QztqrgNvd6AVUMDdSjysSVHQ9 vJfuCYUEQSJ5nN6ZSxvViVT2bXfDd4AROVBChhUES7Udl00E+6WgqgVH8NZWTm+eQkiqNKNX/ak T+EU9+XAS8OXB12gQ0Vqe3q/Y36h/GzCi+gc31mDoStmw3NyfpAT+htSUXB69nLqJS2LAqfp5jf 7n7j9MMMCQScyZ+zc0dLmygzC7VI4mlOn4Wo/R7BV08WytuPKCyUq+YzYMTRPBh+noCDpCpG1h4 v7QMLFuj5JTbDDGD57sjuyOZGH0lZdd60WW2Kg1QlBXNG3scIo4XJtZ9QE2Itheu5V29tER6YHW LtRZETR+o+3VSqSc/bYRStnzkESEUy+GYu6G6wUk= X-Received: by 2002:a17:90b:3ec7:b0:37f:464d:ea38 with SMTP id 98e67ed59e1d1-38dc72a4995mr14964169a91.0.1784116540050; Wed, 15 Jul 2026 04:55:40 -0700 (PDT) X-Received: by 2002:a17:90b:3ec7:b0:37f:464d:ea38 with SMTP id 98e67ed59e1d1-38dc72a4995mr14964151a91.0.1784116539633; Wed, 15 Jul 2026 04:55:39 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e5326c0sm870683eec.11.2026.07.15.04.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 04:55:39 -0700 (PDT) From: Ajay Kumar Nandam Date: Wed, 15 Jul 2026 17:25:13 +0530 Subject: [PATCH v2 1/2] ASoC: codecs: lpass-wsa-macro: check clk_set_rate() return value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-1-16ca64c2b929@oss.qualcomm.com> References: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-0-16ca64c2b929@oss.qualcomm.com> In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-0-16ca64c2b929@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Kumar Nandam , Konrad Dybcio X-Mailer: b4 0.15.0 X-Proofpoint-ORIG-GUID: uIvcNWuLjc6gn1c82EiABhZg1cj-O-Hl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDExOCBTYWx0ZWRfXxRofE/54iRuD hw6RdAhX44bQVJteuoZWrQ4bgRYf3yOmHzP+rzSa3jvDL+DdzdqRZsuPgbDHrqAONwaNbCGF/Dv O0AVSZf7kPrtdEFGX7E1hcGtdneO66Z7YGaMDlOkchHdnB8Z5mIoJLjhgTthkN4BVzahKiLQEJi u8PEpz18qPgJZwuTSNnEEp1G6gC3PPpM+rHcgFHlXj2FJPwsKtC7JP3I5R564PBWPR+DbBG1Gck EdPuYSXt1CFYIJXT+s5npdWiveFyJ3fFkiAgeo+kkrlsGj6iEee+R8hm1j19iT84O3YBVCU3uGL uBfU0vtOg4uwFFw8Tnp/TMGVdnm/kp893CNuCiNO59quvHxmFDyK4aIDxjVUvkm8QWfcdlzlwz9 q4vEy0r+sA7q7Ratlc1mY2NOpmgvtJodgfkK9Idc3pm/LOq3nn8JsSVYZW0FRCWeypVEqWrNaAG V58MZEsYoXU3lcPsLcQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDExOCBTYWx0ZWRfX8eQF75CtiDP3 aghmRfno5Av995b+uKqKpRx4fRmnmAuhqCeQl7jJ6/zV9z7ezWdF3OYYzaPt/T8g/Q3/9Qbq7Oz 5sQbUUh6HwwbStP3HbynK8RQXX+6CYo= X-Authority-Analysis: v=2.4 cv=LbgMLDfi c=1 sm=1 tr=0 ts=6a57753c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=bBduwNICHDKIrEYp1ZQA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: uIvcNWuLjc6gn1c82EiABhZg1cj-O-Hl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150118 clk_set_rate() returns 0 on success or a negative errno on failure but the WSA macro probe function is ignoring it. Check the return value and bail out of probe on failure. Reviewed-by: Konrad Dybcio Signed-off-by: Ajay Kumar Nandam Reviewed-by: Cezary Rojewski --- sound/soc/codecs/lpass-wsa-macro.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-ws= a-macro.c index f511816aa4a0..fc9e0a37c042 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2773,8 +2773,13 @@ static int wsa_macro_probe(struct platform_device *p= dev) wsa->dev =3D dev; =20 /* set MCLK and NPL rates */ - clk_set_rate(wsa->mclk, WSA_MACRO_MCLK_FREQ); - clk_set_rate(wsa->npl, WSA_MACRO_MCLK_FREQ); + ret =3D clk_set_rate(wsa->mclk, WSA_MACRO_MCLK_FREQ); + if (ret) + return ret; + + ret =3D clk_set_rate(wsa->npl, WSA_MACRO_MCLK_FREQ); + if (ret) + return ret; =20 ret =3D devm_pm_clk_create(dev); if (ret) --=20 2.34.1 From nobody Sat Jul 25 17:35:03 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91D3944CAD0 for ; Wed, 15 Jul 2026 11:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784116549; cv=none; b=sg+GgR3Ut7Ws5gPEIzu9pVWuHTLwBkAKivEEbGhFXUFPfXTjUcMMh/rXBPCK9UWQpmdFLv/l2kXBGKL+PsmAG17LpFg8uPdI5n3PFKxOFynLtDgI7ZNkTxiWuWVaZgWzYOMiuRf8GReAC1yCKXh5+U1/Mh0me5O04i0+qPgVGfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784116549; c=relaxed/simple; bh=tlrqHG6Scd8WESdDMOGUbRo9WK+K8RvG+IkQ0ktjTFg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BQF3tThki6BToCQ9IJACOA8ndGQpGAiOohlSXjx/0FGXQm5PQu1jNjMoiffWYB2Oq6GalHCcLSwWf1lCUHeLQM1NXkBY/Y9BdnTVyq4iCBbDGWmEzQjv52nnRtcI1q/avm2V1/knz65CukOa5jX17Ye4zDMyABvfsP/qoR2AKkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jQDUitUq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YiireASH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jQDUitUq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YiireASH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66FBdGlm3579547 for ; Wed, 15 Jul 2026 11:55:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V5ZbptZa375DFz1qKm2R4NvNcPPWcrq8OiKOVg+aw2M=; b=jQDUitUqiuof4D1t efOaOKn4ORCsNMSD/LAUWzVaUIfRHppQtbWa2m6W6lHkjbuK6kd8uD7cdon5hCq6 t+0ytCIlX4vhLDGq8XdEhWhrerlzTDKQxdPZGUY7k/NcD/5tbbAOPEfPSThchq2H /cQfe4T7EzeRImBn/w6v/+0h3+haRtHWM9ipXaoaR+hQ3a/SOdd3CbOQH08aB3dO qUgw+4pPVu51Y/HjGvbtI25NRxP5Im3MyhmO9pkv4XkyKg70X1jFR0h+OqyYuxSC 3P/LH6L3ngbc5Ssr1+ovOz6zIoQZMlAOPZNyguHb/kI18IUhF7VMwYx5OWYw58Zl 9MN1BA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdwk32p71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 11:55:44 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38dc085b0a7so7593221a91.2 for ; Wed, 15 Jul 2026 04:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784116544; x=1784721344; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V5ZbptZa375DFz1qKm2R4NvNcPPWcrq8OiKOVg+aw2M=; b=YiireASH3rkxLaBZ8KzCjLsLuOLSzQqsqKJRkt+CBdNqx8UoNT5wTTJLnOUl58GUV/ m+XXn7YWAIE2HJ3PervZc4O0ZMZAiJw78UqO/ZolbAaG8LJOcLp52febYlSmYNmyw196 PX8TyjHYlX8paPDa1bkQp50nSkUmFybctIJ7DM9Ydo3BkZGUwcT8lzWGcZb0c/jgNKx7 M3CTe0Pqho1m8y8Jj6wYWW0wN6F0HBzJkzfrl68c7t7AGWAIZKvo9WtldzryQmvEgMOy pbry69QFH1K92Mnkz8U2eYl9NgcCPa4vO9mAfjQbiBRDBEBJl/BRfZJmUK2+JmkiOgEW G85A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784116544; x=1784721344; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V5ZbptZa375DFz1qKm2R4NvNcPPWcrq8OiKOVg+aw2M=; b=lEycZccOyKSHmHNhhCS2bZRHalmSWcHkLJjN7QnrvfYOhbbfDSHMinlZNoTa7RyTLX qvTpuYisDQ+iCcUf4D/vv5CwO7UCOakmAfBcONstPsyxtwV/Yh4TVjeiD8nh1sfepbK7 2G1YlCgDKFT9zRomlW+53LxY/R+s/O2cPHmfU6/j8WmfVYTL/6DL7JsOyneX79haulbg df0zdkiQGW2wT8yBqGVgU9uaNmGORijhvr4p5PDbWABH8OIy81xOLN6M8Jsmd1DD9DX9 0Sb5/VYUQppI2dpO2YUGy4DkNulX3HXnrqiSxSmIOPLkpfXEDnjAaPQgGWcsUbeApgeR jPZQ== X-Forwarded-Encrypted: i=1; AHgh+RpLakqTQLz4fH7AxVaqTiqlGrswwdZ1TreIlPiEvLNnKXKPjwZgmmnQKJrmfxG/D+ORGsWggNrf5ypylv8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2sFeY9EHG1j8U863BscNMERigpXIRgjRx9XnoMs/1Nv7J1AFf TNECLreSFjDN4VLpTUbv/+IoYl26odNFR7f/aeVeduPdJoeN950LzpVrPnCTWtOageZOFBN1lVx u/CEknDx/eV1jrEIQZVImZSjXMxUVqfDmW88N9P8ddGTkcqN9xFlxpQx6I6ce1OeusVs= X-Gm-Gg: AfdE7cnefi0x3E5n6IPEaT9cuOoyVeVvTsP4L8U2aJe4C4suybHVGTN3Wp6jFBKX8JU 3wgUgYduDBo8DLFlA5QVJ7fZCFoayzwfG8f3NuIVdqEN7vXMJ09f+V482ciGJ0PtZQxbhrH2AXB OctLCk5pojFSZoAKL2vOuLTJ+OW6tilZGaEg1azK2wd9PznPzdbFfnG90UiYdTk+YxqeILtLGWd av2j6RpS185LpMne8oaU7c/wjoujjdnVYUu1u+SGeMcJ1yraSnJ8HZxlnldInVtwW0OEZAKKrDD eiJdpiXNcPMDp6KT3VYoDp61Sr8CBtkvXdB6hIS0bYTZqDoIBI0O5BCgkoNydbkX8htNSYGTBcu 2gaZtJfaLXY21dxaLPZza891ow7PHe0sXAIR1DAg= X-Received: by 2002:a17:90b:1c81:b0:384:5dbc:cba5 with SMTP id 98e67ed59e1d1-38e2a01cbf9mr2556120a91.26.1784116543742; Wed, 15 Jul 2026 04:55:43 -0700 (PDT) X-Received: by 2002:a17:90b:1c81:b0:384:5dbc:cba5 with SMTP id 98e67ed59e1d1-38e2a01cbf9mr2556085a91.26.1784116543321; Wed, 15 Jul 2026 04:55:43 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e5326c0sm870683eec.11.2026.07.15.04.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 04:55:43 -0700 (PDT) From: Ajay Kumar Nandam Date: Wed, 15 Jul 2026 17:25:14 +0530 Subject: [PATCH v2 2/2] ASoC: codecs: lpass-va-macro: check clk_set_rate() return value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-2-16ca64c2b929@oss.qualcomm.com> References: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-0-16ca64c2b929@oss.qualcomm.com> In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-0-16ca64c2b929@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Kumar Nandam , Konrad Dybcio X-Mailer: b4 0.15.0 X-Authority-Analysis: v=2.4 cv=Yc6NIQRf c=1 sm=1 tr=0 ts=6a577540 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Rw-3s851JbwrW9yZSY0A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: ySVEO7vh7a0ItJ8qWnYpbiaUFX85s__t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDExOCBTYWx0ZWRfX2DHmSr/rE4iY 6aLWWTc+8XYl33W0YAtT5BtgKEj0zr/PEcXN2dCogZ+HfVlmrnPGp4MX15XQLUFsSunnaRlc4TZ GkJL2oKj73WJAXXh/kMPsAdYbDQff3Pk6JI8ApNDwFD1JU7BdEJNpUiWxzT7VltfdHcDq6RsiQJ /yexq6tkz2RtVcKmhlCzDbaQBb6at3bXku7uUW3MLdJcs2sMNjAZGgN9GQtHrrN/sci2aI8KQhw U1OguZkPYZFj8fjQutj9EmGLRM6aCAe9GYWKLrLUoeNb9M3GoW8je29WqtRpopvvwZ3LhaAur17 j0kdbgmnTeX72Stcrz+R7CCBVTJtf0NSMX/O/AHKt3Hu0dOBXdwTWLu8ACVPoY9tsqNt7/sFOJu bjlDj7byFxTQJXawawbSbyqWByjKuWBzQEzqskSND+tEgtaraXFJSnZeY1aKwLGobqcVhauUaY3 bVwOZ5DUQzPJ9iZySfw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDExOCBTYWx0ZWRfX4uezlQGSm5wS TaaoxmHwK2uR29mMcN2qgkVZY2mFe6/KbtdDMF2rB1OEH6jv++7C13nqH4bwDkPBNIxwNHb1rmM INZs73kmiayJLyyeeQfooarRRa2W+W0= X-Proofpoint-GUID: ySVEO7vh7a0ItJ8qWnYpbiaUFX85s__t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150118 clk_set_rate() returns 0 on success or a negative errno on failure but the VA macro probe function is ignoring it. Check the return value and bail out of probe on failure. Reviewed-by: Konrad Dybcio Signed-off-by: Ajay Kumar Nandam Reviewed-by: Cezary Rojewski --- sound/soc/codecs/lpass-va-macro.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-= macro.c index 946051698420..dbc5795b9273 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1605,7 +1605,9 @@ static int va_macro_probe(struct platform_device *pde= v) va->has_npl_clk =3D data->has_npl_clk; =20 /* mclk rate */ - clk_set_rate(va->mclk, 2 * VA_MACRO_MCLK_FREQ); + ret =3D clk_set_rate(va->mclk, 2 * VA_MACRO_MCLK_FREQ); + if (ret) + goto err; =20 if (va->has_npl_clk) { va->npl =3D devm_clk_get(dev, "npl"); @@ -1614,7 +1616,9 @@ static int va_macro_probe(struct platform_device *pde= v) goto err; } =20 - clk_set_rate(va->npl, 2 * VA_MACRO_MCLK_FREQ); + ret =3D clk_set_rate(va->npl, 2 * VA_MACRO_MCLK_FREQ); + if (ret) + goto err; } =20 ret =3D devm_pm_clk_create(dev); --=20 2.34.1