From nobody Sat Jul 25 18:08:48 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E2F3CEB8F for ; Wed, 15 Jul 2026 08:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784104191; cv=none; b=qJIv5dcMNaiHA4PZyxqeTGSqRbuSMYOzfMhbN6AGKpAGNhUTDkhUDZVco+wUovGIO6J6k+lXNFUGYkQCgJUfN8oukBEi1ji4r7pUAbSto0RpBLI5QzeHK8YxPV0nYr+Ln89bsoMoHgqvfWLFedKb4lWHNJ+NDrKg20kkNjqb6gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784104191; c=relaxed/simple; bh=TXKndoG9/ZhPXg6naPWiyrq5aSp08ozw/Uehu2DgDWQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O2+Twun04sJxF0AmgUlnX83ZvsR32VzJq5jrwVKf5IkhgLbaXERfsb4RYbNVKtSVd7mclaClY+pF4UEKueeevyq1eOBL0qVliTqBI6i423UbW7mDN2btt+ZgaFh5lmQgfBO3VHv4EYbHHer9F98Y6gTZm6gBtIwhzc738xNYSJg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V7DfUdVw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H805WSmA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V7DfUdVw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H805WSmA" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66F3lEXn2373442 for ; Wed, 15 Jul 2026 08:29:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sQlEDvb65Bh/rY60bU1eTX6ID0Mrq0HBhxgNwXz2HaA=; b=V7DfUdVw3S4PKgIP S0NHF9DgEj/TzOzrll25oLFLA0W7XsGgAq+iTwKRYUmQ8ou04+1Msm4SHaH+ZZxF py4e0l9O3VeuX6YOpY2HR5DmVtCRGRI7mx7ot5OfoFCGIn4w/W7bhGzBol5jvzTb Q1u8p6c5fFlQuET+1/tsfd98AEMCcalYDC9CBym+6hBV7Z5VFDtqWNyTgV08sMLc tJN7ip6qdIk6Dgu7ZwXZAxFEV3xr70kreHbojCpw89poY/5rejp8Y/Xo9qNX3dGb 24ExKjyYXq/EJHWR+VCg2kIm+HTQK8ps8F5VA/UyMytD9i7/jDyMGy9YVTmroVWk Kr4nfA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdmkk4349-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 08:29:44 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cce406883eso16826935ad.2 for ; Wed, 15 Jul 2026 01:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784104184; x=1784708984; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sQlEDvb65Bh/rY60bU1eTX6ID0Mrq0HBhxgNwXz2HaA=; b=H805WSmAwA3F95csJqaab+9Xb3XOdxegmvWyE9WHenVI5eJZEV7EHS/zqYzm4uvOfE NWMWke7STYnwAu1Cn34jMG05KQ7qD8x5mlurdmp19dFcm3VfCcq0j9jjhcvPLJFwxFNL 7x6mjqjhhCiO5J7VSo5H93Yih0h3urFfjDRL1E0hTa2V6SvBan2U+j7ijNn3tMEPpa85 BoNPLF0Bs3fDe5JP8iF30ltayLdwPwCW67oyWx6Q1OwYQ8JRqBER9pS7+9MWX+0Cv8wJ R9tlHrvSph/qiWyrBgkXsX8inZ22MVu2ma6BAnnXhQEQSBmaaZeIuS1n0qrHdTfMd5O8 iQuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784104184; x=1784708984; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sQlEDvb65Bh/rY60bU1eTX6ID0Mrq0HBhxgNwXz2HaA=; b=k8WJghWUhJ+sjxfyVErGgXJ256t3z3Gs03GUdUmzDlsJw7RjQODf31qnIoqN18p9F9 0CeXy2g5puhvw60itPCd03HVCbQPYvVteB48NYSHrJggs1FR/44ZRfl7igKge3O/Vsu9 +qBiBBcN0A1jqJxFhb5dwWFt4ojmhWoFdgoL4q3sG8lakbTpzlVVePpeEkg3w0nl2COS Cj+cyaMw5Qmc0G+eVelE3onWjLRxIo5sW49s7lqFWKmHXx3yCuFp2NwbNnzN8qVE0UND PyLX11g6D++z5y87xB1tNeRkLr1rc1uxQy45AOV5mUrkCSY3C7RKe8sMKyXDgsksbDFx M6kg== X-Forwarded-Encrypted: i=1; AHgh+Rqpo/rG+yOcnI044oTAdG7JMvTW2gr3S722r+Nf9s+KrgC7iQilUEGELgaIOdBt4ILzOuDYqvlYA3AN06M=@vger.kernel.org X-Gm-Message-State: AOJu0YxDiTVxuu6d1BmnOGWfQ0OLpvT6yekZiKjodghfJEesTn1fxwST Vt01TO3J4trZb57+N4MOYlKRgc2tpIaxX6C0LyB7JXVCtdwB9sQx+kK92n/G70w0HLSq62A4Vr8 YmJ8GZnY3Jd3k/9wmRTuoT72DtTsEZBx7KDLB2wSLi9PQ8DDvuXaw81BNwA9DnSQvfD2O1mtE2S E= X-Gm-Gg: AfdE7ckl9y3lD6LBZ2wXTGEL6ArumeJHo8Ap3l1eYrJ53hnIfsLP5aw+fdy98FghGOe 1beOjbqvA2zhSbJ+HMD2eykMJ6YGdx5I00jm4K+xeDCnPtxGt2JdAvMWQyG9xaugqR/kxOGQqGO maI2YQOU1RfLKJQTvDl74IxeusTbPb2GwgK/1AbuLK1Jn0P8Dzk7C9IBxl7sA3jf0owldBe/Wys 8ezrGdZpoDnKg//Q7HnKo89mtSPITkzZKUq5XBJgsOLRia+DTsDVSJXDw7gvGfvWuOBul1Yos6f 8sw/KhB7LgQ6Eiv7N43zSXQ4tf4h0og+KvST5Nnlf4Fr9BWgIXcQM93DjufW5w2i8ovnnnzJKmR K+gL0x231J81XDv7VCqGrUb3+v4IDr2NUyvSOn/4= X-Received: by 2002:a17:902:e949:b0:2c1:ea95:8297 with SMTP id d9443c01a7336-2ce9eae29ccmr149870925ad.7.1784104183584; Wed, 15 Jul 2026 01:29:43 -0700 (PDT) X-Received: by 2002:a17:902:e949:b0:2c1:ea95:8297 with SMTP id d9443c01a7336-2ce9eae29ccmr149870745ad.7.1784104183144; Wed, 15 Jul 2026 01:29:43 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb75fsm129260715ad.8.2026.07.15.01.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:29:42 -0700 (PDT) From: Ajay Kumar Nandam Date: Wed, 15 Jul 2026 13:59:23 +0530 Subject: [PATCH 1/2] ASoC: codecs: lpass-wsa-macro: check clk_set_rate() return value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-1-f0c713ff0b4e@oss.qualcomm.com> References: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-0-f0c713ff0b4e@oss.qualcomm.com> In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-0-f0c713ff0b4e@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Kumar Nandam X-Mailer: b4 0.15.0 X-Proofpoint-GUID: EuTWxNfq3Ec1o9zQLiWtktKjb5cY2tzv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDA4MCBTYWx0ZWRfX65oKiwd38NBH N2bAjaa7/WYiUQhgyxJlBFuEMXu4xvJyYNK2ESobz5XyKAlNtZMPz7KKBOf6N7mmHKaGT4Kw1oZ EVAadrV6G44Qx+6wIc8x45bElHL7apQtL5y58kzibcp4ABBQg6To6U4qJEIB5LmF8xWYSfPscol COKJo+mRdGbvebONC4GCGgaVk8tXWBlAE+tnY0qjSgJWcxN5SidNz1U7vgNyZZnzPbQoytUtBga hwPfMWpEaP2Yg/L/oLExLWrF9aTxVqRrlFcxFxsdq6XKitvzAnWSB2hsuV2hC9+AIXJMTrsm6CG kvhJ5AItvZcK+e/BJ9GldR/CTMb82mFVV/YmfJRK3/kkoDEaU5wCtbQNF4UKMnDQEYWBu3prPv2 dDVYT0LZjosf9Pn2V3HO5ewf52/2Ej3dLBBRqGkayAK+M/RFTJ4xMVqKy2JOnErD5exaxHZq3hx uw4UkwpxpTcYj4/6xcw== X-Authority-Analysis: v=2.4 cv=NszhtcdJ c=1 sm=1 tr=0 ts=6a5744f8 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=fYNuJulPh_gWck5KaocA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: EuTWxNfq3Ec1o9zQLiWtktKjb5cY2tzv X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDA4MCBTYWx0ZWRfXweOFlIEApZkr syyfBDKrqEHM69eb5mrhc+ujfu9zFc3nDICJ++nfYDIjZKVIDa1lIFPr18FEqyiCn5aGB34GHsH uR5olztlFRZ/QXIB09I5OUs3mj38H7A= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150080 clk_set_rate() returns 0 on success or a negative errno on failure but the WSA macro probe function was ignoring it. Check the return value and bail out of probe on failure. Signed-off-by: Ajay Kumar Nandam Reviewed-by: Konrad Dybcio --- sound/soc/codecs/lpass-wsa-macro.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-ws= a-macro.c index f511816aa4a0..fc9e0a37c042 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2773,8 +2773,13 @@ static int wsa_macro_probe(struct platform_device *p= dev) wsa->dev =3D dev; =20 /* set MCLK and NPL rates */ - clk_set_rate(wsa->mclk, WSA_MACRO_MCLK_FREQ); - clk_set_rate(wsa->npl, WSA_MACRO_MCLK_FREQ); + ret =3D clk_set_rate(wsa->mclk, WSA_MACRO_MCLK_FREQ); + if (ret) + return ret; + + ret =3D clk_set_rate(wsa->npl, WSA_MACRO_MCLK_FREQ); + if (ret) + return ret; =20 ret =3D devm_pm_clk_create(dev); if (ret) --=20 2.34.1 From nobody Sat Jul 25 18:08:48 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5C53CEB8D for ; Wed, 15 Jul 2026 08:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784104198; cv=none; b=LQb3emps6ozsZU4vNik7uO2sCJB5tdqPdCONBEAxvGN2zY6WBTBlc5+hI0yNmb0RBhrzRfNJXOXdlq7MkHSKL3WQPSkQltseCxLYTNSnuLTOMtxrJb4ECsoSkJoOOgHZDXS4fDOyvVeq7GImgslOx5Wp/DnJMyUAeS60tFhf/bY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784104198; c=relaxed/simple; bh=o4ARZ01tTH4LKxC7OaN73OKp7OJl5tf3fPsvab8XkZs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rWcvfEmSiD26wGCPX5PcxIJfpjgTnHvPa5z7Qi15JrH68w6f9EBIOi1uVM+CVi70uMFuEtORGGfLr05EgRsb1SwBSAV+opqQqkabMabrV3+T2MSyI4q8x0DSJR1NVsKbyTKueghBKxcCOSOyeO93ByLRwWmHFQ/xaDI4nmMdg/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CiWlGEiz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VQbLB3GA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CiWlGEiz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VQbLB3GA" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66F7vF3O007605 for ; Wed, 15 Jul 2026 08:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IApwrUwL0UHXKJe/ull5musLsDGYYHv2AUyfZVVBGsE=; b=CiWlGEizouFQpuOU Cout2IRecONlNqFVS5M6W/6jWv1ovgZ/lOKQSvL5UM4oSbPhci30WXyDhcZLB2WD I2Er+DwT3ksue517pyJ8t9/Z9LcjozDSRd0SmeesSJOm0QK+bjEHLk52Vw29iLlr Jd6Wztd04fEVY4EzDYywzP51uBmDBChmzChkFXEQIvaew6pV3tJMgR07DWpJpNpX NZefIc2wVTFsmLZ5uXvheSIBOfSuTF2HbbzhCz24YPMfU6wr47np5SgwCb4FaWsL z7wgTIqgmw/jElzyWihUu3Nh91aEk1G899+FeMwuvUxwjg2xdWCK8WdTd1vCYO9e DVib5w== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fe68wr44v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 08:29:49 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ccb6f6a3f4so30715855ad.1 for ; Wed, 15 Jul 2026 01:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784104187; x=1784708987; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IApwrUwL0UHXKJe/ull5musLsDGYYHv2AUyfZVVBGsE=; b=VQbLB3GA/O9X/RCv+BIkXXvqd1LRQ+MTRNK5G5SMo+0dmbM7UpHddL+Tze9a1E8G4u F7e9dJBNNGR4ckbDojZhI3//Gt8+9F+WrllHYoYPQkHIg8lEYmjqXsUUqSQ+g76aTCDg rbYEcm5rKePS0fzG5dRqHcNX+0oA02G5vvoc3YPRaP9H6o2WsYEZmxLshjpUqvpEtuV+ xw5c4705vvJiboUochjEPHEK1M9VrsexF6EI7Ek3j401/YDSfcdHrXUAYwQqWXBNNJKV dRLVoJgPVRP7XIi8YhC7e2WQz3229nUO84mWAuWUMSBkGKyVtFvgSnYvVwa9j9qyyahC BMUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784104187; x=1784708987; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IApwrUwL0UHXKJe/ull5musLsDGYYHv2AUyfZVVBGsE=; b=Wt2+Ht9y+I78aprNSkCCpLqZHuP6igvg85D6MOkgvzGelrjI9CJJRWrM2GG/1DxsFq Ejl/4xvkBOAVcsSqAusyLKkZnAwO5IwwgKT+GFFY3Xlzd33D680fNqvBDwqvA0XM7fCY F+2fGPF/6Mg81wSVEgICphw3SJYpbyFSBmZDoUaemj0XT8arSKdchrEVN4OQTD4VYDVs TNtAgBXgrq/qZ96PVbo71aztXgzlIwyObieZ7toPhamLfV4OO8gYqMJttyK65BCwOYMj +7VblafUqAC1YiPmyICpDh2EzaBTBq7PpC6gCSeYkYap5lwAVTNIN//wXSKHCjjHyt0M 1jPA== X-Forwarded-Encrypted: i=1; AHgh+RqNWJclMY6B+OAc8GW1St17d9nEMCN8PbCAHopr1/hE0tmwFTQELVXQj/JXrxmCCGHWpqMda+4/b0xSa80=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/hHzZD4WzSG+eSgHOQ1odxpJ5/oceo/Qy1dfyx6eNpW7TJxnF yqVmfjm3fVmRKcyafMK7uVGruvOJvg1W5pG1j1GKbEPRKugQeprz/SsmoReCSqVCKA4wyWi45l+ wn7+5AedcZKnELOS/bmoqba1R0sJWV2akN4e/htNFrqtuJzUzTKhy2D2KBoMqJVGx8wrXzAOcIa o= X-Gm-Gg: AfdE7ckghbnQxBCO45+sDWDdIhkiBVOH1NM14jhVP6qVMRZVFNHtnNOfr/UxjMY/jlF DoAS3Csjk7CxV5nNP1jfqG+0F5KpDbjd0iaU2Rx1c3EazBZ+a1/PAog1cra827KnZ/MnpRlwe/v me60CS/clYxT003q9ldcbnFIMsolDMavXYA/qR14p2BR2OVeJcD/EhwTUX/mON43BmWp9N59Gag UYZUlzem4B1O7nCTK+abxBX5rX+OuItl7J42/UMczbbaBpcbjxE6WIGfO2Wkq4P0h/nsGteA0yN 7zY3AmBhFHlPp+rLyz/biussHcnGvFQ2WytmaQNrPyubQB+4+ykxwcVJzMR17RU+w9WZmeX2Ft9 /YwU95kxtU8PIuKEuda3Sk/EAafXaaVYEXqadhd4= X-Received: by 2002:a17:902:f70b:b0:2ca:eff:ff58 with SMTP id d9443c01a7336-2cea17fa4e9mr157420515ad.15.1784104187173; Wed, 15 Jul 2026 01:29:47 -0700 (PDT) X-Received: by 2002:a17:902:f70b:b0:2ca:eff:ff58 with SMTP id d9443c01a7336-2cea17fa4e9mr157420195ad.15.1784104186647; Wed, 15 Jul 2026 01:29:46 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb75fsm129260715ad.8.2026.07.15.01.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:29:46 -0700 (PDT) From: Ajay Kumar Nandam Date: Wed, 15 Jul 2026 13:59:24 +0530 Subject: [PATCH 2/2] ASoC: codecs: lpass-va-macro: check clk_set_rate() return value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-2-f0c713ff0b4e@oss.qualcomm.com> References: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-0-f0c713ff0b4e@oss.qualcomm.com> In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-0-f0c713ff0b4e@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Kumar Nandam X-Mailer: b4 0.15.0 X-Proofpoint-ORIG-GUID: D4MnR7slHO2hMn2jmCK_HAk4KfxvWDzT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDA4MCBTYWx0ZWRfXypFP6oIJn4H1 jKhIg5esgyGtsffeC3owWtb9VRhdDV9tREzZ4HDiprSRX9E+9E9ZrpUcEWKrgPdgyRXU1pTZmoD /cejOdch5rsrO7+dlABCVLH2eGCKNbjL+XzkVxLOjifRw8cUJG1Qf6kkkc9onsd5lqk5MWo/jgq FsVVbA8OZa3FHJj/bRrG3VDzF8cudgvmyC+Me0o5cufaEDe8m80S/f1EAHb1BgYU2r0jzUvfZJe xL+2o/0eKlPs5j7q2XjYBQ2p0XWiCoNy8IBoqBCQeBXt+0+s9Jg+vuIs3ZYa7ol+ivpnJCkdEeF C6WyWMMVCgrhkmuBmdUwwnedUuxAS0C1zwfV0f9LL4mbQzGpg01mtz6daGY8hU72iJCVm4gNcFF mC+17jHdcqniAaoTK6G2dtoFbAVHEPxAcwGbzmFGVK8FkFXTZhR3CKUJdCBUFoerA4Erm7dwT/q YhoArD0E1IJHuqazDzw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDA4MCBTYWx0ZWRfX3Hm1lXHpIZiT tjl51ZXA2FdG3rzHPG9s65MDmUv7osuO4jFpSU80ma/5mKxZWkkyTWZGXjiqYe7OfT/o3gV9iYn SnqzwsUhxFJSHNTyO4v0tbGO0qL9uMk= X-Authority-Analysis: v=2.4 cv=LbgMLDfi c=1 sm=1 tr=0 ts=6a5744fd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=Rw-3s851JbwrW9yZSY0A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: D4MnR7slHO2hMn2jmCK_HAk4KfxvWDzT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150080 clk_set_rate() returns 0 on success or a negative errno on failure but the VA macro probe function was ignoring it. Check the return value and bail out of probe on failure. Signed-off-by: Ajay Kumar Nandam Reviewed-by: Konrad Dybcio --- sound/soc/codecs/lpass-va-macro.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-= macro.c index 946051698420..dbc5795b9273 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1605,7 +1605,9 @@ static int va_macro_probe(struct platform_device *pde= v) va->has_npl_clk =3D data->has_npl_clk; =20 /* mclk rate */ - clk_set_rate(va->mclk, 2 * VA_MACRO_MCLK_FREQ); + ret =3D clk_set_rate(va->mclk, 2 * VA_MACRO_MCLK_FREQ); + if (ret) + goto err; =20 if (va->has_npl_clk) { va->npl =3D devm_clk_get(dev, "npl"); @@ -1614,7 +1616,9 @@ static int va_macro_probe(struct platform_device *pde= v) goto err; } =20 - clk_set_rate(va->npl, 2 * VA_MACRO_MCLK_FREQ); + ret =3D clk_set_rate(va->npl, 2 * VA_MACRO_MCLK_FREQ); + if (ret) + goto err; } =20 ret =3D devm_pm_clk_create(dev); --=20 2.34.1