From nobody Sat Jul 25 17:35:02 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013045.outbound.protection.outlook.com [52.101.72.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09593CF212; Wed, 15 Jul 2026 11:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115038; cv=fail; b=Nzg9Iu2sRlBrgtZF9rrC0qg3PRU7vQJ8mIKMeOmXgtCx0SlcZRH0OP3zPFcTUB4FtQzGTkRuETOUDoZnwZVcnaXIE21bQ0feg+flOyCP61sBfgffAnJogtz+atAs77kBLxxzb12mWVF5x0xca0aKjckEpYl6CffCT+UH0xcbk/w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115038; c=relaxed/simple; bh=Er/3rOp/KX0QAh3cj3hkw2OC5kJ7Mn8MJ+ULbJXSuOI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mrCCoKITKyl6zm/Q9pbaqTBfi5lLvCeLIKqQdaHovIyoGDop1ds1mz5mreqmC1NBpz0ZsE3ef+sKVky1H/2g7WSe1/48ntmvJ4FlNIznn9QCCshQ087FIV3hudkBQJe+dAipWtZYy1fq6x1tAt+6BkCMUqYdU1xjoSw97rrgWSw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=prqoXVRu; arc=fail smtp.client-ip=52.101.72.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="prqoXVRu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LA7O380AsmSgOFrufIIAAS9z6kLx1/dQmSJjj9UD+c1bklOqSsmqjFAmzJga2axM22CO4xlon3xJmYQlKPBkSxuLJsKgLyOh+In8L4voXZcKad8YDWheqBsBBdAgpeihMLs46hRaEGmL0+bFCIm/NQ8c8U8XdHmBv4SiQgriBje2wMEgJcAZNCeCxES6Xlb7uUFTBAYj09AqSzXmMeknF6ZGNfIBgvYROk3R18E87UpfCIj6fb8l/6loIUxG4/ungRQPMIhroOMR8OI58+bSIGSzeNXDY7tQwI8iU+FQYWlJk7Q31Ws/Wtz1UBleyZlorU9B4Ckf3oOYZlGepwrP0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wWM0/dKUX8zCGUjE9cqph3ca1OTcroilnW34TnRkPu0=; b=APv3kXIO43IlmDj3pCShDG1dj92YRzSSfXQRJb+Va+KCVueGVLxTFqOqExlk/qify2F9EQ3AQtuY7NiCxiiDKJ12REBKXzrl1hmspIj8zvqQ102M5qi4t2KZwTql9FjdDMDVHixfgqJ1Atd3zVxZaQGi+DM8QvN6e0Q/vWNsLChPOZfHftzyO6C3PaF19Fp1sAjYQqT1HrEsdDYBCyco75pykeY+UkLFYuSe6pnZMiXYFE0SkVgnvLhQjGDyIKALECqJR4HwL6ZDZKGUZ4rdJdIskfYACvgDcoH7vzVtjBM5ohDwyiozpcmugV8ieiHRlsJTaqhy+yazGX3v4eDM1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wWM0/dKUX8zCGUjE9cqph3ca1OTcroilnW34TnRkPu0=; b=prqoXVRu6xE8kmTmfJH6iJn6h5kSe2SYYYdQH9vnlp1YsYjaMUd4tPtyP1N/5xJYrm69dhjagFFaX7iUwJ99xnnpkQkbnUqfr1atVPdmbTYi858ga8/eLQVw+hkY06uetzQIMN6BgLbAVa+Mih5bhez8HUND5/p4atnt4OTla0T+Ht76LSEKkLJoDwq7oh8sTXZtBVupe77bmUrjix+4UBp3TK6+jiQG6T6DKq3esaPmK2Uxa6mMfPL/EUGndWgYY90DN4z0QnMQM+bfQ1eBf9H+GLtlTXnTisXsfIIoW2yct1i4eVQbdFWwsWUoQfwDJ8xqt70xCMSV50ny72O2rQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by GV1PR04MB9134.eurprd04.prod.outlook.com (2603:10a6:150:25::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Wed, 15 Jul 2026 11:30:32 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0202.014; Wed, 15 Jul 2026 11:30:32 +0000 From: Xu Yang Date: Wed, 15 Jul 2026 19:33:56 +0800 Subject: [PATCH v6 1/6] phy: fsl-imx8mq-usb: fix typec switch leak on probe error path Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-imx8mp-usb-phy-improvement-v6-1-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> To: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jun Li Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu , stable@vger.kernel.org, Xu Yang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784115243; l=2860; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=KBrW5DQA37AQDiStxXTe/j8vzfNIUfWgsF52yv7R4yc=; b=VMfUrL78UE4BTnpsatN7PZHurk/xEvOKX5YChWAFW/nfLfjk22ROSlzsew2l6zEwPRZnHtIaa FnVwgZ0I7FrDjyKcUzauvYp6NOOrKqmp569lqCwDpAN39UlhPqvnr/a X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: SI2PR04CA0011.apcprd04.prod.outlook.com (2603:1096:4:197::10) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|GV1PR04MB9134:EE_ X-MS-Office365-Filtering-Correlation-Id: 06649c12-0427-41c4-130e-08dee2647afd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|19092799006|366016|1800799024|10067099003|56012099006|18002099003|22082099003|11063799006; X-Microsoft-Antispam-Message-Info: HDsgSi6sIQb0JF28Xtqi2ReW7SWFJBZzNkVMDlDCXXCQJ4h+sOtHe3GH/KjEMQ5mCxzdVEZ8Ot5+2vSy+81a6EEpgksAX4jrBu53OOCClc9FYIqRv0ZHV6SalYACFHp/L1KWQefU4HXo/SExgUdr00XAzecxqqUS6lOaXwP7OcGnKkSpaECiRXEXXHp5yPkB2GFTbOYRx/datGgl4fl+/JpPgDuGxeBVtD0NmJbs3eTsBSnIZePigToGIwALELRwaTf4FC4El85OhCf5/sr3BUCRePjxTAWKgRN829/OzwjDZ6ot5e2VKnri4gvR2S2EQuBWTP167ug9ucPqOtsA4ieTt+nKMdnN0tGRywpJTg/EXk4/JdqL56Hh87zl9QWAny+AVhILJPCqoNiE7ILjBze31ZA1Wd00K/K2JbDromMYYy29X2YG4BXk5NI6lvTnTMtWglS3UQbezsGwRoaONIvkCPH6EQ9ntaiCpknIZPpSzJ9BPGLaIeKoChYEB5lyPQUooNuBOB8M2ZfiUTrZmJlp/RFNpRh54CrfZY3cHo8GISGjF9HhE5QRzhXSWgG9PusiqSsQGM5ac0SgxaJ3vsenXtHIu0TSmS5jqeSk8sxSotdYhEoSZN1/IKJ0XQiKUV/bDGUhQ+cwLX8OSO4xyjEmLykzRjXJo7wEZdVxWVU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(19092799006)(366016)(1800799024)(10067099003)(56012099006)(18002099003)(22082099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFlscHRGT1prN054WmVUamJyQm5Wck9abVhXVnVKNmxJVnVMSnRCTlVHMjRS?= =?utf-8?B?NHI2Y3dnMmg1OFF4aCtYVGZuWGdJZy9QMk9kdFd0OXdMVDB1WTVjcThaSlRl?= =?utf-8?B?WFJ1NHlnWTUvVTRrZlFMbHhqU2RtT0R2blMwbjF3UmVxOXRTU2JZeHczZ1FN?= =?utf-8?B?OWlhVGJIRUVkMG1OTzd6L1ZlZzM4Z1M2cGxJM2NxYStzeUErcU4rdytUT20w?= =?utf-8?B?QldhdENrMFZyYkRLWkJicWlZbzRjOGxRcFk1cEhWK0Z2QjRRbi82ZWNHeGxY?= =?utf-8?B?dWE1ZG16a0hIUEtJRlhwcXRqSzJycTFpendWbSs3NWZkQUhpNHlOU3Vjbk5R?= =?utf-8?B?M2VBWVhrdmx3cU52RUw4anV2ZUtvZUVzZ3NwNUFkaUxWNmxLMzIvV0p3cERM?= =?utf-8?B?RzM5YkgyS0tacDVpVUlrQ3k1TWhnZDdlanRORWw3ZFczTVQvMlNDMnpmNExm?= =?utf-8?B?RG1HbVhjRVlkY090OFQ2Y2pYbkdPQXR6NGp6Y0JscTdYTFR2bFl1MUdZTE1n?= =?utf-8?B?SnpzNFdMbmtPS0xuRWhZTmg2K0tXdDNLd0UrRzV3ajJ3MkFybWdMcU5PYmQ2?= =?utf-8?B?bXdDdHdQTXF6TlhhNHdud3JlbU5XbTNEU0IvU3huckNjbzNlUTY2d3dyaWZI?= =?utf-8?B?SWMwaU50amVDb1NuZEpqWS9uRnBVMSs2L0lSZm5GWnYxSndObG84cWkyeFJq?= =?utf-8?B?N1kxVlBhMjlESWx0UlIxUzFXWUx0RDRobzFkc1hnVHZFQmw3WHVIUEJjVjR4?= =?utf-8?B?R01hSzVnL0tyblpGWjh4aVU5UWpHZ1YwNDkwMG1iYndpeklvdk14USs1U2hq?= =?utf-8?B?cEYyQnR4RmNOb2RybEZwU05kMVlNb3UvQ3ZWWUhEdkFIWWtkSGtmWWhwTktE?= =?utf-8?B?azVneVh5WnVyTzAxek5HeHY0eTkvTUpEN1h6Szh5Uzc0WStTaWtlc0ZvdWNZ?= =?utf-8?B?RlZ4dFh3SWZmd0tSWWs3bW4yR1FMaXE0SGxrRGMyYmlINFVrQkVWcHpkTEEz?= =?utf-8?B?UkhFemNuN1FqT1FGY01ZekludXFxWFc3WUNuQU1CSHNiZHdHVzlGRVRXUnJM?= =?utf-8?B?YmU4WSt6TUVKT1hRQW9uVEtseWMxbExsRVJiNUtjNjdLRm5vTHJsRnAwNi9l?= =?utf-8?B?N21xMnVxRDMwaEp2TWQvNkJJTUFvT09PUnNvazJZTDNiR3RQUFZaeG03Q21D?= =?utf-8?B?VTQ0cHVJTFVycmNQNlBrZElhQ0J4RnV6ektzaUs3dld5UVljVUFndEQ3dDRs?= =?utf-8?B?dzdDcGFzQ2dTeW0ycU1zdFdWRVpnUENBUjJFVkpNUys3SnpFQi8rK1d6Skwx?= =?utf-8?B?cXZZWU5JcmVZOWZjMGVUTk4zQWJDZERJWktnOUhBaDFCSVZKeHMrbFU4YTN6?= =?utf-8?B?WDZNWmIxZWN0dS8xemcwUUMzcG8wZm1tc2dkTTlXaWR0Smo5M2drSWszUnI0?= =?utf-8?B?WEpNZE96c2F1bjdJTTcvM2MzWDY0Zlc5QW9wMVdJRzFmSTR6YW14MUtjVUEz?= =?utf-8?B?QkxJbHBGVlEzcG5NbHd1SngrejlCSjFMTE5lUk1taUcvZ1Mza21PcGpNdStk?= =?utf-8?B?b3p4RzloN09DN0dRUkR6Z09rVEQvU24wRmtkakVyazBocm9CdFBKZ1ZuQU1Q?= =?utf-8?B?d2I2Nlh3dkZNNWRhR2RRbHRRdHhaRmpabGt2ZVdmUE1wa09LWGJQVUF2K3VF?= =?utf-8?B?SStleUpSV0kzVDVSK0JvYXpudm43Z3VkVDBlS0NoRHI5aGppV1BtTy93dVR6?= =?utf-8?B?NTAyZmphREVjdWpTRGNGZ2krcEFKWVlvRGZBZ1I4TitKWmFuSkJQeTZ2Z0hk?= =?utf-8?B?T0M2eE5wU3FjT1BPaVQ2aXRXMTBXSTZEem5COXdZZWxJRjRVSkw3Z241VmRm?= =?utf-8?B?YmxsK2N3WXp1Q3hpcXdhUlNMR2JRMHNSTXpOQWVxZGtsSFNsWTBWTjRVVTZw?= =?utf-8?B?UTZpekdPbnhLNVRJUWdXa1ArVkhLZjZjeHZqTjQwNjFHSTFZa1lvNmJzd0R5?= =?utf-8?B?SWJ4RFd6NUJobGdhN2lSUkxoSHkwNmlzL3ppQTVlNW9KZ1B2amt5aEE3T1N3?= =?utf-8?B?ckxEdG9GckJiOFpFdXhoMFJKUU5qQnVDTFdJbGR6MzFQV0tlRHE5bFBXM05I?= =?utf-8?B?Z1VLcmhHeUFSanluY3pmdWJUUjVoNHpyemJYU3o3N2RObU90RW1SWDVUQ25l?= =?utf-8?B?L01TSm5PcTl0am4xM3l6VG9FeEpjYitBYzdpS2U4aXV6T0FQMnJHV2dkMTlS?= =?utf-8?B?dHV1eEJRTy9wMGs4am1wQlE5R1hyV0RZdWJQYlBCQ0dNaUVaSDdnd0dCdFNn?= =?utf-8?B?eHU0djE2ZHp1RldEV0dZdXdwZWhRV0lRN3ZnV1RzbHJ3TWhBQzVOMmM2c0tM?= =?utf-8?Q?FpJcY8BrBFW54DqNSqqItByLePaVJ5Y6d1q9W?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06649c12-0427-41c4-130e-08dee2647afd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 11:30:32.2887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uvslutCf7xSQJ6GnRk9or0u+O18Z82qvRCeX2Q+br1OS+DWIB82g4GF3AA8qE4X7+9qQCcywLeu1R/iumNBhLBzxB4klkZEIYm8WrXEEvxBLe1UdMg7lE8+sR+SU5nOP X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9134 From: Felix Gu If probe fails after imx95_usb_phy_get_tca() succeeds, the typec switch leaks because the only cleanup path was in .remove(), which never runs on probe failure. Use devm_add_action_or_reset() so the switch is cleaned up on both probe failure and driver removal. The imx95_usb_phy_put_tca() is no longer needed, it will be removed in .remove() too. Fixes: b58f0f86fd61 ("phy: fsl-imx8mq-usb: add tca function driver for imx9= 5") Cc: stable@vger.kernel.org Reviewed-by: Frank Li Reviewed-by: Xu Yang Signed-off-by: Felix Gu Signed-off-by: Xu Yang --- Changes in v6: - delete .remove() is deleted words in commit message Changes in v5: - keep remove() callback as patch #3 needs it Changes in v4: - add my signed-off tag Changes in v3: - add R-b tag - cc statble - drop "sw =3D data" conversion --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index b05d80e849a1..9a33c06d6fc3 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -173,9 +173,9 @@ static struct typec_switch_dev *tca_blk_get_typec_switc= h(struct platform_device return sw; } =20 -static void tca_blk_put_typec_switch(struct typec_switch_dev *sw) +static void tca_blk_put_typec_switch(void *data) { - typec_switch_unregister(sw); + typec_switch_unregister(data); } =20 static void tca_blk_orientation_set(struct tca_blk *tca, @@ -248,6 +248,7 @@ static struct tca_blk *imx95_usb_phy_get_tca(struct pla= tform_device *pdev, struct device *dev =3D &pdev->dev; struct resource *res; struct tca_blk *tca; + int ret; =20 res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1); if (!res) @@ -266,17 +267,11 @@ static struct tca_blk *imx95_usb_phy_get_tca(struct p= latform_device *pdev, tca->orientation =3D TYPEC_ORIENTATION_NORMAL; tca->sw =3D tca_blk_get_typec_switch(pdev, imx_phy); =20 - return tca; -} - -static void imx95_usb_phy_put_tca(struct imx8mq_usb_phy *imx_phy) -{ - struct tca_blk *tca =3D imx_phy->tca; - - if (!tca) - return; + ret =3D devm_add_action_or_reset(&pdev->dev, tca_blk_put_typec_switch, tc= a->sw); + if (ret) + return ERR_PTR(ret); =20 - tca_blk_put_typec_switch(tca->sw); + return tca; } =20 static u32 phy_tx_vref_tune_from_property(u32 percent) @@ -741,9 +736,7 @@ static int imx8mq_usb_phy_probe(struct platform_device = *pdev) =20 static void imx8mq_usb_phy_remove(struct platform_device *pdev) { - struct imx8mq_usb_phy *imx_phy =3D platform_get_drvdata(pdev); =20 - imx95_usb_phy_put_tca(imx_phy); } =20 static struct platform_driver imx8mq_usb_phy_driver =3D { --=20 2.34.1 From nobody Sat Jul 25 17:35:02 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011067.outbound.protection.outlook.com [40.107.130.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1881334692 for ; Wed, 15 Jul 2026 11:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115042; cv=fail; b=eXyy3mfYG5nFFHOWKzsFTl2yprflRtilTGfV2XO9GPaAfpa2Wk7ygrFYZZXAkoEHN2UIyMG/1Tph4Q8qRKCk91gLbKyVZBDIBsLn5a20tMGu0qzBdCZK8n1lPqJ+X/kF7/u4waEoXYLJN8CCdbQZKNnAAs8sAWCcHYo6JptV/WE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115042; c=relaxed/simple; bh=azmXnEnHaasnJBWWnoXG86pQPc4dU6t/bYNVYQUPz+k=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=CdaNss5aGB1LQlFV76XaGEQlYsKamWC67OsE8Lo97BgOtkLWaa4/P2b+/VCVG63BlLpD7ksIvPL17yOnyDC/UuFRM/DYN8mJ2TItF43A6js6440v2355r67PS68WxV/20/tVSBVfZSyTPHIoluxMVzHZ1PSD5mHCs0/JHs6Nhgc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=nqLJ0+qF; arc=fail smtp.client-ip=40.107.130.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="nqLJ0+qF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=StmdfENLOzIlHTeayu0rcPJib9qGHwXlClAPkgu1bUorLtqP14cJbVtXxVwxc3UEPXpQG9R5wIFaB8JcFmNUHNBAnAtPFHfuL8JOcBNN0JHqguGeUCFs1rAyCBrKFNVPA94NdX+lbGleSSl1HNAdLjIbtBIuG5vzy+Ff8a42hQWL7RWQEqoW/wPXmQfD7N/woiwINjwlJmczM8lp2JCp+Z2mFN/vev1+juyZYxzsoNqFNkCXHLxvbgJXXd11FRzhfsRAOEAv1vxrGaE0IG38Ho0PHP4FegSEb0mHtPpVSOIL6EThlhHuZJO9rB2krDF8uubUlPALeyYnRzcoyO1RQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+gXnDG69B7+Zt55NOUU+ptWVYpALYDgIbq/Gfu2LDSQ=; b=RXbMjdw6w2uVrlDQ66XNoIrX0UuuIIkopnAUhPt5X0bqXf0SJHh3hz+fWsmvg5qpR93vQ0I1YYkJLwxIiGbhkmM79uLRbzJE8M4JTXrFRL6+M+YVJW7qu8Pk0m8ZF4vL2I5tk/F6uNquzjyqXSMU1EmfxYzkyw/oD59Kdg8Ai4mS+iHH3VSmcOR43aH+5uVhJmldVmTTVVwpR5h3pzrTBto/zgkBrr9dnH8ZSzbkXluMF8gf11cAod6AAW6nKwEKT21hIQPiyKSTYQY2OTiQKqmwSTlnmjqikcT+ekeCzjNZ4CeFlr11WvYfXsZ6gd5dh126GaBpVExYFul8NMPT6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+gXnDG69B7+Zt55NOUU+ptWVYpALYDgIbq/Gfu2LDSQ=; b=nqLJ0+qFCqxgNKqa5l5tWLP7KXRhhJzXnM8ssglARihhwX4o9shP0pNPnltc9bdfMuys+ONk9xIU9yTkyseAKtLAmjfVu10cgC/VDJK4HEXRXnAwNPIOid5IlQGGcqleKAMJWhfqU/IlDj7lYtTgCI6MA35vndHl5/ailI1dRCRJORk9M+0t1B913wt59kAlOOTWNEJR4zRow3YUGwdXIdSXmEumtjM9badypvmv0lZ92cyy+21eugfv+324cjwi1jNyOVyaq8YV9caofRzD4fFFulm/V1sbQgCzqT8LttZWl9CVxxbiamOmzUP6GTml6ZxB2Uk0DAYL+LEGUbmMTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by GV1PR04MB9134.eurprd04.prod.outlook.com (2603:10a6:150:25::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Wed, 15 Jul 2026 11:30:37 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0202.014; Wed, 15 Jul 2026 11:30:37 +0000 From: Xu Yang Date: Wed, 15 Jul 2026 19:33:57 +0800 Subject: [PATCH v6 2/6] phy: fsl-imx8mq-usb: set usb phy to be wakeup capable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-imx8mp-usb-phy-improvement-v6-2-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> To: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jun Li Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xu Yang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784115243; l=951; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=DZ/pfgytFfjVcHg/HfTEcSllkEEcnL66EZCkKvKp8Gg=; b=IqU4ygzoC0mfOZ+MQFvO7UdToGCffR5Hd/dsViH2aEkpAd34Ue6SAzG19+8c0s2XB71sZbL4v SD03HWnt5KfCQ75ozUE/aArOFbs2AZh7HIy5mZzI/SdrVoapLHgXzrV X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: SI3PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:296::11) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|GV1PR04MB9134:EE_ X-MS-Office365-Filtering-Correlation-Id: 82e931c4-0a09-4fdd-87dd-08dee2647daf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|19092799006|366016|1800799024|10067099003|56012099006|18002099003|22082099003|5023799004|11063799006; X-Microsoft-Antispam-Message-Info: jUr9peI0A6J1ixqxGon9e+KJ0mE/3C52oyxx73JW8VXorZ9vff1JUsbKlw5k4p7idLIPNINZjsP6LvtADWFt6t1/5Zl9J1UNjt/ZCCDaCBYz+eOXWti4c0UMb5M+RWtPlCKlm5OEfnyHs6xVO4aLsD7lXW0eiJ4ikRpfmi+dWDsJEEtw8OTQUtLPopAdwN9JwHOSoEwl404TDcZ+Uxz4t7msFnOmSwhoag+WvIOlhOJEfeSR+SrLAnJ8EyULYsYB0MaDX4r7zBEE9ewXg0DpVHVTEjFomQJzu15swo6WWWuVuSKW9JcdALysZG/GbPgSXsa2KQkIY/GPOOv0ynsQ/M0XUo6zx1n0ExDxuFNq5siivvQt2441Vat0z7t6Ya4Di4i0914/xxhszHl5MAPtnwLnrEAY9srY/gckP3hyf5rgHlGbPO7r/x6o20kVIFR0787zKI6l/ZAltNc3N92yacq3X7wjgtoWwNgl1ag37pVeVW98cdYw1P7+UfRNQNM8iS2zC8ZLrMe5/SEuR9yz3hd0uxLii2oq0y5SWguZfdG50QNDC9kRp/Cu42WJYMA3wkQoEg+pICrW/Wj3K7TZo5aqAqIy0a3IzAc0YsuZeIUt9hXnCSAGJ04uIEG02jsLenZgVddXV2jo/3hXPHX+VIxLx0MgShF14Ii7LbmivsU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(19092799006)(366016)(1800799024)(10067099003)(56012099006)(18002099003)(22082099003)(5023799004)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUkzYkRTM3dTWlZUU2Y2V00raDh3T3pHTC80WUtTNTJrR01TZ2JzeVJVcUZV?= =?utf-8?B?YUhIM0JiL2thRUV1OU0vdmw3ZTlaRy9BaVE4RUw4Ymk3M2pzcitDbGxkK2xa?= =?utf-8?B?ZVZIUzVQdVVjWmNEME5XSnR6TEhRdkJ1NGhmVTh6aHJOWTNab3BPT0JrbWpz?= =?utf-8?B?MnZsdzExWS9lOWtKQ09hbnZlNEFXUmRLNTkrK0JTZW5JbnliREFia3Q3d1Uw?= =?utf-8?B?d2w4NzhsTm9NU3dacTRTZlpTVlpvandnbFJtMXFYbnhXR0w1cGVZTnRERjV6?= =?utf-8?B?UnhJMlpyb3hiVWhhTkFybWo3bmZrRUFGbFNXMlA2QnI4MjErODNrYU8vc1VW?= =?utf-8?B?MGJWMWNQMkR0L2UxTkVRb1pDQkY0cy91NGFRbkhzZHdHWStETWlPdDQwa0JZ?= =?utf-8?B?ZGdCbUVhQi8vMnA3S282c2gwczR3RWhrU2p3VmJPNDRnTWk5cFo0NDFzZHc0?= =?utf-8?B?dGkyM3F5RFNzY3R3VTl4aW9iMTlnN2Z4SHE4bHNPZHRFMDZ2d3hlQWhZTmpY?= =?utf-8?B?RXYxR2drUUFJcmo4cW1ySkY0cjBrbkVJVVpGd21oM0tVbWdpck8ydDNyK2p5?= =?utf-8?B?VEtoRVVWMjBMTExJNHhnVWZKNXV1WHlIZ2JySFFuRGdsNzFCSk5iY0trR1Vj?= =?utf-8?B?VUhaQVZiVTdYY3dkakdyalp5a3FEelhFekpHSVdPNEU3ejN3QkI4RFBOalNI?= =?utf-8?B?c3pHek1uaXN5SGljOXdRNFNqNkxZWFkxZ2NWTU1XWmhKVU1MUEVNQk5tYkpT?= =?utf-8?B?N3doblNBS1c0cWtRWjlCako1RDFoLy9LWWlBY2lMdTBHejBqTUFJc1ZKdkdl?= =?utf-8?B?MVRWQVBkSDZ5dmRMNlRqRmtEZkZRbmp5UkV4Y2crVDVsb3JzY0x1c29VWTI0?= =?utf-8?B?NUROUVlvbjJTL2JUa0RReUQyWVY4bTFYenFkOTJIMkJOSUloYThNTGV5cGJz?= =?utf-8?B?aUVhRk00K0E5WGxhMFpobWk0VE5ETUlQWU9FSEZXd0I5KzA2RDgxcTlVcTQr?= =?utf-8?B?Vm9OVlBMMERwbzVQSlRGa05PVnFIRFBBeGFIUFBQUXJGcHZKaVc0ai9Ga0Vu?= =?utf-8?B?bW5FVFVOUXFCb2NhOWxvaGptUXV5a1IvNTJ3SERpWld0aWMzamZsT3dkWmoz?= =?utf-8?B?NFhXQVM3L1crRzFsbGkramJENDJxR2Y2RkVXazA4MEk5Tk9rYVRPT0Q5RFpj?= =?utf-8?B?S01RYklLcU0xaG1wdFdwd2pHbVhjZ0ZudERBV2hSOG0rd1F2ZTFNMUF0VkFI?= =?utf-8?B?UDBwOFpLdVdsQXZ5QjZubTNwV1MyVFFUcENXczQ4SWJQOUllWVJhUy9RYW9C?= =?utf-8?B?Q3o1SXdYR2x1UnJlNVZTNVI4Y01UMmR0ZTFiOCt6QUpzZXBma3hrSi9oN3Aw?= =?utf-8?B?dUFwUUhjcFBUeGFnSThhVXlLSTArMDFWN0xrZmxXemJvWGU1Qjh2TTN5Nndu?= =?utf-8?B?R2wzLzlvLzFHTGZ1Skp1SzY3MlJ1dmxwc05GcDNoYmN3UURFWFk0Q3UxRmFG?= =?utf-8?B?bWNJT0RzUEhQUUYwMjhodVNoS1dFcGo5WkFtYTQzOWFrb05PZExDR0x6VVov?= =?utf-8?B?TCtNb081YlgwRlZnSnZKM1RXUGlCNFQ2SUxRb3lNaEFhVnhCSW5qRmlvS3hG?= =?utf-8?B?czA5TWJSRFlnWTJDVkRBZytOR0FPcVhHNWF0RGdHMXNEdGY0Yks1amIvdWUr?= =?utf-8?B?VnIyTmtJa2ZYWXBRbWRERjI5NTdkRm9XL1ZIT21MTFFVYjJNM20xSWErMHph?= =?utf-8?B?RjdwNFdKcGhaMG5PbVBFMHlKWCswbHNZaXVUaVpxNGU1NDAzTStMNFIyY2lV?= =?utf-8?B?M0ZTVk0vZzduSVRYZVlSeEp0YmZ1WERBWTA5MVQ2dGI4d1UvQUJON1padloz?= =?utf-8?B?NDMyUU9KK29wVEpwbUhrSHRyZjUvMmx5c0lELzkwaUxhcllrMTlxdjBVTW5l?= =?utf-8?B?bk0vRDhPSmdYeTRaKzh6ZGlwTHRpTDFoVVFpOG9XNkR2RlhVVDJraVJKVC8y?= =?utf-8?B?Smtzc3MybzJWeDBJd1VaeitqenNrcStXdC9Na2l5QXRjZ1FwblVvbllOVjB0?= =?utf-8?B?SWxnWHg1RlFWeklMUUgzSDZ2R3JKclhnbkpGaGlpSzl4YmpxRGtFeU9MRW5j?= =?utf-8?B?N3ZrNjFiWktRNGs4aTZsY2pDTEt3d2pVL2hNT1FwQUlxZ1lDSzcrWml6S0g1?= =?utf-8?B?dC9lWXoxNE1BSHI2VHZMbVZvU3hzSHMwWlNWMG5HMVlSS0hKeEZsZ1JiaFAy?= =?utf-8?B?T3l2Qm5qMnJPd2NGY1RzWndSY0piZ215bVZDNWdTbklzY0VCdkVJUGI5YjMy?= =?utf-8?B?SUNTaG53WVRnYUlQSUVWajBQZitZdGUzOGtYaTBYa1QvN3VsQUhBeHV4Smdq?= =?utf-8?Q?EFR0b+sJRZgLsNi7ltH3dIVphfSxVpeSd6D5A?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82e931c4-0a09-4fdd-87dd-08dee2647daf X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 11:30:36.9425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ShHdHLlVaB6+7AW5iEw09rsy5Hw5Ep4swYpuW5Tcf1QItnBCgmMOcFgynG4WWJ9zw5PCza8SaU7YMQfpclmC41uKHQsJ5XhqpcEgTj/qELwXyW+3wHXVkTi5v5FPzRc9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9134 From: Xu Yang Set PHY wakeup capable because this PHY supports remote wakeup function. Reviewed-by: Frank Li Signed-off-by: Xu Yang --- Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - add Rb tag Changes in v3: - no changes Changes in v2: - no changes --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index 9a33c06d6fc3..3a5788c609e1 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -728,6 +728,7 @@ static int imx8mq_usb_phy_probe(struct platform_device = *pdev) "failed to get tca\n"); =20 imx8m_get_phy_tuning_data(imx_phy); + device_set_wakeup_capable(dev, true); =20 phy_provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); =20 --=20 2.34.1 From nobody Sat Jul 25 17:35:02 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B015448CEA for ; Wed, 15 Jul 2026 11:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115051; cv=fail; b=Z0abPEXHQwP9zI83keh9YwwyoGBPvDaXmlGi1oC9BdGuLYkkmtPgQcGlv4gOy7RfwPtaabhHgdsQUOm7jMFuXdsrA6Ln/M7md1SE7H5uGvXo1PB98UP/RCfCAwcElNmdR96bL2MvBLhF01u32xI0HV93/HAOysSyWXj2TeiuXDo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115051; c=relaxed/simple; bh=IY0/5UchTvmLkBkM+gm/jgtbO7oldhI4pY9VWE+buBw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=udrUoC82XNis/qxBOzQf3342aeIbXuq1/gOaEYAfFHxbF+4DAJ6HaUwEI6VjLzFeIkFXPVcPD6Rick0lnLl9HMotX2iFfKjrXX+5KisAkc7JD3QqA1MUpbZPDLJAYAEYxl3DG8PjAsyQRLsrFWrbGelgcFOFivbrZzohf82xk3I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Pt+KwgSE; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Pt+KwgSE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GFLMfs2s+j+xTv794nMF2z1ZM3AB1pmPqld9o+yhjOsq7PWMR+1/CameeaGobdVa4YG59OTNy2AOSMAMD1ulyHCBk24On+iefeg0ezLKVHskQInjSmaigIe5Y8G86I41aZ2Nm9LiosUEH2pKwiA0U7b3GrMVVvYMqNHZmwS3auOwOBtLi5Q5g3rHATK0gmkYbVeiGf5v2hYdYZlMtNgmfwj0yCNMkV158UHKmJB6BqHm2pf/Km9ET/u/JWTBQ1xqtf/yFp3I+kV+O1s7+TsWtI+rhFEz6h67dF878oz+fnmV5e9n+yQUfn2WjLYQtSJ4Mr4q79nUgW4Q2BSnb4/4lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7GE4ZdNiPoX/rGDvvqfOVFs9PL0x24mOaRysPuT3h7k=; b=Z/hdeWHXnNtAePBGBpdr6wGgY/QF2QI1Q3h92fH4WraQB2N2fGP0E3xJQ/Dxxe9rq8a028CSjXi30E4xzRKQgLWfhfpC44BmwZpk31PAUaIjAGk1WeEujPlU8KgtkXcJvlNzTuOX1jXTPF0qrvq68orOIfLkg2+/5Uda+Nt+/DzAZE/02rxCjRNBdWkFMt7A+VnWWtmv8WUxLCxOenu+QXl4uKscANeWSc+6Z1fcsvmjbrde70hGFn1Ftmp0rO6pv//ODsyv9sk4i3wjMDqvhWiM0Q1XC2ZxeBMOJNesXjrt4AZ/OSvMPs7Sy0OSw8YveaTyWk502/EATo/Y+xWv7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7GE4ZdNiPoX/rGDvvqfOVFs9PL0x24mOaRysPuT3h7k=; b=Pt+KwgSEBKTLA9amggiEylLUYPhYGS36Fq6iPDyxK8r3IRXQJwDaKr1jx/5GVfhcZzd6DWHzPP5dXUIyPCgOeT7DtIdygVAU7R2KUvLx69LSpOOHFo0U8Dg8sOpwTRNtlyAcSrN36YwWETcvo7VMKkH0K3ZG3rcq4mo/qTPfhKY4WN/Hvc4WFn+7FIw6ak29YJTRFr9uaeByIFjy8PbuLFntCCc8dvLS2Xq0IcUDBtIzMwWXGgIflTV8na2LgAbZxiu6a6CuATU1dGFbrdFOc0jRAezVn8j1PYkhy/LvyfaGj76s/yG61mwd+GntrxCf/rTCf4/RFSTm/nKdHKksaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by DU2PR04MB8982.eurprd04.prod.outlook.com (2603:10a6:10:2e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.11; Wed, 15 Jul 2026 11:30:42 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0202.014; Wed, 15 Jul 2026 11:30:41 +0000 From: Xu Yang Date: Wed, 15 Jul 2026 19:33:58 +0800 Subject: [PATCH v6 3/6] phy: fsl-imx8mq-usb: add runtime PM support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-imx8mp-usb-phy-improvement-v6-3-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> To: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jun Li Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xu Yang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784115243; l=5376; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=2PJGR/vJ3Tfanlg+aOx7QqQuD7zJCpHKv1688XqDnYA=; b=J+1hsicKComLPWdnI3PM1mfQ/t13VVfhu7HAdnFZNPi/IQUkqUXhf6WHrnwqk09hYgz2PTdbr cfd5qEFLD0hBTvLxUSpKAo/vh3annUv0cNGxi3pEMlFZw7gE+0JjixY X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: SI3PR01CA0008.apcprd01.prod.exchangelabs.com (2603:1096:4:296::7) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|DU2PR04MB8982:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d5bb905-0195-40ea-7a82-08dee26480b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|19092799006|23010399003|1800799024|18002099003|22082099003|10067099003|3023799007|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: tUNUEn3lSQvgLzUfRcraNZnKAIMCwFqiQHQwRwgz31GeTxS7H0uyF7tTyxcRuPsmIcBCVcORky0N6Vm0YfhQvL11MwSKrHNsdiQGpXCFV7XRFXyxWDO6tpQwoHkw5Jd6mBcAXyJsOCb3gIJN23tD90c2ahmyBJbsiCg3iiu4XVLWU2OC6JP3wr9exJWHyTkfaVlNjEJjPtSzMLZ6s6iVhS1N69ISubupzVWYIaX3SLh8CInutdUXlhAPA0tezYhzfIx78yuLjgA/rskNYhh+KtVkDxfsl0qp4HGjroh/Bvs9swvc08k6QJYasWsAl5Pxb18AUfyxWLxDlfQVmJKCesqqE93xYkN4l594ko1OR+IeBrESEqS3vmIH2sN8c+0aFh+2meSbed216+ir31ZZvNx3Ldq37dWSswBRRivwq/uGt0kfKev+qy0+lrednYydWJlIqBBzcqiax18wnp4Zd89wdfVWiHW9QIFLERPS/w7WmqQKJ4y1tESgOXJ7AQ1aHkwvnZZtnYgHZxxz5PcPFofg+rynW3yi20zIYJRt3QAE6lfjC8bTu/4TqDAYef06PKRSSVnj535pQ2Xa9OFhOrVNBqqFhliaB05WWu20RFX+DLrg5Mhj5MDTnI/j6crk0dzW5ph4OlqiuUJCBihP3CtRWo5qKafd3whJx8Cj0Z4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(19092799006)(23010399003)(1800799024)(18002099003)(22082099003)(10067099003)(3023799007)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjFMeENRaEU4S3ArcU5oVE1WZW9wQWZpRGxDdUp3c290SUhHWHZJalZyQ3Vs?= =?utf-8?B?d28welVWa2o4SlNNelB2d2pqOHEwMUlOdFF6VDAyKzNmYTY3T0FDaDFSVHFa?= =?utf-8?B?WEJ0dG1ydlJPVi9USHBBU1psMXJua3JJeGhKTFpIaTNna3B4NVFMblh0ZElW?= =?utf-8?B?V0ppbWRXNElyVDkwdEJkZm42MjA1dnpCSTdtT0VDejZvL3RVSVVrSVM5amtx?= =?utf-8?B?UWM4QktScG11Qm5uT2JXU3djRWZlQkVhZFd4VG40Qi8rREROc0w0TklaVzFH?= =?utf-8?B?S2tlRUtSc3ppaXN2OE1TYnpKTWJEWnpRaEtWYVgrTnpmSXl0WmVLV0hMNjkw?= =?utf-8?B?Q20zTUJYVTI2R3ZzbllaSEVZR2ZDaks1TlFLWXdZdmdRWjZtL3NPazhIalBa?= =?utf-8?B?UUpTWURiZFB1R0JTZnk3bzNReU9JSUkySW5hWGVNOXY0QS9uT1Q4L0Mxbnlr?= =?utf-8?B?WU5ILzdLV2krMjFGbGtRYTBVdXZPd1ZkUXJBNXRlNDdtcVJ0K0R2UHZCNDVz?= =?utf-8?B?c2daODRWaGUydlNRdnpkeE41SEtDTEZFaEE2UmxGS3ZabFRGWkdRRmxhNHNX?= =?utf-8?B?SUQyMzZQWGNHR1VEZ1VlR095WXVZWTlRbzd5NThiRzQrMnZPQVdpV3U5R05P?= =?utf-8?B?Y251Z09yNzlFbzlnSTdOblYxaGhjTjNvNjZlQ0hwYkNKSTNPbTMyWDFaSWhY?= =?utf-8?B?ZmtoT0UvV01HNGt0OHZtVjc2c2hHbHpYanQxVUpLeXBFdm13ZEhHLzE2emRG?= =?utf-8?B?ZGZaU2JSRlRmZU9CY3JTVkFaNFZlemdCaGh4K043V2QyVGl1RVZIS3BCNzhD?= =?utf-8?B?SjE3dGEwdU4yY0FHSGluWmJnNVJhY3dOMmswb1JWWEhSVnZlcGVkc2RNZldC?= =?utf-8?B?SzNOdkNOT3JqVFAvQ1dmdnYwTFkvdGlRRjA1bWZDNWE0NjFLaG8vQW1rSmxq?= =?utf-8?B?M1lQNkVEK1l5U1A3ZjJNcDRmbGxuYmxpcWFhMUlTTGxGZVA3WUUvekxPQlhq?= =?utf-8?B?SFk4TmdPOFlkekM1ZzAyaVpCNWdjOFNNRTFEUFAwdE1DK1pncnhpdS9FMkNt?= =?utf-8?B?eGhlU01QRkJVZjR3S1RkRjhVNDRjaCtPLy9aQmRwLytyZWlWNzBVZjVUOXZJ?= =?utf-8?B?UzBTelBhaFdXeVVjTDBPTmlqWXlaaHZFa202SWRoWC93dmxWeVN1NDJndjR4?= =?utf-8?B?Um1rRTB4djFqbFhIMWNOQXF1OTdWZk5YMUx5dis1NU9PUWI4ckxTbDNqRjgw?= =?utf-8?B?RTNsNTUreldoYTV4VWRYeE9yLzRBVmtselNtcWU2UTExY1ZxSTlBQ0p4WElP?= =?utf-8?B?QmM2b2RvcytSZnlJNlp5R3hOVWp5TktVMjlsTFFiRkhxUnhsZkRUNTFHbk9W?= =?utf-8?B?aVpKOHQweGJVREZyUWxJY3ZxbnF6bi84d1ZZb000L3F2TUdpK3NLeUUwSHBI?= =?utf-8?B?aFFDYjF3TmNNS0xPYVlEc0U3K1pXY0F0UVRqbEdCN0hwYkF1Z1ZYV0hHaVRB?= =?utf-8?B?WTZyN0RtMTU4WlJZbytaR2ZOb1BrS0FyU0V6ZDZoeWpTb0s3Z1F1Ynhidm0r?= =?utf-8?B?WEdhcWxQTHgybjNONExRbVJ2dlQ3NUFoSjFBdnE3TG5JQnF6SkY0RzVGcXNr?= =?utf-8?B?OE1JSEh4cjZ2TlpsTFhJZkJGSG5ZVnlWbWVLQjJncDVSWFo3dktodkJ0OCtw?= =?utf-8?B?QmNKQzdwRU1ubzlWNVcrd0dobGZNUVhCTVVZVEFEN2tCczd3eGsrdTRjeGMw?= =?utf-8?B?aFNxck14cjRtK1QzZXQ1eDEzU1U2NlBlc3kva0ZxZVlDajVhVlRkNXBwNVVS?= =?utf-8?B?S3kxL2lZb0JXZEdPb3V0Tk1SMmJYRkxzanNLQWpKWHF0V0Npd3VhM21Tdms3?= =?utf-8?B?WGk5bkx6emlqWmMwSFJVcWtYVVJzOFR4VGhUcUNqcXg0d0RzNFVTS1VZNnVE?= =?utf-8?B?T2FnNVI4eE8wRnVjWHJXT2dxaDNuSkVQTkpzOUJnSFQrZ1BQTnZiL3RCbGlh?= =?utf-8?B?eDJTZmNHalpBdmdjRE5tOWZYK2dldEdaNVhCaXg2bS9zcEZQQ3VQY3J1ZjE0?= =?utf-8?B?YjJwUXJaR3VuZFk5MGxhRi9aaExZSEthdlhCcDc1SFJxeldBODAvYVRRWHkw?= =?utf-8?B?RWlkQzNsTitSVmswV0RpQWpicTF0V2Q5QkdMTEFWNGhlMjhQYXlZZDhVM3NH?= =?utf-8?B?Q2N4MGpoU2RPczNPRkdBTGxHUUMzemVZSkR1WWoyWVZ6amxUTnRwdWV0Qkp0?= =?utf-8?B?em53SjQ1MmQ1UGpxWFhRVW9WQm96N0V6YnFTaWFvZ0xTNXQ1aTFaL1pCWHBl?= =?utf-8?B?TFZMNnkvTjZBb1l5NkhsR1krRExOVjVZV2ZHbllWbEFFYkxLREgydGx6blZ3?= =?utf-8?Q?btfxVbDzIUFjmqsD03B1/wQuan2h4r7gNAJOJ?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d5bb905-0195-40ea-7a82-08dee26480b1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 11:30:41.8282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MAO3AuuVIgjmS9e6romtG5Cba66XVj+N5arB7wIPPWC9rUHXGyLT9MRHFnMG7o57x5RdaaVWQNrAjMOtsar1moosiL576Rr3Wf0fDw3v1rxMUIiAE63YLaOdO26vDG+R X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8982 From: Xu Yang Add runtime PM to ensure the PHY is properly powered and clocked during register access, preventing potential system hangs. It guards register access in the following scenarios: - PHY operations: init() and power_on/off() callbacks are guarded by phy core - Type-C orientation switching when PHY/Controller are suspended which needs explicitly care - Future PHY control port register regmap debugfs access Signed-off-by: Xu Yang --- Changes in v6: - use devm_pm_runtime_enable() to disable runtime PM when probe fails - simply pm_runtime_get_sync/disable/put_noidle() to pm_runtime_resume() Changes in v5: - use non-devm PM runtime callback to correctly enable/disable clocks when unbind the device Changes in v4: - replace guard() with PM_RUNTIME_ACQUIRE() Changes in v3: - new patch --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 67 +++++++++++++++++++++-----= ---- 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index 3a5788c609e1..bc804d2b5aee 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include =20 @@ -136,17 +137,15 @@ static int tca_blk_typec_switch_set(struct typec_swit= ch_dev *sw, { struct imx8mq_usb_phy *imx_phy =3D typec_switch_get_drvdata(sw); struct tca_blk *tca =3D imx_phy->tca; - int ret; =20 if (tca->orientation =3D=3D orientation) return 0; =20 - ret =3D clk_prepare_enable(imx_phy->clk); - if (ret) - return ret; + PM_RUNTIME_ACQUIRE(&imx_phy->phy->dev, pm); + if (PM_RUNTIME_ACQUIRE_ERR(&pm)) + return -ENXIO; =20 tca_blk_orientation_set(tca, orientation); - clk_disable_unprepare(imx_phy->clk); =20 return 0; } @@ -620,16 +619,6 @@ static int imx8mq_phy_power_on(struct phy *phy) if (ret) return ret; =20 - ret =3D clk_prepare_enable(imx_phy->clk); - if (ret) - return ret; - - ret =3D clk_prepare_enable(imx_phy->alt_clk); - if (ret) { - clk_disable_unprepare(imx_phy->clk); - return ret; - } - /* Disable rx term override */ value =3D readl(imx_phy->base + PHY_CTRL6); value &=3D ~PHY_CTRL6_RXTERM_OVERRIDE_SEL; @@ -648,8 +637,6 @@ static int imx8mq_phy_power_off(struct phy *phy) value |=3D PHY_CTRL6_RXTERM_OVERRIDE_SEL; writel(value, imx_phy->base + PHY_CTRL6); =20 - clk_disable_unprepare(imx_phy->alt_clk); - clk_disable_unprepare(imx_phy->clk); regulator_disable(imx_phy->vbus); =20 return 0; @@ -686,6 +673,7 @@ static int imx8mq_usb_phy_probe(struct platform_device = *pdev) struct device *dev =3D &pdev->dev; struct imx8mq_usb_phy *imx_phy; const struct phy_ops *phy_ops; + int ret; =20 imx_phy =3D devm_kzalloc(dev, sizeof(*imx_phy), GFP_KERNEL); if (!imx_phy) @@ -693,13 +681,13 @@ static int imx8mq_usb_phy_probe(struct platform_devic= e *pdev) =20 platform_set_drvdata(pdev, imx_phy); =20 - imx_phy->clk =3D devm_clk_get(dev, "phy"); + imx_phy->clk =3D devm_clk_get_enabled(dev, "phy"); if (IS_ERR(imx_phy->clk)) { dev_err(dev, "failed to get imx8mq usb phy clock\n"); return PTR_ERR(imx_phy->clk); } =20 - imx_phy->alt_clk =3D devm_clk_get_optional(dev, "alt"); + imx_phy->alt_clk =3D devm_clk_get_optional_enabled(dev, "alt"); if (IS_ERR(imx_phy->alt_clk)) return dev_err_probe(dev, PTR_ERR(imx_phy->alt_clk), "Failed to get alt clk\n"); @@ -708,6 +696,11 @@ static int imx8mq_usb_phy_probe(struct platform_device= *pdev) if (IS_ERR(imx_phy->base)) return PTR_ERR(imx_phy->base); =20 + pm_runtime_set_active(dev); + ret =3D devm_pm_runtime_enable(dev); + if (ret) + return dev_err_probe(dev, ret, "failed to enable runtime PM\n"); + phy_ops =3D of_device_get_match_data(dev); if (!phy_ops) return -EINVAL; @@ -737,15 +730,51 @@ static int imx8mq_usb_phy_probe(struct platform_devic= e *pdev) =20 static void imx8mq_usb_phy_remove(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; + + /* To allow devm-managed resources to be released cleanly */ + if (pm_runtime_suspended(dev)) + pm_runtime_resume(dev); +} + +static int imx8mq_usb_phy_runtime_suspend(struct device *dev) +{ + struct imx8mq_usb_phy *imx_phy =3D dev_get_drvdata(dev); + + clk_disable_unprepare(imx_phy->alt_clk); + clk_disable_unprepare(imx_phy->clk); =20 + return 0; } =20 +static int imx8mq_usb_phy_runtime_resume(struct device *dev) +{ + struct imx8mq_usb_phy *imx_phy =3D dev_get_drvdata(dev); + int ret; + + ret =3D clk_prepare_enable(imx_phy->clk); + if (ret) + return ret; + + ret =3D clk_prepare_enable(imx_phy->alt_clk); + if (ret) { + clk_disable_unprepare(imx_phy->clk); + return ret; + } + + return 0; +} + +static DEFINE_RUNTIME_DEV_PM_OPS(imx8mq_usb_phy_pm_ops, imx8mq_usb_phy_run= time_suspend, + imx8mq_usb_phy_runtime_resume, NULL); + static struct platform_driver imx8mq_usb_phy_driver =3D { .probe =3D imx8mq_usb_phy_probe, .remove =3D imx8mq_usb_phy_remove, .driver =3D { .name =3D "imx8mq-usb-phy", .of_match_table =3D imx8mq_usb_phy_of_match, + .pm =3D pm_ptr(&imx8mq_usb_phy_pm_ops), .suppress_bind_attrs =3D true, } }; --=20 2.34.1 From nobody Sat Jul 25 17:35:02 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 263E74483B2 for ; Wed, 15 Jul 2026 11:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115055; cv=fail; b=sScytJ0LfF6hiiWgk06EV1zLFNvRqinLe2b7mU1qmc98Oh5Dj0pVc24Rs+MQKiyMhSmfXGRF+IYZ6IkWqpMYBo17lJxpSuW0cCNMm5tYpzULAwZVe6wl/ZpVoMkEYzxK0EFXjh4E7gO6yFABJpQW9JyLlsIj1JxBdz+QMzchcqg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115055; c=relaxed/simple; bh=V0Qkpki5C8ZbEMmApUmjEeJbgBXGfAy0CbIMOyoi2mo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FhD3+EjEjyjsM0GNvG68wBfRAEDtB5m9vg2NI1ea4acmKgaDaE/kT33ZaDBYStRjQvSiI78bTS4/71HKuLfDzbUETpm5i+F1PVqqFOiU5QtBx6nLEHY0voE/8issMWOTSXK6Onjz+Sr5sxMkAmi0Mjwjoc9VXxhmdzTsofKhvBM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=woOsWdcY; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="woOsWdcY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wOEm+4pWiqx1lEbnpKmqoOhQdqew4OBf/Q8z5CktjFRvB1Jl5+YOSZS2JJ6doZDe5fLPuMZhnzGLWgxyThZYi25U0v7P+9Ru5FL7aHWJGdGmurZ7Lc6yGDCNErJKuRtfYCgbILjUH/1bY6LPWD+VSVPhPF47ox2YaB9sU3fAqcZN0d4CotcffAiaw+bt0iNQaOGH4PtIW197sSQiIOjdMGR41roOvlbcjJfXLG8sPQaWfXGQ99uATpoBtIPm7nEYQHGYktmlg71GMUDypZQPePJTJnCjbag+n/z/2fMZrVfiFbDLydnP55VPynUuVEjKX6XbUrGABXK13HZPwE5brA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YXskIeuBN0Mw4wP7doqNnVgFJFZpnqoFvt9aoNiZ7Jo=; b=nQZydRYLZYXYPW0P1aGS/nxw03YTD7hdavx++/yMAcYrTWQlyqjN6u8EQBGwnodLJKELd+qdAR2BUeHaiDfWwOHn6uVIiWuNyp3etijngPayYGK4yHPW3eHlPRT4Nii2p/8ZpfetnAhQnONkk+JXH3UK9P2Mrj3sPF05Jldl13X6gp9+WUUhJcrS83ktGfdbOzPDBNfldPFqIxTfDD2S5QEULlTgUWazCLLrNoOWlqG/b8xuad9tuUfCG0DFQrPkXfDQQaoNB5I61zFiN5UaaRUZlGvyO+kmAMHSojoOsP2xCCz5LL+fjuFuj+YgmPR8eJXIvSD+tEvfshQLzAwrww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXskIeuBN0Mw4wP7doqNnVgFJFZpnqoFvt9aoNiZ7Jo=; b=woOsWdcYdT9r5ht8bcPCW+8kaPp0r4nTbls0AfyNMmYfmSuCCd2Zhja5T4ceKO0AJMi7fiRqXavYPkoFK1jS1eWZugh+Xs7yL7B5Csqq2kQfssfC5tbR6NxKFaoSQ6UGi0PFGPF/IJB3sEo9fS6MrOe4AkQ4Xq1CvbHo3Hlnm5C3gPKLrZhfJsqhhOdwwOkBCKtxIQ3ckTDRAcLzGq0CZzNGNp0bn6sS4WoPup706nHNOEnfCMK4HEwhCswaajn3BJReyg+5WSlh/VSdxuJ8erY/+xpcJQr/l7ibwd0Mm9ui/pt3vQnmZR6gDKl0QIVhSc7a2/uXFWkS5fGsTUPIcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by DU2PR04MB8982.eurprd04.prod.outlook.com (2603:10a6:10:2e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.11; Wed, 15 Jul 2026 11:30:47 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0202.014; Wed, 15 Jul 2026 11:30:47 +0000 From: Xu Yang Date: Wed, 15 Jul 2026 19:33:59 +0800 Subject: [PATCH v6 4/6] phy: fsl-imx8mq-usb: add control register regmap Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-imx8mp-usb-phy-improvement-v6-4-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> To: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jun Li Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xu Yang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784115243; l=3222; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=P5Exx9+4r1UsPRUwYQCsYCLak1Kw4gSSv/scgAMm1pg=; b=39y2iECjGpRHcDhas3caiUjXfWYVoxvBu8ypK7OUzUDXgFn4jR1iN1Zrgv2M5/YAdWGjrsbNH jU9qdXrwjXzCgHvx5Ra8aSEt25vWq+FYxwH2stTd+PaIjRdbw3sceBj X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: MA5PR01CA0140.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1b9::9) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|DU2PR04MB8982:EE_ X-MS-Office365-Filtering-Correlation-Id: b037604f-ddfa-46be-b0be-08dee26483f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|19092799006|23010399003|1800799024|18002099003|22082099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: zg05fUA9hzyQuaE//1C2pjQGAp8sVNL9sRdIzSYsl+cl/B/Co1zN32j5T1an1Wa/HGCGqAcj6hP2Y2lAvu84DbvKfuayOBpP4Z+rtjXg2mnW323mPb+u0RaTj/72NLAotx1avi4PtOF+Iths/YAOJ0BIHtySfoGt4ZeRboOPzYBrE7M4DPVmK4WjhC11myi6A/fYZ2/JXnv7FncC7h1/gMvl/Jca/7J4EqjmyVogGK1+N5CklEgW5BkpAqDPc5rPE9qvQou6P3Xjc76sWaB003ZPkfSiMgQdPjzXvFLAq5Y1+50MxIVs6rgOYv/DiTm4ztl5jqo91SqQfEJqDB/77FGc3jKOYva+dKVyNjB/LW7VUoXGf4SenJdFtbOG9LTKBrz9o6TULKAiipxhO3dYSE7C+sto+osVZZfYJFfGKv4QXjRR7h+DdIesLrEJ8BNnbg9nywrMx6Lg7I00L7w+TDHRsOmooObRQJ5TLMvmsrriel7HMk23IlbQ5iakCz4IFlrnhpGvq2S+HPpYL+P/UnX7ItfaN3uc54QeGfrdn/zcjMWOmcXtUuCSzfgdnaHOwmTZxH/SSvJrOJjkpdaIPx647s3LNBRTiSQMQj/zdQ9wNHs8O07YrJdcTMBZk4SLKKDlQiv+qVMscOD86i6O1ACe80xiBUD+f2qoabmSdD4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(19092799006)(23010399003)(1800799024)(18002099003)(22082099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2NWN0tYK0N0NHhoTk1tYVRXc0d3dHNZM3VUeWplcjJ5OVBPdVBMdUNCam1v?= =?utf-8?B?dkpFRlA4RlFST0FRd2ExR1pyMCtHZmZockJEN3o0K0xxNFpZTUxUTTdFOFlR?= =?utf-8?B?Wk9IWk92U1NrclIwN0dTOWYrQ0t0V29qMTNlaUQvYVM4WjU3b3FUUWFuQks1?= =?utf-8?B?MHBudjBpUTkxUUE1Wk5lK0dMcXJibldUUndWd2hTcUl0RTJkdFJkUjY5L1cv?= =?utf-8?B?OGZHRUtPR0pObHkyeVhzK1Y0ZE92RDg4d2dqcUZ2VFFhVDRjZkpzMkhSWk5m?= =?utf-8?B?VVJCUWlCT2ZpeGdxZUVLbEhycGN4SnNOQzVGbFFmZ1hJZjc5cGs1TC9GcmVU?= =?utf-8?B?bzJ2d3l0NVRNVngxYXd6R3dDbjlXYzlJc3ZhRWY3UDBNbG1tbW9XM3Z3RmNZ?= =?utf-8?B?aDludElSUmxIRDl0M29vd2FjYUkya3NyY0l2SW9XdDkzZHpjdUJ1Vlg4eVNB?= =?utf-8?B?cDZ6dVNIVzRGeDQzMUcwVmFTU3Y5b0I0L3krNFJXbTRUVHl2WDhMSk9FM1lo?= =?utf-8?B?cFZjZ0lHQnZQQ3JEQmpEaWQ2YlkyNjdEbzQ3ZGdRY2wySndEZHJyWCtSMmxq?= =?utf-8?B?Vm5XTlNuMjVCaXhLTzdGU1NPT2NRL3N4bnJ2cmRnaW1McVFIZmFCcmNscXFS?= =?utf-8?B?TC84TkMxUGpOQnVHdlFyWnQ3Z3BRUklSSGR3TzF5ZHYrbUZqZytyVUZPeFNk?= =?utf-8?B?TDVsTUFFRW1WemE1ejM1MWdrZGJDMk5uejRzWHpWZllGUGk3bnMvWFlzRjlr?= =?utf-8?B?NmJ3QUVUVUZHQk1WTFhxNkdrWHgxeE1DYWNUM1NJaXRoWk84SkVtVDhkUWdB?= =?utf-8?B?cGhEaHg1VEsvclhYK2R6cnF5NWFSTnZWdFFrQnUvQUkrRjBZS05wRGtSdVpU?= =?utf-8?B?aEZxRlJ3d2JieUlUcWE1NFRFY21XalcwTXpIMng2RjZxdHJnL3lZbExIam9u?= =?utf-8?B?VEsyZ2ZWVjZOMXQwVitmM1hGOEt5Q2N3dkUvNlRCWS9jUldTU3EzUTd6TXFZ?= =?utf-8?B?ZzVRWjQyOXFVRFdLbzlQNVkyUXhEM2YxYmh2YXdFZVF1RlZibTVhZlJJc2Nv?= =?utf-8?B?ejRDVWRoTmJMdHFUS29kcVgrOU9GUkNJWW9BT0JnWTR4SlkyYTVHOTBYWUN6?= =?utf-8?B?d0IxRmlBYm9NOERzOFVCV3lHZ01ualdseXZxY3JLcXE3Y01xM0s4N2ZiczFR?= =?utf-8?B?cmtKYjF0RllnOVkrTWtNNWZHVXBZeUtYZGVUYSthTG9xNkVoWDBuQXRCWS93?= =?utf-8?B?WWFiU0VJZmhrTjJyYkFTNEtUVEZXSmt3b2RLVWlOSnFEaG1rODJaY3J3bjA0?= =?utf-8?B?UDNwMitzdmdmMEl0RDlCdDdSYmdUQWtTejZJTTBjaWdOTThRNys1eHg1bVFH?= =?utf-8?B?OUhVYkh5SmVGTFkyaXVSbG1BS0p1aFhpaEViOGZ0NkE5SFlnYjJvV0ZpM1U5?= =?utf-8?B?eW5ER0Rzbm4zbWpwaVB6b3Jta0lwUytJdXFVdlJoaXpvWG9BWVpsYjBTZWFO?= =?utf-8?B?djZEYnFrbXBKelo4Z3hsc3ord2RNM3BoNzJ5M3NsZXZ0Ni9wdU9aZVZZMGpx?= =?utf-8?B?bENuaUNTY2I2V0Z5M052YW1VOWx2SlNRV3dxbUFZUXNaUFcxaW9MRnFmbVk3?= =?utf-8?B?dzZXK0dQUDN6cFV2UytmL2pTTWdrU0FrYnJsQWY3L2RiaHZnMU9KTEFIcXl0?= =?utf-8?B?NGI3QjF1L0ZFdnlOWkdEVnNnVENYemlWYlFKbDVmdmtPOGI3SUxBSnJtQ0Vi?= =?utf-8?B?RVFQQThwSFkxdEIxS2ZQUkNmbjlWNjhPazJMdU5Vbm9EN3hyWXErdlRaNEpV?= =?utf-8?B?eU8rT1lzWU8yNE9PZk1KcTl2dHU5ZENjbW96WUpNSnNsUFlhekxEa29JbUM3?= =?utf-8?B?elRUOHcvOUNZWlc3SnVyNzBYUTZDZnlaUVFOMTM0UEtsRFpaSnVhcEFyZzU0?= =?utf-8?B?SWJLT0xpVVhMTmlTOTQ1dnhrZW9IckwyNTkzMnBIUDhZeHFLZlg1cUxVWGlG?= =?utf-8?B?bWhZV1E2VWE0VFJQYmtCTWpqc3RIMTBJQXUzM2hCMWVPUm85aUlOR2hWWFp1?= =?utf-8?B?L1NpZGFEdkUvcHZCM200RVhtT0dDdFhrT0V3UGxCakZTR3BnM3VDNTJnbEF2?= =?utf-8?B?eDdtOEFFbmJLMmJoVmlrcHFwY1c4cjEzU0M0R05udUtoWGZIY1ZtNy82L1RP?= =?utf-8?B?VklOM04rK1JjMDFkR2VPYnJPTFhNVlZsVmdnNjd0VjNraExWS1VDWC95YW5R?= =?utf-8?B?WWx0U1c0Mjltb1V2SlNPa21GRHBTdTZGL055bk5HdnhIWjRZdGVIdm9OM01m?= =?utf-8?B?QStKaVV5cGo1TDdQeGI4QThSUzRLeHk3NlMvUXBDekVjL3owdkJTVEo5UHQ0?= =?utf-8?Q?FjLwwSUz6w8cM4rwuyOQiofUWcw+SJgZcyDSU?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b037604f-ddfa-46be-b0be-08dee26483f0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 11:30:47.3948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H/pnk89jqzKqYL7iwEdQ2BBbeugb+yLUKYAk8j1ghvsaMQuCYJULrzcW3c6pOmrEg2sLl783BW0DJF41Ze+IGu8F0vwWAJIi8Tj32uAv+ppX9IKYSfKkm3zWE5hW4aLF X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8982 From: Xu Yang The CR port is a simple 16-bit data/address parallel port that is accessed through 32-bit MMIO registers for on-chip access to the control registers inside the USB 3.0 femtoPHY. Add control register regmap and export these registers by debugfs to help PHY's diagnostic. Reviewed-by: Frank Li Signed-off-by: Xu Yang --- Changes in v6: - no changes Changes in v5: - add Rb tag Changes in v4: - improve commit message as Haibo's suggestion Changes in v3: - drop Frank's tag because it includes other changes - new patch --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index bc804d2b5aee..79b3958ead2f 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0+ -/* Copyright (c) 2017 NXP. */ +/* Copyright 2017-2026 NXP. */ =20 #include #include @@ -11,6 +11,7 @@ #include #include #include +#include #include =20 #define PHY_CTRL0 0x0 @@ -56,6 +57,8 @@ #define PHY_CTRL6_ALT_CLK_EN BIT(1) #define PHY_CTRL6_ALT_CLK_SEL BIT(0) =20 +#define PHY_CRCTL 0x30 + #define PHY_TUNE_DEFAULT 0xffffffff =20 #define TCA_CLK_RST 0x00 @@ -119,6 +122,7 @@ struct imx8mq_usb_phy { void __iomem *base; struct regulator *vbus; struct tca_blk *tca; + struct regmap *cr_regmap; u32 pcs_tx_swing_full; u32 pcs_tx_deemph_3p5db; u32 tx_vref_tune; @@ -667,6 +671,14 @@ static const struct of_device_id imx8mq_usb_phy_of_mat= ch[] =3D { }; MODULE_DEVICE_TABLE(of, imx8mq_usb_phy_of_match); =20 +static const struct regmap_config imx_cr_regmap_config =3D { + .name =3D "cr", + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + .max_register =3D 0x7, +}; + static int imx8mq_usb_phy_probe(struct platform_device *pdev) { struct phy_provider *phy_provider; @@ -696,6 +708,13 @@ static int imx8mq_usb_phy_probe(struct platform_device= *pdev) if (IS_ERR(imx_phy->base)) return PTR_ERR(imx_phy->base); =20 + imx_phy->cr_regmap =3D devm_regmap_init_mmio(dev, imx_phy->base + PHY_CRC= TL, + &imx_cr_regmap_config); + if (IS_ERR(imx_phy->cr_regmap)) { + dev_warn(dev, "Fail to init debug register regmap\n"); + imx_phy->cr_regmap =3D NULL; + } + pm_runtime_set_active(dev); ret =3D devm_pm_runtime_enable(dev); if (ret) @@ -741,6 +760,9 @@ static int imx8mq_usb_phy_runtime_suspend(struct device= *dev) { struct imx8mq_usb_phy *imx_phy =3D dev_get_drvdata(dev); =20 + if (imx_phy->cr_regmap) + regcache_cache_only(imx_phy->cr_regmap, true); + clk_disable_unprepare(imx_phy->alt_clk); clk_disable_unprepare(imx_phy->clk); =20 @@ -762,6 +784,9 @@ static int imx8mq_usb_phy_runtime_resume(struct device = *dev) return ret; } =20 + if (imx_phy->cr_regmap) + regcache_cache_only(imx_phy->cr_regmap, false); + return 0; } =20 --=20 2.34.1 From nobody Sat Jul 25 17:35:02 2026 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013065.outbound.protection.outlook.com [52.101.83.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2778C448CE0 for ; Wed, 15 Jul 2026 11:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115062; cv=fail; b=pANr4Be6mwc/ec+XBwudcHUx8E/xYy+XnHKTnP83Rxl+qSwSzvxU3ECWTy9brIXMTet+/bCOp1CiVXMeF5iB1/AV4M4pElMQx+x3YNMelfSCBzBnryfj4YpqmW5b3aJgc8U4olxBVUQLk85jkl6oz93qQ9quJqhRKepiJqvRfzM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115062; c=relaxed/simple; bh=/mAh+I5r7JYdKt2cJLbHxCz8Z7rNroYiavYTujDcKQ8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pYDfTkqUjH1lJCcPYpn1jcxkK8vCsemle9nE6vSTkOVCrepZXHpdopfyFLYwg/A6Hqz1rKG3eJiXg0btzyG7jSZHxEYZyVT1dhrpxSJyGOlPht3QGFTPisTr3jQ0lhBvQWbHYrzrjzBoiRbEjxqm7UKSeiNPbWV72k4yu8l0V3w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=WjWKsvX9; arc=fail smtp.client-ip=52.101.83.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="WjWKsvX9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TUQyWlvBfi1mhmX5L+W/xdKvy/oA15XW6VwiwNqEOJskhUIlmP9T5ppVVgeH9WZVVEZo7LYfJUXVj183fyxODa9fHM+Yz1jYlQfsrQ0D/bg7c/YY2/Fm5NO7eyaD0cemEw/Ztt2d3GHZQA5ole7MRhL21fusq81ro0Ic0Qhlo2GCSNSz5yZCmFcuoIytg7TkU/Ih+n3zZHsZdLicG1W9DbGqyC1D2RYha/jMaBfLNxVdAHaI6gFr5axCMCnl+o8+Yv7N28zJckFXmutE7HFqAceUcPiAXeiDObdsp8om2nySUunvHLqVND5xTDzAkzTPXLm9af5f5EUqadAytd8mMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1N3IeId9e637VdAM8P059qnjTzo91xnnEnsrGAdXvR4=; b=o45SN92jUbEcoHZuNV0Guf//QwNHwRa3idYa6WOKZIjX9egq+CFGrET9Caezl3wFhsr1XiEXxQZ2gf2tjNNF82753Fubj2yV3HhCsGMnJP4SHcTzkAYLlckoJYc669tqAC0E0MObMfs7SlHr30Q0Gqe/ryXiz1VJDleMPruHIaCJj+sljHWn6MXcL336IWX92Z7R4mL2yffkCxKFuRuUsOp8UXos+7w8JVhSSbXjO1uCxU9/EYAzXYLUoBkYe4I0XIEFoGCaVfYOBJXLWdy6WW9J6O/wueNJtnsCZv78ZbULJrwLC0s4x9ttF7z+ANYX/xUMZ6csfzkCo5SQdVsfQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1N3IeId9e637VdAM8P059qnjTzo91xnnEnsrGAdXvR4=; b=WjWKsvX9y+NiYl/mDd/BGY5t3zflANY1LuNt43N7zi9qS7KVp3Lomyg6j4dV4iTfXcDmZBQaG6zzKrebgVtzyp9b02ythdZS3WXOJAq+IztBBhCVz4LA3XoyoNfNJCd897i3RfKORH7meSDccfIsI79a5gPXGmQUZi+KXsHEHUaI0BMxkrv5WK2iyoPBv0dMVLn/ERUj1CnqBjwehCkjP1m/SPWIWgJ+6z//zftV3ym1NFMCjYacGHH5hZeK8G/EOgS5bgvOfMCXWCAV0sdjchQ5KQeP5ZqUJ0SR1StGR1l2AomebxUqPbPwQAcOfjoHGLzScx1EH/48RaJAneuISw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by DU2PR04MB8982.eurprd04.prod.outlook.com (2603:10a6:10:2e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.11; Wed, 15 Jul 2026 11:30:54 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0202.014; Wed, 15 Jul 2026 11:30:54 +0000 From: Xu Yang Date: Wed, 15 Jul 2026 19:34:00 +0800 Subject: [PATCH v6 5/6] phy: fsl-imx8mq-usb: introduce per-variant driver data structure Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-imx8mp-usb-phy-improvement-v6-5-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> To: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jun Li Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xu Yang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784115243; l=2684; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=L4H6ce2Mpvj7MRvm+fQjYKVpL+N4Fb0GeL7xGX6mikc=; b=6g1RDeMLWRwVpr7rgCBVpcbe7FcirvDMv3xR0yLGVZEyvi1N3YhBzre+m7HSSRTG6IwajzO9h qHaUqSkF9PaBTEf0LNvk8e10O6rsm9TShCNY533qzBfm0wXMGPQKqlI X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: MA5P287CA0306.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:21e::9) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|DU2PR04MB8982:EE_ X-MS-Office365-Filtering-Correlation-Id: fc648a70-7aef-4879-58bd-08dee264881b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|19092799006|23010399003|1800799024|18002099003|22082099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: bKOwOGbNqT2xC1GsKfGFSavc0gm2xR5H1/odO8tSYHWTtUZ/IRaugZWmdAMIFDiBw7HHcMghIfiUppMEirLJNhr3aOgD5+kisdc/Y7WrWuW9pIsR+35xhkFFU/rdsN+SkeNcxBNWc/nxBPXP43Mk8ArwWh6UDnVlPJbEEplPZTA3BmM6+PnXXYyRsPCiVhGrfjoTfpDVoP7RuUXtV9tnYh/tRLLI4aaHpwrgyYmkYOwEQHT1qpmR9sFghHVJbUQA5tWMOOxjafx4/fF30K9rTQFYo1xKPst0nwz72AkLkPjxLnG/OR0STnZ2FrjX+yMui8jqSzsGddMuB9pvkkkm0O8y7QsF2Qg9gepKgNUtoaSNgPUl0w4CAtYgVPhLhb2HwnL/FzkE8O2glGByIgcBipYFHRDBM5qVDLse/WR/H7ambUaN73tktJRm4wBKRPhqILYIj7sSQJ9RMEH5eBKiDVcicb2rcBoVd+th4U83M7pFhyEuzzGFD81IPz2vzMu/I/5vJJPUOmKAzdwcqqfjX7Yrw4G7lkxVPWKARtcYfe+2/kejyl/B5Pzrv4x+iyM/MfwAGt82pFeHtJ57Z+uXnVSJAiSQ8iD/u+aYjX6uh9hSEzA+ILkV2u5SigURDj9bkhaRQd8Qc98cZXB2ClOSkjwr9H+DBHEGqiFoZK4wXVA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(19092799006)(23010399003)(1800799024)(18002099003)(22082099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rng1YXFVTTdtWEpqMUtWSTd3c1pBV3lmWVpDYmordDRCbUZ0ZmNQVGhpOFBP?= =?utf-8?B?Q09tL281SEk0WmwxS1g2bnlmbkZyVHJkSWNOZkZhQnMyUUl5eDlDT25mWVB4?= =?utf-8?B?dVRyR0VxcnUxenhzYlN5SHhmT1o4d1A5WXZYREhHZkphQ2tRWU1jNGhLWm9s?= =?utf-8?B?c0hZN3ZoNnhlOXArNWdsOU5LL3Y3YlQ0WnpVSERYdHgvbytTdmhZYkQ0QjMr?= =?utf-8?B?Y3J2WnFoeGU1dUhZS0tDUVd0cW5wRmZ3MUVMbTZZQjFhMUJ6Z2R1L3FNajQ0?= =?utf-8?B?UGxteWlCdStSeElGK0E0bTRJMGdWeFJZUVNDWmRxVlVKby95QnBKQXZlOVBS?= =?utf-8?B?YXVLR0NBWXI3aVpJRlRNWGM4VDNkWmJqOHhFdmcyQzJjT0E1Z3hnNWFxbVVr?= =?utf-8?B?d1Y3V2t3MTdKSmZ3dmNMVHRDblZIc3d0enY0QkpTNEJTaEo3RFhRNzA2MzRr?= =?utf-8?B?QzVNZTFnMXRqZG10eVJYQlhiaS91QkxvS2tLK2hlQW5vbzFUN2F5d0pRL3Jk?= =?utf-8?B?Y1F4WU1ZNkwvUkdFdExZbGU3SnQ1VERTanBOaGEwcWEwYzRiM1FuSTlSYTNQ?= =?utf-8?B?SmdTN1hvaHZwN20vTmVOdkdtRitTQk10Mm90c2Nrc3o0a2dYWGpOZmhJTElx?= =?utf-8?B?WUVvdE5iOG9BZVg0cHVVY2VwK2xTV2hPR21Ddk01Vm1mb3U4Qm5HSlN2R0hL?= =?utf-8?B?bVhjQ2xONDI1S1JjeUJWUFVBc0ZzN3RJcDhFbjlHT25IdkpDQzhwTnY3SFZI?= =?utf-8?B?VXFkSCtJbCthTExBOTd2U2tqN3ZNNUJ1dWJDR2Y3RkJrM2lPbzJXUGk5N09x?= =?utf-8?B?RFR3dXROL3l4NWliK0NuY1JjS3F6VFU5a2FUbCtkYzVxcHhESTUxTTRhWmpw?= =?utf-8?B?V001TlpKNGpCTHMzWDYyV0IwZVVsM2RMQnh2eGR2dUpkMFUxS2NEZGJzSGUw?= =?utf-8?B?TXNtQThGbHJCTkVDU3ptdlloRUFUTUVud2RHR2t2a0hQblRFaTZ0cjJjdzZk?= =?utf-8?B?NlJvYnJKNGZQbDlKblpoRGkyejhsWEIzc3JUdFpINFBMOE00dEc4Mk84SDRn?= =?utf-8?B?c2JDaFEvKzV0NUZmVHk0TDF5aGdLR01wbVY0aTdSOTlNWHk2VStDYlgzbHE5?= =?utf-8?B?KzRsdzY1bTRVeGV5VHRYQ2JhS0lnOEl1ODdhNHFEZ1NjdDNoaDc4QXJNNmNk?= =?utf-8?B?L1A3RldHQ0o4dGhWQ2hRUnZsV3d1SnpVQldxSFdBd0tNdXEyZVJ0YmRVczdG?= =?utf-8?B?M0pBeFlnVVRsY2l0TGdkT0treFp6OTRKd1Y4ZzZlSFNJWHY1amswb1ZpWGdu?= =?utf-8?B?OXN6MWxLOGhMVkRSWnlzcEhkLy9reDZvMUJsVmVwRGRBcE5NMlFiMnFUUzNq?= =?utf-8?B?MURzdzU3NDFaZ1lPZG9HTW9POHdJb2RBZ3pTeFFYZUtuZHNpMG1kY1pDR2tW?= =?utf-8?B?NXIrZ20zWnk4U3p1UEUvVlpyVlBkSXdvS1E1Wlo0SzFqend3dnlmNGVYcTRV?= =?utf-8?B?VC9RZDM3d2ZPc3ZLcGVxQzgvYWt4RWlMV2dPNldpODhQZFdzMktYOHk4NjJR?= =?utf-8?B?aERmV0tBWUxiNzR3V1hIR0JFM2RRdVlxZUdvbDdEMms4dXl6aEdkQjErY3pJ?= =?utf-8?B?blVKTnZSaXc1MGEwcnZlUTlQcDJYUnk3dVc0OUVHQmwrZXZ0YnJtZ0d3ZjdD?= =?utf-8?B?bklnbU9iQ2NVeXRCYTRuYmlkNGM5amtJRmxiYXV5M1B1eWR3MjNPYUROVTlH?= =?utf-8?B?TzViVk5ZeElGL1hZUVZ4bWgzekxkc1RHN3BMRUU1YmxJMlRIcFEwbkFja1Zw?= =?utf-8?B?ZCtXVkFXZXFlQkJQZmRjYmpEVGdYWEZmekFvZTlSQllmeDJ5RnZ2NmhEM0t2?= =?utf-8?B?L3crdTBOeWVvSFd4cXUyR2tjWUxvL1Z1OFZZejVhNGIyRm1vc28xVkRFMjk3?= =?utf-8?B?YXhTYTFHWENhRy9CT0ZVVzlwQlN6ZTlWZjIreEZ4bCtmOVlwUFVVU09HTUJi?= =?utf-8?B?YXdQd2t6U2g1Q0U4SXpsazBGWWI1WmlGZlZoMHVrNVFLZ2VSOWFqUWs1dlpH?= =?utf-8?B?S2tVKyt2ellpN2V2NUhmNnlkSis3Rnk2c2Z4M1U3UHEvMTVsQ3FOaWdwb2ZR?= =?utf-8?B?SnhnZXpabVN6eGRmcDU5dzd4L1NCUk5xaGpPNWVyZ0Y1MDdHZSthcFhLakcv?= =?utf-8?B?aHpQMENaclJQYWJ0ZjNKWHpaZ1JEL3RCMGRwZlRtUGRRNzJ3ZUlQZmNZbHdS?= =?utf-8?B?bkxEYnRldGwraUk2R2VXRmhmSERVei9yRHJMM2NUaFlsaDZUUmMycU8yTTc0?= =?utf-8?B?WWhhM1ltMkNUQitaYVAvanljMDJZYWJmMDcrTElKVXYxNjZjUlVaNlR2cU8y?= =?utf-8?Q?hLvC58HP5JZhnUMgP2iJDIdSAbvM/u80MfYy7?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc648a70-7aef-4879-58bd-08dee264881b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 11:30:54.3095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hWwSie5U94hm3g8k883F4WFVcNkM8Ad9tCR1EXTDnvVQkioKmYUoQryQoQ0YeWoh8q81jhlTEq04axNaREMbqpwL7Qbbb5hkavZJjHYUGO5m+wKtcYYQaxCQM58lzYbe X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8982 From: Xu Yang Replace direct use of phy_ops pointer in of_device_id .data with a dedicated imx8mq_usb_phy_drvdata structure. This allows per-variant driver data to be extended in the future without changing the match table. Signed-off-by: Xu Yang Reviewed-by: Frank Li --- Changes in v6: - new patch --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 29 ++++++++++++++++++++++----= --- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index 79b3958ead2f..f0bdfa75d586 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -132,6 +132,9 @@ struct imx8mq_usb_phy { u32 comp_dis_tune; }; =20 +struct imx8mq_usb_phy_drvdata { + const struct phy_ops *ops; +}; =20 static void tca_blk_orientation_set(struct tca_blk *tca, enum typec_orientation orientation); @@ -660,13 +663,25 @@ static const struct phy_ops imx8mp_usb_phy_ops =3D { .owner =3D THIS_MODULE, }; =20 +static const struct imx8mq_usb_phy_drvdata imx8mq_usb_phy_data =3D { + .ops =3D &imx8mq_usb_phy_ops, +}; + +static const struct imx8mq_usb_phy_drvdata imx8mp_usb_phy_data =3D { + .ops =3D &imx8mp_usb_phy_ops, +}; + +static const struct imx8mq_usb_phy_drvdata imx95_usb_phy_data =3D { + .ops =3D &imx8mp_usb_phy_ops, +}; + static const struct of_device_id imx8mq_usb_phy_of_match[] =3D { {.compatible =3D "fsl,imx8mq-usb-phy", - .data =3D &imx8mq_usb_phy_ops,}, + .data =3D &imx8mq_usb_phy_data,}, {.compatible =3D "fsl,imx8mp-usb-phy", - .data =3D &imx8mp_usb_phy_ops,}, + .data =3D &imx8mp_usb_phy_data,}, {.compatible =3D "fsl,imx95-usb-phy", - .data =3D &imx8mp_usb_phy_ops,}, + .data =3D &imx95_usb_phy_data,}, { } }; MODULE_DEVICE_TABLE(of, imx8mq_usb_phy_of_match); @@ -684,7 +699,7 @@ static int imx8mq_usb_phy_probe(struct platform_device = *pdev) struct phy_provider *phy_provider; struct device *dev =3D &pdev->dev; struct imx8mq_usb_phy *imx_phy; - const struct phy_ops *phy_ops; + const struct imx8mq_usb_phy_drvdata *phy_data; int ret; =20 imx_phy =3D devm_kzalloc(dev, sizeof(*imx_phy), GFP_KERNEL); @@ -720,11 +735,11 @@ static int imx8mq_usb_phy_probe(struct platform_devic= e *pdev) if (ret) return dev_err_probe(dev, ret, "failed to enable runtime PM\n"); =20 - phy_ops =3D of_device_get_match_data(dev); - if (!phy_ops) + phy_data =3D of_device_get_match_data(dev); + if (!phy_data) return -EINVAL; =20 - imx_phy->phy =3D devm_phy_create(dev, NULL, phy_ops); + imx_phy->phy =3D devm_phy_create(dev, NULL, phy_data->ops); if (IS_ERR(imx_phy->phy)) return PTR_ERR(imx_phy->phy); =20 --=20 2.34.1 From nobody Sat Jul 25 17:35:02 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013039.outbound.protection.outlook.com [52.101.72.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D541F448CE6 for ; Wed, 15 Jul 2026 11:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115111; cv=fail; b=Yf5ZFwProH1LguwO0uphXXUrznsudhJPjMIk5yfJ9gy9PeVP1brk66g5ZPS4Ce/OA7NLDkTVvoMutGbtUTVob/42TQakK7fScIO1eI7jK30G1gkjz0mkXcBCd6+hUSI8ixCAADYs3tbTta/x2jbTxPFrNb+xP1noUBrDvp3ccM4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115111; c=relaxed/simple; bh=7gK23YEhoalcVqkxuELpW4Hh1eI0smAaasmXnxVV+W8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=KnuQGRedXeX4GGYHBH1dOZV8YmhOUUF1pXiVuNV3G/pOXtp5rBN8E5YYZmwERg/r8yO+uC6JnT4/EO0tYUjRZX0srJEpM+VGknxt3wHRX6kmT5UyHKsc6B2X/kTQkYRXkPa36aGdmHJ9MJf6fyVWEcA4rqQB459QOUbFCPfWENU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=cpu808bo; arc=fail smtp.client-ip=52.101.72.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="cpu808bo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ugSrD/xNVu5tSGRDp1rEo10XTEi8KWgDNDN+xLYPhNQzWeR2TEgGOI7NRcXxC5iuwwpftka8O0Idth1FKrl/Vr14JX1iIfn2dp9YMk1kZvnx5z3WKgWnIVy1OIWFKBuHs7yER+cALhRFqmksBqMjbHXOoMJeu2ql8pEKbC0YIKSa93ceNzOMA6fqCUHwU8GvEusRQPBrasi+RkBmCuoHRZLtpWNcwEA6EvsEoTPSp0gcGoQPvB9U2d5D7KhhqfOKxfrPa0uBOY/PYR+cCYP26+ev6hr66Yh5hTCACsS5jQBg7ac73ogiCHqpC5tIT9XHokbjAP2Rarw4bqoGPZTRDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FngayvHBAoj+/PxqT9NJfMx9Z+0Va0qsofMSXmId85c=; b=yz8JqMjBrFdEPxmntn3Lwg0hGxHquqWTck0/B8rgQmJxiOH60Oa5+USf9oiAVj/kS299RC8k8u5jywGg5meNVT6R443RSVoUGU7xSspr0OsVtx3Mq0W1zEBah9OaBZ38uf6qUJ+unExP+i4Rk2MP0D3FfYzz6VLbqgKjPPI4JVgdg+W3Uxvxol3zPerNfdyUh6GBFvN+Usc2EQofIncB9JmuxALCphnUw3OFq6mBQTF1qVAoI0Y2VNKADCVTlsjVBISh9vjGp1rj7iYre0ln/mX+MuKswPkEgeBgIzaC7FCZcp/kpzqPya/LQsNZzPhSQ7NWqbuqux5P+wCryVX2GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FngayvHBAoj+/PxqT9NJfMx9Z+0Va0qsofMSXmId85c=; b=cpu808bolAiFdwWyhn72Rct1ER1JM2ey5sXUgrVpYcS8K2TWZAAPA7urIvi9N3J1PzpvHWLa0YjKa2jgWy/9vJcFe+tZODK/29daTAPcKQHxHUpl/EsqlhkcBnplEWrHcNcVeNhz+keTpmAvrGZGM4D+Vh6EvQxAEMbUCflIODdsPMIs4zQu8Tu9bWBZajIK+TgnA1GqtpWN8J/rSxjY79n7LSdY7f78+YeXwxGoVDIcD13SQ/7lm3v93r/4E274c+3i954oeIUw4Sed4gEI3hFT4xs50uFBXUTvmDYZ/zgMl6fFQ0dScBm80rC6tpT2ChsvXSm6Bp9zoxR2pM2dQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by DU2PR04MB8982.eurprd04.prod.outlook.com (2603:10a6:10:2e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.11; Wed, 15 Jul 2026 11:31:05 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0202.014; Wed, 15 Jul 2026 11:31:05 +0000 From: Xu Yang Date: Wed, 15 Jul 2026 19:34:01 +0800 Subject: [PATCH v6 6/6] phy: fsl-imx8mq-usb: keep PHY power domain runtime always-on for i.MX8MP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-imx8mp-usb-phy-improvement-v6-6-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> To: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jun Li Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xu Yang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784115243; l=2286; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=kLzuGj/Y+CnGPVZyVB45XjBGff4ec67lzUjxvTNPg74=; b=kGmH6XtUmhwPVDP8KH/ZESosztcnyu5RvvTyHY1Wq85t3p4+3bOCiMKW+5bWSn2odMdmeNuWm N4LxYnLMe7QAw9/rwQP2zfGnuc2LDzy/Gx/qC+OC64+AnaiIVfBcDA1 X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: MA5PR01CA0291.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:21b::18) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|DU2PR04MB8982:EE_ X-MS-Office365-Filtering-Correlation-Id: 3393dbcf-4f9d-4761-ffb9-08dee2648ef4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|19092799006|23010399003|1800799024|18002099003|22082099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: G40vm0KjARNVchkKRs818C1rFkbDXGs5aU8Ep9i3TKkOlXGenUa6fHNJs/58F7MSnd8djXZJf040n4G23FkXcU0wu0TGkFItf6QcAErL+rN3mRv6cPiXxziM1Pf+q3tJVJLi8/x/F0h3SO5Tjxpddl7H+/B96LBaV6cq6tVhiM+xFezB3HTshNj/HJ6n8MLjcrIJTZnqPEFCk+ktE5kUSZanYkKlpubSJ8IdyWEOH8NtCNcQpr9DQFLwYhsZepitnFjWqUJEUrTPCo98m5eYZjHEbk4YmtCHoSHU5alvrkhUloA5xGUDMrKbCiwK1ugDODCStC7HatMhsf0jRre+VWHLNfJ/YhcK408U4ptiLh4PehXaUvEz2n0r3t9N19NS/h1bIK7O71BrwBS51o8g2ZJViNd+LscTuB4thm0V5IlPjctsYoByNoo5527M4du5KgiKPq9cD1fu4QgCqXp9GcbwBurFdqEvyS2WX7JVU1FYqfuuYLTPgYQLjdUrtJq/ZfOJ594BKfOEP1FnPnlKzNWYINFQmDbe7lccx+03QLY3P5fq/gU1YYaV55zP+oAiOrQmY8BXyMvU2jnEVvTKma/NwXOAG4cOyCZqfFgpzx6POXeZloD4txfknEuhPpNLlvLaVQbE3YzCoYJlMFSfxb7OxGXgHl+7NZgBitNyDnk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(19092799006)(23010399003)(1800799024)(18002099003)(22082099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0dXYk16aTJrTVIrWjl5dmJxTnQ4SUIvLzRlMDEyOEF0U2dEL0ZtZU5RTHpU?= =?utf-8?B?aU5YbXhWLzAzRnJ5Rmdrdzh0bWs1aHJQcVd4V3Z6WXFNSVZ4SXRaSzl4MThE?= =?utf-8?B?MDBVZ2dsd0Z5V3BNOFA3a04vUFVqaWdIWEtJM1NtYWJMdkFTc1pCZ0V1TmNZ?= =?utf-8?B?TS8wSXB3NkJkamZTbDFjRUVJMEtzbEhGckxMcHFoQW5McVFZTURzNDdBWE8y?= =?utf-8?B?UklaYm1EcTRoSmRvVVVEUERYNTZsV21rdS9MRXRGMFBUb0NxY0pPemp6K1dr?= =?utf-8?B?MDA2cTc5TjBxTHdSYmxiVGxoZkNGc2tOK3Q5ZG81TGhRcWJRbS9jNVpYVHB2?= =?utf-8?B?ejZGbjlMbERsK1NWdW1MOVBZc25nTWRPaFIvS0R6dDIwd1lJUFNiUGF6WnBi?= =?utf-8?B?V1Q0L29CZy90VHEzMjhSbS9BOThtcjhJdW5sMGo3YWdNTTlqWVB2VmZVK1lZ?= =?utf-8?B?ejNQQTdoTFYyMGVIRnV5aDd3SG5OZVUvQ0xZdVdpSWhRWDRBUGRXMDRrK2dX?= =?utf-8?B?ZUxUK0ZWdVB3clRjcjV5RlZaUVdaMCt3d1FoeXllMUdJUTBZNXFRSXV5aDlH?= =?utf-8?B?UGVuRzdSL25ZblhpY2ZDclhUeElobm5KUFlGb3JVd3MwQlUzTXROaGhoOGRV?= =?utf-8?B?QTRVVXIyWHJTZ21GNnFPN1ovUm1JT1V3bFc1bkQ1bTc5Z05SbXMvMWEzTDkw?= =?utf-8?B?Yy9LeHVvdGg2bFpUdTRySjdXYnljamlGU0d2RTRnNytFRW5OVkh4b2lWMXJH?= =?utf-8?B?QjdRWWVXVEJQSWtOWHhLYk5yeEJjdkFNMVBOamw0RThEMy9NcTM2NzRvZTJq?= =?utf-8?B?SmNudkhIbEFVWkp0S2VRV3huNkFDaEhjdU0rbVNwU1ZnejNDV21jSVlaU1FH?= =?utf-8?B?NFhXKzNva09INitHK2J5OXljYTVzWkIzWlNUR2dhc1BHc1NabUN6K2FYdGtQ?= =?utf-8?B?bWVBcUdPdVZ2VjFwbVJROUFUTjZoOVMvcHZwUHl2MVlyMTNQcWZqeUtReDI4?= =?utf-8?B?a2FMU0NtazVrYU1XdmJhZDZUY1FudXlkRjBPcmdOenNvQjBkQjM0QkVrRkJu?= =?utf-8?B?SFVmS1RLODVFV1JXTjMvRVFqcnZGM3pMZnRhQjJDL251NC8wSmV6N0NHQ0Rt?= =?utf-8?B?ckNPTG1mdkZXWGJyL0hFblMrY1FQSUcxaVFULzI3NEVqbTdvcngwMWpReDlY?= =?utf-8?B?RkU1cEk1a01zSlVmdllxbTh2L3pBM1UvZDJ4Q3ZLUkJMU0hRVjVtWDN6MHlB?= =?utf-8?B?L1Bmd3ZiR2lYdlBjdy93RWx2NkVYNFhWQlZiVnZic2tyRHVHMkZhNzNpOVRW?= =?utf-8?B?WnBSdFArMzRmR08weHFQZnJ6bWxjUTBRckJRNDBhM1M0OEtXMksyV1RmbHRr?= =?utf-8?B?U2xzTlBadmMrOUFhYUZJdHpYdmFkSnFDbmFjWGZUaWZZeDRWaXo1ZDQ5SVZU?= =?utf-8?B?VXNLS24wK0p2eGFISUY4UVUxUU5BeC9OS2hrQkg1NVdRL0U1b3RZWlJNbHVO?= =?utf-8?B?RXlueG5ZYjRpWTFMZkNtV1EzdVNCOXk4TzlobXZoZWU3ZThPbk9GNERmanVQ?= =?utf-8?B?S2g0eDVzWnNlckIzcWNTdlBkdXVQaUtPajN1TDlIMXg0TG1wYXpWekRINlVD?= =?utf-8?B?NFVTTUNsbCtjQ1hUMVI5aFZPaGdZMndpS3pKNk0yQVY3Y1hLeHRWc3dDV1dF?= =?utf-8?B?Ym8yS28vbkVaMzFEZkc1OS9mTWwvZFQ0OGRaWkI1RE9QTEIxK25OVUsyK2Z4?= =?utf-8?B?dGR5aXFOcklmcWV0ZXZubmhYam50V2xHNnlpOStjZHlDNW03RnZqV3JKWWxs?= =?utf-8?B?M21NZXdGVXBpSXNmQ1RXUFovdTVyWnVOQUl6bjJ3cDNqdlA1dGgrMWhjR2o4?= =?utf-8?B?cy9tMXIzUSt5MWF0aG14WkJDZWM1dXN2ckhRK3ZXZXkrQnAxakFHMXlDVXZH?= =?utf-8?B?Tjh5cXR6Q2I4MzVPQmI3bTczM096ckp1TnNYWkZGODl3MDdwVlg1WjZ5QmlT?= =?utf-8?B?N2dTUmZleXUycFVUWk5zM3VHSFBXekhjZE90dE1nbU1PTGhMUEd4cnRkeDdG?= =?utf-8?B?aFJXQU1GRFdDeC9VWldDbkJMT2sxcW52aFBtRnhYcDZ6Nm1OVDdVOGxKNmJ1?= =?utf-8?B?OHNJT08zNVZnSklkSjVIelZsa2lDMVdHd2ZDZmQzVFpBQkw2Y0YzYS9KeTRF?= =?utf-8?B?aHZkMjRCanoxSmRRNkNIVlpmRDhST2VoS2MvbFd4SEt4UXBQRmFIQkZPL2ZL?= =?utf-8?B?cXZxUFNYekE2SlFuaXVyQXdCNnZmbFNtV2srSW1vK0JyVno1RnI0Q1poRHZH?= =?utf-8?B?ZU13YlVUeEdVQWF5VURMMmhDRG9DN25MYW1WcjhEM2hhcXAycTAyN29xa0M4?= =?utf-8?Q?r0FVq7kVb5sPbetpckvnA5MT8zTKrVjWgNegd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3393dbcf-4f9d-4761-ffb9-08dee2648ef4 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 11:31:05.7667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cq3WE/xZct4dtGC5mPgumIa53+M7hVIB+AZJVLBpmujSYuqW+vIAdza8pMN2TME239Bj33wq42bAG8w2KX+4ouScgGAM64vHY3VeRnr0e3HqcwxTN/lr6D7zaMNbl6/E X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8982 From: Xu Yang On i.MX8MP, the USB PHY has a dedicated power domain that was previously never powered off at runtime. With the introduction of runtime PM support, the power domain will be powered off if the device is runtime suspended, which breaks USB wakeup functionality. To preserve wakeup functionality, mark the PHY power domain as runtime always-on for i.MX8MP platform. To limit the behavior to i.MX8MP, add a need_genpd_rpm_on to imx8mq_usb_phy_drvdata and set it as true for i.MX8MP. Signed-off-by: Xu Yang --- Changes in v6: - set need_genpd_rpm_on flag for i.MX8MP and call dev_pm_genpd_rpm_always_= on() if the flag is true Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - new patch --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index f0bdfa75d586..2398bda50eb8 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -134,6 +135,7 @@ struct imx8mq_usb_phy { =20 struct imx8mq_usb_phy_drvdata { const struct phy_ops *ops; + bool need_genpd_rpm_on; }; =20 static void tca_blk_orientation_set(struct tca_blk *tca, @@ -669,6 +671,7 @@ static const struct imx8mq_usb_phy_drvdata imx8mq_usb_p= hy_data =3D { =20 static const struct imx8mq_usb_phy_drvdata imx8mp_usb_phy_data =3D { .ops =3D &imx8mp_usb_phy_ops, + .need_genpd_rpm_on =3D true, }; =20 static const struct imx8mq_usb_phy_drvdata imx95_usb_phy_data =3D { @@ -739,6 +742,12 @@ static int imx8mq_usb_phy_probe(struct platform_device= *pdev) if (!phy_data) return -EINVAL; =20 + if (phy_data->need_genpd_rpm_on) { + ret =3D dev_pm_genpd_rpm_always_on(dev, true); + if (ret) + return dev_err_probe(dev, ret, "failed to set genpd rpm always on\n"); + } + imx_phy->phy =3D devm_phy_create(dev, NULL, phy_data->ops); if (IS_ERR(imx_phy->phy)) return PTR_ERR(imx_phy->phy); --=20 2.34.1