From nobody Sat Jul 25 17:34:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B45D448CEE; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118449; cv=none; b=dr7ccUTq+FW6yxseVjs7QATi2TR92R6rQxG/JRLbqm5nMksLIfyVmthtjgVczsKk8hHSTqegDBZ9VU6LaM0uSoXvh13w3LxW8a9SfHP2lh6sKYWpkmKd3aNXLKYlc7Ifz9VP9QLeYi+MeYqY4tuJZw9MlovMEPkIMnIIvABSBuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118449; c=relaxed/simple; bh=/nmX94i7woECD9G9H99n5Oh/yeRI8rxdP01LoG01IWw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sAZaqVrCVbtiVini4An3skTk1tQLIT13rsVshMVhPYepoLpjww2REnHJn/WvjvNNCnyMu9EanaU64c4X2SZjxGLZwgsWQdhiGB8cGPJoHuxcAjLsyCFHOx/mvLwrtxnvSiALsnGbkG7lchOaK/Xv0sSETHaqvqrq/Q4oZ0dCrYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l+n8mhFO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l+n8mhFO" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9F514C2BCC7; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784118448; bh=/nmX94i7woECD9G9H99n5Oh/yeRI8rxdP01LoG01IWw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=l+n8mhFOetzl2nKeUetNMTzOi5aYzNWl3tgKFTocZaVcix4tFDRRbqkYRGJ0O23B+ lPWG7ldKNddpFDS5GuOm2sxFZLGFTDKRRZBlu09WzJBJQn8SqsmECF75aQK6X9efVC ks7r+b+hPWr5AG/+yiuKo3fMqHOM3A73pKzWDxdmgaSkeQfJCNbqMLKjAWv66aacyk 7Vrotr4fyDCu6fN90YCSkNLH9jVRRGDQlQsrWy8bpJF7hNCdv8p4hv/u36nEptKDzL 15ESboduNfoZ7hEHIl5XAqxo/ywYJCOM62r/johkVvBYq+ZgEma4i+FeXn/2DNjE44 VQdcGJOzEvqlQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DD2C44501; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Wed, 15 Jul 2026 15:26:38 +0300 Subject: [PATCH v2 1/3] dt-bindings: soc: mediatek: pwrap: add mt6572 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-6572-pwrap-v2-1-bea1d801c81b@protonmail.com> References: <20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com> In-Reply-To: <20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784118429; l=921; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=BAi8UFC2xpwSSj8K8iWAUOKHGK6fMGisfalQqsjZVDM=; b=WZdjeLkVUX6/WzHVac1moHYvdUlfq8YtMBTKrlphWNkwB/sQKTS1sIKN6tHhAPcVYKBS39muA vqk0wnpsY1aCy9osGHkYge5/3c8C9PHm9ZDOVY/Pkr1RsT9nAlyVy+3 X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add a compatible string for the mt6572 SoC. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Roman Vivchar Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.= yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml index e7c4a3984c60..a3cf11153fba 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml @@ -31,6 +31,7 @@ properties: - items: - enum: - mediatek,mt2701-pwrap + - mediatek,mt6572-pwrap - mediatek,mt6765-pwrap - mediatek,mt6779-pwrap - mediatek,mt6795-pwrap --=20 2.54.0 From nobody Sat Jul 25 17:34:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1657344C67C; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118449; cv=none; b=VU/cPIE93YpGSXLZeSeOMvdTYrYzMeL3PR/y9/tFm89orHSFodVq9QaBxwb6g9ozZzNCtobmmEAYqocQhc+S4B20cvr64tadUX4w2EH2WIBeFZmV4DwNvQbNbUK9s8dRGWx/caZaAsgtuLPb/RBgJm/rCjx4xin5mtWJM5Ou9+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118449; c=relaxed/simple; bh=Z/jxhE/I9puJCOpHIh3gXSESQsB/BEzTqhANjKLklE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n4jNBPQwVMngn3ML+/QA7FOJTDGHLIIsdBIJ0QY/49i2Gfioa4GQA3Ofuuuc8AtJXtqTm2G1d9orBBKwQydKGJA7yHNieZzAqkrafQ6yo6LywLgvtzF/Phsh051XlYsPedwwWTIUF6PKSVxS3JFRmbJrdFur9kVFu7/Fn2VBXtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WLnhyI6B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WLnhyI6B" Received: by smtp.kernel.org (Postfix) with ESMTPS id AE557C2BCF5; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784118448; bh=Z/jxhE/I9puJCOpHIh3gXSESQsB/BEzTqhANjKLklE4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WLnhyI6BCkZlPDScqSoqTpjOy0ARYfWvGtkOTGv65QIIhfeADpG0Qn1LfbUPm6F7f H2cf47woCN3kSPOjw7cSKN3nDoyY4La6eejstq2i4oCurJp+VEVKGK0zGWh52MEseR T+q2EygbItcIty/T8TxRN05idxFz6kH5l+iFlTHU88ITmiVf7pV3y5uz+VpZsDZtii hqxN7a/iUJ/ylKFMnd0fYT6jmk5HioG7qzo9b6dKZHIavrBd9YOzjjnBJ6McXkwNjw Mz8f0bgYKkLrLiaxiPiieySpm4PfqEvt+UkgfL0Yhpb4aAgLbsiyNPasTZC28UlsQG ANxvyghELwqrA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7CDC4450F; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Wed, 15 Jul 2026 15:26:39 +0300 Subject: [PATCH v2 2/3] soc: mediatek: pwrap: use correct log level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-6572-pwrap-v2-2-bea1d801c81b@protonmail.com> References: <20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com> In-Reply-To: <20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784118429; l=3556; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=UdQUgW/G6p2IpzSIEwNhInH074hFbLPSHyDOpyct7NU=; b=3PKmCgYuJeYKDpULkW3pduxfpJ17XnjHjTmHi1ZlIIW5JOClS4b7MjXGbv5otf6OjNqIBtG0p JkKcrPGiRNhCrFv6lm29Qq77VFIHcIEv3XtUXlM27BM8CmWeqSh5keN X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Error paths should be dev_err, not dev_dbg. Replace all dev_dbg in error branches to have the correct log level. Also simplify dev_err and return with dev_err_probe. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Roman Vivchar --- drivers/soc/mediatek/mtk-pmic-wrap.c | 45 ++++++++++++++------------------= ---- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index 0bcd85826375..a4b10b0a97cb 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2475,10 +2475,9 @@ static int pwrap_probe(struct platform_device *pdev) if (np->child) of_slave_id =3D of_match_node(of_slave_match_tbl, np->child); =20 - if (!of_slave_id) { - dev_dbg(&pdev->dev, "slave pmic should be defined in dts\n"); - return -EINVAL; - } + if (!of_slave_id) + return dev_err_probe(&pdev->dev, -EINVAL, + "slave pmic should be defined in dts\n"); =20 wrp =3D devm_kzalloc(&pdev->dev, sizeof(*wrp), GFP_KERNEL); if (!wrp) @@ -2496,11 +2495,9 @@ static int pwrap_probe(struct platform_device *pdev) =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_RESET)) { wrp->rstc =3D devm_reset_control_get(wrp->dev, "pwrap"); - if (IS_ERR(wrp->rstc)) { - ret =3D PTR_ERR(wrp->rstc); - dev_dbg(wrp->dev, "cannot get pwrap reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc), + "cannot get pwrap reset\n"); } =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_BRIDGE)) { @@ -2510,12 +2507,9 @@ static int pwrap_probe(struct platform_device *pdev) =20 wrp->rstc_bridge =3D devm_reset_control_get(wrp->dev, "pwrap-bridge"); - if (IS_ERR(wrp->rstc_bridge)) { - ret =3D PTR_ERR(wrp->rstc_bridge); - dev_dbg(wrp->dev, - "cannot get pwrap-bridge reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc_bridge)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc_bridge), + "cannot get pwrap-bridge reset\n"); } =20 ret =3D devm_clk_bulk_get_all_enabled(wrp->dev, &clk); @@ -2535,10 +2529,8 @@ static int pwrap_probe(struct platform_device *pdev) */ if (!pwrap_readl(wrp, PWRAP_INIT_DONE2)) { ret =3D pwrap_init(wrp); - if (ret) { - dev_dbg(wrp->dev, "init failed with %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, "init failed\n"); } =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2548,10 +2540,9 @@ static int pwrap_probe(struct platform_device *pdev) else mask_done =3D PWRAP_STATE_INIT_DONE0; =20 - if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) { - dev_dbg(wrp->dev, "initialization isn't finished\n"); - return -ENODEV; - } + if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) + return dev_err_probe(wrp->dev, -ENODEV, + "initialization isn't finished\n"); =20 /* Initialize watchdog, may not be done by the bootloader */ if (!HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2593,11 +2584,9 @@ static int pwrap_probe(struct platform_device *pdev) return PTR_ERR(wrp->regmap); =20 ret =3D of_platform_populate(np, NULL, NULL, wrp->dev); - if (ret) { - dev_dbg(wrp->dev, "failed to create child devices at %pOF\n", - np); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, + "failed to create child devices at %pOF\n", np); =20 return 0; } --=20 2.54.0 From nobody Sat Jul 25 17:34:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4F644C65F; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118449; cv=none; b=rhQW/grQI1Lq/cEWrqWC3uM4ffyz8qk/SO3TTkiwVjMyGWUzdWWy5xuYF9xATtNnMySv4x0rlcEty6HQGtzz02DIWlJ2Ir4/JazMRxnJzINJypQAk5NK3/y9St/i7XXLYiJciWvt6BO716Tta1ryxGEWm/GIkqbD5nFLEc5+BCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118449; c=relaxed/simple; bh=Ixh7QjHO8Sw6SkBbzsHgSMI9ywDCBo9qAZr4szmg7DI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aTad5UZdYxXJT8DuFYAZZH8GdAjZTHqEEdHNvTT0iWBR8tmRIKGAfCnvg2xYOWJFGHCunC0/oqyL4dEs6Azz98BuTpcLZ0z0JwOr/TsQg3GFf1vR3HsSUYIUdUIypdUCQy+FAxt9/CtDrM/AX5irAqMHJN9ugkFe8f7qFg4Ouhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hREBKbQV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hREBKbQV" Received: by smtp.kernel.org (Postfix) with ESMTPS id BFC0BC2BCF4; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784118448; bh=Ixh7QjHO8Sw6SkBbzsHgSMI9ywDCBo9qAZr4szmg7DI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=hREBKbQVHNYnpvpLjDiEOykL6cAFnIvFiE/HunwP11FOkUXdxtePz2K3ib4wrYzA4 orbMl3R9hbpe26G6LY5QJU2Nn5mrQ7l+0jTqqBQ50W4J64sb31oTuj9qyQLPO8zFRc Q+ELrKz9aQyVf7b0H3JCTptagx25vgSrdXHRtQkX1sWYmIOzJWt2cAkiZnbnMU9tcu MdbZTxHRpdMVAzB1HgAhTovk9jhe6p8SudYsSq+SfP9emLb70rWIeOTQVDrnLzyhiM E1hC8U4ebAl05RvfdJPYqgSIV8SsABvL1QCzkNy9W/YxS2yjHsHjDRFJW1CT+8jUgL sMxS3ze9H7yng== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3936C44507; Wed, 15 Jul 2026 12:27:28 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Wed, 15 Jul 2026 15:26:40 +0300 Subject: [PATCH v2 3/3] soc: mediatek: pwrap: add mt6572 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260715-6572-pwrap-v2-3-bea1d801c81b@protonmail.com> References: <20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com> In-Reply-To: <20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784118429; l=3053; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=734OeVA8OVJF9zkD8y++4eBar+yDgtHe1s1/kC7/Zxk=; b=DHzyEVHfr1jchQ2eMIJvIUXEpktNqNFiQGh7LMUnb35+vD/3R+cuXsTBdugL4SGiL0gbHPFa2 rM7wXhvcZ/VD/JGoEUvtlFqLb5G2V1rzlLb2Sj/aVOaQXvh2Tax15Yw X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add mt6572 registers and platform data for the pmic wrapper. While vendor kernel source code suggests that mt6572 can be paired with the mt6320 PMIC, no such devices have been found yet. Hence, registers that not included in the mt2701 array are omitted. The mt2701 SoC-specific initialization function is used because they share the same GPS_INTF settings. Signed-off-by: Roman Vivchar Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-pmic-wrap.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index a4b10b0a97cb..3f05fc724e15 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -1314,6 +1314,7 @@ enum pmic_type { =20 enum pwrap_type { PWRAP_MT2701, + PWRAP_MT6572, PWRAP_MT6765, PWRAP_MT6779, PWRAP_MT6795, @@ -1733,6 +1734,11 @@ static void pwrap_init_chip_select_ext(struct pmic_w= rapper *wrp, u8 hext_write, static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp) { switch (wrp->master->type) { + case PWRAP_MT6572: + pwrap_writel(wrp, 0x8, PWRAP_RDDMY); + pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_RDDMY_NO], 0x8); + pwrap_init_chip_select_ext(wrp, 5, 0, 0, 0); + break; case PWRAP_MT6795: if (wrp->slave->type =3D=3D PMIC_MT6331) { const u32 *dew_regs =3D wrp->slave->dew_regs; @@ -1839,6 +1845,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp) pwrap_writel(wrp, 1, PWRAP_CIPHER_START); break; case PWRAP_MT2701: + case PWRAP_MT6572: case PWRAP_MT6765: case PWRAP_MT6779: case PWRAP_MT6795: @@ -2277,6 +2284,24 @@ static const struct pmic_wrapper_type pwrap_mt2701 = =3D { .init_soc_specific =3D pwrap_mt2701_init_soc_specific, }; =20 +/* + * MT6572 register map is a superset of the MT2701. It has additional regi= sters + * OP_TYPE (0x10), MSB_FIRST (0x14), GPS_STA (0x40) and SW_RST (0x180), + * which were omitted because the driver doesn't use them. + */ +static const struct pmic_wrapper_type pwrap_mt6572 =3D { + .regs =3D mt2701_regs, + .type =3D PWRAP_MT6572, + .arb_en_all =3D 0x1ff, + .int_en_all =3D 0x7ffffffd, + .int1_en_all =3D 0, + .spi_w =3D PWRAP_MAN_CMD_SPI_WRITE, + .wdt_src =3D PWRAP_WDT_SRC_MASK_ALL, + .caps =3D PWRAP_CAP_RESET | PWRAP_CAP_DCM, + .init_reg_clock =3D pwrap_common_init_reg_clock, + .init_soc_specific =3D pwrap_mt2701_init_soc_specific, +}; + static const struct pmic_wrapper_type pwrap_mt6765 =3D { .regs =3D mt6765_regs, .type =3D PWRAP_MT6765, @@ -2446,6 +2471,7 @@ static const struct pmic_wrapper_type pwrap_mt8186 = =3D { =20 static const struct of_device_id of_pwrap_match_tbl[] =3D { { .compatible =3D "mediatek,mt2701-pwrap", .data =3D &pwrap_mt2701 }, + { .compatible =3D "mediatek,mt6572-pwrap", .data =3D &pwrap_mt6572 }, { .compatible =3D "mediatek,mt6765-pwrap", .data =3D &pwrap_mt6765 }, { .compatible =3D "mediatek,mt6779-pwrap", .data =3D &pwrap_mt6779 }, { .compatible =3D "mediatek,mt6795-pwrap", .data =3D &pwrap_mt6795 }, --=20 2.54.0