From nobody Sat Jul 25 18:53:15 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24D833E3165 for ; Tue, 14 Jul 2026 23:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784072774; cv=none; b=EoZbL5Y9oEW7GrgK31ag+c1vN4lG+BB5QVDDJejBiX9vvTGr8CipS/JkCs5Wdf5WDawdNy3bQvbMmSDgSyS/jNm86QgUf/uiJTzEvR6op9jI4TIS0Ki95/91fFA3TqNuUnNv8AwoX9EfNmz26WZnmckDvfHvNPazR6x93f56vko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784072774; c=relaxed/simple; bh=xz5rGf8Wc+mjpEoKjw/Hm6IDCdOr4kMxjrR6BxaTuSo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qs0OXfJuThau7G8caZ0PAs54JM1xsJGMp024WR8uoU9ZAq02mDN6sGLpNP5ynKXLUjrV3JeXeUYBE5Kcw0WTPQnX84SZpvu57IPWjPQx5DmrvfUij3Zl7Y8hhueJ9ycNVfuwQFHRWIyGSGcnYb0xyCGghoNsdkq8L0VQbTiKyP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lKSoYHla; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lKSoYHla" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c9e7391839cso1385856a12.0 for ; Tue, 14 Jul 2026 16:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784072772; x=1784677572; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=kzUE7I1k14QX134cx6l+OWLqB5vco662yBKK277qQ00=; b=lKSoYHlaY9tMQ6eUeikifqhssXe19lkO3NOdAC7mX2evISKwpK9GLuJYokVuUJt+Bq jVzMtreCboc56NouafywD+ppOJPG1RRFU/f54xzYkn+tVyg+g0WrwJxzHrgE6DX8toIv VRcbOhtCKzP0CUxxhRvMZAeE6AZKG5F9LmBlIIQTH3GI/ub6LnG5NeTlvn/SzOx9mrVi 7GepLoMyR97XnOwNdKOTtYRoOK4igeUGyo5ASB/fVhkfJ5/7Y2ZCrlEw0Jurb0rlCVqc LyY5rvGRyGXlkKPVqXu2ENxk2Z37mOvxPh6sMJH3yPbJpZDQt5EatGMXmjtS/jUZZof1 45PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784072772; x=1784677572; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kzUE7I1k14QX134cx6l+OWLqB5vco662yBKK277qQ00=; b=nregpdgYtNJau4LcJgwxjk0cTTEUU2AfuBnJrB5b/+6OFWJVncLsFkHmXqVRHh8TbI GHR5yja3T0Zun3mFYAMntKT/ZJWeaGkkHFdQs66qNjMfaNPqiGtTQQS5EBl0poDPQH23 IJU3x7WYAY8J/96GcnpbkotDFKuFmdx/FdUFYUfAwRFOLukWMD6Gal8VU8B7X1XlvHZ1 zQfCHcZcvf8CIu0GDko7vZcOKltMSeRZkmOr0zyGMOCTjOzQab128aksyGIRQSb5VsjV xmbD2rps6xVGfxZtfQwtIO4BtGvEXJulhyKtiR1ukMmk4o7CmIpAD4vOpiR0UgI77p4l mwsQ== X-Forwarded-Encrypted: i=1; AHgh+RoL11AvRe3ZyUHgET+0R73Ysv8kFzYA5f1Ec8E+8TWd1e2MqJD9tKbiYREvEH09jamSjWqu4dg+qFVTUno=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlujobo+edLUJXkbQrxVL7LxBE4hr0BUe8W2yVi++Q13LyxkKK 1FiGc6PhL/9EhVwDYgX1swBhUirLK8Lj9X/nSMhzWRFOVudfJjslxEm9 X-Gm-Gg: AfdE7cmHbKsNCj0DSdIbtvBRZ4z/af+POUUrAVQmmSZyBRroMBCJ/OVogf3FOeiT/I2 uoSA6fU/GkyC8lZzCMReDN6/V7He6lZF1Smcqafy5i6jXmSUgStW+mg0xJemC2G7QqVK2Pai1mo VaWLuaAw0YBp7SCGE1uspGyU3GXVtB9sKs1EdJ6yqMm4E9jge1CLkFB9ZYagkjOMJ85LM1+f43l l3sCs2HMp9F+QiqkWdzrUOgfsPPSg/p+ZQiyavPWyJBkFJpKKXa9FF9r5v/IWSSISU5WZ6vV5TH LcpRDIqNHI6Tm1Uu3AzSKSImVbPOENnNjfIpgbqO+5qFVU2TDVjz7BknYYGsvNF873z1wNpsHNY gzkMJtqTUfbJQbFeTz7x87E95bu29NFIYY8eMQnNMYH/BiLH3ztCoOKOhG8c6fBs3LRI61SS9BF 8u0O5EB70J3RGp2/T0uEkL9LFfWUoxN7EEnZkpyKJvLA2L1UrXot/B2zBMRpqgYhfIUP+fzUNxf kiENfZYI+jU3Rf6nUefOK+bIMClcu0IxSzGBpUp1HJbfTAgPQL82z8WGb96B1Jz3x1PblfrX/XF X-Received: by 2002:a05:6a20:3d0c:b0:3c0:9c1b:d0be with SMTP id adf61e73a8af0-3c110a24bb4mr17834018637.73.1784072772474; Tue, 14 Jul 2026 16:46:12 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm10988858a12.22.2026.07.14.16.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 16:46:11 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Frank Li , Borislav Petkov , Tony Luck , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , imx@lists.linux.dev (open list:EDAC-FSL_DDR), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] EDAC: fsl_ddr: use devm_platform_ioremap_resource() Date: Tue, 14 Jul 2026 16:46:09 -0700 Message-ID: <20260714234609.902367-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded of_address_to_resource() plus devm_request_mem_regio= n() and devm_ioremap() sequence with devm_platform_ioremap_resource(), which fo= lds the resource lookup, region reservation and mapping into one step and retur= ns an ERR_PTR checked with IS_ERR()/PTR_ERR(). Behaviorally equivalent with respect to region reservation: the driver already reserved the region, so the non-overlapping reg requirement was already satisfied. Drop the now-unused linux/of_address.h include. Built for arm64 (defconfig + CONFIG_EDAC_FSL_DDR) with LLVM=3D1; drivers/edac/fsl_ddr_edac.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- drivers/edac/fsl_ddr_edac.c | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c index b27dff96aeb6..ae1d54434e38 100644 --- a/drivers/edac/fsl_ddr_edac.c +++ b/drivers/edac/fsl_ddr_edac.c @@ -22,7 +22,6 @@ #include =20 #include -#include #include "edac_module.h" #include "fsl_ddr_edac.h" =20 @@ -495,11 +494,15 @@ int fsl_mc_err_probe(struct platform_device *op) struct mem_ctl_info *mci; struct edac_mc_layer layers[2]; struct fsl_mc_pdata *pdata; - struct resource r; + void __iomem *mc_vbase; u32 ecc_en_mask; u32 sdram_ctl; int res; =20 + mc_vbase =3D devm_platform_ioremap_resource(op, 0); + if (IS_ERR(mc_vbase)) + return PTR_ERR(mc_vbase); + if (!devres_open_group(&op->dev, fsl_mc_err_probe, GFP_KERNEL)) return -ENOMEM; =20 @@ -531,28 +534,7 @@ int fsl_mc_err_probe(struct platform_device *op) * Default is big endian. */ pdata->little_endian =3D of_property_read_bool(op->dev.of_node, "little-e= ndian"); - - res =3D of_address_to_resource(op->dev.of_node, 0, &r); - if (res) { - pr_err("%s: Unable to get resource for MC err regs\n", - __func__); - goto err; - } - - if (!devm_request_mem_region(&op->dev, r.start, resource_size(&r), - pdata->name)) { - pr_err("%s: Error while requesting mem region\n", - __func__); - res =3D -EBUSY; - goto err; - } - - pdata->mc_vbase =3D devm_ioremap(&op->dev, r.start, resource_size(&r)); - if (!pdata->mc_vbase) { - pr_err("%s: Unable to setup MC err regs\n", __func__); - res =3D -ENOMEM; - goto err; - } + pdata->mc_vbase =3D mc_vbase; =20 if (pdata->flag =3D=3D TYPE_IMX9) { pdata->inject_vbase =3D devm_platform_ioremap_resource_byname(op, "injec= t"); --=20 2.55.0