From nobody Sat Jul 25 18:53:26 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F71625B099 for ; Tue, 14 Jul 2026 16:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784046681; cv=none; b=Paptc4QeWdMnoiN6NWIdbSgWP5Ds7TkSIAzWfiMNljYhCj79E8o9mbimvehCVGbEQHco7FKVolUVa6uH6bf0KLKpNxu4YNX7VduHjqbaurnHkzNljMv55A0Tb6Euq1RdTGh+8RFdvM4JI/u54inOy+WZ0+0fRG7/KQ/jRGqMSXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784046681; c=relaxed/simple; bh=BcN+kc7Y0a9AymMbKgvR6mCTpXkBQ9KM7faA7J5Krh0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Xjz3j51z13sKyZ1XWxd7mLds6A9DRJDmW06+1gJ/43GYibrvSmSLZqoRtGDZuT9xSlKKtgmyTxaPKQvMD8VF7O/Hg6XkihnGArnP0HT50NPrufT9EQB7UhR3d6DCmXTgJkmhYZ9Gou1qEhHU07AgHsM70TKxBXO4g/nMosI54XM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VK/Pj6uR; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VK/Pj6uR" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493b77b150aso8050475e9.2 for ; Tue, 14 Jul 2026 09:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784046678; x=1784651478; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=P+8jCTwgu5velxazBPk9XTR+aKK116XL3VK7F2AJFKk=; b=VK/Pj6uRuuMzbupiMdExIaK0hj4UOAoEmJ8FUofJWkxaNxDoSsSj//VECMVTV+9cGB 0OL8DPz2U1iioYh9otPqphQhciaYNC0GgEySugaAvU5sfXUbgu5wFNJZTFqqjxq1d4Y4 rV1CgkTo/LdQi522Fi/sSaFw/cATgz7laW1JpaPweRi2boZoN8xRclqUnYugNsuqeQSa WePZ1403LaUdIe3e6yQE/MOdK3REcWdAqx134L2bSUHYzaUHZLPQ+/8wI/L8lDrqYIpo IB7/z5nK2TvdLC1Zn3r5AaIZpLDOQHfGIVIAGajrSu/ypVXvOxw+Kx98lIP+L2xQpljD C3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784046678; x=1784651478; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P+8jCTwgu5velxazBPk9XTR+aKK116XL3VK7F2AJFKk=; b=DQUEO3tvQo9Zj5ypHCDzgvW1hsjK6gGMzLkjvDeD6y1jXdWoUS14Gmhq4J9JFZUjsc GaWIyoPQASL4bALOb4JcE9kO3Bo8xd92heC9rUwuFeH/sgPPiIKIYnkVod3+HBeWd8BE v2WwDCJU3z+bgaI1cjGAN7a1WioyeJnLpf6EqwfmGjnuJz8QgvxdElIda1W7ZpMWX3H+ YpXcD7x9L2VRwW5iQ7Y+KEaZ84P70M/Dbio3qqX8VZf6ayh06rDDahP/D9KIZdbPGi2f zt99piMwxObS+UeKd3133jfVKtN8EjPXKHnHlJljXLkhPIC6PPoQrIM2+Wza7QJQLzNv 4uDg== X-Forwarded-Encrypted: i=1; AHgh+RqgXAXjKFABJw7zCJ9997JYkFJva3V5I7w02uqWY90hj6NuR2J6C85eOnFl7bZjLvmn1ateRvNDjuH+c0I=@vger.kernel.org X-Gm-Message-State: AOJu0YxKGhURHd8imQg0PSMMNWFI3/v8EE4nYv4K6Lz+qXrvNbj1Qbj1 m0icJ2k+suuyxJUEU9/bibHB57tXipqDaXtmps4iYBsBiizw0vdUpd7j X-Gm-Gg: AfdE7ckt4ClKZ8DtBQgyQM88jiNdCK625i/yubGgfUCaXYFktTnNsgLRW9f0WGBBhoT mmYBCLaOVdR/Zws+zRpNEPAwEwekW1d5+iO91niudP+50tTd411oWsRIOZ6pPlHNbJXFfzdBgrp UA9iKPHb9dmAUokO8Kt0noLf5RLX78TlWkSbULKKE73xDo/crdbv7gwPn0ZRzrxj0iDAr+TpwIo igyqXowGPl02056obIFUoKNtzcYmnUbZ806qcBMHRFDhpgL6l6o3ROZjS8Z+BHz6nMxliAUaE3O rU6KwIqxIHcwI6nwZPrOkRMflciZVxq1aEAyKQIZYOl1XIMQC5FhtKR+/kUPCtjQlKs04VVlrTP Nnu11jQE+LJGuRnEyxis9l6MI/W8UerZPfaF0oaLOv/hZ1r4g8EhvQG9zlTTVwgcrXOFimkf2Oh USp1VwvOX+OaKrMAqF8P9uDwfh4RtfPVOUFwZN6jdLo+LAASWcLQ== X-Received: by 2002:a05:600c:b90:b0:493:b967:178d with SMTP id 5b1f17b1804b1-493f881d05emr148460745e9.19.1784046677536; Tue, 14 Jul 2026 09:31:17 -0700 (PDT) Received: from osama.. ([2a02:908:185:7e40:af6d:c23e:9b4a:128c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2d97527sm406414175e9.2.2026.07.14.09.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 09:31:16 -0700 (PDT) From: Osama Abdelkader To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader , stable@vger.kernel.org Subject: [PATCH] drm/panthor: return error on truncated firmware Date: Tue, 14 Jul 2026 18:30:55 +0200 Message-ID: <20260714163056.22329-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" panthor_fw_load() detects truncated firmware images, but jumps to the common cleanup path without setting ret. If no previous error was recorded, the function can return 0 and treat the invalid firmware as successfully loaded. Set ret to -EINVAL before leaving the truncated-image path. Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") Cc: stable@vger.kernel.org Signed-off-by: Osama Abdelkader Reviewed-by: Boris Brezillon Reviewed-by: Liviu Dudau --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor= /panthor_fw.c index 986151681b24..39fff094ebb5 100644 --- a/drivers/gpu/drm/panthor/panthor_fw.c +++ b/drivers/gpu/drm/panthor/panthor_fw.c @@ -829,6 +829,7 @@ static int panthor_fw_load(struct panthor_device *ptdev) } =20 if (hdr.size > iter.size) { + ret =3D -EINVAL; drm_err(&ptdev->base, "Firmware image is truncated\n"); goto out; } --=20 2.43.0