From nobody Sat Jul 25 19:27:03 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85D4E47D921 for ; Tue, 14 Jul 2026 14:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784037909; cv=none; b=FrDJFPsT6ORY+oeBHk0CDBfnwZJhjLTfcsLclHqFRBLIeFu8EoEAKl4ONJiGQTDqeICkxSVgk6opn3H+X2xCvN8/1kbNY5CIfOR75rZhJd5yci8hGNapqP47DbrWPEh73bDw3LMnCo04gRLZ/wpoUEMbkKDHVIyFKxNTGKqa/Zo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784037909; c=relaxed/simple; bh=ggzyTfjEV0/9dpcpFtZ9kFFL7YcUs8Yp4tvAlAGWUbI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D+FguZzxDkV6HWkD3aMyCXstyx961q994bFijRw/16jTHIez+dCYONLtlrhXRMouV8xt3NLBVWuwGgVeFReqSqD/R8gUscTgj7oGxbarNXaE3Q4li+JzBI2c+3r+PVmB7TJhv2Z9e3doFVbhb0P6XbfwALBAJmkgrHJ3Ain/x0M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oqi9Xb0m; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oqi9Xb0m" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e08baf860so1780254a91.2 for ; Tue, 14 Jul 2026 07:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784037905; x=1784642705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bCS+xhHigKk4Qit1FS738ySqpbHn6h48fVzGRxbPZzk=; b=Oqi9Xb0mI9qJrKIlNLfPx3ICZTOSNkSHZw03S8Qtn3hSl2piXUqtyg99DpaSp/kCOZ gfiAQBtrHshJs4v9LBTxXElaivLFqJG0WKJjSN+aKU7aNSeA/vNwG7sRRWjsxK7Un450 iIWJ5/5yywMccfJnr+R3lkxXQl/e7KivjZ0NnmwlPAWc+EDZ4aM5uftvZpzQVjYGp1Xr K5SmIK+5Yy1MArmc6YXYPqk7naVbsl/alJIzrrkTJO8Yxc6R5lC551CnoZ28uv10eGe+ ykMt616zKlochXVV/in/eMd2GFUXx9/R4kDyHywPIDOW9LJJYu1fJycwmnZ82yKcosdv sc9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784037905; x=1784642705; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bCS+xhHigKk4Qit1FS738ySqpbHn6h48fVzGRxbPZzk=; b=oFetF6u9Hqy+xoDEmgXnGc8PhvLH547IRbHJW37RVj+0hb/gOF9BIiW16g2GGJIaZI 8XxeyBKqkZrWAp7VcmVQSIzX+VEhG8+92AmhCsqhu8mUYtD4ZN/vXs+wuga6DeVQ0GzS YFlzHSonrANBJmAcHOLfZnUCYyWtiJsW0gnKEn+sXUDYOdz/dnS4bU6LDrHdbVmd2Ug6 HWzL6hBryec7gQA3Tf8M4gK33T4vb37qBgqajw9XVf4UB1NRXP5d8hVXSSK2Bx1Y/yQZ oqFxyxdq4oaLkx6iZpyYt2UI07TAN1TVNDwMlPMb4NgG6/ua+GZ1HJLh2hayIdcMnkwl 8Agw== X-Forwarded-Encrypted: i=1; AHgh+Rq2FqCjMhhAvwqq8EUEik/ZWwDasatGvkpkTVmd5PySrNH0K7H6kyhSoHFzbZW+3U/sB8EyD1GdNtc6liU=@vger.kernel.org X-Gm-Message-State: AOJu0Yza+QSmUNI/ijAwOsxTIs0UtiGNBhiXaKujPepPucmCY9rOn00R uKeHco+cr7ODXKwCgL7ZUlyS0f52/F6sqknZoHWFH5iR0Xe/RY/oxlXK X-Gm-Gg: AfdE7cmxl2iIFt9esjrJYlxfhzX5ppiWkKhE6qiRyvd+m3K82ZtlkcsAZMH74FJkoJu KYahoaHff0Zc2W7vFfR8BCtU12jX+WjIreIzr7otfUvNyFzIQmeBj+/oCYdIurfSl6Lj+FbuRKz x3MpPnAlT8cejzwYfLVO6uup2yJJ/ueRGWR4DrMViNe1E/hZzdc4ent5xTQg57yDbLiQnB8LUN4 q00eh6XpjU74CuWXlC0LzPBKEu80FrbXi/YWRk7eMIW7hmL/R7a8QhMlOKXzm2fBlxtE3+oxAAL zJD0Yfz8vTOBz18IDj/uY6Rb0MIl0eA5W+YZXLdVN9G/tcgJRHsTAtArUH02g5X5ykIKCWZExy8 Kx14atEK0PjFu0yRSTol/3yTlHiQLyBmnvfRZ4nrQwCNoZ8kS63O+MJDMV9CoIE6MIxo38d+zO3 MYWXPM/8nxJ5kiLaDWqs8EJwdYyRBvnVzy8caxZcEv+0owDhJwIDeEOtf9rdZ2pWqKrBt4SNYvG h4t3ndFQ4vAOuDWP73B4sUVlG7VJj9BV9isSnzv6sSwedE= X-Received: by 2002:a17:90b:3c8a:b0:381:5bd6:eb19 with SMTP id 98e67ed59e1d1-38dc7605e7dmr12912747a91.18.1784037904733; Tue, 14 Jul 2026 07:05:04 -0700 (PDT) Received: from OMEN ([103.184.238.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174ac14f2sm86964943eec.27.2026.07.14.07.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 07:05:04 -0700 (PDT) From: Alfie Varghese To: neil.armstrong@linaro.org Cc: gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, dan.carpenter@linaro.org, error27@gmail.com, alfievarghese22@gmail.com Subject: [PATCH v2] staging: media: meson: vdec: propagate devm_clk_get() errors Date: Tue, 14 Jul 2026 19:34:58 +0530 Message-ID: <20260714140458.1276-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vdec_probe() hardcodes -EPROBE_DEFER for all devm_clk_get() failures. This masks the actual error code returned by the clock framework, such as -ENOENT when a clock is not registered or -ENOMEM on allocation failure. Return PTR_ERR() instead to propagate the real error to the caller. Fixes: 4f75e7dfa6dc ("media: meson: vdec: add driver") Signed-off-by: Alfie Varghese Reviewed-by: Dan Carpenter Reviewed-by: Nicolas Dufresne --- drivers/staging/media/meson/vdec/vdec.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/medi= a/meson/vdec/vdec.c index a039d925c0fe..fba1e7f88d81 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -1026,24 +1026,24 @@ static int vdec_probe(struct platform_device *pdev) core->platform->revision =3D=3D VDEC_REVISION_SM1) { core->vdec_hevcf_clk =3D devm_clk_get(dev, "vdec_hevcf"); if (IS_ERR(core->vdec_hevcf_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_hevcf_clk); } =20 core->dos_parser_clk =3D devm_clk_get(dev, "dos_parser"); if (IS_ERR(core->dos_parser_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->dos_parser_clk); =20 core->dos_clk =3D devm_clk_get(dev, "dos"); if (IS_ERR(core->dos_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->dos_clk); =20 core->vdec_1_clk =3D devm_clk_get(dev, "vdec_1"); if (IS_ERR(core->vdec_1_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_1_clk); =20 core->vdec_hevc_clk =3D devm_clk_get(dev, "vdec_hevc"); if (IS_ERR(core->vdec_hevc_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_hevc_clk); =20 irq =3D platform_get_irq_byname(pdev, "vdec"); if (irq < 0) --=20 2.54.0.windows.1