From nobody Sat Jul 25 19:28:41 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2C75477E4C for ; Tue, 14 Jul 2026 13:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784036969; cv=none; b=O358gLpyFkW/4W5vh03C2Pmnc3ut0FnFqPRsYX4g7qPEiK4ZwFN27uoK9TPuvM8fQ1I4NFnpsILC9XbGFtvunZnKeey+ICEy4HH3BfiP0zvM4dHXHk+Vo2HP77ooJ4R9+i063Ou1LFy75kroOp5tqxLL9+6KrZq5JsUsac9d+xo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784036969; c=relaxed/simple; bh=4WcLQU/ZB2ddX2leJOxaOJJnbeYtNJImDgoylUFs7B8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oBFf7g532fmQJ+1evQFNdIQ6+w69whc7cjn6i2UrLq2tr0IG84ytnXFlYc7BYRUZcXJnMaxXsq+d1DVXww/c26IQSFANZIvp1shbZ3XDixMf33y3iJNFuqtWdQkbHr1IOnTAjkEAbjj/08cFCmCMUDoFLHPOlNveXIvps63dckc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kZuM5cVZ; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kZuM5cVZ" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-381b831d535so1143440a91.0 for ; Tue, 14 Jul 2026 06:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784036967; x=1784641767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dnpCUCIhUIUVob1+81rKKkOZhThYfFIyjzh2lJvfSZM=; b=kZuM5cVZAWMe4RhpI0/UBu1FW24kvfAHwv5b1DQuSuUGda88EnGpVRmNOOo8ZnEd5Z p/JZdGLQeDiG6w6wIgRyCz0ercBHy+6H/WOLLX37NirCyS7C7O52UzQ8F3uUACy4YCZj MElJdSmMpOpcUTTHT3bLFhVl71KuBx51JsJoC4Bk2wjPPnGQ14IMEM8LaqAZuIlQF8xD tm3vsjhh1g02zGXUAbkwMB7/FvUKp2UeLQD9bOnCOadVWEfEWsBH5c1QKTi+D7rWIivG itXaEJGi2pZwJyiE/7Dzz5r4zRJWM5240gbAYymmMOzAHGVHkMq1hULMFnGyiU/h1v97 lqEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784036967; x=1784641767; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dnpCUCIhUIUVob1+81rKKkOZhThYfFIyjzh2lJvfSZM=; b=K1rVMlRQBuOaz+Fb9vqTyiysh7RUZHo5vGctPbRT9drIisBhXiR3Zo/f3A5lpJ+tbp FTkFN0LCm9yT0RgdQjqU779dNN2p5OjY+9p1CCpAWyVpCsp4FZRg+yXAaQdBfm0bLXUK uchW3XaEuiOBc1i7oQpjshsIXwRXG9UKfcg3Qo2sJ9X5FDz9/CU+GjjOkKqQkN9PGKZf xMWTq6gxREtgFOTUL0vMaM8NoFgC/jRAtA3YTMrkUeETnPBrVHzXo+ooN8LNMG+fmlgj lrXxiMhjFM5F4RjRmrtRcn7nDqgiEBwVhGNnxXuzyOTWF9P2MRNkE+Q+2oze8Rx6QuTI 88dA== X-Forwarded-Encrypted: i=1; AHgh+Rp2obd0X8EyWRIULwHYoqIxQOtnQGTs+sKfl87gHg9YVAiip/v1d5PUK94fE6o6isxo52UohYpy00uJuqA=@vger.kernel.org X-Gm-Message-State: AOJu0YyoKQSPwP/TK/0oDcLRkT2+c8IOvQL0HTp1s72c2K0VghRVEoZY GAc8e3vyDmUk5V67lHDMjTsG9XvRbGGUOfDR2pEIj5Q6UqjI//aZ32z9 X-Gm-Gg: AfdE7cnl7FNgcUekiuWCmqbKDsMObLAzrrIn/85hvNy9Bj81WtNsUzXl/nrlWbKw7ce ov4qRT9A61GXUdzm6C6fxtRcLCsoptR7UOzemkgYKhN7xGLEGXag+5Lyib8wjjM7bVueyHthF/G YuIOKYCX5xPtT+AthZ3lUttI0mFY1a1gSiAfzOUSG/wBm+gXPcz4ULEbI8Y6ME8H6FE7AoC7fYc 5NylG6uIG1g/iOmD/mivO6O0km5F7UL0l255+tUYsWENcFIDaZWhoiBTqrugQdvbYwr08NrkmYy xvnP6om4GosStXQKsqeENCwD+6DpKp6r38b7SgagqHGH5yaom4Ee+slUXZiMI+kar1pkZHSGvJR q+dB/wHdvMALG/P5DBkNpcnb3Z8K4t/ptIGiAyXPKNR1O+5WBusnPLmXpWL9eAYQOf9xQwXiq6e KSDbNm/yQtnarWvPoUA2Uw69DPLQLu4x0n/V3HMY71tmU9q+HwHx8UGuFp0V2oloSGKnWrAkE4K uQm2ImmTaKQ+WjbOshfaaB2EfAeOQbj3bWWfklyPVvEOMwxXvC2HvP4jg== X-Received: by 2002:a17:90b:5344:b0:381:e74f:8a6a with SMTP id 98e67ed59e1d1-38dc74d5646mr13154372a91.16.1784036967020; Tue, 14 Jul 2026 06:49:27 -0700 (PDT) Received: from OMEN ([103.184.238.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3117462f5c7sm87462212eec.0.2026.07.14.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 06:49:26 -0700 (PDT) From: Alfie Varghese To: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, error27@gmail.com, alfievarghese22@gmail.com Subject: [PATCH v3] staging: greybus: uart: return tty_alloc_driver() errors Date: Tue, 14 Jul 2026 19:19:21 +0530 Message-ID: <20260714134921.817-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM. tty_alloc_driver() currently always returns -ENOMEM on failure, so this does not change behavior in practice. However, returning PTR_ERR(gb_tty_driver) is more correct and consistent with kernel conventions, preserving any future error codes the function might return. Signed-off-by: Alfie Varghese Reviewed-by: Dan Carpenter --- v3: resend, v2 was corrupted in transit. No code changes. v2: updated commit message per Dan Carpenter's review to clarify that tty_alloc_driver() currently only returns -ENOMEM, making this a style fix rather than a behavioral change. --- drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..24b4dab069c3 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -951,7 +951,7 @@ static int gb_tty_init(void) TTY_DRIVER_DYNAMIC_DEV); if (IS_ERR(gb_tty_driver)) { pr_err("Can not allocate tty driver\n"); - retval =3D -ENOMEM; + retval =3D PTR_ERR(gb_tty_driver); goto fail_unregister_dev; } =20 --=20 2.54.0.windows.1