From nobody Sat Jul 25 19:29:02 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013029.outbound.protection.outlook.com [52.101.127.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 317AB38CFFE; Tue, 14 Jul 2026 13:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784034221; cv=fail; b=QR/JbWq8xg/wEQxpdccXnv+W4sq5fAGkYkNWPPKe5IaZN5YTeSaPOzMjnxy7Ed3748Cauk4PtYwad5HSbs0Bm+WTWA4gxxdhTbz5YXMpr7pvlNUfpBOnyQjWiHNWm46c5PRkqjTm+OCrJjwTN0GWz2sZtSef8JvTg9y9TdK+yaU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784034221; c=relaxed/simple; bh=wRtMfp0SwVRBiMpoqIdnnT7C6nxVB98yEHSGnNSNNuE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=YTqRS0OQJqtOvZeuUHBZWcod38HcL2b6txEbiacz1kUYeObeDV6EvW8rJ4nYsb7eQI6DELYOcP29krJOpUbwfKplzSxkbxjgDj7Sizvf/ife8aUVprdnkCH1tgA7E2Czm+sgPRCNvXywC+k0SRYug32Bz8lelPSrgfNi9RlWzH8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=RqAevoxE; arc=fail smtp.client-ip=52.101.127.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="RqAevoxE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CMIFTLwzowJhWN3B/2RzU40DY6fJnsGT/nOfQxvbPV3P8cKil1ZDfllNVjiO1uBZc4WfBPgL3CBJizliZiQAuGCYOBcIARlla07DNLeKhxKsre86F/MU5/SqQR1kWgQcx3P49gCXBIDKPcRSEwcBL9cGNbaG5Y63+OpBRs6jJ/VBZdYkMqZRfR8CeNjN5I8QRWJAsJKlgdX1d4Ppjv3Y711NPuetwxkWeNBvNwOfjkAa/OVtp1FV2JgS1jXdwPNP5UBYShv/kPIanmjKQmdp1gjBePs2f+K9aDIp14vf5946oaQeEbDglIa3VwVPlBdUaaLdt4EXlnrO/f1i3oR0fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vKS8AdBGqx4Hg4PouSq9poRjjvRaIMtOEV6E2TvcGrg=; b=RXaWJxZNs79tm31ZeAf2ZWZG4U2TYa1EcoWKRKu7ae2zHYtFhiuGPYn9Y1L+mmff/iRyBwJwA9sEwXsfbGk12S/KgTbLjgAscybpWU9+KIDT2/4Z+E+Ks9tTCWAjTizCJPTVjWwVrcZWegTQLfyBktSdhCi1Azww7lgqoEmkEsZr0z9hXBMAf8jt2V4UfC2vUk3RtMrSIm8ukHHZi3/3RKn+WngKdV2P1czt1TQuFXI7rJ+IugF9G51x6pJzPffx2WpaOarVfS9TIXn/fM5eu3gXYajgNBLsFGCkQ9UdlxhHeVSL/awztFV85k21d7/iwhLi6+3SSlyaxoKfhtVFXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vKS8AdBGqx4Hg4PouSq9poRjjvRaIMtOEV6E2TvcGrg=; b=RqAevoxEpxioBJrJkUGcocBf7aUU0fkGtTy8QXmWkhFFKwaJolVbpTkiakGbM8ScglVOp8o+W3IYoQF6a5VP9oWG9O5NwDyIT8Wu1hDKLLD6TBZXmizRqg4jdocLsbS3b7sbwUSOcF7MN5iIGmus/vWFnQYhJmPGXpxu8cwPQ5WxjMy9rcyHU9lXxFOUQ3fTjuOqTpX/lh4ue70yVMq23eCw929fk7VnoB2tDd/t20mHBSdU87S2JrrqnCK/zfxHrx/g1KmIijsECZ6yLsOiBiDuYWdxOAhlAaqQCZQYaZR+pFpebLcetCztsSnfgKK6QY5Nr981hp+WhvznqwIk+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB6666.apcprd06.prod.outlook.com (2603:1096:101:17b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Tue, 14 Jul 2026 13:03:30 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.018; Tue, 14 Jul 2026 13:03:30 +0000 From: Pan Chuang To: =?UTF-8?q?Nuno=20S=C3=A1?= , Guenter Roeck , Support Opensource , Jean Delvare , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , linux-hwmon@vger.kernel.org (open list:AXI-FAN-CONTROL HARDWARE MONITOR DRIVER), linux-kernel@vger.kernel.org (open list), openbmc@lists.ozlabs.org (moderated list:ARM/NUVOTON NPCM ARCHITECTURE) Cc: Pan Chuang Subject: [PATCH 1/2] hwmon: Remove redundant dev_err()/dev_err_probe() Date: Tue, 14 Jul 2026 21:02:24 +0800 Message-Id: <20260714130228.449233-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260714130228.449233-1-panchuang@vivo.com> References: <20260714130228.449233-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0305.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:38b::16) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB6666:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fa1b259-a059-4463-6efb-08dee1a84d04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|52116014|7416014|376014|11063799006|56012099006|22082099003|18002099003|6133799003|38350700014|921020; X-Microsoft-Antispam-Message-Info: /DnQ2iicpMsWS88kJv+OejiZr8PhGRX2bd1hucMcXUp4Gd1YEKLfXqqIZKpNrnUgWToqDCROzt56NOcwloXvxv/WIcXMvPv31qW8VFKle00SryN5IZWDPtlk1QpLtdn0xuhoq8AgU3aPLfIDNTfq1Vucdv0P5jXxytQOTMdIwzC6mV4m2N24bJIXLwyJNLkrYEUo3gLlY6vZW1kZtaGDycc52PLuUMf2xwVSiWa8L0jkYxmPouYRwcDDuHhNqZ4eEDg8mLfccbghzY2sFrbGHFSXyVXbRtzpUFbyt3E9E3UJ9vESwaOmLuDNg2CxAsRtDc2d4naQIMG1AYSSILjYaoi8vPFkD5oyPLxEmOBe1gkhwLF3dyKR0DtEwfi8I2Yfp7WlUtjq0qYe0Fk9mc8hND/+aWdtggdJMNVeii5Wor47VunAPS7V/kzla7zw4hB7VD7ClETzCQniYDD89vr5CIDN/UPuK7jNRsueiZOtzaWGpHIVD102TlLKGNsGiM9A0OxvSK4Cp/rgStuIBTwaxK2ycH9wlhxkrNMXUrz0FnrMuJ7ojeOydBnHrSKvtvufEV7gtwfiA5Ki9r5ii4jg4fWHPV31vwvOeAvYXvOmncXvm/igtcIl81mBewJ+5xBGw1PJqlYjZH91LEUEUvoQW+y1Z8foptQ5QTYeqLqVE113RlXE++L0AD0jDATmzCknqrjwMBqyzJF0ZdOm1GNf9s5ekmtWgvpOSn5cM9uoS9L6Cp3ZIVVVyQ1H9f6ad9nz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(52116014)(7416014)(376014)(11063799006)(56012099006)(22082099003)(18002099003)(6133799003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KpF/fYA8HJM3Dms+M0t2a6SPEU0qAM8sfd4QPR8+gimiGxzIca3rn3HXggcV?= =?us-ascii?Q?oYKE3urEiBt/6YoJICSSThhpMgftoi9x8BPHE+9vGfHZMp+aYKzqFBde8R2U?= =?us-ascii?Q?Gorp/Pz1q5Vfu6B2TFmz4Vp/2+CALgqffw5+CEiJyuy7nr/jsRIW/O97ENd0?= =?us-ascii?Q?pqO/PKBwVxGihGhmU9xlHcCVzlgkOAmlGgcDqQP9Za5UDm+42YEpXerqSFXM?= =?us-ascii?Q?jUOfZXR38RrsiBv9SlbP1I1fS3lY6f19jfVkNHeFacWZ3/cO4fO12B61OaVa?= =?us-ascii?Q?8qNuFIUbF3y0Y6WsXvxHsHHokccnUY9XD3R1BzIz62cq2prwm2nk5aVuUDsc?= =?us-ascii?Q?sh5+yiRKpOqB7ygZH1LSGGSVGuvvds0H2Xnfmw+fCnlyfuUKo22x6xtHRYCY?= =?us-ascii?Q?SD+waIon/H3Z0GgKi2K7t4AsqRf/YiMfrvThTORfP3465NEjW2VBrOKCWgaC?= =?us-ascii?Q?j+qjvQOmsjuyMjlHNn9qs2qvKwXXDqSdwVzc1eJu7b3Cf1/1m1N9T+JqoGpI?= =?us-ascii?Q?0772Q0xmxVdssDtXR3s75XCaHsGnpmW2aw+ay7eLs0tb5BprEavDgz/JasT3?= =?us-ascii?Q?5gRXuNZ+gjT0Tq+/uAuLOkkseQjacIw00IQ5Q+7vzoMkqOfzGwk1fd0I1TJ0?= =?us-ascii?Q?EiCwvcDDZoy4bSashBI6zSqGCgvJ1RAo3QlwaGxTWph+yJQybRDjgfF8HWRp?= =?us-ascii?Q?SKW4zMFtLhw3nlxgt9Vi1mKFQugHdteEk+RDwoxvSLtGKfD69yB9oZPDmg7a?= =?us-ascii?Q?4dnQidOCwaAykZQ8laNqih6m6UyHjpviHptU1ULsqkgFRpEs/CWdwvtAtI8v?= =?us-ascii?Q?MGlA0tMHZ6DuIQzdx+9h/slyZeOqegf3NbGEMV5kp962t3zJB5PyKtmkIUZa?= =?us-ascii?Q?mUf0TqWlGPENiJA11CBhQbu+LxwJ0eVX3hycqG40satu62Hb3uGdCy+DUA/T?= =?us-ascii?Q?usRRaZHPkQnepgYBr1YofwA5yrKFFCyCqH3HT3hnpLOJ+LO39dRaAzvdY4hP?= =?us-ascii?Q?KQxaK9MVpxpwWDL+FqR/yrq8gsfk7i0XYI7IvvcMfvscUL3Ee7iy6vrjdmyL?= =?us-ascii?Q?f2FIV+ykPG6/maiGKA/y07i2RqStVUcqdwl1JpNtyi8lcBP5Asad35ILZqin?= =?us-ascii?Q?PVvcCpfiuUvndjfuf1fAS8kF+wBvUqmxdf77ziPZJw/vs8A7YxQnzyHvIEQo?= =?us-ascii?Q?doq39LEeXGKHKQewQxyAGf/oauAzmRSukb/kY7rG0CvlcBAQq+fq10AGoA2k?= =?us-ascii?Q?1GB4PeCQzgJ5gfoLxwCEkG4ibEw7wiPjgb/cctGp0xXH/YjTt3cCZ2+WYJUh?= =?us-ascii?Q?8mA2u+9DdPTnE8gv918kC9lHRRIn60o4PCqQGooRE2BL4J0QIyAPGxlCvfba?= =?us-ascii?Q?IlnYLN3XwJ7xk7HcUkMiWjrgKjY2684j4SaJ1Wz20onCN7FsGR6HUvX2JdE0?= =?us-ascii?Q?4HzhxVflTdmLtbVV3zK16zyz3jMJBdX+He0YA0CehIQJyKdC68/zTrBbzWyW?= =?us-ascii?Q?G0lVhtgQeMgihMFYeWeYzRBrCRyjBj9fpPP4zcJ45d1kN4PEKG4fyMNvGsup?= =?us-ascii?Q?9jQIwKn+qDls4ZUJsmVwBaAaB0jtE28nDSsvCiNwRAUsaARI2D4T7BKNGhLN?= =?us-ascii?Q?eL88IDrZu98BzJHt53x6fixD89MzjB066jtJTLRYeJVNd87maJGRLOUxdisu?= =?us-ascii?Q?W5etCa8bUHp2EEh+mSUDaTS+AOXPwg6kxpKShFyT2J9iVNmkXnEAseNHn1TI?= =?us-ascii?Q?mBzBKWZzwQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fa1b259-a059-4463-6efb-08dee1a84d04 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 13:03:29.8203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u77HoFae9dvgxntUHMQnDLp2XqoZzo5lEw8JCTOjAlMafICy4TWxDTPK0Z5G/T5wbpwUIuT30KeEOqGYIAxZiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6666 Content-Type: text/plain; charset="utf-8" The devm_request_irq() and devm_request_threaded_irq() automatically log detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/hwmon/axi-fan-control.c | 3 +-- drivers/hwmon/da9055-hwmon.c | 5 +---- drivers/hwmon/lm90.c | 4 +--- drivers/hwmon/npcm750-pwm-fan.c | 4 +--- drivers/hwmon/pwm-fan.c | 6 +----- drivers/hwmon/sht15.c | 4 +--- 6 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-contro= l.c index 1cb481a1ad26..04a767d762b3 100644 --- a/drivers/hwmon/axi-fan-control.c +++ b/drivers/hwmon/axi-fan-control.c @@ -508,8 +508,7 @@ static int axi_fan_control_probe(struct platform_device= *pdev) IRQF_ONESHOT | IRQF_TRIGGER_HIGH, NULL, ctl); if (ret) - return dev_err_probe(&pdev->dev, ret, - "failed to request an irq\n"); + return ret; =20 return 0; } diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c index 7652d553b8ea..7d330baa0f05 100644 --- a/drivers/hwmon/da9055-hwmon.c +++ b/drivers/hwmon/da9055-hwmon.c @@ -256,11 +256,8 @@ static int da9055_hwmon_probe(struct platform_device *= pdev) NULL, da9055_auxadc_irq, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "adc-irq", hwmon); - if (ret !=3D 0) { - dev_err(hwmon->da9055->dev, "DA9055 ADC IRQ failed ret=3D%d\n", - ret); + if (ret !=3D 0) return ret; - } =20 hwmon_dev =3D devm_hwmon_device_register_with_groups(dev, "da9055", hwmon, diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index 4b9c0ccdf260..348eea5bec3f 100644 --- a/drivers/hwmon/lm90.c +++ b/drivers/hwmon/lm90.c @@ -2918,10 +2918,8 @@ static int lm90_probe(struct i2c_client *client) err =3D devm_request_threaded_irq(dev, client->irq, NULL, lm90_irq_thread, IRQF_ONESHOT, "lm90", client); - if (err < 0) { - dev_err(dev, "cannot request IRQ %d\n", client->irq); + if (err < 0) return err; - } } =20 return 0; diff --git a/drivers/hwmon/npcm750-pwm-fan.c b/drivers/hwmon/npcm750-pwm-fa= n.c index aea0b8659f5f..df24dec78e77 100644 --- a/drivers/hwmon/npcm750-pwm-fan.c +++ b/drivers/hwmon/npcm750-pwm-fan.c @@ -991,10 +991,8 @@ static int npcm7xx_pwm_fan_probe(struct platform_devic= e *pdev) sprintf(name, "NPCM7XX-FAN-MD%d", i); ret =3D devm_request_irq(dev, data->fan_irq[i], npcm7xx_fan_isr, 0, name, (void *)data); - if (ret) { - dev_err(dev, "register IRQ fan%d failed\n", i); + if (ret) return ret; - } } =20 for_each_child_of_node_scoped(np, child) { diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 37f37813ea51..3b87f65bae05 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -628,12 +628,8 @@ static int pwm_fan_probe(struct platform_device *pdev) if (tach->irq > 0) { ret =3D devm_request_irq(dev, tach->irq, pulse_handler, IRQF_NO_THREAD, pdev->name, tach); - if (ret) { - dev_err(dev, - "Failed to request interrupt: %d\n", - ret); + if (ret) return ret; - } } =20 if (!ctx->pulses_per_revolution[i]) { diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index 101cebbe68e4..7bb2105d1ae2 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -981,10 +981,8 @@ static int sht15_probe(struct platform_device *pdev) IRQF_TRIGGER_FALLING, "sht15 data", data); - if (ret) { - dev_err(&pdev->dev, "failed to get irq for data line\n"); + if (ret) goto err_release_reg; - } disable_irq_nosync(gpiod_to_irq(data->data)); ret =3D sht15_connection_reset(data); if (ret) --=20 2.34.1 From nobody Sat Jul 25 19:29:02 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013029.outbound.protection.outlook.com [52.101.127.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9983C466B68; Tue, 14 Jul 2026 13:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784034224; cv=fail; b=I320calwzTX8k4ciGyIDHaAkyI8wOfmfTCV22c1euVu7eI+mJuQOpOeSi7O5Ct9u86H/tzynhZkgm+5vqXKhKogNGiDT2fmtCBVqJAqLgG8rB+9St2NdAg8ppTU6dm99tAqoHESpNCEsdnTzAWgm52gbttY7bTieqnkQX73IY24= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784034224; c=relaxed/simple; bh=FdqmK4R0ngTIrWN/atOf0CKYzv/ic6y0wiSj8kXgJWE=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BUZALicfSmau9fzUWeagUvUGueQBBx9DfMFhkVoAaIANz5NNmFZ3sAJIAYbmOh6Rn0jQVFf+AfTI/a1FDf+RnWbB3TaFGU5Awyd+SdlFlH0wQkLCWRT2GI5P7T3ZiYNvHjOLcFMdLBFSM4hkJGaBw9gCjGbPp+ipokIbLzHfrgQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=NezwkluQ; arc=fail smtp.client-ip=52.101.127.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="NezwkluQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kkTzkLqC3SnT0YdHpMqVbU9U1Cp0JFPbHYK8Ly2R8Ait2M1N49AX8y8Z2nlOYr3juoXpZtPL779D/HqNDcCQgWhmFQC8lVf/RVasEq06OlJwhGsmr32ZWRLrak7ZY0zg8xEXGRlSykHC6cxf5OgqjfE2pLp9TXD0cmkX7NZki9R3wEmDV2rTTgcno1XhuZFkkf7w3iyl4SolLuKDiAf5nyt7j+p/aqTxp9porsWycqfGDaEiHxLI9QUOBwKYW39ZGg79tqJXc7UhLAxCi2QT8Ax9SZG/h3m3hL4zoKe/mAMWxh+FDVQEyF1fJRfmXY7DiQ6cOM8BxQz8YFKXz8iq8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FDkEPnGPwCC1QhctPu5atJ1jJsA0SzjKdAX0CD0CrPY=; b=oT7AMvrLGvh09LfKs2Iz/DL7sc+1JcnWT/c7HHNtIH176NikqUK/KLFWuYVEk99AAu2WVzrhTIImVl8oGFottGIbEQBJT95EzRnfok4bbsf03pZJxEuof6Iq+1f3fWBsmO1WLVpI5DFido9/zAVyFRNrOfM6Up+80Rb2p3BIdpJ+HhT9YYSrJOzmoFfcRxibGMJp8/iiEv4aTRrOU8AhihW8hkak7NMHNnIzLnSYV4hN7tUUJgEC8eNaAsz3BlCqMUyuqe9xjgLOQfbbJKFo7iJIOybb5avL2rU5Ed7oHrz4AK8l0ZREcBfnRQ8KnTgLfJ2wSDOQcbxuwod89z6bsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FDkEPnGPwCC1QhctPu5atJ1jJsA0SzjKdAX0CD0CrPY=; b=NezwkluQVpy0e+qZVFnRTCp3/Wb5s6QSAW1dYI+5ducUyXn0V/MaaxGhg2bHPh6oMIAMgBeRS/ghrkww3xSf8DBZdtErXgGvjprgdfvdM363RfxHSL07gpSPMoxCTgiP8iBtnQ0QeeNNo/XogXsqVRLvbwmJyL77aVqLN67pRUHcyZfKPSNd66v8TsYEsA/dJMYQLf84pxQblWVKK1hU51tF8Py4iA2cy4g2RshA1LjHs1KotO6/jdKlegEoIpkF6sSJUZW+WSOOnVmVdS8XA3uSTAz0myTK2zeILUlVPAeY7Z0qzpCXOSvSg9H1zTnKGD/RkS9Fwq0XGJUsRM4Mag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB6666.apcprd06.prod.outlook.com (2603:1096:101:17b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Tue, 14 Jul 2026 13:03:33 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.018; Tue, 14 Jul 2026 13:03:33 +0000 From: Pan Chuang To: Guenter Roeck , Sanman Pradhan , Pan Chuang , Ashish Yadav , Abdurrahman Hussain , linux-hwmon@vger.kernel.org (open list:HARDWARE MONITORING), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] hwmon: (pmbus) Remove redundant dev_err() Date: Tue, 14 Jul 2026 21:02:25 +0800 Message-Id: <20260714130228.449233-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260714130228.449233-1-panchuang@vivo.com> References: <20260714130228.449233-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0305.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:38b::16) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB6666:EE_ X-MS-Office365-Filtering-Correlation-Id: df4a620a-166c-4e3d-bb8f-08dee1a84f4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|52116014|376014|11063799006|56012099006|22082099003|18002099003|38350700014; X-Microsoft-Antispam-Message-Info: DhbQ5XlzxanbUX6U5kh/BCuAKYLbW7vgAycXbev+oZbXFX9CSMm3u1457KHYbsezimBnNQh47H7scajtzPQHWjDQmxqllESDEyw7rwasRRd8O0F1rr02os+iEHslLESkMphWu6tjInFB2XvUV7G2pe+1DD/JRwkyfsqgOWDbZuaDhoprJAAlnwPC16a0sXhElQbvG/s9j2zHmLcXwimGMZsT3QA/pIaImROV2tvBYK/S2QUirA8BVKdF249u96H/kIG5mupe2d2gyeGbBPIUZuwEXJTSwN4EgBGf/LjSw1YtXjQm0JEvZre7QLk7hoZdVr3tcCdHHbT4K1nZabdknBb40XELl31XLXakEEfsa7IzVAEskiCbM1GlGoqpiBwjPbbEfvLLBD5PkPF3DFucd9zr4+YPXBW+M4fYRvmEOr4MLbOfRnwgYfD1kfv2IjeOClF7wO4nJDUFVRx5bwaJt+d0AqnOUZc/iZhJcrlzw/MYFkQonBEGJ2pPaUOoIq8+g8VBRPsjRGMvAD/4QZQQjz8Ih2cc3R7p8JMh4SAHwV0jEIww61AndmQfr5ty3Xgcj6zB4+Y0t2O9OrCSEWeg469uTRCWjEW22r/aE1rw2c07IAMbGD7U6I7m7ogkSzlKkYfS8D4Qbv+k7QVsBgYTahQhy2qdY+oHZ0IhbE9u17aCalECIBvLuCshUFKFQjMFPhhFGeZGCdPskbWIKzmj0auOGqfWUeIVoNCxXaT0+W8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(52116014)(376014)(11063799006)(56012099006)(22082099003)(18002099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1fgi7wmz04vXR87VcVvlMmR2okoE1yadbJCOW/zPGsxeWf/NIlTyuTv464ia?= =?us-ascii?Q?1eEPUV2AxgJFSXuOugwogQ5eMxx6nZUBsJChrGGwHSfG03QwfN/10MALv/ds?= =?us-ascii?Q?23ZK9zFFZQVQ3celgyOjhWQ0gYlVTRmFqdyoTsl5USSZmODCgMCnzd5Tz2uh?= =?us-ascii?Q?cxoDlM93Z8JagRGAlUyhOxvOC3F5oSL93yxY2jtGOAPER5ktVzZkR3KbW+H+?= =?us-ascii?Q?bQqkuCign1GjO+xslYNH7GGdGH7R0VboaBFi0w5Nx26JHa6N5MjV78kTp8Ka?= =?us-ascii?Q?WEMIyOMvVfi/NhNZq+l21cNNT5UMDm7lIlYfiLU+PzYnPChkm5xSyn+kJXSR?= =?us-ascii?Q?FImAIMJBtxYTeoe873/cDv3S7eIX/V60/AOO8kzrrN1wggEsSyvPqesgdYpp?= =?us-ascii?Q?PQoszoUSmyoed2bT5sQnNAXrwdoYBr+L0UOqSq92I4vb5hzOCvEvVTX6F4ut?= =?us-ascii?Q?5uJHkx9rOb1U1A0ecB0LybvgbdoAiTEvw0Kw04s43kHnYPOsqGihIXvNQoqB?= =?us-ascii?Q?lUGqCnJielmKg7j/K6N0+WFQjfQdQdTBhSh0aYJGH0Ifn8TogqtWMQ6IgN/X?= =?us-ascii?Q?LLUhYO21s2rzBoG6VbkjweubSDBH+By17J5kzU99Udqw6aOEON1ryFyfouXI?= =?us-ascii?Q?UMemfZ6HssO6/Xkpa4mZuLJ200mQKTYrsqWvSj8CUQ4r3irKBtKUQq8nHcVG?= =?us-ascii?Q?atVx64Kg0cinateKZedaMGxLRPc0wgikthazdIs6/8Ig7NcryoUVRJuKN8xK?= =?us-ascii?Q?MPftVCdSGx6Y/5fD0g8AR29g5KzFLb0d8BJNI/VC+nSQO3aEMqvFUu0pEtnS?= =?us-ascii?Q?4QkTKErX8BYPaTJY4p6H8CMOe+2Z/Q0l8yETvMuQU7suF7JzHucSCagHQALg?= =?us-ascii?Q?I2oxMeNqvSW6bF040wtqloTyhaS4PUN4/rVVvoDXkUXO2LuKOEHk8T2mEwLV?= =?us-ascii?Q?eClHDfpNp5dq2YGSX9sAkQKlSz2eRUl0hPW6zD0Ciu3f8YlRPguIQ6XQ0i4g?= =?us-ascii?Q?ZxXXbUOCxpuJLzs5n1mZxxKPX2Cl46n6WuNqL+oW3BDM++boUHWsHlhDX1z0?= =?us-ascii?Q?0QMCzGcMeGB1IMtHYydy/osKXNgvo6bGUjvA7/rtrVIL+PlHZxA0g1k8UugM?= =?us-ascii?Q?8uSRwsp7EmpECfNm0nWKcX6g21VZhxMNdLO/AaZCFWKO2fZ0DfcJjHDg/Zvx?= =?us-ascii?Q?kPnWtYmgfF0hS1WLMkoGjuBKHj7i6VQ+FCQ2jKx2GygDs3STtGbTo+FWRJfG?= =?us-ascii?Q?c52GFlfOXPd0R6ZegEUO3k9Ou3bPW54+7Qq78LS7ZfSVKEUZEtkMLmVneZUz?= =?us-ascii?Q?9jXmZkF99LUFwclIAelo2Yai6yzPvcA213xOnF4rY7tckJ9OCMgn0HRvSFhX?= =?us-ascii?Q?jKblByGLosP6fG88ASR+p3VN1oRHg91z/JK9Zj95DKfAhIniBoseClVOa3lB?= =?us-ascii?Q?X8hzqW5+bTHkfbl+/VX9W/zjSZBf6xZuEsU4HF/o4pknk0zTJX7XiV62SGOp?= =?us-ascii?Q?YqRQ5z9xnUU8Ik2MhqmaKRdZ8hUD2uHGvPqS+c2EHvz54xIlU6mcuE4Wc9LV?= =?us-ascii?Q?iWTmywZ+Bf8cddJ6cklPtB92iJ18TKB2QSEnSY7f14Ioxajbjj4H+qRm+NL7?= =?us-ascii?Q?w0buGE29Gsq9VmELwZNrN5miV6h/4c713arOsiU5vHixDsgXT6H9Dwi47Xtj?= =?us-ascii?Q?GaJgIWzda2HR7m4Mw8nxTKhi/PFHnS37y9eanr282IfDZym3Jv9KLTDjBlIc?= =?us-ascii?Q?25Eqz/7SIQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: df4a620a-166c-4e3d-bb8f-08dee1a84f4c X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 13:03:33.6218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FttWb33ObHwj1zcoMp5NSf8UXPtkEdTOydQAaef4QiqffE8wfOtZep+B9ctltWOGd1jiJVU39Ku1I7/UwbwzfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6666 Content-Type: text/plain; charset="utf-8" The devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hwmon/pmbus/pmbus_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c= ore.c index 3143b9e0316c..91771747e2ca 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -3496,10 +3496,8 @@ static int pmbus_irq_setup(struct i2c_client *client= , struct pmbus_data *data) /* Register notifiers */ err =3D devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_han= dler, IRQF_ONESHOT, "pmbus-irq", data); - if (err) { - dev_err(dev, "failed to request an irq %d\n", err); + if (err) return err; - } =20 return 0; } --=20 2.34.1