From nobody Sat Jul 25 19:28:42 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7786371868 for ; Tue, 14 Jul 2026 12:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784030474; cv=none; b=BTT3RAo0+EfIbi+e0qZll2oG4F57OuP3z0bG2ZobNuqXzokdiq4l/IVuLFzK2gyWiK/PjTB1nyHevnD48+n18i1VjJDmCb3SzFcgOe2u4SXL2L/pylr7sWy84xRACSAefcGFkqNLZx+02uI4fC/9a9tZhrlerB08fZeWYKW3PkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784030474; c=relaxed/simple; bh=tfzgwTa7BiktryzGWIkcyRE8N9h1/Jk912Ti1RcchOw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KHSTinfIqwZLksDNZNzAyPi1EKsxjt+Snm8IWVADMLT4dcpELJBTzo4tG7Juy0q0hqxuC2hacsZy94q0Qo2Qm1ZOmLibGNKadGgtM9QchgwwHuDVGAaJgrWPaYWZTmElfeG25uwPS3jFUNVPZO5ACw73ysYh4mz1XCJWjPZpJwI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=knNTRTKK; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="knNTRTKK" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ccf2360620so6551025ad.3 for ; Tue, 14 Jul 2026 05:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784030472; x=1784635272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=un1/HNmxd017xfWTCfNi2/7YdurFwymQXIdYAIjBxB8=; b=knNTRTKKBpS5xNKvJ1oeWh97QAwv7gEO9ddLKItmGWlNDus1Vtzrkpp+oG9LDyPybe WhVCTd6qdbBqnnXqbNtw71UVyZRMt28vCXbaCDUxjXut2lf1HX6QncpuU0/Z4Un3Oqms O30cechpnGV7XuXzvTSngQHxufesthpDJbToARb0lgVLx9tsOF5dqsam+SGWTHtM7jFl SpF/S5rIeBqGMw3EgmpcV/aF7zFICLwFOs7N7ichZudwnXRbg2ZOiAwxh+6Sz5DW5wHp 06svUt2Ot5bCOv71wt5o4IYNL1nWyqrhl8N7xTsE8zvR54FNTI9oF95BxO9l9GBMm2ii kytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784030472; x=1784635272; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=un1/HNmxd017xfWTCfNi2/7YdurFwymQXIdYAIjBxB8=; b=GQlXDPN3hl3WG5A0pkfPwLliQgLoQ2I4WTOThFdZ7fM/gPWwRQFCLpvfy5Pt0z5LSk sNUxgeE9aSDfgbTOCo8jYHAfDFAN2sDxvmUHZnyDNfHIf0C3L+qa8fi8HKduHWtL4c6m suKmIw1juYDWAt1zVpAcQXBrGjFBCNA2CVDQOntCgYOAH49x1P7RcdCH2oh/WSDZ7CYc ONqhwh93huuiVSeWYi1ImjyMYaHa8dAlEel1QeTzDdoAxkyXIQnGIOeuRSoTfYiA4C2D nkWRkbTZ2orz3W7DGt7Xzxz0QSIFi403Er8VEUa3AktRfgOd/39vk+12dK3zpRXY6nm7 nP7w== X-Forwarded-Encrypted: i=1; AHgh+RqngFVeLKrPxpAn2k57VpTDGKXlAJ6zRBnjF0Twq16MDVgPvHBF0eGewV0//a7cdJjC//naAXHHqeKmjLA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhkcyjv3GbpxLwy5mHbGjpEXCLs8FtwAXY+Lchyv4HKl1Td/M+ mWYcWTJUoBMy7Bea1mA6SwgGlC8BM1/Qwh/u9s0U7Mf1kb7Z9MDTBELGm78pg7tT X-Gm-Gg: AfdE7clsp+uKTBG5HdYZD+UEYHIFwWXBYhdLo4MdAAIk+ami/fKw8y51ri3G2IDv9jT R9ZPCRRPQYWKXxhLOlo+eULw/eNxptvZQF0FYXLhXsYyQknh9yjEjap90+mLRsJUHjf+B/a/LK1 HFxGTyiv0ifNukPT7FKbygE3QeLMS57VXL6xKezGJ7ATon0ZPZ0XnbcoEDfTf0mpCU6vZC8trZV 4s+wvZOZM8P+IM7Xw1EZMJx719w+Fii2HRBY3WWhkiiFHbZ2SHhP/mqeTZj8QS0L7c7vUxxxsAN PaAaJPRd/GJRo0oYahQbe8CORlyHmT2+9rtO1GmNzhcIQq9RKpuuFhRUAecJIzE/gnuRwQJENeu OirSj9yCPioHgM8OeHHnkD2/FxEk2P7wLvVcJeXm4LuTFtQ3Yvmyw9NH3kfM//dI1yZHS1lkuCL e6guY+VW2JyNVXpKDvrGFwvNfOSOQ0sCW3tm+SDQ== X-Received: by 2002:a17:902:e5c2:b0:2c9:97a7:f544 with SMTP id d9443c01a7336-2ce9f179c19mr123766045ad.42.1784030472044; Tue, 14 Jul 2026 05:01:12 -0700 (PDT) Received: from DESKTOP-EQETL3O.localdomain ([182.225.143.210]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb76asm118605335ad.12.2026.07.14.05.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 05:01:11 -0700 (PDT) From: Hyeonsu Choi To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Hyeonsu Choi , syzbot+aec1962419768c5caf88@syzkaller.appspotmail.com Subject: [PATCH] HID: input: allocate input_dev name/phys/uniq using hid device devres Date: Tue, 14 Jul 2026 21:00:52 +0900 Message-ID: <20260714120052.255085-1-chlgustn3171@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" input_dev->name, phys, and uniq are directly assigned from hid_device. It causes a slab-use-after-free bug if the input device outlives the parent= HID device during teardown. Fix this by using devm_kstrdup() tied to &hid->dev for name, phys, and uniq= strings. The string lifetime is tied to the parent HID device, preventing a potentia= l slab-use-after-free bug. Also add OOM error handling for these allocations. Reported-by: syzbot+aec1962419768c5caf88@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Daec1962419768c5caf88 Signed-off-by: Hyeonsu Choi --- drivers/hid/hid-input.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 3487600cadb4..da6b338f18ba 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -2125,10 +2125,21 @@ static struct hid_input *hidinput_allocate(struct h= id_device *hid, input_dev->close =3D hidinput_close; input_dev->setkeycode =3D hidinput_setkeycode; input_dev->getkeycode =3D hidinput_getkeycode; + =20 + const char *name =3D hidinput->name ? hidinput->name : hid->name; + + input_dev->name =3D devm_kstrdup(&hid->dev, name, GFP_KERNEL); + if (!input_dev->name) + goto fail; + + input_dev->phys =3D devm_kstrdup(&hid->dev, hid->phys, GFP_KERNEL); + if (!input_dev->phys) + goto fail; + + input_dev->uniq =3D devm_kstrdup(&hid->dev, hid->uniq, GFP_KERNEL); + if (!input_dev->uniq) + goto fail; =20 - input_dev->name =3D hidinput->name ? hidinput->name : hid->name; - input_dev->phys =3D hid->phys; - input_dev->uniq =3D hid->uniq; input_dev->id.bustype =3D hid->bus; input_dev->id.vendor =3D hid->vendor; input_dev->id.product =3D hid->product; @@ -2144,6 +2155,8 @@ static struct hid_input *hidinput_allocate(struct hid= _device *hid, return hidinput; =20 fail: + if (hidinput) + kfree(hidinput->name); kfree(hidinput); input_free_device(input_dev); hid_err(hid, "Out of memory during hid input probe\n"); --=20 2.53.0