From nobody Sat Jul 25 19:28:42 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FC5367F4A for ; Tue, 14 Jul 2026 11:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028054; cv=none; b=m45iS3ZljRCikGc9fPrGYrwtbRTawrFwXzwfM58rNDhvviEyrb5uz0V+ib+mLbfb9WQAnN0UgLbtor7hDyfgWY3FIhD6oEOvvyU1u0xsWz8YEu7zY2ZroDPPPbRdednx/bnQGLBd0EFBMuiRg9ojYAyOqC05uIil3eU8EB0PSLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028054; c=relaxed/simple; bh=5U8Xt+5FII5bnnfNrELICp5w/0y/KFXkF6lLjw5vPX0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ILm4sIFlbhxjvOz6fprop6wFjzZRkZi2PJnGSI8QZy7CTmv29A3tFlae2yzsFfmziW8f1jn62ErBNrq9RFWvb/p4kgDAcngHBQMe19BMLrYYnWIGYoQuzn69WWK7ue2kffS00wOc0UtD8Fob/dyAHgKrMOrI3p0EBoq6vEX2OgI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XJRhPpC/; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XJRhPpC/" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493e4ccccc2so26824135e9.2 for ; Tue, 14 Jul 2026 04:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028052; x=1784632852; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=c3OMzo2xKVZ4mg1KtmSh/Is84yo0PGktqHQ2pNf/fQs=; b=XJRhPpC/0ddcaI6JKuNFFsN4Zt6Q9T8FljCJrrPLQN8akSTmKTvq0m53Ivz65Vlid6 hgrrYb6ojYGhsMcCnRxN2y39Iq6BFOD6lVHELzbLOd0xy+OEcj1soi/WKy540EvZAUR1 bQeJHARnxFG7WLmwYEz4OuJE0TCeWrUEsyZ3lXnNt3t2OS9ivqXIwGdJfKKOjLZxBH6/ X3GKQaqDkPk69C9dra28p0MpekWZGNYblZWpxEZaPMfTeogmVEeOPOA56hEFt4JvSyfM 2tWg1NxfC0m652yHJU/J9Ilk6I7ToOdNkJi6Ql+L0RKdBgNbH/GRDc3iZMX24EpAWgr9 hHiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028052; x=1784632852; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c3OMzo2xKVZ4mg1KtmSh/Is84yo0PGktqHQ2pNf/fQs=; b=JT45UuJ+G138R05DbJ2VUoxPrzA6FCooMyVU/t9jDwwfvZc4LQ0GpJgh6d8COt/1Dc b2LXh7J70h3vQeNaa7CI/gxi5RJgyACjRAOBvX6PSnDZqDjARBg7ljjmIbyH7WmnP/+b JRoYcw49/z/wOxOeCfMzWsXk6AzHCGkcQ3b73SPM6qL1DEi0zrfztfyTIqatQPREpJFv gfaLAob0c0fX6DnGbgGVLm7ajaiS6n0QrJAzNGrae9NjZ/0exj6CSXsZPtldlC7cpfi6 +CKAndV7ctK3zkJQEUZdm7Br2r9IIiyd8yWK1z4YB3vwUGaCScJk1VjVpuNQDVysM01r ZQ6w== X-Forwarded-Encrypted: i=1; AHgh+Rpm3TMaF53y7tUJ1QZ0ancnWNx4pNeBFe8HS73FKHLMoK7VOh69G2ddJAB1gs/QgLQy/phYSgK+GifJKpQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzxk/pzsxX7y9Ajp6BWDrCz4oWuG2nZwQvezRqm3tMZJwmOhaWB LLiQSioappV0SD38pMaBlF5bLZ5UMenpZgiPMqzHOPcJ7z6OCfdCdDWG X-Gm-Gg: AfdE7ckpyLNVacZfkJAafsFLtGNTDm/va++sgxMNM2fRecuTHZoHitA6ZzeTqIxI0Qm ZnvXauF6l6uD2jxiUly5rQxzQENsUp9+kpdSuXKkW5Eu3A7ys8rCWTbY4cQYRC7PbUUyF2QgSjt Mpj8r5jZNdGuiCuLZQijuymO4MFOpeFGJzNoQCwwvrjx5H9pBXNBqOCbJ9R043FmfNGSosXpgSG PUCHuw8KJQN2QskWNtqSKsbR/cRPB//Rh3rWXYyblTzGbpgqfAxaLia+ZW1zzDnBM5tqbCQPOCj cVpEBkm+tPsFqfTLmse0znlbbl/ChxgCCL/AkjhIql22laLo+DO8X5uoLcF5Wuibd1S5yKARn/T 5eonq+Na634eitGs4HokpoqIv96BFx59J3TDAQkVSeEjXDKIi//AHJzss7f/UwMsNtN0+XwMosY 2a8QW6GVgVbXCLVJF/6ZWw64griQkynIsyW30aNuqwBVzkYxCsrRddtqUza2pEzwGqMZcKu2fyg xaj X-Received: by 2002:a05:600d:644d:20b0:493:c601:3e23 with SMTP id 5b1f17b1804b1-49538992cfbmr15904745e9.5.1784028051709; Tue, 14 Jul 2026 04:20:51 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49508739c99sm65552465e9.9.2026.07.14.04.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:20:51 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: b-liu@ti.com, gregkh@linuxfoundation.org Cc: conor@kernel.org, arnd@arndb.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, daire.mcnamara@microchip.com, valentina.fernandezalanis@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, claudiu.beznea@microchip.com, jassisinghbrar@gmail.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, wsa@kernel.org, ben.dooks@codethink.co.uk, heinrich.schuchardt@canonical.com, Julian Braha Subject: [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Date: Tue, 14 Jul 2026 12:20:46 +0100 Message-ID: <20260714112047.2304856-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'select' does not work on config options in a 'choice', so currently it is possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE. Remove the dead select, as it is unnecessary, from this conversation: https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/ This dead select was found by kconfirm, a static analysis tool for Kconfig. Suggested-by: Conor Dooley Signed-off-by: Julian Braha Acked-by: Arnd Bergmann Acked-by: Conor Dooley --- Changes since v1: remove 'select' instead of changing to dependency =20 Link: https://lore.kernel.org/all/20260711130349.592545-1-julianbraha@gmail= .com/ drivers/usb/musb/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index f56929267eaa..1b0d27d8e02f 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -116,7 +116,6 @@ config USB_MUSB_POLARFIRE_SOC tristate "Microchip PolarFire SoC platforms" depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST depends on NOP_USB_XCEIV - select USB_MUSB_DUAL_ROLE help Say Y here to enable support for USB on Microchip's PolarFire SoC. =20 --=20 2.54.0