From nobody Sat Jul 25 19:28:41 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F08E43FD29 for ; Tue, 14 Jul 2026 09:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784021367; cv=none; b=RDF0tWITA8DXOjXNh8hS4JyABs7WEyP4B93jgJkxTmkQHwsJCWWh2H2PrQQYps0X1FTTCYXTCA+UtBdcASj7/irQKtVB+vauGmNEJZmDTPlJDTof8Wka5343gMjvp17Uh46D4k7Goi/1YQAsLh2LSpyQlV8XamgmsXAfXfhsb6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784021367; c=relaxed/simple; bh=EcYNhb1DhZq08ytH+e0lfJVwg5GPW4pD5PwRpgxsgTo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r94twCbJ5ZyOm/66HZYKwF4wCEDUGs7HGPcGOI/TXC8+XvfcSBLwGB7VVzX9d2RrGIFBxw/Sd/dBvr8mUYesr4wKAh4gnb/rLDOh9UG1MdgIMMA7yoqyiNJCysfXprZJuypxayffQfUzl9CCI1Zk7IORb9uteYZsBnRivmnav2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WQIstewx; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WQIstewx" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8485bd28dd0so4506136b3a.2 for ; Tue, 14 Jul 2026 02:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784021354; x=1784626154; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EUQ29qtnue7GGPW+uOfgi0aOvv9tmXtSIWyDlapW4Xg=; b=WQIstewxA11i3A1GvwlTYgxwfvm4Ym7OLT9XgIbHwLrL7E7yZD1O/0VzW66Y0ZgDxM 5jj0UtdADmbLO9bc3hXYWzL210H0wd+xOhGe6HUIz0FjYi5cu/ox/x0F4UxdreuNUF6y E492q0pgZkjOWEiiWZPWU+FQqoLfzj01s/I30f5BwWKtR9Vidc49oqUnkl4JrIwXa5Yu ZangSjERA7QLNA+WHLQSAGbqO7DRHuxPUdxKkZ+2SwyzZc/TIUfMulyEqCJyB3ZSwkNA nW7mDfVM0eWbN3zB1qKqOa6mnJDmFtiTgcfHw42gvcMOgu+js4ZGEK3fi1OQnLKFMGel 7Lyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784021354; x=1784626154; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EUQ29qtnue7GGPW+uOfgi0aOvv9tmXtSIWyDlapW4Xg=; b=PArJr/vrl0xjZEY710g6BseP8uA4O1/vx68Pa2KSToiHSmdIv9mqXxIJCBG9nAFQkK dQ83cLW7TOhbyS2yu7NlxeuMtRvN5dSAnJiyJNmLxqf76bMIOsLnL0fXQm3T76KP53ZZ dd7sZYShaHe6UncMoTJLn1cOFypD+H1GTJ0xmxk+0SeLG2eXUf+EBREifhn3tdP80QGP iLRAiBuJK8B34QGZtHscrF4vEEkAPML+GGOuBEaXGFU64ya66FMTLnr7ziZKDzZIdGQu yEZpBw6iquD7FSzr1JbW6XN6L6wVUX8+aMPeHqIDVYRgeI/6hhF6UkcVROKadzXxWH0S NUNw== X-Forwarded-Encrypted: i=1; AHgh+RrgF2wOPVqESXwT1EZL8t2/43uy2YwQgj6ArIauwPyJZGQfSpTjgZ4MivpGGZylBoyuty7I5KyXjpqlhh0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6j1wZkhO9tyAq1gXVUvqrPgq8on3KLFALQs0kbQ40blLFLz1o 8Qldlw+cU+FCX/gETfDalPT4+8DZjgPqF6VJbMP2yTqj2HBbAlfvOqhX X-Gm-Gg: AfdE7ckv71PGt9duLbRIpzLfTPuLZN73oZEQzYbo8GNoCNPKWc5DSD5417yutMZ4e8s bcetmKURvUKF1SQ7WmA2KSpDt5BiHmaaY5gBr04A3wP5Hr0zZPfjhuYjcMsmw+qYZcTBYF27SR2 5D5iUZDn8sq/mGcnIdMdS09XUAj7EYYmDciFOjctxZZhveYVs3P/7VK2Wbg9BR1UayRx/KNfejC d3ykaqmQSAOGMBPeF4IK3NI4gwyo8ev3n7/DBsXGFnx1fM5xQtzdfRKwH+IQdxtfUETVDVv1aPX lOVVIwviUF5vuECgy4jlx1ETlxBxreiHJeh6O9N8CA7Ezx3dq8ZeR+mZk2gOvwE4BlQXuvfXsgS nGOUfIWa3iXAlJFtM317MitoOYd7kW/92w/Cik8ZQVz2ZX9wmyh+v7Qnz97UigOWam0QZDejh4J BMryZ2 X-Received: by 2002:a05:6a00:3e27:b0:848:87f0:ffab with SMTP id d2e1a72fcca58-84a5167760fmr2667959b3a.78.1784021354196; Tue, 14 Jul 2026 02:29:14 -0700 (PDT) Received: from n232-175-066.byted.org ([240e:83:200::343]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f278aecsm1186856b3a.24.2026.07.14.02.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 02:29:13 -0700 (PDT) From: guzebing To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: [PATCH v2] nvme: reduce firmware activation poll interval Date: Tue, 14 Jul 2026 17:28:46 +0800 Message-Id: <20260714092846.3381169-1-guzebing1612@gmail.com> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Guzebing nvme_fw_act_work() polls the controller processing-paused status every 100 ms while firmware activation is pending. Some devices can complete online activation in only a few hundred milliseconds, so the fixed 100 ms interval can add up to 100 ms of latency before the driver observes completion. Poll every 1 to 2 ms instead. The shorter interval reduces the delay before the driver observes completion and allows the timeout check to track the MTFA boundary more closely. Signed-off-by: Guzebing --- Changes in v2: - Drop the module parameter and use a fixed 1 to 2 ms poll interval. v1: https://lore.kernel.org/linux-nvme/20260627010610.47768-1-guzebing1612@= gmail.com/ drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 453c1f0b2dd09..c226baf8641a5 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4813,7 +4813,7 @@ static void nvme_fw_act_work(struct work_struct *work) nvme_try_sched_reset(ctrl); return; } - msleep(100); + usleep_range(1000, 2000); } =20 if (!nvme_change_ctrl_state(ctrl, NVME_CTRL_CONNECTING) || --=20 2.20.1