From nobody Sat Jul 25 20:49:05 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012043.outbound.protection.outlook.com [40.107.209.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 309D1381B00; Tue, 14 Jul 2026 02:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996653; cv=fail; b=eWDpD0yAYbrSXYDTdBDQ2+4sW45GdlWTPm4esW8pnyDfeQ7ytTY87GDbnpgP6U9XBtKQaEHCVDWhthn2Dz4fId9ZHjExnO3Ci+9rPokBiRbXJvagyfw5PdJxZ7++5PsBDNgfxJ49mX6Os5RPU5e3XLtdWF89EG4w6JcTqgw/KDs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996653; c=relaxed/simple; bh=j1tjeByXeIHinLjHoJARApYbtqw5FLZrQo/H1IVDTic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nO3Fijwryjjppcp/8wqxt9zZqNhySRJQwmZ8ATTw7PbKuw7dyWGMHsyW3qIOBXkWCrzdsQuhXtVjXdSBP/XadU8hMs+v5kd8LJLn1ZmQLNnEWPaAiYGP3OgybclG5+uA/SlnpUV0L6JEVmgTLnSlJxgk29Yt/l1USu9kSwM+B2Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=jCT6gDgY; arc=fail smtp.client-ip=40.107.209.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="jCT6gDgY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W98pWArnnUyCNg0AB3Ue8gOWVugEdr+zCTAd1xXIHzeVWIynXdN2pxj3aqv0BvBALnF1jxWKYPapJeSL0HOZ/j42r2w+LuLhIvxzAeeZH3myBCZ9/j9EDT8tc7/XwZCObxNIssfvsYLZZG3LItqeSTx47KSF7z6OJaHbDx/79qw5UUGIhqclBhiWaecSEJdzmSa556pXCh8qO/9ToTJO9kBYpckAyANEmG5dMxrXrqUaRMPYdsADsLsKrqxzD91YSfJbRvXKR4G5X0S1gTD18YCtXWEVCT712iwcYvJrjuAV5mBxz2OZu8xBF9iU65lcVJ61C9DobcPlhyVn3ReTnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R6OgbckISqAtzhoezk8E1ClROdhN3BCX2f8lIC8DmhQ=; b=b01TPkqKVsVGE9saRyf6PVtgzKGP+u9PS7Fa4/kzImWaG6enyQ4tKQSX/DSY5cteAiWL6PZNGxpqu5ldR8W+1Aanln0cVb6XdVjn4dpCANMZ2JJ1Oli8Ak8q1W8UIXdENN5ZmnK2bn7tCkGw07C/YDs60wN2KoubFqwZZFbHhG/vw77eVtsWLGJSKTYDWcra34AQ3U+uxjqXjy6ixt5z/HNx+EZPZYLpEfOK2jb9/Jn7ZXoKVl1lsfh3oxbEWS2rd92hSw8UvrviGEiG6YwUDFPAZgKa9HpjHtLP2v1gwzzpUtWy3i9KIcdurkEKnzc2BnNX8Wnw7hYcoimD0Mfsbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R6OgbckISqAtzhoezk8E1ClROdhN3BCX2f8lIC8DmhQ=; b=jCT6gDgYx/1e3dOapej8zr6prMsUhXZCr6AQuyAbHBp2yA+S3D7GSAiCfEwRkZkxxQaMl00r0I8thHsQWtpxVzFj0dcB26YTJG929fTmVHTaNSnyifoTNDKQXHJrjXVl0k/5PYVPk/DrLqE6QOkKsblM0aikPv36VP4DDTXtx+T0F/d13PKAebrIZ4luW0igkSva5YPN6Oc75H4l/A/MFBOu3g8W+hu/nfQsAmDgsGO+gj4HuTaoTmaow8KelI/exSylBa3GVcjP8AUQcluAGo9C4r5PhG2Bk1KhWN1kf3qACpRc/uoHOvr7krgtT1FcJIzRl2xq2i34c8IR4NMgTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) by DM4PR03MB6032.namprd03.prod.outlook.com (2603:10b6:5:393::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Tue, 14 Jul 2026 02:37:18 +0000 Received: from SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775]) by SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775%4]) with mapi id 15.21.0223.008; Tue, 14 Jul 2026 02:37:18 +0000 From: muhammad.nazim.amirul.nazle.asmade@altera.com To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org Subject: [PATCH net v3 1/3] net: stmmac: xgmac: fix l4 filter port overwrite on register update Date: Mon, 13 Jul 2026 19:37:14 -0700 Message-ID: <20260714023716.29865-3-muhammad.nazim.amirul.nazle.asmade@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260714023716.29865-1-muhammad.nazim.amirul.nazle.asmade@altera.com> References: <20260714023716.29865-1-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0116.namprd05.prod.outlook.com (2603:10b6:a03:334::31) To SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6964:EE_|DM4PR03MB6032:EE_ X-MS-Office365-Filtering-Correlation-Id: ddc602f0-d6ba-469d-1e15-08dee150d279 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|1800799024|366016|56012099006|11063799006|18002099003|22082099003|55112099003; X-Microsoft-Antispam-Message-Info: HbTjE3TI9DRIGBKhdM5ZOxH7RC1wJ1hXIias/I6Ss9MVbVg+or/QND8w0+5Zr/DHeo8ZdkFdnvWtVFl0ctJR0OCWynuf0hcHvZoLuuUiQUG01CqfjtEP5855aqAGSSOs0Fv2hcCjSrsgx0ygzTfbIt9yA3uZMB36+rTLIF4deqF2SBLVe31KXV4CCfXy3b6kFLrFQuxhcU9FWHzuVmNLAF3Jy2ZlNxRHzAInsPBcdnfUQ4y6SVN8OI99mBOAT8E1ZXiDMUoI3Vi9YImnF4FiQTqD6sal8x99oHMNTHQGlOKj8V2wCci7/T3uzoDQXhJokkoJmbGx8ZGyoJHuQP0fxa+e9fvVWxu+N9YmbAogXPc4gXabC2ug2gObsVOdEpRD5pXI6z5Qop8ufy8GrG4yabMKS7DqUeSu0bBNWwxgxS9QdrPwtx+uo2ElRFbUpMPBqbuypuLb0adE8zCWDzXIM9dFDjQaW94eFiKo15+zGS43UJXd/0q/9ORYzo2sdzzsCQl1OMASv6IGcY/uJG2O/t7skFq9ardMM3+KVqc4YWj+cgWgJ4t/sst4vK6d4o8EuS60VN+Xtk6j8cclKetAZ8PkdOpVoC7iWQ5iip6ziHLrfIoU8zQK3x2Bh7ZdUM9DqipjuU85AGQB5tYyL4Z+/VPi+PSmBbBRJ5jyNXjnWho= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6964.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(1800799024)(366016)(56012099006)(11063799006)(18002099003)(22082099003)(55112099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tQGfhlK1QbDUXOWxcExUsmsP8inAouSLszVFI0HjYVQ5JHl1BrMox+QzbsNG?= =?us-ascii?Q?WL4iIAJeJwC26eyBDxsDk41Tkir4dPZOrgMomeG3ZNPMfBJLkyEbCTcl6qTE?= =?us-ascii?Q?LTtrEP03Dko19ulXXXJ7yFw7z0XX/EnJLnrFEZIDfR+G6a38cqNaSenEHzGp?= =?us-ascii?Q?b+DJX7vLNdJa9XIOsOhB+CiGKe3tWAVtfTuq8QKcYyjItoeyFYLqD1JANM+N?= =?us-ascii?Q?zWQ1GpqXBgQVKTcQc6c8j+dpZC5szqlNjleTzN4LWU5CaT6s876DXvc8kvwf?= =?us-ascii?Q?b1LlvcIZg4dixAm+/obqtOK/idugp0/G2oJpBHKPVsA8K3f6bSqs5fPO8sfP?= =?us-ascii?Q?juS5Qm3qlOgiWcATxhxZy5LJj9u2hc2v2PPd7DeDH8Scnh2q8KCP6+pAi7d1?= =?us-ascii?Q?+xcx3aNXVTQmhwCIYmEChQ+t58L4azxqmOuqH6I874cuDnwSwb6/KR+E7RTJ?= =?us-ascii?Q?NpVFM3F+d8NSbExkf2Hlt36myaReCV0yGv+fpxIoTYJweIuSG8dISEov/YwT?= =?us-ascii?Q?86D0WilgYzOlCkk5n0VucbtM/pQFeCZOWiGHNfc7S+T8UtBLYusJ+h7iCuPl?= =?us-ascii?Q?fNdMP1eK8ppDe2iYJeCljJO6xCSq+Tia3UXIOwv302Yjq7z36ft8TFPkMHpV?= =?us-ascii?Q?cMIr/YUQ9utukQ39U+cf6blFjMwbjqUoMnXwmmt0t7KIyXIXm/E2tJTHzv9l?= =?us-ascii?Q?4RFuVQtHFG06GWgHyK5QPG7SYnnIwbGOv2JM1HTyaqtcPHG9PzZN5HSO0ibD?= =?us-ascii?Q?VQMhf5tNdOIRkhtzIeoEv5kkd8Ay32ahsfWNr9cu8eiYedZQKsXdoFEYm1rf?= =?us-ascii?Q?qbWWDp1QcP2zb+KVUdN7Hf9Zhk9qky212DXyfbjdkbJNITtc0RRC0q6aPXSw?= =?us-ascii?Q?ykJWDbId1yl9RmwLcclWvr3jYMnSY2yhelV0JZHD+He/VbN4l8Eu0MKOgNZB?= =?us-ascii?Q?zNoH6DjyuQC8vqIsO27CwzqDXUGXQjhj6TBEgk8M74fYjf48yK9gvLWM+PIr?= =?us-ascii?Q?vl8zaMiwv0SZbSr9Ej5WjK8k5wl8a+LUoQn4FvICuUDhEuujmkASU6wgEs8c?= =?us-ascii?Q?RMIVwXPabgWS7OUUn09IOU0wj/S+1uaFOn92TC7LmY3zewpLuzsFHyZlau4c?= =?us-ascii?Q?8+DNw2LzotGqc89rXLzvIcjCS+g/hnsdFl/mFoDF+7P2xPGf2JSnABUF/U6+?= =?us-ascii?Q?alMtUPzEkzDpFnpPLIUDR+EtMN6RTAPa9IobY05Adekf/oFsgAq9DQctqOXj?= =?us-ascii?Q?ntnefQsOr2TE/vP8TAWl4oqP95QJc8jV4Q2UFI5KEAYWPpZPAX2fQ9+arF9G?= =?us-ascii?Q?3uY318gAYOr/1HagIQeUTNc3JUpJCBmOKudX+AoZ8xmHpURHZEWPMSG/pjgq?= =?us-ascii?Q?91unoTKBpUPaUr/Z7jCpDp1EPZFIEL8VWFbvQmQWdaOOnP5p+4EcsG0dhXbm?= =?us-ascii?Q?3BkQetyP4Zkcf9dFYNyxSh8k6PJc7BUHJiMCXpQOT5lBp/wM0Ei+j97ckFsZ?= =?us-ascii?Q?AmflVIV5GAWbPev5RIGqeJzsNb/g3vdfwgTpjiqb2B7XgDhi8JKx9BajBBf2?= =?us-ascii?Q?PT0o9YRq2E+YIF6k3hVIVhuczBiPVi0/GM6B0LFPCAlTXzimkJYU0zN7jsac?= =?us-ascii?Q?O3F+LGhd8MvYB5j8n6v/Ntj3cHEsdQ2Id62xHwXeicD5VOpQDbfrV8w3X+u1?= =?us-ascii?Q?yGifVMGgtu650v4eVBNRxxPrfAxy/QHCGaGW64seNI+ndI0t6ztWWHAthKNb?= =?us-ascii?Q?HUOk4AEKx51j2SVfyrFzdI9wsbnWvC3uMySq98s/I6FwgWj/aBS9x0FMPtar?= X-MS-Exchange-AntiSpam-MessageData-1: CGlfCRT/OTJkGA== X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddc602f0-d6ba-469d-1e15-08dee150d279 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6964.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 02:37:17.9227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 047qngN6sksOxr9rzeEoATBT5t4lzpciZpwYJvsQvx6rfbiAz2Z7i3f7FTpVD0Krrg3yd/ZG1UKpYx/ifjASz6WKcglTUYAEu7WUa/Sd75v7uTJohqqPiKhR77AlUq1rdzvaI5KmPWHi7vETqIsKUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6032 Content-Type: text/plain; charset="utf-8" From: Nazim Amirul The XGMAC_L4_ADDR register holds both source and destination port match values. The current implementation overwrites the entire register when configuring either port, so setting one silently erases the other. Fix this by reading the register first, then masking and updating only the relevant field before writing back. Fixes: 425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower") Signed-off-by: Rohan G Thomas Signed-off-by: Nazim Amirul Reviewed-by: Jakub Raczynski Reviewed-by: Maxime Chevallier --- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/= net/ethernet/stmicro/stmmac/dwxgmac2_core.c index f02b434bbd50..52054f31376d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -1370,36 +1370,40 @@ static int dwxgmac2_config_l4_filter(struct mac_dev= ice_info *hw, u32 filter_no, value &=3D ~XGMAC_L4PEN0; } =20 - value &=3D ~(XGMAC_L4SPM0 | XGMAC_L4SPIM0); - value &=3D ~(XGMAC_L4DPM0 | XGMAC_L4DPIM0); if (sa) { value |=3D XGMAC_L4SPM0; if (inv) value |=3D XGMAC_L4SPIM0; + else + value &=3D ~XGMAC_L4SPIM0; } else { value |=3D XGMAC_L4DPM0; if (inv) value |=3D XGMAC_L4DPIM0; + else + value &=3D ~XGMAC_L4DPIM0; } =20 ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L3L4_CTRL, value); if (ret) return ret; =20 - if (sa) { - value =3D FIELD_PREP(XGMAC_L4SP0, match); + ret =3D dwxgmac2_filter_read(hw, filter_no, XGMAC_L4_ADDR, &value); + if (ret) + return ret; =20 - ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L4_ADDR, value); - if (ret) - return ret; + if (sa) { + value &=3D ~XGMAC_L4SP0; + value |=3D FIELD_PREP(XGMAC_L4SP0, match); } else { - value =3D FIELD_PREP(XGMAC_L4DP0, match); - - ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L4_ADDR, value); - if (ret) - return ret; + value &=3D ~XGMAC_L4DP0; + value |=3D FIELD_PREP(XGMAC_L4DP0, match); } =20 + ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L4_ADDR, value); + if (ret) + return ret; + if (!en) return dwxgmac2_filter_write(hw, filter_no, XGMAC_L3L4_CTRL, 0); =20 --=20 2.43.7 From nobody Sat Jul 25 20:49:05 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012043.outbound.protection.outlook.com [40.107.209.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201123815CE; Tue, 14 Jul 2026 02:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996655; cv=fail; b=rxNs5E4bmpfEsMlZ0AyJo/+UEpNpL9LByiGw4D2UuW0kqBmUyhoa08y6t//PGYuagjRKKLEvhmcd4rl2fDYIoYDJAbnzQgUh8cqdV/e2hBAR7/TgAWcQI8uhaisMa+in5i59R665CvPDiVcWGaMOqpxBo/NPQqi2vxsfXLD8l6U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996655; c=relaxed/simple; bh=5duLO6uMprPcPIv4W1WL5kXtgmqsmdQvdGD12Mp93RE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=VkN9YJQxzDqZwN/rI17beKfhrSbJ0CKu38A0O++vQSDG1GrkV/WeGbbMlX5q5aYyF4ArlnPJWlrvwhFrRuyyI5scqVKADuExBgPEjCOaPi9KcEV4kQ84xsJTbWXVxAvBJpUsyh6wJCzMbF43BA6Lkb35XX6oS9y+cOvfhR13reo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=SCfFzWvB; arc=fail smtp.client-ip=40.107.209.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="SCfFzWvB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wKCAbID0q0FVw/tcRmKP50nzxPs1eXiKAanAHywb87iK/9ztRmOMV3VcRRq3hWnaFefPO2gsnFEibtiWWRBhYYLvvmfnH+1/2H6ypYHqibYGokwV0yRLx6dM183PVrPNNosN2Pc2S8N2mNdJOTmOKhyLHRUxUDEoEon4c4MiOa6PwRRlojvK+Yrd1XO32CfkI1dGi2BbJvx5WdEW0OxP8l+/iWMVhu3mOPMCDiBjv9BwPkd4lGwwJaUthsRtAiJCFdrLMW9JaVNw7bVz+JcqcZsa6p/6iOFMRhdsIA6VmuH9cy4NHZdbXl65dKhCUON7+HysmuP/7aKlWbZQXduERQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G2n7GZUXdGw1/OWHBpHnTodAyxpIGd+3rVzE9jcvipM=; b=QfuTAIwe3/mH1Hw9v7IBcvQTewAKV3a0Ac+5YQq1e6FEaSobWYcpT56/5fV1F9yS8bpVUtmBnTGMXGqu8qFfba2DwqPUxX2xUmeBEKzT1nsFYDhwHUV/iKChZkARl45z4GuGWnhDUbkWSFXLv1tMKCQTc4B208KCz0DqzD5geNqg6Ao/9PMA4yG9eFMLhWrYkHSRoIVaMAZMEHaMYG0jmiqQfVjO1vpZJKAoTky3JzlSVaPLJS0AtnfziD3iZohBoS3rjq+hZ53AJ+k5pw2hDTWA+Z7QpcfP9efU6kgMwA8gklYKBI00UKpxulI5y6zoQTMkrqyDzctcH7cWTnlcJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G2n7GZUXdGw1/OWHBpHnTodAyxpIGd+3rVzE9jcvipM=; b=SCfFzWvB3hsUfBfmqjBl4Nfv5mbP0CO4dDciuI6rrGZDaEwRsrV2uvOQlsNmnyQJvAgZxTdF1r0WWebU9iUqnb9QYjxj0J/9Y/A+5vbvtF+NEw0oLp1N9Af9r8K7mqtyNNP8IjlNqVJneEezss9aBwZHwQp0cy/scf6Tx+4MoUE16e2E+/Bw3BaDBRpyKDt0WwJH384OwP4n/irX/rXPUvhw917lKyXyAlGanSzzUqFxLAuFdyb7G2YTUuxfXD99D6xOBpqAlgLFiT0geeRJGnyda8oLYdJVMvw9wlrVsyLbHd+R1EavVypIZvKvC2FGk2Lj8qPmpJv5GHazYWpnKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) by DM4PR03MB6032.namprd03.prod.outlook.com (2603:10b6:5:393::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Tue, 14 Jul 2026 02:37:18 +0000 Received: from SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775]) by SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775%4]) with mapi id 15.21.0223.008; Tue, 14 Jul 2026 02:37:18 +0000 From: muhammad.nazim.amirul.nazle.asmade@altera.com To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org Subject: [PATCH net v3 2/3] net: stmmac: fix l3l4 filter rejecting unsupported offload requests Date: Mon, 13 Jul 2026 19:37:15 -0700 Message-ID: <20260714023716.29865-4-muhammad.nazim.amirul.nazle.asmade@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260714023716.29865-1-muhammad.nazim.amirul.nazle.asmade@altera.com> References: <20260714023716.29865-1-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0116.namprd05.prod.outlook.com (2603:10b6:a03:334::31) To SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6964:EE_|DM4PR03MB6032:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e7d915a-d32d-4686-f9d6-08dee150d2b0 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|1800799024|366016|6133799003|56012099006|11063799006|18002099003|22082099003|55112099003|3023799007; X-Microsoft-Antispam-Message-Info: 37JKDl4HPBiJf3NBAN9kHX+AgSaMq30uqqYIi1cecAKhuhtZ52fbOC0YSn8pL9Gvqu+ltvXTTpVGb3cFcn/gt0PXeOeQGsv+XszVr/9oD6dMKV5XMKCRSUlN6Cl2N1IwjDcKGmqWQ7hOYi/Z/g/IbvXXecUyKE8TjDV1JcB2FDIxVEJYiZMmocFKjbAxI4abna5FWGcxUkJdEJoczfrznCGcTRDMAj1zQbwUbhISHNlRfWxsfNTTzmkcZ15sQHwO0OZ+wRvBDTKQyBL5EtihSL1Sinumv19aLoEKiBDVuxc2XrbPFDaNB/edxpwHNoAMs1MjMk2NL54HohULFtmzWIqZXCwdwbP+jdFE+q2pzYznd5zgumjHwbD16dy4J/I3pjucYloPp8ksOGJA/ypTIRclmjJ02XG29guJm1E2wvnFAsewM0915iBe3vL2d08KpMyFd/d4smocwyaraSFnBygoS/P2i0q7fSnuq6fdmjde2Q+FWvtZaFYf6hO2WvbcuG8ziwuUBcx0kDKavkyrkNO1kqYtuv+vlznEhviISJ2e+pn4woR4ojPuDSwwDJeLQfi5w0Wbtj392/OfEBIBnOiTAbwL/9XMaDOvXsqhot8jODWCwMt16fq76JKETsB6d3AMHUP+0xqyGh3iUgjk6ke8YHCiIATtMurq06SJams= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6964.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(1800799024)(366016)(6133799003)(56012099006)(11063799006)(18002099003)(22082099003)(55112099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OR40yoiuKOgOPFe+Ct6d0FjCHwDMtKsAwyq7kpjUi0ZWqcVOPj6aQkvoQ3Hp?= =?us-ascii?Q?+Q/D/4W4DUeGREj9ShdQ1YCofnrnKpYUcEWbWMKrMIBj6a9h0Ej+1rSrcMfE?= =?us-ascii?Q?kl4JafLm+hsVRash+OV59aftLNqm9dgnnOM1EouojGFDjVDE81/hEzuR2Oyz?= =?us-ascii?Q?UVeBzb3GOwKwg6X/9C7hYRweNhcmtxkgfVjlxicwS4ivKNaCxfKK0WSlBGwR?= =?us-ascii?Q?+NbO7sAcUwdcwOehshlbk7ivyZ1mxfkVx/tcL1YR62IzfzxHvQM89ZyH9gph?= =?us-ascii?Q?9BB52y2yawxveJegPwR/b62SASlfR2zGdGnhMLZwHccu0ELCh5CSxlCLutd3?= =?us-ascii?Q?2mgiDo+W9DYz96eNa1xNOatSeejLEygGx1axbj08njAAwC3ESg1qC8E42+yV?= =?us-ascii?Q?IjSmKFrwqkHtchFWTSpc2590d+o1/FZ7odm70IcdYcclF3SGkV0NR1mgLPZ8?= =?us-ascii?Q?v0VYmAiEY8W+wNGMfYNIDWZEM2vmQGlskpFmvon2lTh9s9lljelRoF2C06qa?= =?us-ascii?Q?XQqn5/6hOvGfRytRk6LV2W6MPVlbQOjWDOGMaLHAgkoO5rFsZNECCA8B4hyq?= =?us-ascii?Q?onYEnGzrHC4mSTszbMw4mQwYORDVU+B8ZsUjmdsh1wkoK9YXRvtU+zj06w5j?= =?us-ascii?Q?RnDXDh91MW3FTLmF1iYvus/J+jbK90RPkMLt0fliNF5FeCicJvDCaJoOTiCQ?= =?us-ascii?Q?/kRW3LOS7QPF+ogTBy3Upon9RHfuxkP0HtzOdHY0KSNUIW0hS1DuOXS6TwBj?= =?us-ascii?Q?D8OYcIGZs5M4c7czEOIgBtvzgRWIZAmFhTgHGJbHi0JZ8/rCB31TAbFSLlrP?= =?us-ascii?Q?fyZWwCM72DX5TpOLstZEYbWjPw7a1eUxPRG60/iQWXp/F5Nn+TA+eIkth+4w?= =?us-ascii?Q?3epebJbCCB3kW/nHKESsBUKBcJ5buI/zvMdvO6MphK1bNTHXBXLllNabMMjH?= =?us-ascii?Q?ZwEIXsuhyx6tD+363NsIYjfMcyxV3Ro3YN1JRG+ez+iv2oc/MTOuNm/+wla5?= =?us-ascii?Q?XZpmFeLrU9oN/aN7NlK+/zrZr9TkGzI8DrVMwKyLqVmyrgUHaRwgiTS9oFKz?= =?us-ascii?Q?9HxbAgEYY661FMQMU036EhK7mZZg0KI5dM8v0nc0oO4u68HY9WaUoyikhALS?= =?us-ascii?Q?8jN1zOMo0NqOktnQeHGuS8Bo1ewbSXD+SdiXLrTFREMVT9I047YEBMXiOdI5?= =?us-ascii?Q?wWkn7i+d47Yt8b72S2f8kXc8EXuRT9Apcts7iVklkw3ZEOHReumI04HbcuHx?= =?us-ascii?Q?rUj12cgQPWgaei+u67FznKp3gy0OSFf6x0TCpk5qTM9sAJ3kXWYv6DY7aA5x?= =?us-ascii?Q?kjjIxSRaAmy/19c38B1L0A4wtUgyRfPovxn8V9FElo2rCwetguzTO/uMAKQc?= =?us-ascii?Q?22jKuDsf2gLfZwQfCAEtzu9Vgrf7X3YMJ2S3//2hqDLeD8RbPUh8gzzk42w+?= =?us-ascii?Q?mgCOMZDSaV4ghKKzfiNznTXxq4BI0JasCagqfMepWa9zuCuF9x3epXa+HdFG?= =?us-ascii?Q?Ovn09YBdgTgYXFbiRqCvlJ9XIaRJ6yk5KJ8m+jyFCsclc9IJJPgFWFwFVhr0?= =?us-ascii?Q?/UojetFUiy1aA+V8K8YnCcCTA1ZamVwZECUVIAoT644Lgj5NLQ539c7UiWMX?= =?us-ascii?Q?MvLj1GtUD4l1CgIw8BJlUG1LfNNDEKzmEBtMtJ1B7/H7dpY4F5Ul+9Z3zdQv?= =?us-ascii?Q?h8J+nthJZfWXDY8kmdEp0VVRREIdc0tkQXZEPYgUyt8JKCtfE5DFS3laVJvN?= =?us-ascii?Q?SnLQCX27g3KFSIrVUENrpvRk3CeKhhchQfbKWfJCuI0+jqUGzPh2vakF5oIl?= X-MS-Exchange-AntiSpam-MessageData-1: IAbDMk3qohG2NA== X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e7d915a-d32d-4686-f9d6-08dee150d2b0 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6964.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 02:37:18.2463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e+AMRPViq+0GbQCHhlmB3gKJJTtzAP6+nXGExkdIr3tQA4MJn9ZsNJAVsEtEDnr0HoCGNZN3ex90/Jq3VvfAEUActatTjqONfv5ljRqpRrU/P7iabQFBQuzOQHleGaZS2VuSPCUIQkU/7xU3e5s6xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6032 Content-Type: text/plain; charset="utf-8" From: Nazim Amirul The basic flow parser in tc_add_basic_flow() does not validate match keys before proceeding. Unsupported offload configurations such as partial protocol masks, non-IPv4 network proto, or non-TCP/UDP transport proto are silently accepted instead of returning -EOPNOTSUPP. Add validation to return -EOPNOTSUPP early for: - No network or transport proto present in the key - Partial protocol mask (only full mask supported) - Network proto is not IPv4 - Transport proto is not TCP or UDP Each rejection includes an extack message so the user knows which part of the match is unsupported. Also propagate -EOPNOTSUPP from tc_add_basic_flow() in tc_add_flow() by returning it directly rather than using break. The break was silently discarding the error for FLOW_CLS_REPLACE operations where entry->in_use is already true, causing tc_add_flow() to return 0 (success) for unsupported replace requests. Fixes: 425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower") Signed-off-by: Rohan G Thomas Signed-off-by: Nazim Amirul Reviewed-by: Jakub Raczynski Reviewed-by: Maxime Chevallier --- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/= ethernet/stmicro/stmmac/stmmac_tc.c index d78652718599..1f8c9f47306b 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -446,6 +446,7 @@ static int tc_parse_flow_actions(struct stmmac_priv *pr= iv, } =20 #define ETHER_TYPE_FULL_MASK cpu_to_be16(~0) +#define IP_PROTO_FULL_MASK 0xFF =20 static int tc_add_basic_flow(struct stmmac_priv *priv, struct flow_cls_offload *cls, @@ -461,6 +462,37 @@ static int tc_add_basic_flow(struct stmmac_priv *priv, =20 flow_rule_match_basic(rule, &match); =20 + /* Both network proto and transport proto not present in the key */ + if (!match.mask || !(match.mask->n_proto || match.mask->ip_proto)) { + NL_SET_ERR_MSG_MOD(cls->common.extack, + "filter must specify network or transport protocol"); + return -EOPNOTSUPP; + } + + /* If the proto is present in the key and is not full mask */ + if ((match.mask->n_proto && match.mask->n_proto !=3D ETHER_TYPE_FULL_MASK= ) || + (match.mask->ip_proto && match.mask->ip_proto !=3D IP_PROTO_FULL_MASK= )) { + NL_SET_ERR_MSG_MOD(cls->common.extack, + "only full protocol mask is supported"); + return -EOPNOTSUPP; + } + + /* Network proto is present in the key and is not IPv4 */ + if (match.mask->n_proto && match.key->n_proto !=3D cpu_to_be16(ETH_P_IP))= { + NL_SET_ERR_MSG_MOD(cls->common.extack, + "only IPv4 network protocol is supported"); + return -EOPNOTSUPP; + } + + /* Transport proto is present in the key and is not TCP or UDP */ + if (match.mask->ip_proto && + match.key->ip_proto !=3D IPPROTO_TCP && + match.key->ip_proto !=3D IPPROTO_UDP) { + NL_SET_ERR_MSG_MOD(cls->common.extack, + "only TCP and UDP transport protocols are supported"); + return -EOPNOTSUPP; + } + entry->ip_proto =3D match.key->ip_proto; return 0; } @@ -598,6 +630,8 @@ static int tc_add_flow(struct stmmac_priv *priv, ret =3D tc_flow_parsers[i].fn(priv, cls, entry); if (!ret) entry->in_use =3D true; + else if (ret =3D=3D -EOPNOTSUPP) + return ret; } =20 if (!entry->in_use) --=20 2.43.7 From nobody Sat Jul 25 20:49:05 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012043.outbound.protection.outlook.com [40.107.209.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D180F383328; Tue, 14 Jul 2026 02:37:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996660; cv=fail; b=NMm++a8lxYrSQuvvv4RSZsvN8Co+vVTuXinUuK4FRMIcfqpvxtMeJYs6h66vaSGNMkJoPohuQep39mUK1MKOQFrQYP85bFZmv6kxOoYrDUclUc6kY8EG3phROhIELtldtkv9OF/pHkFrPgZvIsvfgpI1NJhK1mIzPGntXIvq++Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996660; c=relaxed/simple; bh=vXJ4n6FkjeJt48Y0bUSonF2Ja9KQ1s7xDHCIP/b+Qik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ZwAJmLEOKHtwC9X8WjaPaV5+kwZ7viWyAq5xI/NkL/HiWrOLqbfxlRCa6NAPdiyb6ysSi6tcrO7RSnKffzJG6PEl990I0x2w7Leh01bxhKcRavO5KuCY5R4WIVPdXdtsi32MGL9R5wMwqs4vEIAp/Q7/IyLsdeSH+63LmRKlC50= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=dmoP2xuJ; arc=fail smtp.client-ip=40.107.209.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="dmoP2xuJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qv8x6o7XCnZWO6WKdEBIXylnxUJgpqKvU3bAyoJI0hwzwM9kTFauRAivJ1zDvqSJsGOMVeG7gqZ8xr9IWutgnTmbdviDWDcWfcD3zvSgigK+M8jj5fV3Co3bQHqWqS8fg9gtmWIZZMRNPToF+UUWNjjhtncp/f45XKZpcn27D8oGvYxhHM9EMiziGfH6z5c+E3OSmjAR54IM2xUKj7CmSYe6Ukc9jsioZUYIeJ9TPdHUb7rGPhXYiLeXwgcZOciZ93bXf6sZ93lGmiQx1KSrI7wERUJe3eA2hVAr4+Yf5v0LR4QNRpAJRbECDwsAGsLifoiuorLDpBYqjERFIjkEpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ohQMI1sj2QytgtCyi8JP1WbtLnJaAmpjScQmKsP/PG4=; b=BKf5XA/WVBkYHvfQWgmxQXFsFqmChDQ7+Ye8p3XaRmSvwKoMJsRTyJF1jWNfBtLKFK2DZIBqgGW4ExRuhQ8foqNvKPtLoe8D+aAieKIVoJxn1CxpqAon2Qv2HkjfYhQpP7rS5vKKagbtAdrae2M88IPAkux4w4EBD/l/8zrRj6SusmV3NBBmIbmr58NZDDL+1kZG39KqWG5Wox5wmWm6sZ67ifEQJ/OsDyCVGGGVw1hft/OKVV3ROtOWbGKs7laYlVHwC2/XPzXwrCupRUzb7q8bw1Tq3IGsIyvpyz3dlWRvczma06Tn5cZK1Yd3f3fY1WGslUnCtTLfRZ1BnAXWCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ohQMI1sj2QytgtCyi8JP1WbtLnJaAmpjScQmKsP/PG4=; b=dmoP2xuJ0flDSHSPEbjS2yx3lX1Inz7T+BUQMPoNgItwt98VwvXN3imMFO7P5cyA9Rd54YJPCdBtRChtp5C4jgWJ0R7mwv+fbHNswGkyvGg7euGv6bcN6tojk3orUGpsrGTNl5/GjNkqU88bU13TiYZ68mu1vL7x/nvE7UsWlFxHKHQpKCH00H1IkSQb01U1gXZHuk16aowjo0nU9JsX+e4gwKnoEiQ60xmPPyt0sCh4HZgcddPbhHQT/eQJj/gySN2BtJA8LImpVyk2O9ItBUYgjAT7StpgzznSdd9T38Nf+IGnJo0TzLUIewm2f/PcNU0imr1hHkf6lZJGfUpRHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) by DM4PR03MB6032.namprd03.prod.outlook.com (2603:10b6:5:393::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Tue, 14 Jul 2026 02:37:18 +0000 Received: from SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775]) by SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775%4]) with mapi id 15.21.0223.008; Tue, 14 Jul 2026 02:37:18 +0000 From: muhammad.nazim.amirul.nazle.asmade@altera.com To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org Subject: [PATCH net v3 3/3] net: stmmac: reset residual action in L3L4 filters on delete Date: Mon, 13 Jul 2026 19:37:16 -0700 Message-ID: <20260714023716.29865-5-muhammad.nazim.amirul.nazle.asmade@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260714023716.29865-1-muhammad.nazim.amirul.nazle.asmade@altera.com> References: <20260714023716.29865-1-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0116.namprd05.prod.outlook.com (2603:10b6:a03:334::31) To SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6964:EE_|DM4PR03MB6032:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ed50ab0-d380-4739-aa57-08dee150d2e0 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|1800799024|366016|6133799003|56012099006|11063799006|18002099003|22082099003|55112099003; X-Microsoft-Antispam-Message-Info: 0eMou3/uG98XIlMt8vimKXbs+pu/A/PL5HGj+B9gskqeHplEjVJtFsqRYKPzGbpiV9Wxlwkwhs/IC4POmuvOn0I8opxzP8FlRT6rUCa4sOFI72ahU191/RirAeWPY5r3qd9rYX3SVs93gYL7TNW5BM24T6NXDrcJKt/ybBU1XI+HkIvWpfoLenKtbPxpDuoI94i8xTL3LeruRfcAvrAI5BGhkn+raVFoDE335JBmk37pRFqB3tTKZi2gv+s4dFPHnaA1JL0zX/7Q6a9bAthOW97GslcP4krcYUz/vyNIps6a7q+huNKoqXKPUAcbDngrF2+9vps/kFUjDUQVtmoJ4LLRowmYmYYOjQEZc0eBcVOVF6jfrVQfxAYu0oRiphKL8Kkt9uBiKB9QvaVU2Mw0uMJ77h49jdwkamGpEB0pQ9dJHfS45wAmHT8MJlKOtyCGWtMwqWSS27D6PI9FlHnKkjTD+EQ/QMJuPbLJVSgSBmbRUpzbdMKsoNcK5ki1TG1sYF66sngyVd4GXkxkKYejPsAE8Adajxpe99GbQOTZ3HYRaLesNe9beH20wajHL65HrQk+jVwqD9D+O3L6STe/ZhopEW6NNTkG7HjtOXEyJc6nG3PmdEQzROcKBbLAM3cYxHPst6J8S6QQbY5igI2ZZdLWIeyLEZc3xdQmzp2vOWA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6964.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(1800799024)(366016)(6133799003)(56012099006)(11063799006)(18002099003)(22082099003)(55112099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MHmuu5O0OuWxX7XOEn8zl+NUWjv3IdFtgow8XTi/SV21aezfgXFMO6+WlOrr?= =?us-ascii?Q?ke27ZklDbY3MJur+Z1phL8ovK+Kql6auxwQsm7hJz/babn6hBGOEwfcYeoJF?= =?us-ascii?Q?bO2JCYiRxjE5VdXJ32Yi8wWzVAN/haUlBW3rMcU/OJIGl6TNlzBFP+b+27M5?= =?us-ascii?Q?vsROuYCjQ3z7qmWGGF4Fda3tVqEzJKWcTmZKAhDWqcBA68yMUMw+jltJI8l8?= =?us-ascii?Q?KFdYKEBii8ayoMvL7P4OQPxgaz/YYSkGjLotkEdtPo2ISAN3PXwUbEgSTqym?= =?us-ascii?Q?1hcT0LmWYLGqvaGdypVTfrUqY4xnNel8yTJ1pxWHC0Nvu6hlyDNH53CzZ3ta?= =?us-ascii?Q?k0wRRYFHh52TJu2iWa6QjgHfuJPa6KXIw3mbZg7ixx7gUaShHlqHU9kWY3lJ?= =?us-ascii?Q?Q2vh2oHhtzk8uQtelA5GWMkcV9wUx5m4joyiEohePrZsmcr8bJgs+xjER8Un?= =?us-ascii?Q?eogfmajiH3+Qm0C8+VFLcuvGH1tZNWyoUs9IXfT5fiJ0EpqPlu5D6MSL/HG2?= =?us-ascii?Q?tgtqUu0eiJjUakr0gETeluROdshAtUX59NfwqO7IqDuDWpLucheuMQuu4ugk?= =?us-ascii?Q?2QjDQM7nDmRJI7CqGwBkzkfMmpvHGgEmoYHxESB6tf51JRaTfeFbtNJuIvvl?= =?us-ascii?Q?/6S3R8N3bKVUXu8heJ0cwpzrwf8XbjeyFe11m87sTc1iCcX84YAmCIZhxXi7?= =?us-ascii?Q?SAqq70WeXLBAwLMydNAgZw1UGK9kUamn4bO962x5aci0RqxhXFiCA8Iq2Xa1?= =?us-ascii?Q?kz5OTOTokUMSLQ0s+DrqReDHNwCA93MYZNyViUHF4qgdBZefH+bsLsIVj/2U?= =?us-ascii?Q?LKWJx4mh8qxF0Q6KmTKY2QCFW5O9hv2Z06qAF/ODU9XrmSFjzZnvNH4uFvmU?= =?us-ascii?Q?rn6R4Gm6ryBnC3/rfRV8kj1tIuh0Uc+Y3z2s7M46tv4JI0azT+wi9N+P8RJB?= =?us-ascii?Q?73DDn9uFLGFwyHHyVYZ1l3T9eMsNhhY93R6Uilllqqx2XyK2DiVEeUUZRxzn?= =?us-ascii?Q?KM2OsDTRlRKAUgIZ6E6iCp6R6xOnDeUM1MaTPnWEc4hvt8jD+0lnw8toy2Iz?= =?us-ascii?Q?/uxvfugNnQfsvDCipfArx4zsFpgMGSH9WGp8+0AQAgUPwAq1NGUwM3s/+haP?= =?us-ascii?Q?EJWYJAFZZ8lwanHAQzT5cYTgLUaatX1pDIbtWJc6Zn3WAL9D2B11xHa/3UuB?= =?us-ascii?Q?HivywC/g/N+YofDYUwlNX5cyATElucpWfveo0NJ1DHeT3SmYES2u3SMbpOnx?= =?us-ascii?Q?rF6DjvpBk6ZJhRoemz4XB72kXAJ+qSlAx7emO3SkIcLcI1bbNaEYQHw1p5bh?= =?us-ascii?Q?3Kvjmf/OraZi03oITwQX+gtuayY10QQ8BtFb7vCaE+VItmQzBm/JPlUhzZAy?= =?us-ascii?Q?HJMFxoI7mhU6f12Rbl1mAPMbD56JJYcQpm9VZbpH6hszvx1iaOpHZ1r79Qoe?= =?us-ascii?Q?omLSq0quzCVlFVxBCCHLtxAKhX9/MrfHBwEtTOl7JBvBPgnv3SzeVywuOCCU?= =?us-ascii?Q?3bKgaObjk/5zIaTAf6DgCGwL3S9a8ag5CDzgYuRhbUSGWcgZ3QWEQw3IrZsm?= =?us-ascii?Q?iZruhFh60E7vnEKlZbhFexKxJLvGUAcf+rKXQKlXYTVPcOUbkA8QwlMkGKLf?= =?us-ascii?Q?Tx7Rn4o6Az3LZezgS2kd8XF9Pw01Do6jMbLE2kwlRcIDjhGznz7OMDHooJcK?= =?us-ascii?Q?A4eE4oM8zKlmyzcTtD6ICK7nqKJG6BkFW4C96jcOQ8vWULhMuwQy430dljpS?= =?us-ascii?Q?Bto5bmqbTIep2I0lSYfJUv9Sdi17n2Lq52EXCBnW9C8YN3oogJQ+9NI1TJ7C?= X-MS-Exchange-AntiSpam-MessageData-1: w2YdoDKRXFbVIQ== X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed50ab0-d380-4739-aa57-08dee150d2e0 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6964.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 02:37:18.6011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CnxVZPwFPSr503F2eYxVsjyzVyXM7uww7634jBVKHrZG9LC1UraoFtjWGWliH71PhRsJr9kKbhnthKI7lqGVVIna+RNf/JXDC+JLXqVU4cIoQPBkd0qqLmaHb83NVHhrEeaCTYXG0HPCncohrT3oZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6032 Content-Type: text/plain; charset="utf-8" From: Nazim Amirul When deleting an L3/L4 flower filter entry, the action field is not reset. If a filter was previously configured with a drop action, that action may persist and affect subsequent filter configurations unintentionally. Clear the action field when the filter entry is deleted. Fixes: 425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower") Signed-off-by: Rohan G Thomas Signed-off-by: Nazim Amirul Reviewed-by: Jakub Raczynski Reviewed-by: Maxime Chevallier --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/= ethernet/stmicro/stmmac/stmmac_tc.c index 1f8c9f47306b..14cabe76e53e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -661,6 +661,7 @@ static int tc_del_flow(struct stmmac_priv *priv, entry->in_use =3D false; entry->cookie =3D 0; entry->is_l4 =3D false; + entry->action =3D 0; return ret; } =20 --=20 2.43.7