From nobody Sat Jul 25 20:48:39 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A91165192 for ; Tue, 14 Jul 2026 00:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783988584; cv=none; b=ehcSCZw0P/X1MHP8yF53Awye1Rzcy0bXcRRsXjeB8zz5sdQPEPfldquD/ApTlo8hL06vGb42R+2+QAc14QFqhrNMYveLwc2AsLUgtsEPQ/I4hthmP37VBPuzUq5+QK/EcHXQPzFA0DQF2SE/PvazLy1r45jPAmWVe/4LQ9CJyA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783988584; c=relaxed/simple; bh=vVL7D6bBR374jSiyyxvCqD0AEU8LzCU+hQHuZ3TWJSU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZQAOlMqvxjoInSZrWd9dgLlacrJav5xrKM4q/l7cJVBuIl0ppcpIuKUpPAc5lQpfFSJFIF0yQaflm48YoBq1s6r/n4TyLpXWcDaxY5w87xUXr8qoZ1sCUD1PLWj5fSfwsskTKHqCaVSRkZYadCMP38gtQi7yfFuguGKjVrRPAmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bJUjcQhq; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bJUjcQhq" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-84867f07d63so4123779b3a.2 for ; Mon, 13 Jul 2026 17:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783988582; x=1784593382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PC2x/z/M+JODwXQ4QIBsSqX18lp/m00iHD8pFlNxcrg=; b=bJUjcQhqv34X8AZQ6Dfebhtt5Wq07sIXmdZZ8m70JQVyd3/5LCYuG3hKzVf4YsmhhJ 1fo0YEiQSHvk9CfO5v1Fz8iCdwNUif2vAMHAWEdHuWDf/zdjhVfIvAHNqwnb/NH8P3CO eLruhiKYQsSK0mAk6+qdkEj4iXc8k66T+pavAMsM+QWv9TsbbdHZRAIQVHfXjtz1OA9I eny1L0rQaGwXyfdUWnzuO9vL3w6B4j+rs4V22sy0nTdAekHV9nmApvEa413pVtJRdmeK cH0iZNH+Dg4DrVAfduSTgn8ciGHhTuNa18jnPfcSKY7s8fU2SFNQhssmfR+Kk4oqEmQp i/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783988582; x=1784593382; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PC2x/z/M+JODwXQ4QIBsSqX18lp/m00iHD8pFlNxcrg=; b=fYrEx7kpREPCW29Rv8cBlZ+kngqnfzOXgPBfq3VXPGDtH5oPUy3eCtOfmc4l1bpCzC RsvvIPoy1Gd7T/YLva1qIgvoMGqrk9mLbRIjmrmuTmXjGcqRZ9VUpplxcIvbsF6TRsTg jU0ImqCIr39yoEsmmVFJndC+K8cGnpO2yGsaPTpRklaGBDeGgAS7Mh+gqwfIo403iSQ4 DbwGd3XgKQdzI50aIl4ppAthPay239VtaBgSZI0bonESldmSN6g0kDI0q6dyd7IojXR7 17sCC+1LLG7yJmhQMwPhxHizudruDTw+Uum3Wa3V72yv/CG6w7S904GvvGdnKmNNVLwS R0aQ== X-Forwarded-Encrypted: i=1; AHgh+Rp7qjhFEvSTafbsG1A2eRo2vk0v31AUvc0G7XkpBxtkGac+XsFFX459jL8Rt6KfcM66DkGxmsm8z8QoAAM=@vger.kernel.org X-Gm-Message-State: AOJu0YxbYGw+lQpSbnQslZ9VGJyCcixFbTTlUTyEEREsL//xauAqO5nw GKYpScg9LZ8hjoxOUBwM0iieM+tkw/7JjUCgJKI4LS7LfvFzwF/CWSxt X-Gm-Gg: AfdE7cku/FbqsN/389djqBV/w6+x1Kyinme0JRExdERecTpP5E9e0FbMJ2ESa008Cm6 HBwNzsZ5Sc72AYO8FM8iI7k69PX73/PHfD5ac4bkp4VbqovZ1vLwNhqapf2UZi7S2Zlug4VoDty 60ywDrg/hreoxLy+ziVMB90VIYDZvEB8cAr10YAqrbiM9m3tccR1HvMuabOp6NsdCT9kf0wooni BNq43ZWWo7Mqffed9ctyLW+pXTHjG8E/6TYt0wbvxbEe4NgXu5tAByMzrqa2HPP+5JKS7X5ahGD YvPpyplVvmSQfXVTNCInRWSus85FIxbZLa3By7lpngwtE0O3jiW8ubjtyBkU4g5YN4IPIA49f6x OlmVPkfouo3bjqtMBhVzRqQv+Tfav8FiPt6uEp22DGtpbTHIrrNhk0cQJLjU2lefxa5hxdXPG02 oCd9XiiLaxZ5VfppVDzwc2lMKq4/BHP58nFpOdluyqxgSKi+jajetS4ETaJWnWjrovvyb+6qEqU Tov5/2CzlqEG41qM/5XqFwY73xBQy/JeqwP0AKu0g5iJM5vpyH71MNOTeRig1J8SA== X-Received: by 2002:a05:6a00:3395:b0:842:83d1:ee6d with SMTP id d2e1a72fcca58-848896dd7fbmr10534315b3a.45.1783988582236; Mon, 13 Jul 2026 17:23:02 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4ff2ea4csm473962b3a.23.2026.07.13.17.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 17:23:01 -0700 (PDT) From: Rosen Penev To: linux-rtc@vger.kernel.org Cc: Patrice Chotard , Alexandre Belloni , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org (moderated list:ARM/STI ARCHITECTURE), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] rtc: st-lpc: get IRQ via platform_get_irq() Date: Mon, 13 Jul 2026 17:22:59 -0700 Message-ID: <20260714002259.1392655-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace irq_of_parse_and_map() with platform_get_irq(), which resolves the interrupt from pdev->dev.of_node directly and returns a positive IRQ or a negative errno (it never returns 0). Propagate the error on failure instead of the previous open-coded "IRQ missing or invalid" / -EINVAL message, so -EPROBE_DEFER is handled correctly. The rtc->irq field is a signed short, so the negative error code is preserved. np is still used by of_property_read_u32() for "st,lpc-mode", so it is not removed. Built for ARM (multi_v7_defconfig + CONFIG_RTC_DRV_ST_LPC) with LLVM=3D1; drivers/rtc/rtc-st-lpc.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/rtc/rtc-st-lpc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c index c6d4522411b3..ae79ddf24f37 100644 --- a/drivers/rtc/rtc-st-lpc.c +++ b/drivers/rtc/rtc-st-lpc.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include =20 @@ -212,11 +211,9 @@ static int st_rtc_probe(struct platform_device *pdev) if (IS_ERR(rtc->ioaddr)) return PTR_ERR(rtc->ioaddr); =20 - rtc->irq =3D irq_of_parse_and_map(np, 0); - if (!rtc->irq) { - dev_err(&pdev->dev, "IRQ missing or invalid\n"); - return -EINVAL; - } + rtc->irq =3D platform_get_irq(pdev, 0); + if (rtc->irq < 0) + return rtc->irq; =20 ret =3D devm_request_irq(&pdev->dev, rtc->irq, st_rtc_handler, IRQF_NO_AUTOEN, pdev->name, rtc); --=20 2.55.0