From nobody Sat Jul 25 18:54:12 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 272FB3A453A for ; Tue, 14 Jul 2026 15:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043693; cv=none; b=GCQr5dK+u07AzQv9Bcl3kIHKno0LbPQ8ix+ikCjWj8deSQDt20CEkICe0mDhcCZcmirHFSGWcmmm+XKnw705TORLqqufDP71yUsggslUIyVJu9YambbSIZTKuoHn77G4gEY4s/XB47h5g7kvjy1EoCSy3bcB5XTCoXNKz5Y6Tj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043693; c=relaxed/simple; bh=qevuPbC3ipAlHnx/CLyUvELDYmFet0ftlCCOj1w52vw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=G6ZMeZrYhFdVzRDknM4S2s/eZWOjzqw8tuNi1zIlEZATcJ94LoWCldYWVYV+/2vPWvf71utOO3wjwJS/4+Y97kIu9OnXFCAqJUzHQK20mgoTq9NIZWn1eO+d3SMk1B4GmYYCAFVytlYwc9ZnQSyDdE23ud1fG1oH1K0rm+hkeFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=Ab4w3J1F; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="Ab4w3J1F" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4728c12ba97so1998418f8f.0 for ; Tue, 14 Jul 2026 08:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1784043690; x=1784648490; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=7GNTtKuo/BgF6mYC1Y9daW/AtQJUyZsBrVhnEirUr/Y=; b=Ab4w3J1F7s3c8n1zSfVFZ4ImbQEWglgsK/Xcmgz5pN4UgjWLODem6f85NjnFsi+ELe HFqYhOsqtt4YfVZpQFgEOjwejQYIiG8MVAWWsYPg78s6m754qkyUzMnt9bEJVCjQEJUq nRD/OeFbvOI4kdibl5rorrgmQOsoimqbB13FyJQkkleygKHDpVpW1MCrB4wf5OeTBhLZ 9BHIErzTynkYvPv/Pa19IrPL8XiYWWBp/8KLGfpVUmJxcBgs18290Rddn+/bapQy6Nme OQSgJDFKy2fINBMEW5xqnjUjC0HxtFnXv7JTTeRZhup56maMWhCtR/SGFZS+0+pDl3vI tH9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784043690; x=1784648490; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=7GNTtKuo/BgF6mYC1Y9daW/AtQJUyZsBrVhnEirUr/Y=; b=IQpUcghKqLeJZOROIRmmDWakyx1PdtoB4iEKh6xLQmkkz5Mc8QRU2mvxwvZLvvICCF KwdusJEONWNTraYcfEck2QgpGY65rYSByWw+b7zBuaDFtWlX1NYYdilzzj3Ulh4nWVH2 boHnrmWFJA2ZPikTdjZhy0+hvHSj1ASuscLMZcsxHCi5ScT7gQcFins6SKaTrAXfo399 Wlfuew78sSwLrwZMbogjJejsW1+Xz1ykqNKNvB7C6X5k3oSvclrnRDecJbm89F8pMVwq HEOaRGm/om+b37oWMK53WPsWyj6mtx0F6/+n30dQCiew2ATX3tixW4Xo0sONRCRtVs2d S6hg== X-Forwarded-Encrypted: i=1; AHgh+RrhtwDSRLFTzd24pdi2rcdu3mmpX0TRf4TwyHw9HGCVt1Gzn5LfXWscxSZP4nWIxdvxzoybaTgrDv4q1ec=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4btIkqlZfo3LB9lvK9KAcZCX8OR3sJH7QzAbK0jedfVYaeOSJ cHrvUxgQAYUZJtXEvd+Pva+iAgrsH9HJ/9DxV27OJKMXbtVN9SbJxBYwb/4JFFHLssLqI/m1m+L F8kvNwjA= X-Gm-Gg: AfdE7ckxveRroQvNoaC7+381nK1S8uLhQfewEJB1Nze0w3lvwKLikfBw+38mE9Tcl0C HbO1ouIooz0+E7YD1R860CaoQguNLCXLrUySGTXAxcScywCFgLqL6GzNk0SJ02clj0Xl1QiC4v3 MHAlUiQA38vcgQFRdJVNzTvVA2Qcrdt8vIbTxXAMu7nrgbXjW5kdqUK5UYuayxa2EwkFNd0NURw Cu4+hWq+D328TPXw1Sgz6KMpADbWWCTndBOsekhUgU+wgILAW2PCayOF1kOut3YEv+Gwqr1ubL2 /FLisy/4bcxQzFOSPU9LoJ6de48cW/QnFKNzNT0kN1evLaAs0hv1LbRdbhgyQXWEDUbcLucTH44 pqs/4HXNW6Fsx1j5jL45UB3N37Z2vek3EdAhwN+V973ceRy9LHm5P0uMF7sFGUClL3HZSxbHv27 bAyJfd9DpdW3biRSl3FGcxhCzo7zPnoc9XG9Sw02VS7HM/cVSfkdVmSTJj1AINvT+a+h7Yzz37d yA= X-Received: by 2002:a05:6000:71a:b0:465:81cb:bb20 with SMTP id ffacd0b85a97d-47f2dcadd2amr15226174f8f.9.1784043690339; Tue, 14 Jul 2026 08:41:30 -0700 (PDT) Received: from alchark-surface.localdomain (bba-92-99-174-41.alshamil.net.ae. [92.99.174.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4635aa34sm8423240f8f.15.2026.07.14.08.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 08:41:30 -0700 (PDT) From: Alexey Charkov Date: Tue, 14 Jul 2026 19:41:20 +0400 Subject: [PATCH] phy: rockchip: naneng-combphy: Always configure SSC spread direction Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260714-naneng-ssc-fix-v1-1-1c40a58061ae@flipper.net> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDc0MT3bzEvNS8dN3i4mTdtMwK3RQjSwtjA5NUCxMzSyWgpoKiVKAw2MD oWAi/uDQpKzW5BGSKUm0tACiDjh1yAAAA X-Change-ID: 20260714-naneng-ssc-fix-d298304e8469 To: Vinod Koul , Neil Armstrong , Heiko Stuebner , Shawn Lin Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2604; i=alchark@flipper.net; h=from:subject:message-id; bh=qevuPbC3ipAlHnx/CLyUvELDYmFet0ftlCCOj1w52vw=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSFRaxYI1zXUFp7/tEFLfUjJytz+9Y3OxVs9w5hb3Zdn LTDmel9x0QWBjEuBksxRZa535bYTjXim7XLw+MrzBxWJpAh0iINDEDAwsCXm5hXaqRjpGeqbahn aKRjrGPEwMUpAFOt8ILhn3aXaFhPz/bVMU8Sly72e5w51a8sv+OI37nVl/MvnT3yZxIjw9+o30K 3T7cvC9U526nROT/Gcd2ej+JfDLdb/j2kINCwigUA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Commit 0b31f297557f ("phy: rockchip: naneng-combphy: Consolidate SSC configuration") moved the SSC spread spectrum direction setup into the new rk_combphy_common_cfg_ssc() helper. That helper returns early when the 'rockchip,enable-ssc' property is absent, whereas the equivalent RK3568_PHYREG32 direction writes previously ran unconditionally in the per-type switch statements, independent of whether SSC modulation was actually enabled. As no in-tree board sets 'rockchip,enable-ssc', this changed the behavior at least for USB3 on RK3576, which now fails to bring up the link. USB 2.0 still enumerates, but USB 3.0 does not, and the SuperSpeed root port floods the log every second with: usb usb2-port1: Cannot enable. Maybe the USB cable is bad? This was observed on two different RK3576 devices with a CoreChips SL6341 USB 2.0/3.0 hub connected to the USB DRD controller running in host mode. Perform the SSC direction writes for PCIe/USB3 (and SATA) before the enable_ssc check so that they always run, as they did before the consolidation. Cc: stable@vger.kernel.org Closes: https://lore.kernel.org/all/CAKTNdwH_ZMQa-97h+tqdsWqXKtorkFF9wHAMn6= 0-8ZGKuze_Mg@mail.gmail.com/ Fixes: 0b31f297557f ("phy: rockchip: naneng-combphy: Consolidate SSC config= uration") Signed-off-by: Alexey Charkov --- drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/p= hy/rockchip/phy-rockchip-naneng-combphy.c index 2b0f152f5470..7843356a4dd4 100644 --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c @@ -452,9 +452,6 @@ static void rk_combphy_common_cfg_ssc(struct rockchip_c= ombphy_priv *priv, unsign struct device_node *np =3D priv->dev->of_node; u32 val; =20 - if (!priv->enable_ssc) - return; - /* Set SSC downward spread spectrum for PCIe and USB3 */ if (priv->type =3D=3D PHY_TYPE_PCIE || priv->type =3D=3D PHY_TYPE_USB3) { val =3D FIELD_PREP(RK3568_PHYREG32_SSC_MASK, RK3568_PHYREG32_SSC_DOWNWAR= D); @@ -471,6 +468,9 @@ static void rk_combphy_common_cfg_ssc(struct rockchip_c= ombphy_priv *priv, unsign RK3568_PHYREG32); } =20 + if (!priv->enable_ssc) + return; + /* Enable SSC */ val =3D readl(priv->mmio + RK3568_PHYREG8); val |=3D RK3568_PHYREG8_SSC_EN; --- base-commit: cc2b5f627e8ccbae1188ef2d8be3e451d7f933a5 change-id: 20260714-naneng-ssc-fix-d298304e8469 Best regards, -- =20 Alexey Charkov