From nobody Sat Jul 25 19:29:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F659378D64; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; cv=none; b=VaE71rf34OfZQxsTktwQ0rQ6aWV5Lefm96U5CRO572Xgo7EwqUPPftqp3JeAs3NX4S4bNrjOThsU0Rq7y0g3889twkL04KDAvRUkUb1vHGY5nrFC0QUBDZ4Bfzq19SHfJU9IZR72qq4a/5FGYacYGzhLC8Cx01N5qcQETfmY18k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; c=relaxed/simple; bh=1ZHNBJO5qrM8bD3uBDopzZ00me/02rhRwmoXbHpPB+o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A9s2lpDhod7vPr1VSOp2MQndyZkrJjrlnDCiQ8mZi2LcM/dR8HfQRRDR6v8zSrajgLKNs3C14rc0fisn2NEcjMqbQ+0XjjirMo2N6SSvaabqdsBS4SnM5i1BxF0ERnumRqEcr1LsN+KIPN7dV0tzGrSDw4ZZHZ6xHerWKxpbyY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CCU0w3Rz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CCU0w3Rz" Received: by smtp.kernel.org (Postfix) with ESMTPS id B8739C2BCB9; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784033099; bh=1ZHNBJO5qrM8bD3uBDopzZ00me/02rhRwmoXbHpPB+o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=CCU0w3Rz29cVqbt3JYg5z9+vauK6q0C7NZrt7aUrZlD9seiZzdUld3CpUHi96hp2a 3ymYZykF8K2vqoXQjAYF8ykQeEZ4naNLo0Syd2HHuPrV+tN8BxPtjJfFHh2QHj6QCY YRRONyCrXyHiruzkxJjZYqnHt/TOx7HKK+q2RP6zPtamKaIUCwtoMK7MWwKWueJ7Ro emXTlTYH8/tcjVUt9cf6GqGDckkNRQbVMmm0hR439kwpWrirTz7z1ekJk50CIhri7Y Df8+2WV53LZ9tF6Hqskl8qghoHqN7bI+BDrclETHJNa2w8JCr34BUWriGqVZ3nAap8 BomyR6sBISMrQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9161EC44501; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Tue, 14 Jul 2026 15:42:03 +0300 Subject: [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add mt6572 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260714-6572-pwrap-v1-1-d8e5a39cf7ef@protonmail.com> References: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> In-Reply-To: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784033096; l=838; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=DGlethcwjr6H16kkYv8rGeF6UvLfthLp0VHfVhWr1Mk=; b=9Fb6Cp26hr6jilvkzub6M4v2q/4lL0YwTW5VtR7PmuZCGmc+q1MJnxFs08qNCpGQwIAYC57nS 2QYhDhvFYkrB0aFN8eHW4BpqKibUhfROxJ2zy+39XcBccKeVg304Jh9 X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add a compatible string for the mt6572 SoC. Signed-off-by: Roman Vivchar Reviewed-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.= yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml index e7c4a3984c60..a3cf11153fba 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml @@ -31,6 +31,7 @@ properties: - items: - enum: - mediatek,mt2701-pwrap + - mediatek,mt6572-pwrap - mediatek,mt6765-pwrap - mediatek,mt6779-pwrap - mediatek,mt6795-pwrap --=20 2.54.0 From nobody Sat Jul 25 19:29:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313C53B42E9; Tue, 14 Jul 2026 12:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; cv=none; b=lorElCS5IPxN6JvImh9S4bZXgcH1eFYJPUw9ZmVT0WneF/3oPAsDy0eRAeLORiIJioMhwXN0aoT0ZiOuLO2MJfIlF3+HO64jGNdgXpIrITsnH7OfTKgwpms3vXi6pIxuq9wkEgmzcTvDoF9HxR0x/6wd6NK3CnaeyLVGKwNseTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; c=relaxed/simple; bh=HQi9+WXJ36H1mtRwYsG6NMNnHpxUitC2EHPxgWZq3AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WFQehVfPhe5fV+nA3mUfuxwtK5Hg2Rc73Nx3Aq/Tr/p1ux7Gbj8EeqVzLXm82Ew+/bdpRyuhssNBmOT5vp+VjPFxoP/lp2CMbJow0LkD1zLbuB/LZNU+mXaGmYEdZgE3H/qTeN7/Ikp9WSLIPRK/vvN0j2rsnLL9eUUMVXHjlb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A8JRblj/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A8JRblj/" Received: by smtp.kernel.org (Postfix) with ESMTPS id C45F4C2BCF6; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784033099; bh=HQi9+WXJ36H1mtRwYsG6NMNnHpxUitC2EHPxgWZq3AY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=A8JRblj/x+s1q5n5/JejuGtCGZsckUvQRe1Isxa1NOqMM10mVKCnEmBAqDc71hNBl 4bL/YhG/5brV5QQL41/bFsdAvyMG3Ojke+Q5tQin3Oelk1zuc8PxMnjgLC/JAWQL9C 76foVJLDT0FeyCtauTQNjT9COC3Ys4ETdUprFx/2oSPjNdsH76h7V5UPb/7pW6iIp4 vLQXb6yX9DEd2cUFiBcE9YAJXrWSTiB0N5rUGnD5QH289/MAuU8Vx4UPFuD8A5+2jM dXLRqErDTS+3ZVJQY8bTRcyllwC1jG0okdEgzOGx3Z/eqxyiA2MM/n6VI0vsCTo9qm Vuidqw1GB3o5g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47D8C44508; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Tue, 14 Jul 2026 15:42:04 +0300 Subject: [PATCH 2/3] soc: mediatek: pwrap: use correct log level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260714-6572-pwrap-v1-2-d8e5a39cf7ef@protonmail.com> References: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> In-Reply-To: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784033096; l=3474; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=xCzQlof4bTy3lyfGICVenLAtisdpBRuoLhm9lj1xxcA=; b=tFPaWcSgTeyrtuEKazGDhaavw7PSk/bmCsLQdhVZBvGV60I/L96kMUtY7FDNlZ51cFwraAJTe zaElgfCUqgoByKgIGVoz7g00W3aKLxuExk3ZylCMiu0hmVBVVerT5h1 X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Errors paths should be dev_err, not dev_dbg. Replace all dev_dbg in error branches to have the correct log level. Also simplify dev_err and return with dev_err_probe. Signed-off-by: Roman Vivchar Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-pmic-wrap.c | 45 ++++++++++++++------------------= ---- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index 0bcd85826375..a4b10b0a97cb 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2475,10 +2475,9 @@ static int pwrap_probe(struct platform_device *pdev) if (np->child) of_slave_id =3D of_match_node(of_slave_match_tbl, np->child); =20 - if (!of_slave_id) { - dev_dbg(&pdev->dev, "slave pmic should be defined in dts\n"); - return -EINVAL; - } + if (!of_slave_id) + return dev_err_probe(&pdev->dev, -EINVAL, + "slave pmic should be defined in dts\n"); =20 wrp =3D devm_kzalloc(&pdev->dev, sizeof(*wrp), GFP_KERNEL); if (!wrp) @@ -2496,11 +2495,9 @@ static int pwrap_probe(struct platform_device *pdev) =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_RESET)) { wrp->rstc =3D devm_reset_control_get(wrp->dev, "pwrap"); - if (IS_ERR(wrp->rstc)) { - ret =3D PTR_ERR(wrp->rstc); - dev_dbg(wrp->dev, "cannot get pwrap reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc), + "cannot get pwrap reset\n"); } =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_BRIDGE)) { @@ -2510,12 +2507,9 @@ static int pwrap_probe(struct platform_device *pdev) =20 wrp->rstc_bridge =3D devm_reset_control_get(wrp->dev, "pwrap-bridge"); - if (IS_ERR(wrp->rstc_bridge)) { - ret =3D PTR_ERR(wrp->rstc_bridge); - dev_dbg(wrp->dev, - "cannot get pwrap-bridge reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc_bridge)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc_bridge), + "cannot get pwrap-bridge reset\n"); } =20 ret =3D devm_clk_bulk_get_all_enabled(wrp->dev, &clk); @@ -2535,10 +2529,8 @@ static int pwrap_probe(struct platform_device *pdev) */ if (!pwrap_readl(wrp, PWRAP_INIT_DONE2)) { ret =3D pwrap_init(wrp); - if (ret) { - dev_dbg(wrp->dev, "init failed with %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, "init failed\n"); } =20 if (HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2548,10 +2540,9 @@ static int pwrap_probe(struct platform_device *pdev) else mask_done =3D PWRAP_STATE_INIT_DONE0; =20 - if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) { - dev_dbg(wrp->dev, "initialization isn't finished\n"); - return -ENODEV; - } + if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) + return dev_err_probe(wrp->dev, -ENODEV, + "initialization isn't finished\n"); =20 /* Initialize watchdog, may not be done by the bootloader */ if (!HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2593,11 +2584,9 @@ static int pwrap_probe(struct platform_device *pdev) return PTR_ERR(wrp->regmap); =20 ret =3D of_platform_populate(np, NULL, NULL, wrp->dev); - if (ret) { - dev_dbg(wrp->dev, "failed to create child devices at %pOF\n", - np); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, + "failed to create child devices at %pOF\n", np); =20 return 0; } --=20 2.54.0 From nobody Sat Jul 25 19:29:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 335703BBFAE; Tue, 14 Jul 2026 12:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; cv=none; b=QLvIzD4yC5pdtPeDe/Aevc4xB3TD39FP4vzDOHlrO5d/+P602UAykM3AkrqIH5abijSV+sN8Qclf2CfvuSNpv4Lbhe3fWRjr4SLYNdU8XZ/5mzkMN3VVGJpM9/t1YTjahnv0KbK7Zis+Iex2DzF1DmQCZKXY7M/LpUsUA3oM1VU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; c=relaxed/simple; bh=yrxMhmCYOUKee/WHlWAg1e5dG7auoKfuHFKPci2Li+c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CqgA8tt+00FHUv3WBwt12ySeGgilmHW0W42o4zCcfSYiMiOifAvAEc5E0TYaprGj2vFlM0gInhTQIsm427FGQEnv5NCYMN9PqZItyYBs+9ibAglB85lQkRcHwAbN4iSb3QvluznkGtrI9THKJKpux4bdqhdyvNYKYZq59HcnLrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sNvPHRLx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sNvPHRLx" Received: by smtp.kernel.org (Postfix) with ESMTPS id D45CAC2BCF5; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784033099; bh=yrxMhmCYOUKee/WHlWAg1e5dG7auoKfuHFKPci2Li+c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=sNvPHRLxhxDr/Tbzq2T1zG+NviZ4GJlCvmhPF9olSMCOiFkSGXCtyiFE3hFbWYI/w +cGhStojrujikZaXxHraP+GrXrxPPbdqCoCg9EhK0PFv69SGsXDe4odEe12zjTkH8e 7Is3mGLGNT6SxwIeuxuJ8ao4mR+GxTj7bc3ImKnBggfh/0TckJxqRWU628T25UdmoP ruMtqgBQCszpWGcBS00HhkIS6zmr4j7jMBhWlT0zzWRdJr8x35/tnCBvkocQGEJmt7 O5ps6ep3QTJp71UCSnsLXcG12vnkYGEkOqLOZcONK9JTk6UJdVq0nlwGkHluvqfaKz /d3jcVY0kFYoA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B565FC4450B; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Tue, 14 Jul 2026 15:42:05 +0300 Subject: [PATCH 3/3] soc: mediatek: pwrap: add mt6572 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260714-6572-pwrap-v1-3-d8e5a39cf7ef@protonmail.com> References: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> In-Reply-To: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784033096; l=5555; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=MPPYOgzDqoNCcN6F5iF2Dxp5T0TD89ZEJks3TwVCRQY=; b=JF16gx8q+zpMiZXOKBwHA9fCCmx8KQ+k5V9GLIDoEui8/ctpGb81KmpUv+9n/RaAHUe/WHlfA DFv2NlPy7FlDEzIeLKfKg/GWwJgWy46OfbSmDfWLY+pK6HsLwpeK0Ez X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add mt6572 registers and platform data for the pmic wrapper. The mt2701 SoC-specific initialization function is used because they share the same GPS_INTF settings. Signed-off-by: Roman Vivchar --- drivers/soc/mediatek/mtk-pmic-wrap.c | 111 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 111 insertions(+) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mt= k-pmic-wrap.c index a4b10b0a97cb..4b8a5dc80a36 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -569,6 +569,96 @@ static const int mt2701_regs[] =3D { [PWRAP_ADC_RDATA_ADDR2] =3D 0x154, }; =20 +static const int mt6572_regs[] =3D { + [PWRAP_MUX_SEL] =3D 0x0, + [PWRAP_WRAP_EN] =3D 0x4, + [PWRAP_DIO_EN] =3D 0x8, + [PWRAP_SIDLY] =3D 0xc, + [PWRAP_OP_TYPE] =3D 0x10, + [PWRAP_MSB_FIRST] =3D 0x14, + [PWRAP_RDDMY] =3D 0x18, + [PWRAP_SI_CK_CON] =3D 0x1c, + [PWRAP_CSHEXT_WRITE] =3D 0x20, + [PWRAP_CSHEXT_READ] =3D 0x24, + [PWRAP_CSLEXT_START] =3D 0x28, + [PWRAP_CSLEXT_END] =3D 0x2c, + [PWRAP_STAUPD_PRD] =3D 0x30, + [PWRAP_STAUPD_GRPEN] =3D 0x34, + [PWRAP_STAUPD_MAN_TRIG] =3D 0x38, + [PWRAP_STAUPD_STA] =3D 0x3c, + [PWRAP_GPS_STA] =3D 0x40, + [PWRAP_WRAP_STA] =3D 0x44, + [PWRAP_HARB_INIT] =3D 0x48, + [PWRAP_HARB_HPRIO] =3D 0x4c, + [PWRAP_HIPRIO_ARB_EN] =3D 0x50, + [PWRAP_HARB_STA0] =3D 0x54, + [PWRAP_HARB_STA1] =3D 0x58, + [PWRAP_MAN_EN] =3D 0x5c, + [PWRAP_MAN_CMD] =3D 0x60, + [PWRAP_MAN_RDATA] =3D 0x64, + [PWRAP_MAN_VLDCLR] =3D 0x68, + [PWRAP_WACS0_EN] =3D 0x6c, + [PWRAP_INIT_DONE0] =3D 0x70, + [PWRAP_WACS0_CMD] =3D 0x74, + [PWRAP_WACS0_RDATA] =3D 0x78, + [PWRAP_WACS0_VLDCLR] =3D 0x7c, + [PWRAP_WACS1_EN] =3D 0x80, + [PWRAP_INIT_DONE1] =3D 0x84, + [PWRAP_WACS1_CMD] =3D 0x88, + [PWRAP_WACS1_RDATA] =3D 0x8c, + [PWRAP_WACS1_VLDCLR] =3D 0x90, + [PWRAP_WACS2_EN] =3D 0x94, + [PWRAP_INIT_DONE2] =3D 0x98, + [PWRAP_WACS2_CMD] =3D 0x9c, + [PWRAP_WACS2_RDATA] =3D 0xa0, + [PWRAP_WACS2_VLDCLR] =3D 0xa4, + [PWRAP_INT_EN] =3D 0xa8, + [PWRAP_INT_FLG_RAW] =3D 0xac, + [PWRAP_INT_FLG] =3D 0xb0, + [PWRAP_INT_CLR] =3D 0xb4, + [PWRAP_SIG_ADR] =3D 0xb8, + [PWRAP_SIG_MODE] =3D 0xbc, + [PWRAP_SIG_VALUE] =3D 0xc0, + [PWRAP_SIG_ERRVAL] =3D 0xc4, + [PWRAP_CRC_EN] =3D 0xc8, + [PWRAP_TIMER_EN] =3D 0xcc, + [PWRAP_TIMER_STA] =3D 0xd0, + [PWRAP_WDT_UNIT] =3D 0xd4, + [PWRAP_WDT_SRC_EN] =3D 0xd8, + [PWRAP_WDT_FLG] =3D 0xdc, + [PWRAP_DEBUG_INT_SEL] =3D 0xe0, + [PWRAP_DVFS_ADR0] =3D 0xe4, + [PWRAP_DVFS_WDATA0] =3D 0xe8, + [PWRAP_DVFS_ADR1] =3D 0xec, + [PWRAP_DVFS_WDATA1] =3D 0xf0, + [PWRAP_DVFS_ADR2] =3D 0xf4, + [PWRAP_DVFS_WDATA2] =3D 0xf8, + [PWRAP_DVFS_ADR3] =3D 0xfc, + [PWRAP_DVFS_WDATA3] =3D 0x100, + [PWRAP_DVFS_ADR4] =3D 0x104, + [PWRAP_DVFS_WDATA4] =3D 0x108, + [PWRAP_DVFS_ADR5] =3D 0x10c, + [PWRAP_DVFS_WDATA5] =3D 0x110, + [PWRAP_DVFS_ADR6] =3D 0x114, + [PWRAP_DVFS_WDATA6] =3D 0x118, + [PWRAP_DVFS_ADR7] =3D 0x11c, + [PWRAP_DVFS_WDATA7] =3D 0x120, + [PWRAP_CIPHER_KEY_SEL] =3D 0x124, + [PWRAP_CIPHER_IV_SEL] =3D 0x128, + [PWRAP_CIPHER_EN] =3D 0x12c, + [PWRAP_CIPHER_RDY] =3D 0x130, + [PWRAP_CIPHER_MODE] =3D 0x134, + [PWRAP_CIPHER_SWRST] =3D 0x138, + [PWRAP_DCM_EN] =3D 0x13c, + [PWRAP_DCM_DBC_PRD] =3D 0x140, + [PWRAP_ADC_CMD_ADDR] =3D 0x144, + [PWRAP_PWRAP_ADC_CMD] =3D 0x148, + [PWRAP_ADC_RDY_ADDR] =3D 0x14c, + [PWRAP_ADC_RDATA_ADDR1] =3D 0x150, + [PWRAP_ADC_RDATA_ADDR2] =3D 0x154, + [PWRAP_SW_RST] =3D 0x180, +}; + static const int mt6765_regs[] =3D { [PWRAP_MUX_SEL] =3D 0x0, [PWRAP_WRAP_EN] =3D 0x4, @@ -1314,6 +1404,7 @@ enum pmic_type { =20 enum pwrap_type { PWRAP_MT2701, + PWRAP_MT6572, PWRAP_MT6765, PWRAP_MT6779, PWRAP_MT6795, @@ -1733,6 +1824,11 @@ static void pwrap_init_chip_select_ext(struct pmic_w= rapper *wrp, u8 hext_write, static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp) { switch (wrp->master->type) { + case PWRAP_MT6572: + pwrap_writel(wrp, 0x8, PWRAP_RDDMY); + pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_RDDMY_NO], 0x8); + pwrap_init_chip_select_ext(wrp, 5, 0, 0, 0); + break; case PWRAP_MT6795: if (wrp->slave->type =3D=3D PMIC_MT6331) { const u32 *dew_regs =3D wrp->slave->dew_regs; @@ -1839,6 +1935,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp) pwrap_writel(wrp, 1, PWRAP_CIPHER_START); break; case PWRAP_MT2701: + case PWRAP_MT6572: case PWRAP_MT6765: case PWRAP_MT6779: case PWRAP_MT6795: @@ -2277,6 +2374,19 @@ static const struct pmic_wrapper_type pwrap_mt2701 = =3D { .init_soc_specific =3D pwrap_mt2701_init_soc_specific, }; =20 +static const struct pmic_wrapper_type pwrap_mt6572 =3D { + .regs =3D mt6572_regs, + .type =3D PWRAP_MT6572, + .arb_en_all =3D 0x1ff, + .int_en_all =3D 0x7ffffffd, + .int1_en_all =3D 0, + .spi_w =3D PWRAP_MAN_CMD_SPI_WRITE, + .wdt_src =3D PWRAP_WDT_SRC_MASK_ALL, + .caps =3D PWRAP_CAP_RESET | PWRAP_CAP_DCM, + .init_reg_clock =3D pwrap_common_init_reg_clock, + .init_soc_specific =3D pwrap_mt2701_init_soc_specific, +}; + static const struct pmic_wrapper_type pwrap_mt6765 =3D { .regs =3D mt6765_regs, .type =3D PWRAP_MT6765, @@ -2446,6 +2556,7 @@ static const struct pmic_wrapper_type pwrap_mt8186 = =3D { =20 static const struct of_device_id of_pwrap_match_tbl[] =3D { { .compatible =3D "mediatek,mt2701-pwrap", .data =3D &pwrap_mt2701 }, + { .compatible =3D "mediatek,mt6572-pwrap", .data =3D &pwrap_mt6572 }, { .compatible =3D "mediatek,mt6765-pwrap", .data =3D &pwrap_mt6765 }, { .compatible =3D "mediatek,mt6779-pwrap", .data =3D &pwrap_mt6779 }, { .compatible =3D "mediatek,mt6795-pwrap", .data =3D &pwrap_mt6795 }, --=20 2.54.0