From nobody Sat Jul 25 20:48:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2F4E388393; Mon, 13 Jul 2026 23:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783986339; cv=none; b=pTClM3jbeJyvyXo730O6r6isktjUdeJZW1BokQO4sZICKzdAHLmFbg0O9EkFk/FSinroRVFp9Mn8u7YST3tiIQd1W/mPTgE5g/ez4A2zYSjsozpvmSAQ2wwvODgWseiql/YAhv2jfare3ZGb8Ym0i9DVq0yb5VbbZvTbYlH4Gzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783986339; c=relaxed/simple; bh=7Y3DTKf2fI+ajLwDzseyuEayaIVwLo04yvH3oUwmAiE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K6kcmjfYLYmDi8N5YHQ9Ry1T0C56QYjMfbFlzjPg+O7uBjcmlz+vobkjRRnWae5yQ7BHOkzItL+HTqiW2LQROdghs6X58s0PaLL4udTRsUJWwUX+Bumt5kZ6Gk33xTe+P3gxrU8w1kP4quxtaOcWbrt4j0Lh53Mpcmk41dGe6Vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FrR6R6q3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FrR6R6q3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 346FA1F00A3A; Mon, 13 Jul 2026 23:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783986338; bh=NHlZi45oV++7xZVrBiLIa7if84QvUn2pazP4hHbcUcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FrR6R6q3tZNhQP3e8s8UN3EfOV4zKgk93b9z+tIAIpYOOMb34vYI5oh68QokQ1tBB WBT3dM6b6bdVMnWZnhKxM4sG/RXaMLOuCV5M8VX77uAB2C5s1b7/YSNdOh4z+kej6w BpGU2vq691n8aZP6Ljc/4PcwXbfLOtEePjH+NGusgjxqEceswnvqhpNQyxZzlFlgxv F3D0Ct4NSTUKFyer5upaZiAG65RukyY5pVdbla2IaQR5RaDfIqPN8Z7WvGBJf5HWIU S4G+QEsr4RmcGA7B5JiyRcnqw06NbalzH46Vcjk0rv5aHUjRjkr93gizr90i8aMe5Q s805hFrAeLEnA== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Swapnil Sapkal Subject: [PATCH v2 1/3] perf sched: Add missing perf_session__delete() Date: Mon, 13 Jul 2026 16:45:34 -0700 Message-ID: <20260713234536.2280374-2-namhyung@kernel.org> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog In-Reply-To: <20260713234536.2280374-1-namhyung@kernel.org> References: <20260713234536.2280374-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The perf sched stats record missed to release the session and ASAN reported a leak. Fixes: c3030995f23b ("perf sched stats: Add record and rawdump support") Cc: Swapnil Sapkal Signed-off-by: Namhyung Kim --- tools/perf/builtin-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 6e0d8f4d270e2d88..c5728f3aa46f2630 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -4027,8 +4027,8 @@ static int perf_sched__schedstat_record(struct perf_s= ched *sched, else fprintf(stderr, "[ perf sched stats: Failed !! ]\n"); =20 + perf_session__delete(session); evlist__put(evlist); - close(fd); return err; } =20 --=20 2.55.0.795.g602f6c329a-goog From nobody Sat Jul 25 20:48:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4536D3A4539; Mon, 13 Jul 2026 23:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783986340; cv=none; b=Sf1nN+Ip2c6CpOAXQY/eFxurEhwrNK+hh5r/6e+c6F+7vHULFCnU9vcxTwRtWKC0TvutX5+Q1zhD7B9l8ZMbNSPJ/zVXDO+MtZ4h/QpBkqY5pln6/TE6kWjIZ2jA/OVDYnXI85WUIw/W0yJZZ02ElLxtncRaAW8lkCq1xSly0K0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783986340; c=relaxed/simple; bh=e8L7JP+eDiD7idQalJ092Hbvi26hvz50A4ROwiGvGv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pgUwJQF5ErN3x3Ts7Jyr7p+8MZKItCGItUwLetajluTWIPcj08ce+fKOoOeEl1zWbppDkUPCYyjwGH1OHWJudo2dqtu7N9lO3S8QK16kyT4ve62mLx54uj9dWiztkFWvAVJcOvtPXIT87eWjMUiloBEMPcOvQMaNXJtFxVMnhJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BXznfom+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BXznfom+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA13A1F00A3F; Mon, 13 Jul 2026 23:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783986339; bh=W3MbfPTUdWHNSNqEkTTqYBG6n5DO/IFfviNfQUBR0dw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BXznfom+fVQlle8m5ejRMibUrASNUvdHNcH/gH0cR+aatGkpa5ERQ9ccWGTYs0R2M B467TwNIu6uoyx3aK+auV6yfUdrUXfdFFcAM4Xy1OR4iTiFiuX0h2IR7TQ6G+D+LEr 9qup1cY+qU3jnp5u6gkr7Vt8ZXiFQmq7aWOMG9yv4HOiY5yxXIkLPCCesdvpAnPzCj p+s2thMMofdemnfHHRzrkoNZuEWdUIIZiDHKOhNLA9eFwu2Ypnm1tyTek5FMlGI8Dx 1NLAbU5Pc5hagpjG2/VxshvnR4VggXQlPUL8C/jcWIcVzCjX0ffYwZAR0X3l+7Z6Cm Ik46/zB3/K2nQ== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Swapnil Sapkal Subject: [PATCH v2 2/3] perf sched: Fix memory leaks in perf sched stats report Date: Mon, 13 Jul 2026 16:45:35 -0700 Message-ID: <20260713234536.2280374-3-namhyung@kernel.org> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog In-Reply-To: <20260713234536.2280374-1-namhyung@kernel.org> References: <20260713234536.2280374-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The second pass data is not saved in the list and only used to calculate delta from the first pass. Let's free the data after use. Fixes: 5a357ae6ad63 ("perf sched stats: Add support for report subcommand") Cc: Swapnil Sapkal Signed-off-by: Namhyung Kim --- tools/perf/builtin-sched.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index c5728f3aa46f2630..ab9590c4d838eff3 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -4631,6 +4631,8 @@ static int perf_sched__process_schedstat(const struct= perf_tool *tool __maybe_un domain_second_pass =3D list_first_entry(&cpu_second_pass->domain_head, struct schedstat_domain, domain_list); store_schedstat_cpu_diff(temp); + free(temp->cpu_data); + free(temp); } } else if (event->header.type =3D=3D PERF_RECORD_SCHEDSTAT_DOMAIN) { struct schedstat_cpu *cpu_tail; @@ -4651,6 +4653,8 @@ static int perf_sched__process_schedstat(const struct= perf_tool *tool __maybe_un } else { store_schedstat_domain_diff(temp); domain_second_pass =3D list_next_entry(domain_second_pass, domain_list); + free(temp->domain_data); + free(temp); } } =20 --=20 2.55.0.795.g602f6c329a-goog From nobody Sat Jul 25 20:48:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FD9B3B777F; Mon, 13 Jul 2026 23:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783986340; cv=none; b=O0UuOavPl19BhfOQOMwpdDuu2PrRSbtUKhf4w+qeIWVTDOBh6ThruicvZCzg9R15QV9mPnjKpQW1HnvYJ75wp5FrzCenMWFNjuMRfKcKweaC19ErA2x3cW3MYiSIYfU2DXiFeRl9nzFcp7FaQTzBOsIEAVp9jt65FNIUAdTX0mY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783986340; c=relaxed/simple; bh=YyuVHjU+ZbX4pENj1g+R8y/nX/Ac9Y+0iLI74ws35dk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZvOuE7vnVrTx/j16JuifYcwOh35+LzwMtm52apAL3cD8auEjIqE8AzMGapB/KB3xdiq0cwQmDi5+rWFqPnPv454xn1KriV7oCOb3MDhjhzKE1wh+42sKl61SJAbLGLuEqA+049so5SOgWSt6oWSpfn6g/4EDxHlTdjO0DIkBPyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WeQx/zf1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WeQx/zf1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2283B1F00AC4; Mon, 13 Jul 2026 23:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783986339; bh=wOkavhZ3KX+8cIlmdeCXNUzWYbrnkJ4x9IfdA9Wxy0M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WeQx/zf1vzlXOzD4OHiMbv62UD9XLzU/00k7fhPK81JEZYJdxnqCe/F1cYBWqW5aA NheJccsilevhi/otfq24dEcjeVyf8sH1aAsYo7IZqI8sxNpiCcIDRFfTy77Gpqnnr3 NtUNLQgOCXX3WXC1tX5/FYz4XCxy7ViQnQ980akuERwpsX3LDy0EVJJetamjiFO5GS /H+PHNa76P/LtGWt4BNeziz8L7L58AEtE685RDYAGuVezs/3uhGEbTeivv1Rj1m7ts ll59UwH5wDw1xMslUyFXeWV+d1SQkRrEqPZ1kcOcVW6H4jthG1asLJ6e/793nOYEjM F9OWxdpfgRjVQ== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Swapnil Sapkal Subject: [PATCH v2 3/3] perf sched: Free subcommand string after perf sched stats Date: Mon, 13 Jul 2026 16:45:36 -0700 Message-ID: <20260713234536.2280374-4-namhyung@kernel.org> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog In-Reply-To: <20260713234536.2280374-1-namhyung@kernel.org> References: <20260713234536.2280374-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The first entry of the sched_usage is dynamically allocated in parse_options_subcommand() so it should be released at the end. Do not return from a subcommand directly. Fixes: 064790a3d4a8 ("perf sched stats: Add support for diff subcommand") Cc: Swapnil Sapkal Signed-off-by: Namhyung Kim --- tools/perf/builtin-sched.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index ab9590c4d838eff3..acc8d81a20d3b9d1 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -5259,19 +5259,20 @@ int cmd_sched(int argc, const char **argv) if (argc) argc =3D parse_options(argc, argv, stats_options, stats_usage, 0); - return perf_sched__schedstat_record(&sched, argc, argv); + ret =3D perf_sched__schedstat_record(&sched, argc, argv); } else if (argv[0] && !strcmp(argv[0], "report")) { if (argc) argc =3D parse_options(argc, argv, stats_options, stats_usage, 0); - return perf_sched__schedstat_report(&sched); + ret =3D perf_sched__schedstat_report(&sched); } else if (argv[0] && !strcmp(argv[0], "diff")) { if (argc) argc =3D parse_options(argc, argv, stats_options, stats_usage, 0); - return perf_sched__schedstat_diff(&sched, argc, argv); + ret =3D perf_sched__schedstat_diff(&sched, argc, argv); + } else { + ret =3D perf_sched__schedstat_live(&sched, argc, argv); } - return perf_sched__schedstat_live(&sched, argc, argv); } else { usage_with_options(sched_usage, sched_options); } --=20 2.55.0.795.g602f6c329a-goog