From nobody Sat Jul 25 20:47:10 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A1EB359A6B for ; Mon, 13 Jul 2026 19:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971620; cv=none; b=i5nwphdbDzZMK6u5MNn1oL/YFptOkjwm8OF7EHLDcHT97n3eYtywhccoTe7STYe/9KEthao7ZzgYE3B++ZhyQUAVBd6g5N4J0vx2twKTwK0LxrEnH27KdxMkQQlmB2r3Wd3l2qA2HfWrhBDeiSetRrARwYJz5uAZ7W0rXSTx6VE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971620; c=relaxed/simple; bh=cBBAAXVfz2OnPP835VfCEgjtcsAJ50plKAqlklYzeK4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FyTVPOnDXv20qhNVBaLvNv60C++acsgGOTXTdOKcqR1Y2yg6sTv2oowT6Zc+iB2TJIIAC4ZsDRXgazscIfpr/NkfA5YA//PjLC4kdN2UMGYWWiiBos2WXPNRASFy2qMe0M/9b3Zek664WNBUsb6Y3TveSplnZlRZwBouYFx9Ffc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=opSmBt1X; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="opSmBt1X" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-474560436c3so173022f8f.0 for ; Mon, 13 Jul 2026 12:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783971616; x=1784576416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W7xWVihr3+KHFM8BLDbVBGdvZbVrj2tho5cLk2/xNCU=; b=opSmBt1Xu67tnrgXx4jSRAZ8V/f84TSLZnBd+blsRbLHN7Ou9g3lDzDCj5TZUvX9l1 6ljneaAw+WN/RJ+VvBzT4JJNAB59PhzqXhF5jP/O7ZZBSi7jZr82DdwZWEdoNQxOSkzD FROF1/tRenpwUClBPQmXlhNRT1WblHAkw7tPz95LjqshEykIkktGuhlVJcxKvt7vTppb IHZeoVD/DVLeSdQoLdWsOc7vh+R59UelE3+veBuvL70ozgNC3C5jQKkZuHzhyVqYVqmC H7ItH46lNAThPG0+3yhK7QYHEwPAnZAA/ONf58lG4ETGD03pkkZvy2yT/7E5pEmDvaYw W4NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783971616; x=1784576416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=W7xWVihr3+KHFM8BLDbVBGdvZbVrj2tho5cLk2/xNCU=; b=jjqufV4Y7rARGqNoxuCm23RF1ZofQ79gtTzyzBRNelMCVTDyPh7FbiyHpmJCVJEafs 7vUlwPPu1IuYanuR3yJ9gPzSZEHBGszBXVFDW0AX0cWoittxkJFGcunB2tIODR7RqjQ1 bwJ8AdqIG0ViIXd9/oQYOUYGt86o2PHBb8tPVTRwmJjjXR6qqrAfobcywdpceG+7G/oF KdDE8VLMsHYhs0sfdPz2ipsMkiMeZ7f/dZTQ5Tkj6haWrRsw4fMaMHEUII1dTLoBd/Mv oDjKhe8DR4zuVJYC602dr0ZOp5YG2TUDnadEmVs2I3C6ndhxE6fbM/XPW6QoHIdXX9T5 +XYw== X-Forwarded-Encrypted: i=1; AHgh+Rr+nxjf/1US+pfO9YCy7L1VSBWBW9dlzE7p7bClkkLZkNC+HbpGgAbE73rDFdAIcnOrq80n+tMWbXArcwA=@vger.kernel.org X-Gm-Message-State: AOJu0YzDFotoQrQcd0vXwZ3VvcimsABvvJfQtwGwI5lNZEoBpTtxCDxw Td2KTLQy0YmMCd2qjzbHkNRDZXsGJoLl6nfvLiHROSQbJxRgsN4a3CwaHHTb6q4l7ZIl X-Gm-Gg: AfdE7clCgo+PDy9GaeN/B7Xgp9bZYVGRYVcuY7Xsrd6LLE/f+eweSSLX8wVvNxSbugl 8RNvBxVzASjenwYNOvXHsLAVmtBwPyt0rJ46A36TZ1YLDzZkr8IdnaAgiFLLfQYeWHOt5OFN5vV UeY1/sKRszXJOc8v1bBnE9L8w73q/G4Gdw5/Od1TbIGFZjqrglgAg8CFb5Q9+XsWo234PB/HKHF FCfC2CCiiNC09trAIilCSPrcyTXVDS/+6/arbW0x+z9EQ3oOyV4NwcK1Y3C/4NXC7MZm0nz2t2F 65BqFBuNCmYZMsjNY2V1D+RwXfpupErQzIZrV5ANbwEdM/Ncp8I+ci+UzjAg4RvYxeMwggZTA1x bbOnqtDjoEbESeU3Meubn9Ved+989tyJ4yBKyWM8oMYz/BGRbLNB2tSQPA6KdulKROY7adT7Az+ lcTAcWJGGiAl9QsmlitTGfhNFMTEa0LBFK3OENs0uPXceJrHQpk1IMFFcqx08c+BtCwZUOG5LOC 7DoIx6Da+jhXNhMMjT58VohSwbnbaiyPqg= X-Received: by 2002:a05:6000:24c2:b0:477:6da:1b83 with SMTP id ffacd0b85a97d-47f2dcc8ab8mr11941321f8f.24.1783971616139; Mon, 13 Jul 2026 12:40:16 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c4320sm1648928f8f.32.2026.07.13.12.40.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Jul 2026 12:40:15 -0700 (PDT) From: Doruk Tan Ozturk To: Vladimir Oltean , Andrew Lunn , Florian Fainelli , Woojung Huh , Nick Child , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sabrina Dubroca , Arun Ramadoss , UNGLinuxDriver@microchip.com, Michael Ellerman , Doruk Tan Ozturk , stable@vger.kernel.org Subject: [PATCH net 1/3] net: dsa: tag_ocelot_8021q: don't read an unset MAC header on transmit Date: Mon, 13 Jul 2026 21:40:08 +0200 Message-ID: <20260713194010.54642-2-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713194010.54642-1-doruk@0sec.ai> References: <20260713194010.54642-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ocelot_xmit() reads the Ethernet header via eth_hdr(skb) to test the destination address against the link-local range. On the AF_PACKET SOCK_RAW + PACKET_QDISC_BYPASS transmit path the skb reaches ndo_start_xmit() with the MAC header unset, so eth_hdr(skb) resolves to skb->head + (u16)~0 and the read is out of bounds. On the TX path the L2 header is at skb->data, so use skb_eth_hdr(), as done for the same class by commit f5089008f90c ("macsec: don't read an unset MAC header in macsec_encr= ypt()") and commit 96cc4b69581d ("macvlan: do not assume mac_header is set in macvl= an_broadcast()"). Fixes: 43ba33b4f143 ("net: dsa: tag_ocelot_8021q: fix inability to inject S= TP BPDUs into BLOCKING ports") Cc: stable@vger.kernel.org Found by 0sec automated security-research tooling (https://0sec.ai). Assisted-by: 0sec:claude-opus-4-8 Signed-off-by: Doruk Tan Ozturk Reviewed-by: Vladimir Oltean --- net/dsa/tag_ocelot_8021q.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/tag_ocelot_8021q.c b/net/dsa/tag_ocelot_8021q.c index f50f1cd83f16..4514026897d1 100644 --- a/net/dsa/tag_ocelot_8021q.c +++ b/net/dsa/tag_ocelot_8021q.c @@ -71,7 +71,7 @@ static struct sk_buff *ocelot_xmit(struct sk_buff *skb, u16 queue_mapping =3D skb_get_queue_mapping(skb); u8 pcp =3D netdev_txq_to_tc(netdev, queue_mapping); u16 tx_vid =3D dsa_tag_8021q_standalone_vid(dp); - struct ethhdr *hdr =3D eth_hdr(skb); + struct ethhdr *hdr =3D skb_eth_hdr(skb); =20 if (ocelot_ptp_rew_op(skb) || is_link_local_ether_addr(hdr->h_dest)) return ocelot_defer_xmit(dp, skb); --=20 2.43.0 From nobody Sat Jul 25 20:47:10 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F21359A70 for ; Mon, 13 Jul 2026 19:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971623; cv=none; b=ZGQsbrqCcM8mkpqZFZZTsKzjU0WaeF8ClQiWI0vy/wjDg8bednT7lWM/BCf8xRyo7f573+rd+G7HrkRUQVyd5MOv31UN22bk1DIZRDggsHW3ldr0OQTAxPrOQW0slL6wD9pbRYb8zxDN/XM3lJTk6yWgLsKceFjWNtP7o79CqLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971623; c=relaxed/simple; bh=ZElYX+gf59pRPgluKzpGvx9WiCEsZq+Swc8cluTkDzo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=li4jwEahM5uUuLxRu1maCaKdpid2sw9IZ37wWPedDwz0rKzNt+39l1Qx9hYbJ8ccMqoo5EoPCYmnBaPHLbG00nbLG55vGcVbkXZkGlJ69/Y719K5+e8RvYNtDcM/1rXfv/dhJBoH4uQ7IdDg4JhASljuYj8Y9kvmV6e22VMVn2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=ZEka/sdd; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="ZEka/sdd" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4758b2a9e2aso2183917f8f.2 for ; Mon, 13 Jul 2026 12:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783971618; x=1784576418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2Anq+ZgEfX5t6X9Q7TePAbPIwtsyngsq62Z1m8/YM/k=; b=ZEka/sddEpto7RUMFCIQb5azkrkfoCdYr8etYSkVMWZO4ISCu/iad8n56x1S3UkYt7 XpNtEycCBk0zqhZUN8/F4j8Q+gleArHpn8qeMlXD6G55tv73Yt7JZcg5Y+4AiJ5Imydu yhTc0xH4X0s4HZK7NOph4LgugRFZ0eCK2hk2cR5qA8yqzVNwpJ2VTgDpWswdoC4DwrZe 7Jvn4MuqaMmjuqwveOJiuZbv1MTGRHm4iiAuIttR9wVV4gx1DveX7VerssR79FE7USfT ivHn4PH/Yt4RQGEf0GdB/hQ/jDHWNfL3EOfCX9HaWKEp4tvffW2fmOxelNeZA+EV+Gjj OQtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783971618; x=1784576418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2Anq+ZgEfX5t6X9Q7TePAbPIwtsyngsq62Z1m8/YM/k=; b=ma/rHeRvPBvF7msiVtamZ0BCKC6ICYY4rye4AUBm3twbNi9N/qKBDeRtwuVUeoUh/X wC1YbvRjVnvaPG585N6uoJl7lPU+kqo2dvOhLXECMDkLcWNXjix2ccae0Tsqbohzl5VU tqqYc/LchkFAd3pPoNVg3PbN9qS+SsFb2h4MrfEZecb8yFK1qxoYMhocWHENTpymcmVN /EN2T5MTeAQYJnJsjxPMUn5eBtyWuhIHkRf2Bga4YRWjN1fnV1XoVI40uCM3bol+btwx fFitQsv1CMkYHq/V9+LYZv6euLNgLQxMqWeoF3V2yz9dsuL81DivRVrK1HL++MaJCE5d XzuA== X-Forwarded-Encrypted: i=1; AHgh+Rp6IGQoLATLcG2+GSjkTJ2URZpBM+BYpqBGakxxLoK4d24LMNp6iVtk2nXTGSd4PntTeSbiUS7Fe0uEMWo=@vger.kernel.org X-Gm-Message-State: AOJu0YyNRuGCBIeI57OeNHXdatUIwPVx1wvBb7YYEZ4Fo6QfnSRnpHQb L+Yo0c8j2qbnGeb07p+mhuWNOjNAkJ2Ze48HNe1t2WuMR2vhw/HekW8uCzw/im3u/FwL X-Gm-Gg: AfdE7cngQyvURHnXdeTZA2JleAVMBZrumV+2VWL35NBImKHi/ff11f2OPRpmafDLKxH GkW6YU1gq07V4cp97d87qepYi7/FYs6Azx5//GDQsIsa4vUrDZd6T6xDwdLmptzPNbWJP4OFV0V 7hweWMGNjFmM8c4ga4pgdJ/KQj1IiZ06pkyv/QgBeuuOgioEBveRxcos/hj3Kp5XJNdY+ikL2No hnfy56EQ23+j5BTxD6oyoCVIeI6J33wZeUzobY4K8w0DDbjU+h16Ei5KnF5XgCOK0I8T7Arxp+s LkvI+WwBPY98HO+OkLsoG9MP9+Y0UNP+lh/GovVQjXJMbJ6vDjw2KZozn3JXQzXl3V+4iTQyrdH vAYx0xDr5y+qlDZsJNv3npGisyWg4DiDqUrznAgcRrxpzglrJ7u3kya+Mo88oYGrDjyoKqxk/QS taAwDwxvD+3HMu6rHOphCxjKDvoXZ6cZ3e9k1YHrPKUa9xdAu27RK2rWSpal/wljhTeb/lXG8sV UzDS0hs3n0Qox1yKFbVNBq2IZfVWzANqxjNMpAaXZjEtw== X-Received: by 2002:a05:6000:2908:b0:46d:9871:1a44 with SMTP id ffacd0b85a97d-47f2dcc5c1amr11070214f8f.32.1783971617968; Mon, 13 Jul 2026 12:40:17 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c4320sm1648928f8f.32.2026.07.13.12.40.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Jul 2026 12:40:17 -0700 (PDT) From: Doruk Tan Ozturk To: Vladimir Oltean , Andrew Lunn , Florian Fainelli , Woojung Huh , Nick Child , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sabrina Dubroca , Arun Ramadoss , UNGLinuxDriver@microchip.com, Michael Ellerman , Doruk Tan Ozturk , stable@vger.kernel.org Subject: [PATCH net 2/3] net: dsa: tag_ksz: don't read an unset MAC header in lan937x_xmit() Date: Mon, 13 Jul 2026 21:40:09 +0200 Message-ID: <20260713194010.54642-3-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713194010.54642-1-doruk@0sec.ai> References: <20260713194010.54642-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" lan937x_xmit() reads the Ethernet header via eth_hdr(skb) to test the destination address. The sibling xmit paths in this file (ksz8795_xmit, ksz9477_xmit, ksz9893_xmit) already use skb_eth_hdr(); lan937x_xmit() is the lone hold-out. On the AF_PACKET SOCK_RAW + PACKET_QDISC_BYPASS transmit path the skb reaches ndo_start_xmit() with the MAC header unset, so eth_hdr(skb) resolves to skb->head + (u16)~0 and the read is out of bounds. On the TX path the L2 header is at skb->data, so use skb_eth_hdr(), as done for the same class by commit f5089008f90c ("macsec: don't read an unset MAC header in macsec_encr= ypt()") and commit 96cc4b69581d ("macvlan: do not assume mac_header is set in macvl= an_broadcast()"). Fixes: 092f875131dc ("net: dsa: tag_ksz: add tag handling for Microchip LAN= 937x") Cc: stable@vger.kernel.org Found by 0sec automated security-research tooling (https://0sec.ai). Assisted-by: 0sec:claude-opus-4-8 Signed-off-by: Doruk Tan Ozturk --- net/dsa/tag_ksz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index 67fa89f102e0..4f74336ae396 100644 --- a/net/dsa/tag_ksz.c +++ b/net/dsa/tag_ksz.c @@ -430,7 +430,7 @@ static struct sk_buff *lan937x_xmit(struct sk_buff *skb, u16 queue_mapping =3D skb_get_queue_mapping(skb); u8 prio =3D netdev_txq_to_tc(dev, queue_mapping); struct dsa_port *dp =3D dsa_user_to_port(dev); - const struct ethhdr *hdr =3D eth_hdr(skb); + const struct ethhdr *hdr =3D skb_eth_hdr(skb); __be16 *tag; u16 val; =20 --=20 2.43.0 From nobody Sat Jul 25 20:47:10 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE2D35AC01 for ; Mon, 13 Jul 2026 19:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971623; cv=none; b=Dlt7EKsQM4E8XZayN0IdatItB9B9Tm7qNwVYsJAsivnbUXEvoxLiorK0FZp9JHDTqjGGH/y0yOBTZ0Oxb1jaAO4daukaYM6vY49Z9QCnIWZNTDoUbv+TlwDNKMNUkBMsKDQoPbM1qZhUjYLGd+X7Y9DhYWxRGBWLD/jzC2JahkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971623; c=relaxed/simple; bh=Qb2HIoMSqWqjQCWpGfmBQN/eCpG6jcj8qiqVtJGiIdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R5rlgfkB9FTxNkdyjGbyTyj1WlBWUqn1luaGkR6dXAqFilbai0g1M7g1VFceW/IVlvFAJgj1a08P3bcbBsU7uoqdgviyFeOHBZPUtiIJqe9re26Sxob319yeoN6KEhyAR7+Z8QvXmifJylO2g9XIK9IQwXeIK37yo53cvp+EvpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=Rt0Okg/R; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="Rt0Okg/R" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47640541585so1683255f8f.1 for ; Mon, 13 Jul 2026 12:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783971620; x=1784576420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8SE6mH/eebwrYuJdjdXRg/YfI81pgkyA3KxLJxVspBM=; b=Rt0Okg/R7m2LYzMem/ylCjKCEzz69c8dLbMOcZti5wRcXsg1ktmSA7lar8vT1POltc eA/DCf7sMTam6DmzQZ/uEG2ycSY6mvUcI4pFSQ0BCat8nNIZKSEZDAYqO29MgEKL7meO 1jCh+8ortx6Q5Z4RMUuxOsoyX4yl5iHU+ST0bVip6L2s+VseD+vroJwrM0SVba7N1hlP Y2g6GRcfneRw45jJH8hU29kg2YDHdPXmIqHdMnSCLSZlvXHPuhDbTWFG33wlqeLNGhUI fmt9B2yuuAk74yNuvkCKFGFWNVYwvqsoQTr098cRgvM8Ilcb9jQsQCXblbI6Bj2EnJm9 grrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783971620; x=1784576420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8SE6mH/eebwrYuJdjdXRg/YfI81pgkyA3KxLJxVspBM=; b=WPAMa6WK2Gzc+kGwZvcYWJ2EMFofmyHdPemhkTOQO03Esh1NvIaPhdEpl/Y2NKbPHe kNASDpWubwvO9+nXA+SWb0yRYUEuXzuEgpU7xxAEwAyTnnGGhaDMcoVMHOtkaACoM6Ag 2+MHYfTfDbJRtdh+gNB0V3jypjJoVNRm9GDF5kK+hRPdJ6DJevFeU/6UXnV0pRIrwKUT J7R2qKbQ6f+L2KSEnkpcrOez/+RX3TH/7bW1zTN7n1dp+O9TXhV5IJa3vd4sVpUhbRpm oSIaAF9GPoRqeKDPXlULiwyZV2YcVRa15VBiMTnleQQqsbnDGibIeH5G8AOnXPX8ShTb a3TQ== X-Forwarded-Encrypted: i=1; AHgh+RqMLeldoJ+VW7bGcz9KPlwsibM3x9pPRvAsomvorKacm1YyDZiZqfYpvzhJKPp4no+QOb0mCvnpkJko1co=@vger.kernel.org X-Gm-Message-State: AOJu0YwRTQV3KVtoLx1UiNkg1wA/TJ9GGYv62/TdM4HKHKpT6uEje8qH twax2BMe49157LqDidMXt5zk2f6j4sox1kbMUIFkEEHZsFUA3zOLoJrkR3edFXL+G4xXEhLM5HI rLk3y2BlQ X-Gm-Gg: AfdE7cklUJW/474o/VTowAy2HRuUDf8cb15IXW355EQY8Dg/wBw4XiRtNyqluySQjIW V1zNZyV/FQon145Rvc/kbY7NVPhG0fJFApDib99az78Truf1ovnGBCuEHnuZ3HkW+kFnDi07L0b 16AlvsYoh7Huy2fZ5cXlRPQb2ihOe66WYoqOou2DlF9+Mo8lRqAbz6ZktnjfNfR7Gfmoc9yNSqr I6pJLvEyiAgXrG0qqafkpHSw1sAV7TwKoXoVweHvW9Lm9tUAdDJMysodBVFlpsnmkUj9M/7+6Mi bJvxBI3rXWlYtP3ro7pvQ1w5JPRgtO0WeTXMQYhr4RgtTcY+Vozb/wpivYEhPW/461P51UoqkqY /+8mzGXupagc/HNuso14zq5ybY9cIfbZpZXNNwplrBWQR6qgF+sBxsaYwldUCQIG71SREh89I3m ThbL1qK3KidHZk9i21EJxiPcms9lpZEnAhPg7tmfIeUP7EbmqMgscbGblrmHilEG1HcU3Ztg2jK SbU8qyUrIChmvBwfFTh+Ie4HT/fiCR50Lg= X-Received: by 2002:a5d:5846:0:b0:474:9002:c74a with SMTP id ffacd0b85a97d-47f2dced169mr11560342f8f.35.1783971619960; Mon, 13 Jul 2026 12:40:19 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c4320sm1648928f8f.32.2026.07.13.12.40.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Jul 2026 12:40:19 -0700 (PDT) From: Doruk Tan Ozturk To: Vladimir Oltean , Andrew Lunn , Florian Fainelli , Woojung Huh , Nick Child , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sabrina Dubroca , Arun Ramadoss , UNGLinuxDriver@microchip.com, Michael Ellerman , Doruk Tan Ozturk , stable@vger.kernel.org Subject: [PATCH net 3/3] ibmveth: don't read an unset MAC header on transmit Date: Mon, 13 Jul 2026 21:40:10 +0200 Message-ID: <20260713194010.54642-4-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713194010.54642-1-doruk@0sec.ai> References: <20260713194010.54642-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ibmveth_is_packet_unsupported(), called from ibmveth_start_xmit(), reads the Ethernet header via eth_hdr(skb) to test the destination address. On the AF_PACKET SOCK_RAW + PACKET_QDISC_BYPASS transmit path the skb reaches ndo_start_xmit() with the MAC header unset, so eth_hdr(skb) resolves to skb->head + (u16)~0 and the read is out of bounds. On the TX path the L2 header is at skb->data, so use skb_eth_hdr(), as done for the same class by commit f5089008f90c ("macsec: don't read an unset MAC header in macsec_encr= ypt()") and commit 96cc4b69581d ("macvlan: do not assume mac_header is set in macvl= an_broadcast()"). Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to= the hypervisor") Cc: stable@vger.kernel.org Found by 0sec automated security-research tooling (https://0sec.ai). Assisted-by: 0sec:claude-opus-4-8 Signed-off-by: Doruk Tan Ozturk --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/= ibmveth.c index 73e051d26b9d..88e8bdfbcd11 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1218,7 +1218,7 @@ static int ibmveth_is_packet_unsupported(struct sk_bu= ff *skb, struct ethhdr *ether_header; int ret =3D 0; =20 - ether_header =3D eth_hdr(skb); + ether_header =3D skb_eth_hdr(skb); =20 if (ether_addr_equal(ether_header->h_dest, netdev->dev_addr)) { netdev_dbg(netdev, "veth doesn't support loopback packets, dropping pack= et.\n"); --=20 2.43.0