From nobody Sat Jul 25 20:49:13 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99F81360ECF for ; Tue, 14 Jul 2026 01:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783992507; cv=none; b=YltFASfpnUe0uqkSQ4K8Mtcy5a7foMwNqIqbvQdhNiiAohKQqXUdGim8w/UGLswKiMHQpDEqiJB6wEONkso2xotT3YSS441sboeigHVlfCjUc2PWy1fC9wUXFkEYip/RwsU/PprkpLhVP0NorFVoecW/+Z9D6bYKkaqLdkX965I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783992507; c=relaxed/simple; bh=8XoGhhKgqN/YoJDmz9HpOCDXOEv2AVUfCsAXDpg/FNI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kj8Xr/T32tYKXhF5CaXpaOLGM4pCiuPPpxS6eORSTS/ATbH5eKdF7FJCQCOl63bhhiqQ7Jfq6BXJZHskbobJWAfRSv9ze9TXJjsdO4A4M9j5GA3S6aA+ck8C/UDL6dVXLYujfHZAVgNAfPZ/90F4Ganbbi2OXETtpOXDcgXNm7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Rd09pv2Q; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Rd09pv2Q" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8485b358552so4136017b3a.2 for ; Mon, 13 Jul 2026 18:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783992505; x=1784597305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lHkAb0RBcm3J3n60JT3c4eRKzmhDbTFAAzgucXF3t5M=; b=Rd09pv2QxfB4JK6EWpIQivyGdebx478MicqGXwTJMgUN9qKZLuNyWQJI7a++UZres3 jQTRhroYhCtlGeFrlS71HNiVX6OJaKnuV4msSPZ+kmvkyrwzYOYVnk9uOZi76CrEw2ZT GAC6McL7B4Lep64GERzEyO4d243uH0ZtnEUng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783992505; x=1784597305; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lHkAb0RBcm3J3n60JT3c4eRKzmhDbTFAAzgucXF3t5M=; b=jmS9IUYx3sqqbHstuiGi31fdj5/+W7kyw+HcyqSrZSyaAHB3ZcKQlodZLkhoe2B919 T2FmzWwKmt2l9wdUb7s16ZRHpXZr/bc/En4RaQkw74jlPa4zFZSpVNYRlROwi51XjDjd h+5kgzzzUDYP4yORTRF1c0b9TlIbsnRf6szNvUgZ6gKOCb0XE36v7XdTg0lYZZDPLgPE XUv0vX2RRbh1VOSyTPJchSvJTrnRmeEetFh8vcFNESlGTCj850SNRL/eUry8Q5w8ZlmX ZkD6ybEVO1oxgEBEQj9dcKLzq3SughsAr+t9CqGJlGRGOyiWvqNraq7Rze8t05KOc0ci Y74Q== X-Forwarded-Encrypted: i=1; AHgh+RrJkrRVSero/LMnRDsUUe9PLLP9l1uOh9Wui2BBWbaIvR/26Q4NDRbyMUWvw60exEtHEDFeiw3F3lA7QA8=@vger.kernel.org X-Gm-Message-State: AOJu0Yytk6UOLeaXnEIhJMt+c/cs9LVPC6SsAdkOGy72HU+KW8ijucUX UZppsG0cvLNk/a0yWCJq88DPG++z9Yr7aq0r5KqLf3nbhU5s1wR78UuJVhTKe6Ac0w== X-Gm-Gg: AfdE7cliZbsUO3eiQnJsaHoNQnQKEK9rFX7nCq1HqSy6Mr1xEiO7kGSqAV5lRr5u9k6 MANFoKBFT1livLZ4F2yN9lUQHkp8z6i/IVn2NsxosCem92lc1OR5QP4BF44R87FBILU34MGU8O8 CLDJfxGokQIrtz61lTIiIRN3cYZefS6V2z/FD7pQvWFpHW01KFYY7dAmYDuTFSEwsqZHV687s5A skC6HwT0x7kQzb9cs0IVNw31gPmW7mrwBHWjMfnIA1yTiJ+SYDDnBP4KjYNaavFCA6spXlqh7vn LFEEqpWtVwLD8HYnmjtctU6BBt4Y2mK962cKBSgJBlo42AVuRkiFBCsPOlcGlW4/hYAlZzD3M5Q hJYc4u9yIY7ZSt/MJq2oelACudC3CAARXN60iPMZfdPinjHdDV6P40uaCQH3At808Q+KW00F9OS dMqOIy3aXJ5LKjaCt4imV11T20B+d1E/hgrJKqGlDkDnWiM0uJTaAAp4MoZGhQRw== X-Received: by 2002:a05:6a21:329d:b0:3bf:9fe1:c27 with SMTP id adf61e73a8af0-3c35754e38fmr109532637.40.1783992505000; Mon, 13 Jul 2026 18:28:25 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:5106:b6e9:abed:6332]) by smtp.gmail.com with UTF8SMTPSA id 5a478bee46e88-313cb804197sm25344454eec.13.2026.07.13.18.28.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 18:28:24 -0700 (PDT) From: Brian Norris To: Andy Whitcroft , Joe Perches Cc: Dan Williams , linux-kernel@vger.kernel.org, Peter Zijlstra , Brian Norris Subject: [PATCH] checkpatch: Ignore indent for conditions inside DEFINE_FREE() Date: Mon, 13 Jul 2026 18:27:59 -0700 Message-ID: <20260713182759.1.Ia65df416df6120af1298ac97ffae143619d62da0@changeid> X-Mailer: git-send-email 2.55.0.141.g00534a21ce-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DEFINE_FREE() macros tend to include conditions, and checkpatch likes to complain: WARNING: suspect code indent for conditional statements (0, 0) #77: FILE: drivers/pci/tsm.c:77: +DEFINE_FREE(tsm_remove, struct pci_tsm *, if (_T) tsm_remove(_T)) [...] +static void pci_tsm_walk_fns(struct pci_dev *pdev, Suppress these warnings. Closes: https://lore.kernel.org/all/68ed99a5b6308_1992810024@dwillia2-mobl4= .notmuch/ Signed-off-by: Brian Norris --- scripts/checkpatch.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b7a42bbdd94..45df5071541d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4441,7 +4441,10 @@ sub process { } =20 # Check relative indent for conditionals and blocks. - if ($line =3D~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|(= ?:do|else)\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { + if ($line =3D~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|(= ?:do|else)\b)/ && + $line !~ /^.\s*#/ && + $line !~ /\}\s*while\s*/ && + $line !~ /\bDEFINE_FREE\(/) { ($stat, $cond, $line_nr_next, $remain_next, $off_next) =3D ctx_statement_block($linenr, $realcnt, 0) if (!defined $stat); --=20 2.55.0.141.g00534a21ce-goog