From nobody Sat Jul 25 20:48:39 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07AFD2D3225 for ; Mon, 13 Jul 2026 17:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783963291; cv=none; b=TlBjuJ8e8cnW6CdAjaeI+CwrBXke3I/iWUSonli2IteBdnyJjsEw5DfMY30bwi6plQ+EC9oqvLvmlSLyCLsmUSMP28VAMH3aVackZd7ROK02S2B3O9Avs3QcWY5WuMc4oAJ4LQo4CijSFM/XP42xai9q4RsLYPO+3nGS9xqnHq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783963291; c=relaxed/simple; bh=H1Iz7IMNy+NBBLF2lJ4JDxKCCY2c6NJXPxecRbmI2+A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mIZIPnSDDUJ4fJGaBR28FW6x2a3CYwBzbsWiSZ3lfDIzEpIt1oHprqcI4zqDH2HHjDccgFpb9mIBh5SxQDv3ZCS3Nm55JGiBJ2Du/klYHUfoXPa61/YlOgli66G6gIB+gSnhn2RLXkIvdUKNK0tjI3SokH0zJpHsmL47Q/JKsAw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jqgTijHK; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jqgTijHK" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so3280866a91.0 for ; Mon, 13 Jul 2026 10:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783963289; x=1784568089; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tNqpsvb529pea4MTwMPJfT3oG4xMq+3jZrBViJ1NtuA=; b=jqgTijHKeVnCLadq5qWVEkX6luJ8bSulPzGktOAsFGUChLERXlepLISrfwghmuCOD8 LJhA7ID+8hnC59LWbjmFXGVHMBVknnjQn90AXhi7tonElE1e9FtNp38GdBTCM4ptLk8D y2SC0x73o3ipFuEbC3B4PW8r7EjdZ1Nzqa6jhHVlp/t4YEd236QzuvT661yhrE8aW/XH 5H0RmbCZ8lMfQf9shEFVsQy/Hm9/NeRPLOL3RXD71UJCazIXSj7f6LV07QzjRFyeOV4A 00Wtzr2ao1cbC5LaBDIF9UPwko8q4WzNLS7GulZsOoSVsT2ZXVboqeU8Vug2d/bPoPd3 QaJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783963289; x=1784568089; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tNqpsvb529pea4MTwMPJfT3oG4xMq+3jZrBViJ1NtuA=; b=KLB310Lw8GFj48HZAvHXFsMNXY9/h6ljd0K19OGHiGJJZEWaEfXtgrhln97ApvLnkH oXSMtJeucuuAE38c0a04oLiBa9q9fSwxNZLyNYEsWZLquwIs0SzfoSu3nx9JgEde4Jl0 qWgFU+Xgmgw11UI8Wn4VKN5+uCruO4lb3xoRSFj2o8LJKukGtE+RBDaPrJhU8v7AlxhJ ssqP1Eo3uhWB04YpsA5nntktVwgKwC/+VAC7lkvxlDcqMyMSPdufbjtcHtwtFBjeRhqh K+5IMmfZXuieIsec7bvAWEOjcrqiLSP02wOMfn3HqxmLz4++fb4iwqTh2XoYWa6+FNIH /K7Q== X-Forwarded-Encrypted: i=1; AHgh+RqPENvcjI7BNikUmdxY6nhdhIs8+h/bhNr27Op9TnEcEeG90svFzk5tprRfeSlV5mzgKVzYV8b3oGeByQA=@vger.kernel.org X-Gm-Message-State: AOJu0YycbF5k+kK68ipBBxV/kBzurv3B8sQlm/4+dKISuzAp5TTAKT8b 5Hip3HS/GU3I6lLwnbZ+ej84tcrwoFCQKprTj3ceaCtdDCjfX583XtN/ X-Gm-Gg: AfdE7cliRZOQrnMyKzvjl4QhdZEeMZ8ci1opb4nV/mLn+sUJh5IG/z5bWkHP0VwCg6t AJFQlp8G9PxnNTuwqJOa/5RIsgv9YuhdIA1qfgIozvXv7Nug88Xnow4MO3utQcrKWnfH8j0UDEJ bTsOwjLBG9XW85pHLfOvqX4niffHWN8Sulf5ikJGx0QPIexwZI64/iDVMUnwdvFFxMAPVrit1BU B6CKnoSE/Id+inl0kcb35BczJdkrhq7M9lOm/vAeJviSTgbeLI2Ojo489MASCidrUP4XtXlldR5 ytUl+RC0HjBHpKvF9h0bWPh9365Rhqod2WLyBGqeNw8B0Epl4SjJ/LJ9gT+LLWIcQbPUAHwAyhT W/kHEx35pdJAtFgjPoFrh96A+ufn7rqTvR6xBHQ/DBRlOaWklfXSYew8uXzT6QdE6OCS0KG9DGR 11IWU938QIu9Nl8O7v5LGrTYve6u3hbByVnED7YK8tveCQqTDA6ePKeHxuVz5WtSYm4UFi+0iRz Q5ipX/wguyhqDEe9vfiJugxY8jH+3PvCKF5YQSuL7fAGA8= X-Received: by 2002:a17:90b:5112:b0:381:6c5:3f63 with SMTP id 98e67ed59e1d1-38e17d96405mr129387a91.6.1783963289228; Mon, 13 Jul 2026 10:21:29 -0700 (PDT) Received: from OMEN ([103.184.238.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b4cbafa1sm57958608eec.6.2026.07.13.10.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 10:21:28 -0700 (PDT) From: Alfie Varghese To: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org Cc: bingbu.cao@intel.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alfie Varghese Subject: [PATCH] staging: media: ipu7: add NULL checks before ipu7_mmu_cleanup() in remove Date: Mon, 13 Jul 2026 22:51:27 +0530 Message-ID: <20260713172127.615-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ipu7_pci_remove() calls ipu7_mmu_cleanup() on isp->isys->mmu and isp->psys->mmu without checking whether isys or psys are valid pointers. If ipu7_pci_probe() partially failed and left isys or psys as NULL or an error pointer, the remove path will dereference a bad pointer and crash the kernel. The probe error cleanup path already guards these calls correctly with IS_ERR_OR_NULL() checks. Apply the same guards in ipu7_pci_remove(). Signed-off-by: Alfie Varghese --- drivers/staging/media/ipu7/ipu7.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu7/ipu7.c b/drivers/staging/media/ipu7= /ipu7.c index 310e3f24e571..41436f22c684 100644 --- a/drivers/staging/media/ipu7/ipu7.c +++ b/drivers/staging/media/ipu7/ipu7.c @@ -2637,8 +2637,10 @@ static void ipu7_pci_remove(struct pci_dev *pdev) if (!IS_ERR_OR_NULL(isp->fw_code_region)) vfree(isp->fw_code_region); =20 - ipu7_mmu_cleanup(isp->isys->mmu); - ipu7_mmu_cleanup(isp->psys->mmu); + if (!IS_ERR_OR_NULL(isp->isys) && !IS_ERR_OR_NULL(isp->isys->mmu)) + ipu7_mmu_cleanup(isp->isys->mmu); + if (!IS_ERR_OR_NULL(isp->psys) && !IS_ERR_OR_NULL(isp->psys->mmu)) + ipu7_mmu_cleanup(isp->psys->mmu); =20 ipu7_bus_del_devices(pdev);