From nobody Sat Jul 25 21:20:41 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8446D327C0D for ; Mon, 13 Jul 2026 17:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783962529; cv=none; b=Yq7Sjy9bJNIB7XcyZy4ipNoF6KTxujGZDNKCsFo8TlsJloe00ZV1QUxk6mgPNUPg7sdtbON6+wH0dlRr5A+9NCsz1XXaiwHdESHtK8o1kT4KUlOOB+6kG27AN/SdHXhNVxTM1RldB5wBX88DM9hNa3cvlkO+OQF8bnmsr9kbBpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783962529; c=relaxed/simple; bh=lo4+XCpPDh8c0k0gz8YEx1ohqw/wcd4J6whfyFX7xmU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cZE11J7QLbcZjUuIhL9dof0Gt2UHnHc/J4WkIBoaaNEx5BdV/Fglel5IbDGL2VKN5cXE7zk43PgJAA5YqGrODhvZaQ4u/9PHyokudR027FUwVWTVhFxr8FDHJ5WCyfrwMqgLNXRBANAo21XbsobQTb3ZfDJrSlDR8yJtFgBXuS0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d/YO9JtR; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d/YO9JtR" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8486ac3f347so116116b3a.1 for ; Mon, 13 Jul 2026 10:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783962528; x=1784567328; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qFgEIJe873D6LcL30QNtzeLHCAWHrsjuemBtpi5imkw=; b=d/YO9JtRADPkJ10B0VncBr8FFngFG9qy6IZ2nf38QyLTxUh5Jd1cVJr+m5ElzCAukl X+iC6ZklwyJsSftbJCRVGUFbme+CeNJhqnuydkxmV7uC16+TNTxQ2sVBSkRbHmF2YzgJ vTTTfOna7psyR5pJDLtOUGrmF8bBvUJF4FR7bdZttjE/h5cDTE2dbLoy4+feRv5Zb/69 pdu0mLA11XhcwGz28v3h0AuZtIj/6lOpsby2b9Xx9ASLBVCPV7UtuGvInAmX6zqUfYVm 8nxSseBScjuNt8ybG9RJZj3dhrJEmWJmRmq9ndTBGVZy/Wj1rXevsatWWxfUPxDH2pkC h9Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783962528; x=1784567328; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qFgEIJe873D6LcL30QNtzeLHCAWHrsjuemBtpi5imkw=; b=gh5O9FZJmUY8XvlL4d4Tjv4/Q5lnHJycpd7VBNZsSgFL3bk+nilbJ33Hj/E5+B6iHi z58EAjR7EXIGFf1EES14hWd0of8Pjd52pTjYeOJtuAIhd8KJS7ykONRmincOoux5IZJz kWejvjyXtJFkfHme15wZdqLamfpP8kP3YIKKDFW75Be3oI+If7iqPXUIaz5c+I/aCxCA JF9qSE9D7htazeME4nrIsR2E0WhQX8f/clyNhJhXPUQbGugqPh4hPt6Jsde1A/COx6c6 FaJwcunFXPLX2jubNk6dVf6Yui5INnYKqnBOuzIbWT5rF4B0/6W3DYXS1QntJdii7b9e dg6A== X-Forwarded-Encrypted: i=1; AHgh+Rp8myzUqxy7gQJavN02OAXm2tSMgKn7rz1MTlWawIp6JAnKa87fHiYmpXJOvi33cpTGL9cW3E2mk1u76S8=@vger.kernel.org X-Gm-Message-State: AOJu0YytXNe/PfFpKh7NMWq5EisQDMv+XTQ0E8IdLxSUiCAbRKies8vj 11lOP0fp68Fx9WECqP6Mq/3hxSJeH2ufgtBxaAUsOZAmlyoar9AZvnZe X-Gm-Gg: AfdE7cm4T6gxsvdqb7kBgRdCr66X0BmBEvRhSnB8LAPsnDIXuaepagxDDOMUVVIn5bI fOFzOuk1qeXV7w3nqJrOb36NQOtw0eUlOVQm3LmAqS45cQ33d2WOCWsC9atywCBBI6dogkqmmP7 9Z0ATVgu3uY8lhhlG0IQufBGciF1SWX8RickPglx1D6Ylw6v2fUzkB1fLc98qRXykqshthZDePn dBebfb++vz/2UfwHuhisHZUd4IAmsKAOljZc84oJtLL/j2yuzoERfaQQpSCvdnYNBknF+cv+iVp t8QyZ/CKiMac4lHp6mAYMUzUDfIuyi1PZXHbeMd06Ct7McjZDrUJRjcQ+dfB4xkdMDZhogd0xP9 lLQ/bJ2TGxuH8VgC11HbyRLVEhLXUv3W00azu0M7S2/918uAWbGWV3954ZpqXv5Bnq26Em9KuDb xTQD1EyvHSX6I5v0gCWYTBVPo2aV12JpxuRLlzcO9WJBh9lUCRfmOYnWaHDwr2tqn5Z2zBCmZQC 6jJ+aRN6gpuOayq3iTfuBfKnGJkMX2MmU+ab1rbivYKDEJsqW9ct+JHw/d9x/2zzeS/ X-Received: by 2002:a05:6a21:6e43:b0:3bf:b7e8:68ab with SMTP id adf61e73a8af0-3c0f08602bbmr16557584637.2.1783962527926; Mon, 13 Jul 2026 10:08:47 -0700 (PDT) Received: from OMEN ([103.184.238.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d8da9sm123126740c88.14.2026.07.13.10.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 10:08:47 -0700 (PDT) From: Alfie Varghese To: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alfie Varghese Subject: [PATCH] staging: greybus: uart: return tty_alloc_driver() errors Date: Mon, 13 Jul 2026 22:38:45 +0530 Message-ID: <20260713170845.1518-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM. This loses the real errno returned by the driver core and makes failures harder to diagnose correctly. Return PTR_ERR(gb_tty_driver) instead so callers receive the actual failure reason while preserving the existing cleanup path. Signed-off-by: Alfie Varghese --- drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..24b4dab069c3 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -951,7 +951,7 @@ static int gb_tty_init(void) TTY_DRIVER_DYNAMIC_DEV); if (IS_ERR(gb_tty_driver)) { pr_err("Can not allocate tty driver\n"); - retval =3D -ENOMEM; + retval =3D PTR_ERR(gb_tty_driver); goto fail_unregister_dev; } =20 --=20 2.54.0.windows.1