From nobody Sat Jul 25 21:31:10 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012059.outbound.protection.outlook.com [40.107.75.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A02B4425CFC for ; Mon, 13 Jul 2026 13:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949287; cv=fail; b=LgCQGWJNdeKX+2d5IS3yGoEPXF3tKYksDzCcZ5gZ+ukWqCeo92pZ4KDl3zS29VV0iYIaIJjDCO7gU/6wtDZSHYwlmBg/pebkys5DDNJm7nEWBuGxnzcwTiqcAyR33dLpan0D+cgSwVPiznk/Lh9hPitTMnVaXcPt6c1iuq4iPoA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949287; c=relaxed/simple; bh=W9rpx5jiToCLkxu6O5bSQPkDY5P4ZrV/fbnLUp0FBHs=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=fCLk2KvMNI5Gknr+sLLWrUo4xEgwENlqKWF09QNFSjNa1Izo7DKFu6vdC5eANIH3rp0rGxK+WLjC3fRvpLXbpnm50StQXB8BKIA2Xf6hNY1qycBXXhCCXRTo3xP4/Ej1hn5aUVYl0oXN7ZZAY8nVjkXVpatSCCcqcISzprK9BQ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Mlxe0q5N; arc=fail smtp.client-ip=40.107.75.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Mlxe0q5N" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tbjoen4ugaFyG59e5QiOZqs1lk22Wi7Cfobk+yZRJUPtZQ3m9gsGynzaa3FCmSVSaEoS+bcJgRWyamxhuYAdV+iRwJAzBxgkn2Q5+8pEq5TVFrvt6sQMkTqXMyn5dxP58Ln2YqtWfh/jWKVfc/0wMtcRn5LeLi8Ja+xC4Y009bHoBv08sUZQdiBM0J9wUR5tRfIx8DqrwQUCTNxxmoVLSRG+L+bqlbsSjPa4FEUcbTwze7WxE3Omx2khi6NrEtUKHOK6dWiZFLDL6/4ciNz+H2cESn6ZmJd8QpZ211nWRWbGgZoZOEqYBHyY2tHqLV3B4uTWIgzzGQuYjZa1F1l0Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/muWrbXRIrsKYLQlQ25qYxW9G8SceM4TWHah04BrIU=; b=b4btMvH3YdL4oB6C7bOGGync+KGEUFc2hxMuizWRz7Eqo63/MiLIQFL+223ZJ4RiqsxUQeGk/6Kui/q2d3FeRX5yQirbzLmLnrBu2+72wLBpYn1PE82b3tLUXbQ+v0UyAzgNgtNANx2SpvzntihrsTZGFxnyBGJBuvf42aWxwUzs9eJLFOVKz9/dpuLjRsAlIg8ao+et+p2RISUxdHNBlP3FNydJlDzBsq3EIs+ID4+xvELO6jHsg64KG0FfRX4Z7/tYaSvzquv8ENvVxGgscRsGOlZmC3O1lzcdxQXyXAn6TVvArOysgSC/D9MzDSi9OFd6WNvjGcg0Zh2r0Q8dVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/muWrbXRIrsKYLQlQ25qYxW9G8SceM4TWHah04BrIU=; b=Mlxe0q5N/v3pp/2yQiPeN35WjA/siyhFn7cuA1e+5AczQ2e5HLF0iV8tbnI3iwth0gpNSBdMqFjgkofXlJxygvPwiBGHFxKROxVXiw48S43DDECTpyaf4bIfG4MnbaBSNw1rsl0SDw9KUl1iz6m/cWUM809sQf3YaPrgXp2QiZqckaRRJe+iKgkMmWyXDQlj2FeGvoDxsjbTH823EdbzWXLpf65Rc/tUA3v8TW7TiGMU4LYqbwwE4i8DIl3FqwARgFC7qTLuyGKXB7M1ybAqHW306Gc0lKmbS0e6dDpx6N/LCkF5rJQHWv1E8k+cTf8BEePx/y3hP0bM7m9GE9G8tw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by OSNPR06MB8956.apcprd06.prod.outlook.com (2603:1096:604:49b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.23; Mon, 13 Jul 2026 13:28:04 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:28:04 +0000 From: Pan Chuang To: Sebastian Reichel , Pan Chuang , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] HSI: nokia-modem: Remove redundant dev_err() Date: Mon, 13 Jul 2026 21:27:38 +0800 Message-Id: <20260713132747.394970-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713132747.394970-1-panchuang@vivo.com> References: <20260713132747.394970-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0056.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:8::7) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|OSNPR06MB8956:EE_ X-MS-Office365-Filtering-Correlation-Id: 890fbbfc-e61a-4616-050a-08dee0e29164 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|38350700014|18002099003|22082099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: nml6l/tJaYuFSE1zl53rdjqqf2AcDuOe5Q6//wGvry4NFk+/wGNpN38cvf6FFofa4vibua+y7tejki6rB+mJEMFKvAV6sbwKM3j0ANLWnJoFGnGr5naLAftMeCiQx6NFFUn7j4XrbAn1MjbjTtrbOX0bCw8JsNsIRCuek7YBDAlTmO9XHK7qDXWgNmKrziEZ7V3yUH5uBVMX4pLFb8c9Ob6frCKUmQbxiRrniABEb+2VCLOleT43DD8IjGF8qaom8YCsWPic7uKLpCGdCDdjaVdKieYw84f6G+SIdcNqTY1/vsv/1qpzLVbNjjzNfsQUUlv9834ceFGZ69Y7BktOle1Wg0d/0secI+bNYwU9WGelC3d11EdqexUtpCc4C/6qiVmHv8j27b/uy9O1GaAaes83VYbXwxOjeyMMv6KmC4Vz2a/RFFLGwB5G0htxzxYuZ/3BeFOcVF8a9B0e2tz3xQe79q9lGTBnT56qbxTmCwJWd3cX0oGJVFSvTuT1fFpwEX9ux/xiP33sj51/IUrPq97jR9zrbYXVKrr3ILhuDUccC6OCxssHwn7pIurRTf5dJ3memSKsO2b/+vM/Q/FjuX10G175iWmSnlXcyngT2AfJFs80Jfotgwy/+6ly1bNZiN79vDJlNccqbCL0PTr57o/cl5qiQSdjwh/vO8pk3pgmqs7U3qIjJKnBSsG+S1zo7XJP73X47wdjKNOtExn4WT2F8Enulc7ErWSpBxghgok= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(38350700014)(18002099003)(22082099003)(56012099006)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q1f4+1MQ2DJtdI5M77AzyKv4XiYb95nM2RLSNOXGj/ztVUq2Z5kR1+2MXPmw?= =?us-ascii?Q?OnZcImFUxxDkMvPBDEhufyZe3QxD+114h706uvxuUuz4IKSJNz9zINBvSKtW?= =?us-ascii?Q?pzaYizzt/CQste7OjqUk+8RLTgDnwN/qVAC1+pEFBzb5IyNiVr7+icvxUw4R?= =?us-ascii?Q?9Kuj7nTHHPxVP7kCt5G/M4ca42LnDPgi8/gRcjdjHJLAJAXjK1PHqJ1LCFJX?= =?us-ascii?Q?QpYajfhzQ8b9nYJne9UFIFLmsPC7Lg9PYiuikF2rxW+kom8ftrxV8dQx7kTv?= =?us-ascii?Q?Jji6+aWSU7+BK3hP5BlV60Vb0fauVeYR4hcXqMQiD+tYRBad82XBPk2GTK/L?= =?us-ascii?Q?TcNeakcKT4Xg5ZYcd7k0aqjdMwWvSbpW9JDNx+7UNaibi5w0va5Wqarah3TS?= =?us-ascii?Q?uc5ikuzxCHvdomlK7jEPSCHpJEvIGD0X/t9GcroQqITyKJTDHjA2KOUgMorp?= =?us-ascii?Q?+KMEXlw0wXfbJuYMd1SgGOjMzcvcpDzr5ycigfcqU23s5jYhM4hqWmJa30gH?= =?us-ascii?Q?c3UYYEC7GlF98RObH68c/GVBeQsm8+3ztTwRbUOBUpcu15WPIOPZzY3Yt8Xq?= =?us-ascii?Q?0nj8lr4ORYSqbkJoQFg+CPahuuS8Hq1h22dCcohA2mheuh3KMLcbehAE7zRY?= =?us-ascii?Q?a2Oeay2fe/V57q3SiZZSSUhqSJBPVTPzKWL17clFx9rPn+bB8IzAmv+RUXZg?= =?us-ascii?Q?eR8knVEy2ijCendk3cdlK3Ud8HIiiyJyOCsBjiLDO4H4LMYjhjj5Fv3Vurwe?= =?us-ascii?Q?n5OF5MGKDsMdYWQEWiBrky0cyoCjz5ZCWYADJ+vt3sG07zBJQgzI9CZFzx1F?= =?us-ascii?Q?Yo5JYd1j/65dBVnxXLWhXNzJ3ywdM1k4EKANR2ZZRPE1BOCx9H6EBOFoZhwh?= =?us-ascii?Q?f9pqBZhxenUaT9ocnS/1GEbdhQ9ItS/wjxqAOQcO1OzkDGKv/xlLtN98zQqa?= =?us-ascii?Q?/0mndgiu4UuIhDm5Hm9QPy5ZzxW8Sz2TH65EO5EwTd3vWg1o2sz6R2/tkKZU?= =?us-ascii?Q?9xSXSPZpmZrJcxd5Kn0VcA29sDj9JWo2N1caHacExOC7uAOEOn+eNND+dpHG?= =?us-ascii?Q?mDyoud2qWngm+uZTzi9Vpj5h8XjMKWAAlPrh7b3g9ttAJOtOepWhgopewi8F?= =?us-ascii?Q?ttZDQFEny3SqD24sow0gdALYX89o6GcMNWta+2ntPm+kblFjdrjvkbmhZwkN?= =?us-ascii?Q?coqi0+rEGASe0KA/OL9b3jYao3ZJVsOQyvTR5EeL9Ggbt9cz0Yl9yfXHRv74?= =?us-ascii?Q?6kfNdVEtNOvq7iz35FIPDNcaactGKBZVEFxL3dFNQ8q21F+zmTkyQoVpUKDn?= =?us-ascii?Q?StpLyLz0B21P/ZGFx4F9rWxxmDIGhJQ3854ZlQXcSRG6FDvQSFvjd2ctam/d?= =?us-ascii?Q?IdsadgTXVE+ccjLJ/n30vU46nIDmxh+q6WG2kxVbAZ+JorEOBsBB1iDkI0z4?= =?us-ascii?Q?lBXq2+C14vIwDezKinLhQ+Og1DAGaK3Qf/049hw9AvKsYrESrBuG/74fuQ4T?= =?us-ascii?Q?Zwrv0es4LVhaB33AO0oU+JBk3d0gWVNOtWe/GwEE9XfhEbGarGT759v23IOr?= =?us-ascii?Q?Y0wguMFczNy08SxUOGH8g5Xzy/UQJPU1RavrtQlQ/QkVMho/qp/IKcoqvz5R?= =?us-ascii?Q?9oi1C4g6dKesBz20imchwkTx5LCoUNeQSGovNNXM9s6rSNuK8RpR3/uXned6?= =?us-ascii?Q?rzVMyvZU0VZrGQjtBxOa97AB+rPGS9rSHR40eA21QzQz/X4wvloglDfV9HA9?= =?us-ascii?Q?fuFzWOuPrQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 890fbbfc-e61a-4616-050a-08dee0e29164 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:28:04.2221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QlNcBKNyxzNPJMFXl8x7NQA5pFw3f/QZ0DO2w4RHh8ilAi0Ndt0D3Wk2u0Cp0hf+NnGNksa89IZf2xUHvzuYtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSNPR06MB8956 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hsi/clients/nokia-modem.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-= modem.c index 97ba59e60663..88924d757616 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c @@ -157,11 +157,8 @@ static int nokia_modem_probe(struct device *dev) do_nokia_modem_rst_ind_tasklet, (unsigned long)modem); err =3D devm_request_irq(dev, irq, nokia_modem_rst_ind_isr, pflags, "modem_rst_ind", modem); - if (err < 0) { - dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n", - irq, pflags); + if (err < 0) return err; - } enable_irq_wake(irq); =20 if (pm) { --=20 2.34.1 From nobody Sat Jul 25 21:31:10 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012016.outbound.protection.outlook.com [52.101.126.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFC740E8E5 for ; Mon, 13 Jul 2026 13:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949294; cv=fail; b=NM8NaxkrlVlQ5A9p+md7ukdo0FTQPNHerhA3ZNJPbxkdGsnPyjLjKcU/2YfniuTwz716mMoSLcMg0MVgPupLH9LELrZvVC4mL89V4+9EpelZXBYE3DDj0+nGou6uPe3IPPoO7cpJQzJzyMCvq0lZ2e58RsYUFJF87k8oT9SJOfU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949294; c=relaxed/simple; bh=7gr515qcr+upgLNM1OvixXEJVbW1sQMWkmnAlNTV8Sw=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mvnUie8yRyg/zgRij163Av0Kk5QRm/NQSSpymCggK9hx4y8eSmY2csggF/fiDTaiwv+fZI91wWGrLBCwhUebg97wRNkZSbok23MvS86qEI5ZEjQOcfEwBvJkMd0ZTN2NZvnjGEvjHtnYUvvgNPLXkstm87OpRGtIQ4mtRKj5m2c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=CVdGIDxq; arc=fail smtp.client-ip=52.101.126.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="CVdGIDxq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ARRYPS6DpqB1tiR1NnGznEVkA80gQ/6t0w65qeFt9KUzpG+34HZN5rFLlDUh80eyvMMzVfBGIDWdHwdQoXmnqwD7JRi4EBJGBpXMuesvpSPDUwHaVz+Ssk2xWHQu0ZglJ05cI9V4fAnSTGb7jHt+NOcVDSk98WlBMcaR2k22HNWmZ6D4akI3COzMlBKyRVFOooPMqEZHQZ6ykMomlLYM5ruHTPLDMLCDpsyLrZ0PXvGnm8LbJuuKOuGv7ZBDvrQU+wUAXN8qCnzsrMSMNzEopa5zJjSaVPV3QTXXvHUfcLE4nUwnUSQiW0BdTa+8lKD2FQ86YFeAT86FmkDvbby8xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qjPD/SuEUTaKbbX/2sNosm/bRclWozlVDF/Jiyi3UM=; b=vja8rO9Am4+EhjKk0WIVP3OkJc1JmYh3HpQRgRal75MXYPb5IsV1FwRf76CBo+RaE5kSdF/FKnxcFhAGleAjArkR5cGoXcfBv5Jf32O8qBL4C3+8yiwV+yUCBqt1IssRuyk+63SSwvoZ+Sa/As59Bg+yKKwBJUr45aJFWKwV0rB7kADgWD7+/0bJW//58BR9GR5LTvm1zhMwIIuqRyfvKAKz8fGYtrSZeSzRgVWYZiKerZw2D6RQTPWN/6Shmn6CBbtJtF4N35tg0bSLFXDXPE2oso73Z2N+GLWq3ZUJwdBtvPvRFZ27lf5xYPe/fAfo8AI+PRNFMD8lWS+Dv6BpEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qjPD/SuEUTaKbbX/2sNosm/bRclWozlVDF/Jiyi3UM=; b=CVdGIDxqsNY0ChCfzd48Ikv5rxfkiiw1+s85WtmjH0J5zgvtGombtSkuuO6DRtw+vAeMMc6f3s56AGqjvOu8p3gbRy5JNxIkm6TrxOqAdOaxp2P1ZPBrS4pW3hlvIRYNItpkDKbPfX+xPYHCK/7vZAp3WRJUwXqjXR3SVbqCnLQ50/BrhAm4A4vv6s49vECT3PIcRXtYCIPfukizxnrhDJSP11cK3aQCNDwuNgj7rzCNbUduuCNsdGAhkwXFS9TnROIcWrbYylx+HR14BzLpxzdqXE1oNo2feAfxj/e7XKn9jLR17bkdzhQsz1DNRWtQwWs2zmj8piXJsJrZjDhvBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by OSNPR06MB8956.apcprd06.prod.outlook.com (2603:1096:604:49b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.23; Mon, 13 Jul 2026 13:28:10 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:28:10 +0000 From: Pan Chuang To: Sebastian Reichel , Pan Chuang , Rosen Penev , Bjorn Helgaas , Takashi Sakamoto , Sakari Ailus , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] HSI: omap_ssi: Remove redundant dev_err() Date: Mon, 13 Jul 2026 21:27:39 +0800 Message-Id: <20260713132747.394970-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713132747.394970-1-panchuang@vivo.com> References: <20260713132747.394970-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0056.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:8::7) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|OSNPR06MB8956:EE_ X-MS-Office365-Filtering-Correlation-Id: a1b308ca-ac00-45fd-ddf1-08dee0e2954c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|38350700014|18002099003|22082099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: 8VfKyv3sOy7YDNInq/hNtawVYXBBGlHamm0Xkbzdu2TzqfI75n+GrkJxXhEob8K5vaLQ3ZMOHiz96JfBq+bt4Pk+p5fw0j0LZLm7PbhKc0XMRrnPmwJsouVYL0P/gLHqtYyBOdqZ7x+ad00VG6a8marabEcQajcAPol4FnJ4pX9hEqKUzecsAg8ajdhL1RMzZ+2z20KhoeVSpdzwsurAjHurm+xzYrWPiULrNRGEXWU1M/LUtXi0+hv39iHjB39LWgaTCtOOUS35Rmr699cfN3yJstbNM1JJjTguWXq2Eq8D7WRaPvd4iTINhOE4A/NSIOqBjYRLJMWCZ5HMy0+CAL2iwcE/hj2C/2y2VzAiPk4bEj3IOS84pG8y1HFyN5KqRQ57RYvHqGMuN6p9xOSJjZu5BSYD/NILzGslgySbS7fZQQPzOly5aWy4RJ+0LlpFZ28NCDWNdICXEuCxfwNQD7dXUf14Tr0Wb1V5C0KikrlvOfyb/evGj1nn1Cc4Ct5DAR2g5umGL0mhNQO14Q9j1XrUsKD+/ApiEPlPNc8AaCDV7ngF4mMtpPfpumDaOebEEHh7JGIheQO+7+L7LLgEeJUGfPcmrm17w+DzEiGHu0VGHdbmbgxc2Iuq32EhYsNPBx+mdY/q271R/jt4PrtgQXcv7ZLuNPIg6QW4YYdMVw+GSJAq7YE9PHCNIw8rkRT7uJbxAOgy3ZkcdNzqyQ3DFhkXFu648Dff7hXyZ8uqEZg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(38350700014)(18002099003)(22082099003)(56012099006)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tNo2fhcOZIJl2AZwZGTZHiWXeY2xzd7FdnMqJ58nc6P1mphqg/dG3gL50f7L?= =?us-ascii?Q?USe7dlm8dVq39iJ8udX5rG+wGgjLTvdkHfYQ9sJDKwzSFbUeMZcgx/OcXBUa?= =?us-ascii?Q?oFh4+6LQEJ09nThpBqTbjlo+QYQ0IhMjDWZtp75MpVMKpI+UAVWeojOYk1IN?= =?us-ascii?Q?i7xK0dHlp570GDu0fFm3W8K6/bec9i+Cq7XFOO6s4GoSvRnht0u6mCEgHl+D?= =?us-ascii?Q?Nphe8JLmgMKEjSK+rJrAwe7J7/8FGdCMX76SeN0jO9Gjx3oUZNB2iRQxDBL1?= =?us-ascii?Q?siFMPfhh1qSfQMFCUeKcRkYejNmjNjLzwA3H0O/fWY9Zuvo+Ps4/h6ndpAic?= =?us-ascii?Q?jANN8sH9W2iQjzypGGwWsL2lhgEZQ+2pPYd1NwiDatj7rmbOFxHJorrqZKCp?= =?us-ascii?Q?/ajJ+GQ/y2c5051UOZWMhCV8TxQxT/4fsMmJdovcAVtboxiyE+n0a4CQB8S7?= =?us-ascii?Q?Tg8cwrd+LOc907SAZ+juJE7fW1/xJmsLXGwBcYrJsW39xtkzqr8zRoZfdzQe?= =?us-ascii?Q?t9/AY0fpz9pSIdcuwMI1ExcQEu1hp8HafoCikb7/yH03iDmTA6kh5hF9i2b/?= =?us-ascii?Q?U/ZhEmbofSd5V/wGhiUjnIOM6Ib4QkkbcYRFED8JzYmC2Oniq90T/M30LjzI?= =?us-ascii?Q?DxcK3EcYYbMsgBiCzs0Rue2SSuCUQhfjKEmzWHW7P6S6VcfSL7SkppVs2cFQ?= =?us-ascii?Q?t/hruxOt/GSUsNH7807v8SFznNSQHKgxKcwVuASvlhtYxVSdD7sROklZMD7n?= =?us-ascii?Q?3XhnWNfXlFpUxHy9NmHN1yFoUNj+kN5OmFlXpXSHmZ+8HV1QbAb6vmD9rXv4?= =?us-ascii?Q?8pSTnSf0lf9yy7MNtfkNw9f2+II+xalvy6HJvn6L1nmRWy+QyV+eSDws70cA?= =?us-ascii?Q?FERJwPlh1HMzRBtXo2cHY3QSRUFxRLpEYbJEuEbOhQEC3cDg7jgoPTO1ErGh?= =?us-ascii?Q?Q8T4pB5a2XV7t2badsu+t7+JOfT1BlYGJvLmT0VTr4SSZSvfYo03TspbgOQ5?= =?us-ascii?Q?8iscck0S58nMi2I8yKF/NkARKBPcizU+YNyaQYT/92UE/VngtAMzSnbCEs/Q?= =?us-ascii?Q?31MMNMUrLXoAdgiZlrPBvLxFOebAiCRVXxqDPY8kyWqBCYZ+nuTV7veFdM58?= =?us-ascii?Q?V5U3jC8ZVvjXSi5wyfUdDKm0ub9BhMXvbtTh39YOErCLtzKklSgmh0d/xaVO?= =?us-ascii?Q?24UDLy11gxnQkwLBvkxbdXxKnjDM0q/Vvee9RXO1RtOVU/pqjR/AtSvlTKiD?= =?us-ascii?Q?D9VwJEELlkefITr5b3M+aPbPP0Lfq+WaswsU0Iaxuh6iU1AqC5u9WbvBFj3R?= =?us-ascii?Q?ZxBBdfrUufnfN6N2Eg9vBkQt4y/Up8DzyuVV6fPQmqvZHTbgsnY07GNQBk+p?= =?us-ascii?Q?i6cBXpVTv0uxzkLz8oo95hRVyGdG1ECBQAuRi86YIg3INiSpdxnbr2TZv9WM?= =?us-ascii?Q?vMUeVMShfFKJAtOT1gUXyl9EoW9lgrHtlItKhDqRVwUPFjiDln1ICeZ//svx?= =?us-ascii?Q?veg4Ryu+9vNLYOQTR/EhM/Qp+7cwuUsFkFEvO4h2W3y6o8vMZY7uwjofaiNS?= =?us-ascii?Q?8pMnsiMChnLafVjXc9f1IZ0S+Z84y2rzhh6Og4OmZwnQhM9rm7lx+qnTDO7S?= =?us-ascii?Q?kCqtXV7+69Uck5YznFQ5JL1LTy2siQR5Pa/mHuk7Ectpiuj5WGHMnytnuUJ3?= =?us-ascii?Q?AYtWdtVGzVkp9bxDf4tNDILTM8Z1BBxwOhAn8xAUrjGWFHrEyyoUILGH2K2U?= =?us-ascii?Q?XZMQHrbzKQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1b308ca-ac00-45fd-ddf1-08dee0e2954c X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:28:10.6981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KUxOLBoMouFoWN3Rtu4OKt2xAlauOWjT+T7khoeyESiMje6snK2hPMXO36/GxUBqewl69X7zm+Fuf3O8WaH47Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSNPR06MB8956 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq() automatically log detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hsi/controllers/omap_ssi_core.c | 5 +---- drivers/hsi/controllers/omap_ssi_port.c | 6 ------ 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controll= ers/omap_ssi_core.c index eeacc427fd65..dbc4119fc305 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -370,11 +370,8 @@ static int ssi_add_controller(struct hsi_controller *s= si, (unsigned long)ssi); err =3D devm_request_irq(&ssi->device, omap_ssi->gdd_irq, ssi_gdd_isr, 0, "gdd_mpu", ssi); - if (err < 0) { - dev_err(&ssi->device, "Request GDD IRQ %d failed (%d)", - omap_ssi->gdd_irq, err); + if (err < 0) goto out_err; - } =20 omap_ssi->port =3D devm_kcalloc(&ssi->device, ssi->num_ports, sizeof(*omap_ssi->port), GFP_KERNEL); diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controll= ers/omap_ssi_port.c index 98810bfd1ca8..63e8bc44630a 100644 --- a/drivers/hsi/controllers/omap_ssi_port.c +++ b/drivers/hsi/controllers/omap_ssi_port.c @@ -1024,9 +1024,6 @@ static int ssi_port_irq(struct hsi_port *port, struct= platform_device *pd) omap_port->irq =3D err; err =3D devm_request_threaded_irq(&port->device, omap_port->irq, NULL, ssi_pio_thread, IRQF_ONESHOT, "SSI PORT", port); - if (err < 0) - dev_err(&port->device, "Request IRQ %d failed (%d)\n", - omap_port->irq, err); return err; } =20 @@ -1048,9 +1045,6 @@ static int ssi_wake_irq(struct hsi_port *port, struct= platform_device *pd) ssi_wake_thread, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "SSI cawake", port); - if (err < 0) - dev_err(&port->device, "Request Wake in IRQ %d failed %d\n", - cawake_irq, err); err =3D enable_irq_wake(cawake_irq); if (err < 0) dev_err(&port->device, "Enable wake on the wakeline in irq %d failed %d\= n", --=20 2.34.1