From nobody Sat Jul 25 21:23:04 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013015.outbound.protection.outlook.com [52.101.127.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E55B542B321; Mon, 13 Jul 2026 13:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949102; cv=fail; b=VzxUdMIyb+sIuxWhc9KUZ9iZcttVOeilKA18R/jd2M/Wn9r+XrKiolXGNgqASwUmq0Vxff3Qqj37grFnvcb1cUQ8UIQ3d1dzGJBzul4CZrXXR/X7Dt89+lH+AiYCG6aNZCwfOdm+vH+dBBeYQmAUutGfL9vY7OmN1yuNaFnEdT0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949102; c=relaxed/simple; bh=RfcLwio2xhj+JmVFhCDTCcCpVApUvZ5JC1yq4Kst0K4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=H7XspRKSi2qUpcihlfr9Ks+Kql6mZEHmt/NKdXKwJJqRrU5rFHyeQmxC5li+nLP5Xxdm17HSMVnI+PKnsa7KOWB9ClHyhFtVQa2eTBjm79BpttuEgFCYNolYF9RZysevqZYZHcLv+QwKqh0A9hlZdRjLpQV/54r5kQF6O89cEnY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=W4zznX8K; arc=fail smtp.client-ip=52.101.127.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="W4zznX8K" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bw/dZOIzgTFjznyzQff93rPADnhEGHfdsfdjYfwmOgVMB0v8KPRFVbE1PoMXUw4z7eUlgMPoKf84R4ygj8Qrof2++vxR4VpN9PHICo1p7YP4vlhBgdYntYcUOnqGZJAyDbbCqtXHJ6Wek7tqn716VtMzIA5R1nrKkCYHDPzaQvYaI4AyodTHFXn89QZlubXyxWCrSIy/w/zKR8/sKhnK7z10Fweg+i7DXwBNTUWeLL/C4OFWyMWHBinCeTbf6NqkzsQEt5ReewEx3zYBcuKK7xbYobIX25cuZOoDMtKtOlFGBzI170aDF0dcGh3ccIbsLrM5TAEXXPwk2Sz8wexW6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EljfDAkC2xOndzkvxHtJyc4iXYMghDoSHgInh4tw6fo=; b=rlNJYyZBEnxa9eCCtO2nR/uJJYKAskb5usbBRw+QEEqf4jhVx9HTiFO4WPI6uHpXmGPklYTpRwBq8BSJPuFMdUT10hG6EGsixlnlp3NW1EQ9GqRoitpP8bT3bxnZqGVck4GfFN2A1FlXUt7u5q0zeLLORZt1CMjItMhQ7ly8SRziSpaJC3TELjVokec0HW3xSn2mun9g9IIM4KH/uu6TVJWsimZKR8601PMQ6A7OlfJY2P1/A9uUB6rAoOoudz5XMjd3Cq2QVxZ0GqsaR7G2hGxuEkmhHsimVZ4G7zv7Ghfm3GdjB6yhFKtPEr2Hjdiq++BrmFoP96r6JaeejkAxog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EljfDAkC2xOndzkvxHtJyc4iXYMghDoSHgInh4tw6fo=; b=W4zznX8K2kEhHp4h1nUOi7CH9Wv+to77PvXsK8SBFl0mpFTGFkrNxaopmpGG5m7hlT7OuTwFdmfwCSLNNI2u2KFpW+q5FpIvRS8q9csTpQDCPWrwaEC8vGLpPzyEwepueg+i0Ht/WtKo07W0q3Sw+cO2nyE75ZW5VO7tJDMr4ffNfejQRtKzMy9hyGSpaYmCNtTobetLjmBu0GbJlzKrGzCd6gkKDJYKmopZdOo2WyT9889znrsEOUuRgoYMPzl4FTM3i5x8cEnRsmyKWl1Fgdf+ES9rqXoSVX6cCG0IAt+H1qi/lEhOt2srDO7Coxt9PKaIo60b/7CcmyUB9u6I0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TYNPR06MB9248.apcprd06.prod.outlook.com (2603:1096:405:3d5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 13:24:58 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:24:58 +0000 From: Pan Chuang To: Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org (open list:AMD SENSOR FUSION HUB DRIVER), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 1/4] HID: amd_sfh: Remove redundant dev_err() Date: Mon, 13 Jul 2026 21:24:30 +0800 Message-Id: <20260713132439.380121-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713132439.380121-1-panchuang@vivo.com> References: <20260713132439.380121-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0055.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TYNPR06MB9248:EE_ X-MS-Office365-Filtering-Correlation-Id: c75d39a0-1afb-49f3-f3f1-08dee0e2228e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|23010399003|1800799024|38350700014|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Ej7sVkMTsbUxVa8RyApPQ8S9jL674nwgTHHLu5JiiBn1LgwPR7F6cFmTrP/KwIEHCaO0HE6VaXAO5vsdrxeDokwPI1ywQZQ8593kLqMw8+xrydNkqwMn7foo/Us5+pFlDe+YzE9xPkZ/OlgCQdyrpYD1aCCK5kPirDCbKV9/t2cbsQO5Kkp32er/3G5ZzbgHGdclwgn0BfH2BVtYfNJ4y+X70cYst1+/cpmnzfvyyNVrpHn4Q5+FByqcFkqJ2UXLFhYEU0A1deKN60x9WYDk33w0skinrZcMuxfZS0VeuMkGypoFeSDgAxk+GFAvfkoSoaEP9FWPeoK7iQlLB6NcdjAnMSDP564OqNJjcHXtDkrHaDdfAxTn2zpkYfFzPgTTQAQzUSzZltDBNX81QFMDlnTopH8qKqtkImjbgvtc020W6b7lhtGejLxO5UqlosmJrLs5aptow3zwp6g/BiDcAENzZqjRd+TfT51GVMmHklLJeKMsGCi3F2rtVKD/qSBu1qaDV30i3/SAoc9LEnWo9C89yMOtKP+MTkuYD4P/vIdT9veoM8/8YL5GLxrA7OnBj9NUN4O1fNquqfMDvCGeOBlfx3iLKBjPNpCsR5WQYd12LTFz73DOrA54wvf8i7kagGgUW2EMVTwQ3nb7y+uINhTlk/KHKs/3nzdT1BxVz6FEYy6L0VHW/w4JF4EUYTIxkQS01z/ZMZhZMz1SmeCfdumVHeV7vFhSELCOlbbhkHg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(23010399003)(1800799024)(38350700014)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uDE+VJSltUy2tcZ15FmQvtA+UBN7Ou2K/zZOg4Qi9ppE18AO4w2HfjdLlK6W?= =?us-ascii?Q?pkCrVp0TtQvbcd4FuzQ53MWEoYyHZi/Pi3r4QHpgqK8MNSrnnTffgJ3msKpu?= =?us-ascii?Q?cgH0RVzrLPqWJNQOQuosmrFJ0rfUVAYxUdoTrSot/r7kIjsW1BVrD53fXkfR?= =?us-ascii?Q?+As9dxcY+OPVoHEyeq3x4H1KZvVgha3GOwGyhzkXrSetWx0NnuHHmJSpL4M0?= =?us-ascii?Q?RbRcTNtMZ9LSajGmcX40/jEGlw7gR0JGvi+YqlQ0QyXvM+1QI3IiKaE9q+ER?= =?us-ascii?Q?a/qlqtgF8woFRZKnrsYXWKZi0JnjXPiGQIET5Arv9BaZGfdkL36wqvZZsb7u?= =?us-ascii?Q?/wGH+X2Ny/fFZusZPvz9qZn/Fia3ZbnQvKMOUDALQZHRh8EcK36RWnK/Mz4g?= =?us-ascii?Q?j2cm4jF0jrxEpKnPtNnT3Lnzk4RwxmJ9yGz2k28ZP3aj6eXZy3xEOWFnw1TK?= =?us-ascii?Q?E9Gig9efDkqV8Uso15+Sus0XrqV7+xWgtSrebhcrhXCbqgtGQPg7X2ehAHgD?= =?us-ascii?Q?RpJ7LEaiTUrrQIOPBa4z1JpBYsXJqLVU/4PVw97/qVr08GVH9Dsk/GO0z89C?= =?us-ascii?Q?lMxrHRPGY6Nyy2ICuqXChCDegfHXkLnzwZjrPl3d5c4NFOnGfPt4KtfWDQC0?= =?us-ascii?Q?hwMPHQUEsoVyG8/+tYWz3aqBur6fenTpfsBrwaKI/GjKw8572DdQItiRI428?= =?us-ascii?Q?o51D/h08rK1rFgXX2PDqr14RqywL8O4+rTO1avwZ9lbnfO5XQuiacIbkSY11?= =?us-ascii?Q?w3z+7bmJysP6FruYVHKXuzDIJ/uqowaqWJdWrvMQU4XwqBvIATBuhPyVImpM?= =?us-ascii?Q?UHB9zXL+qVT8pIa9YvZJFL4MsElWldLnQ+51JodXlNufkUzmCBP85Xj+ZX/S?= =?us-ascii?Q?d2h863DDJArMqgW17vExt5J0o9oC8+3nE1SRUCZHi1MifjRsg07n78udtRO0?= =?us-ascii?Q?q24KZsjvp2UeITPkplcy03QozT+IyjiyoH8MrSaiwUxQ0VXBX0dKlj/ztVhH?= =?us-ascii?Q?0WIO9ygJGm5vMu9pOtXFRgxZ8HXNplxJZr+aA7o78DVQomHyCbGf8W/othLv?= =?us-ascii?Q?5OCQN5G05iB2LMq8+11Is1pNtt+AJRSPhJwdJJsy/kC+NvEqeoxhAylRwMja?= =?us-ascii?Q?z6UE93Ha6Ypd3B7QoIrqbUJVzjQi0PwhH6YazEsV5a/hxcWWjKpVERI6LkV/?= =?us-ascii?Q?3oUy2i9+bjmf9Ay9lPcIC68423j8aMUDhIJlpS4zY0fXBqkJHSWOvL3sgjwX?= =?us-ascii?Q?9WxObA2cJM/r1SUnAFPadfVP+kGULZENlNp5QNXlsszOCkyQ7z+mJUjFiSqK?= =?us-ascii?Q?EKToySV/+r+T1BvAahfeCFirnUpQc9yL6SlvOd8BKvJ+9RUm+S8mbv83vLM+?= =?us-ascii?Q?lwqCvo859xg+KFrgKz9UGJcjYgEQoPYfOUCsxdc53v/7vwjRGLLI8l1WHQkq?= =?us-ascii?Q?Za72AR1/U6hJZaQslPR9G3xQatc7W6qS9JIVtVvlhBiDimdARHK+GFGs818X?= =?us-ascii?Q?SvaSIbqeogFEUHr7u1FVd4s8DyRgladw4J2SQ2h+PvP5oy0LwJGjMEk3e/Wk?= =?us-ascii?Q?dQYiwAqZTSLCE+QLO7RFj2tKXH9pGIk7ZibPtePRFuAqX0cH5Ogj6bL401H6?= =?us-ascii?Q?oxEcG62H74TNW2bGf0ikLmJ+DIl5AYI9tyIpwZgCZmNb15duzxcr3yp96y0K?= =?us-ascii?Q?p0ikBQXlHhs1Kl0Q4rXREq2WcNuv9HDNHbQMZeL6E6KbpD2zGIpG3AICQ4cD?= =?us-ascii?Q?Boud3a7SkQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c75d39a0-1afb-49f3-f3f1-08dee0e2228e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:24:58.1907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9b1HkAX764souatuSuuVp/rFju0gYND+sk7Ap0nVRNetqVhzGmvCHmaeIbEQeL0YLtv2oxLgV6sgXOGS5V1l6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYNPR06MB9248 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-h= id/amd_sfh_pcie.c index 4b81cebdc335..a2acd3ca20e2 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -128,11 +128,8 @@ int amd_sfh_irq_init_v2(struct amd_mp2_dev *privdata) =20 rc =3D devm_request_irq(&privdata->pdev->dev, privdata->pdev->irq, amd_sfh_irq_handler, 0, DRIVER_NAME, privdata); - if (rc) { - dev_err(&privdata->pdev->dev, "failed to request irq %d err=3D%d\n", - privdata->pdev->irq, rc); + if (rc) return rc; - } =20 return 0; } --=20 2.34.1 From nobody Sat Jul 25 21:23:04 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013015.outbound.protection.outlook.com [52.101.127.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC6E42B310; Mon, 13 Jul 2026 13:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949103; cv=fail; b=TshulWux5ivqk3dr6bpodJMiGRCFvFmSfm6W7srdKd0Gj0NT2xmIWO9+tmuXmepjQ2ZIBmRJ5Muc6T/KEkOREC9JqLIh6pfOFEa+JSfqpKQuBIfUAt9HuIFg2yTVS6o4sNGsUc6WjbwTCBE4Hsw90sHk6ujTuD/5MpgD17z4x40= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949103; c=relaxed/simple; bh=rIdSxrmPhyt64WfWTi1bnO/7CwhCQBD2XFj2nPwLVy8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=r90PCqNuGlNaQE/mn1XJlJk6dNdCAEefEVNXlt+0mwf4L+f9zcuB6RuZHKV0xNWqyQ50EWvTDQGphMQ9k/pJPUuUy4cJikAkHS7djz2tao62AGyX4OHlDt/BOxf7ZoAymmCJ11MX8SpNL53FA99zKJH0Eb+/eWqGM4OdA6cinDQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=aIa3FFn6; arc=fail smtp.client-ip=52.101.127.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="aIa3FFn6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X/pxdHYR2KlWWfTzIs9fetXlIC7LH7kja9B6W/Rx/L2ws/MUEAECSTfQZi8ApJ0/kGDJ4l1Fr10tfO5Ltd3o347bJ1xGVJhNTG+q7AE2nBlGL05yOQmgBEwcC1b9L7uEJAL1o48TUpL9WLLyjFDtTzUwFcyUrG1a0gYvQGZ2fSvs2uf2OTj5E44U2iWYC8PQRoYKAK/gxEK72x1a+RmeaUFXAJ0tyL5LPycFo3SFdM+2uTbWUXdp3YCInT/YRHFTwXaq5x5EI0XMipi2R48uUo8teQi+HYsg0grOREZbIVI8OpXZ/mxe8BuTnDG8XkIy8hBpQpDgUXyemABBoRP64g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aOIz0Y84zgTrTYEevf2IWr3s7kOaVhK/8JS8Wy6vp44=; b=oeHCrkqtvPDJN4dYTs1mXHBWSs1J0Bg7fAobgch5wGb8rRb299IWb7NU3RuHy3rNhHgwnRJDWZl5qrZ3ZEHS2GCZ4auVOrwcmjDz2L/yXC5g2VeiAJia0eEJ7qqKNekJN7Vb48vSGZCnP+f/zBOtfppT2EQgQWjbplFpPqiehTcHVj3kFe14Uvs1O5andd/uzNd2tHcELiMYyWy12M0VpuUsYG7JoSn/NgDAG6eUSQ43+bipEP36ngucuFcsVSroM7bA+AQxxgjbL2K8P317mEzkCMhJ0BOXsHeFCJEDPT44+oMfnhMSUB5TLqNDlTwHelKth/WvK2orvhnbC8xaGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOIz0Y84zgTrTYEevf2IWr3s7kOaVhK/8JS8Wy6vp44=; b=aIa3FFn6xLJUzpBvEOxaDFp/pLRVcoWDsGUfUQTQRWFOrDfeatf9CCn+MabkILcVMvQv9pi8//ZjMxIUSOjuXLTE+KVWUDfkCjjvHK7ffeoFaMowFJUg8TK4G3dVKsdPkmFL9mk2xdgQm0H9vmnJx28YFyciazxcflYrBUc9imWncV3hVKwYZ2K0MLVyyPK/2kqiRfIubHVnvSISUuQEKzVhQeg8LVtYanJlhGHYmDw272nlo3f2yy636oa2lBVdJZiMG7gu1R1cVZaAJ6uKFUU+pRu0biHPR0NS5CzJ76KVTnNwWxvU5jJrdUKmglZ+A5XKA0ejQk9yuU19Oxie3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TYNPR06MB9248.apcprd06.prod.outlook.com (2603:1096:405:3d5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 13:24:59 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:24:59 +0000 From: Pan Chuang To: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org (open list:HID CORE LAYER), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 2/4] HID: hid-goodix: Remove redundant dev_err() Date: Mon, 13 Jul 2026 21:24:31 +0800 Message-Id: <20260713132439.380121-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713132439.380121-1-panchuang@vivo.com> References: <20260713132439.380121-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0055.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TYNPR06MB9248:EE_ X-MS-Office365-Filtering-Correlation-Id: 760fb06e-d693-43ff-869a-08dee0e2235a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|23010399003|1800799024|38350700014|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ygNL+iJ3nSsTqEcaGq/Ib9MjCj8ihk02o+WH3f0KlNnNDCeA4vHvQr1EBtvjeBSGw7y4jV3kogdWGK+3+JmpTCPG17FbktDU3bL6o6Ka/G2swRhUnVYjwW7yk3cFAfNfbs/1JCXPjjScC3DmAIvqidrP7edLCcmKVG1L6owCFhb3HiOyRhoq0ZJxQ0ej2dGBfUM5VJZhBv0oRb183m+uuvfjTLkMWacYJmdoo1OwUPlU06JnmYSE3wAt507wSvs35r3w8gI0kF4yNCZTVnO2rwOiOVdb9YUlErUZjpXFZKU9R2/ZPvTycgnwctQBGUeqmuzv/7vmxsm/AOuTch7u15ZnZpZQSre7mudXv67QrOh21GdqzbpeLWVQf8zz1ri0Smlhs4mXFtbsx4nDf3UfNvUEoJoqgdm8QiSaAtjrL73GDftXwLjAOydVNTmTBnPJV46uADObzSvDCWlBdpjZLtBOic9eS+r3Q+XqpXW5dG69SIbpriwWNlPzJHWVe1/TPDOrlfgdNEyHql1F+cA2gJMO7vkVnr7OY+PbJRNHOOtOXmyQxp/uwzESnxVbSPKjMqFJeTUmR3whpBEPPBOlQ3OjF1CrZVbZaH3v6Esbv+wQbNProv6PggnE75+VNROHgSrfrpylI+0nbSUqPeOlHeAPzhjB6U1UmH/hWJlZWANANheNydlXD8OrswQwwZQyrFTxclBme7BqDqGxDZ1I4E8Nb4HS0WZ0xEJWJBG26t4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(23010399003)(1800799024)(38350700014)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IqNnvY4wCVxZHHgUKrx+GeCA/XR+fgQzobNp0rB/klu8ghWs/cdS1QpSNv7D?= =?us-ascii?Q?yMkQzclxRirXjwQcQxNdQ0cTvQAO9n7rDToiXnFMUlKiBdwMUh/GwvddSUHl?= =?us-ascii?Q?GJGooJkCcHTrnFocXNsgqP2cOBT+plu0OwbM3gtLozagvXIYOfYAMYVxUOzX?= =?us-ascii?Q?qlRf2XzisI002vh4bdbvvwxuuTyI2KdXsYPOk6h1jZuGkonri7U0cehBCtKy?= =?us-ascii?Q?fjOUzU0/1XUpSoOAYM/hT9PDiNq72qFc61340B6H4tG9c4CG3GLQI3T4Eozx?= =?us-ascii?Q?1VLS1xrxJp1UmwnCciUO5nXL08tQC7o6n8gRTPRm96t8IN0UtnVtS8zL6UnG?= =?us-ascii?Q?DQrbOvR4/cB2JBlaY+5mz0nV05dyf3NFjHSzowc73RVlHp9ErtGvT49TLPn5?= =?us-ascii?Q?auCK0UcwKLy3FDqYUWj6mlulMKQNpAUK0Q11EtcU65AgqNva9Xd1WeXV02Uq?= =?us-ascii?Q?h0fte5uPRAdM8YMvySFiVxLBh+oHUE5aOwEVOsIDFPpRrGSvXSPd9gHdQ0s6?= =?us-ascii?Q?RQzjBohHNMDp1Up7Lh1kYU2tE71zoyDBxLB6As96BRBTAHX2zoumgmSg+MLd?= =?us-ascii?Q?7LsFNNp4WENAXVA5CskirkjQ3iNlzUAf7/UttEstkRdrkerndY37672eQIPt?= =?us-ascii?Q?Plml9CgCKrFbUPZL1YBxlt4kRSR7V5WcRDotEFEh99iP28yHMd6cdhZee2Rl?= =?us-ascii?Q?4PAmQXtshIR3WFoi/hCKATpasWt5burm5e9d4JWWoiZ2RRd4+c7P5ruwKWqn?= =?us-ascii?Q?c4Nco7VeXLoQsMCQSOsw8sVUlw4obeF6JTiCCQXByCLTDDR3L1Ma8lCVAtzF?= =?us-ascii?Q?ueMMatfOv3TjFUAVyOhkQHhppIdcDEHVv0XVpuXHeRMZF1md0lzZv2w8n+fn?= =?us-ascii?Q?JDECt91DRvr0aY7BgDTv7H/N3Skmm/9uOnN5SLi+boEWVxuLWECKU6z/Gvhi?= =?us-ascii?Q?NQNLqVHz8c4zNHex3o6FWrUoO6f71Dqus9+JmQ7V9q84TaFvles9lNS4SWLF?= =?us-ascii?Q?n/fQvMWDSqu/lHc82fa3hYw0rkOSGPsZhu2goMEvPZzDmam/Op1a6AzV3FWo?= =?us-ascii?Q?HgZth01d8FOIVkNgDtqO1ZNarUrd82yisTp5ch9HYz7xVk3Sn6xpes/hzMdR?= =?us-ascii?Q?68tc9kU+vwJy8GyiMLQFAZnUke7nNR1lZWGqnq8UIyxvs39eBnOEPPactOgM?= =?us-ascii?Q?AtKwf/YfHSzogm+5qD0kmfPN+JG7AC2Pkg6/RL16H8ZimfLHd/ZGm3ALacjm?= =?us-ascii?Q?xn7jeR/JUKS83znr9BojadI2CFBMtjGMnjsQkM63kRjITluoM9z6GWw37+FU?= =?us-ascii?Q?vgDAAvYRFVwOwip4gxu0Owcwo/8wGDxW71yahoZ4TkXgEBTgRQUFLMegi43T?= =?us-ascii?Q?SH+wKWodN7VuKNiuX+cOmD1Uim4Tcan2PHg97GxOtP5B9RfS8CfM/qrVR+85?= =?us-ascii?Q?Y3nryfukBLsBQU0vtSckJE63599alc0t1Bu2IEO8h+X+x0JkTQXAE3VfgWB8?= =?us-ascii?Q?mChrB/jp0gz4TTbwinZzFiMUOGkqGcqnL0SxIfJNM7ijglwmhbyHWPBlG9eL?= =?us-ascii?Q?hkCQA3bH7wtSHRfycY1WZVJN+BoJAkzCWpcXHU9nGCnx76MKXle1ysx8mhi0?= =?us-ascii?Q?l6WyROzaGysXTo+mW3iOLukyVCgOfzd5hWhvKHabLlaamI2K2wW2lQH1OKXR?= =?us-ascii?Q?FBUHPY+NrMrvpXn213ZEBPulOOCEX0O89yY2btOIjx0CpOg9vlolVR5gtcNO?= =?us-ascii?Q?hQqbsPP14A=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 760fb06e-d693-43ff-869a-08dee0e2235a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:24:59.5574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rpA+fljm86bEA2Ixji9ba5pQ6cBqgkRsMMiJ5m3X91dvttWaKoTldPN1vp/puTJvKjbNIJaXG+NoKVan3CWtNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYNPR06MB9248 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hid/hid-goodix-spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hid/hid-goodix-spi.c b/drivers/hid/hid-goodix-spi.c index 288cb827e9d6..03d549efbdce 100644 --- a/drivers/hid/hid-goodix-spi.c +++ b/drivers/hid/hid-goodix-spi.c @@ -722,11 +722,8 @@ static int goodix_spi_probe(struct spi_device *spi) error =3D devm_request_threaded_irq(&ts->spi->dev, ts->spi->irq, NULL, goodix_hid_irq, IRQF_ONESHOT, "goodix_spi_hid", ts); - if (error) { - dev_err(ts->dev, "could not register interrupt, irq =3D %d, %d", - ts->spi->irq, error); + if (error) goto err_destroy_hid; - } =20 return 0; =20 --=20 2.34.1 From nobody Sat Jul 25 21:23:04 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013040.outbound.protection.outlook.com [52.101.127.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D800842EED6; Mon, 13 Jul 2026 13:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949107; cv=fail; b=DriE4ch9eVRjUAzvNS9BBjWv8uCinD5TdGsLR3xZR44yurlyWcr8/hO91aV9TkFGh3TRbVbslhROUFhc1lEFF5GumeH6nT7QgxKSaziX31Gxed4iBelhTG1Q3Hiei6oVewC7eem9suBC3yESq3buPHahIklPWGnnLH6zka/NTEY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949107; c=relaxed/simple; bh=1YFH3hrlqjZW7SN6Daensn/hoM8pNR0Ipd6RzInhQIs=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=YEtYLqT7gls3WbATtwHwrBqRXCX05Q3kp/qIQMnnlUJQwmcIaICRswzTZDH6sthaZz6hQ+5HHahgnKbbwEaDUCfDWQdNtm7z34frrBanBQQB+DkUqIlrrVRTBEGAp/ewr6jpID5zXGhPL3H1Zf9j2KU88ia/B7IIawIaFVgfJZs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=SabtDlNj; arc=fail smtp.client-ip=52.101.127.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="SabtDlNj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QUA91xzZQi88FM+ceaU7swDEa2Tyd2TV3owUJ6UmxUpixF2kdnu9bdP5TK5sujpHYowu+yAQULEKk9xSToKcsBWf54PtrpTGBm+PktpnwDm8jWTydGDY94DQYpKsG1jUfIHs7gCKOG3hcDSvZljrR+XSOmTPtJoXBUj5NdTebq/TIowpxIY8JpGnruZTcP69k3vrT8RQ2/plaDuX0YmP8Njhyz4ZpNH8SW4RmxVmIlT3fgbCBCKTJj8I+sDaYJ+B/L5SAxpkcp9QjFJlpKLAcmFJRuM+uNxJJpT2YAAUH/z3GBMufLYgOhUCUG7LvGkVBGLW3VRJSzG+1y1E9486ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ZyPXBqHNfWoRtD+nWC7vr4+jKHltdXaANF2RRwjf7k=; b=jqArX8epeWZCZXkxYMYtPKyir+n9LSL+ACI/T3aZow3kA+aqWEIuez58AdSK0n7ysYUbBMtSQ8ccD1/j1W3BB5NKIukKZSikTWAYAdzgKZxiCWPGQ2YJI7yQ1Ci5foDT92umX1ChQ6BfYWcpmMFZQSq3Z35ELHy0esq+WYn6LkuQjTO+sP3CZ4mwXzl1lfqlZxBzPliZ+Ki/CmEBgKE65ONr+Xbp9m7APA2QNrn4rtH1DAsabbj+9dimVJnOCKij9RP6cDAsuFe9tUNeSvf9Oc+nVJoj3c7haU2A2s8e7q+2O54ZvOan8kn7hg7iSn8aUOJ5/7mdi76njGvbnkL3mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ZyPXBqHNfWoRtD+nWC7vr4+jKHltdXaANF2RRwjf7k=; b=SabtDlNjkzRuTlbrRjGLbgk1/ZZDvLsAQ6ggLh5Px6FsMd3lXk9ORclJKHy6oeNj3m0jd/UKnLyAkfg70tmKrgDdbDTxtF6w4JZ0Ez9qUvPXdPYitBbI8YiAUASETthBKs5sIm6gc3O/ygrcRxH/lsCtcj+ZfeojQ1Nm1VkMbU9g0/ZNploKV5BVgGDYOXpNIwBLkQy5Ttn+o3ijW65KfcjrIxFZiaO62Um5umtag0YYqz8624DR3ZDhgkPPsp29GDSZbuoqsR+pB/Hd82P6sL+hr1N9665I+mI9OHxifRwx96O5xJtpZP1RAYMxs/eB5aJLKgW03kVlcp7LgyMKAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TYNPR06MB9248.apcprd06.prod.outlook.com (2603:1096:405:3d5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 13:25:03 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:25:03 +0000 From: Pan Chuang To: Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Zhang Lixu , Andy Shevchenko , Vineeth Pillai , Pan Chuang , linux-input@vger.kernel.org (open list:INTEL INTEGRATED SENSOR HUB DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/4] HID: intel-ish-hid: ipc: Remove redundant dev_err() Date: Mon, 13 Jul 2026 21:24:32 +0800 Message-Id: <20260713132439.380121-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713132439.380121-1-panchuang@vivo.com> References: <20260713132439.380121-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0055.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TYNPR06MB9248:EE_ X-MS-Office365-Filtering-Correlation-Id: 2509ccbc-3064-448c-d5ca-08dee0e225d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|23010399003|1800799024|38350700014|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: u/emuHpQPaz/fX36xLjHdavPupMzvy6e6B64vuLSh5kkiZhHYalFAkp1OyMmKMeru7LSlUhPuPCdNm7CGXHsbLrVmYZa58/EXOw0cLck8GMKIkDM1IRkSjSCgaWWFd2vS5GcKIu3LBJP7c92MjSa7rm23pg9nA0pohR0nHI5kVao4wujGXuEsPL4slDxeeKdMfcuU7cJgdFWKZwYZDwMJ6WieeCuixgajBlZrg4HBbuslsiwBSwI/Kqx16aJ1S901M/Yy9yrw1XrZEiQLEKLx1ISOuO54zZaBFCYDHp5nKFohV+8rOE6AntBcDyB6qEQy2pVVoFDCv3jQdzdCBHlbkqgsVaX23uqO7vpUFsTYn7WFnBvQQk7ixTn0esAqxVvUxjyhXW6HEV9zmKUHUU5j+Uk6VHwJKw0W1CA4IkuQCXx5zmay0hgGotMSXpyi5PR87XPt+xl8vThBY+nENXh9Ou27Omt/DBL07KsLqSLwv1IslAUpReBikhMjqdNyJ3i5hK/LZqebhD5ofOjBDHKhX+FzN5boRHMOHegF5YCwQ5vR6n3HUbRUiyfO3o7h3Q9lq3SKPn6UAOtEiH8rn+Kyx/EZH+6mFeOh6r5tEJajFKVTi4UF9OKsqNLeWX4iG/50IYjQAUw79BI3/v/pyt0TtSTDZV/4LCuUzk45jTIW62DkNewIwlwnWgQyqTAa3EK10q5NesQ6sCQTF8PpKbqjt6izsCisBigoGjgDiuXhd8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(23010399003)(1800799024)(38350700014)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aOR9b1It6TRanCR0abIPOrtJlf4TvBbU1doRF7TCIuAGzxueAsDxHrM/WiXr?= =?us-ascii?Q?s1TlCXUJGNOZrsL8A+9j8AYwrUpW5Wh+AhiHpEWbnhViQcM4/eSaanfbGcaG?= =?us-ascii?Q?UtMMCPT4w//4S54ZdJu03z/W8o8owk81UzZNk9SSygeOZUnDSS4p9RXkjXFg?= =?us-ascii?Q?XM+sTmgl7Ry/vS68hTboUWMuVrdYZuoWuNMYTU1N56V9emDFPCO+XmYDqMWf?= =?us-ascii?Q?ax5Suz6LZlhBU3mw7jTL2nf2GSDae6BehZ91UtM2JO7DZ/e9xvPrRVJ440pH?= =?us-ascii?Q?BYh4xcpgiRI2UUUP8QtYhZTHiN9sr4Qh0CInpz6fOektj/uchW0Yj6trOpgR?= =?us-ascii?Q?0hwW9/1vgPtD+P333x95730yx7arD0OiXpv3WrI7rd8C52wzjrS9k324g3uP?= =?us-ascii?Q?HBwyR5324nHOecn/IuPIx91EwovJ3ZCAv86Ys8TIbw6anwge5Mb5ZKHK4Zyx?= =?us-ascii?Q?JYTouFNRhgdBKeA26wEdKOONjawcxOYhq5iG0lRlWJbooJY8iAQWbJn/qeX2?= =?us-ascii?Q?Y7UhJbO+yTbpJ/9e9QzOKuilFhSFX+fg2W0GidC18BEJJuJC4ZRURlRKxAFf?= =?us-ascii?Q?9wVlC5ILlYq4P5LVqmF3srtTYSbOx9MgFtOyTRJ7FaNR4ABmSRx0qMXVPgAc?= =?us-ascii?Q?SeDJ3GEP9+nL9kXQ+cKJXeCBpfADMFWVT2vxTvVjuDcyLgL40H90aXE7FH8K?= =?us-ascii?Q?oA+V3fvuz7e+sRkKCPxRpZQ+bWkc7uGFdUtuEyRuPfRekBCj7W4j4phJ9rrd?= =?us-ascii?Q?vIH6DU+iPUhGiMZNCio3KA9f/lowo54NDTyu0saQnF5ZoXoajMtbaHDr8LYW?= =?us-ascii?Q?+dPHMW32rsG/K1L6wcWdF5NaNP/+IS6HK3oNlilCWg5kwApJZxVf0pyTebtC?= =?us-ascii?Q?DsZ52Li2ha1bOTAjdb5KbfiF5De7XTQwaTI66Xv8VKNyOUytlj+W2zt7uOho?= =?us-ascii?Q?Ik5/xA3HxO3RuWkJ4TmkiegamPvb0oJ+25vVifO0/vFX8ziRwMiGTUW6gIK+?= =?us-ascii?Q?RKah4ej4wF4QbXVNiyPi1+/UYFmEiHbKD8YH7Y393YIE9O+wnNWUyaXEzJRi?= =?us-ascii?Q?yaJhi/KOnW2h3djzyT3NFz0UBAo2LdNBU3SVAEHEHWEXc9AOUO1McdGx4nLa?= =?us-ascii?Q?PTH0VcfLiDkdWtRNJvBVQ3nUwQiwZDU3+yJ95l+4eHvkKnEOgsJPPM6S4x2E?= =?us-ascii?Q?cYdwAh7902/ZIpsNQ93hsT9jYjFZNp1HMuWylLVzrpybySXQ/9+sd6tbzkDk?= =?us-ascii?Q?xug2/V2O73H/aQFnrmLUYUZTXUgGZAfpHAQxNVmht0oRDw4klTpE/qXTi0mY?= =?us-ascii?Q?nW3AdzkchJWdUKDqWaDQjUEwy2LGlKrNr5JDyCYLZDA9abvbDiZaperNDWsP?= =?us-ascii?Q?cq4Ai2nVk8nUWbXqdSvE+vcZysY65EIU3YXrvZZMbLJmW3uDYTl+L7RcJUjx?= =?us-ascii?Q?VqnVu0JQfljWBl7+NR0oucei5R23nlsLnovjare0v2lBmtruKevDXqY4WX2S?= =?us-ascii?Q?PRyO8Z59PBjc7hWDvV1R73+dssdCXnZdgpu3x82/7p1/90s5PMmO6gzBGBOW?= =?us-ascii?Q?0c8bsMLBqJ8oJ9qRn9ZoaKwkZAateYbT4KNoICocgHnZZ7eoR3wKgsrtMTbg?= =?us-ascii?Q?9VcJaAERdjabp1meArbpAbHDAwBnlDJLLdQdiBz7oC/WgXHXCnly6obGwEn7?= =?us-ascii?Q?2Lp7D6/1n+v9/lF3igtnbElKVSSpTG10LodBmTsGG9Z2sLmfRe6jzOi9XlrF?= =?us-ascii?Q?ePStDgV8lw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2509ccbc-3064-448c-d5ca-08dee0e225d7 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:25:03.7310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9RXuimpYsgEUkdj5aPdxWAzMPsT5xy5OF9GHGQCsv2GXzsLAk0Ecgv3KHfkjkdsfFHBx7OOI7YnEWHge9/6vQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYNPR06MB9248 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Acked-by: Srinivas Pandruvada Reviewed-by: Andy Shevchenko --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-is= h-hid/ipc/pci-ish.c index 8d36ae96a3ee..e7196e429c8b 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -232,10 +232,8 @@ static int ish_probe(struct pci_dev *pdev, const struc= t pci_device_id *ent) =20 ret =3D devm_request_irq(dev, pdev->irq, ish_irq_handler, irq_flag, KBUILD_MODNAME, ishtp); - if (ret) { - dev_err(dev, "ISH: request IRQ %d failed\n", pdev->irq); + if (ret) return ret; - } =20 dev_set_drvdata(ishtp->devc, ishtp); =20 --=20 2.34.1 From nobody Sat Jul 25 21:23:04 2026 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013055.outbound.protection.outlook.com [40.107.44.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA07F428475; Mon, 13 Jul 2026 13:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949114; cv=fail; b=tOVRlhpqSbIi1EW4L5hI8air3C9SdUlTVLHQfafVQ85UJKa64WFI0y/fP1RJkHIlgQ/fGPk1lZZkJa91cHLd++llya410T9kbWOmi0y4kXW77J6VTd25qSAFgEB0fiAOcMKN5b+z0ABGTL7J7ylDRmASUxg6L2mXTDxpnLb2mr4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783949114; c=relaxed/simple; bh=pGpq67zANS6IoDeNWczn3vPFy983TEhjbiKeM/WBxFw=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=E4VdcpRWuoyV/XYY3j11gD3f14eK6zmnEDyudCifpGDRBlo0+4FTkSsKWw1GtfiVHExI4JZkb10FSUj/7fTv4+lgk+BPjHZriLDbEMeOE0ltlFoNIOgE57AUsVlbQN2kQjHkvX/vgXlTF0uBw3gb/FntQ1QX6TDscT6KjoQ5tC4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=kwgMXCVU; arc=fail smtp.client-ip=40.107.44.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="kwgMXCVU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dIfCl5o8ax+WDGjOHzWOMnBTuRovg+v2Mo8ss9d5Vr4/vJU8RaTMQ53nIAdzeLl71CJooXvOLKJjjFRnogfiinVbvCh9UcVUwA9TSzRaMhUpoo7ClrY+GTLNttOt2Sa9fA/svlV1phJgzidP+z2TgEZWw/73hlESE06gvvXrWTs30Ct54aTzhvb2aRLGDDUEkflncgVhE5u/Vut1Hr4BCYBuFwFXMDQqRfIrfG1mmbcEbeD36E3qWHhapPxm7kgpvLKxb1xyvQO6cqfvazvTXcQ8jp2zBIVE8F+nxvh+lOdIcFmiKlmO8YWuoUDNPYZDgMdDyoDqpWc89uexaZBv1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ffZkQFSQ0UmJ2QdL9Sq1IflMpsuDj/WyfnZeI//0sYQ=; b=zDqj4r+PBQeUHf5kuBtKWfqofbcwEST3/kHWZW3inZCSk/pxDU0lNcWNCmifgl3dg/kuz7BDSlYdzvRiInpkVyqo5RO8lJbtPdsbNH0hiREZd0syWUZDlNJhRnGhlrcSqey+dr3gsoy1BtNGM1O1uWIerHH7LY/0QuVb8tTi/wugXy87ngTfE3QVroxeHUXrJW13aQ+ildhzK9jIj48N4FecwHjBAV7Mr/QmzfwNyKS/Z36VN7+n7QdBTR4A02iOzOyesfDOHP2ffc9AaCMp6YAxqKjn+NMdOKgm5UfmiwcZncQGXAO4Z9OxTXuFpNAmJik2E1IWzcU3FW4eBj4Zmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffZkQFSQ0UmJ2QdL9Sq1IflMpsuDj/WyfnZeI//0sYQ=; b=kwgMXCVUv3O/xtGvs30M57mTamJdFPOZJmWR0L8bFD7QNyobKD6CZnacL5kS7czCfrDoTeiWImmnTPQpyOFYAlgde2Axc7s77ZNJUDM6o79uqvxeiTdd3SLiWXACIwzPuxIKNrOynrydAiZkcyXQhREc7nqXCRkRgZ8csO0Sbge4AFU6KW/h6OVGeNpeFdN7ZAx6CRV3K518eH0bYK7Gky9Dl5gpaCu6YnMM9qR/mdTMdNkW8CQ3MuSG5KTmzylY5mMI9bDeEiXA4VbEvJ6Fm/1jmU1hewTs6C/V/Jyg9tf9KV07/d85YzEWJ2p+iemB/hzfBIxUgUbSGhEgYIHqlA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by OSNPR06MB8956.apcprd06.prod.outlook.com (2603:1096:604:49b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.23; Mon, 13 Jul 2026 13:25:08 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:25:08 +0000 From: Pan Chuang To: Even Xu , Xinpeng Sun , Jiri Kosina , Benjamin Tissoires , Pan Chuang , Sakari Ailus , Abhishek Tamboli , "Danny D." , linux-input@vger.kernel.org (open list:HID CORE LAYER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/4] HID: Intel-thc-hid: Intel-quickspi: Remove redundant dev_err() Date: Mon, 13 Jul 2026 21:24:33 +0800 Message-Id: <20260713132439.380121-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713132439.380121-1-panchuang@vivo.com> References: <20260713132439.380121-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0055.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|OSNPR06MB8956:EE_ X-MS-Office365-Filtering-Correlation-Id: 7537121c-b093-45c9-ce3e-08dee0e22862 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|921020|38350700014|18002099003|22082099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: aonnNAtdFF04h6ydf6Ss6hrhHx+mYSruGjS7iwNLT28YcvDkzj1u/ztX9QNMAYFPiFhVDph2LRAqMmYgY7HYGWsKaAzUQss9Rsz0a1uqYXS/7d5+/QDCsqkQKZ6F/jYwFmyQbk7hDhnrqYYxvLqtPdiHsanRuOWtG8NRhThSSp69gJFDpdGIn9e8phWAtlpVdPnf9xgLPAzHSQp/wrtWfBeKijGngFSgc8zQafr4kmRiki3ObekL55fRoaWXaL8pDPRen9lyjy0h2XM4mtx+l6ofgBtz+OdoHgaBPzIZR8dZlOUAZPM86p/cWsfzAR+cy9m9D9B+Ys27n9p9l6LUbWEQxsLVSay2P31mTynXvyWuO7i8yH4sCmk6jin2Unze5+teUT7v2XBvj4EliIjGJcBv0Xuz7AaSqVpDC30smSUyqYPSjp2Z2uLXSN0SHwgAEC3ZIFZdpjpuxX1FLnD2lXGxk9QHN1divcDYWJUCQcPpyQ+8+1ounhSh3gm7jr79yl6x2jmFMzerYNlvZpq2w2lP2fKH8w77P4CsUAPSKMJvgQXJpCCJXAne0egXgFcHqSBjCPNi226GUOH20Oc7pvERR4ktlMNTZkd32IvgZnx9ila7yQLPb4n/kWB04zz8j1BqK6SXmsDI5lbG7vh/NLWCfahSLFCxq5jAqSZUHcxbq3fuJqiViDE/ALK1GYW+YvvG6oZuTuJMxhchncBjGnPAiQXu7Jiq5HCcW+3NfDLkucM46O5GSNnwBODf3JnO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(921020)(38350700014)(18002099003)(22082099003)(56012099006)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sOkWzTZTYbAmpVKN5Zm4yufuJKysW6xOo97vOKrPf5hebUXWN8CrjgLp0MUN?= =?us-ascii?Q?+MxKSL2+v47PHCttRYueGA12JhliCyCHAUQj6xTdmZHNdrGIx8U6XnPm8uvc?= =?us-ascii?Q?/tNLim4JeJ3rlHg3H8Jc3khoFWnut+tRB+3yyklsf4vt0FP7d2bZyW00Xdbs?= =?us-ascii?Q?JoZwISu6594Y642PorYV4EwsMqvgUFtUeklwTJDre/Rm3CXtRjwJH5gAEd+s?= =?us-ascii?Q?/hAJRBbJLPcQq/f/b7vpijkwNR/FN+IRk8a5lztI4a8Z0eZzfPfTouUj2nIb?= =?us-ascii?Q?seKKPo1k/9Eykmi2svKb7yopKSA61OXVC1JzPasFun8quOJE5MY9BcNTS8NG?= =?us-ascii?Q?oT5jjvfrDlvyCv3xlgZVjno4ISVEZ7ak4Llde9BeZgxDrIsOUwGKR5S7nadF?= =?us-ascii?Q?K9TalFXtaG6JiVPESK/6VbPgecG28N7Xb19sJbFU+GcmS1og13A2P+pxjZQW?= =?us-ascii?Q?+0NkeOoAesYv8wGUsYZ2lcwX7TJIwL8TbNsgpGHLPsxJpBGH1oDC7jpd66/K?= =?us-ascii?Q?C5FPU+Od5JjTHlSZ/tP5LfRbGlRSyAZcpYKCYzi4WpmKwuFrXecmG8bMcGYm?= =?us-ascii?Q?JZRaKWBKetR0L+ZW8Sufy5qdIZiZLt1P5sBet0TaPXaGcwvqLFoAmbhG6qRJ?= =?us-ascii?Q?DkW6EP1DKfvhFYoHrBzb/ZnyKOPeaMVT0AKsnuwVj4LcMw4x7PzBFPSKajg+?= =?us-ascii?Q?RnwL0n8syycUerqfCBTKzSQj02cyCCRuO3zILBwYr2oIjMYJdytTelrWydnW?= =?us-ascii?Q?nWbsFs+PM9cMNWyqp1ptLzP7gywCXpkw5KzRcsdOfpHrl1wNNmk/uJehMtRC?= =?us-ascii?Q?cmseHO6MYy7vZO0NSxELBLKxpzmysbOmyqQnawaEzOlDlzF30/8a8svArUzC?= =?us-ascii?Q?Ib4M/0AHIniSLXkmwZzOLLOwsc6uIGXWG1SZA/S/S+71rgaweEcrEAZQqIaA?= =?us-ascii?Q?MVPRQJuuE8dzXjcyTWNTpEVPlAZCpyYuvseVikDZF2G9sgZLB/hlVdu+spfB?= =?us-ascii?Q?HtyB6xpoCjSI1iqR1sivzLslDdN9Gb2IyJhNT7L/nwzg+2a+974FFF4c93wp?= =?us-ascii?Q?O6pWz6j430Fk69Hq+8viQHvgzLXYg4BQ2/D2jIy3qHW4GU6TtNqm4DZDMSiu?= =?us-ascii?Q?PZs69iBGx+hBHmnY2wliRV8WTGrQWb3hFdk3Lcv5zRMiPDNYEBmqwYcNCadK?= =?us-ascii?Q?PeQNkAgxKM4IV2oKGrH9PXKh7Uq7u7GAxoTXbI1DGv1HCC4xTpMOR/c6uwWT?= =?us-ascii?Q?5rYy5Vdb/LycZuOFH2IGRhsQ/9Sp6hOWyoIM2jlaOspX9+erAxQun2Fqv2Df?= =?us-ascii?Q?A+zFILi2Ka0NE85i1mDi6/CQZYgmKWvsxSFiBuN1nSB33gCbEJX387T7ynyb?= =?us-ascii?Q?WAiBdnvuoV7Ja8n2ijb8GlU7hQ8YMbwgPmvcpkMSBrR2SCoFkhyqPM82dpfI?= =?us-ascii?Q?D93UWsjZ4UBGafJ9zqGkd7U3545VlBM/tHm/KoEmg0jgn2dYL3Il0F1kd1k2?= =?us-ascii?Q?IN7cTG1a82pNxKz6PJ8SLfMMo6TxphkKBpA09oRJD0LlYpTjXEGn5o4zneTN?= =?us-ascii?Q?nHVqmvIZAeMmdHAOsAF0UsaaSm5zLdrVr4VZ8uvXVo3UyYOaXnH/ITvUw2kw?= =?us-ascii?Q?d9KqARkAfzgwtN9q7jo9AqXQvHSwnxPH+deL0HkKXyz13mA4/1DU5ADFOjt6?= =?us-ascii?Q?q6b1zAtUfm5YBsHT4qzFCxEpHo81Ys2fg/+SAvBKszPejwjAs8yz1O4tnQWw?= =?us-ascii?Q?6RL6lkAhdA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7537121c-b093-45c9-ce3e-08dee0e22862 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:25:07.9972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5i0xaowO9TxCQgNrPAor5iL+4jt8jy1jbk2jP4OsuZxtR2ZNMNGLt2GOOSyi4EiStwWv8jZmJl+WQPxw/Xu93A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSNPR06MB8956 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/driv= ers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c index 4ae2e1718b30..504ef3c842ab 100644 --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c @@ -636,11 +636,8 @@ static int quickspi_probe(struct pci_dev *pdev, quickspi_irq_thread_handler, IRQF_ONESHOT, KBUILD_MODNAME, qsdev); - if (ret) { - dev_err(&pdev->dev, - "Failed to request threaded IRQ, irq =3D %d.\n", pdev->irq); + if (ret) goto dev_deinit; - } =20 ret =3D reset_tic(qsdev); if (ret) { --=20 2.34.1