From nobody Sat Jul 25 21:21:08 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE123FC5AB for ; Mon, 13 Jul 2026 12:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944260; cv=none; b=i/assnFbOShiUtGm9wvc9eBR32w+k3ELeJjtRzvASMXLmam8gwInG8xIIe5/X17iaYZx+Axy1FGTBCoQ95EuCypMcWxMN7Nzlgr2uTkAj+zTL64KF+wi4a4jhuc3z4uJXNw/TBwFuuFb1RIu0oD/02R3RJd4rA/yRYksPx73EJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944260; c=relaxed/simple; bh=vV1VhIAuONEmnbG4Bp5VF4zsUQEK2yLhV+oC4X2dBtY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Wt8rVK1cfATFxP+3PHwNynKLUWRyCO0uSAS9hE9Alkj+pyTbIbvZ273ClgoFC1a3w2W09lLe/G+Azdjxk7LB8lVH1rD1jfYc6SOdfu19l1nr58o15Qq3dEiM7HJMQ94kMz1QO2zwcCNe8G1PKLyfa04pK8hzW2CD2JKnaoONYaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VWgPC3zO; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VWgPC3zO" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-381ed661712so3558053a91.2 for ; Mon, 13 Jul 2026 05:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783944259; x=1784549059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xbBLBFXxW/JBreBI2+xziQALRD5/GvPJ/LzRgunvQI0=; b=VWgPC3zOx4E3aE7XEowf+iWjq6l3HEyXwciNqSLMRUOJh0/cxBCPxspWeeMRb3ean6 yQJk8YzHrs+FCDC2KAHsoSXwscJFNUmP7xsclCG1/+KVFBlaAX68HgaNINeUUBQa/Y3p 5Zrbery222htoJ5Kb6HlhKW3rR0XBj1IW60W/nueUzBpwd7Q7qxQn9TqQn43NkqKHuOl 0YgufI7CmWSw4vHF7pHlDp4AojN65MUaLZMaKPGMbmNzj7pG3TsRm6Ef8qvkKEztVtaf 5STvKhmjYHU8Bpgllrxd0TnbeFkB6j2XBiWGDcgMc50t5p4j8IhHvVnci1IZbcWrM+dt zWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944259; x=1784549059; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xbBLBFXxW/JBreBI2+xziQALRD5/GvPJ/LzRgunvQI0=; b=mMV0CJstiVXmm6jvw0H6Ph5FnTLqzgKKm5SKqbR/KqtYBeVoqd4tZOkt5jJUJOr+tA azxFiL2VwzvNBJI49gkCkq1faBZ5ytrScjtJPd46W7yfvBpB3V6bMpylHhit4+O6afFN kpV+N0x8vcKTnxiGfxd45LkzQ4tJ8zEpWopZW8xCrC0p0w4B+U7s0u6peSPIJuQ6D2lp 1kk6JCU+OW1jA+vHE5GSBWbiTf6snpQ1PY4qc+TZqU8RqkH3FVrBrn4H8GFTQc7dg+gp nRavHtVMewMwGPYcy/IwxV5zcbB0IR9Y0LP6hCEdpHGcZgLK82COlXUG0u3xqCMg43Ns WWRA== X-Forwarded-Encrypted: i=1; AHgh+Rr5xMNMyamO9Ba7CZfymMm52ZsNc00XG7XoewGdSugg9rphZZdSQ3lgvEfUfmJQzq5n7nZ86dyX3YJD+KY=@vger.kernel.org X-Gm-Message-State: AOJu0YxhSQVIC1RWoktLWWB4JX2quHj/X8csjqiCM6qwsS9BE9lxJsTF Z9fpVC9rg8CTOTIxAFx8vicxMRfFm30cGAEw0285sluVwSRjoFsMN06c X-Gm-Gg: AfdE7cnCPgqs3pgJlCUVax1H7ylr2Mx2e4ZB36fGNVsrOgaEJ3p+WmuR1NNZl9Iypou EXb1gSNkhmVrUN1xN5KlGKVqzE6lq6nKBpizh70C2TRZEKXYq5jYlzFRPSVS3Aes4gi/e+SB/wl /mxrFf7Y86aBCGovPoV17CY920DCcOm37E8h+kgKPCbOvTqhkkY0dC31b0tCdvxcyclcvxzbOh2 J9Wy+FcVms3UaTINiIbEKfn4Kj/6elsXLX2bJxR7bmoER8MlIi55EOL2YmJaLqgpz7dqm33v2wJ FDd1PUjhcKljwmcWqrcmNdjq2oZ+VcRT/ZiFLaRVJ22X+hxWhsZ0hExBaOd+cGDufy3iYIn3W+b zw1UIYMZukGn2nZe9XO/HFxg0uCk6kmbBPzT/YOkn4uddLo+hQfcUf+HwNLOTVz3HpQWli3BN3G MJIiW5mA== X-Received: by 2002:a17:90b:3d48:b0:380:7d9f:81f1 with SMTP id 98e67ed59e1d1-38dc74c49acmr8119797a91.3.1783944258918; Mon, 13 Jul 2026 05:04:18 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5506b48bsm6419887a91.1.2026.07.13.05.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:04:18 -0700 (PDT) From: Guangshuo Li To: Alexander Shishkin , Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] intel_th: Fix MSC output device reference leak Date: Mon, 13 Jul 2026 20:02:05 +0800 Message-ID: <20260713120205.1003691-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" intel_th_output_open() looks up the output device with bus_find_device_by_devt(), which returns the device with a reference that must be dropped after use. The reference is currently intended to be dropped from intel_th_output_release(). However, a successful open replaces file->f_op with the output driver's file operations before returning, so close runs the output driver's release method rather than intel_th_output_release(). For MSC outputs, close runs intel_th_msc_release(). That release path only removes the per-file iterator and does not drop the device reference taken by intel_th_output_open(), so every successful MSC open leaks one device reference. Drop the device reference from intel_th_msc_release(), which is the release path that is actually used for MSC output files. Fixes: 95fc36a234da ("intel_th: fix device leak on output open()") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - Add Cc stable. - No code changes. drivers/hwtracing/intel_th/msu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/= msu.c index a82cf74f39ad..84d99d7b1d20 100644 --- a/drivers/hwtracing/intel_th/msu.c +++ b/drivers/hwtracing/intel_th/msu.c @@ -1490,8 +1490,10 @@ static int intel_th_msc_release(struct inode *inode,= struct file *file) { struct msc_iter *iter =3D file->private_data; struct msc *msc =3D iter->msc; + struct intel_th_device *thdev =3D msc->thdev; =20 msc_iter_remove(iter, msc); + put_device(&thdev->dev); =20 return 0; } --=20 2.43.0