From nobody Sat Jul 25 21:20:57 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEF613E866B for ; Mon, 13 Jul 2026 11:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783942876; cv=none; b=E32WFMy7vBCtAV8gj3DwHwHNDmbBI0JJ7mkDrscv9wgeZ3QsCRuvVLsJzyCXhLdS/qdRyc4RH+f7CG2sGhJ+/wnFAvINf6Snc8WSSto8fgqebUPja90IocahfUvmObWXMG34NgQlO+1mPcTQedghrof9ZZDwiByBAJGhEEgxxII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783942876; c=relaxed/simple; bh=DF8JWJfNh6M1Sw4cPR6Hjd+QCs0193pYYptH/jXmmFE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rlXi9FzMmZaGC1IrltnZuQbApINsiHYwEya5OELeB4Nk9NzUITRKc29EaDEN9PiDniZfUr4WQ9aXatsjtk6JYXF3z+oMoexCeKhOGB+1geRPVNPmztPqBR9DqINvOhnhJQyxdc/u+Q5FmOMvoW3tMluNuX+Dgd8TvJNBjtKEkT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I4PRoorD; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I4PRoorD" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ccdb73f0e1so25753895ad.3 for ; Mon, 13 Jul 2026 04:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783942874; x=1784547674; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Bjup8tkbZReyLVbx7owWNWJpf0WRCU5BarQCoUzbWwU=; b=I4PRoorDO4Oia6Gdwk/Kc/D0+f8ToiOYMGTUk6lTcb7FsTAqOMEkCjZlap27qNdGUd pTL21PqGoj4S8mZIWr8Z1j+qRCSgi0IJw20qAACd5co6Ay6PT3iCu3vSzCA/Nyo+y2yK t8qYUWpKln5W1rLNGUtwUp9L3MttmDPhfPf7phjh8RDCwe0KlKbkQ8qvgL4Pz/Ut+6Rq t4NmddTc167tRLSXEW1JVdybAjE3K0iIaJP8A9guPUzD0uE6+KLw3djuIp5n/U5NOEbk 9Y/0vMyC5FIg96LRDdpr6JSjpbc3kfABhrqBEM/FsuS7ZTFwbC6yoJPhYfeVl1BcfTIv TefQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783942874; x=1784547674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Bjup8tkbZReyLVbx7owWNWJpf0WRCU5BarQCoUzbWwU=; b=LKbmfAQ8Mf2LMswzqPUhg2HX9n0JQYzIV94qbnb1lNNwh2iQ3WkG5Uji9mqQDcp0ay jRd5nYVvrU3cm27ClM/ji1ymjdPdCGJxHTTZJ71lb0Eie7WHbVYriT0gh5ke0oZv/yPu vccsW7NX34Gc9ptuOhNEcfOa/g1L5wGsnUD7IGi1HvUWrzPItP9w0nC5n79aE6cJ+gQm IPGICCgkS0EI48HqqIZ74GmuLyRUzfaYpeuKJpnRZeEMltjdZl/zyxxW6bM554gvRdy6 TD8OfpkYeXjBFc9gqdQGAG49vEdcjiiye+Kans1sPmsc66TSwwhD+0rvKZyoyTjI8NUL 71YQ== X-Forwarded-Encrypted: i=1; AHgh+RoWRIbVoU6xGnNRmeWmVhgZjKEbDxmRG4FNMd8OoZcNw0bqNv2bzWHNNF2uRweZjSZVdr1sCl2hkaTYkqY=@vger.kernel.org X-Gm-Message-State: AOJu0YwARindsumWr+SibbgkJ61+WHbjDRqflX07VpmOGlRDsonbZrke T9NPKlr6PIF7OMypvmOJ2oasfnMrmeqBc8KctE3xEavwcaX5/jIu936l X-Gm-Gg: AfdE7ckTnyBopq3UtLmGMa8XmE9qjcMXzEAeMI2DCrLtb6DBgn6ZC1auuV6lQuntYwk q/47bqnwuuzePWdN+f+gcToAWaTVGEnbRFs2pjOZuk3g4qm2yiz3g+wiIhY1u2vTtcsqTpcMYBm PGJlkYMEfFKl6NZFtojCgQidLTWYuUm6iIgw3nm8Vs6sR+FKb6xFgyFec24YMPsq6ynDVmUtva6 ON6wdeIoOUf1WMoO7rz69iUoLSqVqFrAzGm/iJLoXZ3eABbavZRC/pv832etyv6r06vn/nMuLgX 2S8vaSL43Hx145vAjvDdANPAcHPzTKQeeMt5vS7vb9SKMnj3T5YkGpu/7JKNf/qKrzeEtnuiPY+ 0muU5P9GtjLvxFji9PkkkS/s4inRGjjX1ur9EduWJtqq8viJp5njY6btoLHmEe2lYU8U4rqydBv JULgOZ1Q== X-Received: by 2002:a17:902:ea03:b0:2c0:e2ea:6b0c with SMTP id d9443c01a7336-2ce9ed181f6mr81660085ad.21.1783942873961; Mon, 13 Jul 2026 04:41:13 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d59e33sm95978515ad.74.2026.07.13.04.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 04:41:13 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Nicolas Dufresne , Johan Hovold , Kees Cook , Guangshuo Li , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Marco Crivellari , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: stable@vger.kernel.org Subject: [PATCH v2] media: platform: mtk-mdp3: Fix SCP device refcounting Date: Mon, 13 Jul 2026 19:38:59 +0800 Message-ID: <20260713113859.921358-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mdp_probe() first tries to get the SCP handle with scp_get(). When that fails, it falls back to looking up the SCP platform device with __get_pdev_by_id() and then reads its driver data. The fallback lookup returns the platform device with a reference, just like scp_get() does. However, the fallback path currently drops that reference immediately after platform_get_drvdata(). The driver later still calls scp_put(mdp->scp) unconditionally from the probe error path and from mdp_video_device_release(), which drops the SCP device reference again. Keep the fallback reference until the existing scp_put() call, so that the fallback path follows the same ownership rules as the scp_get() path. Fixes: 8f6f3aa21517 ("media: platform: mtk-mdp3: fix device leaks at probe") Cc: stable@vger.kernel.org Reviewed-by: Johan Hovold Signed-off-by: Guangshuo Li --- v2: - Add Cc stable. - Add Reviewed-by tag from Johan Hovold. - No code changes. drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers= /media/platform/mediatek/mdp3/mtk-mdp3-core.c index 8f4da4cf55d2..121b1006ffdc 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c @@ -294,7 +294,6 @@ static int mdp_probe(struct platform_device *pdev) goto err_destroy_clock_wq; } mdp->scp =3D platform_get_drvdata(mm_pdev); - put_device(&mm_pdev->dev); } =20 mdp->rproc_handle =3D scp_get_rproc(mdp->scp); --=20 2.43.0