From nobody Sat Jul 25 21:20:43 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16A99388382 for ; Mon, 13 Jul 2026 11:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783942095; cv=none; b=nlwh0vdo/V2Xl9FG5ICYiHNtrvIKv5txmDZ+44J0S81N6f5AAnTvEwhZeoJCrqgDKXRdQYkwSUbCpcz9Tv95hu8ksDgrohXt3PPlZwJQ724OeWKgyYt1UfCz8m9xJiQxGc5/bw/IGiNlhGmZUDIWmtqpOQG8Okq8rUZ2ZDc5NZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783942095; c=relaxed/simple; bh=qAiI+Aq3U5FtaCmVP1hHMWOVi++6u8t9kYFLhCkE9+o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QVZuG+EAtrYuLhvWuyjOwgn50+w7lQ0FaL6jSEFGVxPoGijn8mdzf0zZ23EXJDtxh2ttm0WOIvrrNlQUC3WvX7k7oxjBKl6HXahJ9ItENrtGH3q4OxmL6Gj93Ksc68eJ5DQ1SbjBNVpFFr0EbmiT7aU54cnFBgOO0MhXnE0Hwjc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bgDFqgUX; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bgDFqgUX" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ce87c7e3bbso29990895ad.1 for ; Mon, 13 Jul 2026 04:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783942093; x=1784546893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=G2euxT0qaEKfF/kpFQE4EqG1inqBHFyulv/VShZJ89Q=; b=bgDFqgUXoRXwqi51nSDFOfAqyUA5UJTaqigcciydCTVZv4+IDKZ47aQ3DMU12Qs0pv Mu2IVPGJ4PID40USrUJ8JPVG1ztsoUf28/L75oKTC8pYSDa5VNJLv6GGRRZBDkoZkS97 bDpgkqBZ1k+CzDnYfpecm/s4Hjvy9F710UIWehxEeH+XOEJTOHGYDMltrabF3wJtlUaB 3eX65O9ZB1TMdqzN0BIEaMEedy09cZEZcHQIMvLirDKXqbe1IXi7qZfESRAA/Z7Ma47A ABnLheefQnJMGRRxcIPShOIh8m7TeWD4dN6PjTCLsk9Yt21ufaHlAsP+mrARHtuy51iO C9YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783942093; x=1784546893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G2euxT0qaEKfF/kpFQE4EqG1inqBHFyulv/VShZJ89Q=; b=fYLZied1/yb47k31QnQ7xC9LjcZkfTnOul9ATR48XqzbCxSw0FyUI+vp6dNk6gUjjH KuuqKvyRL0/JuOH3gsiwAnMelZlAYjf9cOcHGel1tHNSoZ9DangHOKJpk/hCKM63bwDz 9sWco58vLlu3Ky7arSgDf5ChnDLCjBtLSYk7Z8wJb1RQ3XPXf79cC1gUGDbxUgHgjgwo BmCQQcJpMOlpTA+pfiA2IX/NWYi4tIYkFkrewsjEwaqfuxR6mdTkO01qwV5aOrl7RBwB EuuqRHIkTmT9kb5AWyagGU75kj2Iz/8CunpMlprL/d68N86o2UeKeFQ4NdbW8mqONqak dviw== X-Forwarded-Encrypted: i=1; AHgh+RpqdNboipofOTy8CiXCBcL4t70IO9KwQr3Of9uRMq054U6RR5ZL1Qk3MdYtoQe8ztt02jczmOpvxn14yrs=@vger.kernel.org X-Gm-Message-State: AOJu0YxqbOHy37MH8l3pCjUWw8MucuQjHPDUi96wljvLfSukK99s2G7X PkCJaEn6XglthXLO/CeuS9tcMw0vVjONVvb2+/cPMG0ieOS1drCcDDWX X-Gm-Gg: AfdE7cnS3UvkPbKrZVB5fKnJaICsquy6lK2wa6F3FAwUS06Fi6vGZMv1MQ7B503QgPW 44ULD/efO/jKpcJt5S7ZrT7IbV5DenMWQj+ksfy/kFp78P0JQMlvoPmjhvsjIhEsSoVqlKw5LIS DMbn1mmPzr5OBgAAIKNmc+a1/m2e5xF/0URbV+5dwOvEVfa+tDdPXzrUwor3cFseQk1w8ncyPzU 5eq0PKEUYjoRjWpnZQTS4JVi0S9SzUiO6JNibwy2Ff1liXvXAOxxLUPH7rNmDC4LdHsfkc9UAMt ftI7EnsQGijcFZnaK7MYCL7JYAQ3s3YpfZTz9L9R9ZVqsiPKjF77k46pKOpjNQbt53Ekb8/ZukJ CmWms1PNAOhGSJlNoAKonBIdNvj5fxkjdRTNTrZT35XnapTwY6yWftUpwFA2pW79ovEiLp3p0g/ yG8+xz X-Received: by 2002:a17:902:e946:b0:2bf:9760:b94d with SMTP id d9443c01a7336-2ce9e9be58fmr82776575ad.15.1783942093236; Mon, 13 Jul 2026 04:28:13 -0700 (PDT) Received: from n232-175-066.byted.org ([240e:83:200::34b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d3d2efsm97224455ad.64.2026.07.13.04.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 04:28:12 -0700 (PDT) From: guzebing To: dave@stgolabs.net, jic23@kernel.org, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, djbw@kernel.org, iweiny@kernel.org, ming.li@zohomail.com Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Guzebing Subject: [PATCH] cxl/memdev: Fix firmware upload exact-fit handling Date: Mon, 13 Jul 2026 19:27:44 +0800 Message-Id: <20260713112744.2543829-1-guzebing1612@gmail.com> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Guzebing cxl_fw_prepare() classifies a firmware image as a one-shot transfer only when its Transfer FW input payload is smaller than the mailbox payload size. An image that exactly fills the payload is therefore treated as a multi-part transfer. The firmware loader invokes cxl_fw_write() only once for that image. Since both offset =3D=3D 0 and remaining =3D=3D 0, the multi-part action selection sends INITIATE, never sends END, and then attempts to activate the target slot. Include equality in the one-shot classification so exact-fit images use the FULL action. Fixes: 9521875bbe00 ("cxl: add a firmware update mechanism using the sysfs = firmware loader") Signed-off-by: Guzebing Reviewed-by: Dave Jiang --- drivers/cxl/core/memdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index 33a3d2e7b13af..45e7d2be17e09 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -921,7 +921,7 @@ static enum fw_upload_err cxl_fw_prepare(struct fw_uplo= ad *fwl, const u8 *data, if (!size) return FW_UPLOAD_ERR_INVALID_SIZE; =20 - mds->fw.oneshot =3D struct_size(transfer, data, size) < + mds->fw.oneshot =3D struct_size(transfer, data, size) <=3D cxl_mbox->payload_size; =20 if (cxl_mem_get_fw_info(mds)) --=20 2.20.1