From nobody Sat Jul 25 22:03:31 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C9E83D47A8; Mon, 13 Jul 2026 08:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932804; cv=fail; b=d98832vlDjnUX3OGb5r+AKxmtjRVAf5Y/dhVcTuzovV1G5uvmrlkqFs2wCw4QGYx0cJXoCeQv4s9xgU3eof4e5jydpzuODUXUAnJwIlzQXrZBQbV0KRoDQ82bCKsHvR2kTTXYrn5LU4CKgVLX1HXLPpSiUmjLfZcAdM4Dek01c0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932804; c=relaxed/simple; bh=qhmfD2AxaOMuq+vy7TjZkkjjqyVbXAB2QMnIDx07L3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=dtAW74BWv1xzI8K4teBqROh5KCnPjamMi6BcnB+XjpK1ueQNdIRr8bdRV22L5hkGOnvv4Y7GrmjuEQBUlS27/4otIdL5WgP/Pnq/iCjjuTevfcsvLfC5xShd+Ke3JS+mcl25Ao66zYhb6XIb90so2bP9g8uED+4WUxZOCac9kRE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=SVBfyf61; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="SVBfyf61" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rtuhXbb8OsQY3CLvgNMzT6g0AYxLiMC9Uw3dEVv9Wv0lYqiSHG+tJSoSGrL2Vf+as9YAnzfSOewGMDD7Pz8JStAixk/wMhG50TYjJwVDSELfOxfnhhV53P6RElyguVmd2z2Y9yYmV3B5Sawi2i1aTvCPo9Aos9nMDf5/tcuJpisfeSt8cmrc0TPaVyQVTTKWlmxjGv1+d9PFL4rBfgbwIehkwlDUeGmyEb+Mlo2AGf7avcQHP1Q4YI0SfkHd94qG71wsUDizP9OpRgEuEA0X2ddKSt6SUNynPEWLK9JTenn1HhyiecQh65hEF6k3FdaFaezW2QD/eaiRuQPs/n4HWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cr5ij74tYnvdvl7zgYATzrBfCWM7e2nHzLUYpxmRo00=; b=fPWztGCeUs+3fNFIGxdjIJPX1ABw7Q2S5B5I9PbbKuEgVIlqn97d1AVu9UNuCVv2XEBB3ko/7rn/t3VL/belqg+Es8jBoAA94ipQYfRDk95c8CGF7LTB4XWWcrzMuXs3BOPptWFxLOonmp45h3qq31yRoTzBDSMyPQuqVG1Pn3rgS0nhWKykvjigxjPUslTTKY8299MPYXBzyDMW9msZqZ73dcxwMAHK4LtWxRme4fRyAfvWKuLBSKS7hFxkZ46P3h0Q9v6iyidueP2mnWE6pcPvbAr8XeG8JhSpp3wGhGLG7HNSqXKPUaCRzFfOVRsngSOXwH/xeyqbWw431mPWdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cr5ij74tYnvdvl7zgYATzrBfCWM7e2nHzLUYpxmRo00=; b=SVBfyf61ZfHDTjJkMA9InmKYUy19gMWaMrNAovfBjD64Pb6dLGsbah3mvbz3YDzkEpKnKtuvWU3ENvzKT2edNoNUvuPyH6FzQgAHHRN6gwZ76ao7Ymt3W4vVodWtbcIM5BWOpC6hE3kdSWoiAGu5isd/Kk+Z89FKbF8RQpT5b/2RKEegisO0qqKc436m7P9VF78SopCSGA10SAgYJxixQyRA0bVgRuYzCKtZH5Ao1caTU8L+Av4MWNJIe/dndrASgckKDs4f2OQ95qh17PbM1uljI9dLxDsRv9l1buUimX7n5oCsDS4Iw0CBJZH5HaILSmNqYme04XvYZtGsZW5Cbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PAXPR04MB9139.eurprd04.prod.outlook.com (2603:10a6:102:22e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:53:11 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0181.017; Mon, 13 Jul 2026 08:53:11 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Angelo Dureghello Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Haibo Chen Subject: [PATCH v6 1/6] can: flexcan: use dedicated IRQ handlers for multi-IRQ platforms Date: Mon, 13 Jul 2026 10:53:01 +0200 Message-ID: <20260713085306.2643794-2-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> References: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR10CA0018.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::12) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PAXPR04MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: fe9d8d86-e439-45af-2879-08dee0bc2abe X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|23010399003|376014|19092799006|366016|1800799024|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: x85YeBtCMgduK+DRGU2RZRwm9CCvnVowXNDka7i/LnWgl8YbkKNJ60kDoV5jp0YFE1oBlIDeMKOElCbIa26RClkiXs9XZLkDLNMuW73rwHBm10rpGTlxrT2Tnz/+fGJ0Mgqjyljr/jZesRdXsaLxbRvhgSjWJ6IcnIWcMVNVNTbBXHfVkn+bN9fgrwRjymZEUkEtWYLJlvNk9vAWeeIA+4j5xAK7C+eI+1l4OXRwKazLVkrEBnksW+MHMbzUsEWpRrJ4rFs0tS6HKobjzMgJQYaLfLSU5DcROUuU0TzDCeCBK+m6vnVCvoqzxxdpRDh55JpHWYVqXx9WupQ4zV1CFOB+pTKtnXZS66MxCBNhG7W6AjGMCBncmw/pLNRj/yUiKQd7L6/bLneyXoZqzJpEIQ17fpvoE6JyFUu7tYz+MonXaW/r5X9/sAQju7MGiYaIP/4RYV5o1Fhao85D83qhQjLCvFXvZ7FUQp9HkE1pL1bu2tTrg51BJT5rpbOd/X/UZdTnxbF+b9c/5sUkhiagHEuuChvNakJVr+QkW8rIcIfWZ0DiJ4o683IRRXtnjRzJj/kuud9w6ebfCTqSP0xtqrWe4sYNq2lAmmmf1gsZvQClDwkUQR72IJuWtBqcOzg6PewfocI6BS16ckNud+kLdz+zGLebku5htITw0SwzGOs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(23010399003)(376014)(19092799006)(366016)(1800799024)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFhBM2JkQTdoVXdnNTZlZUc5eG92d2QrUG1uVUs3MGR3bnlZRW1uOEJpY2VP?= =?utf-8?B?YUxZRXh4cVhoam5QRjZFRHVmVWhTNnl0bHhRVTkrdjNoWDMvVzhLbWJaaEE4?= =?utf-8?B?b0ZpWWxOVld1MjVxV0owYm9OSjBQNDAvRHdUMnRqWlNjV3NnbUEvOCsxWjhQ?= =?utf-8?B?d0NYNDJPdWVFa0dBOXJQaHh3WWI3d1NyY2xlSDE5clFjV1BHRGlDdjNjZXFo?= =?utf-8?B?eWx4NXB1VEd1amdWR1ZaTTR2NVIxcDNFUmR2Ym9hWndSSXV4QUlWUFVTaDND?= =?utf-8?B?dTE1SVI4N1JBeHNWSG9BbkdKOUdUZiszVkZTMkZkeDdVeHBKeS9JRmpuak0y?= =?utf-8?B?OWkrUEF4YklCSVZkUktFM05Kd2JlRzBEL2pvUzBRTWxxa3R0enFKT1RqamVP?= =?utf-8?B?SjR2MWg5dm8vVE0xL0hFcFpNcWVGNllXTFNpMnZVbEswVGRyK3RZK2d4N2VW?= =?utf-8?B?ZER2azRyRWdXT2M3ODdlc0NKQkNVcGlUUXR3MU1OSDlxOW9vb2IxdmFROGl1?= =?utf-8?B?QnVjL2JWWXc2dXY5VjFiWEVoVUYvTHlFZjNYaEVxOE0wSFNNcUFIWHN0QndC?= =?utf-8?B?bDQxY1FoaEFnelZzMjBjb0VmbUI2T3U5cHVtSmlOaTFTNCttRXJpZTNITHFS?= =?utf-8?B?ekxWMkdnSVd2TVpRaDVlQ0FmS2ZpenZRZHZvMWFyakFGOW5Yb05wOVRXSDk0?= =?utf-8?B?R1MxbGI5RDBWRXFTZmJhVm1IQkUxbVJub2t0VzFlWHU0SzhXSWU1LzRndWVi?= =?utf-8?B?WDVvRFMwY0g3Ujh1SHJaLzBkUStRNm01R2lWNW42M0tMOVl3WGlOM1JQMC92?= =?utf-8?B?RmtBaEZ1eDVUdll6S2FQaFpIcG11d2ErN0UrUmdGY3luQTlyazBXckppLzRu?= =?utf-8?B?TjVVZFoxUklSck5XVW5MQU9mTkNJbDQ0bXRKM2FTTFBQc1VkTi9ST01PZmI3?= =?utf-8?B?ajFwKzJBdXZaTC94c0lwbEtyenhFd3NNSEllcnJMbUhONG01QitxR0JRZ2wz?= =?utf-8?B?Q0hvNUc5eXNPblNudmRKTWtxQllRUTRHOTE4SFpnVmhKMmNPYVphdjFvc3Zr?= =?utf-8?B?UlpaaGlkUlVKaExTVm93TVBMT1ltY0lmeVFFL3dOT0FaelFkcUl4cTVIZ0Na?= =?utf-8?B?OGtMVmZRWFBrZmRwQlM1cVMwQnFuSThqbzNJVjJRUk91am5CVHlXaDh4eklG?= =?utf-8?B?MVgvczB1dFFad2xPNlhsMnlacHdPektNaGg0WHpLbDBhMWc0RENxay8yNCs3?= =?utf-8?B?RlMvQ1lqNjlBdEE1dXUrZDlsbk43d1QxNUdiNmR1VDFyNG5rbXR3MnlIeHpv?= =?utf-8?B?QU5wQXAzVXBtSVlDdTNxT0RuSUttSTdUUFFWTG9ySkdCZG9qRFJRQ0Q5VHY4?= =?utf-8?B?ZjI2N29OL0wxcnVqRllLMW5YdXZOa29RK0psKzNMTkhPRmd3dlhaRlQ4TWxh?= =?utf-8?B?VHkvR0N1WGRlbXpWaU9ydXRtVVByNUtNQ282NStCd3Y0L3NHSERaZkNaV2xO?= =?utf-8?B?Y0t6eHNtczl1VElFM0RjbG9PRHJaYlRxVmNsNDF4LzdTNE43bkJuczRObkZp?= =?utf-8?B?OStVeGxlQmdXUHJUdXRzTW1VcDNGU0FaWFh4cm5jL3RRcW8rOVI0cEowMHMx?= =?utf-8?B?TThIeWpCSUh2ZDFtSElPRFhyYTlaQ3BjYmRreUxyUEpOYTlkZVl0SENqUjZY?= =?utf-8?B?SE5IMDFBSUxKSFdlQkErRVE4elN2WHF0Q2JZU1IxeUROMEhUbVhSSnpSSWh0?= =?utf-8?B?MUZiQlRLbHIxNysrdXc5SUcrSXdGckZGR2ZKOXFjSWVwMjJma3pWVnNVQU5z?= =?utf-8?B?aENVWDBMSThxTU41Y1FUNG1GMHBrV0FNMnN6NCtLdDcySllBLzd1c2pBSStK?= =?utf-8?B?L1RGYkhYQUJEeDBqdTZuaEtrVXpqYTI5cHFCSFJ3SUR1QXJZeDBzMFhObDYv?= =?utf-8?B?MGVCOFhCTjRUamE0UEMwRnRuQ3ltQS9ZZm1EZFpTeitjOGZPRC9FNUhsbS9G?= =?utf-8?B?Mk9rNnl2RThjQW9jRnBSK25IekpRTzJjb1BoNXlKNktGTEpQZjJKS3BMR1dB?= =?utf-8?B?TkhMeE82cW5ydklnUHdUaFRzNy9mbkdzMFhYNzcwQkdvam5jTEJTR2FpMkRT?= =?utf-8?B?ZU1UaGhpdjVKeENVam9GR24vcnNSWTN5dUZyUmQ5RnFJdElLaFMxRGJMMGhS?= =?utf-8?B?Y09Ma2IwSmNJUnR6Tm1rZXI0T0ZwY1p4QnpZbWh4S3lJbndIVDJJV3IwNm9R?= =?utf-8?B?RHhWb0theUZqUnVuRmZYMlhWb1hDTGo3eWxBdU0vNlJWQi9VT3lpUnZSNitP?= =?utf-8?B?Z3duZDh2VUIxbnJlU3VaWFM5NkdJdHRaZjUxaXFXMWhxamJ1ZTJtdElZSEJJ?= =?utf-8?Q?+oyohNb2yGYwksc8=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe9d8d86-e439-45af-2879-08dee0bc2abe X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:53:11.0119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UazC6MBBaV5bnldbwii4o7oYxpGxvl685XlUO15slKaAn3HnCm4St+axWtX6QR1dkulmu5EE6DtdLU6w8Iad+Gwi9oGWQ3KDKnQwdqJiz8Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9139 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea On platforms with multiple IRQ lines (S32G2, MCF5441X), all lines are registered to the same flexcan_irq() handler. Since these are distinct IRQ numbers, they can be dispatched concurrently on different CPUs. Both instances then read the same iflag and ESR registers unconditionally, leading to duplicate frame processing. Fix this by splitting the monolithic handler into focused parts: - flexcan_do_mb(): processes mailbox events - flexcan_do_state(): processes device state change events - flexcan_do_berr(): processes bus error events Introduce dedicated IRQ handlers for multi-IRQ platforms: - flexcan_irq_mb(): mailbox-only, used for mb-0, mb-1 IRQ lines - flexcan_irq_boff(): state-change-only, used for boff/state IRQ line - flexcan_irq_berr(): bus-error-only, used for berr IRQ line The combined flexcan_irq() handler is preserved for single-IRQ platforms with no functional change. Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support") Signed-off-by: Ciprian Marian Costea Reviewed-by: Vincent Mailhol Reviewed-and-tested-by: Haibo Chen Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 128 +++++++++++++++++++++---- 1 file changed, 111 insertions(+), 17 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index f5d22c61503f..f73ff442d530 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -1070,16 +1070,14 @@ static struct sk_buff *flexcan_mailbox_read(struct = can_rx_offload *offload, return skb; } =20 -static irqreturn_t flexcan_irq(int irq, void *dev_id) +/* Process mailbox (RX + TX) events */ +static irqreturn_t flexcan_do_mb(struct net_device *dev) { - struct net_device *dev =3D dev_id; struct net_device_stats *stats =3D &dev->stats; struct flexcan_priv *priv =3D netdev_priv(dev); struct flexcan_regs __iomem *regs =3D priv->regs; irqreturn_t handled =3D IRQ_NONE; u64 reg_iflag_tx; - u32 reg_esr; - enum can_state last_state =3D priv->can.state; =20 /* reception interrupt */ if (priv->devtype_data.quirks & FLEXCAN_QUIRK_USE_RX_MAILBOX) { @@ -1131,25 +1129,57 @@ static irqreturn_t flexcan_irq(int irq, void *dev_i= d) netif_wake_queue(dev); } =20 + return handled; +} + +/* Process bus error events */ +static irqreturn_t flexcan_do_berr(struct net_device *dev) +{ + struct flexcan_priv *priv =3D netdev_priv(dev); + struct flexcan_regs __iomem *regs =3D priv->regs; + irqreturn_t handled =3D IRQ_NONE; + u32 reg_esr; + reg_esr =3D priv->read(®s->esr); =20 - /* ACK all bus error, state change and wake IRQ sources */ - if (reg_esr & (FLEXCAN_ESR_ALL_INT | FLEXCAN_ESR_WAK_INT)) { + /* ACK bus error interrupt source */ + if (reg_esr & FLEXCAN_ESR_ERR_INT) { handled =3D IRQ_HANDLED; - priv->write(reg_esr & (FLEXCAN_ESR_ALL_INT | FLEXCAN_ESR_WAK_INT), ®s= ->esr); + priv->write(FLEXCAN_ESR_ERR_INT, ®s->esr); } =20 - /* state change interrupt or broken error state quirk fix is enabled */ - if ((reg_esr & FLEXCAN_ESR_ERR_STATE) || - (priv->devtype_data.quirks & (FLEXCAN_QUIRK_BROKEN_WERR_STATE | - FLEXCAN_QUIRK_BROKEN_PERR_STATE))) - flexcan_irq_state(dev, reg_esr); - /* bus error IRQ - handle if bus error reporting is activated */ if ((reg_esr & FLEXCAN_ESR_ERR_BUS) && (priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING)) flexcan_irq_bus_err(dev, reg_esr); =20 + return handled; +} + +/* Process device state change events */ +static irqreturn_t flexcan_do_state(struct net_device *dev) +{ + struct flexcan_priv *priv =3D netdev_priv(dev); + struct flexcan_regs __iomem *regs =3D priv->regs; + irqreturn_t handled =3D IRQ_NONE; + u32 reg_esr; + enum can_state last_state =3D priv->can.state; + + reg_esr =3D priv->read(®s->esr); + + /* ACK state change and wake IRQ sources */ + if (reg_esr & (FLEXCAN_ESR_ERR_STATE | FLEXCAN_ESR_WAK_INT)) { + handled =3D IRQ_HANDLED; + priv->write(reg_esr & (FLEXCAN_ESR_ERR_STATE | FLEXCAN_ESR_WAK_INT), + ®s->esr); + } + + /* state change interrupt or broken error state quirk fix is enabled */ + if ((reg_esr & FLEXCAN_ESR_ERR_STATE) || + (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_BROKEN_WERR_STATE | FLEXCAN_QUIRK_BROKEN_PERR_STATE))) + flexcan_irq_state(dev, reg_esr); + /* availability of error interrupt among state transitions in case * bus error reporting is de-activated and * FLEXCAN_QUIRK_BROKEN_PERR_STATE is enabled: @@ -1188,6 +1218,65 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) } } =20 + return handled; +} + +/* Combined IRQ handler for single-IRQ platforms */ +static irqreturn_t flexcan_irq(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_mb(dev); + handled |=3D flexcan_do_state(dev); + handled |=3D flexcan_do_berr(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + +/* Mailbox IRQ handler for multi-IRQ platforms */ +static irqreturn_t flexcan_irq_mb(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_mb(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + +/* Bus error IRQ handler for multi-IRQ platforms */ +static irqreturn_t flexcan_irq_berr(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_berr(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + +/* Device state change IRQ handler for multi-IRQ platforms */ +static irqreturn_t flexcan_irq_boff(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_state(dev); + if (handled) can_rx_offload_irq_finish(&priv->offload); =20 @@ -1761,25 +1850,30 @@ static int flexcan_open(struct net_device *dev) =20 can_rx_offload_enable(&priv->offload); =20 - err =3D request_irq(dev->irq, flexcan_irq, IRQF_SHARED, dev->name, dev); + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) + err =3D request_irq(dev->irq, flexcan_irq_mb, + IRQF_SHARED, dev->name, dev); + else + err =3D request_irq(dev->irq, flexcan_irq, + IRQF_SHARED, dev->name, dev); if (err) goto out_can_rx_offload_disable; =20 if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { err =3D request_irq(priv->irq_boff, - flexcan_irq, IRQF_SHARED, dev->name, dev); + flexcan_irq_boff, IRQF_SHARED, dev->name, dev); if (err) goto out_free_irq; =20 err =3D request_irq(priv->irq_err, - flexcan_irq, IRQF_SHARED, dev->name, dev); + flexcan_irq_berr, IRQF_SHARED, dev->name, dev); if (err) goto out_free_irq_boff; } =20 if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) { err =3D request_irq(priv->irq_secondary_mb, - flexcan_irq, IRQF_SHARED, dev->name, dev); + flexcan_irq_mb, IRQF_SHARED, dev->name, dev); if (err) goto out_free_irq_err; } --=20 2.43.0 From nobody Sat Jul 25 22:03:31 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EBC3BAD8B; Mon, 13 Jul 2026 08:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932800; cv=fail; b=GfZFRBXMn32fVvrYwbmEyDtKECiZ9D4KvUXFBpjrkiDd3UegZ5ZdfwajfLBsjRPJJ4zowPcDk0oz0/JYJZvWvnN0S5FAFZaqySFjENZtbWUP94Pp3qKg4q9AXnwSCvdEwvP7GybrOTrRuhvJMMfUX2S3HNJcS7ptVWlW5VW8YAQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932800; c=relaxed/simple; bh=jEKc1mHUxTPgmopcleEEXBhGsLlzVY9kPz//6GeEJ28=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=YrqohyT/S+uD3aa9IFcqvkvPzTul8kvEOOfBbWh+d6uA7jxIs9WbnPP7IvmhzVcE6PCtyodwE1oBmwTCCawZMr7MY70ppvx8ARvQonhzZ2ugk3qOUacridpMOTryEi4+nwIfq5n/Zuex9SOZnMnPI+7V03EqHqrkbwctB7lJEsE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HeilkWda; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HeilkWda" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yrxbhcaXHNt2X9iQX7isWyZo/2pKm163cTWU5SsFCLcd3Nq+6Swz3N6/WpBudnGZaJ2vWp4w6+UPP7376lz8/lZOSsqMwJjO5muNgLK2cNtOHrzo9146xrXH1YS95l+laDk7O5YyJh4RJwrQc26BMTuNoGNZH8wbVbAOvZAbBIf72I+1DhvWr3hiJs03oNTbNeRoRqzvyI8JPGioigR97aiCcfbGT9dGwrI9qXlJQBGodsfOs/CmD/Lb2PiLGjPjRYWx5z1BcCngESd3g1qmheZoGDbS3+ov0Tfx79T9/+RbwcXd7GdKWooUMr03S0ZS+L/HROFrWbKrn9qO9OOKWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EIwMQuNSe7a3jJkFFm2nuBoWfl5Wt9Oyitq8ajx+img=; b=qQX4r5cuWShNSYEf50upo159br+CPKrncYhyVnqsnPeg90wERSvjBvSg1xKkLhGhhmnxNtcfTqCXKxf31W+r0FWXuq2SDddwrJtWeT89Ug/3RQtUh8DLFCZXrwmK8+CYw3tpXWCIRx7s8MeB4jhoaLvIN5+NA5TBHxVj1DswZJ/Z+tBY96ZB6Aiwy6cgLz15dZfLEX7coN8Y30UwkqWI8KiC1sc3ehd49AHzFV8cH0+s0SASHLgl04i5VpVD/mAwT7ksew6MJ+rKm+DGFG7YJ1VuUJ4nexi5gsIRneKCItn2malo/8HqVCaoJ+9khVSaUsRJ94aU3kz8MLrA2FPk8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EIwMQuNSe7a3jJkFFm2nuBoWfl5Wt9Oyitq8ajx+img=; b=HeilkWdaS01aU7tjxSp/rgffaAkA2N4LlRIoBe1gGBU6w6zD1NQPQaxYFzqOR/sfcJ6JfeR9TAHK2JczozClimqk2BOhYzjsJwFg3x1N52T2heJD52LUOzi9HjNdQnx8p5vW8pi2txEAGq6IuEgUGr6vtvHLx8YiGsH8bzyd3Y2GEmtDxcYzd/39XWlMVxvOJ3qbudXA7I6rISYwMThuYsem0WUZQbcCFGszyuDHaiMoohWfHqwXHtNjcRrSlRKjEBFH3SVRDVKeEY6e6sy0++LsUQ+TmfWS9a83orwB1yQxF2poUQ/ZlcPGRlikiXqrGziM06fTPjTZnW+FyqtbMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PAXPR04MB9139.eurprd04.prod.outlook.com (2603:10a6:102:22e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:53:12 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0181.017; Mon, 13 Jul 2026 08:53:12 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Angelo Dureghello Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Haibo Chen Subject: [PATCH v6 2/6] can: flexcan: disable all IRQ lines in flexcan_chip_interrupts_enable() Date: Mon, 13 Jul 2026 10:53:02 +0200 Message-ID: <20260713085306.2643794-3-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> References: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR10CA0018.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::12) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PAXPR04MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: bb672a0f-017e-4df7-69b2-08dee0bc2b74 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|23010399003|376014|19092799006|366016|1800799024|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: NCz8OdpEHbhnUdBqkPEhmRh53wO3riAcjCfm4ElEHat0eWkVFL9ezO4iRZz1ZD5mCfEPHGWy4B4ntuzZvTqYwQKhgAZVEfranoBXu2XVKik/FeHhhfBGjJZ+MYRQcYEOv5LQcZ5qVq8Mej65FSqleCC9Try4949UVJhxkb1DWEfddSSc8nQeQ0uZn6BnI+CQ00OPhh6QMtHA8CVIig6A5JiEG1AkwDhIpWuB2i7qazTuSaFJj9MHFYBs0Wujl0qF61/+F/L28NsyTMt/lvHLquvRi6BBbLwYXTpE04TYnM87QVWDHrk2YUSFlEbRqgbguIu77YIlSaljdbruT47wuCm1JcZItuNO9fWIaqLMyK1vbLbIYnA3ski8pCaCwoLowDiukIycNXv9LMyLM0IuytBBXNHAfjvvQ4o8PXZNSw0r3Rf9obkNl6jTcJMw0McQjrdd6Q8iAYoXXpyX/6FI6Sarby+eBaJdc84EJcWOrChwC4CVk32v8lif23lpDTS0d7rfTsB3vpiVbimA7a/7hWl9Gs7Nb9PSj+mmEKCQbT6+ImZzuVOhNbKCZVX73FufVSgCNjf4a6ZW9fUQWab5nYmBjeYMrupBCHMoL1P9dVsf8tWFJSosXVYgVmjADMOCcdubt5LmjIkg5hmUAssnGtZ8YjKwfX+dfGiQ9IlAWWM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(23010399003)(376014)(19092799006)(366016)(1800799024)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk5hbTRsaHBhdmVKZ1RmMUw1alFOMlYwK0gvRzY2MVdSSVFiS3hiNTkvYlJV?= =?utf-8?B?RUlVbmNaUTdiSXpIQnE2ZmY4bFFkSXo5T2Q5TEtsdi9DVitTRW82cm5OTmRH?= =?utf-8?B?L0RremJMUnFMLzY3ZXlkMjlDZ2NTcGRQT3dRRDJEOHRIYVNFbHpxYWttd0xB?= =?utf-8?B?T2hVdlBvcDRCRzBlYXlkc0YwZis3VGgzZTlPWENhVWwzbTNZMi81VWc4eTkx?= =?utf-8?B?YmN5a2pSMGNVN1d4c2xPalhHVEdsbmV6MlFlNmJPMXJsUWhoSEU1T3lWOXZI?= =?utf-8?B?Zm9ieE5ITUh1OTJwbDd4UnNoU0o3eW1oVDk1blZyOXNxejUrcUdQWjdieUtu?= =?utf-8?B?aStRdDdsR2RrSGtuVUpucytsd0JIc2RCTDllZGZBaXppaGFoTEdYZlZZNWlN?= =?utf-8?B?OE5XY1FPbWVQTnA4SFRCeHZaTHMvNHJQUTVFNzZBbDJocllZUUxkNXJTdjc2?= =?utf-8?B?NmxMOUUzYmx5Q1ExUmVvU0VNeTM5ejRNbEk5TzBacm9zSmwyUVdiWUQ2TWZy?= =?utf-8?B?U0hSYXptb0lMVFF2US92WnVQb1pjL1dXc1JURXg5LzZwVnlLRkF2c24xYjhQ?= =?utf-8?B?UDZFUDUyeitaMk1nUXZJb0pIZy9KVzhlOUdEbUxjV214WHZKMDVqYjBDR1Fm?= =?utf-8?B?VXd2SWRQcVdhaE92ZFhzMy9uRDJtN0NDT0Q2aFkxOWFQNThaRDF5bDB4aFN5?= =?utf-8?B?VHBsU1RDaEkvQ250a3R0YjRJcFpqTmROKzEySk1nTTdTRlN5d2o4UWZDbkpZ?= =?utf-8?B?MTFmMHdnell0SVdQVW16STdOTytoOUxxY1JGZ04wenhoM2lDMHd3TWxjd1Vm?= =?utf-8?B?OHFyOUhETWVmVDRzVW93RWRMRmNLdkhLZG5URGY2N25ST2lCSldOSE9VSktm?= =?utf-8?B?Rkw0Tm1jMUp5RWJIcUcvWElDM1RaN3hFdE94d2xIYWwrK0J2ZWgyL3FrUm9E?= =?utf-8?B?dmxwdWtiY011eFJSaWpuK01BeWVNb01YRlNUYmI4U2VRWWFWQ0pxNVc0ZjlS?= =?utf-8?B?dWZOWi9BVGZkTmhIK1FRQWJBQjdsa1VtNmxyZkdESmFsS1ZBeldyQkVWWUFG?= =?utf-8?B?Rm9GSmhJSkdLVVZ5aCtSeVJkeHZtc3ZIc0s1L2QrdjF4czZIa2o0VkJneThR?= =?utf-8?B?K0pUdGZlVVUzdHZ0cytjN0YzbHJYWEFEOHpER2NuOUxsWmVYN2pCNXhCN09M?= =?utf-8?B?VmZqQ3h6ZFQ5TnV5eW1WWFp1UGcrdWNVQXIzYlVFbGhhT3ZtMmg1cHpIdWxa?= =?utf-8?B?OTJWODJhQlFHRnRFbzZicHp2ekxhNTFVaEtiL3JBczRmVUlUbWl5Rm1GWDEy?= =?utf-8?B?a2xPVEpsV2lScmk1QWtRM204b3djaXRzTnlrU2pFMlRHN3NFRmF6ZHdBM1Jk?= =?utf-8?B?L29aMVgxRnNVREFLQzhjczYrR3RzR29LRzYxYmlVQTdNM2lvRDQ4UXhCL1do?= =?utf-8?B?RzV5OHR3NFRkbG5KVmlUVmRBL05rdUdnN1grNlRvS1lDNktNVStwWFZnMVpS?= =?utf-8?B?YVVkKzVLUkZyai8yLzJ0cTBSTzEvVzBCK0FHcWNNSVBXRW51VXMrc0JNeGYw?= =?utf-8?B?Zm5YNkcwWmN3dVFrL29FM1NFTHNvR1hjVVBRbmMya3Vldlc3M0FiMlJraTJt?= =?utf-8?B?clQ2UE9uMVZNK28rOE0rbDNIcWl1bHZzZ2hYR1JFczRLdnpEeFpJTWxEaWlH?= =?utf-8?B?ekV5OEExcm11Ni9MTUxMUm80bmsvK2kwRnlQRzRwNzBRWS9jSnZsR09IRjRy?= =?utf-8?B?MXVuSDNtT2laVXhHUGpuSUluR1RtK05aV2d3dGRlUEpkTGU5aUxpWG9jeWtN?= =?utf-8?B?Q0ZSSEoycjZleHgzK29LemhiNlZWblJhRENUQ2MwUVBhc29EUElEbnNiU1Rv?= =?utf-8?B?enBjaitBLzFFVlhIbldMWENIWFZ4MjVYcksvUllpSDdmNEZVZytjQk9Jbzcw?= =?utf-8?B?Q1hyWHNpTmlNTm9LTU9GdjhSNzBNUzNnK2QrWHdrVWNvZmpOOWQ1cjdQejkr?= =?utf-8?B?OERxSHhCeDRGMzNYeDE0QXR3WjVLSVN4NU5ER1VRMlhhcjV4RG1HUjJCSzJp?= =?utf-8?B?RndSQkQ2aHk5ZW5KbWYwNE5YeE02M1Q5Q0trb3lVT1Btand5T0RvWUVvRG5F?= =?utf-8?B?RG5UL1VISFlHQitTencyZElsNFZoY2JIcGhab09vNmJGWDFObHd2STV2L21X?= =?utf-8?B?QjBKV3dwbzl5a3d6dEE4WkNFb0ZOS1lMNlFmbUkwdnZISThmelJjNWg3VDlL?= =?utf-8?B?V0p4aEs5d0dkSUp6dEU4L0k2Z3NBZm8zbDFONWx5aEExTks3T2tDQ21kMGNN?= =?utf-8?B?YkNYbmFMS0xLZTVCaDJkcVZXei96RUt0K2dJcDFZYlpCQ3ViQmM3L29YZEo1?= =?utf-8?Q?bWtIUYnd75oGOSbE=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb672a0f-017e-4df7-69b2-08dee0bc2b74 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:53:12.1778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vaGm3goO0rgHeZAPt4UAMT/RAclkPChKz63lIPt8EweQwPloBCrZOcSTvvRmEhIwbTajWE0XKZUt1b4NVN9FPb2DmXyCu9D1BlldQ0Q44U4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9139 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea flexcan_chip_interrupts_enable() disables only the primary IRQ line while writing to the IMASK and CTRL registers. On multi-IRQ platforms (S32G2, MCF5441X), the additional IRQ lines (boff, err, secondary-mb) remain active so their handlers can fire while registers are inconsistent. Disable all registered IRQ lines around the IMASK/CTRL writes. This also fixes the resume path, which calls this function. Signed-off-by: Ciprian Marian Costea Reviewed-by: Vincent Mailhol Reviewed-and-tested-by: Haibo Chen Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index f73ff442d530..7dde2e623def 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -1519,14 +1519,28 @@ static void flexcan_chip_interrupts_enable(const st= ruct net_device *dev) { const struct flexcan_priv *priv =3D netdev_priv(dev); struct flexcan_regs __iomem *regs =3D priv->regs; + u32 quirks =3D priv->devtype_data.quirks; u64 reg_imask; =20 disable_irq(dev->irq); + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + disable_irq(priv->irq_boff); + disable_irq(priv->irq_err); + } + if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) + disable_irq(priv->irq_secondary_mb); + priv->write(priv->reg_ctrl_default, ®s->ctrl); reg_imask =3D priv->rx_mask | priv->tx_mask; priv->write(upper_32_bits(reg_imask), ®s->imask2); priv->write(lower_32_bits(reg_imask), ®s->imask1); enable_irq(dev->irq); + if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) + enable_irq(priv->irq_secondary_mb); + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + enable_irq(priv->irq_boff); + enable_irq(priv->irq_err); + } } =20 static void flexcan_chip_interrupts_disable(const struct net_device *dev) --=20 2.43.0 From nobody Sat Jul 25 22:03:31 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 911BB3D331D; Mon, 13 Jul 2026 08:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932802; cv=fail; b=G0lu6S08cMqLBi/H310R6amz5yvtVzxEyzLQGAkMDYfuj32nqL5hkvCJhVBrvBSrDBV3nyDEEfaoojWiG0jpDoJHuep2HFtyVv7d/NZF5AULIcLN8+FmcYUvUjYa8VI9hvc2i38vyxvAw7cwT27FgEF+aNHPF1xLzIKpny8tu7M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932802; c=relaxed/simple; bh=YAexm8pVlZDny8Ten3hso/o/Gvry2HaPfLMK4PB2AjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=S80gPaNIavsczYOe6GBDNWalB4jfRzV2iuim7vUfGb+1DWmW3qYIl7y/YPxSMeMW47dcyxNzB1c1c1stnro1+n3F0AdEFzQaNKA4fjbqbo1HiKV04aLq7hjcD+0NImiGlah88WQ08c0Hl9Vzah1/4S+NL6gIM1htxjuA1lHxqe8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=MCU7RYqm; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="MCU7RYqm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IvM/G0vrOqAYd+92nvNkyTAXXX18X9ml1kcvB4j2tDk93TD3oaLTbo6CbongbrCWZ2RQ5+ryJBsuND9V9JU+EGZXkRczdqLjA0tWj4RDa+E8yFtPU/kPXlTAutKA7snMUEDquYWIS+5K+LZ41Az/zCht/r0u13z+0i2GR/rAmAG+wODof0llqhwNN7mz3uc9rrvJS2Niv88tCNVibuM9LhEmt3YGVM/mMTNWLIj+bUwW98di29IfxJyN6PM0zc/3a37nJAmtpnNTx25XVLq4tFPiwVzkAuzgtcs8TAZ9BDxUqS80eSqWvna4oIDx+BS5tpWjuw20gNKY3BMW755VyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FTZLozdaZejLwtCbU/HyeDKjbs0bUL40fVmInykkfXA=; b=EGGd6x78r6sLF1B1Ng+UfVG3Bdl0rEAmDfZhn4rPQVRK5vhMOY67O2R+KTxDRgN8YKtVvyBaHZ6xioV36jwY5tK/4D2yoz+Plsd47uckbPahP9jYyJvpYZLRGbEpxUz4PGdkiQrv6OyqQIIsCjx9wGjYXkU2sQiMfssaVImUHDvgHA7p1KdiTbh4CSaUWjRJHq6IJdn3HLixIWCYkcZrnVeiQABM9aHrwOolP1q+bsvO7pI9lTXP6BBNnGshmFT9MNKdYP3fHNbyDBOBbqUxksIj4crMU87Yr9xx409jMAS7J0huo8xlOIpJQdY068kCiqscgm3iEbdDjrE1qdpjIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FTZLozdaZejLwtCbU/HyeDKjbs0bUL40fVmInykkfXA=; b=MCU7RYqmxMr6NYCNXWBW47FCzlM1M39AYXbBUjq1B2jYf0ki9S83m3KCKtKZhEyWoV/7KTJxUEVnu3go8KiyLHWAx5eSYKgsFLy4xYV/ftQAKcrUU1vpyfciEcFjHzp01q5C7FvRApLrbakMUNfmsKjfFy265fc4ugBNqklMTy7acX3ArOW22cGcEqO76FWDsvuaPErSPiJ6iGrO41bFU+T614MxQYm1WEkoC5TLsdbwsFoEFzPRsnJ1asUcUu0SgWh+z2qyu4QaBfY8QKIcFpQ2uLx6AWWL2xSW5Pw7cM5Lg5zlv6aXB+f6n5ufyplabwwNluDNlENYzIvGW+ADXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PAXPR04MB9139.eurprd04.prod.outlook.com (2603:10a6:102:22e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:53:14 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0181.017; Mon, 13 Jul 2026 08:53:14 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Angelo Dureghello Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Haibo Chen Subject: [PATCH v6 3/6] can: flexcan: split rx/tx masks per mailbox IRQ line Date: Mon, 13 Jul 2026 10:53:03 +0200 Message-ID: <20260713085306.2643794-4-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> References: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P190CA0047.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::11) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PAXPR04MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: eebb0d66-ef03-4651-f99c-08dee0bc2c25 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|23010399003|376014|19092799006|366016|1800799024|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: +KXSst3ngBGuXG/nMcfFhuDU/yeLxSQV4UmiwBsEtd8uo5C4/bvvJI2JMXl3kfmRQFfrwN9vEgd+rN57DFnfrW7I+uVIDlUxoempgjhYq2KFqo400fl4LZ+4raCe7I7ge3v9SLewR7pwwHx5D881NTQLccAq3KgrlC6RiZAHP8b757RthV2n5JMlp/Fiuu1oxQK16rUA6y21meG14oQ0j5nXDz9kZZSWIJZeBx3auXdJuxjrQSi8x+rtnJYUX/RPhxbIiGXCy61ilXf1dDdXl5pzRRDtrlFsKsRiGzYEM0KxbOiaof/Gjw87omqi6rjsyNm5XoaYRCHhPTtxt9GO4cTRXF0ODo/jEsDbrMVmkdPRH8UrofG9CBh3vM8/Dgk3yW7w5nRlgqEjxAomZqEyHtNQhrGkUZyv1wmruGJeSDgwOunWeUFFVvjq2jmF/s6wwVZGNi4NXyPSsUIVNREilfYsE8kaJpHwxG9+Ijeh6Levx6fhxLWGJs8/UMgtzLJIlAUxHHI39ruLoxAlBmthZoiuFqY4illi77iVL88QNb5BmmRmOgn2Eqg0AUpNLBGEeJvSaYVMI0YgC3Ikb6vjfHoeam79ygQgFsuNaj1Y4W8IjJZtJYoDtcS8IwhIwf4BDjuCX21QCxTk3VFnF5PnpjJstUtLEyqtNGvufjgB35c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(23010399003)(376014)(19092799006)(366016)(1800799024)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDdwVGtCd0NyTEJMTVR3Q2NQM2E5UDJ5QThKS1hKU2ZWcG5DNGduV2o5dm5C?= =?utf-8?B?TUgwR29GaXJLbzRKdncxWTRFZDhKRERadnhUV1dpTzAzTW42ektrYnJpc3NI?= =?utf-8?B?Ukg4OW13NmxUSFd4Uk02bEZVcHJ5Tm1lYUpXaGZjd05kWGJFS0Y5SldmQjI5?= =?utf-8?B?VmxNQ2NiL0pENSt6cTZBU2NHS0RxVzZycGxrWWlndWo3cTFhMHJmcEJqSHlO?= =?utf-8?B?ZnRoZENvMGFxY253U0txWnFHeWUzZ0tJT1BWQytDei8yUCs4QnhYcS9rTk9X?= =?utf-8?B?ZXZtUjZ1SGNCS29La3lHL3A3eXJ6eWVMUmUyWWFQWUU1ZllZYm1wQXJ6cGZH?= =?utf-8?B?RHdSQXJiOXVkVzgxVUtNQ0FqQ0pHSzJVK2JaR3dLYUVaRzJmcjRNblQyMEZH?= =?utf-8?B?QzZCU0NoUUhkbWdMSWkyRVJGN0VDVUE0bU9Xc2JEUW9WWXNSZ1VCSkdvaG90?= =?utf-8?B?VzFTbEw5cWRDMGNjSUxONGZkZk5xN0dIakE1U21iMXJrRDR2eGVxUTRpenFP?= =?utf-8?B?WWRmT2lBSGVGRjhET0FoaU4vMTBCVDIzbHV3cEpSbkUrU0MzTEJESTlwWWFS?= =?utf-8?B?ZjlmQmxBcHh5NTRGRGs2U3pYRkV6blFaODVIUEFmcDJVNW9HZWhxbEVDdy9q?= =?utf-8?B?WUZwZHJUSGZRNDNzYzlMaElKZHFHMk5lRzlUaGs4RGswSit3WFZuTWU3OEgy?= =?utf-8?B?NkhVckVYZ1NZTmRuVnA2QjJyV0RjbGJqcmtGM3pkUzNJcUg5c1cwTnZIcnhD?= =?utf-8?B?T1l2K08wb0xsT3NUelMyQ0JLZXJYaXpkeDl3UGszVXI1QzYwU3dTUWUrOEpt?= =?utf-8?B?L0NNbWIwOVFMU0Y4WVRBZ3E2UG1FR2N3NkVSNlRTVS95akFHZkNXR2hTYVIx?= =?utf-8?B?V2tlSHVYVEdjczFGdzQ1QzFnWmdsdzZkb0EzNWxvcFB2V2J0RU9iSnBkZk9x?= =?utf-8?B?R3FNTHZNbmZJWkNoeUxSZERZN3RKblJOQmJGVUo5NkI0SllVdHFyVld6MFVV?= =?utf-8?B?dllpN2hETUtoMDErMnpYQlVOc2tTN25FM2lkNzc2c3F2Nk1Ld1pzYjd6SzRC?= =?utf-8?B?cUg2aVRuQU9tWS92WUFkQzVtd1d6RnhkbndicGJTUlBycXozN2lOZG8yUzFY?= =?utf-8?B?ZG5lYWVaaEtoNEdMdWdadGpYMVNsQUFJdGl6Q3FWYzhyRWNGSGJpNlF6OUhG?= =?utf-8?B?NHBPUTdVZUUrZVdGdkVuTjJHTWlocFM4Y1RxL2ZnT3doRS9qMUZMZmxSV1g5?= =?utf-8?B?aHVwNmdpekpLa0pSeVA4WklNTDRyZmNxekV3QytDam45bkxHLzY3Y203b2ww?= =?utf-8?B?OE9MUG1PTGxKYXJtMjZub2dmbzFkSENnTS9hVUluYjBMVWpWN0lsRTF6a2RF?= =?utf-8?B?cmRTOWFRSkJ4d25qdVlDM3NTN1J2bTZSQlZVTi93NFg5eG1leVdGMzk5ZmJx?= =?utf-8?B?M0U5aVFvMDdPN0s0aHVPSzEyMUE5NlYwdk55MlN6NjdzNkdQVkllSGZKcnp5?= =?utf-8?B?OG12eW5UWVI0aS9vU20zSVNGWWk1YzNReHZlNDgwMEp4T3pkSXo0aWpMbDlo?= =?utf-8?B?bEw1ODlodW1qVTRGelQyeXJZOVRoR3VnNVZud1hvTWFCSFhlanlJYXBkdnl0?= =?utf-8?B?b1VORFYrK0Y0bk9Wa2t0OWRlVGRJVU5CY1JrQ3JGdDVRSW1iL3pEZ05hTmV6?= =?utf-8?B?RHlsWkV2VXpORnNxQWFGVTZsS0hvWFU2Z0NZZFlOb3pFMkRhWmdzSWtaNEEx?= =?utf-8?B?eTV0QWY5dHlzRXpWaS9ObnBsYjJ5a0kxUjU1dEJKKzgxRkdXeUt5b3BZbDBX?= =?utf-8?B?Q3M0c3V3UmF3WVN4Q2NNOWlrK3BrZTZ5Sm1XSUNOT1FRWXJZeHd2SGRJdjB3?= =?utf-8?B?Q2ZYRDNTaHhLOENGNGNLaXZOVVZMczR3aGZZK1E4eEdibkQyV2RQVG5zTnZO?= =?utf-8?B?THIxV0JhMWtzVkM3MjFqRkwyK0lQWEJSTGlmQjhzcWhKV0xvMDZmSElVMDlH?= =?utf-8?B?b3kycE42azcwd0ZIS1c1VXlsR0RyU2ZFMkl5UG9OdFB5UHBHcUlMaktBVTZO?= =?utf-8?B?eDNUZ05YMjU4Lzc0K3ZuR3VwaUJOUnJ4YkluRTZnM0h1KzV4YlFkajBIYzZN?= =?utf-8?B?ci9SK0FsbmNXSHVoMUg3TXdmNElVdm9TTC9ZNkFCbDZYbThxU1BIU1QycXoy?= =?utf-8?B?NW93am9CbUtkei9yeGwxSk4ybnZYL204UEFLUVh3RjJrM2IxK3oydkhRU0hu?= =?utf-8?B?OUhabVNQcVVsWGh4ZmlLZU9EUmVRSTFheFdKZW9iZUFUNHVvclYwWnAyOGlm?= =?utf-8?B?cllydnNOMzMwUk8wSWE1NUYrajNNbVFldVlhbStJM2dpMXFDVU5zRXRodnM0?= =?utf-8?Q?mw7x0Bf0YYsJT738=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eebb0d66-ef03-4651-f99c-08dee0bc2c25 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:53:13.3727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iXGl6vYeZZ/38BkBYeCf0rsegxhNNf07Y4XJXucHVPD4qHTS9EwpEN/UQjcHNEWLKe7jNpSnZXulqbjlU2TBy8HOxIHQhuUrqWhbfk+nfiE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9139 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea On S32G2, which has two mailbox IRQ lines (mb-0 for MBs 0-7, mb-1 for MBs 8-63), both handlers currently process the full rx_mask/tx_mask range. Introduce FLEXCAN_SECONDARY_MB_IRQ_MB0_MASK and FLEXCAN_SECONDARY_MB_IRQ_MB1_MASK to describe the split, and pass the selected mask to flexcan_do_mb() via a new mb_mask parameter. In flexcan_irq_mb(), the irq argument selects the correct mask: the primary MB IRQ uses MB0_MASK and the secondary uses MB1_MASK. For single-IRQ platforms, mb_mask is ~0ULL with no functional change. Signed-off-by: Ciprian Marian Costea Reviewed-by: Vincent Mailhol Reviewed-and-tested-by: Haibo Chen Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 39 ++++++++++++++++++-------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index 7dde2e623def..8b70952f7f05 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -182,6 +182,12 @@ #define FLEXCAN_IFLAG_RX_FIFO_WARN BIT(6) #define FLEXCAN_IFLAG_RX_FIFO_AVAILABLE BIT(5) =20 +/* On platforms with FLEXCAN_QUIRK_SECONDARY_MB_IRQ, the MB IRQ lines are + * split. + */ +#define FLEXCAN_SECONDARY_MB_IRQ_MB0_MASK GENMASK_U64(7, 0) +#define FLEXCAN_SECONDARY_MB_IRQ_MB1_MASK GENMASK_U64(63, 8) + /* FLEXCAN message buffers */ #define FLEXCAN_MB_CODE_MASK (0xf << 24) #define FLEXCAN_MB_CODE_RX_BUSY_BIT (0x1 << 24) @@ -957,14 +963,16 @@ static inline void flexcan_write64(struct flexcan_pri= v *priv, u64 val, void __io priv->write(lower_32_bits(val), addr); } =20 -static inline u64 flexcan_read_reg_iflag_rx(struct flexcan_priv *priv) +static inline u64 flexcan_read_reg_iflag_rx(struct flexcan_priv *priv, + u64 rx_mask) { - return flexcan_read64_mask(priv, &priv->regs->iflag1, priv->rx_mask); + return flexcan_read64_mask(priv, &priv->regs->iflag1, rx_mask); } =20 -static inline u64 flexcan_read_reg_iflag_tx(struct flexcan_priv *priv) +static inline u64 flexcan_read_reg_iflag_tx(struct flexcan_priv *priv, + u64 tx_mask) { - return flexcan_read64_mask(priv, &priv->regs->iflag1, priv->tx_mask); + return flexcan_read64_mask(priv, &priv->regs->iflag1, tx_mask); } =20 static inline struct flexcan_priv *rx_offload_to_priv(struct can_rx_offloa= d *offload) @@ -1071,12 +1079,14 @@ static struct sk_buff *flexcan_mailbox_read(struct = can_rx_offload *offload, } =20 /* Process mailbox (RX + TX) events */ -static irqreturn_t flexcan_do_mb(struct net_device *dev) +static irqreturn_t flexcan_do_mb(struct net_device *dev, u64 mb_mask) { struct net_device_stats *stats =3D &dev->stats; struct flexcan_priv *priv =3D netdev_priv(dev); struct flexcan_regs __iomem *regs =3D priv->regs; irqreturn_t handled =3D IRQ_NONE; + u64 rx_mask =3D priv->rx_mask & mb_mask; + u64 tx_mask =3D priv->tx_mask & mb_mask; u64 reg_iflag_tx; =20 /* reception interrupt */ @@ -1084,7 +1094,8 @@ static irqreturn_t flexcan_do_mb(struct net_device *d= ev) u64 reg_iflag_rx; int ret; =20 - while ((reg_iflag_rx =3D flexcan_read_reg_iflag_rx(priv))) { + while ((reg_iflag_rx =3D flexcan_read_reg_iflag_rx(priv, + rx_mask))) { handled =3D IRQ_HANDLED; ret =3D can_rx_offload_irq_offload_timestamp(&priv->offload, reg_iflag_rx); @@ -1110,10 +1121,10 @@ static irqreturn_t flexcan_do_mb(struct net_device = *dev) } } =20 - reg_iflag_tx =3D flexcan_read_reg_iflag_tx(priv); + reg_iflag_tx =3D flexcan_read_reg_iflag_tx(priv, tx_mask); =20 /* transmission complete interrupt */ - if (reg_iflag_tx & priv->tx_mask) { + if (reg_iflag_tx & tx_mask) { u32 reg_ctrl =3D priv->read(&priv->tx_mb->can_ctrl); =20 handled =3D IRQ_HANDLED; @@ -1125,7 +1136,7 @@ static irqreturn_t flexcan_do_mb(struct net_device *d= ev) /* after sending a RTR frame MB is in RX mode */ priv->write(FLEXCAN_MB_CODE_TX_INACTIVE, &priv->tx_mb->can_ctrl); - flexcan_write64(priv, priv->tx_mask, ®s->iflag1); + flexcan_write64(priv, tx_mask, ®s->iflag1); netif_wake_queue(dev); } =20 @@ -1228,7 +1239,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) struct flexcan_priv *priv =3D netdev_priv(dev); irqreturn_t handled; =20 - handled =3D flexcan_do_mb(dev); + handled =3D flexcan_do_mb(dev, ~0ULL); handled |=3D flexcan_do_state(dev); handled |=3D flexcan_do_berr(dev); =20 @@ -1244,8 +1255,14 @@ static irqreturn_t flexcan_irq_mb(int irq, void *dev= _id) struct net_device *dev =3D dev_id; struct flexcan_priv *priv =3D netdev_priv(dev); irqreturn_t handled; + u64 mb_mask =3D ~0ULL; + + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) + mb_mask =3D (irq =3D=3D priv->irq_secondary_mb) ? + FLEXCAN_SECONDARY_MB_IRQ_MB1_MASK : + FLEXCAN_SECONDARY_MB_IRQ_MB0_MASK; =20 - handled =3D flexcan_do_mb(dev); + handled =3D flexcan_do_mb(dev, mb_mask); =20 if (handled) can_rx_offload_irq_finish(&priv->offload); --=20 2.43.0 From nobody Sat Jul 25 22:03:31 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DBAD3D5244; Mon, 13 Jul 2026 08:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932805; cv=fail; b=k6gRsHnEH6RwRLs1JYCzg/YDFKC4TCu4b1WiYPgBYKwSpHEihPMkN4TK4K1OjFHpsncfcjE+ss0E+hT5jNZS8g14XXV+jVgiyosvDj3GS0OSB5GLzZr247gk3VwBwjBOiBLWTS7CCaLJr5fN21wYFA65zmrjp16F79TuuG+LVOQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932805; c=relaxed/simple; bh=1upDEasXsZkAK0im+GIkBFqGG2oU1/fr19aNvoErZ4M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=a/6dyVed5CVviSQ98J4n3KmytblzjmUFK/o3pO8wBPo+HbTPmDqSjyco+MLpdZHJ+xbs1tC/ldfv6acF39NXD28Wr9n6y0weKDu0IS1v1caYfV65nrwN/PA84QL+IMi4qBS1M/e7cqIIgJs4nI1rnfMH43jenIahLnZYKvm6A8A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=B2UWrg9m; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="B2UWrg9m" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m0JZ95murCcPsoY5nISyoYDp1xOp8JAskS3JJT3WMmwEr4y6kJ2RXg9eX7aVDex76ssMtOGtz/quif/NtdncuduNyAwQV1bfbGvCxyQEEqIoTXmjMgMO0b0k0TXcVAjf47fEQ+wtiKeKdYVNvgOJfOqTFZKrTH7lO5CsOrsBs7/lhsgTVOl88VdaHyPzTPGcYdAomz/bVcPsZH/gwDCi8n8jgV5IehjwYm35Cvkb3Db8V+qB4Q71BHehqo4S4aAzNfzik8RgGhLvabSM6/s0u0k97Bs3g9WGTHh5dqAdM4eu7iutMMVn9i/4pyyC4/bivbnhFaN2m31x9gqbZsVmuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AfLF2os2kzzc35jZf3bjNKQLGWICLw+dnzgpzDvFcWY=; b=Mo0JKurCIzCAQrGNi0gvhdrBWx/qRS1/7zEIvABOrNSeiZet35r0aMnTQuLV9cSv2loNAqDzjOG56siXTELMfgSCvAGk59Sgk/ntXb0TQb1u/R0JVd5+QzQrT6J4lRj8E2qvcOBGdNK8+9Sjm+rvKfcw0KZ2tj6guezp6jYNFZImrfMcSrjELP7Rtk55zIn14+QI4CoHpL2xza0RLHb9a9DL1DR+BIZN0iS+SgLVpfwbcIEVTSNyeq6NlgurZqLaNd4WHtne3SDqNah+jHaxtpsAkA8dtJ8SahvQZjwNiGNEaLqAkeK1DWlzLJFcnENeL3FKWjA1ikzF0EfWQ3OVkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfLF2os2kzzc35jZf3bjNKQLGWICLw+dnzgpzDvFcWY=; b=B2UWrg9mQy1Q9Etik6ZeHLeTny9wz2+H4chlGap7n4odVPBQ7F2q/cz3NYz+0jfhB6nmegf17NDkNOGLOJ/l7OX3SOk5CeWNFPxWw44OXYMpIMSZ9Vo1zatLDwdonYNFyM+mcGe/y+5VkiWCNX8G9zQkPPMh1a3EMJF4qr7fC0ckzb8LTopN5tduCCVHf9DJqZ0tMQ7E+OfjM2U5eOEn6oLnaRhXFCqzaMssdZFcS2bymQCNsQbWLar1lX5DygDSyERTB3mMivyFhGVk8Du1lR5Mf1ZU3zYBHjK7rMz1qqmJHZ+9mXjHZm8p+arjyoZT9Qaqd6BfThFEE9xXzWTIGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PAXPR04MB9139.eurprd04.prod.outlook.com (2603:10a6:102:22e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:53:14 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0181.017; Mon, 13 Jul 2026 08:53:14 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Angelo Dureghello Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Andra-Teodora Ilie , Larisa Grigore , Conor Dooley , Haibo Chen Subject: [PATCH v6 4/6] dt-bindings: can: fsl,flexcan: add NXP S32N79 SoC support Date: Mon, 13 Jul 2026 10:53:04 +0200 Message-ID: <20260713085306.2643794-5-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> References: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P190CA0059.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::26) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PAXPR04MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: 37bff051-4373-4727-78c9-08dee0bc2cd8 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|23010399003|376014|19092799006|366016|1800799024|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 5e3ukmQvYVOEBHx38VhCFIFCuUAHKYYM9j4GTug9A4HOQGi4SOpECNVpkd+HAxccTrdOcOz8Ke5rCFi+ecZ/YhkHxCptcZPdZfbI9oo+Tc6iiDxRCR24iR2Z7cg9f3dCtBpYSzJB+ANwHo08tgkSR92j/Vku0gLfyhN6lbFPrRsfORwfRKcS5p4a8v228rNbj6NZJdGJH+EYXVUn5w0a3Nr2uVqshe6PyBd2j+knM+QJbX6554U6lH5leWntm3tFJbFI8wjsgHvk90gafzGhoK8NY/ZI6bGUOrj2OJ4eUP6AbN0SqgbdN4aAiHLyE+js0HtEUNGNs9eonrFISDGxIyB1ZygD7x2ax9Xya7qbBqQPnG5knNbxaoKAQcigvP91jFgw4CDx7mi1he0kyazSgZoLKutP48OMfmk2jUGiRhFduUi3A8O2XDE5aYbAL+464nH2aiU+ntAjzGdXNYK+0zRsaJdQCi8p8LNl+sxByVNWNIufILP1D2jsEGz2Q1dQzL4s0NzWNS2L6late3BqjAIa4vxSWEoup2pQ1NGTFGKWrbiv0KrthHc6WAn/tz1aJY+kA60RPN2Eph1BRiqa/O6QiFeRIISC8dHuuxQXsk1MMqQNGf+os/pFn4Oo9jPme1+mCNzjwYIbP+tPxSF3N638Z6ppl2biFradtLcua/4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(23010399003)(376014)(19092799006)(366016)(1800799024)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXV4V0JxcEE2Z0pSVWRWOGx4Tjc4RzcyQlNlU0hlUm1TZ3J1ek5tREhGZm9F?= =?utf-8?B?Mkd5KytEMXQzenZKZ045R2FDUEFUT2F1bUkrWXMwaDIxekhIYWQ2bHF6U3hk?= =?utf-8?B?UkRiNmQwd0wraTBuQlg1MTI0ZWZGRTU0bTNOblFVOGJSS2dXYy9wZk9TWTFp?= =?utf-8?B?djY3QWxQbjZuckZQMXp6d01hOWdudDZkOTlDd3p0Qjlrd0l6MEpIV29MSWRW?= =?utf-8?B?aFZnNWNxSGhrdDNGUUdVRC9vbUdzbG9WbHJlVk0zMDhNWGFpR3lQMFdkbU1a?= =?utf-8?B?YXdkWjc1YTgxNmxxekRyeDUzdXZ0ajNSS3dCdUZCNHcxTklsZEFXSVltWEFE?= =?utf-8?B?a1NyNTFIWHNLcC96bjhPaDVKbmpvTnBoM01IVGZwQ0tXUDRjRVVvbWRFc241?= =?utf-8?B?RFlzdmFrdWp4bnlQODY0dGNTUUlpbFFDUEJ5ZFY5MWVKR1djYXdBZEhlY3la?= =?utf-8?B?TGh0bmdveXV2Si9RYkY3WWtxWkVxWXNLekYwS2FlQk8zWHh6V0E4VUpNaUd3?= =?utf-8?B?OUM5RFpTdE9CUnNua0NPbVAyQmdIeFljYnJPMnlRU1dDSUxvVE1HVmJObCs5?= =?utf-8?B?ZWZhTzJYMS9iVkZNVWUvM1RWdFZEc0Z5VHU2OFFjOW9qL1dFSUpVdURlcXBS?= =?utf-8?B?REthdDJua2w5K3h3cmRHcWVIajlzSnhRQk9zRVdETVhua0Vvb21pYVg1U28y?= =?utf-8?B?ZFF1azFSdy9QQnVYd1AxSVE4SjdGSUJmVWVSSjNMdGVUQ2lQdmxOTk5kb1Ew?= =?utf-8?B?Q1grKzZoT1B1YWNnRzhaMTgwMS9KaXNYM2k1amZaQmpKQzhEV2c2MExGUDkx?= =?utf-8?B?VUNRL0E5SlBlZldZL2hwV2Jsd3dsUFlaeXRsSi9naDAvSFl4SkZPYjNFNEdB?= =?utf-8?B?c1c2dXNRb0J3eHYzYkJpS3RRM3htZFE1U0lwSHFnNWt1T0s5RUNHSkFhclVB?= =?utf-8?B?RTFHZWp0eVhwUU1pcExxeXdmdnA2alEyZ2VvQ3FwRkJDQUtaZnlmWVVIS3ZT?= =?utf-8?B?dStBWVNVaHlkVDBtMndiQ3J2QW16eTcyWXJFckdPdVhKcE9uZ3ZUV0JVeEEw?= =?utf-8?B?c3MxaGFhQnV4TEpGRm4rSGNtVXgxTVIraVFGcFlRT1FkanhBbFM5Tzk3Nzd2?= =?utf-8?B?dW1GM1VhMlZ1Ymg0ZjRpTnFKQVNYdW9ESy9KMzB3T0VNSHB5V0RLcVhBOWYy?= =?utf-8?B?b3JVdUs3WlRCQTJiL1EyKzJBMW9vM3ZRN0M5M1g1c2JjbnpKelFvaUFMcHZr?= =?utf-8?B?NlRPb2lPOWYrTVBLZGdreGlRN1Y2MU05cjcvdjZmd2RNeHl3RXZObDJHYjBO?= =?utf-8?B?ZWNqbnhkMzVrcEFrSHhBd0NReXBHa003TEV5SEJBbmFkZS9lSDg4NEk3cjc3?= =?utf-8?B?RE5KRFpPUmNFVk14eTYwYWR5NngwM1R4SWRkUGdoclh2Q0pZWGhjYjMwNGVN?= =?utf-8?B?QU9pWmduenZqM2o2TnVuV0VZV3A2Q28vdWE4b081Rzh6V1g2bmFyQWYzRzBa?= =?utf-8?B?eHk4ajhVUy9lRm1tejJBbVlhdUl0M2k1RjlLNVQ3M2JSRTQveHBvNVdlY0ZE?= =?utf-8?B?Mm4wRFpYeDF4Q1h3bmRpNVBEOHlpc1hmS0dEZzdnOEZpV1h5SFRuQXFEcFlF?= =?utf-8?B?YUtQY3RSTWQ0U2NQRC9QWTFJaUFhLzhnUEtRUlRGTDQ5TGI4MjB1Y1FxeG1Q?= =?utf-8?B?SlJuNXFHNjRtcnB4OGw4Q2JCUitiaEhtYklsT2p6Myt5ZHBuVkhqNVZBZ3Vn?= =?utf-8?B?TTh3aEZYUkt1VUVYKzNLcjhCV2JYRmxQN0xnZmJuWVBEOW1laURsejIrN2FV?= =?utf-8?B?R3dkdzFOOUFtYUhMZDg2bXFpOHpVYkdWcjRnK0ZNcUVQNVdYSGF2bW5hZTBk?= =?utf-8?B?OXZvTVFreHF4UXVSZEhhREJ2bnNPcnE3Y0FwR1Zob0ZXUjRwR1NjWFBJWEo4?= =?utf-8?B?MDc2YzRHeWVsK1hrYjJoRzF2S3JnTnB1Y1FTaG5CMHJtSXZLSHhBMkFpeGFM?= =?utf-8?B?UGE5K09FWnM5TmEwemtnOElQU1Y5Z1RYTjFQTFV3aW5wbzVXd0xHck9VQzVz?= =?utf-8?B?d3JiUnBPYkloNk96aHpLdXAwTndaYVFUTXpRVzRsaiswcWJFOFNpamFSU29a?= =?utf-8?B?THRCNllNZWtmRE13THlwMVMrNHBwYjdIYmtXY0NtWWxZTlBxRnNDN2hWb2VR?= =?utf-8?B?d0ZSTHBpSm12Y0hRMjF4UFVJNkRROGMzb3pmakpKSTlIRlpLcm1BYStsbjlo?= =?utf-8?B?V0h2UFdxeTY1a1QvSkJIekR4RXBCZFJSUkxkL1dPRTJSR3pTQlpuN0NydlJ1?= =?utf-8?B?Y1c5TDYwcFZDRW8yRnc3VjcyMHBMc3dFUmdIV0hNUFNNNkdUWmdKSk5CSFc1?= =?utf-8?Q?bolSos+WHIIlH3HM=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37bff051-4373-4727-78c9-08dee0bc2cd8 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:53:14.5510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: opsynHU224+LQWczraDdIyvYkr1KTTnukgM4vp72f6C36pgsRovGZIqrubJ9//MDJC1M7wUEtYjqUaHfDu/ahmfJG3SWKhVRMPGObZ5GpaQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9139 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Add NXP S32N79 SoC compatible string and interrupt properties. On S32N79, FlexCAN IP is integrated with two interrupt lines: one for the mailbox interrupts (0-127) and one for signaling bus errors and device state changes. Co-developed-by: Andra-Teodora Ilie Signed-off-by: Andra-Teodora Ilie Co-developed-by: Larisa Grigore Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Acked-by: Conor Dooley Reviewed-and-tested-by: Haibo Chen --- .../bindings/net/can/fsl,flexcan.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/D= ocumentation/devicetree/bindings/net/can/fsl,flexcan.yaml index f81d56f7c12a..d098a44c2b9c 100644 --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml @@ -26,6 +26,7 @@ properties: - fsl,ls1021ar2-flexcan - fsl,lx2160ar1-flexcan - nxp,s32g2-flexcan + - nxp,s32n79-flexcan - items: - enum: - fsl,imx53-flexcan @@ -173,11 +174,38 @@ allOf: - const: mb-1 required: - interrupt-names - else: + - if: + properties: + compatible: + contains: + const: nxp,s32n79-flexcan + then: + properties: + interrupts: + items: + - description: Message Buffer interrupt for mailboxes 0-127 + - description: Bus Error and Device state change interrupt + interrupt-names: + items: + - const: mb-0 + - const: berr + required: + - interrupt-names + + - if: + not: + properties: + compatible: + contains: + enum: + - nxp,s32g2-flexcan + - nxp,s32n79-flexcan + then: properties: interrupts: maxItems: 1 interrupt-names: false + - if: required: - xceiver-supply --=20 2.43.0 From nobody Sat Jul 25 22:03:31 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F4BF3D45DD; Mon, 13 Jul 2026 08:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932807; cv=fail; b=JOTlIj7gIzP8tTrCK2RZollSoVW9D41Jp8sTNP4HL6mRYtncjiQ1LYlPh47esGVqdxs1Hd29Q9lI/Cq22DuHsr458H4TjpTGcUVRsxKc6bdppEyAtZmVyghRbWqir/gR2XTjPJu9hokmEOvDUQReBiy4O6CLdruBoPf8IhKgokg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932807; c=relaxed/simple; bh=L2GeK4P9A0OCzaBg3VY0hDTGq0jlrEjH8CorYuCjNb8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=i5qsDjz2fB7JPMlIIHacNtwyzE4heq4ZHaIiqINmzRT/QAjnBgcX+l/37GPHrDZ7zsPIaPJ/RyU/4rhWUOiRdWYyTD31Jz+V/7hbcBCsvn+4gMbaZKouWos7JfIKOHu78OTz9MvuDOOvvzuXmhqDovMv3sMbXn8Lag9KeIuH1m8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=w/Ywa1mn; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="w/Ywa1mn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DfGSv2ZqCVph7B97rzJRp/ni47QmftZ7OPSHtUnLFympAcnZuMth3pRJBUm7eic0oLOuS3mj2FFwbek53/nbo34WrF+hgni5SmgqW41o0A5jFc+aeM7EyCer0jyStGAP0oGhfiflavIfZmtY51EunGYpBJEvrL1T6JuMIeQD2iHrVSjrqci5G63OFWsmMucaBcMovyYQ6DZI0iOQyazITa2TwbG1+mJLEK6Fcvh4dwoE8YX3Xji0XAfT/RHGkNjZnVJAxQzcfCtMfOtdYcAc79p+DP7He6vJBNkgBY42Au6+FZBzn+j9j8MzquTtwmqIO9ay0YCUvzNtsVT4q0vvkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYysnO5TUDX/ijxoCX0C5JjYD7tZK3PMESQ9/aXD9cU=; b=YmRSzU+7f2QURKjPek0eI7MikheTTkZ9mr0f8E1qxA+Q6MX/fMFzMKFD4Ujpk5vUT4dDhygGdy9DLVnLRPHQQfWfN4H5eaTp51uPABRnpoUU6MX7FFK3x6ah7mz3QShzjoZOKTtEHxBQSSoI4OEXQVIjgIagWECB5MPXkOnBoWLjPoeqXbnsJmIxx/DFaldimwk7BQcRTAChdMxchl5L1C/k+sNtGaa43SBWqYxhni0Fa6UpTpJ2Sh02qB1nDM3mGrc5jB1m7Is/YpYhfcgPmdBAAF8tpqKlsa6c4cVRhxqKHL/kQXd9IBfWNCbQv6aTYaudn7xuml2OMJzDg+8tiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nYysnO5TUDX/ijxoCX0C5JjYD7tZK3PMESQ9/aXD9cU=; b=w/Ywa1mnszNeFt+JfmMS7EVHQwQ8O393O/ZVoSwGkCPOprPjYGkM/Fg0/jsFqb0ZLYi65D+jAHjkIxqjM6qtSwlUwt9C2uQHhY37plbf6ID/gtvBEFbgzrIZC+q6sBc/Jsh9P9uwTWKGzKO6YuLBgohxrNYTln6p++a+mkxgM94GgfFlzp/qla8h9CXiMVwL6muNQsVyKYRIgkrecM4zx3F9JRka+p+7WZ/f1xghMykRiuUerKKgXQ4Ouu5vDmgDWvsN+n0Xmk90gaRYg96QkzHoWuBm8eKGQiTbV3coCEmqtEK38+tVtIfRs+Hp7VNakEKC8RI/juVxwzAky+JJVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PAXPR04MB9139.eurprd04.prod.outlook.com (2603:10a6:102:22e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:53:15 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0181.017; Mon, 13 Jul 2026 08:53:15 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Angelo Dureghello Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Larisa Grigore , Haibo Chen Subject: [PATCH v6 5/6] can: flexcan: add FLEXCAN_QUIRK_IRQ_BERR quirk Date: Mon, 13 Jul 2026 10:53:05 +0200 Message-ID: <20260713085306.2643794-6-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> References: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P190CA0054.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::18) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PAXPR04MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: a893f518-6c9c-4c64-6428-08dee0bc2d84 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|23010399003|376014|19092799006|366016|1800799024|56012099006|11063799006|10063799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: LC3E8i9BLChyRaiBS17J+E6IR3oBkm9TckJz7FsbaiqQiwL8bdIfzFCpDGmxbchL7zkxNaP8fTf/sMVZnybEoy1u8PQnFRMOuFyktGrVzgsc7/PcIWCp4zPvTfHctSG9tG0jATsWVLgSNA414gcZeOHDr7YJ9f9foV/vydk1HQdYGwAO6Ms+hqLwg8uRYog3TOD2CtuK3ET9FtXCNuuXyPUjuTlI1K7VY/Ep8VKM9EaEmDPKztFZ/B60yjCO/OvT7TGs65ZxYTBH5zonHytp/51JBrEz62C0gFR4Q6lRJJZiiWUiRl5wkubLzKR8NHqKVyLol6JihaTZESmU/jL1wl17MMt645CQgHBOoHN6eZFTtLuOyNxaKnIxhJPv5IG0hxGL4MeaDawLhJY8s1CrR0Emj4Ci9LUbceuq2vqBhsFtb/NKTC9qEwcE195RSjOplJAHaMsTfaooa0A45cy5UZ28YrColxYpGUTWgCGVQAwveUlsusP9NhPGW55X3GnXvXFde1fUIuEymLwImj4CkgE3h4mzMGgexJ+vrRN2Oici3u21h8Yo2AWhUySQ+Zp2S3ut6a160ulL2ERg/aZynXPIA7Cux7JNM3/LNbnV1wZRjHkMHH/ps99NjHg5tR2EJ3+Bnoy6VzlRdofUC3OXYu/pfGFIjHk2KuIGCjLJGgo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(23010399003)(376014)(19092799006)(366016)(1800799024)(56012099006)(11063799006)(10063799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VC9Gdi9aSGhhZ1htWkNGLzNKdWd4ZVNNMllaY1ZSdzN6SGVXb29sSlRkR2Zz?= =?utf-8?B?Zmx0RjFUZVJKVU02RGt0TDV1ZkJtNGhXK0tRQTgwUkZqeUJIMW5oVHA5c21o?= =?utf-8?B?eXJOa2FhUk9EWVVTZ3QycW1tai9wWGVqWXBQLzMzZnlXMllkcGoyc2JkTlZG?= =?utf-8?B?RlZsWjkyQ2ZTdkZmcHVFU2FRYmM1TFRVTzYzeHRGOFB0RW5hUjBWT2IxcUZT?= =?utf-8?B?cVJGTWdzZWhScXRxbXF4VTIyNU14NzF0SXlIMTd5dUFSaTZWRlExUjFNQVZx?= =?utf-8?B?RitQVy9rVEFtU3QrSktyTEJzenJhUjJpKzVKQVFYaU16d0VOY29uUXVvZkgz?= =?utf-8?B?RGFWUnk1SkZFZTZQRjBIY3M4clJwaFp1U3ZyUkFXdVBZT0VsNllsU245QTR4?= =?utf-8?B?dlZkT0RIdjRYYUdpSDZSeEFDL3k4VzJ2bitXTW9JSzNvUVZRSis5enhqN0du?= =?utf-8?B?KzdGcnBaMFM3RWdQQ2NVblQzVUtGeVJaTG5WZ2I2WHphYm5uZmdNdHRaK0xj?= =?utf-8?B?dmxoamVmTHRlcE9SNy8vTUJ0WXF6OFlZV09EeFg0LzZTQ2tCK0JFeE9EWFFP?= =?utf-8?B?d0w2WFBWT1VuMUdxNHpQM3BoYnhHSHh3bmh4dHBFa1V6anZ6QXJlOHB4Vmxn?= =?utf-8?B?MGNNK2NkTVB3MmplSTRYYXZQZ202dm9ndklWbkdITHZVd0NVcUhGaTJuZmxo?= =?utf-8?B?enhRSE12S0lqYzNpdFdONWdxT2lSdDltWlNlMSs3VVp6T0w2MGF2a3BORlhC?= =?utf-8?B?Z3JNcWRhVVk5VHBYTzl5TXowM1lKaDlqWHBBbEkweWRGRzFaYUduV2ZvQkl4?= =?utf-8?B?aGJZemRTMjJjQTVJRXpTNkFtV0swbC9kMklwM0VLLytJZWpNRnRoNGh5a2xk?= =?utf-8?B?Mm9peERLQWhpSmhXaGl0a3hKZmxOZFJTZjhadm1TSHpDUzdIc0xSSVVpaU01?= =?utf-8?B?M3NYOGx0STJRd3FFM3IwL2VWeStWT0JrcGFjZzMvRWZzVlc4NWJURDhvclRy?= =?utf-8?B?U1o0WG5TZWZya3hxT0hOaENwcXVnVndkNU1uZUxBL1dsOE0wcHU4NFF4bGlo?= =?utf-8?B?d2czMmJ4eVlCdk1rOHUxOUxUZ1VzcUFiSE4zN3pyUWFHb093eVJZdVZTWCs1?= =?utf-8?B?eGV2WGx3akhKb0VJcWRldW5KdGpVdkVqK0p2Tk9OZFFCM2dKNXRuVzFCQkxl?= =?utf-8?B?WnNsbzQvZFJsWFRWSGU0YlQvWklOTlB4Q1JibUhCZTBsb2JqL1g4QlFMOTNO?= =?utf-8?B?QXFTQ3daS0x1dnlsNWEyVkpyRW55QmloakUxcnVsdmJpNE9hamczTzloakoy?= =?utf-8?B?TXFpcTBXcG1EdXFRWURhbGY0R2tQdHo0NnBXdVV3blRQV3JPUEU5UlVpRVo5?= =?utf-8?B?T3VvL3o1cDU3dWp6OUQ1L3JPc1ZreTlubmxKdkVRLzRyMUhDRy9BVDZ3ZXFn?= =?utf-8?B?L2FObDR3dytOSHlZTXo2UTFtS2dzN0k4YjJDV0puTUN0dHphZFA1ZnBFVFV6?= =?utf-8?B?Unp2VUFHVmFFaDFLK0N3WVpuT3R5VGZKSmg0SlZSaFdUZEFqMW5UTzlhNEJu?= =?utf-8?B?M0JZQUN6Zjh4SzhoMHdiTXZYak9wcCt6QWswZzJXZmhoanJqcXdoL1VNd04w?= =?utf-8?B?UFl2N1J4TEo1aDIwSlVPSWNBcHN6cUlrNTM4MWtTVVU3RmtJM25tekY1bmpk?= =?utf-8?B?T1E0dnJxNzZzT1VaNEdTUlFCWENaK1hIQy9EcnZWOG1Scmp0bjRvK0NYRFdm?= =?utf-8?B?bkFsRVVIZEg1RldjK0pSczdlY2dLdlZSNU5CMHpadVAzWk1jRTEzRWZjc1VW?= =?utf-8?B?VWFMYWxkd3VYQ052Vm1xUC9TR2hkRXJoTC9rZnNDcDJEbG1wbUZyR3VkcGpr?= =?utf-8?B?NzViWWJxRllJTHo0dUUrZjN6cERJU0NBSzJrVTYwUktKRHFQUDhacWk1NzJa?= =?utf-8?B?Vk5rUXNTNU52Z1ZNMm1ld0FwSWVFM0lmZUVaNERYUkpDNDBicFJyQW5wcVZw?= =?utf-8?B?K2c4UTRDRDNOT2wyY0UrYkQvRnNYL1RSeDlqSHlZMEZnc1VZdE4xM0xLMzdO?= =?utf-8?B?RWszZEt1eUNla3RoM2IybDdPbGJTckZBaHBaR0FIOFBTYnFvS0JGMVNkZjRv?= =?utf-8?B?OWozNC80OW1uVmdwWGozK3g0YnBvM09nancvaWhvMmlQKzFqU0JIT05pc3Za?= =?utf-8?B?YTFoaXFVVUlsMGwwMnNBR3BZVGFCNHFoaHhqL3pzZ3lHbEhpS1E4Y2xpR2FO?= =?utf-8?B?aU05dnNweEVWUmUwbkhoRVBlNVVVNndrL2U2b2NTZVU5Y2VNVTl4YXVZTWQ4?= =?utf-8?B?Uk5rM1o3NnVhaEM0Y3B6WEh2NFg5UXM1RjY1QXQybmRFUEI5aXZkOUU3SUN4?= =?utf-8?Q?9Y7k1qghdo1sBG60=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a893f518-6c9c-4c64-6428-08dee0bc2d84 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:53:15.6381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uWbHtACn5pu1X9UxWi98RIp3YSBFcd5iz/SzR+W0Ybz5NoBtEAqWBVCb3s5jQlRGnIzNZtFh647TwIsVI/DwvPMXEVGn8DlNhpTOKWdywj4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9139 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Introduce FLEXCAN_QUIRK_IRQ_BERR quirk to handle hardware integration where the FlexCAN module has a dedicated interrupt line for signaling bus errors and device state changes. This adds the flexcan_irq_esr() handler which composes flexcan_do_state() and flexcan_do_berr() to handle platforms where these events share a single IRQ line. Also extend flexcan_chip_interrupts_enable() to disable/enable the new IRQ line during IMASK register writes. This is required for NXP S32N79 SoC support. Co-developed-by: Larisa Grigore Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Reviewed-by: Vincent Mailhol Reviewed-and-tested-by: Haibo Chen Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 53 +++++++++++++++++++++----- drivers/net/can/flexcan/flexcan.h | 2 + 2 files changed, 46 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index 8b70952f7f05..e7e3fb41f55e 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -1300,6 +1300,22 @@ static irqreturn_t flexcan_irq_boff(int irq, void *d= ev_id) return handled; } =20 +/* Combined bus error and state change IRQ handler */ +static irqreturn_t flexcan_irq_esr(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_state(dev); + handled |=3D flexcan_do_berr(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + static void flexcan_set_bittiming_ctrl(const struct net_device *dev) { const struct flexcan_priv *priv =3D netdev_priv(dev); @@ -1540,10 +1556,10 @@ static void flexcan_chip_interrupts_enable(const st= ruct net_device *dev) u64 reg_imask; =20 disable_irq(dev->irq); - if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) disable_irq(priv->irq_boff); + if (quirks & (FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_IRQ_BERR)) disable_irq(priv->irq_err); - } if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) disable_irq(priv->irq_secondary_mb); =20 @@ -1554,10 +1570,10 @@ static void flexcan_chip_interrupts_enable(const st= ruct net_device *dev) enable_irq(dev->irq); if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) enable_irq(priv->irq_secondary_mb); - if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { - enable_irq(priv->irq_boff); + if (quirks & (FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_IRQ_BERR)) enable_irq(priv->irq_err); - } + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) + enable_irq(priv->irq_boff); } =20 static void flexcan_chip_interrupts_disable(const struct net_device *dev) @@ -1881,7 +1897,8 @@ static int flexcan_open(struct net_device *dev) =20 can_rx_offload_enable(&priv->offload); =20 - if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) + if (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_IRQ_BERR)) err =3D request_irq(dev->irq, flexcan_irq_mb, IRQF_SHARED, dev->name, dev); else @@ -1902,6 +1919,13 @@ static int flexcan_open(struct net_device *dev) goto out_free_irq_boff; } =20 + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_IRQ_BERR) { + err =3D request_irq(priv->irq_err, + flexcan_irq_esr, IRQF_SHARED, dev->name, dev); + if (err) + goto out_free_irq_boff; + } + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) { err =3D request_irq(priv->irq_secondary_mb, flexcan_irq_mb, IRQF_SHARED, dev->name, dev); @@ -1916,7 +1940,8 @@ static int flexcan_open(struct net_device *dev) return 0; =20 out_free_irq_err: - if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) + if (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_IRQ_BERR | FLEXCAN_QUIRK_NR_IRQ_3)) free_irq(priv->irq_err, dev); out_free_irq_boff: if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) @@ -1948,10 +1973,12 @@ static int flexcan_close(struct net_device *dev) if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) free_irq(priv->irq_secondary_mb, dev); =20 - if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + if (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_IRQ_BERR | FLEXCAN_QUIRK_NR_IRQ_3)) free_irq(priv->irq_err, dev); + + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) free_irq(priv->irq_boff, dev); - } =20 free_irq(dev->irq, dev); can_rx_offload_disable(&priv->offload); @@ -2338,6 +2365,14 @@ static int flexcan_probe(struct platform_device *pde= v) if (transceiver) priv->can.bitrate_max =3D transceiver->attrs.max_link_rate; =20 + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_IRQ_BERR) { + priv->irq_err =3D platform_get_irq_byname(pdev, "berr"); + if (priv->irq_err < 0) { + err =3D priv->irq_err; + goto failed_platform_get_irq; + } + } + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { priv->irq_boff =3D platform_get_irq(pdev, 1); if (priv->irq_boff < 0) { diff --git a/drivers/net/can/flexcan/flexcan.h b/drivers/net/can/flexcan/fl= excan.h index 16692a2502eb..bbb1a8dd4777 100644 --- a/drivers/net/can/flexcan/flexcan.h +++ b/drivers/net/can/flexcan/flexcan.h @@ -74,6 +74,8 @@ * both need to have an interrupt handler registered. */ #define FLEXCAN_QUIRK_SECONDARY_MB_IRQ BIT(18) +/* Setup dedicated bus error and state change IRQ */ +#define FLEXCAN_QUIRK_IRQ_BERR BIT(19) =20 struct flexcan_devtype_data { u32 quirks; /* quirks needed for different IP cores */ --=20 2.43.0 From nobody Sat Jul 25 22:03:31 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 059063D6461; Mon, 13 Jul 2026 08:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932810; cv=fail; b=MaMFAc2+KJnjafJbjtk78BuO4K4pgQyFnGi2p0+hlKvo2RgFfpLTO6YEcXg7NdTZazEnwDlRkz6w0ASggQZzZCwjjJ+cPCy+1XcFXomqBD9OjwHf1fp5G4zOfvznnhk8OtxPILOmmmuUw071uyd4I7H7QRhj6QYFXcHFyek8tqM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932810; c=relaxed/simple; bh=9ygVd/9wOYBvYuQKxlnmXiqG0N3u51+iaQgO8LhlNIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=n3HWLAqKdkX41grAXGDVyiUsZ0CaunDCgkqYueJc+rCDTqRJtAgxoug8e82SWs2eMgw3/smMZbzA+xdZk4kZutUj9KtJh4Kl8uKSq0vQ2LDJcFQG6iD4UEotMJhpgV6vkj2d38gVHVy5jbCWYxuSZVEisM9p/cMV1EpmmSdh2V8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=cSl01qZ0; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="cSl01qZ0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=htoFUmDeCuVVW1S5jJtpHCZ2NPxi8R2jo0wX3sWqxUJ+QeynzT4A3Ss+wQIomU00QTFa5pfyO7SE1MqB5KCcWRbHTtE7Qs0/R43UeD6MDCW4tPZwFp6/a7hAn1m//7xjsVB5bRaF+BIocb1Ve0t8e3LDBvhn6J7L0Xn0QYXC/s2ptcNggvkUiKS+2EK97+vIFrCLxRiKL95ET+0cDXkFlcE/pUqhVmwBUVpQhZC5BQ88Y1BAfuikj2rY/dip+BjyILBXkZZfsgi78BCdkcay/edCaKx+X76h8aL78A5o1r2sEsVVrBLyON/C8sqaIpE7HKB0sgtZB+qlAmrl9CBnLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BICuwCHVHi03s3I2/r7mErJ4O70LPSuo2IX7EewVGyE=; b=KpkNdU96AUZ2cL906aHDgc82SmE7YuOhQhEEnodx7RHjmCcDqoRZ+8t733E7qrEMaPaU060btSPAE0PPjZz3OnMU7X8bD3UYfm4xCxdHB4FDbuFus5+MdSPT6FBQnsIoEd5+jRXlvp9Ho1jYEa3NmnJQebWxeODE53Wol1WAbBbOCBnHz9F6+A4Y61yQbh1Qzz+YK7BMHGvN28I4ToGD39m4DyPn86rOFhbWhh4seGR7feZ3YabBGsnsBHdFFeauD8TSSIWvzpMLitzin9UqwLjEwLsyy7C6FT4WK7B3LBXuh+jg8EsPBA4GYadwqopVFnmlALeF9c0Vsgga9du8Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BICuwCHVHi03s3I2/r7mErJ4O70LPSuo2IX7EewVGyE=; b=cSl01qZ0/Jb7tEG2u4LM3DKO676/G404fZ5M07Kwsx8H0u2phORet4rW+c1YHH6wMlKfsAmCLuOgLR4JfuV9rlJXpg2yQ4ATW3cuqecc6kx4MRpUU3V+/soFQQSCRQNeNyLtLRbDHUomgvTMml3Qp9NyJRG7GkP6+Zwdg5pgLcx6dElZ2Fub42ZP/3IdFJtaQeaYFCo2UV1oOeHjNXSjAs6h5j33oFHigT9vlQfmJIhw62sLqnZk5StR/ZHay071Jtfhc6LrI1Jn86IU15l7vNB4fMD2Aw2DKyiJ/WfsYhzTp/yef9tvzWHBPWg1MsKK91he15XP402btNI6TV6Vxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PAXPR04MB9139.eurprd04.prod.outlook.com (2603:10a6:102:22e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:53:17 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0181.017; Mon, 13 Jul 2026 08:53:16 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Angelo Dureghello Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Andra-Teodora Ilie , Larisa Grigore , Haibo Chen Subject: [PATCH v6 6/6] can: flexcan: add NXP S32N79 SoC support Date: Mon, 13 Jul 2026 10:53:06 +0200 Message-ID: <20260713085306.2643794-7-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> References: <20260713085306.2643794-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P190CA0069.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::15) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PAXPR04MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ae66843-288a-4590-1936-08dee0bc2e2b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|23010399003|376014|19092799006|366016|1800799024|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: wgF9pszZeJgMpeZRQydxn9aCupz807U2sZifa9fEadDaVqJEldqk++YUytvv28tmGOBuBH6HlZB6IdWV4WLkV/HjYdxIjh4RMeCJXliAbtgKVrI3/G4+WAHmDH6uRubhZLgucZFhs98Xc376YmpkFa486h7aJyh+3fFDKujg5kHazvioKsBJ+LuzvFNj5VIk7DavBZlL38/V+FYlXuXplTGjKsOG834LLGhrzqasXMjkAtJKhtaT9JuqsP7fXj3wkCaveSsnoASB1tWC9OxaPRpS/8YthtZxzhYCO2mh/haDl+VpxZHmfwhhlD7AcS2ikcPySU+iv514GZxe5s19Yde7U1e+CjQUHbaKDbw80qSyfwugmautK3KnyZ0eei0p4k+omz4Nw7Tek1YovzSIWBT+xC2TV9DeqxqcyL5xxcm1Og3CMwIes7gXRhGUvQaiyQ0/e7QuvtYVBeQAoyImizYIDnDwbenCwzJ+kacaxcJoLtDXvL/lyzZ8kWDpeYdogV2VbaDM8/QkZbusI8HjdcYAhsk167q8ta7+U3h4OnWchdnsyGV+/wCp6GF4V7qn1nDW3RSa3MRpqdJk2djOx+4aygXjPIFUr0/d/dBmtmt11uNXe6ZFy9/oWDOVz39pFEMZM8c6SG4vV+UA6kpPF+5VyprldSQtNm0AOC2x+Ww= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(23010399003)(376014)(19092799006)(366016)(1800799024)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2pTZ1VWUUc1S2NoWHR3aTJmU1Z4MGloTGZWOUt5RU5DTVZOT3ZGV2Zqc1ZQ?= =?utf-8?B?NThHVDZGS2Fib3ZyZXVudnlud243NWhuYTJ0VE1PVzdvVFlqQWFrWWRBeFdw?= =?utf-8?B?bStBL0FMcHR0Q1ZjRGxvQ0JpRkRXdFZsNnNmWVFFc3dUVFdJM09pVmpVeTQ5?= =?utf-8?B?cFJzZEZKMkRlc2MzSnVvZHBEVWw5YTFmRm9Ld3hmWnVEbGlCSWgxS2VqNWdY?= =?utf-8?B?SGZVeTRLOStLRVBnaUIrRXVoeG5vd1JxTEVPVUxLUnpzQnd0Qk5Ld04zeHlq?= =?utf-8?B?YXhyWEE5ajdqeVF2S1dlMC91UGJ2VHI1bGJlMGFZYkh4QStXbDN1WjFkUktC?= =?utf-8?B?dFY0MEpjNkZENTJCMHpjdWUxLzRaUnBRQXVRMHhlK2FZZzMwOWg5S3pUTW9x?= =?utf-8?B?YUJSaXVONVhmU1A1VGRwWGZEYlNkTXlsRU5sblRBNC9qZ0I2QzJsZ2llMmtq?= =?utf-8?B?QnVQbGcwbEhIK1JiY2w2U1QvQ2loR0pLM0oxNDJtaGxUSDVWcGxEaUhDWlFr?= =?utf-8?B?L0lLb0xZcXg4T0VKRkdXVjdxT1pDMTZETCtYTGxBSUtabnZHaHlTNDFDTGh3?= =?utf-8?B?QXppMnNNSXVYSXl0KzVWL2lsOWsvdEw1cVpyU1J3RmxsaUI2V3VhV2drMmVS?= =?utf-8?B?ano3RTVvQ1hhZElaWjIwSDY5Y21SRXBBQUVqZ3F3Q2Zsc1ZLWUtqV3A5YVdX?= =?utf-8?B?Z1l2eVJNd0x1UlpjVUZxcmhITC9qUVE3cmI5YWE0L0V0cUdqSGhRcjgweUpl?= =?utf-8?B?MEUzSFlOQTFWTmRJN0Zrd0dBZlAyNGpNK0ZjTHhWMkdyMEFaN3QyYlllR1lM?= =?utf-8?B?eXlRRjlvR1VpVzhlcklFNWR0YjVmR1BVeVhOTHdLTFJ4RVU4M0k3czZWNm1I?= =?utf-8?B?VVJZOUViNFlVMEJLT3NmeU9rODlmcnJzYU9SN25CK2RPTnBNOXlIWVZrNGY1?= =?utf-8?B?cUdKZzBXOTZaZE5XcTZiWmt1WmxlY2pBd1dsMlIxanZQSGdSdnRzSGFvMEM4?= =?utf-8?B?c3NrNzBxUzNDQ1pDUTJzTGsxY2tNajJpSU9XU25XcDh6bTg3b2I2NGhaeW1Q?= =?utf-8?B?RVgwbkRPS05MV3UzTjY1dzJYaXk2YjJXZTl6M3lod0dDQUMwR2RTZHo4bXpt?= =?utf-8?B?ZzRtekFyeUYwckwwU09pSlg4QW1hQlpyY2NPbDBsd29zdy85K0JRZm9TclFP?= =?utf-8?B?QXY4NUxCWjNUcDJqaUZqOFZwN2VsNlFIL1dHOGQ2TWNwRW9RaWlMeHVZcDkz?= =?utf-8?B?WTlmdHFZOGdSQjFhSm9CaEVtOWt1ZXpIT04xS0dUYytvT2RvdjQ4TS9Jc2dW?= =?utf-8?B?bTBCMDhxMit2RFR5V1FDaUZlVFl1Q2c1Qmo4N05wYzFvNDBUV2ZtUUp0ejRl?= =?utf-8?B?ZkFndjI2Z2JiRldVNG9oeDd2blU4K1l5bTlHNmJ5ZnBiY24yMGYwSEJNN1gw?= =?utf-8?B?Y21hdmRMbExqRjRRNmttdE5DTW5ScHI0RjZaN0hKbVVoRDVCYWxnSExxcndt?= =?utf-8?B?VC83S0ZaNFFnRGUzT2hUekVPazhQKzMvd3hSNTIvTWRwa3lBVmVyQjhOeXho?= =?utf-8?B?RG40TXFFMDM2S2FzdGVKZXBWeGJKUkNjMGoraVArUGx0UkpyUVFqZktPUFBO?= =?utf-8?B?YUxSTDlsMHFUVU9vZ2RReEFmZ2R5YzVCTHh5UGJudHVwQ0VIbzlHTjQwTmlQ?= =?utf-8?B?djYrWlV0NDJiV0w3MitGVU9HMTl5azhDa0tQOVJoY3NqU2FXRTJhYmw5b2FV?= =?utf-8?B?em5UY2hHUXA1RVRZWDgyNDRvYnc1MmFnWDBjZ0QwYTIxb1dZMnBUVVFaNlRs?= =?utf-8?B?RWY4MWZlZ3BPV1lLbHVocUlENG5QcWxoWDBnWWkwYWRqTGF3aGRldGM1c2Rp?= =?utf-8?B?NjJmNW1iR0NhK1pzMGgybXB4enFwOURKNGwreTJ0STVWbDJsOWUvMjF4ZDRT?= =?utf-8?B?eGVZeUswRitLeVA5UWNMRU9ROWwzSWtqNkZWUjZ4WWhiNzBDOS9aUUQ4STYz?= =?utf-8?B?WkpOTEVSb2cvK3F4azZ6c05yNThTVkZ1d214Y1hUVjdpWU5BQlY3VGRoaHlE?= =?utf-8?B?YWE5VGk4UkVOOER1Z0VqOTg3aDVnVVlXYmZuc3FOZHUyZjBRa0w4eUpwajNM?= =?utf-8?B?KzJvZjU1WVJnUkhkVTdncmpHU0NWUEZGa3NsWCtLaG5iMmVDaHAwZHEzN2Fp?= =?utf-8?B?UndsR09HeVNsVUNtWkkxOWk2bFd3KzE0TVRnLzNoMlNMMGtCMENCaC9wc2kr?= =?utf-8?B?QkZPSk9ZSlpnSlQ1enBCSXRlOEdKOGFJTnBhY1ZiNktlRmpVc0RJZUVBbGtp?= =?utf-8?B?K0tVMUhDVzkxM2FnUGk5bDdnOEYrUjdiNytCcGpVeDRHalFkdEFyTi9yRDdl?= =?utf-8?Q?kn4ZXatUYhCSKt0k=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae66843-288a-4590-1936-08dee0bc2e2b X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:53:16.8177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q043nVh6Y8H55GhLE/jGclYxjYqs0aTNs3zpOm4jDFkEtJ7+0ZLgA1/FH8jOPXlX9O/DquaqEoWRbe82PO9X0kD0EixwzWz7wDsbooEHPu8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9139 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Add device data and compatible string for NXP S32N79 SoC. FlexCAN IP integration on S32N79 SoC uses two interrupts: - one for mailboxes 0-127 - one for signaling bus errors and device state changes Co-developed-by: Andra-Teodora Ilie Signed-off-by: Andra-Teodora Ilie Co-developed-by: Larisa Grigore Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Reviewed-by: Vincent Mailhol Reviewed-and-tested-by: Haibo Chen Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index e7e3fb41f55e..54279b91cf5e 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -403,6 +403,15 @@ static const struct flexcan_devtype_data nxp_s32g2_dev= type_data =3D { FLEXCAN_QUIRK_SECONDARY_MB_IRQ, }; =20 +static const struct flexcan_devtype_data nxp_s32n_devtype_data =3D { + .quirks =3D FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_ENABLE_EACEN_RRS | + FLEXCAN_QUIRK_DISABLE_MECR | FLEXCAN_QUIRK_USE_RX_MAILBOX | + FLEXCAN_QUIRK_BROKEN_PERR_STATE | FLEXCAN_QUIRK_SUPPORT_FD | + FLEXCAN_QUIRK_SUPPORT_ECC | FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX | + FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX_RTR | + FLEXCAN_QUIRK_IRQ_BERR, +}; + static const struct can_bittiming_const flexcan_bittiming_const =3D { .name =3D DRV_NAME, .tseg1_min =3D 4, @@ -2222,6 +2231,7 @@ static const struct of_device_id flexcan_of_match[] = =3D { { .compatible =3D "fsl,ls1021ar2-flexcan", .data =3D &fsl_ls1021a_r2_devt= ype_data, }, { .compatible =3D "fsl,lx2160ar1-flexcan", .data =3D &fsl_lx2160a_r1_devt= ype_data, }, { .compatible =3D "nxp,s32g2-flexcan", .data =3D &nxp_s32g2_devtype_data,= }, + { .compatible =3D "nxp,s32n79-flexcan", .data =3D &nxp_s32n_devtype_data,= }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, flexcan_of_match); --=20 2.43.0