From nobody Sat Jul 25 22:00:01 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011050.outbound.protection.outlook.com [52.101.125.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3684D3A48F1; Mon, 13 Jul 2026 08:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929818; cv=fail; b=FgV9oG3/w3KFVH2tWBB0iKEAY0DKYWZ134SG9WfzOScysZ6HcNcOzveyafNlgOQv4MJPxpy+CEmSyQdqYyCX44lwaS6rjuGC8nDSpP//y5rJV2v2dyXkOkaW91THC9JKluL9olgboCO3q6uR6cxVLFavD8/3CMD+OQuiwDHVz4A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929818; c=relaxed/simple; bh=EN/WRb9kiwxpEdLDkMHPZxca36qwDROujW2CWAJMiQ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=NaVtO5TqX+iSaJY3juberp0dpSLtHKEtD9QKrTc/QoFQ6pVnAoiHPYjAkSio6Olv4pxJJjlKV3cg7T4SNoYG0dQPrxwSVKh6gsDdm6LX0nBxsNXHjG/AquXSNpj21a6xeEt7VXod/KoAgmMYkix5wJ4R4yvYna1/KO+TwjPjiPM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=PNLyo1ru; arc=fail smtp.client-ip=52.101.125.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="PNLyo1ru" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tzxreROahcuAW+dCy0jIbSus3ys3de5Sh+ZDexoQX9AzAA506v0kPrIPvAiVWF9vgNrlqaqnKt5KaAvF3LStwYXFWxJT0xI3NLcJ6B7i6B3nlUgpDFGcUZS/NzQO3HrchUYiCNR31iHsuR7jflQtAPcrOK//aO/hrKPs8GpM7RFPuh+oi1VgfRqwTpW4CmT9i0AXiuGPnkSuiPUQEMPu+KDSmJyx2f5SIT74CJfh2SOavU8WSDkEQBh7QOiMpl4nW7i5Xy+KMq3mJCphauDEaZ82zIsXslH9Ev16Z+Z5iluYmrue5PfYYIYn5cG1TMOJlmosYP7gM4oSk9ha3q5sAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZANI5/9ZKEyktP2x89FIdPQom6CXt2tLKOU1MeXjP4=; b=I5qOpezkeZLdcSZRB9ivqt1yEuS3SSh9BOcd0B1B94ckBBTOANyKBxgwfudUwQcglmFblQ63+udoc7fTeLgJDv0Y3+0aLuZ5xOykI2W6rh+lq0hwbUE+aKTDBzstzxS3e5BE511uZbiN2QRj4TokKNHpWEAXlo3rLrPdxpap3zy8AoRYz7sXYES3bftBPrKjBSg2EdEwOMkeCwazYwJi7E0N6op2xGjE9eG1nM/iavPGnb9r5TPf9E1S6CL08hEBKxBOb2dvCQ1FGJj5uvrMDm0TIHMR05RNY8QZawuCufYADw9drn0FjRYSp4Q8Jn2VMiVxttFmBlIsRpy67zFwkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZANI5/9ZKEyktP2x89FIdPQom6CXt2tLKOU1MeXjP4=; b=PNLyo1ru3QgOVQdTftFZsCE52CSr/00CFRyWyZjkN1qrOq58Ol17xSzIEceKV7z9rg6xgSVsn1+x44obU2BBUI7npsZUzCXcwWVecIt+hA1+/T4Ffg8xiBfM5zXXdjR/wRiXKWmLJDhPV79SJJqnPtqxEZiCElGTVo/kX14xBzQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) by TYCPR01MB11657.jpnprd01.prod.outlook.com (2603:1096:400:3b8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:03:31 +0000 Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828]) by TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828%4]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 08:03:31 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Lad Prabhakar , Jacopo Mondi , Mauro Carvalho Chehab , Hans Verkuil , Nicolas Dufresne , Laurent Pinchart , Sakari Ailus , =?UTF-8?q?Sven=20P=C3=BCschel?= , Marek Szyprowski , Mehdi Djait , Isaac Scott , Paul Cercueil , Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi Subject: [PATCH v4 1/4] media: v4l2-common: Convert v4l2_fill_pixfmt_mp() to static inline wrapper Date: Mon, 13 Jul 2026 10:02:50 +0200 Message-ID: <20260713080259.21835-2-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> References: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0217.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::9) To TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYRPR01MB13588:EE_|TYCPR01MB11657:EE_ X-MS-Office365-Filtering-Correlation-Id: 4022924b-23e6-435e-289a-08dee0b53adf X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|23010399003|366016|1800799024|3023799007|18002099003|22082099003|56012099006|11063799006|38350700014; X-Microsoft-Antispam-Message-Info: 6CUukg+j9uNIQbx6d/bG102Yax7NTrovI4Hk8SNge0AbuonBg9UUlxzzXliSGT/h2bfle2SvGe1Glgs4LPdQjklHBbGNcwqIFBS6mxJNKX6RoBMkPpgKswLgr7lIWD3dfmTOqcvUhA8ehEtI56DQTDsBawzTMEw1gEM79yN49oSfLL/Uo78gAPxlOHz6W5x7R9NSdmJ21FAXxypCO1x+Yjb4xhWri3E3QKHuecab+jRt1lmbGboRm23TmwSshZss1L142Qu1q44lHsr3seFujA4VkWP1piYguW72dDKPLeXttsOVNP7wmtI21uTV71SlvUF1OG8E3bORTIxzlnQNLhIz67UXhR+5ldPk6XG5TP1x0wUYPjR8uOyJC4W385vsXbAPdf0ea9qICa30J0sTypF2clmDUkUGp8xgK8C8+0cqwHmP2ZoBy0b/x6bvh+qbslwSzikMne6G7EYVA7DQjo2CPit6h1Pq60Msl2zbWka+D6klLucmPIUIyIEA0Yb3Fs+qdBvAjUE/ChflgY8Xe0vHe9Li4UCzX4Vp50EUogsZQ5fYSoIv+j0EraHyg2LBIAXdM81pfdSIeBuORheiSkwYnDyPmBWCL0ZX6x2xhWh96YPDn6gJOKFGCMSeBcjVBoIMDwTMekNnQAoc1P/Uyhhu8j+nEGZpikdfWTGxq8FcvdtCfV0lMNM3zJmpOlVgtnEaF6HGWM0vovCKh0P3L6ITyToaN6iUKp9qAWKIG/U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYRPR01MB13588.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(23010399003)(366016)(1800799024)(3023799007)(18002099003)(22082099003)(56012099006)(11063799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MWXRLsMRfqLD+tOkmEqfOGZRBHuENORd1SwFwa+BuXt/J0V4udIjr24SaaYm?= =?us-ascii?Q?yUZkKuNsokDZoiAIbBVQDb9hB/R0HGjFvPIM+mS7KTyfxGIS2t1skBqIhmk3?= =?us-ascii?Q?hgZBVymuYlw0pC1+IR9po6hckCk7L3mShuPyFhv7f+Rxxx5LkqcWI9Qz6eBp?= =?us-ascii?Q?nfzlZSJYCrw7AddMw+6MzxOTF0/qXpTYqIzCZ34WhF9GMpwFq6zB0S1ig0sO?= =?us-ascii?Q?g7RK3ywTxsqamYYC63H8NCJEJOyHMG2nXIm/cEKkB/th5Xt3TqXBZRr0yE3D?= =?us-ascii?Q?AOzU88jb0HXa/+6l9KIlIoPULjNy2OacaygJR1BzODXks3KYvZw09X1Uwb4a?= =?us-ascii?Q?XGlr1w4Zkb74Ty6E4WZqxB8fzTyX32OWEL80IrfBUl3Jw6a183ycwvswvCBa?= =?us-ascii?Q?RXvxDGeX8zfziIb+bGZvD325GLR0MskOLOjqM3xCRwzeiLpvfLiwzvZnGQbf?= =?us-ascii?Q?YJCv6Y79z7Fo5c1H0DcZ2Itnynfb+r9oTPWXyrzkpOtvSsfd2nXt5PklJFMG?= =?us-ascii?Q?xVSh+yCD7CrbPtaJJvAddQHFB38uuSkgoZ7xVoPYY5gsPAxsJyKK06f4e/RT?= =?us-ascii?Q?mQakcLL/SKHUJLEcADgw7ZndcsF1ZdhKvAZD6Ls9lCivBYoE0PMJpDwDZZW9?= =?us-ascii?Q?euzo/rDYUcnKm/1hyEbAU9rSRjhD/l1jGiwXXdQ1leZ6tuaquudZp1XgON23?= =?us-ascii?Q?/EtZVGtdrN2VsPSDWYrbHV/w9TGgUMAq67yhLKoOr4dxpCAlQz3oEFn9F6rE?= =?us-ascii?Q?ZLUeblW888Af/HAIUlMw7fBLUbvSk8IuLtFfdjf1Ft8aw44x71ydl5/J2T2w?= =?us-ascii?Q?cRGdGYQZIyCtLjBQrybzyU+erCsB+fm8BEx43jwxqqQ2WPEAvvWn9GqNx/1f?= =?us-ascii?Q?/kYiUuJD6w+RnN2eFdqh9Q0IjyMxvNpm+ebhmTbtL9VBUIqqUfRRrU37qMft?= =?us-ascii?Q?7xOauBNd9NE6Wgftb3JTifSKvrXQIS9b04+BDY5FGVsEqFQQQqLJ0n4opzWi?= =?us-ascii?Q?ZRbOkYNpCQfpeXbZ8kA2Fb1v73vJ5FdVPhwXbVsBNczXGx/AdV2RHWJJialn?= =?us-ascii?Q?5KcVYyAsaOVl4qv2+aWh6C0t0YtVfXRr/Ej1vt7DewBFO0x+zfk7c8j/adsm?= =?us-ascii?Q?f5hs2G/wpTxh0bx6AdSweHedz9r0BSVdr4lRYD2gMKXD6fwyx0q2GjD4TL0O?= =?us-ascii?Q?mX5lHputUh2VHn5eY4MK5iLofwk/tAgNfDuEDB/iHPXotzy2dJbYB3Vo2A3k?= =?us-ascii?Q?CExWiGDq98dU+xGTKAFZLEZsqX1FeyxHvaGjsN0QLEqNRVrDt4/Oc3Fw+9Mh?= =?us-ascii?Q?zbVeDiEQiPda3JTIDT/pv1Sn0l1eilL8nbesVcB0x96K3ATiBCBQQbaLf/Q9?= =?us-ascii?Q?y0W7W8PDNppIEfgHopLV/ktKTelewYL5UkOeF3lZAh1IcfP56ojhAhQEwdJa?= =?us-ascii?Q?jHYmZn+ADadYkLW1WHhkwFH+2NGSQCjBUKQUfW4EXQak4fjotmVohtlIdsd0?= =?us-ascii?Q?SpilAI/sZFdP45CBU9D7bXLEDDWk9auZiyijii638P3HlM16H7xyiqSYF5gc?= =?us-ascii?Q?D2X2MCvIXPFPk0XIrgXWtPqC4hFfYmBYKWRY+iE0wLZhjd/fJNbMaai6FUO2?= =?us-ascii?Q?/N/YgUTGoZV5VhB07b8QUfKpDUgqRxFX2WOx6jLb/hwttmT8ulIVk2pDWepp?= =?us-ascii?Q?EBMOhGbHqYYCZZJ7UGJSG3xLicVYHV3aHOK1FhIHlQ+qgyN06LjaCXVcdND5?= =?us-ascii?Q?bctaEvpRAP5BuHgntKWFp7Yso4WRIyEdA+I3KM/p8gs7eq0vPWV7?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4022924b-23e6-435e-289a-08dee0b53adf X-MS-Exchange-CrossTenant-AuthSource: TYRPR01MB13588.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:03:31.8007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rx1AYgE5CgFvwrDkYi0AawFoM2GJHxETC1ulogN91TtSefsSYVfrpEoPQEiHnciPlp9B6vvMgPf/G71Lfs1o4YJzibnRsouj5ZtxxphnJZQPbVdk3LJm7vTKwM2PWgyw X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11657 Content-Type: text/plain; charset="utf-8" Convert v4l2_fill_pixfmt_mp() to static inline wrapper: drop the exported v4l2_fill_pixfmt_mp() function from v4l2-common.c and replace it with an equivalent static inline in the header that delegates to v4l2_fill_pixfmt_mp_aligned() with stride_alignment=3D1. Reviewed-by: Jacopo Mondi Signed-off-by: Tommaso Merciai --- v3->v4: - Collected tag. v2->v3: - No changes v1->v2: - New patch drivers/media/v4l2-core/v4l2-common.c | 8 -------- include/media/v4l2-common.h | 9 +++++++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-cor= e/v4l2-common.c index 65db7340ad38..54995ba8c20d 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -537,14 +537,6 @@ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format= _mplane *pixfmt, } EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_mp_aligned); =20 -int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, - u32 pixelformat, u32 width, u32 height) -{ - return v4l2_fill_pixfmt_mp_aligned(pixfmt, pixelformat, - width, height, 1); -} -EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_mp); - int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat, u32 width, u32 height) { diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h index edd416178c33..749fe38c134e 100644 --- a/include/media/v4l2-common.h +++ b/include/media/v4l2-common.h @@ -556,13 +556,18 @@ void v4l2_apply_frmsize_constraints(u32 *width, u32 *= height, const struct v4l2_frmsize_stepwise *frmsize); int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat, u32 width, u32 height); -int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelfo= rmat, - u32 width, u32 height); + /* @stride_alignment is a power of 2 value in bytes */ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat, u32 width, u32 height, u8 stride_alignment); =20 +static inline int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfm= t, + u32 pixelformat, u32 width, u32 height) +{ + return v4l2_fill_pixfmt_mp_aligned(pixfmt, pixelformat, width, height, 1); +} + /** * v4l2_get_link_freq - Get link rate from transmitter * --=20 2.54.0 From nobody Sat Jul 25 22:00:01 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010057.outbound.protection.outlook.com [52.101.228.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 317F41F91F6; Mon, 13 Jul 2026 08:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929822; cv=fail; b=tCyI+vl3bF5a/CvlEn95ONdH0PtHYxwyuzPLoHtajZAoGAb4mGJMYGKQta6LoVXta0kT7ObmNih7vyJrEm+KMPjqT+VT9TZ1yWIk2rSPa1dvOAN+YLnIJ4/v4XgwhgfnBkFST6C/yvx00bLCVV11SPCl5e3SjegNyfAC8YRG/gk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929822; c=relaxed/simple; bh=wH7uDAZe/jIKhs3uAbHUxkIJD/FQCPD39w/34TVpyQQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PRuCDnuN8xe47yqF68paYLrryyoT4n/J5LNH050s8QthRbhTtgTTqy/+lU6bZuclBcvO+e1UXKAEU1cwbIPzBhK3Jfu8D4iZVQIizNa4sM6KxtXYgOeHqIlrAl87UXx1KK+AB6Y9uN+0DuZw+skgt/dfpuCelRwglhU+hr7sKfQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=BXJBdK63; arc=fail smtp.client-ip=52.101.228.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="BXJBdK63" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FCUgh4qU3Z3XXFb+FBTplm2spqk3Njxee1df/uEcgJivSQfwp9C/H6kVS0zTwnQLi83vw1x22F9f2oBZago3Czp27dHbHNYGZyGfaF+hSkOIyt6/Ch+BQcTKS9K22EX492Pek6jDbI/9oHCW6FLxdGsIbnA1fFAgcGi+oUuZX2whag3w3qNRLrTp166V+ZCqmqrFf+sJDrbSqdxGgb8ubNiSCGc6488+SnZZhbOtLkmWkgZUo/CElXI1l5K007OIfUbeNrfuGv69FXvL7G7bGoGUvElNUutV03LUN2e734CnNh1YkuPRu0WqG0ZNTiVsqaozEBJbl7fQQ9s/PbL2Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bD5dGqEUMoPwY8K/+RNQUbFOHb60hk5E2kSUIJIJyBw=; b=fZJS/vBzspV1HVMhLCJzsjog9ysHPZitsSJrwNbvN3Q6HdqVD7MXzTaJTalRwuuUf0es9iM01i5e8ks6jCaxVyhBvQnXNOc/cTdRzEMhBlV2KOPyRg0IZTdMFd4oc6OSFoQOCY7I8LroMLJU5oVAzowdwzayiUEKC5v+ig2KSWq1TsrDVDkxOcKcNe53GL/pEPdhAAhxvjHueOg2Kf+WFbUF/Ee+IsWynzo3nsUTil1ojRUNqEwdEXl62rvFBVawaaGQpt/39Rkyt1+EWyIWPYCLfxlK6o6P7e4NiNEFnDU+I+j9n9MUbAyPknmMCDuMr9aTOm8kg2sPvEqlh6cFHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bD5dGqEUMoPwY8K/+RNQUbFOHb60hk5E2kSUIJIJyBw=; b=BXJBdK63Okg+7OqjzxNsJsed5qLzETToZs/LFl6AhYr8nAgVs/vdcQYTGx7qK7lY0sKk5y44aolS6YOh68rpafNqCZWQDQA8cU2W1GkqBz9AZDJIlbYgIjXH/EWKgkkeb00owblg6qR7N0KrGbozK59tUoJLBR6bhEAFg0qUSHg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) by TYCPR01MB11657.jpnprd01.prod.outlook.com (2603:1096:400:3b8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:03:38 +0000 Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828]) by TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828%4]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 08:03:38 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Lad Prabhakar , Jacopo Mondi , Mauro Carvalho Chehab , Hans Verkuil , Nicolas Dufresne , Laurent Pinchart , Sakari Ailus , =?UTF-8?q?Sven=20P=C3=BCschel?= , Marek Szyprowski , Mehdi Djait , Isaac Scott , Paul Cercueil , Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi Subject: [PATCH v4 2/4] media: v4l2-common: Add v4l2_fill_pixfmt_aligned() helper Date: Mon, 13 Jul 2026 10:02:51 +0200 Message-ID: <20260713080259.21835-3-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> References: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0217.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::9) To TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYRPR01MB13588:EE_|TYCPR01MB11657:EE_ X-MS-Office365-Filtering-Correlation-Id: 80f2df35-c4f0-4cd8-6d28-08dee0b53ef1 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|23010399003|366016|1800799024|3023799007|18002099003|22082099003|56012099006|11063799006|38350700014; X-Microsoft-Antispam-Message-Info: RAbOSlyNxYQSi5R9fKykNw/zfN08ofVeGnI4n+7UFCyMzXJUAD+G6aljdrDDxOvzqwNLts51qYbIAzIJU0nTKXdvr9DjD2mFHntidIaBidisXpLjj0IIEZk+kEg8VbZtg2KY4QEJEHha9KjkDDYokqNDuZyezmXjN0uadYMl23uGJVGIMRUBCsg2DyoDTdQEmqHrnOi+uyUUSuxbsY5Jz/uvKfKcMFjyMGkbFBYoCv5TC6GdlHqwttWIWksbWmdZzYUvN1GQcBNX8D0iQ4PpDsW839uFhpXasmzzzXoyzlv9MVCxuqRbc78tDFtblOS1cd2sI2gZjfy3rbCtT0eA0Ji/gDTFOCnYkyPZcdcozE/SXp2eU+Sor5vLx4ytD2cakYHI3Yn7dGHGWKP3C/Q8V+b3OjCPj3KyRTcPFtBdDjaPnhqEg2gTRoqTOqX6Jm6ov9nz4gLCWfmqpRp1sr+tUvqOJ/W/a8IkJW98gUODdmjbDP1nQyFr3f4GZmlpgE3oAcIk2a+0YV7oNQ6SU/xz0dkZPzO3pqOl0Z2hlipqQF/BlsR3/fdzkkjwBQqRyPHwsubCJrEDvZENI2krce4ftoIlzMwUCINGUhnx3sUcRM6FlqZPO1XJnTmziIcKM53ZAbRX2tYMOgpuCm7i2gIF8Ay9CacX+WksumUWGtjsXP8hoIUUjquJXp9zrTAIAqujNpkahnUOaV6RaBDIeZWB3g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYRPR01MB13588.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(23010399003)(366016)(1800799024)(3023799007)(18002099003)(22082099003)(56012099006)(11063799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ovcKdIjXLHgrywJjWhfOaH5S11y8JMzYHCxmfgqbn429TtbYH9Jc/M5qp7XX?= =?us-ascii?Q?7ROhbeFZTY4oCeENC5G/vjJPOGSLLuOly8+vs1EYW5ufePlQtx0Twzy+MnAF?= =?us-ascii?Q?mPyFA5PcvBm5NP+vUjEy9Nv+08Wvgd2bkw1586M5AJ3UZiv6W3R/vZUTO769?= =?us-ascii?Q?8/in/TwzTQjldICvGf0wGgaiMhOk2BykGAgQ1umLRLmYwJ3IbBd6Yb1i5UGd?= =?us-ascii?Q?JJqlHsPsgmsuAl+CObFbxROMNGxaVDVvv1tnhvkSxC2VdyHB0koexJnFTKqi?= =?us-ascii?Q?oy+gyUgLWrvMwpmHQFry4pTdD6+11fDFWPlHfnC73ObPjk0mUSz8KBNy8+VJ?= =?us-ascii?Q?+PdMQrReykdlM/b9NS8dSTW0kFPQpJwqsCmCDyhKFyBt0HuKxWqLuIQCF/KO?= =?us-ascii?Q?2IgHghtUW9hifUgIaqo3gIdYQRoPwlJgTXDqxYOYTDyCAs88GzS4VjMV0P1T?= =?us-ascii?Q?cI0jRfyogv/XnXpbzKmd+5cx1Fbg/kSXuZcKB39dqzbXmzHnMBOnzWZxrKG8?= =?us-ascii?Q?/vFjic5APl+4yiXzuYwuWTet5tuwHeWYP6nOnG1JSNwviTOXktbFuiSnxYfd?= =?us-ascii?Q?W2qO4RvFCT75bDXhwbJZ7Gimdy/iYWSComa27HU49bKMHoKfgCVg2CkqqEJb?= =?us-ascii?Q?vGnwRMxXUH3+p3qyIS7fTAsiPqdxV/jVhAMG2MxjJx9BK3ip5Y1uXUojwZnR?= =?us-ascii?Q?HWmQB6b9KUjicD+RG2x2lRbZVj/DeNUupLKectxyTAvXs6Qv0+cv0LdBfDqA?= =?us-ascii?Q?r35EVSDO2nTWLwyv+iXphaHlH9tjCdOrNJU6+Ld5d8+jAJEd393sloeYm/jC?= =?us-ascii?Q?YXxHO3F6RoTaWqmNHpvmJcD6UcnNdh7SHn7m5E8clj2Kiv2WhGkKayouVJam?= =?us-ascii?Q?Z6h19gOtA4SSkmbzPf7FUxJBOX4mrsb5IaR03+MDPB6qU4dYYd+lE1426yL0?= =?us-ascii?Q?RBzg2o8Dq/FjKvn1xHkncm/fk7g00YCHAjdbsBGrHvv8BFPJBjvtgubz5y1Q?= =?us-ascii?Q?bC5ttiX0a7FAkutmY6IDBrQX81FXZzZAglA0K/cJWoABcvo5vDh8bafW2YyU?= =?us-ascii?Q?joDJbOiXJNnn96lEMBVE7hAKelmHfF7epLF8zXUMD8T5LSIib6/9uF4SFdgW?= =?us-ascii?Q?sS+9xaCM3guJ++OVb2bIS0exC6gr6ZpTL0S9nXOz6bM+6kWD2pHePxGD2Np9?= =?us-ascii?Q?p0x5tksAzSPzeyM44cN3csDhJRqg17quFepalHN3rMOz0pg7K97fzdHZMkvO?= =?us-ascii?Q?DvXDqUySCuNdLy1A8exyVvOXl2SX7HGhK/3KAo1nDGFU2nftN7/auKC+Loza?= =?us-ascii?Q?DABHXqvWO0MFetpcJ1kOiPh7FKYTDe/ZfA9HHo2q4TQdburhYDw0j8qexVVq?= =?us-ascii?Q?HWtBp/joUoX1Y1UxWLqxijbXs1HxqhxPIhjQ3vTI0nWJIy68JaU4LEYd5Nts?= =?us-ascii?Q?zwSc5XSzq+OcUWUDdSWxiaSDX8GDaH7bB8fNQ3QEVcg8p0LQrTqkLx0oxXkC?= =?us-ascii?Q?gDzTgVaocOyZkFjgfVEqwVR2MZ2eUM6CzNC5hBf8oVW+UFwvlf6Rpj/mArwV?= =?us-ascii?Q?Ijst91pTlagPnxfVu37kOnTpZ1azDHCar8t+GZ/wpjPNqpguotkgocH0+KJt?= =?us-ascii?Q?7ZMarTfZz9HwiXPSPGugelwwcv4ew8A3gbIBkl+V6b9vbYYzASZilwIQKTYN?= =?us-ascii?Q?y8m1xuOoR6/7pCwq6m9EVHy3yCMiSHZLgDU25kS9/+havjfltknXQvPbHTjX?= =?us-ascii?Q?FDk4OPhVCGr55EVbzOtzHYou7yUp2mRQ4jeZW8S3cmuWA7RG62hI?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80f2df35-c4f0-4cd8-6d28-08dee0b53ef1 X-MS-Exchange-CrossTenant-AuthSource: TYRPR01MB13588.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:03:38.4910 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: msjLbegJCB4gGSlirV+g9g3yD2V+5LC/KZKAqbe7RToey9G3RBom3DJqM+67j9hs35CZO0iur9kiYbHwCFrqTgvFOKSm0XhxDTQSHzLwzncSkM/F3PKzdX7LM58w+zAr X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11657 Content-Type: text/plain; charset="utf-8" Add v4l2_fill_pixfmt_aligned(), a variant of v4l2_fill_pixfmt() that accepts a stride_alignment parameter, mirroring the existing v4l2_fill_pixfmt_mp() / v4l2_fill_pixfmt_mp_aligned() pair. v4l2_fill_pixfmt() is refactored to call v4l2_fill_pixfmt_aligned() with stride_alignment=3D1, preserving its existing behaviour. The new helper is needed by drivers whose DMA engine requires the line stride to be a multiple of a specific value, such as the Renesas RZ/G3E CRU which requires 128-byte alignment. Reviewed-by: Jacopo Mondi Signed-off-by: Tommaso Merciai --- v3->v4: - Collected tag. - Removed "." at the end of the function's brief description - Removed "component" from @pixfmt->sizeimage line - Removed wrong tab - Fixed example (e.g NV12) -> (e.g. YUV420) into function description v2->v3: - No changes, just moved to from PATCH 3/4 to PATCH 2/4 v1->v2: - Move v4l2_fill_pixfmt() into v4l2-common.h as inline wrapper - Add v4l2_fill_pixfmt_aligned() helper documentation. drivers/media/v4l2-core/v4l2-common.c | 12 +++++---- include/media/v4l2-common.h | 38 +++++++++++++++++++++++++-- 2 files changed, 43 insertions(+), 7 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-cor= e/v4l2-common.c index 54995ba8c20d..2ce4f1c20fbc 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -537,8 +537,8 @@ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_= mplane *pixfmt, } EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_mp_aligned); =20 -int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat, - u32 width, u32 height) +int v4l2_fill_pixfmt_aligned(struct v4l2_pix_format *pixfmt, u32 pixelform= at, + u32 width, u32 height, u8 stride_alignment) { const struct v4l2_format_info *info; int i; @@ -554,15 +554,17 @@ int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, = u32 pixelformat, pixfmt->width =3D width; pixfmt->height =3D height; pixfmt->pixelformat =3D pixelformat; - pixfmt->bytesperline =3D v4l2_format_plane_stride(info, 0, width, 1); + pixfmt->bytesperline =3D v4l2_format_plane_stride(info, 0, width, + stride_alignment); pixfmt->sizeimage =3D 0; =20 for (i =3D 0; i < info->comp_planes; i++) pixfmt->sizeimage +=3D - v4l2_format_plane_size(info, i, width, height, 1); + v4l2_format_plane_size(info, i, width, height, + stride_alignment); return 0; } -EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt); +EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_aligned); =20 #ifdef CONFIG_MEDIA_CONTROLLER static s64 v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler, diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h index 749fe38c134e..4e5c5ffaf651 100644 --- a/include/media/v4l2-common.h +++ b/include/media/v4l2-common.h @@ -554,8 +554,42 @@ static inline bool v4l2_is_format_bayer(const struct v= 4l2_format_info *f) const struct v4l2_format_info *v4l2_format_info(u32 format); void v4l2_apply_frmsize_constraints(u32 *width, u32 *height, const struct v4l2_frmsize_stepwise *frmsize); -int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat, - u32 width, u32 height); + +/** + * v4l2_fill_pixfmt_aligned - Fill in a &struct v4l2_pix_format with stride + * alignment requirements + * + * @pixfmt: pointer to the &struct v4l2_pix_format to be filled + * @pixelformat: the V4L2 pixel format (V4L2_PIX_FMT_*) + * @width: image width in pixels + * @height: image height in pixels + * @stride_alignment: stride alignment in bytes, must be a power of 2 + * + * Fills all fields of @pixfmt for the given pixel format, dimensions, and + * stride alignment. Only formats stored in a single memory plane are + * supported; returns -EINVAL for multi-memory-plane formats. + * + * @pixfmt->bytesperline is set to the stride of the primary (plane 0) pla= ne, + * rounded up to a multiple of @stride_alignment. For formats that store + * multiple component planes in a single memory buffer (e.g. YUV420), the + * alignment applied to each component plane's stride is scaled relative to + * @stride_alignment so that the chroma stride remains consistently deriva= ble + * from the luma stride. @pixfmt->bytesperline therefore reflects only the + * primary plane stride. + * + * @pixfmt->sizeimage is set to the total size in bytes of all planes. + * + * Return: 0 on success, -EINVAL if @pixelformat is unknown or uses multip= le + * memory planes. + */ +int v4l2_fill_pixfmt_aligned(struct v4l2_pix_format *pixfmt, u32 pixelform= at, + u32 width, u32 height, u8 stride_alignment); + +static inline int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, + u32 pixelformat, u32 width, u32 height) +{ + return v4l2_fill_pixfmt_aligned(pixfmt, pixelformat, width, height, 1); +} =20 /* @stride_alignment is a power of 2 value in bytes */ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt, --=20 2.54.0 From nobody Sat Jul 25 22:00:01 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011030.outbound.protection.outlook.com [52.101.125.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC6D1CA52; Mon, 13 Jul 2026 08:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929829; cv=fail; b=ZaFTfZVLx7feJMxmRlFdSMIJj6fTI6dJItJMJRvHi8tPWkx2NgiRFdPh5HRGLdcPHO2dhfNd4bpEsLz5a1Gx8rI7hMAyxBffRpQLfVjtx3/Y2ysDVWc5vvJjpYHgZH48BFHJUd8gNJdEKuQgtyDKQZDQHqlZAtnDCwTSDWSbXF4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929829; c=relaxed/simple; bh=3PauuHuWbAY8glQdpGNO7ZmxumbrXFDVBamhCrvRWNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XLM3KX29Ze+LA5cgxbBpF2iX8cGQ7zJRKqO5wYfICjwfF6rZsdAjlPGzmPFRCF9Q8Lj/J39eHJUztS84KEX69Nj7yY2HSDIBm91oFyf6xjiIgCTuEYNyh5HhEcJ4qEI40UDf2lx0ikaREQ0GX7DqlvNQ4RzE5xsUPYLdKXts44U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=Nz5QaS41; arc=fail smtp.client-ip=52.101.125.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="Nz5QaS41" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vufj20daN/ETtEKlPQdXC1mtgC413Df/XWv8+vubpQtkGGE/8dzlmE7R4BqJ6CVoSS5cyn+P65tAppldj6Z1SANGioJhJ0acAdU9ateoz5Q/ci9pxR1zmjItZwdOyENrFe5/pDDMNQxGVzehg12ENs21rLpe4ZWIPK1FKN0zXf372bEq+um4c9c15zkQMSloRwz6nIykK6w9T5gKJRQ8RT/nLBIQjnaIhgeuUBWeyl4kX9/L6VQJjzFPd1d4wqCrEmsgM8MphWTgw4UXZ9lumtg/pY2GecVf/q/x+EZVRD4195jQzBCUdn51flZyfHUfoFbSb1vgw9wuX/2MtF7UbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fZg7L00OhcXovjIJCrw/T+K+ShziKIFkz73JhIy8jmo=; b=L0/GH8WIA/A5watWCjI8xXyWuVUJhRBSfjj5F9oC6CLtRnjeq/nIDzlqizE8ukbeaDOPyVkR+kxub9Yr6N9KmB1PKoQRZezNEU2wCGUHPWdgO2maaij35Q0QHtEFVqbswh94wc5e/NpgRfCuZvjOmNsZgIS1pIX/WTOjYW69M2kBIDA1gHRwpiZsUHpEA459r9UEUvqgLJ24PKPqn0XiOnHnLc/B/JIvUwDIx/VqFW8qKFs7nFcVMJeIOBYClS0EcEWMPmACDxz/+F23l/v/OLpYpplU5l2ZyeE0bRiskAefTOaQ1TKkGoG/BNF5Nxc4T2dZW4XAYxP8dV+z/vS7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fZg7L00OhcXovjIJCrw/T+K+ShziKIFkz73JhIy8jmo=; b=Nz5QaS41UX+mToxSnUIEUpmQaSMEtFx21rEuGe+PyrgXonEoSgym6+9kNA+YjYRE3V+iKONrruSqZKiUl2ItNk6KbEgBiKqkFu3Ld515YRalFgLWR9MqZHQrZbKcSEXJgL/hGf/nBpibr7BV5Hyv4j6n6Wy33gSBeaGMl4A9Kws= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) by TYCPR01MB11657.jpnprd01.prod.outlook.com (2603:1096:400:3b8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:03:45 +0000 Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828]) by TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828%4]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 08:03:45 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Lad Prabhakar , Jacopo Mondi , Mauro Carvalho Chehab , Hans Verkuil , Nicolas Dufresne , Laurent Pinchart , Sakari Ailus , =?UTF-8?q?Sven=20P=C3=BCschel?= , Marek Szyprowski , Mehdi Djait , Isaac Scott , Paul Cercueil , Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi Subject: [PATCH v4 3/4] media: v4l2-common: Add kernel-doc for v4l2_fill_pixfmt_mp_aligned() Date: Mon, 13 Jul 2026 10:02:52 +0200 Message-ID: <20260713080259.21835-4-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> References: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0217.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::9) To TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYRPR01MB13588:EE_|TYCPR01MB11657:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c9324e2-088d-472a-9a56-08dee0b542df X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|23010399003|366016|1800799024|3023799007|18002099003|22082099003|56012099006|11063799006|38350700014; X-Microsoft-Antispam-Message-Info: jgSlwF2vlyy2oFzQWAS9Qq4/AoZL7IRArpr0BxAO+yvfwEECFPMQ9AvUKv1D6cbpJEMkHxujHdaczhJPQdbUYbmGbbjUG5llGnUgxPwgBLUkmkCLaSQLbhbYKOYiob5JTrX6AyvuDlOJZrkW5A7dEduLqj/MRTYf7rETMp/3pJty+hcDyjUqvowq/z22PzXy7K+xaF2DW4mELDOOzYJwrrm1vdjijYLB0uOP3607OsJw/+Y1wiOjLd2f28CiX82kWGKCDuMVB/lALRNlDmPPqqLGG+vZG4M5syffudt5KuPaDt6g0/hnVNBXXucOn/v0m7Zt+OxH7n3srgKPzS5NdmED/LGH7QFiXmGxezUZtEzEzDaC+U8ry2YRYb+i8B1QLsOl4GTSWww4fkdvezfz/lRQ7hUSL8mbgYp5fr43+bVG5qdPQ+3mUvFu/J2rGEQC/UVNC7JoOYoQdDBSVUInW8fj71bnkIZoeeu8KuzbLs4qkfBK4MVzYHYvpiMiK8kbFxI8POOj9gM18QihbzPto0LS9gKrELs46PVbow3zXQIwDL+C3OuK9RZ8kY9/UzB5uSbIuD6xt89YTyOPttHBIFnFY8fuPq+p7rqTWeaQqUCZjnIjtmgmnp+Sy/PZddO9rlsxNdbTlNg0DKJtbG7SVulbftqcEPRzvRMzNIUxnHr6GTFag0cUjIV9AqmWgx6LfL/14R8CzCoDUk25ZVLtwATG11p6P6sVOBtvzLVq954= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYRPR01MB13588.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(23010399003)(366016)(1800799024)(3023799007)(18002099003)(22082099003)(56012099006)(11063799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QitqeEprbVVmMEtpMGFPTExDamZGR25TbFkxTHFxZElqUU81eGxtQ28vZzd4?= =?utf-8?B?Q0N2ZkVuZlNpUDVOZWRGY2twWkxwbGM2cTZOdVZKQmEybDEvSWo1Wmt1dlBQ?= =?utf-8?B?K0hiM0F1OE5Ubmk1VHNyN0xsWWFuaEo0UWQ0WUdVQkVHZGpFMUkveTVvY3pS?= =?utf-8?B?MllZN21acVBFZUx0ZEFtNEx0VllnVkxIcUl5ZmgrWWd4Z2RJTDFmQXAyTmZT?= =?utf-8?B?UllEMG4rR0VRbXB6NHlDbnZUaGQra1NnMFcwL3RXQ2VkUjkzTlVhTHhPbWZj?= =?utf-8?B?cERLTlNUc2Z0SUhJSkhPNGtMTFlmQjVNb3ExZ0MxWVZEaTJxblhRR0M0Nmww?= =?utf-8?B?dThwT0xvQnJKZ041T2d5MmFhdUZYQXN3cEtqeVZUdXpEMTliU0hYRFVLbHJa?= =?utf-8?B?dnhoL1diWHpHRk5uM3pQVmRGcXV2eXJsZzJkQndDTVRFdmZtdDZtZXJwM0JG?= =?utf-8?B?QzlNTkdtOUJwS2gwQ3E4Y2FXZjQ4ZG41ZEJSUUgzQmdra1hwdndJcXc2NFNP?= =?utf-8?B?cktGZmhpcENmbDBESEJzYVYrMm1QRWdLQ01qTVltUGdOTG1xeUdHQkQxTC96?= =?utf-8?B?RlFpb0x5VzZBZTAyRW4vNzRVZkVGRWRFOWtFQnhIeUYyUFhzNVprc1lzcW1X?= =?utf-8?B?Y2lLeHZQclF2OHNCQXVFNXdrZWpMNHpIVHA4WDJ3VmJwU2dXMUJGMUEyd0Rr?= =?utf-8?B?SXdSTTlvTEFXWUhwenZKTDFiV0MzOFAxa3Q2NXpPR3JaWHpLakRNa1A2ZU9t?= =?utf-8?B?REJ2Q0hJc1BYclkvTVd1WnZWRmNSTUhkY2JNWVdQRFRZZmlackgyanJNcWd6?= =?utf-8?B?RnlTTS8xQWR1ZDEwZHdXYkUzajN5VEZIMWo4T2VXQ0JhWGdncDBiQTFGb0pJ?= =?utf-8?B?eURkNDBnVllpTnNRbWZRUmdqUS9jVktHVzRtbHMza0szVnM4MTMvYUdGMzZV?= =?utf-8?B?RzVCVk10N3lKUVVEa0JoeUcvYlpuMEd6UWFCZ0NsUy9IcC9tK2JNeDRYS1p0?= =?utf-8?B?SnVQbDVoM1N4SUE2OFBydWNyYzR0TlpkbU9DL2xhREpXdHppT2w5WVc5cVI4?= =?utf-8?B?eXdjZmU5aExGcHVxbjNVKzIzTDlMZFVKWDVmYm53WWJWMld0OGxNMDVUbHdr?= =?utf-8?B?L3J2Y2VWZGRLZTgyMkdvL2hRVEVOMlZlUW81UVgvSEVKNHN6MFl1VWVXU2xm?= =?utf-8?B?QTRNemQ5Q0NEYmlQbWhUOTVObEJhV1NaMjZlbjVCWU9obmplaHlJeHQzK1Jx?= =?utf-8?B?Q2UvaDhJT0FMUzArTlRoZThOWEhXRmhtVTNOcVNJMW9lT0QvczRPZVk0eXFV?= =?utf-8?B?TGNBN1pSL0czclJWd2MxQk91aGtBcDB4TXJJUkpaOFFTQnRpYWE3YlBUc090?= =?utf-8?B?UnhMYmYwREUxMm5WdzRqZWcvcGtMYnhyby9NVFlLUTd0MmNWUHh3c3ZXb0hm?= =?utf-8?B?VGRjM3NJb0FSZWNzK3VQc1B2NlMza0kybUtnUTlad2RkVHpjWUtJaUxGekxY?= =?utf-8?B?ZGs4ckVEMGE0SytTUGtBVGUxSnlRSE1VQTlBU045S25Yd0R1MmpDVjR2V1c2?= =?utf-8?B?UVpGSjZNNE45bUc4eGF0V0RGemVVYTgyaTNGQW9PVDlXTlRvWmozbGxiSVJ1?= =?utf-8?B?RkZCdWtmMTlpS2JIYzF3bFRES1Boa1NzbkhiZ2hnK3ZXQlJZVDdSaWtSMVNr?= =?utf-8?B?SjFFUFF6YnB0WDdLQVk5OGJnejZVYWh5OTlXemZIeUtUVlJ1VFFZNEt2MkhJ?= =?utf-8?B?cDdRbXZzR1NEVDZsVGJXNU1rcG9hdCtldWhJeEhxYzg5RUdNODVFOVdYbWYv?= =?utf-8?B?Sk9xb055UitvbVM2c1pxQzUzcGx2eUdWR0x3Q0k0STRJV1FsNFdRQ1QrMGpz?= =?utf-8?B?NzViODlvaTJVUGNlcFpuWVdrOEJ6MWRVS2hSN3hIc3FhRXpESEpaWHRCRy9z?= =?utf-8?B?b0ZlU0ZOZm55elQ5Z2FLTmRjZ0x3SG4waXBRWEw4WUVuekJpYWQ3WlZ6V1h4?= =?utf-8?B?dnZ5cjFUTjlhTDFadmhtMTh5SlNhVkUxeTFQNjVoMjZ4UDBWcm1TUmZWWFR5?= =?utf-8?B?a3FxMzB1U1VxQUJ1WHVpcFVreTNDU0V6aVcxWlZEUnhMQnUydDlkeVJ0WXVp?= =?utf-8?B?UnQxaTdmbzJWdHpGVHAvdTVWa1VtaUMyTU1PZHFPbnZ5aUJ0dDhlK2dXZGpn?= =?utf-8?B?RmREQ21SU0RhUjRaeUEwRlVPUnRDVWwvQjZFcDZiU2VaQitOTEhybldPNUF5?= =?utf-8?B?SSt4YTAvT2lDejV3K2FxbGUzemllMEpxeXhlSWhicE91ZzRHZGF5NVlqaGNw?= =?utf-8?B?alB0RzUySmlSMW5veEpMRzIrWGtPcHpkTHJRcXpsMEVFS2t2OGtJaWhCMVdG?= =?utf-8?Q?UaRWrNwoThrwBNIBdh3Upc7H5CCHmDQWUEHtL?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c9324e2-088d-472a-9a56-08dee0b542df X-MS-Exchange-CrossTenant-AuthSource: TYRPR01MB13588.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:03:45.2177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kla2HXqzZ3B4iYrUc4M1pTbrJvfmsgzfpTNyhJDfVBDxztAfLXwwhvZOK1nL4hgTjWe2WsWvn+Sg3t2fCiN/b1+RvoVfJSFeZFAuDCzTendEjx/54qUVzZA/5gLdcc9J X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11657 Replace the bare placeholder comment with a full kernel-doc block documenting all parameters, the function behaviour for both single memory plane (mem_planes =3D=3D 1) and multiple memory plane (mem_planes > = 1) formats, and the return value. Reviewed-by: Jacopo Mondi Signed-off-by: Tommaso Merciai --- v3->v4: - Collected tag. - Fixed function documentation. v2->v3: - Moved to PATCH 3/4 - Fixed documentation as suggested by Sven P=C3=BCschel v1->v2: - New patch include/media/v4l2-common.h | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h index 4e5c5ffaf651..33f5713734cb 100644 --- a/include/media/v4l2-common.h +++ b/include/media/v4l2-common.h @@ -591,7 +591,33 @@ static inline int v4l2_fill_pixfmt(struct v4l2_pix_for= mat *pixfmt, return v4l2_fill_pixfmt_aligned(pixfmt, pixelformat, width, height, 1); } =20 -/* @stride_alignment is a power of 2 value in bytes */ +/** + * v4l2_fill_pixfmt_mp_aligned - Fill in a &struct v4l2_pix_format_mplane = with + * stride alignment requirements. + * + * @pixfmt: pointer to the &struct v4l2_pix_format_mplane to be filled + * @pixelformat: the V4L2 pixel format (V4L2_PIX_FMT_*) + * @width: image width in pixels + * @height: image height in pixels + * @stride_alignment: stride alignment in bytes; must be a power of 2 + * + * Fills all fields of @pixfmt for the given pixel format, dimensions, and + * stride alignment. + * + * For formats stored in a single memory plane (mem_planes =3D=3D 1), the + * behaviour matches v4l2_fill_pixfmt_aligned(): plane_fmt[0].bytesperline + * is set to the primary plane stride. The strides of all components are + * aligned to the @stride_alignment. To keep the chroma strides consistent= ly + * derivable from the luma stride, strides may be aligned to a multiple of + * the @stride_alignment instead. plane_fmt[0].sizeimage covers all + * component planes. + * + * For formats with multiple memory planes (mem_planes > 1), each plane's + * bytesperline is independently rounded up to @stride_alignment, and each + * plane's sizeimage is set to bytesperline multiplied by the plane height. + * + * Return: 0 on success, -EINVAL if @pixelformat is unknown. + */ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat, u32 width, u32 height, u8 stride_alignment); --=20 2.54.0 From nobody Sat Jul 25 22:00:01 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010037.outbound.protection.outlook.com [52.101.228.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA304CA52; Mon, 13 Jul 2026 08:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929836; cv=fail; b=SU3LoLASpJQVPavPV5u0/X8nRD2xceFsDuCJRwrC8ryrdAjcgZYpT+o1Xcun+oIMIR9WNRiejDSuSz10ekhDxdFR1+4UCOCotUuWZYU0EccIR9wRq4l5SAAQklcaLx4cuB0L1OFXE/DxJdrNoa6iDXRvFd8u1O4kIQ2cJoR3qto= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929836; c=relaxed/simple; bh=zfjeIZ73/5+VEPBtQ3/5/7Y3qV6S/DVz0zJE0RjYKcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=t+R71nLM5uKD8g8Uz2DwlBeMg1mDis+SiiOdmD8MmZQ2CnJ0OxzRgLYTenMiVTLgeQe6Qo7u+bmxETQMJmzBxQyEovJF9JjiCKFKq5ewtU9y4fvuWv+d93dfGb2vjtwdSpbFDwt9g5H7RxdOivaPtuaGm5mYwBRgrvYHDTwI5AE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=oFRdZ0Sy; arc=fail smtp.client-ip=52.101.228.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="oFRdZ0Sy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hecI1H3OEV78tq15wUQREeor8j8W99+f+XYKzLqVG2islkG+JsIiuAIqX+zuYR5Vj2lIZRTpbANxgKDWZQ0T/9Xo/gutXc2vk5iMLDfKRWiP0iqGkU2UcgzZxAO7VzRQwzy02kOgOpn4neyZ7rO8WUN1Zwajb0g8RR0QVTtWjAeqDFVH/TyjcCI0Cn3KN/uU4ksjdAUT0dT2X5WOxngrI+2mG/FnNTQ+y+SxAcRbL5Yi/ctInC3z1V8+avJrMU/iH/S+gEue3bJailziaCcktnl+JgvWCSZodc+0McVAErJhylY7XgQ5ffZ08NUsddg6UgspjoRr4YxNHYgaSHq2Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ux8mihsRPfeE/0VHpurVqMSLj1DZKhLQqgZnyO62k4w=; b=w0JVmJL23apVFl/2t91GFNP97mS3w5GnEqCCgpKi3tLKfNXSyuNcOXr+3RHAS0kko/aN4IrYCgOtBbtH0luWOEr1c6YgsdCTRdWyU3O+I0D68n5s+7SxfmOVe46fsrZnnltOZOQn0FRwEOIND42DqCsI/ZD6HJgwhZc7qRskMd++0CbW1zjsOVJl+Nx80XKly07LQyw9M0bjLopdq6ZEtCaZ79Pq0Y/RxZkRflWvCbV6jJtzYovPF7KrPFcF3Oc4m054I+bEBIa+o4huj4j4lqM+vHzeqhV3qT1QbUGN0J1NClFRhUulciObxtzEoErHhDrP212TP8FeZUPgANvWCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ux8mihsRPfeE/0VHpurVqMSLj1DZKhLQqgZnyO62k4w=; b=oFRdZ0SyBeRQfTxhlCK/Di3D5XeFD2sRAE7IYuvGwBFEXSQ/gtmAynIWMvM9LNvHdX4gfrlBKxTaEniGjfexMZpZdG20ByeBZCOLdbCr0o0GBC2gLhsjoe+JLUC81dVwWbQ2mYK8WsbGN4MWu6U4fg+T73X6Zw0tGWNMkKyFUjA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) by TYCPR01MB11657.jpnprd01.prod.outlook.com (2603:1096:400:3b8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 08:03:52 +0000 Received: from TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828]) by TYRPR01MB13588.jpnprd01.prod.outlook.com ([fe80::2f5b:8560:48ed:3828%4]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 08:03:52 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Lad Prabhakar , Jacopo Mondi , Mauro Carvalho Chehab , Hans Verkuil , Nicolas Dufresne , Laurent Pinchart , Sakari Ailus , =?UTF-8?q?Sven=20P=C3=BCschel?= , Marek Szyprowski , Mehdi Djait , Isaac Scott , Paul Cercueil , Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jacopo Mondi , Laurent Pinchart Subject: [PATCH v4 4/4] media: rzg2l-cru: Align bytesperline to hardware DMA stride requirement Date: Mon, 13 Jul 2026 10:02:53 +0200 Message-ID: <20260713080259.21835-5-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> References: <20260713080259.21835-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0217.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::9) To TYRPR01MB13588.jpnprd01.prod.outlook.com (2603:1096:405:18d::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYRPR01MB13588:EE_|TYCPR01MB11657:EE_ X-MS-Office365-Filtering-Correlation-Id: b287f02c-0872-4244-dbed-08dee0b54734 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|23010399003|366016|1800799024|18002099003|22082099003|56012099006|11063799006|38350700014; X-Microsoft-Antispam-Message-Info: HjcPeHZbvTVj2duljqy8QfqPMZspYypuxFHZkGIrMERQwAlRGMewlb6Ei3iF7FRiehaXvFugODgoyS30jYaPKBbINQ5ZTHL0UJR89fho8Bm1f5J+mzlLZQpQhCoasU/EZHfDVFxtuK/iQd2yGF6bn48xRtwyzRkTvOZktN5H7F+OXmM0e9Jq+hJt+4N3Lj/f7WJjEvDNxciLYgWfcDa5BoMnblbBWDRVNXY/+lP5AkyBd3DgMjyXbLWBiM16ffigOs7As8vVq56VgL+eo0UnVjQ21wH8MjKg4dCkuD53Bccr7pOEuIgQ8vQ0pXX03/rjvVEk/Wc7kOGn0y+zJsFBSKdqWvchT0JwKBDjvIHAppi/2ZesKPRPmLnES7Brl3q40K/yar8ulzBAGAOBwTL06CXU2E0sH/ScijEVsgyvMQKrApj9AemNO1XydwJAKGbjkxrjyZBnhinPca4yCB9242r5TaD3wAiZhCbcYK9syIB27zlKcypswQxt7ynCCNlmSgjJRaKDPwhW5E8rOP9lXYtSVqYFqUVnR8Nbb57su6rE0tCSFesXPXBXGWj90d8xwp2BjD5uqIcPqNJPRTIVb8QB+l66M4ElCE6UbGpGU875M4x7Cw1L4/8oERksRTAPH7fwt59OfogA6Cp4TfuZN6Sx5NitiSW7iNAApVV22fEd7VnbZ8U6EuNm0R9Mdb1ngI6K7tFBQK2a8DGzqa8wIyVtxjJcQuAFurWOJ2+3138= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYRPR01MB13588.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(23010399003)(366016)(1800799024)(18002099003)(22082099003)(56012099006)(11063799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?htr4ZyvF69nAauK4Kp0PL2X5s7nzGKYA2X9Q8M+lr7BhYxljtbtN67HLygFj?= =?us-ascii?Q?7Mus7wWVOlGvWVsPxOPpCpgjB4DDKPe/hVsxqqsh6nnYwqYSzS+Hy067Zv1j?= =?us-ascii?Q?yk8Qv8NPTytQ1JuAqQB9aDrvrlCOQgHmhm3Vy5YwQxFCaQaPY9qPMPQYv6A1?= =?us-ascii?Q?aRtyMtgj8BGAZ8VjEXrPWJ5coc+Ui/DAhTLsSdM7/eqyG1B2eWST3frhut6/?= =?us-ascii?Q?u+oYEyI8sbzviQgqyBH1gCdk407ibeKsm3v+H6H9yw36pLjbympjQuGeEhff?= =?us-ascii?Q?dmipdw+ETAHtmWdnduogfN0JXVdaK9vN8hQ8/SOuQDjlobWp0ESFzQ2kPxW/?= =?us-ascii?Q?VYtuIAWvSjZWvng1kb4KwGAbOkI6vsy+P6qfu/FR97rpPxKVdBYCA0d3Gcsn?= =?us-ascii?Q?Ahe8XQS6fYnNKFTLzPaA1+VR51qPAwI6YZTEjVEI/4F2ZwKsHZBP5Vi1WTCu?= =?us-ascii?Q?FPu/kgxobnCjWvfcRM/eitNleqd6AXora+Hxannu6mVHF69WD+bNxf2+kpl+?= =?us-ascii?Q?zMHMuGXSrOQGPQFRMRSxJ/tXqXmVgn5bX1Vf4TLwesFGEHufrysICnNY40Dc?= =?us-ascii?Q?TloNNF2kkNJKtohoO5yN31fGNi5uHEo61xMD7ayktD0Ztds+ZTR0GOKBzmQ+?= =?us-ascii?Q?G8QE0jpMO1Or2FBHqsPR2mtAwrLpLhUQ9tpq9IbUWnmBMHiHrHTqCrF80SMk?= =?us-ascii?Q?9On30VW93LHnFffMrp+c02XNYu2FAhou32TqgrN0yq72aMELCrtzelvJb4q2?= =?us-ascii?Q?/iwJDyPDXfr2fgf9GPrzjDnS5qhye0LzmZqk+N09EhM5oYn6TQo7FskgCEle?= =?us-ascii?Q?0b04WpwrU3VNudS8tgV2iFV0wbcNtpMYg/F+3g2LmGFX9k6cdomVY+3vO9/9?= =?us-ascii?Q?GBnwCH3cCHTOxKSvHoABpkH0dyzWlc3VSMjkxQcI7cdxFHlgIETkvM/ZoK2k?= =?us-ascii?Q?kYmQ38Dc9F2b9FfK3My3/xQmSPAjNBAyMOtKhWluyo5yBRhPD8xKCQYx7vYw?= =?us-ascii?Q?vRBHVsKE2Sy6oP0X607O6Uk4Sg7gwaNnaqTEuylChbv7++6mNqaBkKncNPUz?= =?us-ascii?Q?q4YXUSJrPqCh2xs4G36ZE/5jDaTB3DdbsmF56mMTEQPtMZUy6LJyF5h0/7f5?= =?us-ascii?Q?vFhSjHEAtTFc3jXG0kuRrrYBPQEWC55je9qJDIAAlVVIBQ7lgw0w9Llmnkwg?= =?us-ascii?Q?9uuVccb1WXkVskxR7cvJUPveUHDMOLkypTOPsxoz6ibQZLMmzoG9kRsF/xjN?= =?us-ascii?Q?+aq43gMBVdCKCl6nQceql1+IDzzxjE5mnJTq7pQP+hBV5pywj9MLJAnlPITR?= =?us-ascii?Q?X2SytpBXM3Voo0PBAopA1DiTe/gHQtXpmMxe9cm5ZzITPppKR9MjLGxPZIjZ?= =?us-ascii?Q?HhMj9534X2FoT31jj417f7J4jKU//7IPjRyPDFS4ZiLVAQGXmXTaFxFCpoS4?= =?us-ascii?Q?O3fMyOBOqLNe3n3wKNPyQ+VpQeDp0yQg0vvmgO8PswmpMQXMVFcrjLUP3KO2?= =?us-ascii?Q?Fsap7vaO4Dp1075cDJk67eLRz0EUEePONcOjuO7Cdx30T92CF7QrXGoMyOf3?= =?us-ascii?Q?XB5q80doS6nFJcQ56U3GU4GWHC9F72gqF/zF/DJ66lgZ8n8ux5ffrtg+lnx3?= =?us-ascii?Q?KyadY3oDau+uAGf9aeuwgLW2y3xcbzZs6DMRM2mjZHkvsvW5H/NOQHW5Q6wf?= =?us-ascii?Q?QfNBa7ZuNBFBE+0K1NKAs098NXO4ce/520gjT583EmDnecTRh0ba7nMZtFR7?= =?us-ascii?Q?hEnYG8G91LaMjTyzf5wfMc9hXqALyUEeh42XKZy3UI/JLpNEVJxt?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: b287f02c-0872-4244-dbed-08dee0b54734 X-MS-Exchange-CrossTenant-AuthSource: TYRPR01MB13588.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 08:03:52.2551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 89iFo08wlLLkyphIpv3j2jzUyiEjdA9oIxg2AU/vT748a3ORX4JQZkuMXeu7wYELVl9rCSbN52/Wqtql5QpRBZCO+MkFQKgdIb2H4pQ8faakeE/KA7DtXKgD8VANOUWt X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11657 Content-Type: text/plain; charset="utf-8" The RZ/G3E CRU programs the line stride via the AMnIS register, whose IS field encodes the value in units of 128 bytes. If bytesperline is not a multiple of 128, the division truncates and the hardware uses a wrong stride, causing horizontal banding. Commit ace92ccef0c9 ("media: platform: rzg2l-cru: Use v4l2_fill_pixfmt()") replaced the open-coded aligned calculation with v4l2_fill_pixfmt(), which sets no alignment, reintroducing the issue. Switch to v4l2_fill_pixfmt_aligned() with RZG2L_CRU_STRIDE_ALIGN when info->has_stride is set. RZ/G2L has no AMnIS register and keeps using v4l2_fill_pixfmt() unchanged. Cc: stable@vger.kernel.org Fixes: ace92ccef0c9 ("media: platform: rzg2l-cru: Use v4l2_fill_pixfmt()") Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Signed-off-by: Tommaso Merciai --- v3->v4: - Collected tag. - Rebased on top of media-committers/next v2->v3: - No changes. v1->v2: - Collected tag - Add missing Cc stable - Fix s/commit/Commit/ into commit body drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drive= rs/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 5185a547461d..27a35ef2a6df 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -849,7 +849,8 @@ static void rzg2l_cru_format_align(struct rzg2l_cru_dev= *cru, v4l_bound_align_image(&pix->width, 320, info->max_width, 1, &pix->height, 240, info->max_height, 2, 0); =20 - v4l2_fill_pixfmt(pix, pix->pixelformat, pix->width, pix->height); + v4l2_fill_pixfmt_aligned(pix, pix->pixelformat, pix->width, pix->height, + info->has_stride ? RZG2L_CRU_STRIDE_ALIGN : 1); =20 dev_dbg(cru->dev, "Format %ux%u bpl: %u size: %u\n", pix->width, pix->height, pix->bytesperline, pix->sizeimage); --=20 2.54.0