From nobody Sat Jul 25 22:03:04 2026 Received: from mail-pz2-f1.google.com (mail-pz2-f1.google.com [74.125.228.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15ABF29ACCD for ; Mon, 13 Jul 2026 07:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926357; cv=none; b=I9VrXtkPHrKf6kXC4x01o3mW/Dq+hKa35oSt9kaFYg0eEYHY8oibIGilI4kvKuSyRrWTNNRq8YG/XtQckHie7tdBfboFBOOi3YtyFxzbAQAFF6InbtTEtpF2VNpg4ZeRStrg+zzMlA8+0yz8lDCFYA9fddnrmG2RkjZoSZ9hB9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926357; c=relaxed/simple; bh=f/MBbiCuKKupEkf1byRULDmHXfS8NTVvAP9nhNm0auc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=smMRJHZFiWKurEy/v6YGcBKLkwJ6DT+MXHNJHHoSwWITVzFeU0E+esyRNbRh6r6pqpObCHWNmIBhfJz1q1OjRdTx1Cmb9x7qMxCowQ0cXtViTYEumMkAHogQE2NOqcMRWfW3JYANcXsqfWMpyG43A5uvWkTKk9G6BqFgeEqKSsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LWqMPWrj; arc=none smtp.client-ip=74.125.228.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LWqMPWrj" Received: by mail-pz2-f1.google.com with SMTP id 41be03b00d2f7-c9486571b64so1743728a12.0 for ; Mon, 13 Jul 2026 00:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926355; x=1784531155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qA1SnyVW2zGbBB6hZifBtURCT9h+B8LPBVvb0SNXHhc=; b=LWqMPWrjZiEiGjo5YESZsk9BHc6k1buWYJwNr/EhIv898iHOyQlhymFMV0tq32R/IG QRrY4BUInFR/zVqUh/of4ZWR/Iqm+RQNWcf1lObtaeWvkfEFaU77a0n9wgYMyMeRq1xU tTCQt4gCDOP8iNLGL7Bs/IUKz4lfdrdcsHUtQ5GYaf8RW2L6+JxelL/DQLDy6vF5KkJE dH1tUh6UawyREHZ0Wj6ZYoQHKmP+flO6Cu+gaaera785Am4uNZhdqoXDPzMWqZySzix3 XkBV6Ev2gA+m3V8s4oaV3Wl9fbvB0puYQjAv6gr2QstLvY+89gZLskv2QvYxWg/kyLNW mE6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926355; x=1784531155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qA1SnyVW2zGbBB6hZifBtURCT9h+B8LPBVvb0SNXHhc=; b=JjWVgLPWpF+Y7THwj8MQsiqFWwm6vtT8BuI3829B2XbDPvYnZ3KLYo5TMOf38p4dC/ GPd88BOT3IIEHoR/h/5yqCBRaU7ebFWycvSQ3BIkw3sAMHRXR9OaMH2Bk8kqSCGpCOdS SnIDWYBpqN6dY9vh0V7jAD3TKnPUduo5eei+HsbNDIGCBNSBZiIGWLPMemnYYe0d2tW8 Voa3Y+ZvPq5fmiMM60SM5sMJwbbhBvTMT+YFZC18B0bv8X6P7l0SvSyK9EEoA0VAZ2Hx sF01X9UZLzZOmRXLbi9bsS09P7/ZeTSWovqiJVnDqQBG1U21ddivtpF5T3FqJ8HM2V/Y jEsA== X-Forwarded-Encrypted: i=1; AHgh+RoCScrDB30xGQ32RH+179jQ5LweT/C3o315ZaaoII2vMCCoAFNwr4yudgDes2Nwl+GqhAzU+2UzCD6lxgI=@vger.kernel.org X-Gm-Message-State: AOJu0Yye0u+58q+9WtzzJM3nqFtIeXmxlIUgmdnoLSV5dVWZHJ63zzTF lOcqMTknI/dqAweIiAhPHyvWw84Ub4Uf21YfBRFAze6/8KWIouOUkFu1 X-Gm-Gg: AfdE7clGxoth1YmqBjN0N5bRPM0JD395hK5hRLJXafvYRLRgPZMLcupBfBW8CUYa1v9 2Uknb+6FhLvUAc4HycqgBT/bc20uuq4axpBq1txKpEs198+UxcdScU7htOgCVbNp1NOcd/qzdRm bR9VD1NzAi+iX+1Aza0pE3s1dGaD5az+NVUiLdYHGo1TKPJVHtnlOlhMO5v94WGgCTxzn+OxNyt uHhoPNIUI1QBLyK6CGEh+QqlxHNxUlA9pxH37eYtRk0guL+ch7GaPGlF+3tQT//pYcfVgPNP9F1 vShnLAgDPV9GdMpRcI7MiNy3Nw8jCm9PgsNXJUrEkxkvkyinE8kr5Qs1Dvv2lEtqVHVUdOPXulA 9UdacBsjnfgTZJplqHDe8llnpl6zNRXNRbkriALpczPiINCjC4sOx7xWmQZfOI5aBC2U+WXrL12 Vt3YRpSAYJDpcYPdwUvpQiJeykt+9u/tFwCcR+5m0J1tcC X-Received: by 2002:a05:6a21:4d8f:b0:3bf:97e8:a04d with SMTP id adf61e73a8af0-3c110b45600mr9044683637.43.1783926355337; Mon, 13 Jul 2026 00:05:55 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:54 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/5] staging: rtl8723bs: remove redundant return variable in rtw_make_wlanhdr() Date: Mon, 13 Jul 2026 07:05:33 +0000 Message-ID: <20260713070537.15903-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The temporary return variable is no longer needed because the only error path returns directly. Remove the redundant variable and exit label, and return _SUCCESS directly on the success path. No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index ca8f01575b55..ff67e2576b31 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -911,7 +911,6 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct qos_priv *pqospriv =3D &pmlmepriv->qospriv; u8 qos_option =3D false; - signed int res =3D _SUCCESS; __le16 *fctrl =3D &pwlanhdr->frame_control; =20 memset(hdr, 0, WLANHDR_OFFSET); @@ -951,8 +950,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr if (pattrib->qos_en) qos_option =3D true; } else { - res =3D _FAIL; - goto exit; + return _FAIL; } =20 if (pattrib->mdata) @@ -1026,8 +1024,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr } else { } =20 -exit: - return res; + return _SUCCESS; } =20 s32 rtw_txframes_pending(struct adapter *padapter) --=20 2.43.0 From nobody Sat Jul 25 22:03:04 2026 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D022F368D4C for ; Mon, 13 Jul 2026 07:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926358; cv=none; b=hP/bP7lG7GAluyezuuuEZYtqd4Ldry+HgnoF8No9DhmBl7uVF0GuMcLbOui+ZdISgcdc0R+50cRQdBDe7yTrEAiYeFfHzXfMN+ZauX3rQZG1r1LHOUiLhGlo1UpY2c86L5qE4249EeMhq5IuBPkj+1bG5J8KjDQzicsQ6VxHFiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926358; c=relaxed/simple; bh=XzfgW/QIAC3UIidbn9HJWxF8wgWeSp6iQuDvdi+K8hA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lH4WblbAf/xE0XcaZyT5rSaD7Lt2dhIMnMoCcJf+3q/8/38sR00yRA48QSjTusfy6GwtziAOKnC428I922Z8Wxx0prCNkA/BUURAQmY/cV8ijqPoFYx4E3Jf9+wmUU0mLbCuB89C/RR+h69u+PJ4sRQu04Jf7vIjq4ndxgXy7rY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RbIzgVvb; arc=none smtp.client-ip=209.85.216.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RbIzgVvb" Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-38175907a56so2933449a91.0 for ; Mon, 13 Jul 2026 00:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926356; x=1784531156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CkIMlCQQAnln+Op2DNgA0UlpbuYk4uUCoqJrhtqHg84=; b=RbIzgVvbTcrbeW5a8qb1cxMJci8lYj65LhoMrUMAmUkRtsNp2JXZ1zk+7dfdg7em8C YWQ8jS/OnHphQzps1hZGqXaPIRPwkjj5AvNxOm8FtN4IUMJvUbGEh6eDV8/50+xwWTta 5VqhIe7Tgfcow2RkFk/izLFHMYhk76Fu/yL72fb9uIbd1TGODCXQTeZ5n3LViaXJ7ZBK xX6XBUkFYI8b3p6u9cajkQG0JzVJoflXNG5x/rtmSjCVLDtGWIA/5kQJ8yUemzrkh1NH m2lQyqKZ0ukxx/vQX6HpzI5gVScB3ZCYvtau0xRtwd6U8tybNFpUfuLabgJf0UOjA2zo fkZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926356; x=1784531156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CkIMlCQQAnln+Op2DNgA0UlpbuYk4uUCoqJrhtqHg84=; b=DFXiCigQhradJ8RqKBXn1xvyRrsXKJHalMoTJHlXjP4ZHOyWEfaWqplbf7Hb7Cfbbf ThPR6Q9uDDJYaPrQ0VWxrTPJY6ej2XpgwA9jQp78DSjEcL9B4t8JdP70ABgneiWxn5jU Q/aQLCrCb7slzGP//c6c8T/S5A3QxyikYqX/vwW3EmU6N7ehtTuZB6CA0hIL48RP9Nhq 40qNl+1DnjU3gfFeMURykhxnzJp2BgEmxw0U1q1kzzSsmvoU18XsLeacJTjwqBkXq9FG 0JaGAOtH0+RX08tdWMKMAcuDdyDkb2EPvtAvSnpWQHWrlshRajvD+7ryGZPgg7/YDdGE OPag== X-Forwarded-Encrypted: i=1; AHgh+RqP3K0Z9Dte0cTGnS4D47iMPl9DF6mdCxwtG62EFWXzeDyGwcQBHWHbIOCUWHPuJZbzNPjGPCipUtqfg8I=@vger.kernel.org X-Gm-Message-State: AOJu0YzXMx43z3u7sZiINdbRU4gr7TjVUu0NWZMBN4COcGi/eseaCuei mSjf2SVBjKc0aQorwmFQ3yvtoAv45xahNyGl5R7RwXMnfMPDjujIwRVW X-Gm-Gg: AfdE7ckgiOcFYb6sLiGw31cH24aYKeSvhfdwM47Wy99eJG8zAswrgfl/27uu+YMogSJ 1J/rQUtd4G8AM94QQtBTq7AcLydXxZxSvEOKCEdGm4/pGLvnPt31CsPT78a1JrgByeP6/rnlSpJ 0udgoQ/4YG3H1HCNEPa2PM+9rNeXeXugcO+J47mEFHyugW4aNRuEoF5uCtbIGbHgqzTqKNmR1HU 0UlnZe553am7M5G6LLnPJakZl4kag59XJ0eWKUsMFGEmgTFOsGSBYIjDVZPq99JuOvn3E/zkTpZ jk/Ap/PAzYVK8v+L8IznumWWSP64iV/9oaAU1Geca6mdacoAbehHNLEbZmxSshWDSFmi+BLc8LD CkLBCdvzd/x4eI7Pp6lBm0QJMxuBBMpMgCP5xYlAWVfxIhdd988f7IeiiX1WTyF1SgI04lYJZOz BsNtvPRsuBf7r05Jm1sz0b9YnTRnSKMVJyfjGgKjdoLDZrIAcPOLEdVh3Kh7VtEHHX8A== X-Received: by 2002:a17:90a:d2c4:b0:38d:d9a7:a4e9 with SMTP id 98e67ed59e1d1-38dd9a7aa3amr3766897a91.11.1783926356166; Mon, 13 Jul 2026 00:05:56 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:55 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 2/5] staging: rtl8723bs: convert rtw_make_wlanhdr() to return errno Date: Mon, 13 Jul 2026 07:05:34 +0000 Message-ID: <20260713070537.15903-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert rtw_make_wlanhdr() to return 0 on success and a negative errno on failure. Update the immediate caller to handle errno return values while preserving the existing _SUCCESS/_FAIL semantics. No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 15 ++++++++------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index ff67e2576b31..98b886732646 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -903,7 +903,7 @@ static s32 xmitframe_swencrypt(struct adapter *padapter= , struct xmit_frame *pxmi return _SUCCESS; } =20 -s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib = *pattrib) +int rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib = *pattrib) { u16 *qc; =20 @@ -950,7 +950,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr if (pattrib->qos_en) qos_option =3D true; } else { - return _FAIL; + return -EINVAL; } =20 if (pattrib->mdata) @@ -978,13 +978,13 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr =20 psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) - return _FAIL; + return -EINVAL; =20 if (!psta) - return _FAIL; + return -ENOENT; =20 if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -ENOLINK; =20 if (psta) { psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; @@ -1024,7 +1024,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr } else { } =20 - return _SUCCESS; + return 0; } =20 s32 rtw_txframes_pending(struct adapter *padapter) @@ -1093,7 +1093,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct hw_hdr_offset =3D TXDESC_OFFSET; mem_start =3D pbuf_start + hw_hdr_offset; =20 - if (rtw_make_wlanhdr(padapter, mem_start, pattrib) =3D=3D _FAIL) { + ret =3D rtw_make_wlanhdr(padapter, mem_start, pattrib); + if (ret) { res =3D _FAIL; goto exit; } diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index f67cb22e3396..303b50051274 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -410,7 +410,7 @@ extern s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv= , struct xmit_buf *pxmitb =20 void rtw_count_tx_stats(struct adapter *padapter, struct xmit_frame *pxmit= frame, int sz); extern void rtw_update_protection(struct adapter *padapter, u8 *ie, uint i= e_len); -extern s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_= attrib *pattrib); +extern int rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_= attrib *pattrib); extern s32 rtw_put_snap(u8 *data, u16 h_proto); =20 extern struct xmit_frame *rtw_alloc_xmitframe(struct xmit_priv *pxmitpriv); --=20 2.43.0 From nobody Sat Jul 25 22:03:04 2026 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5DB369219 for ; Mon, 13 Jul 2026 07:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926361; cv=none; b=kr2iLajwpXaeNRAEoYCsdJEU4p3AnceK+IBW7mwH1n1koYRsSh/1B2cOP5dKeUwS4/yeuF14LuqUEGJgwpkDE+ZcA9/J+moPk11vd7QvURuzkyCutwbK4j5xkbTQ5xkPb1kaj6N8H0BkF4yxTRN8r2bSJ1HXp7aVYoC4h3DL1M4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926361; c=relaxed/simple; bh=N9HLizXXiFAvZaaWH1ui6wNm8m+fAkUVUXVihRy1fBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L5BXGZyN7V1SweJlprluEAFs5geUsD7EAcYOIUqjsTpM5Wo26Bqrtyf2QrWKMr8J9K6aMYqaH4P+0JB2NGfucvfYEbMYeWZ7FIeRODFz2NuSdA488DDbG0C5okidai0z+l7d04PQaBXBUmR6GrKTVOhyjFZN1+TUIkVCBbSR0tY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P2pF0rvY; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P2pF0rvY" Received: by mail-pj2-f1.google.com with SMTP id 98e67ed59e1d1-3810f0aba07so1656789a91.1 for ; Mon, 13 Jul 2026 00:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926357; x=1784531157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bFy8a5KYcxfhVgWB2o9ncTF1rCZKKEFMUuyrfhVpuV4=; b=P2pF0rvYv5hiAYWMDApzELBn6tv3La0dYWk2Ppxgj1Zzs8gTy6+zfvhwPNDcbHu6RV uam9M9CA/Udw6mtGjrgO4x/piHBlMZ6HfSxFJfvKi4SqNYSYAiZaLVF4cd58eeO8uSW3 uDQdKdmyLc1TUOd5quuYHKuFVxpxpFVznugLQAXh+Mw9swKSVI0eObrCDN/1UOCYMrDK PhKyJvN1lsVXvPmfuldRSXuNzLUf27uraBQ+/WJCplkon1limJAw6b0ETJYhyUF9fD1D X9BbWvmAT0wPoX8QE9AdF/6Nn3+pVsoNsrh6d+2hDXrXz4q+QXWQmHUaGcqs3UqB7Ghz iFcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926357; x=1784531157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bFy8a5KYcxfhVgWB2o9ncTF1rCZKKEFMUuyrfhVpuV4=; b=jZnfJVC1tnV+wAGC4SbD9V3/r4oafOg/am2pLiCorijpJzB2qAHXx/cX0KiHI0sXqZ f9dxDInMNZLI2iwnmkXJ+5468G1OfEN8HyNdYgqjItXstHC7pRknn4MskDXlOJp0NgwE BZQiT/huFM2IbWnKEIjxUAs6xp1MPEyGTR/ibd3an1MCJL4mxITk5rdIwAB89Y5obKWA 53axpZzjG5oOYWmIuEuDbMXxhjidq27N4ZOT9ZOUBq1TYoUQz+qowj09aZvAMV3RAlnh eghZoSgxn+WzSp3B3fw++aXWA0tZxhB5VyTM3rRLYXrrG+X0RSDdPT2qw5L35exv2Q3/ Ui9A== X-Forwarded-Encrypted: i=1; AHgh+Rr4NSpCknQtHe/zjuAM5ziMt6rmoa9RACw/+ocBNjqcmbC80LezAxYM8ZH7ADpvs+xPi2UamBt/7QNQZ/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxlZL0YLVhqklM+3WcP/I4fdOiAjhYxcDcOd5lNTjVIL6eb4pnb kvl841DwW10ZTR6rox80jTch4ByMul93CbuaL/LV1aMXN1bHOPrQE9RVqUUPjd3i X-Gm-Gg: AfdE7cnWN/K/X5T+NZo+spAksn1h6HlQJ12N02ZNXc/uavkaYIcfk5ygKDNBtCltKBN Pcj/afK8bgcFtwpkkisF80olMPu8kLJhZV/GCqaqRmQoPPjYADe2DfeHzzJitLmcjvF5knb6Xml hac+tflVXy5pUro0tFZysxHnPKhVTpfjSt6gbko0xiXxpTWsyTgBTlMp96F46lUJ+WneI5dHxTK 13JOateIEtqzD6XTYccZlz473Izhmy0lysCGvYFQ4AjATVW9rSqkvksFSsJF5xdlmN+X475yMg0 SaRIJivpAuDJvIyqs06RSeu+/FSKbw/jnIZWm65SH6a52Dv3XxhsBFmIoCgCOQcbDEbQgsvhkOK eZvlsJywJeA9EPWT9vdXJDCrGjxo3nKqABYZmnWtDK/WhT3ah6VJYRfHL67uVx6gP8kQ2SGVa04 1ViUAGpC44CyHVvqrY0ePstIc10d4CQvgXQaJLWGm8m/Zi X-Received: by 2002:a17:90b:17c9:b0:387:e0db:3d90 with SMTP id 98e67ed59e1d1-38dc77e8853mr7597465a91.43.1783926356989; Mon, 13 Jul 2026 00:05:56 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:56 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 3/5] staging: rtl8723bs: convert xmitframe_addmic() to return errno Date: Mon, 13 Jul 2026 07:05:35 +0000 Message-ID: <20260713070537.15903-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert xmitframe_addmic() to return 0 on success and a negative errno on failure. Update the immediate caller to handle errno return values while preserving the existing _SUCCESS/_FAIL semantics. No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 98b886732646..07e413f4dbdb 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -797,7 +797,7 @@ static int update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p return 0; } =20 -static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *p= xmitframe) +static int xmitframe_addmic(struct adapter *padapter, struct xmit_frame *p= xmitframe) { signed int curfragnum, length; u8 *pframe, *payload, mic[8]; @@ -820,12 +820,12 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 if (bmcst) { if (!memcmp(psecuritypriv->dot118021XGrptxmickey[psecuritypriv->dot118= 021XGrpKeyid].skey, null_key, 16)) - return _FAIL; + return -EINVAL; /* start to calculate the mic code */ rtw_secmicsetkey(&micdata, psecuritypriv->dot118021XGrptxmickey[psecur= itypriv->dot118021XGrpKeyid].skey); } else { if (!memcmp(&pattrib->dot11tkiptxmickey.skey[0], null_key, 16)) - return _FAIL; + return -EINVAL; /* start to calculate the mic code */ rtw_secmicsetkey(&micdata, &pattrib->dot11tkiptxmickey.skey[0]); } @@ -876,7 +876,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, s= truct xmit_frame *pxmitfr pattrib->last_txcmdsz +=3D 8; } } - return _SUCCESS; + return 0; } =20 static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame= *pxmitframe) @@ -1175,7 +1175,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct memcpy(mem_start, pbuf_start + hw_hdr_offset, pattrib->hdrlen); } =20 - if (xmitframe_addmic(padapter, pxmitframe) =3D=3D _FAIL) { + ret =3D xmitframe_addmic(padapter, pxmitframe); + if (ret) { res =3D _FAIL; goto exit; } --=20 2.43.0 From nobody Sat Jul 25 22:03:04 2026 Received: from mail-pj2-f4.google.com (mail-pj2-f4.google.com [74.125.227.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 841A5368D76 for ; Mon, 13 Jul 2026 07:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.132 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926361; cv=none; b=L15bvwAuabKzY9Vrl95vt+0ouFcdJB5ijjX0sMXDJBEhOhVhvaZbD/HcYIF4lGk2bJOQ5T4/f4KpgHMXbywAjUa00S1Wsm4WFbaUJ7trTEPJnPmKoz5ud+W/EzJGJywbt1r0g+pV5SexuqYPQlx2/PAIRRTHmdJxK/eNPVWWLRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926361; c=relaxed/simple; bh=oMlfsfiSE0cT9W3OByCiHCCl7GXUyN/eRFDfg/rVZRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uPD40KDklX+e8GrJY1OFxCBWzNbzZa3jB5IVqjePAcYqd9AXjaBZnVEjF9Ni9yKmPf82kYTRYPVSZwc4mb0qWe75rvgGuwNmOrnt2jETFFq1CMFh0WO+w8xoX+K0rE4sK+8Zv2QsbQnT8PnCGMkWNiK/ov1/1KFZLhhKc1Y1DTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oJobaW/m; arc=none smtp.client-ip=74.125.227.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oJobaW/m" Received: by mail-pj2-f4.google.com with SMTP id d9443c01a7336-2cc7ef596c6so25950315ad.1 for ; Mon, 13 Jul 2026 00:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926358; x=1784531158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qdQwwTxmpRrQW76O49QNFsy/qCBmIpByAPOiT/YU9R8=; b=oJobaW/mjmnCysLQBot4JIW1sZ4dRZifpvspYba7n1/NKis5cdmVy082H3lkrtWm0z iSz2RSGVqTUvkxCqDd6BBB6UEaSE8Ud/bzraLqGZJ2tZqXMPYo1pvsmjIp/0Fnec+lCF mf5fLr5HfxA58v08P0t2T7JgYImAEU/0Autd3tRbf8GX+yLnADT6eTKiStJBWAqUebOU S40vAaNmrx6NTtm3cs6aSKfJRRv6xSTbXX63YuRRlsNCr66gwlrXy7ME2Nx2POWWPbg8 SV6diSlgYDqHLzZmQ3At2b5XJ68/DJZUBbH8BRsWq5vhVLZyYIcw6RM8RZP4TkZKUojL vXlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926358; x=1784531158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qdQwwTxmpRrQW76O49QNFsy/qCBmIpByAPOiT/YU9R8=; b=Xp+WtHtfzW4zcAPV1siKVumLVARLqQlwe5tsiE+6XzLJAWYTZtdPMOjdVjxaH7d8Ic 6zWvZJdyap3tkzciO+Wr/D1bg6h5AxiRpr9dE1hnIaIiSYgWpEIzRJXwtlWZRacge13r 8ehA9YewtnMjggJNBh2aMqkjwoc3wz5wXRqyxsf7naYzLGfNYmN+H6kiVwVtg2lRUkeX 28mZjQIE4BWWv58J/qfruW4P1Ogu810PPEDRjmQCLLRWu+Cd9nwusswZQ9heht7DBSmL FtCIhYbHnBYYBgg5ddF1nmQfEz9ZJ1cyr9UZnwA4oNzPuagvnKCMiKzDKWPox7OMLw2X G8fQ== X-Forwarded-Encrypted: i=1; AHgh+RotHU2ZNHU0zMDDoy6SPSIk4qQDx/PoUOf1ljFoC6mYdxMBXgmfKW5ky9IS1oqFrjJh7orb1by1bKwt82U=@vger.kernel.org X-Gm-Message-State: AOJu0YxuyI6LXuJe4ZEa5o2dIMPvk913wLcO587PoSq64JgHlynSVWnJ rvaqBZnoz2B5Mmbfmand8+HK7zYw1Y3BRMaJeF9mYrVSdZJcJ0Y7flZD X-Gm-Gg: AfdE7cmyt1Xa9wIhT+QstUEHLi0D0fBKhP2dDEc9eChLrIGOChw7q1CFkRel4x9zbp5 t1QHBhjdvrdNu80B9PSTLMxI/nRYkli9ygWhoUrdvYRdTTTbSvL61T7JOriHXbIJisv3bJubz67 U8s7X85a1d5Q2AGkhaAkNsLaQUf0ma4ZohaoNG48CGJ+VXmZLxPzoIsFylT3BDGCQ4i71ZTiOB3 j4CuLFtBz8Mo3mocTMXnYC4Bgk86lwxFZ6Uv17Ja+oMClUY0h2jTQzf+3YKsPvaM8tDfJptYN/q 020i3lD+qpMxhweU4SZa/qA3wySDrS77bjJ2UsfeAmjPwtMRURWTofBdgSi0vfcS3FsYNfk79jp o9k+auKV5JtYakFoF8klIGvcOcFg5pCdpKU6qNriMud2/bywLqZjduK2rbNMUmZA9YzbUk8c5L+ VHEi9wDnvSkrJ771L4CAjXoOjItyST6IZx9wu9SjqjlHA6 X-Received: by 2002:a05:6a21:398d:b0:3c0:9c19:65c2 with SMTP id adf61e73a8af0-3c110a7780amr8249156637.74.1783926357806; Mon, 13 Jul 2026 00:05:57 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:57 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 4/5] staging: rtl8723bs: simplify rtw_xmitframe_coalesce() control flow Date: Mon, 13 Jul 2026 07:05:36 +0000 Message-ID: <20260713070537.15903-5-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace goto-based error handling with direct returns and remove the temporary res variable. No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 07e413f4dbdb..d4bdda50b68f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1082,7 +1082,6 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct u8 *pbuf_start; =20 s32 bmcst =3D is_multicast_ether_addr(pattrib->ra); - s32 res =3D _SUCCESS; int ret; =20 if (!pxmitframe->buf_addr) @@ -1094,10 +1093,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter,= struct sk_buff *pkt, struct mem_start =3D pbuf_start + hw_hdr_offset; =20 ret =3D rtw_make_wlanhdr(padapter, mem_start, pattrib); - if (ret) { - res =3D _FAIL; - goto exit; - } + if (ret) + return _FAIL; =20 _rtw_open_pktfile(pkt, &pktfile); ret =3D _rtw_pktfile_read(&pktfile, NULL, pattrib->pkt_hdrlen); @@ -1176,10 +1173,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter,= struct sk_buff *pkt, struct } =20 ret =3D xmitframe_addmic(padapter, pxmitframe); - if (ret) { - res =3D _FAIL; - goto exit; - } + if (ret) + return _FAIL; =20 xmitframe_swencrypt(padapter, pxmitframe); =20 @@ -1188,8 +1183,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct else pattrib->vcs_mode =3D NONE_VCS; =20 -exit: - return res; + return _SUCCESS; } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ --=20 2.43.0 From nobody Sat Jul 25 22:03:04 2026 Received: from mail-pj2-f4.google.com (mail-pj2-f4.google.com [74.125.227.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFD0368D4B for ; Mon, 13 Jul 2026 07:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.132 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926363; cv=none; b=mX/G3v1GNTdzksFl4m0f6rqo+RSfLcsmp1wBc4wYFIue/AxhasFc/0WaVZWyRGQlwCJJm2dU7gtPkbvDQgsRrPNFxpgSCynKHqu9841FZw8wfgUHupEnLMsG5AfRfH6PpeEwzrqIUXbBALu8MqvJRJGHxw1AQyCAMWOlw1maJwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926363; c=relaxed/simple; bh=xSpjy7giDG2N15KKw3u4QFJ63jbvutsHW6+WADr9bMI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TAChbo+zqLMO94NGADrpdQm3afQdSfZXpBdcq3hxwsNuDHclgYU1pLLR6/akcBZOjUL+mhSg1QNSC0R1RbfYxqc27mXko5B0iimHD6xN/fcQZ8YHDONlQ+Hnj2gX8cfjzmEJc2lLv5RHWNM2CmAhldnJOzJiEGIhn9jzuemcbpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=czChat36; arc=none smtp.client-ip=74.125.227.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="czChat36" Received: by mail-pj2-f4.google.com with SMTP id 98e67ed59e1d1-38111ea8a88so1979034a91.1 for ; Mon, 13 Jul 2026 00:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926359; x=1784531159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yOlmJH0n1OVlXWDZ91LzVBkSBOpbC1reCkCRza+2PqA=; b=czChat36bT+oyFCQg0EKqXk8nOCtGe0MyoqTzCGOMCOmmDRRdlGa2cng3s9L4fKEhI +X+/34XGFgBO8y7nTegC2U7E9SJ/CVmCNSrMUeDc/08+4v7bu9lDUml0hwdNvtCIAb7y jfohHJIhVtM1xAkyXP4eXnINs+wyZb8sxdFuKoIqcxLoeF3kkT+fBgmNJFP8Fr0+ukSE lhUBBlhQF3n8+YC9KY+fAcnqj9WTyadqjiNyW0qfQOpwDo4GcRNRLJmZO4vp6ALKJ4LD BRaub1A/pncKfiHzhpHaTYp1w6h68KL19A89m7Kvp0jfvGSlnVI917YS4VuRFhyp9sny IbzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926359; x=1784531159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yOlmJH0n1OVlXWDZ91LzVBkSBOpbC1reCkCRza+2PqA=; b=Ho3fLPJVj1YI3TPGpWXaokDL2Trk/cubxmDdCDVLNPior9WgJ7dAkly7DFc9HfarbM q28novhnPE557+3i2Skq7scY1/9TcE2GHn4/JqbnF6Cc44s7Cv96loInLimT/YkrMUdv SIeX6xnsnCK/LiTtkJnHAqjFajxhzNm88l6iOZZlh7KxJsBHnfzrshfyJDvu46pwpJka K1ILHy+5B3pEQzP8phjYoPj/UK1RR+Re7aDHA7eM3bEnLs45DxDscNIMw4sndDfNV9cl RyseBJf77B9b0s/ewlGBCk3Z+72k3VB/DrqTOerYNDEmonYT46aM1jFbRhe16zKGEJcN z3wQ== X-Forwarded-Encrypted: i=1; AHgh+RqgbG9AdcfOEasn6kGMwj/JBkUT6DWbF7LMGKR+G6Mf3gDmArwbdtLSsZQeIPwIuP3jKGbNU31RodbpKsY=@vger.kernel.org X-Gm-Message-State: AOJu0YzlSiap7IyAiqqVF08mMxiehN7QdSMstCSfa96DDpZQKMUy4t44 xv29NLYVD7Q8qLeKl8U4Q7f5YYWJcnfisXeLixqx4L1wQHDl9agkVbDo X-Gm-Gg: AfdE7cmxCm8aXcB+JX5nhu75qZjRLLGg/EgFQYkHQU7+88L/bvWKvqXgWBsLLOhfzMP +al7UmdBx4Z9CT9WEzsLqYsyE4QtP0m9WQ06MC/1r2243wZWohTyOW7eaSOU+qWXALyeIhJH82r NO5T4W6F7SJp2MdGbFs0kYCP3StXSIsctLeMvbZZm+jAWqGA4uNbStqKjgRf8IseO/u0ssOU6V1 unakEFEZAE+bz2Gfkwx81UDskCdFH1G9zBSVHFrOe0lr2BCrjncNIXOLBXunLjepNP9bC8I9icJ DbQWfVT2ouvxWu4ifCIECl9s5Yq25q1NzIKZmH5tBtpT7x7eBSDFjeowVmoR/EdYz+hA/ogXqkI KbE1rL4ufqt4lQzWHqlBtE4CBNDu2GC4D6si2YPzqt+i2CM82MBbm0iIggl6Ny9LDbmGKu2x/Nf iRkKijYVjrbWBVOqmukBIizOI91lhP5j9pGtjbItuQLUai X-Received: by 2002:a05:6a20:431a:b0:3bf:edfb:62f0 with SMTP id adf61e73a8af0-3c110ba1098mr8198249637.55.1783926359014; Mon, 13 Jul 2026 00:05:59 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:58 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 5/5] staging: rtl8723bs: convert rtw_xmitframe_coalesce() to return errno Date: Mon, 13 Jul 2026 07:05:37 +0000 Message-ID: <20260713070537.15903-6-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert rtw_xmitframe_coalesce() to return 0 on success and a negative errno on failure. Propagate errno values returned by the helper functions instead of converting them to _FAIL. No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 10 +++++----- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index d4bdda50b68f..2626ac8ba178 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1064,7 +1064,7 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pk= t_attrib *pattrib) * 5. move frag chunk from pframe to pxmitframe->mem * 6. apply sw-encrypt, if necessary. */ -s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, = struct xmit_frame *pxmitframe) +int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, = struct xmit_frame *pxmitframe) { struct pkt_file pktfile; =20 @@ -1085,7 +1085,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct int ret; =20 if (!pxmitframe->buf_addr) - return _FAIL; + return -EINVAL; =20 pbuf_start =3D pxmitframe->buf_addr; =20 @@ -1094,7 +1094,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 ret =3D rtw_make_wlanhdr(padapter, mem_start, pattrib); if (ret) - return _FAIL; + return ret; =20 _rtw_open_pktfile(pkt, &pktfile); ret =3D _rtw_pktfile_read(&pktfile, NULL, pattrib->pkt_hdrlen); @@ -1174,7 +1174,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 ret =3D xmitframe_addmic(padapter, pxmitframe); if (ret) - return _FAIL; + return ret; =20 xmitframe_swencrypt(padapter, pxmitframe); =20 @@ -1183,7 +1183,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct else pattrib->vcs_mode =3D NONE_VCS; =20 - return _SUCCESS; + return 0; } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index e40f69c13c44..79dbca1b5525 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -285,7 +285,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv pxmitframe->buf_addr =3D pxmitbuf->ptail; =20 ret =3D rtw_xmitframe_coalesce(padapter, pxmitframe->pkt, pxmitframe); - if (ret !=3D _SUCCESS) { + if (ret) { netdev_err(padapter->pnetdev, "%s: coalesce failed with error %d\n", __func__, ret); diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index 303b50051274..917e846e9ce2 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -423,7 +423,7 @@ int rtw_xmitframe_enqueue(struct adapter *padapter, str= uct xmit_frame *pxmitfram =20 extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) -extern s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff= *pkt, struct xmit_frame *pxmitframe); +extern int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff= *pkt, struct xmit_frame *pxmitframe); extern s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk= _buff *pkt, struct xmit_frame *pxmitframe); s32 _rtw_init_hw_txqueue(struct hw_txqueue *phw_txqueue, u8 ac_tag); void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv); --=20 2.43.0