From nobody Sat Jul 25 22:03:16 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013038.outbound.protection.outlook.com [40.93.196.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C264B239E6C for ; Mon, 13 Jul 2026 06:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783925811; cv=fail; b=J5TrJNWJqqkqMc0hlZfcT/aOyv0ZmjlfJDa6lhpFG7V4aRLTCPshMcZORl/vBYXTIu/kaUme0U1O03byyRjDeXmTsY2ENLVIJq0rNpVt043ntbe8V6H1z9UmrDi1S2Okg6pTznNWu0jX+Z/67HDVdBSDtV8QhyqJ4Xzn8ZbiYXI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783925811; c=relaxed/simple; bh=HsC/Lj/IzqzYDrCV7/Glfx8A7sKqiCoBAYd1S9uqZWo=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=D+ejeDgKKfDLnkORtQ0O9jH2M7l2DX/UIYurVuFYRHt/+gNc6hYk29bP4SYHDIGZ74UJ6zQ1yk3j1V9j5Dq1Xv2nhzfub28NJg6j8CGVEswhY4tfgJ17oKXeRitWw3vCJbcs7vTb8NKFBdjscsFpG2RPCeguDigOqMll+TvqYuw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=QP4yhRZU; arc=fail smtp.client-ip=40.93.196.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="QP4yhRZU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o2uOzcHuqpP1r6WahHJN3ebp441cMokFQy62P/W0WBCF+uDk04/fsIL2jXFZo4NIsO2Li1wYpeSO+a54YTdfbMmpgVFXU2fvXae8Z6+Z+eYTuNlBdmcOmiZZPvDP4lLcAzYz6bmYMTE895z0cxv8t4VT9E2JgSjnHdS9EsdVMOvyFOU7qwnYfd9hv4WsKx4wBx16Y/1hssv9wNKxqfq+ZwpwumXRxJ9sj1zyJ9gOIXT/aAfiEFm6k+dUV1OzgxPmrdlPJLkPVBp2o3XRFAluxR7QJ6oxiP2dZu6VUIdST/yNVAYc9We94h9IGPlBZH33U36LlYce3Ac5SZ0+5Q96tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XlNzZ/MB1pI9Pr+Be0P+4LM6E4XjNlvgDuLMB4uCDuE=; b=KZ34AJPO6Sn16k5lDOdfcqyfxlcFHyn0L0OGybH1looECVBqNiJaMdzmlV2FaENBzJjRVVfdmZaun5cgYsUaKlOBl/e1Zm5rUzTDo5jEy6GmRMuDiHqWReX2BpZpiTi2eJubzdepnAZ3yr80NqAHfRDP4sHqeGwr1c2TWIopGu1KYA+oYadIw6F8793SWiavKtjXX4nL7qqEn+ulbJGzHXowf4jdbZjB2uu3hi9PMOpwNHfmhynvfKNUzQbsJbsL+ucdYgHkwyVGjma0jCV4MS3+321KbxD0R0B8VJhd3bRBZTK9rL+KsZGKv2au8HK7h8AvMBRBgU+Xvl7CGePb+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XlNzZ/MB1pI9Pr+Be0P+4LM6E4XjNlvgDuLMB4uCDuE=; b=QP4yhRZUPN7jcWTOpRa07VvBlDEnjMTusdl3pEOxcviIGwtroag5Cb9xr8n9XUidfMDMvcxLtJN4UCmMt7tmzUqTsbBjniFDpSDoba4Kta54NLr8sL9DRS/l6hf8lP3iSzVuHCqh7pOgDt2r7ktycnE0RXu0WurHtOdC0pRA7bU= Received: from CY8PR11CA0021.namprd11.prod.outlook.com (2603:10b6:930:48::19) by SJ1PR12MB6290.namprd12.prod.outlook.com (2603:10b6:a03:457::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 06:56:46 +0000 Received: from CY4PEPF0000EE31.namprd05.prod.outlook.com (2603:10b6:930:48:cafe::9e) by CY8PR11CA0021.outlook.office365.com (2603:10b6:930:48::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 06:56:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000EE31.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 06:56:45 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 13 Jul 2026 01:56:41 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Breno Leitao , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak Subject: [PATCH] sched/topology: Do not override sd->shared allocation Date: Mon, 13 Jul 2026 06:56:25 +0000 Message-ID: <20260713065625.3572-1-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE31:EE_|SJ1PR12MB6290:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e0db1ad-85ad-4866-adf0-08dee0abe761 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|82310400026|1800799024|36860700016|18002099003|56012099006|5023799004|11063799006|13003099007; X-Microsoft-Antispam-Message-Info: 52Qgb643hta/Tz/XbfGA1J+3NcNWAf+/IQaq6Yrp4X0qiRAejWn+ZNx+KP+EXvmSiZPZWSeJ9agjqYPXVE+z8j2yUuB0lMgrolofjyuSpzteDdMToxSC2N4/V7N/j2NUBPyxCw7DrLNapEW8uQpHRs92fvLvf4pTEWe0HY6hHIROHXCK9s7V1lFd3Wdip3aLDJVqGDK2yJl0ibRG/ll+L9lCWNmtUGacUtJ8HWk55bX0eATNJWVM9D4pr0NX7Hbsk+gnFI9+rPEqbLxaCAMyrIWbQLroeedbJKRAgvcdvXE3i45eR7DoRZNewjIYThS+Cve/cFnCKy1DtVJ7saklbHh+h71mCQXKWSiTH0+NAXPp9DupOjjqgz50Khm0PV0O6DzPWXVVEN9ofG2zq/5LSG78yjPMsY6aO+qpDAHAMDZv0FLLKYrbPEXUqtYPeVTvcNVj2UWU5LxfpG/YtiozYp2/fFQkcqfWYQAGRuJWEJt7m71g1AT+oJ6+y4C0DVQCsCmele960o/D7gOj1qWAhiVpOkTlrHBS9VkfBX5dQTG4RA2zs8GUKjFyLi5pPxcx47QI3hdUPj1sxiXwmIFvyEK5z2gLsRH/IDmUDw+z7jeC4WC4qqDq7oCEPLiJuSHuqhLyZmRhzj7hGCdF96FpNDL1aizijqHlEW+s10g/5d8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(82310400026)(1800799024)(36860700016)(18002099003)(56012099006)(5023799004)(11063799006)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5OfJRHBMAOJy1Ym/YgM5bdRTUFH7rm0imwORlpiNpf35F5PRVA4imEJrdC4BE4LwXD3/kqFeNpNhheYnWmk/AaHuHtfSybsZhRPwy44VaErg2KZZuYcu9INdZm1uO8d0JIq+0i8+Jw7XaR3Yelc05Agboa1nPU4Q+NMzZslwpsT/1k9lqWqMENeEwti+08wNSiqrhv+pwFUunqb7ru3YXjwt9TUlvXVgfUoMlxDeDWEjRdKZmsQaHVNga11/bf9KUcopHaPF23ZWr+5b02HkBtvJwoHZbda4YVozbfaUPNaWg20Edzzn0OhypwvVa6dJTc2UBu8YPJna6Uz4Kg91QyMH+v1nSTNiAl28oEY7b3uaUxFAc80uA+2dbJtRNy8yU9MPjFWaXV3cBa7colOl/dFNJ0cUJDFKyL0gtQFdSbcSRQLJwZpiaYXbSFIQRPBF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 06:56:45.8269 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e0db1ad-85ad-4866-adf0-08dee0abe761 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE31.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6290 Content-Type: text/plain; charset="utf-8" Breno reported a kmemleak for sd->shared assignment on an asymmetric system with a single LLC. Post the unconditional assignment of sd->shared for sd_llc in commit 9e005ed21152d ("sched/topology: Allow multiple domains to claim sched_domain_shared"), init_sched_domain_shared() can overrwrite the sd->shared assignment for as_asym_cpucapacity when sd_llc and as_asym_cpucapacity point to the same domain. Return early from init_sched_domain_shared() if a valid sd->shared assignment is detected. Since the degeneration path only decrements the refcount by 1, it is correct to only account the sd->shared assignment once per sched-domain level, even if the flags overlap. While at it, correct a typo in init_sched_domain_shared(). Reported-by: Breno Leitao Closes: https://lore.kernel.org/lkml/akeMbyZGmbjWSZqp@gmail.com/ Fixes: 9e005ed21152d ("sched/topology: Allow multiple domains to claim sche= d_domain_shared") Tested-by: Breno Leitao Tested-by: Dietmar Eggemann Signed-off-by: K Prateek Nayak --- kernel/sched/topology.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 622e2e01974c4..b761ecda790a8 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2942,6 +2942,14 @@ init_sched_domain_shared(struct s_data *d, struct sc= hed_domain *sd, int flags) struct sched_domain_shared *sds =3D NULL; int cpu; =20 + /* + * sd->shared is already assigned for this domain level for a + * different flag. Nothing to do since this allocation is + * already accounted for. + */ + if (sd->shared) + return; + /* * Multiple domains can try to claim a shared object like * SD_ASYM_CPUCAPACITY and SD_SHARE_LLC which can alias to @@ -2970,7 +2978,7 @@ init_sched_domain_shared(struct s_data *d, struct sch= ed_domain *sd, int flags) =20 /* * Use the sd_shared corresponding to the last - * CPU in the span if none are avaialable. + * CPU in the span if none are available. */ if (WARN_ON_ONCE(!sd->shared)) sd->shared =3D sds; base-commit: 04998aa54848f15332202d0bea008d2ca1ed1713 --=20 2.34.1