From nobody Sat Jul 25 22:33:06 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013039.outbound.protection.outlook.com [52.101.72.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3915813B5B3; Mon, 13 Jul 2026 04:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917395; cv=fail; b=S9//gCTBeuuGlj9PzkGa7ab4olYNgbLNLuj977nzgYkps7br/XQFpuaz0Z1NiXqweHZjInPXQdPW6Dv8AatcpSzQUvwG/OPL8cQuWfN5YWnAUGWPl0LEICrnr9UWqQAlW/Z2J3JH/MIBEVUNcjaLSb8k3q9ZvkT0/kTD2dCsvQY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917395; c=relaxed/simple; bh=ZUO09b7tKfEkNWM5qiqw5iEY66SIIuj5DsXGQ6bA3u4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=nlJ3vMSX1PlZZQSdstL+LH9jcLQ0PxWGiw0SgbAshKDdemc9X6eYo5O30dWLAFHgVBNMv7xrCq8HjnMyV17BmpgFE1BXZ5UGYAQE9oEkha8GAa8Oqn4JT/n6NjsbsggybQjLeUwh9lCopE/pGluj+JSPEFzg8tbHFdsg+zQRNZw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bo14MFq6; arc=fail smtp.client-ip=52.101.72.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bo14MFq6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vx5DFrMx6Spzw9TKLw6Ac7HA3RlMMYH6msXo7xHQ7ezytxtwIO6NSVk6WpolZS+9syuZkVDrP32Cmkqrtc5rpRLQhabJQEtQ8eaEaNgOGXCO55aL/av9gUAQQc7ZGz920N71BKWJko14ZyN0QBuzQlBX9eRCj4M6iw7F07JFIsSOOXALRQAwEbZl6rsarcxGd+Lle5nCSmFn5urxTVP20SqIDd/uPLDpycvJz3n0fvRVmh6oBfZXXjdFV4AAlnPsgYURrQY8vLvWeRS3ZZk3ebixgw9Q9ZHkopm2zWfLoha8/hvzCrlqjvemLcil4GkQynJe5m2ygBP1hDJ7BdzDvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdLDYkWyWiJ2CTqf35B3bvhbjM7PIcSppgnmNL/kALM=; b=kKZ3nfSGAyxSLxok432o+wC+42h+c0BPEPd7LtZBuJHWB7n2TG7w/7+VhE0F597G6Rb22eJEFHxktab7+8kEPgIAeeUPDtrnArLqgxu8MQxGm8gfwi7AWx5qWLTCmqMYlQXdd+y+dUtAY2I0VjSdZDUPRoFyX3ECQSLn73Rxn8h267yA0SNqBCvjuSt2fbrB/U4Mq4hQZJwucaqufWIGm+R4hFgRS0H7UVqb3CAfF9Mywrne1xsf+BVgUN/XwJDXaCijX2IPYa8YQo5Nk8bvoBQP0TbJ2iz6y4MUUShCmgd6Dx8v0kvQzMz9pOvbU+RPeE/IUitZVyQShpCpJ+/4NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MdLDYkWyWiJ2CTqf35B3bvhbjM7PIcSppgnmNL/kALM=; b=bo14MFq6GFjTHtCJimtTsWppRp7oe7ZF+Lr2bCQm9UUNBEX9N9WQ6A/v5RG37vK8T2Ht6YqD5T3REHF6HlWygRBj3pctE8riqbKK3BuYSJaL05yCfL9HnnU+hTiVeDdkm+lgrZ14AAowdVLubiP+6hYIkRd3Ld+DarcVKxszLzYzfIVPh40ASp97fg1fJrungnROesb1E2W9ghPWYX+vzQHGnsUKKk/VnJ+wvQi5wDKT/LdzYnu8ZimHNoSRjW+jx3Z4LgVmDXU8Ii3h6EzbCVMHMiSYTExBbFE24jUekF9PIoFhvdKScBLHHjxH2dn8LwWXMGNGYL372ajR3cIhdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:36:29 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:36:29 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/8] mmc: sdhci-esdhc-imx: remove unnecessary mmc_card_wake_sdio_irq check for tuning save/restore Date: Mon, 13 Jul 2026 12:38:57 +0800 Message-Id: <20260713043904.4144172-2-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0036.apcprd01.prod.exchangelabs.com (2603:1096:4:192::22) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c1c67a9-3cd4-4189-bb55-08dee0984e85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: KUDiL6K1OicG5TZMru4oyK2WWrnEDSptJmZ42VLWK8+u0fZgTn47p2r9JnBd4gLrmDtNf2mkSi9LWtdxBIAS+hZP/JfNvCwUGH5kDeFfry3w5vb8m8PAdUoxTB9FznpR//s9z8lf/+2Rm82ZdQYKCIWPfTFnG/QSOKkT23pnvzRb2aPjyUkwg4zJDZvvw0amE/0BXUd6WMIbdSj58SUqmxLVGOJYUUQsNQo5xFIKsBUI6QBNSFAWflk2lff18pyQM1p8+jptLVCg/2hhXBxH8asQJh2h138lmIuLkUsRRrOcoMDP42w12E+REp1mx/rbwRwmsGRTm4k2BA9dBSP+kziODcnflcxi6r2YWX4oSfLONVXEh7hGoGBzi6gl1p19I6sjQHucFASzAxcy0YUSuYcla/8iw/i/blaXD4yMXqs0ZlD9cSwkX9hNYg55QxjzBOYd98KkxZMiiUT8U0wN/JRRdGPAi31zbkkXKpWK5KwRxyLEmsMXit3zeRYyyow0JkuhbtscvQahjwnTy2SOypKBUPWXNyhMRugUAk7lAoG3TFHWid9jLkuNDNuoDxMorJofANGz4PVFon2LO8CnJt0TDZeWRDTsisiR9jMRzOgUitf1By53o/G+WNbXiusV+2hEEKOxmNXjr8eKIcheH+k+3Ut4InZM7B/bJKsxFRA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AHoqGB5XVGykUCgM/WZrxumHswmvMaC91tIXKkiBIlHC1jxFLYRMBTJ/5wJi?= =?us-ascii?Q?9BbBfBDnZYThkxHmEyQb1tbLyqot2UXJOXV5jtbhRUWwb/66SH3oASI22rRO?= =?us-ascii?Q?l/TAOwTBzNkpGSp1jR6qhURtnjXJ2ShjdtxLqnr6xNhdDhjETiXxhJohI5hp?= =?us-ascii?Q?4C76yACjpRcpW9b8LRV9N9NGyXDQnvuqqZpK6tOQBJ1c/jMRrEBRq2rXvAGR?= =?us-ascii?Q?5BiTOQ0DqoMmJrDmzGcJxVG5ucu4ltaruXhly1YFKf4W1YHuOqkDCur6irvI?= =?us-ascii?Q?4j4KdSzX41+5T6/0X9tUBF0OaNvuqMRClIyqtBAdE1KlrqtYdBLAcMkUccuS?= =?us-ascii?Q?gXtG+7RPDnrwEsgGc2OgmTTf5MIitOK4m38Vl/HR8Y0JUrqaTJkQWxIn9GIi?= =?us-ascii?Q?RV3rp+zFxqXXJVLebjniwG6yU1vkLJ332pZod30XqA5wW8lyfaNA/kVbz8tG?= =?us-ascii?Q?TFdNczAl32mvEAscsPvOBn0Un4Y6vu1hnjtp/+JfILP0cmG5E9op9tQIXvRn?= =?us-ascii?Q?H4XI3ZSC4QSckZgb4wzjmxuHZ+IGI4qYcjdTVVY598EAUdRuYWBpb+2dhkkI?= =?us-ascii?Q?NAVbPpNs+j+PB4d8baurB7u9xop5nijG8ZHBu11RLNdAG6QrZPvT8xY10xae?= =?us-ascii?Q?vRJL6lhtm9sUyfstNSZO0IvcBmG90EOTOwQfb9e+s628uOZfexvetFzxb9Pb?= =?us-ascii?Q?ZbAGUzOu5dbZ6nQXQ3h5qQgb1EaOAzgED7Ewf8hl+vhVyHDA/wujqVX4H3IQ?= =?us-ascii?Q?Tn3gw7M7Reg+DCYS+gCR9Rt8y8Bs9/Lh44QQ+sUtxGS4+/3KDNO6Il6m2Q04?= =?us-ascii?Q?MjNGk9Gd3fzq4LLzjg/gwjGadh0YxUTk6OlbCX88pq1S1RCP1JlVOg2FfEiT?= =?us-ascii?Q?ORVpkGh7SlxcbiWO3aDOGQWUWnb/A0pP+9HW4YxfaHibr5DWZY8Y/Esbc33H?= =?us-ascii?Q?Ksg1ycY+dShTvHlPAYyRz+Syy9qkFZHkxUMvdPYwNcid+d0Ya94grF4pmhW9?= =?us-ascii?Q?IRsf/Zr5yX02wq91Ro+Oa/vc4u9tC0O8h+sD8ZkIT6l4Vw2xMFJfS6sSejGV?= =?us-ascii?Q?RwOfSDvNMWsaWZFhK072Uw1Lz7w2uejMtHsAz6GQKlbBHkVGdOxuXwY6XSz1?= =?us-ascii?Q?yYJENHbYQ3U37n7FJeg3OW3riPTfzn8d2tOuGytKbfPi9OyhFYFwVFKpvtuo?= =?us-ascii?Q?ud0U+TnxC935ij0MMpLCN65UobDozYqruRR6tR5BSV6sH+7R4VmNR0AVr/r0?= =?us-ascii?Q?6KIQ47nll4lU2l1NORtZVbIbnpqJTLWEOPKskjmD6YMmx9m5c9Zx49eukGTc?= =?us-ascii?Q?jYGegA/decmfz5g7QPHZGpenHupBzh8Usyvm3q4t/zoMaLvxiy/bK/dGihVs?= =?us-ascii?Q?if5jmuC1odmNLzEmruerBiMGgvGn+uEi2Rq8P+f2y8eWFLFzbB2L/KzEOHaB?= =?us-ascii?Q?2ckLK/YuXzpgyKBCVmxud+HqA+iq9qx/DY4hwwGuL9nRGdNyshSX4OP5FxDw?= =?us-ascii?Q?mdunDo04chBt9pm8zclv4MQG0Q3fKNHTyJmqwcvvnUJDlHVFIyINN4s/x6za?= =?us-ascii?Q?Le889WS1tzb23KYZ8CrXxRj/6dkcDKzEv/O3G4MaHccqpE0VBslRcgX1SzHp?= =?us-ascii?Q?6v0IrC52cDr9Xzr9sD/lZo4TstAj5YRUCLjZbOUvHiaFgnq9yiWCQAfNqI0j?= =?us-ascii?Q?VUNbgOt8685/ThdBjBkdycC79iXwdhG4p+sINMT0kGyLfkuaovn7Mv2/JIf8?= =?us-ascii?Q?qIzfog58N5vGkGtqldlSuSBLpMWqioQcCtH5/N+r7rPmSEdZoKp36lG3RZJ2?= X-MS-Exchange-AntiSpam-MessageData-1: 55bRwmzFhZp9uQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c1c67a9-3cd4-4189-bb55-08dee0984e85 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:36:29.1092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 22jorbsHWrMlf/B5NHxVcWqmiC69V/G/EzQfwixZego/YlYImnmmM59FnqmwyE7vWVsGw81AfPGhRE/VUOiHje0PLD1ABkjRQD2fBsAKDH4qbIwU196SubBJZy3H5HvJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang The tuning save/restore during system PM is conditioned on mmc_card_wake_sdio_irq(), but this check is unrelated to whether tuning values need to be preserved. The actual requirement is that the card keeps power during suspend and the controller is a uSDHC. SDIO devices using out-of-band GPIO wakeup maintain power during suspend but do not set the SDIO IRQ wake flag. In this case the tuning delay values are not saved/restored. Remove the unnecessary mmc_card_wake_sdio_irq() condition from both the suspend save and resume restore paths. Fixes: c63d25cdc59a ("mmc: sdhci-esdhc-imx: Save tuning value when card sta= ys powered in suspend") Acked-by: Adrian Hunter Reviewed-by: Frank Li Reviewed-by: Haibo Chen Signed-off-by: Luke Wang --- drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index 18ecddd6df6f..6526d65538de 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2064,8 +2064,7 @@ static int sdhci_esdhc_suspend(struct device *dev) * to save the tuning delay value just in case the usdhc * lost power during system PM. */ - if (mmc_card_keep_power(host->mmc) && mmc_card_wake_sdio_irq(host->mmc) && - esdhc_is_usdhc(imx_data)) + if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) sdhc_esdhc_tuning_save(host); =20 if (device_may_wakeup(dev)) { @@ -2124,8 +2123,7 @@ static int sdhci_esdhc_resume(struct device *dev) * restore the saved tuning delay value for the device which keep * power during system PM. */ - if (mmc_card_keep_power(host->mmc) && mmc_card_wake_sdio_irq(host->mmc) && - esdhc_is_usdhc(imx_data)) + if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) sdhc_esdhc_tuning_restore(host); =20 pm_runtime_put_autosuspend(dev); --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010047.outbound.protection.outlook.com [52.101.84.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05BCB3438AB; Mon, 13 Jul 2026 04:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917401; cv=fail; b=tRtx0b5V1J4sHQKO6/5sjARgnKeVaCm2Fogrydn6KL/RtwAsjNK7nNWdC77p80Eq0vho749UvpPbKrkbP4hgw+7XDyuU2VZRTPaT0v4R0pt15KKn1BF6pN+m71KOAouVivL30coMM0G1J0RwRF95KEx35AkxEdK5OtXor8ijovY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917401; c=relaxed/simple; bh=2OEDquF6HEXP0sxB0+sQAR8bFLwCWTw51d9L/0BGlEY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=gn+2LnZcWY/ZuQnewvTQc70L8OqcbvDrFT89jmw+3VbIz49SC5d5+hmzvJ13rTLrEgxYR4gcScBbPByMddeQUEZHtXbB3F0FHJ05W3Dy3W8bCgzFRmUhjVw9pzJ80u+SslyTl/5XBcpfMdNb9nLUwXi0oqeX1eLQ6C0Jpm0QSW8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=hEer7ZcF; arc=fail smtp.client-ip=52.101.84.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="hEer7ZcF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PZAPKbMRcqfmATY9mHu4v0ajiooI/zBOdCHEJ908A+DIw0jz91oVdUZltG249muWbedeCsZx9bKK4LR+GLG8+/u8YuXkMjnxKAKYuKJ83PmrgG04t1YcAbSkRr8CMdugw2v+ZPmYjQD6ASwnM6m5pAMUJ/aR7jpABPxwzin5oXKqCpB++lOqChs+cfNANwQ0dmseA8FbGv395Wz73CJBL4oLl/7NUJUqgmsmrgcimf8PSe2ZywunKJyhjjmouDBSCMwUG812CrKcGYsQNqDtR49YVpiS+tWTnhoGQZ11pdjpXh7vjzMoL8HgaswhHlzgEMRD1RvW944GEnXtkVUoDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=stNNZ0M5tcRj0eiH5J7xatsBtIVCcGsFGE5+YMHUE5s=; b=vZagXt8hzlsl6RjvXSJdvrUTQ4fqmTwVtShHKJF81Qey83kIu3EowIwppzfE/I9bhUTdCaY/7aNJ6YyTT4kZCTnob0Er/em47i6j3HGEX0TgqwN0npW5F0IOz8/Ov9yloiEyVNuhHPLK7hSbZmyFq2JDWs/cYuXhcb4mL/0hu4BVvsvPodtRZFDSPoM7VWwiY/kjcVXxfpo5N1FqqzBgJbhLT3IW5OF+Tja6391aooXIfHMOjmuFOrfM2HrFiyis41weSv11Urj9SJrznBe+7rEBr7ZXGZfUsFJ86RlYHoqwuk+URCWY3j1Zpa1VRdwRR78k8MIrnZTxG+NnCeGIIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=stNNZ0M5tcRj0eiH5J7xatsBtIVCcGsFGE5+YMHUE5s=; b=hEer7ZcFkYLB1zv59gxZ+bqM3y3R/1EcJmBdm6tF+L8aXsZEZ39ymTN/UAQwlQLjz0nFgjMqCJpU9NtJt7bDz8ByUGm9tqW5fLktXK83BWskm2AYB/BTdjmTXftfxws6s/YjOzgqOerxbb75GP6U30hKqjSwc84MNCjdXlW9cKm75STdR+w2GMutTsHFLkIF9Opoewns6kjbKBt6jwPvddmvAPHGP2IPJZDnKRSY2yYKiHgfbzRZSE7HASWlRsdO3z41LFJNdbr5/RvdBrLgzCtLhccrfewc6tEIvrMfjL6YdzmADK/Xh6R7IXyhawyM0lKVcKqzey/NrEUwEVdqzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:36:35 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:36:35 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 2/8] mmc: sdhci-esdhc-imx: restore DLL override for DDR modes on resume Date: Mon, 13 Jul 2026 12:38:58 +0800 Message-Id: <20260713043904.4144172-3-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: dcf9f814-de57-4ed9-fb83-08dee0985209 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|3023799007|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: WCmcq1/WQxqp9YJ3MrN75KM62UwtYRVmbdAMtVurcPODLJJlixTPC69yggm2Xguhq4DpQGztJ3gdBZpuE50mWJ4jIJ2rUgm1qP2kk77QT8g/BysFE1YL6zmV9ADlIamaeNPjS+fuEq8lyJckNyCB+OyBn6Qs/xwtyR7Ajur2/YyKPHX4FlYssHDhH6zuxZ3WU2Dy2y64mDmg7jQConEEF4hiLfA5beh+cdVgX6GEgDNMyFSwOPIfeQfXlAptLFCxbnH/aBFTWGTUmyZDb8sBQfclyZK9gDCACNNJVzT7a52zY3YzgsaI1c39pHlZbKr8aoULAC9ONXa4KhpN0FIsjgpZFX/kZHAOAgk9r3qSK8y+siFZwC9FpNXcYgVg8h4k2C26svH23lPO9PvMLNRtvgYviUcecNMmrI8Zxawq6rwoTRObk50za7xRwKTnYVndC99nVq6zvMhu/+ZJLHd++vupTX2GtKroclvTtooUOpynWOSK2G8oNYjBLK28beGJgUit6pHAttwKOgsCofvEeP6EXvCRhMLZVDFd3gYlKBciMD5SkyBD135nI8bhiaXvUstu7a+02iZ/NqW3fMIV65AdI2KZ9reLlWdMzG4edYS694gN4UEpB0ADNFHXFC8U1iGdPOwGcWJBHpzY/QThMxtS0ATivrnod609KXN4fDM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(3023799007)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gZnT4TSKEsfMlR/843K9cR9KTuGb1lUpAHwIozOlIy3df4uvnNDD1y+IktB0?= =?us-ascii?Q?A4OCByrS+6ZITO4m7AVDekeYLVGQvUEwvwFN5egryV7OrR/iyEEh0mXcH4IX?= =?us-ascii?Q?NEp8N4sXCBqVPP821Q2Pk+sh2UuZHSip+nINsUHv2Aeq2Xt/iWf2byW3DIxu?= =?us-ascii?Q?iLhn51GI4r8xS05GuaVoZw9MQy4xZVBYE0tADVf+zNW6mGYnxLKzkOTNp87s?= =?us-ascii?Q?iLr3UGY+9GH5WWqjaNECvE9VF9OCZq9RcfSXBURAeVK7hLfqhDtHah0cU2uN?= =?us-ascii?Q?AqhGcCQt4Jgrj5VzgawUtluVosz6C9vTGXxeMmevt2kLUWEMb7IJ87Kmie6F?= =?us-ascii?Q?z6kv/JDzZ7KmifsV0x+CC/xCtk8Y2kMytvLSHFed+pWXJzNoWbXJlQyYTVm4?= =?us-ascii?Q?maai54NfRwWYKC0R3jhsuQT2b326Gqyf17j7PabdNMK5MF0cVY6gTMWjVy6e?= =?us-ascii?Q?NFAoaAFiKMlBZ7Bg27rMlsFAFbWcJFAOwOYIRdjxBn0r6M66I7dBwwGENqrZ?= =?us-ascii?Q?9cq+cXVmYmKxDanMa/HTfArhpcK+r0yxJ8z6qXOZE4beBjIgy6qzVD8UCply?= =?us-ascii?Q?z/YwVyxVaKnCxJ16zfP5gJUIqTdVnDDjp5bg+QTQ1bc+LA0CaKnjVvQUtXMv?= =?us-ascii?Q?nBlFhRkU0Zj+qIELE1JztvV8gja6M/8sLEqyQv+Pd5afUKBVxqsQy0UO/9b2?= =?us-ascii?Q?wzLeVZVIUwyDz1lJza8pO8lwc/PdkyoLQ1PfjwowqlsdbMmWaHPHNelgS+sZ?= =?us-ascii?Q?ZD5d9iobXCz4Kteumw9Ao6V8sGqBnQRi9I6O7utn5E//HskCIdiyxkIeRfN/?= =?us-ascii?Q?2pKU8vyh/QXsFIe8SQVv7F5qM5evjzfqxztgDaIYMec1VMuJT7ek8M1B5927?= =?us-ascii?Q?LECMogaCD74fJrGsAmaqwLL3ReOQMY9nsShsALWIm0qJx+HXJFCfyPV1bX8Z?= =?us-ascii?Q?ZbMvRc9lE3ITCgqXSkKgy9KrhChae3YQmT3i8rBa01vfNjlZUzUySoRTNIDm?= =?us-ascii?Q?kTHjoQXVsG3JQ0ufEFY5vKwBSvp22G+TRrW29yTM3tGKOO9qFUR0PdbBPlI0?= =?us-ascii?Q?gv2hiYvOnVhxvt5xcRywIIAaHPBm1nytz8dIhS2ep9VCCpe7gqkBv6MrW6Bd?= =?us-ascii?Q?4haowGjOkCKneErWttzIXngBpa7/3ZpdtH7hRoX9V/TgmpNqCY6Oc8qECBUA?= =?us-ascii?Q?O5AKY4UulH4CwgA4iNQIuZr2fCacZRgi5rYQFD3hX2VPfKG+XiQ/P2bUjXGk?= =?us-ascii?Q?kkARJ8IvAVXtqZCSRjaTAzI8JwLuM1f4uOu7HtEff2RUKk7F61dC9DxPsuB1?= =?us-ascii?Q?vcuPOhfkgJWIUqKGtQU9MpR84E7I2W21Lp7EId/AZNKvhNBODKLlCWqNM79E?= =?us-ascii?Q?MW82lYo5Qo0fORtO/lFcnXfzBuA8Z+2rI6cQM1iRuejEJEq3jnqum0tLAj7X?= =?us-ascii?Q?FuaOK5VDVC9uAWtShwNT7EDsca49fvLu9DlDicVRDUJ7TKnM0EkgRTqYZ2sW?= =?us-ascii?Q?/O1SMG9vlgJDuDijFtdCBb+mkgjxw5kFmMaYyDuKFwAKj4FlyKOtEfWW3pDS?= =?us-ascii?Q?Xe/wy5r9/Sv9iNK0IUSR6NhPsjroapAVAZoX/V7ScjfRHBj8k48kdpSx32jE?= =?us-ascii?Q?DXXWPgwUzpDTWwYy+kamsfNe9bb4NfsUGIwUyBPov2hGuBOjpq4k8GQ7zt9E?= =?us-ascii?Q?qfFSMVAwnd1k7fdzax1Kv+9W0HcQFXuaeHtnbZPd7XfTB9XAVPdG8BYpo2J1?= =?us-ascii?Q?vxh+50pfevz1ko0pRk3Lw3IZoqi5KbG/8Gs7VoY+Jzy8xD6ovdRT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcf9f814-de57-4ed9-fb83-08dee0985209 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:36:35.0400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i8bHLfoFe9i2cUIydHiTlzmC5sXXW7yE8nOFa2V6tnGo/i8GG/gZQNMPofRP0cRULmDQIlRbqVf6cCjhH+KBIc0ito1FSRbbl/tKtcWSCr/7pfMGOcyfLOpwjw32u1Z6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang sdhci_esdhc_imx_hwinit() unconditionally clears ESDHC_DLL_CTRL by writing zero. For SDIO devices that keep power during system suspend and operate in DDR mode, the card remains in DDR timing while the host DLL override configuration is lost. Extract the DLL override setup from esdhc_set_uhs_signaling() into a helper esdhc_set_dll_override(), and call it on the resume path when the card kept power and is using a DDR timing mode. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Acked-by: Adrian Hunter Reviewed-by: Frank Li Reviewed-by: Haibo Chen Signed-off-by: Luke Wang --- drivers/mmc/host/sdhci-esdhc-imx.c | 39 +++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index 6526d65538de..7230d70e02ae 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1349,6 +1349,23 @@ static int esdhc_change_pinstate(struct sdhci_host *= host, return pinctrl_select_state(imx_data->pinctrl, pinctrl); } =20 +static void esdhc_set_dll_override(struct sdhci_host *host) +{ + struct sdhci_pltfm_host *pltfm_host =3D sdhci_priv(host); + struct pltfm_imx_data *imx_data =3D sdhci_pltfm_priv(pltfm_host); + struct esdhc_platform_data *boarddata =3D &imx_data->boarddata; + u32 v; + + if (!boarddata->delay_line) + return; + + v =3D boarddata->delay_line << ESDHC_DLL_OVERRIDE_VAL_SHIFT | + (1 << ESDHC_DLL_OVERRIDE_EN_SHIFT); + if (is_imx53_esdhc(imx_data)) + v <<=3D 1; + writel(v, host->ioaddr + ESDHC_DLL_CTRL); +} + /* * For HS400 eMMC, there is a data_strobe line. This signal is generated * by the device and used for data output and CRC status response output @@ -1404,7 +1421,6 @@ static void esdhc_set_uhs_signaling(struct sdhci_host= *host, unsigned timing) u32 m; struct sdhci_pltfm_host *pltfm_host =3D sdhci_priv(host); struct pltfm_imx_data *imx_data =3D sdhci_pltfm_priv(pltfm_host); - struct esdhc_platform_data *boarddata =3D &imx_data->boarddata; =20 /* disable ddr mode and disable HS400 mode */ m =3D readl(host->ioaddr + ESDHC_MIX_CTRL); @@ -1425,15 +1441,7 @@ static void esdhc_set_uhs_signaling(struct sdhci_hos= t *host, unsigned timing) m |=3D ESDHC_MIX_CTRL_DDREN; writel(m, host->ioaddr + ESDHC_MIX_CTRL); imx_data->is_ddr =3D 1; - if (boarddata->delay_line) { - u32 v; - v =3D boarddata->delay_line << - ESDHC_DLL_OVERRIDE_VAL_SHIFT | - (1 << ESDHC_DLL_OVERRIDE_EN_SHIFT); - if (is_imx53_esdhc(imx_data)) - v <<=3D 1; - writel(v, host->ioaddr + ESDHC_DLL_CTRL); - } + esdhc_set_dll_override(host); break; case MMC_TIMING_MMC_HS400: m |=3D ESDHC_MIX_CTRL_DDREN | ESDHC_MIX_CTRL_HS400_EN; @@ -2123,9 +2131,18 @@ static int sdhci_esdhc_resume(struct device *dev) * restore the saved tuning delay value for the device which keep * power during system PM. */ - if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) + if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) { sdhc_esdhc_tuning_restore(host); =20 + /* + * Restore DLL override for DDR modes. hwinit unconditionally + * clears ESDHC_DLL_CTRL, but the card is still in DDR mode. + */ + if (host->timing =3D=3D MMC_TIMING_UHS_DDR50 || + host->timing =3D=3D MMC_TIMING_MMC_DDR52) + esdhc_set_dll_override(host); + } + pm_runtime_put_autosuspend(dev); =20 return ret; --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010047.outbound.protection.outlook.com [52.101.84.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D65E433A9FF; Mon, 13 Jul 2026 04:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917408; cv=fail; b=kgV4CLQtJljDg2SJ1PA2BBj58OFB3wubhI0slgqClD17+OhaJt2Ykx7R/44VvR5fX1S7s4VH2pcLjbPXtcMBbQamjd0dxVm/Hrhy3AV0rWNmaY46FqjbfEqO4sMnSYk9johAXa9zNuKEYu+8ktmeptQsXxV2qfSnXUEOo8IFr7g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917408; c=relaxed/simple; bh=SOCMc9RC4ueSnII0T0YI8y390+r8NEMwN1srfEN9bpw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=TgrabvSuk7SfHgagvYxRHKQFYYDwh3OYeoPH+7FguSljE9GAYqhnZOUwaAiWa7PNIiuF7S7L0UuHf7/Wfm9fYWLp4Fe9kY6hqFuxCesZsK5nB99xtKqyySh028TQOhM0ZteQzgXvGGGru7EWH+FgB1ZPQhv1/b6LaEyWwK8CfD4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=JdCXwEPA; arc=fail smtp.client-ip=52.101.84.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="JdCXwEPA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=foyojiBCgCyd03cd6tbJsaXfG6T6btp4QmHIZO0GJ8ZI4uEn3MwGdVc2oR6hFhuHThrAFLcUzGBSpK3vFCqiC83AR1mgpdgrn0ju85stMpcxLPSWnEzWWjouvfcHUo5h3Fs5BqF/yEAGUD9uz0wohAxrLS0zVgL+WDYSwx+Lbjg+xs2L5ghAdZXrapjME/HFMTcSP4RwwNs1lZ2iuWm8SkdWvV+5KvGMECU4TGCH+51LkS8i8XkrepGN84vfiPvzVcFcZcSlJlX8YVA7+jUFmnVu9xVkmjJXWLCyyxeiV3JBEShkxmoln+zxZsbM0hGsBBHnVAWrshg7aMaSOHSmBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jRGwQU7IScsHwwXN5wix8xDQEc+yVemnrH0ZO7mMhLI=; b=aBl8oX3Ly6ZlIruAQusFIcxMEckOiORxws9ekH+4IsSiiy3pmWZDGLSx8EU95G3x9ScxveVpXf2vV1/uHQ6gflAhv89sLbw0JnR9tjHepDxgWD4mkgVTODBCcQp+sHebfALbkagATlh5S8sackzLorIP5/gWGGW84UyNMqH7G/DDs3GjL49pw8w+DFRcYdjdJ26qgpUebk4K4W4KgbAQFx9+OfoM4D1PjHJiQttOB8N8aS4+Pj5z5SLHZ2h1kknG2apkPevSCf015TKnqHt0a05WzvgS1lVI1qRiJ7IQTmtmxDSReJRphM3jm8PjZs6DJ+xTpGmcvsyFPgMJNzIJiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jRGwQU7IScsHwwXN5wix8xDQEc+yVemnrH0ZO7mMhLI=; b=JdCXwEPAjw1kmUAIHpV/pWPg0npxJu1h2gIpMdzTCe2GexLfNfoqqXWpY7AuuxdgTwWfQfvvas552Een4/Lb6TNNjEzDon7nw6MzRrjMAon8u/vK/B9dwwuErmq+jWRYcP9knedgWmcoZj2L9cCU9nSK/Zv2bH47Mgs3I3Fu2URhHqADnPA47NhQh+yPBu8y0F01Wa9I51UfOrIiTT4sFcbGhqWWt/x7h9XaLHmZppNBG0zp37JLS6yM2ISV4lj2ywSR10RhxsR3XLNUn1lEW+vQWvMHTLKTYNy+QGJMMCl3zlCcvp/fWWjSGrg9ga8fdpaMUrITouP9unMYvRoTXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:36:40 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:36:40 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 3/8] mmc: sdhci-esdhc-imx: fix esdhc_change_pinstate() to allow default state restore Date: Mon, 13 Jul 2026 12:38:59 +0800 Message-Id: <20260713043904.4144172-4-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0054.apcprd02.prod.outlook.com (2603:1096:4:1f5::13) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: 28885b25-448f-4d17-f987-08dee098556c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: bR2GE/FNp6ASejYxczRP1Ku11ebsn/UYLWj6DimiCNPh29v2L0RIRnmtWY8xN5JDJD/XG9PikYQyKFe+z3ZkMDGZyROjAM9zK38j01YjDIRMZrhVy6WzBkzpPz2S5Aw5YZ78v3QLgCd36uj03fD4iBjFXuZ2r72+0OEkTPWgOJlOpIhUsKz3Y+HkstC6NQ9siqXg9o7M7zUK2z45DLL2qE+wGKUwTYrl7eSg3YEWBnjXbbWQbZttepHiomDyXsSl+GhSR/pHxK997qUMgLxtSRMWfCdiISf2Nqxxk/KqSAqZf9cfqmdRAOmgfDzFs3ksLAXZkn1MCnW222OLnaJVBtT9pb7Qu2ZBLnHKJ0kLmIbjoTSE2VDtsSLtWTCb3JWTyW0w7ITCUoXjM3UZ/qvl2iLFzOhLJ28AiXIKJvvPe4xpHcWlGaXgxaiMyaYa6+tpKlY+Yq/xHg/b91MmTgnLBIQ40bs6u8+pg5iqeXAU/pPlKCdmwPs9GIToVVe7+dXqNAo7GIL8Mbb3xp3elinq8CR/WAoAz6bZQus92rQb25mSTNG2LxwRRY2AAwjunHsCUnQuCROy6MdBGPDUpK09rcF9TSMLeFHJhRoAVbIxYf1rDbeuIZzSIrCqFGBiPkwBvNu1EagvBn/pPjIX3S0fBNgxkJAray/6Wnig3jxJv6M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WJLRR/fK4IGIuXXE8w0jKyXDIrHCSrjC1tjPXmXVVTfn0ofZhA+z+Btao5QN?= =?us-ascii?Q?k694BkQ4HblU1Lljq64yVxUxyvfeEfCidH8EsiaZ4LwLOZbeRqS+RxZd47oj?= =?us-ascii?Q?uK9a65ZQ+VRZllrnod037mmHQImtixtZ2mnDrEyYOmomXP6F7aD2SGbmBYvx?= =?us-ascii?Q?paMLga/pzRYUbCGy4o4Bgj4ABqat81XfYYquE3qD4mj2hcIP5sn15kHkszkH?= =?us-ascii?Q?1nKxFCyz01Hs5lVX6sVQNABsI3j5X4n1cjuKZbHJNJdNNabOTdB2PNLOgCC1?= =?us-ascii?Q?koiHhpd7fPM38w5XfPls+IhAQ33LF1ZWv1Jmst8gPPuc0HKARTqy90KD5QxA?= =?us-ascii?Q?k1czY2Mh7z3UXHMpdVbRdBL1gjw02SyQm09ltnRsvrgmA+2Rx2bmlAABGRvt?= =?us-ascii?Q?DLPN5JqavqxRKFmENXHEWbc/yySQBzVacBkpFyOjxn4Dvs4F87fPOfEvufr8?= =?us-ascii?Q?zvssI20/ye2H/GJU52WXJjpZF5dXLvmKf/KnzHsrr7hs+jZPqU2qZpKwieXP?= =?us-ascii?Q?Szmy3z6yRGDCZ7fU0ozNSss3lIpaUBOGpmp52Hf9wVbh2ipoQml6Zf26921l?= =?us-ascii?Q?EjZpmb1RzYF5nxTWhMAhJSWkM6iBciCQCotiy+G49ZXOfG4Uv29bmFbkY7vq?= =?us-ascii?Q?sdFAO3IRqT5VIXBZ3n+msS3t5weKubK0SRP5+HsUoJN5tFDJPqHbGg+gfdNK?= =?us-ascii?Q?0Mli0E+ZJ5b8L+OQSq4CbTjk2Qx6e03Or6pYSSDgCO0QK9dwvdcSsv7BZchq?= =?us-ascii?Q?WPEGnJFHPXjNeD/k+wa3N6dbKPdgQKaTmfIgVCKj+I1Mfd4wA9RBjskRgupZ?= =?us-ascii?Q?DNHhCgt8R+3t9UN0cJZOX953mb4ag0gSZLn9E8RbxaRCndcOxQBEzZMsnjBZ?= =?us-ascii?Q?QOPxl4TjMoBzZIiqAuRLiET7YMIXCVhKT7G4oWU+PUoNWQD5gSUs3V0gVjNK?= =?us-ascii?Q?uusNU5pQ4+jdirY4qamDAZfyfBHjooMZhjnlzlduCeeWLxBjkjBcrwo4t9HZ?= =?us-ascii?Q?+AjfCZUXc8tj7+F4RK544gRhBLOmPvzexAWcuExFakLQDtZD5p4QzUVer9O8?= =?us-ascii?Q?nPOy1xXiuP63x7BSIb6U1ljzCCObUjnzYl3mUeW7US0fZs/hh5X/SUohiP7x?= =?us-ascii?Q?rkEDCSLRMlCFpORJrtKw2MtFAkERiYeL1Mtf74iVomXc4atNgV9ZZ3giN3t/?= =?us-ascii?Q?SpUjSX6wYFzFYlUfj6HoR+Z2Lla17iTNvf8HBnxGouXHWGoBORFrmCmhYpEM?= =?us-ascii?Q?4M+SsuFvPSFAxDtOcUrFGQWmU87o+blanmR+Wxlk6AVwY2g2WsKGK5psDuRG?= =?us-ascii?Q?gof0UZaGb47iZNqYzNEfktczyChFKctZu+tzro64Hz+HGBvXciZHApImVxWX?= =?us-ascii?Q?b0CdFbdkvyVjFTA9b4G00Mkx9kwU5Mfr4v3KJB/FNXe73ysx/1Bx3A5WoY9l?= =?us-ascii?Q?BK/wCx7kx0qDBKimEw9ywl4HZ2TRbY2HOeHTm1czmRL4WjDjxHIxRQGKcW+C?= =?us-ascii?Q?GengryL6jRMelN6U92RMaNDavPcelmces2OTkRpvW8oesgclI//4troKrYMz?= =?us-ascii?Q?TIieZQ703JQFbnQImkWMErzkuQQX09/NXTgMgGW2ja4DtgRNMxqBTGblmYq8?= =?us-ascii?Q?HEqaPGz1nN2hDWVvVKAecchyHR4NUVqUSoDiVosDb1gUIU1FxR8wXLBqxisu?= =?us-ascii?Q?sB8qd5gmIfKabqRXA7uSbPKb5oAxvlfnHcYXdejyBudE+l/nxVNec/yK1BWY?= =?us-ascii?Q?S781xLsZYI0gCdIgMUmPrBAxvP9P5pRKmjB4SFqGDj3fecu8oztonvVt0hE/?= X-MS-Exchange-AntiSpam-MessageData-1: dj1osbVodmkfew== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28885b25-448f-4d17-f987-08dee098556c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:36:40.6965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N03q6iYZtMfXScSJs6X9FvU3wX9arYlqzGoqgBUuwKyQ4wJYy3cElQGImLfFGn0vP1cvddkWx/uRYgpt2P6GxSCOzTWXFDJOvMJjY0Af8T/cpxBQP6JsOT/CJ4vAFan6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang esdhc_change_pinstate() checks for pins_100mhz and pins_200mhz at the top of the function and returns -EINVAL if either is not defined. This prevents the default case from ever being reached, which means devices with a sleep pinctrl state but without high-speed pin states (100mhz/ 200mhz) can never restore their default pin configuration. Move the IS_ERR checks for pins_100mhz and pins_200mhz into their respective switch cases. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Signed-off-by: Luke Wang Acked-by: Adrian Hunter Reviewed-by: Frank Li --- drivers/mmc/host/sdhci-esdhc-imx.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index 7230d70e02ae..ead4685d621a 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1326,19 +1326,21 @@ static int esdhc_change_pinstate(struct sdhci_host = *host, =20 dev_dbg(mmc_dev(host->mmc), "change pinctrl state for uhs %d\n", uhs); =20 - if (IS_ERR(imx_data->pinctrl) || - IS_ERR(imx_data->pins_100mhz) || - IS_ERR(imx_data->pins_200mhz)) + if (IS_ERR(imx_data->pinctrl)) return -EINVAL; =20 switch (uhs) { case MMC_TIMING_UHS_SDR50: case MMC_TIMING_UHS_DDR50: + if (IS_ERR(imx_data->pins_100mhz)) + return -EINVAL; pinctrl =3D imx_data->pins_100mhz; break; case MMC_TIMING_UHS_SDR104: case MMC_TIMING_MMC_HS200: case MMC_TIMING_MMC_HS400: + if (IS_ERR(imx_data->pins_200mhz)) + return -EINVAL; pinctrl =3D imx_data->pins_200mhz; break; default: --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010047.outbound.protection.outlook.com [52.101.84.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D50D3446C0; Mon, 13 Jul 2026 04:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917414; cv=fail; b=IublmgserjIdZTH3wixYqC0k+NKjdd1qqgUZf3vyJvmw+TPCqpnZ4oWNvTtRnYIxFu6fV6QOsv/YYBqS+2PNs+Kb5bo/mrj3KqUpmrchiAy+vpDxMU5H0+HuGoFTBmNKkYQBYSr4+ddvaGMofji8wSJoXE6bSWXvnSJx5RW2kFk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917414; c=relaxed/simple; bh=TumYMlT6WgIVsx1M0fRcUxD9F2gDaVwIZtm81XMuhn8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=nxIo7JSpvUIOshIdlN6s4hKpTGxHwNHSNIrLARqo+xRokeQqRtwUBEP78Ta6jMribmzqmvFamFE/hwNpLOh16hTogDU77tDMnQrdZiXdmR9TpkdsRNuBpNkV+om4AOZb0ziuMQc7PK/YpIdMS+Ua+ekOa8m8vELIKM8iiamAtQw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jj9/xrFY; arc=fail smtp.client-ip=52.101.84.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jj9/xrFY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lUptadSnq6RTWFV81HYXWMjmH4AjGNUcR3owhYvrsF/wcee2AtJZzd8gdlFloD7lBHbgWXNSFV+oUjq1xLQTNyMjrQbMJJ2wwOLGwpmcOuL4wYM8HYNK21L3j9zI+RjwYJrUl21Hf3z/OiyRf6ifvnBehMafymB3n+PVX+xvw6cTj8nEt+Uq1wGqxnuo0kIqXI2VBF8GKfrn3jF4XjIuPPs02zpkT+np3sWNU3zujdkukzf4IE13yxLTpTi6LRGA8lZngU2nu0HRXSxJr0h0vKJ/GjCMESLcxK5okHpE/M71aPBL8NC6YMps87fRqD1Ck4JuIZy45xLYR1ae6TcG1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=55+YzZLEUnFYJEqI59kTtYuhrT3z6KAxXnGYyybTfdA=; b=rxl4BoSjpOwIiK3+hxExrlntDjwFULbpskHpVWFbIZwvPlhBmx9zh5xR9zrpLZ1Hx5wpuIMUDWdLxnx6Y4xYz7KGgjMkJ6OF6yEQWcPd5TpL+QG2d6lkwOBX5jgHawR9KR4Fs1NXaxvtlYFUWGKfITIweYMr2/1jDHUNt2KgmRsuWKCYBbTiZjgQmutqvmL6vadjqX4AQCvJStqOpjwGcnxHpwtZs8CYsAKDjjYMury6WnpuPCLi9asQZO8+ByFxa4lPf49Pw4hNEnsKIFHGy4iPxQknEolX5SxWYJLWER8tnKZFgkm+Foixpl0qTbgcd+hlqFAEIZEpGaombyDEBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=55+YzZLEUnFYJEqI59kTtYuhrT3z6KAxXnGYyybTfdA=; b=jj9/xrFY+AJ05h5nDcvLsNx3aZQf5SpcTg9Oj4b+dkDXOxg72G76ggVBrOBJn9xsf0eIkkzrwX45mqHAaOsBphabHkIadDgN8jv5d+K6zb0ZOQTUyXXx2t8AFtqwMy1L4qcJdFsMEMGI2XbbIFzzo2vrZQVJmpo7Ms2uii00qIAg8kulXhLqCgWPRo8ifuNxwo/DteWaSvKVbW7rFz2Kbcz/LuDKsl3ClF8kXTrW5SepRI9NiyIErhx28WvM0yOLoukEPkB4ADyXRPlREm8NVyX5+rJz2PE0ed30M6/ZPjpak0qofayD5gm/MCRA3YciQYbVli5I1lzc2Y4nuyvrmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:36:46 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:36:46 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/8] mmc: sdhci-esdhc-imx: restore pinctrl before restoring ios timing on resume Date: Mon, 13 Jul 2026 12:39:00 +0800 Message-Id: <20260713043904.4144172-5-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR06CA0012.apcprd06.prod.outlook.com (2603:1096:4:186::13) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: cd6ea000-9aa6-4f1b-50a7-08dee09858e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: yL6aeNeCXFjsKeEydF9zSa5/SRhQq4Ma5taz5FfbU9azDJSSD39yFWBDthb0lvosIX/pyexS68ZzKAHdm8WdRBpsLxDz6C381DiOY4nDWCEU+3wTWWCJDsPxhORGRTtL9Ih9bwXLR1R24ZkUKyTlLuXNx6hYmwJ24zuxFp98TJFioHtwY1xJcYFGJ6SxDVPK1OZiaypxVcTuyxdSN+44OlU8nrrImm5EjV8HacGw3MQtOu1EAyolej/PABFJwkbhaqjGKRT05lmA0Ep/SvKP9PFAE1fGjiiH5GWtJTknxQJumEejOgA9jf7ukKSEbPHpcmSu+WBFEzJH+KkYajBWYCTSrOLojwq6nco02IV4zDAXocCXyTdUc4iw369IrK4drsK+hSz5UTqfQiTU04YFzhQ77gLY6tb9XyHkJ1js4SSuIQwYKjCNhR1VqUtdnSLUP/Pfx5bLApf3YxJX7mbv2+ejxrUoisTHkxNcmu7u8aYSZlVP3snRkkz6KfiOa7x6jG9+zssIa9NNYSr0351b32fpjj7/SKDevO9RE6TUQ0elovfKE756xK9FM6et8iUFDxo+ds/glPi/R7EGz6K8qDiWbmiBpskUxsFdc4P0fPxgoYRKPiHuYfCuSl6ckcnaJAJ2ZiJp7+nWftsFsyprTip6FxfjqMS9VkLtJgcyvXU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WwAedzdEJOrkiex8yk6h4POyeq1x9VVsuiYISZtp0ge49IqT3LslOl5WhFow?= =?us-ascii?Q?QmYpVeS+7CVbwWcn5fGMwTrpHms1RZJ3HhrX/9YBxjKcgod9SgqXLEdevuel?= =?us-ascii?Q?KFA/bf5ZVwKs+kRWnyQdo2ViNJyCJEWkQ/FSoRr2ukzq8BSdrr6ywH+fg6Ua?= =?us-ascii?Q?ukBUeMHFviWHTXNxWRQbrzVUShVeD0/ZZolaZZRUhLSwipMWpHKY7MgonrWX?= =?us-ascii?Q?4Dewh4JuzfYIxueznsUMaRYmDPJ9RFYJTm615gqtiKLtbKmvEf9wVsZtnZKG?= =?us-ascii?Q?QG6dRCrVsdwfWGqRLOno8JiibiIcwydjvl/AiZllz5hN5LrYFfaMVJ6iG9iS?= =?us-ascii?Q?LfFP4ORhdAexaGXMSOYHv+HHneSlPygWtaqvi7gJKs6NTrQ8AyBx0noozEow?= =?us-ascii?Q?0lq6mHNQksXlK0EfhqDbdSTpx0jA+K0Bw4v8OT8ALppY7aO32l6SDuf/aTiR?= =?us-ascii?Q?bGek9mjL34ecO9kiJc2tCqqYIIbfUieLOBh2H0LLBufW2Fb4NxgCH5xF5KgS?= =?us-ascii?Q?S04Z1quaEkIWWp51huYhw/w3BdbayOrJ4h825O6Edds0RSrhEbEShWUMq1iZ?= =?us-ascii?Q?h2armwu5x97TBb9abYj2fCidG74l2KLK0qn8zXUJKGsSAGT6ShzfQYE/8Mki?= =?us-ascii?Q?RwH3qkyNQkCHcXENBOvXufuTDImJxuf8SLWXVmpHcIsXM1fz4DzQaTMBYdzY?= =?us-ascii?Q?dg2Bi3E/QdtndTgsMYXukYxX81YYNEnrjS4Joaon5GFFuVcrkbDrFTIQ1tMl?= =?us-ascii?Q?add8PWlJOd9TaG/PvU5xZVZVNMJzoZLeHtAc+NmKXGTE0k+aP0LCluz2YkbC?= =?us-ascii?Q?PGzmeOsVExlXHZBdqYIghf//ByAfidA5IDmWqnAVqj592znuEzf39SEKFI/m?= =?us-ascii?Q?eKc+D2nzV6W0KgAMtx5KTlCKZ8bgvdZNNEp4wOlAzLs0h5QH0Rzq+ZnaKiFO?= =?us-ascii?Q?wUeKeeTkDXZnVOOHazTGcWXagO7Bg+YzsNdWK27VbnfboWcB488rFeA13J5v?= =?us-ascii?Q?b2zLip32mEcGtQCg204iAGQIjO7m9nwGuftbUosM3sLByeKeAi/QVBtPEgGo?= =?us-ascii?Q?RJJNb9qQBEiyhoYkON5vG1ltxdEzKWH6/+NOSE7Gdre+tYzaA6qhHzzsIfaA?= =?us-ascii?Q?IPZ17EPv9d8uAN3FO9noknh57uHRUeogU6LYYjPZ0izFBLJZpgYZdv8poLiB?= =?us-ascii?Q?ZYkjxDEaTynJdwEu6xw1B1NPE5w2+CsLuJNjyNpJJSOBiFxu7O61ci+BY2b0?= =?us-ascii?Q?UmgJBcf0h3hQm1fCYtmBhomUcO0BUqiTuku5ULzSh+TWoGxRSs+cy5NfKtta?= =?us-ascii?Q?KnBNBEBfK83YmuE8wr4eHmezG6ePd72+84AVYiuM6NqTrSHpGeoGszpDJPf7?= =?us-ascii?Q?Jiiq6yfZSPxGddKHW1LhoZBUtNIfE5lXEiUeGr8kFdxeX0jOne939x6rafAa?= =?us-ascii?Q?LiEPBPYjy8ab+O2Rmkc3ukNw/7+AEXDm5Qr0FseSBMMU+/p8NlNt/Oqv0QDb?= =?us-ascii?Q?3SX6BPtNsjBCe0by6gJoDcVr6ymTILU/4eRu8SYKOWQmMzL8B35ZI8a+TfMp?= =?us-ascii?Q?lHbFdgIpC+sSTogcFugbocNbPBeK/3Cs0l/d/aYOcIhk4c1mdv2efMCot1C2?= =?us-ascii?Q?TwMZJEF/Ft+HumuAx3sAQugAZP5ftN8orwJAaWLUG5PBs9yopPknt4qX7RM7?= =?us-ascii?Q?c6VeIgfUZ611WLAb03+vjSoZUgoSZeReZqiVDrJdvSSZSxv8RuV/r5Pdw5T2?= =?us-ascii?Q?r61rOkOGuLHE03ssjj83JeYge48McqZGhND8ctdz1XE8FDrOjPOcM5ucDnZt?= X-MS-Exchange-AntiSpam-MessageData-1: fE2syiqdGhrIVQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd6ea000-9aa6-4f1b-50a7-08dee09858e2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:36:46.5052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3QJrXw71TIimGwQjG/mQoxK9X+v96gxaPjwi0Wvits3cpHq7OABzryC0w7+AhnUeJcZt51YaaP3E7zu9yWZ2Qb+vOaW0mVNjuiVv3Y8dySDeCRPQGp5CoorGL57dpIin X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang SDIO devices such as WiFi may keep power during suspend, so the MMC core skips full card re-initialization on resume and directly restores the host controller's ios timing to match the card. For DDR mode, pm_runtime_force_resume() sets DDR_EN before the pin configuration is restored from sleep state. This is related to the SoC IP integration: switching pinctrl setting (changing alt from GPIO to USDHC) impacts the internal loopback path. If pinctrl configures the pad to GPIO function, once DDR_EN is set, the DLL delay will be fixed based on the GPIO function loopback path. When the pinctrl is later changed to USDHC function, the internal loopback path changes, making the original fixed sample point no longer suitable for the current loopback path. This causes persistent read CRC errors on subsequent data transfers. SD/eMMC running in DDR mode are unaffected as they are fully re-initialized from legacy timing after resume. Fix this by restoring the pinctrl state based on current timing mode using esdhc_change_pinstate() before pm_runtime_force_resume(). This ensures the correct pin configuration (e.g., 100/200MHz for UHS modes) is applied before DDR_EN is set. Only restore for non-wakeup devices since wakeup devices kept their active pin state during suspend. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Reviewed-by: Haibo Chen Signed-off-by: Luke Wang Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index ead4685d621a..a54da5757acc 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2115,6 +2115,12 @@ static int sdhci_esdhc_resume(struct device *dev) struct pltfm_imx_data *imx_data =3D sdhci_pltfm_priv(pltfm_host); int ret; =20 + if (!device_may_wakeup(dev)) { + ret =3D esdhc_change_pinstate(host, host->timing); + if (ret) + dev_warn(dev, "Failed to restore pinctrl state\n"); + } + pm_runtime_force_resume(dev); =20 ret =3D mmc_gpio_set_cd_wake(host->mmc, false); --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010020.outbound.protection.outlook.com [52.101.84.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23149346E40; Mon, 13 Jul 2026 04:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917428; cv=fail; b=YuomDPkz3caHixHzjhMr9kl6yjg7FY57ALu5pKvp+Bv2qIBnZKIqSB0HbDslm7Y6KmHQ0V0d0VHX4n16S7UwUJtaZx41ncjx0hp2CfTKGncHaybXl/E4D4ZSe2ZaTvexxJQP1zzyEaJvVvYBtwoF1481/iVBlzQZdVta99PhBZA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917428; c=relaxed/simple; bh=/idPdpTDLzD9Fy4oIHcINAWPKGDsZDy5+3RZ2nbYcTM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Oxvb6OJWDVRLJgOtP/aCvMcARdVneAH5vn9iQFiZ9WZ5pYA/I2RyKOOk9vQ3snfa2Wb3NmgAgrAlJeUtFNlTkLM2vaucnbMjbChZzcZCSkOG27jDFvGLYLxE2hNLDULAe4hqWJjDNIL6mA6DKflL0UP3DCj6Vz1jpvYEyt4akH8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HU49DooP; arc=fail smtp.client-ip=52.101.84.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HU49DooP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TFmdJkHnA7I92xOpBmiJIOvGLUoq0lDlHpT/kdxm3g6xgz+Xt7Ll4Kp1y2AIN9pfq6rXXIgNsAx0RhM9+GncCvAKhh+Hw4ca1IeHb+jt5+NCIGVU3ihLDRnf3CvuwQ24yV8uWsrxoiAtcWDWCXY3zCLn2Ua6nymipy6H/iFsMlmcWZPn+caWdq6DRxoFSAqmO8Y2W0YJObHFfjtMxP8qFL5+lYS4ZAnJPch0vJhXK2jL6nByuPCxfcct9gMf/IqXG1ELfrtVEqkDB3ndqCkEZrEfxAKF/Uu/UjUAXONI5cUd3vcKuMlDEadkEZfevMSHhw9KBYEuv/R+dohjtGAQRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gvH2OEhEv2g+GkSYTINHghPKZJlwzTs/Gkp7x7ReNBg=; b=gjHD2n97F07JN8wjBHr6A4b1GyodTlwOq258jJZL9keSqNgaTIhgP8pJjj74hWkA64cnzTmLAAQQT+UgLvrmM8FYivV33fRR9sT4XFslo66zs8xdl1Zb35FX3RUXGPSh25rW+ThKpnLw1DnHMe9u+jKZvq0TFjQcsPoJguZvs319l3frD0zafbJXwKNmQnvHrAZeBvPDW/54M2rgHeLI8Epabahy+DGlFurRPyQCjAarPDW4XrTxye4p/ia1/HQPn83d6/Bg4LLQaCLFHEgIKrkx6ttQT5RLqH/6HT2c+jK3w0J9qM59U7LbkeUOWCJLgt2QAp48OHFrIVuBrOlc6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gvH2OEhEv2g+GkSYTINHghPKZJlwzTs/Gkp7x7ReNBg=; b=HU49DooPwjYolNM87A9Fq7V/+lhQn4BEuLudZPBQoLUFPwyV3CD//a3Um3Qe7uxrVyL3zFZVwo6vsfQp1VY0PByw6T/NwIPynhoRB7ARtZo+siuOF8Ybwj5TO8M6SHjarlUeHNk1GWYitA+xjWOwCdzOKx/EcxRwb1iqRfvozopV3M8OmdZjlk8YMcOBJdkIlTpkxw4oBHhIzMrbgRSxGFr889rf+36ttjA5kXCABwEmQJyUVboCZQfON9wj/WfcQI0MAylIRP23lqG9MtD9ZwXiQICOGsi6ycNYHMWJX00wQiDyy4EYH/AabtJbEngtM+xUi1eU9WO9tm9QHa4JYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:36:53 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:36:53 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 5/8] mmc: sdhci-esdhc-imx: disable irq during suspend to fix unhandled interrupt Date: Mon, 13 Jul 2026 12:39:01 +0800 Message-Id: <20260713043904.4144172-6-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA5PR01CA0220.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1f3::16) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: f8206a3a-9b4e-49b5-1faa-08dee0985d0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Nb9wNQYE1mCa68YSXxdS8zS/MRshVW7alw9SmBkV0zFGEuBIcOYIoj0FfeM4kGagCgU9LfSutARGvX1LAtBVZuSFAoMoUUTfjTr4o1IX+H5ZGZc8qcXVpuzBT+FHrkIVa++9U417MCRE8N+1laAVjlnisxq2FiPSpM/+RQ5uss5Fitc8TjGwSrtFke5PVwBNKDOqbqcuEmx8yxm0KJbFJZDHQ5JBh3VBavG2iBuPlLKeatjpyJiSpsMH+xLDaYe9GhPHUkhjovPYx93URUQh6cYJUher29cxbckFrzldB5MmWuk6b6kEaVttxrb1kcjG55ZqXDD/UiVzvjVOuBmeaqlHfP0ohFVY5IdYlXkmlJ3vAU7DRFzcmAX6FtAXGHawRmVYx7If/+pFXDcDK/AhZjuSbKU/BpOfcy/g7PSPGM6m4GSo8NOscNnhf4PLm86owLY4TPEKHmlBJ3U9rAkquAC+97K42p4RLmjv7lQkaMIpBqJ2b93WhnsJD+2z3ATL/MIY7Z80iZpiyuqQFFNfWfD5sq6Zpkk6HAWq2XGU3zqhr7uzJEC5HCfkX/qOXacWsWwm4BT+ZIzUBEdaS8+Y9wGQjGVBwmvRHPx38zhyqUCT/6havHz0Eezyo1pUuPm80dnOsFUUyovHVA4ktJxPOfIFqTsTcnPzyF6tjRbYbBc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8FiEti2ZznBtu+ZLwI9D5Ni3lGlBLkpxVzBXeqtHpj9odqosHjHpwhx3fL9q?= =?us-ascii?Q?8fc85FXcp8y23leUzRNq+PpWd+UPzHS30IqfPZ36rHEHleNHEBZVtKe++IR2?= =?us-ascii?Q?Bdn8UdofJpSqiGs6CrT/m2s0TaOcIcRmocQKQj0KN/aWWiTDGbYeu/ZC/1C8?= =?us-ascii?Q?d5EbwAVyN56Lh3gb4akbkfkkl7y1biRQRoRVeCh9jxB1UgAjDLlz+ld8QaxD?= =?us-ascii?Q?pu9OtfBFaUNkmmTxkyObUxaV+uel2+nyyyifTixLV45cjLTonuz1GDJPY2j4?= =?us-ascii?Q?bmjOrs/Ej2L8+ex+K706JP/Zm29M5YIGiX5bScAJ32jVGJ1K4I81tiqwk3em?= =?us-ascii?Q?z3C5Tvvjg/MzHScj8DhP92XAz+YglvbkfZ8n178OyOEKrEncRZT3OZij8H3I?= =?us-ascii?Q?eVlqAv9MvDwyZUNe2YQcYNnmXjcnyODPA8OBPBT9jILHVhvC+TAGWi1QhEQz?= =?us-ascii?Q?+DK1T4GP2SSOlTSSA3E2BzY4r88m6lq387QM/TO/VjMF3utNKXCMdQtvo++p?= =?us-ascii?Q?Xgh2Gp3kCoCFVrqAGPNXtR25RRUN1u+0gKcvNgmuRIKVkSBAO0xlY0k5Z5KI?= =?us-ascii?Q?5xkCCRgh3Ah5arfQ4Xm2bzu+HQw1yQOMAXCIvd8idDotTIIZiAjvMSbhB0f5?= =?us-ascii?Q?LjIvsk3JckdCa4gA55V/dkIKxDkxlC6uDDr8RAN48oiIxwdlMtgxkLEwfoBh?= =?us-ascii?Q?9AKbsS1gSasiNgos8kp1viOdekupapN9S46N8WhGbJ3/QsZc6ZESDWhPPIMo?= =?us-ascii?Q?C7ivCnfKaaJKv1XRR8Reobaz9GFnTZDTz8kpla44vvD3oO9RCqtQg5sd1Jfp?= =?us-ascii?Q?jdM3rb7Cf64YjobpFlsqNR0FNWobF/gsIb6btxc4eLHRTPUtRLI+ait7Kext?= =?us-ascii?Q?1TtkYIYswdedpXDr3ebWPgNNPsp+L74hEbIkE2jYzyDkw44/++gpRbK2ZTj4?= =?us-ascii?Q?G/rwGePEXb1mQI7VNizmtr2h2J1aWLlrdIpBErpBJNbKszWZGuXidLwD6IjC?= =?us-ascii?Q?1MH+AcZqIKKMiF86nVQhVaoKykQR30gi7+w9+bp0E0peWgfdeJLjV70v3hmd?= =?us-ascii?Q?0DcEU0xSQR0cyyFqqcEXzSqByJfKdUCqttKF/Wdu0kZ/K97XQTFt9EJLPBvt?= =?us-ascii?Q?eNeSOf1DbBXEKcjj9C5BUgCYfHRv4TeRuJDALHslygMNZ6Ut3cyWlYx/XNoO?= =?us-ascii?Q?7wSjZuHWoqM4HoZQ2nfZpY5VbEzu17QpqrfpoYc3zcWuIMA79lbjJUgmEFZh?= =?us-ascii?Q?SvOK1n3Xwhjmcrp8jJtzHkEfjArOUS8vYczJ0aeIlw1caEsTq1htoB2T2Cvk?= =?us-ascii?Q?T+wRGWIgWD/s8RnJT7sJDpXQ8860s0afL5cDpX4WlmDSuhj0tjwRZtC9x+JR?= =?us-ascii?Q?jJiudMvq4OJXcYAcc4YGhmo9qIUSpJDSFx69YKcKLcpnrdnFl0hVIizvbnNR?= =?us-ascii?Q?S9OUiT07OawWX1IQu9tKSNBn68HvfFOVNvRAE59j9qhzSImCYFhWkrl+HjHE?= =?us-ascii?Q?lmRvJb7OHlyLAz5MQYqYu13owv7BJGeR8pT/G9kTyLFfDTWxYnRiFN1+5pKF?= =?us-ascii?Q?YiOLPRTulV+EIc6+0ynLLKBlrXWXZZAelngRYTUdU5sbUQxYjUd6THYapppf?= =?us-ascii?Q?ZQPIAoxjVK7di7dpmW642WLY9k7vthREdAV45gw1St063MnO3WgjQAsL8cNa?= =?us-ascii?Q?wFWa6aOvz1K2w0Qm3zC23yHSZSiLyOdCu9JbScxODD/9oRRJ0uhnS1i1fDH0?= =?us-ascii?Q?Z1K2YXV1tFrYzAe2eYIr+sFjHwXAuZC9M/Vmon6lySxQNFdJH3NZvY9LCgrh?= X-MS-Exchange-AntiSpam-MessageData-1: F0TwdD2OKA5qkQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8206a3a-9b4e-49b5-1faa-08dee0985d0e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:36:53.5126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: opIsz/NEYVlGqVfVJl83VPvmMw8dO7ESkPtKXj6wIZtHX6Mp341sIiUAAiqI5oNIWDoOlRRVSwge72dZOz0vacu+djwYKJmhY2R+m5acZCZnCpn5fIqXBtAMY1YOyerC X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang When using WIFI out-of-band wakeup, an "irq xxx: nobody cared" warning occurs. This happens because the usdhc interrupt is not disabled during system suspend when device_may_wakeup() returns false. The sequence of events leading to this issue: 1. System enters suspend without disabling usdhc interrupt (because device_may_wakeup() returns false for usdhc device) 2. WIFI out-of-band wakeup triggers system resume via GPIO interrupt 3. WIFI sends a Card interrupt before usdhc has fully resumed 4. usdhc is still in runtime suspend state and cannot handle the interrupt properly 5. The unhandled interrupt triggers "nobody cared" warning Fix this by unconditionally disabling the usdhc interrupt during suspend and re-enabling it during resume, regardless of the wakeup capability. This ensures no interrupts are processed during the suspend/resume transition. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Reviewed-by: Haibo Chen Signed-off-by: Luke Wang Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-esdhc-imx.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index a54da5757acc..d980dea9cad1 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2077,9 +2077,10 @@ static int sdhci_esdhc_suspend(struct device *dev) if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) sdhc_esdhc_tuning_save(host); =20 + /* The irqs of imx are not shared. It is safe to disable */ + disable_irq(host->irq); + if (device_may_wakeup(dev)) { - /* The irqs of imx are not shared. It is safe to disable */ - disable_irq(host->irq); ret =3D sdhci_enable_irq_wakeups(host); if (!ret) dev_warn(dev, "Failed to enable irq wakeup\n"); @@ -2130,10 +2131,10 @@ static int sdhci_esdhc_resume(struct device *dev) /* re-initialize hw state in case it's lost in low power mode */ sdhci_esdhc_imx_hwinit(host); =20 - if (host->irq_wake_enabled) { + if (host->irq_wake_enabled) sdhci_disable_irq_wakeups(host); - enable_irq(host->irq); - } + + enable_irq(host->irq); =20 /* * restore the saved tuning delay value for the device which keep --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010020.outbound.protection.outlook.com [52.101.84.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC677374E67; Mon, 13 Jul 2026 04:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917446; cv=fail; b=iSvPvuDc9I8edHONp/A/1cc1MftsUwxxcqBlz7sE9p7cEOm47b7uTXzW8Ubq0EJWi+5DGTyHj3aIFplTfuQzbOwLDmfdcZs4ZoTt9cI2+DP1D85ok3Cii3RLJjO+JswzuH8dYYTmFR/YF+VR/5A/5gVQuo8RhzEdur5Rxsa9bfo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917446; c=relaxed/simple; bh=cteAhfX8eWw8tGwq/93u47FrcG6qckzXNG8qZrzBjT8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Hm6f6O6p+recAdPnxjW42I4U3StTaXFIf2Y1VB45XUKPQB+o/nPUU3chGQc2bvFBsdmRu7wKyZZATpmykpmJAO2PaAH76SJisqB+xU5KCg+bQK+JmeFH8vXXVEXrztPdd/XgobZlhhyNnxR4nSB21A7ZRWPpsKBLUacPy6/7uBg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jEv2c3JP; arc=fail smtp.client-ip=52.101.84.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jEv2c3JP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iZdeN+tsogkAFv7wSMqiE8hXOTOW0gFyIh/w2z1630T4NDq3sRiGddSeTd7M+rfQRc01W6LHaxc2D2/IehWm8DnZ7tBkT+X3AajJHe5QZZjqIeHXzzcfyebPJ6tEHgJMkSoBCCMPaCC2TdJOLa8himeIiIjYW2FVFAdNVCOzZfjrFbYVf3TgRXIKMtJURW87WPf6S+aE9MD0RPIx36AjbS7la5Ottz2LVDit+KBHTZs7yDZKxMLK+Jzos/Yx0DeXfxDLm+B5s3q7lLd5n7vtYTkptMQ1pgJYcgmRj1XJRRy4wbHcsGF7I72C/oT9HOUWizmQyq03ObAUuhcv6mgPAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=clQF4CfcKwYBKaXlPSmL9IuZrksTMWYqhWz9N0EgstY=; b=tvVJmrGQDo+xNynIH4mOSEhdt3ZWAl7H1+RhtnexijhdVFljXCdubcbvRAMqGmvIRxwoP4dm1qXthbkQJopV1Xq+gZtQyBmEmR2y1B0u2Gnjq00VX3l7bn3vwBuKJUy/DhUjU9uLpaZpcCD39CJ49SYoxAKuqK8ELQY+Mle5FI2YX0Qo7+3X+izR3VNTioCmkytBiFRIuHBPuClDwzVEqNM6E8Ex1IMYtFXid6v6fk/NQiEpm2r0xiwlBrKlQb4BAyxw0gp/zQ0bRQ3yzeoZdw+VH5ukXlef1mZ2lhN7oAVf3M1MeGSdM17CyE1Kpp0Nywi8x7zZLJjCx6E2n0rD+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=clQF4CfcKwYBKaXlPSmL9IuZrksTMWYqhWz9N0EgstY=; b=jEv2c3JPOufrctbehUuriAyVXvzxL0DpxK7RhviqfsqisZ3bzkMOYPUcQVFnn95Rubn4wRYbc3t6He6HJtaV8FDCOf50AKM4RhF7JYl0NkWRhpxgaUUyO4IkUJkw32yGDrbf88vYtOpU1mBdh5xbLAVghsDSuctya6iWtbX5QbZ6jxR8KkOPflSx/Fn3N9qG98NSNxHPRJPbzuFbX0Dlwl0wWYYrFQ69hBbn4NAugpHWQmcjGZWbLgCK2klPwv3XWQ+Ho2mkKyJErgrnAYiWWhdI4vSBNGBYIbApXHO3J4kXCMZRMI0hvE0o2OwLV2OpVu0ae8UGuo2FE/8olnMmsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:37:00 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:37:00 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 6/8] mmc: sdhci-esdhc-imx: use pm_runtime_resume_and_get() in suspend Date: Mon, 13 Jul 2026 12:39:02 +0800 Message-Id: <20260713043904.4144172-7-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA5P287CA0295.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:21e::11) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: e76586b3-8c5b-4ea2-abc8-08dee098614a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|5023799004|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: unBYXygkAUkuxTCWJc7+/vu1H9dPLOtyOCQIKKtJdsZzBGwB1n6hUBxTeDeAuvCMIoZNb6ZPJbGLUWo9+j2lTK3+NziKL3knIUnxvlJWi8fAMERHDxSSpzx+4nRlbHmzfEoiVrSIxc7MZL+nE+qiVUlGApxROsu//DIQFyiMQGwKoYQsGLTYd4aQP/kKw77i0WDTlxgfJTRPX7ZQ0uG+kON6ocyDnxq+5YP2v8hdfl1m0t6kPz18kT0MXdrFbTIjsCZAjOLKZ4bSZ3GdBy9x4Ciywd1C7eu79fYEaieiyCo2rC3t3SQJxSGR+g2mC4jwPyCFNTCeI3bf06QSxK1mFU0ALCvd0zM35ggpI1NuxuiaCdhXOQOJ5RPdwZF6eGuVFrXtvHV2mXVY+wJuoK1gt5sC8elijPhfNJ+3T64r83L1mUKyBA5+jWspHDhMuoSN59NDYOfkqWsxidaBrc6WuvxrxpHvvhkM6a0sM/RQICwtDRTIXVV1S8A12kgCGhVMMV0pwNw/P8VnvuCMnKZqDYbSJ9S/B7H7Hyucafxl715ZZwnchBhO8bBD19I85wZ+J5xFyI5ry1t6lGcCjWL0uQpBmoFUIgjNxSMdTwUR8rdH9LqHUl32KBQNmgdvYkwMRWwHehGtfQbYPno/qM9VYr7uc8ssn/bKNQLittZmc2s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(5023799004)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dkbK9LjH65MFYEKyRTKBOYehb5kFhfBZ8PNSymcrhrv0L95Z92h/xw01VU+y?= =?us-ascii?Q?V1cKkrBAl8hrFYc8PMtQ7KszBT+hvFEhJBPu4uMljTtwbQJJhbvVbTQF3vXq?= =?us-ascii?Q?qDUaeaSVTQdJvwtm3PQPvIlkdmCNGk4SOT0LOC77fmuvae9+a5y7fvGgo76L?= =?us-ascii?Q?wi9Sy8tmSmzI6wDnKNidvJPJ7mAnpHSP6nFXKEGRXzUn/5/ovJywQ6Od0jXn?= =?us-ascii?Q?pnANYFEgDDxIhD9jzemXSf6uq+0r5vxn/sB1ADhS1b/qMooAyJvTsk5qAxXE?= =?us-ascii?Q?UzyvJaWU7P2ERDnDaJMWB9BJFkRpp9KoFcODoZToirUtXD7NgDdh7SmTOOLo?= =?us-ascii?Q?Sa34K5Ae8VwU7L9q3V07T8E3f7ZzRx2LdycDbJUCN1v/IfA3/1mImObCNuN8?= =?us-ascii?Q?ex9vLtAecgQI/ljvRslW8RvtcxbjarakBOJVdxe5lXLSVJ7JzU6ttPg1SLKN?= =?us-ascii?Q?ILRWBhhq6GvDgEdHu9OefoZhxAo74lLrvaKPjVbATkkrOeSWCrWajH53bDdU?= =?us-ascii?Q?iEZUg8XUvDJMf57n+uARQ3b3Sk7XSHL2hBgJYzbRS5qSdWwSDWSA7vAO1DDq?= =?us-ascii?Q?nu5H2oXi/WLGzAiEDc3NzZlFkC0xnmptziabFDr+cRjgEpRb1YfltVC+N/4d?= =?us-ascii?Q?jIzVMxjo7za4hn912DDGMks8FiVXK0N/1c8IWj+hMTibF6FILPGr9j4SeG1s?= =?us-ascii?Q?sIl9z69d4ILGLLyJIXjVhbNxaR2DXO6QM/MNQ8JCt0Sc0yjeIO7X/DOxf4x/?= =?us-ascii?Q?AtziNNLD3V1Nt3UMpGpPzgmh/fYuqsFkSPE2Pba3QCajCjskBoECzzXvOUkE?= =?us-ascii?Q?76w3dpHGYSHIBzusMt1JVsAhVjiqQhlqWqDQRXcN9XEp6ASBWvP3EneBYmyq?= =?us-ascii?Q?4AS5QxVFULtdPQziIqYpgkHcyiaFlmz0hX3J3ck+E34AfHbtzYTo4iP8aCK2?= =?us-ascii?Q?kJkEBB0mYZizXBLGK6ksABLJN4yOH+iB457Sk7IEEY5ZjIzVqHEzuzyIJXIU?= =?us-ascii?Q?GyOvNKaOZuU5fCqcH1DcRGhsjAM5LLhLWcxJ1q1HCInReZp3FDJuBev9D+Sc?= =?us-ascii?Q?YlJQIJf1K4GSUwfSHzDkxSGHQFtlPzIoh/C9GFSAe0vsyL4SAYYXoWcltcEG?= =?us-ascii?Q?uKq6I2azXaJrJTd+BqcfIyS5jgN93xjhLP2EFd9UmCxs6R4uLPbaHAdKTS4J?= =?us-ascii?Q?ZmWcgBSuQ1E09owP+qIodss+o3g+/0JH4WE+sLlZRAgLKypOTy+LM5ev1P5m?= =?us-ascii?Q?JBH3uau9OAVHHFwueXXHpRVjMQ6PFKUO2tC6bETQAhBDkeosBNmz3PiHkLsL?= =?us-ascii?Q?TbXUCU4j9B5KfACxdfMfT6csfddyJ2QTyVP+ZI/KdsQ4jXDQIwnxlZ7xdSyf?= =?us-ascii?Q?gTUk5WZQbPAa/mnw+lEeh8X9ULdW+m0AE3MSukF0rvesRaZ3zK+w5bn8K6Qz?= =?us-ascii?Q?YAgTa36nw/R9HZNkKxk4kMhHKHmpMQlHC6HcihHoIWNmxoCWMVUsWAeQf1ql?= =?us-ascii?Q?tPo7Kk27kBf191EQEsOfSeK15bQkQK0AQX+XNnCS4y4XcM5bWOzv0BVh8myo?= =?us-ascii?Q?w1W3nayzj3NUp8tAbQ955+KdoKxCVhfk+ynXU2jBIPXSNsGzEO15ECbo7cjM?= =?us-ascii?Q?y3T6M9CSs4TnSBwMK2J2sYSZA9wWmSgUtuVzWjNinWn+INsKpi4TRJ1Tuybp?= =?us-ascii?Q?eb6HpnxGpRzvoqxidTlJQl7tJXnSjlxL4j6a+DCxt+2cLcysDujAKS+eTV3z?= =?us-ascii?Q?yvNxrx6v0VJnl8JSNRI6C3TpmEf83P+GoDTTEchi/AQx0S+61rdeZlc3X+21?= X-MS-Exchange-AntiSpam-MessageData-1: ezdR7tc9ZUxbkw== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e76586b3-8c5b-4ea2-abc8-08dee098614a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:37:00.6093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M3KeaV3Wx3LZUNjvPOLFS/WRPKDEMKcn7tdcbZ8tinUdlMLqeKGtybTSgQomyAlLCeul67K2Neyj3O0Ke9IAszY5qPhr7wh6FqrXOtIkdGcePZ7+pnFGd+pXxOMpxypl X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() to simplify error handling. pm_runtime_resume_and_get() automatically drops the usage counter on failure, avoiding the need for a separate pm_runtime_put_noidle() call. If it fails, the device is unclocked and accessing hardware registers would cause a kernel panic, so return the error immediately. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Signed-off-by: Luke Wang Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-esdhc-imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index d980dea9cad1..7818f351a58a 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2061,7 +2061,9 @@ static int sdhci_esdhc_suspend(struct device *dev) * 2, make sure the pm_runtime_force_resume() in sdhci_esdhc_resume() rea= lly * invoke its ->runtime_resume callback (needs_force_resume =3D 1). */ - pm_runtime_get_sync(dev); + ret =3D pm_runtime_resume_and_get(dev); + if (ret) + return ret; =20 if ((imx_data->socdata->flags & ESDHC_FLAG_STATE_LOST_IN_LPMODE) && (host->tuning_mode !=3D SDHCI_TUNING_MODE_1)) { --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010020.outbound.protection.outlook.com [52.101.84.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E907E345CAE; Mon, 13 Jul 2026 04:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917458; cv=fail; b=Qk+Le9TQVV4P/iiPAJqBbI00KVDX8v1xJJ2HiqDo4y4cRSD2ynicwZhyo9B9F7K4FluY0M7T2GJYNHpkFRefmg0CjyO5YytZkLhA/VjMRcnhB2w25XqqT3i+j2/3OjaYdf0j8B/TBDOLUV3rcOJyuYBmr++sc2r3+F9g7/eOnvQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917458; c=relaxed/simple; bh=uD19VxJ7ii1NONeK7LdMECNxHHhlAnPGsT3KcHGNtu0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ciwB0ccDHenXCQYFCrNsKv2OluF0Kx93h/ajB3kKaHwmVJz6SzPx8aZaCko2tI+yLLy2y/nxTW98Epg/5yvn2Kl9EuAeRmBvgnEGPuAxMwCwBSZdxTQ8f7XgmN79fBUd9H+Uv8bCpbd+8I83Q5xiKYzhWF3EX08pLppuU7ENokI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jJSeXPiL; arc=fail smtp.client-ip=52.101.84.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jJSeXPiL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M+bn3hyQ71lhhrZS+/QlQsqRT2Zk39Y9vQHjRll2CoTWgCUBKEm5lBTxGnob2kdOIMoM8JpkgWzljiJkzukmh88EDXtyljsURFNUKsnQ7nSAahoAlW10qDJQHsXteFghkguBqyF+tWe2Ex5fhEsrQP6D60AmIU82I1mrXNQ4CPnj3AiX2FCJ9woYwYNtC/yxXjU1v+v1SJip+ofb7sH60j7pwqO/Y5q1o7p2oQArr05l9qDMjjkpZOH7nmCDrSCiAVMN/9Li8J9JgzQOnNQm/eqSD3Sg2S6L2zgKnoZdctzGmRXuNAZwgIVhzfTgwr/IbhLeS1uOdtcFBgxvM1hE3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Ii0mNK3XfgIizUl+lO7fj3mWabgL59Z/6LNN24u/7g=; b=VCrHIHZ73+hEpziZq4iLSd4pl1WIjjfV74AuSS83MI0FlxjBcFLrK63SBz/IF2sVDnzuDu3M5XwUJtTGyUPp1vx43Aqtk4mev1vnKD44XesWU9CN7YMxeeg8XPVo6dQuRf1pmisRWFsnnqvYA7ziqc/xgKpF1rr6FTbxs9prwLkxPj5sMbDBZ9LiMG3nQDdqgfA+s7YluheKmZRxUyzVQcqRTtMjuKejojT1Jy5TKACmlH/xa50ySYQd8pZfH4VWSRXiYPcfKSGWdGzMYdWMdy7sjUfx28mHMFXeZDugz5H90idvyr7pldM3LBMZPVOirKYMIV//cd/jFuXO2qKthQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ii0mNK3XfgIizUl+lO7fj3mWabgL59Z/6LNN24u/7g=; b=jJSeXPiLcpBihllrthUEWzx9bNlCCNrvk/lLhVi08DtDAXDc1l2fFWvy7AIljlyUGqVwprxOKWdv9pj+YFkxb6ubk7wy1jbbN39YwhEziT1eWunW6o7F6+FqpbN0+04gtMrEkYwjcTuLXd+hns1xcWPZmxVEXtmP+OuW7rTRKY1tUcVl2GToybCjIqeEsLBMgcyX3PjE9xUL8XNTa/sXJVIVNeGrhJW+z0QfjsCxxVckh5OrRRBbZh0raS5aNwZNsMCZ4F4JHIpOZk+1fT1wPySRSrHftQzInfYmq+cafViEiWuW7XeUr5wKPBlK5yh0CeLfcZOqFw4eDYL9gdVNhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:37:07 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:37:07 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 7/8] mmc: sdhci-esdhc-imx: make non-fatal errors non-blocking in suspend Date: Mon, 13 Jul 2026 12:39:03 +0800 Message-Id: <20260713043904.4144172-8-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA5P287CA0217.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1b4::13) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c8dfe65-39fe-43a0-c666-08dee0986538 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|5023799004|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ccQzb92W9zmyXRKGV8tjVnCTssV5HoeiPD27qkGryZtbb8vWAlXG2kaZ3zoxQfknQTLQj40Wp4j46bE7Y94bn4kncbg6/9mW26dliQ0E5cKr5Nt8iKdGejP/UI1j2SoqPvnofRc4dQLJ8AH6tTMzdSpN9oV33WeVbu3OaRENMgTkSUnPFl7y3UZsquNsKn4D/bdh9FmDnsEewsNlQiN2n+zPk1zvvbhkZkHfFIJQE5obi1/BwSU/t19LXTACe0YJbecDaQVAdPKL/z05/DbJQZDyQYe7wv9pe1VBIeNy/hvtiECn5Dyj+IcPHn6smHoAkeTdaNadBTtBzSjUoajAXkUUIzKfh2tGLF1lcYY436lSge3qJq5BIOrvuAjunKk6tPSmR90f254G1D+y65J7/Xun3C1xJ96Vm3t/XGuJe8du37ShlVO5PdSGXgTtkON5GUOh+JOYRiCFk0pmnl6o4CmLt4bLePKQmHS7KriEAf/Wsc62BRNnhX1b08dzm0sD0g0lIh4W824Sk4UR3C7JTwfXcYw2/sBKzuPvK6z9BB5S1Wj+QL3EkkSrg5DTDBTIxtzU8rW65VhTZdQdSyfgC9RIU6VEadxo0rqhF27ARf9s8tlxBQoN6RbTRMiS+DEZKcynvXPW80vwi0RFOxTuiKknDHDtX9lTH0qS5OpILuQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(5023799004)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UAGeWUkYxryv2a1XxWj7tHBXt81JAe1tRQboxb56/uYWzh/JhARY/V5X+ADt?= =?us-ascii?Q?FsPxYSooz5uuluOh8yn56WDLX34l4WZiXAXVYU3lw0d68c/VjKUU/ODX5txd?= =?us-ascii?Q?NajFyc54xwkd7sbzTqZtUGNZWRqYCtDRxSdjRJ65U08fM2/WgUJUv+aDXQJ3?= =?us-ascii?Q?krpdcs/p5pIYXaQfPn/thQGQtfv0fjzOjMvMzYyYPVQZjT939CEvXSwtbgOy?= =?us-ascii?Q?25C7Zu2KdIDjYul0IhCKa7NRBVyDMCnUe9N2fDQEgkOgHAG+jyJPYLGWpp+1?= =?us-ascii?Q?6Tdko7XPsOqDthx5DH2j+izMCDxaJpY3y4s4Mt+vUottIChrXh3pBliFlu7y?= =?us-ascii?Q?fY5oRYswxsl7LtN04HJAWtAgJfg2iaryJABUd9XvSphlcrxKUQQtdRDp7HJw?= =?us-ascii?Q?3Z4u24kb9dw35LDZeT9SR+F3CWtae6AUhDvqHQO9XeGCusttZoIcSWapml12?= =?us-ascii?Q?dhmH/jXi3v4/+Xoy9aJ9fKDi2xfwzsIF5z7g7oLRsRoi9iq++B+0hRfwpH0T?= =?us-ascii?Q?ET2FBikusDwtwks25+30IgqxVlGDrv/HpYGo9RjNe3OUhF+3qT4jr8nNM2ct?= =?us-ascii?Q?s+gANDUcGKiURcJDgq6nXpeBvp9iJyVg2rb8UqLH1zl+voLyPXh18R1cmWv6?= =?us-ascii?Q?IiJAK/Od+jZGOCUZ+c/vd4pIju/dGxcQR8ZswzrtgVG2ken4CObCbLhS/5Kc?= =?us-ascii?Q?ugrhORdymh8CLpCNC68wHXls30RGsGwMN1Qi4pJ8A5WiSb4AO8pjuEfAmF9Y?= =?us-ascii?Q?ox6jm8VUQe3H7LVN9LOStAVAF2RWKFZaIZ2tdJl6/X4spBj4OfeQ64k58K1n?= =?us-ascii?Q?Rij1JsojkWq4ID7nRQAvsqKVC/JG2O6RvenhvgcRjTtUapl+B5osVo4u73lF?= =?us-ascii?Q?JaTHaPp9HU6kZtmmwCQxWR99mn3Gf3OmMu9RQVi4mmdTpKGfe4otgPeBnNr9?= =?us-ascii?Q?P3ciU3Htq5z9mF1YwoqNeVwe1qmL4XATB4sIj7lI3j8Hqis51AfdLPP8oqUi?= =?us-ascii?Q?yu9xeXQJaPZhBgQ+rS5fk2mK6pjtref7YEdkQm2cAZNEpMmvW0RR8fofu8/F?= =?us-ascii?Q?hHMqdvtwH1m3QFmQSYCVJ54bTF5fzfwRyFNyh79RdfFOZ8nvbj8FPZ0eitLQ?= =?us-ascii?Q?3DcX6+mm5gNgir4p2jRYN553c+q6RiXZ8laaYMhNlNexdvWm1AZzAAC1pvQ8?= =?us-ascii?Q?BA/Ku/6SIiNTUJVVC3t4RvK3tuMIIpcPSkL2XSQXL0Uq2PeoUc3FRUeOqi6g?= =?us-ascii?Q?WQ3yOdH/3z2L6t+B2nEJnKXr/UluXp6CnwmutXT7BVTG3uZIZ1P/EloRx3ft?= =?us-ascii?Q?HmqX58aCM0dDLQD68eNta1ROet5Uj1r9n1Dzk+EM9dklVVw58gpo5njp+i2j?= =?us-ascii?Q?+KrY7tdHXjXK2K3D/ZiV440vOpgeW2KQX4Fa8JeQrSpFls/gyzUjRFuzLtpK?= =?us-ascii?Q?D7qr5gaSGFkJIQuh9/cUvJINcs/IEQd+JEDCptJir0nXc/KfBGe3aMxF64rf?= =?us-ascii?Q?z8DFGTdOaSZeKa+HHpMa2eQX6xDiz8rzlA+dWU4h9XurJiTrYx51SyNAi4km?= =?us-ascii?Q?uyn0sjEoLKCrSVPcqRZjAaAAOaZJ+oVI3oJyYpdPmkqi2KHK1NhSpEwxl1/v?= =?us-ascii?Q?kFdqn/hf5EOpXYZj3OhB0XKEQfjaFBrqpWpwS+Q4cPq2zIJSXQSsQFnhFnVk?= =?us-ascii?Q?L6CVY8Qh9yJF/KkewdMphBJuB0BzbApAL46J4WRg4cScL1UoUA5w9gMy4fAZ?= =?us-ascii?Q?poETrVnTgtTR1FAIni5FlN0UWLHZXe0JlqkmrVubWLj1WbGfTqS5YJaiZEU4?= X-MS-Exchange-AntiSpam-MessageData-1: dBp/VXMGVD27lg== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c8dfe65-39fe-43a0-c666-08dee0986538 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:37:07.2244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6KOsnhDv4La/Zsq/fuLDGdYomSdcEJgeMzU1wuR5fMEjM0QeLk7fLG1oPlAI5gwbGLcRTeCeauJ/1nOtS7Q1QhOSl120Bh8rI6WWWjPbhap1vEngZRP2r/FdL+A/T8PM X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang Make pinctrl_pm_select_sleep_state() and mmc_gpio_set_cd_wake() failures non-fatal in the suspend path. These failures only mean slightly higher power consumption or missing CD wakeup capability, but should not block system suspend. Also change the function to always return 0 on the success path instead of propagating non-fatal warning return values. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Signed-off-by: Luke Wang Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index 7818f351a58a..6cb84690fde4 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2097,10 +2097,12 @@ static int sdhci_esdhc_suspend(struct device *dev) */ ret =3D pinctrl_pm_select_sleep_state(dev); if (ret) - return ret; + dev_warn(dev, "Failed to select sleep pinctrl state\n"); } =20 ret =3D mmc_gpio_set_cd_wake(host->mmc, true); + if (ret) + dev_warn(dev, "Failed to enable cd wake\n"); =20 /* * Make sure invoke runtime_suspend to gate off clock. @@ -2108,7 +2110,7 @@ static int sdhci_esdhc_suspend(struct device *dev) */ pm_runtime_force_suspend(dev); =20 - return ret; + return 0; } =20 static int sdhci_esdhc_resume(struct device *dev) --=20 2.34.1 From nobody Sat Jul 25 22:33:06 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010020.outbound.protection.outlook.com [52.101.84.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D7934041F; Mon, 13 Jul 2026 04:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917466; cv=fail; b=glSkvW0p6gajJuqZAvSvCHs8gaK9jUm9EhKT7PHj4cbl3LHpKhdUHQMV51bwjFC/7nhulDmtwU+7eA2Cl7+7WTlDhuRFd9zv3qU0QvV0/jCjR0wgzHIgOAvuV+gEVDE7n9UxrzMH/QrflARWtIJcgcObvXe7vWKu0MsCvFoZ/rA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783917466; c=relaxed/simple; bh=zcozPL7FAOhMwldMhWUxN8H+G7GKGHBH5fge8ZNr7Ok=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=g3fHGBqchnihCjilq72XDP6ZJb6MCueOFotd5osWuUfXH0g15gBKV9ZTRAjnvwgKSb8N5k9bswVIo1zGCsNMZPpPVKvr3kA/Ik1PhZGvZvtlgAIqd2zlbTmpgzNHlUPnqUxV2UvZN+U6FUiYGPUmsXH8Olni/4WeFX2zd9l45sQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Yih2dM6G; arc=fail smtp.client-ip=52.101.84.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Yih2dM6G" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dQHHb2FTJZ96Av17Gyp5JgHB8hYCnpEz5pdh/0ppbgMBsvCQMjHpBNMfycJ5lVShcOSVCehOfzEeWEfEDbyAgEG76sWgytCrxFBUGr3EVacrIT/zWdPsvos7gUCyPsvlKS8IW9ukvaUmpyVeqw/4korGj+Ptqvs4s3S9hiAR4LvAdIOBled+cmL5l2xg+/jg1CuggNeMKJWUyLi/RusEtDEtSy94EP9sDez5pwabsipR5M3uw5ERyf//bHPyoBdY+ufToOEnIHaGt8hAMe+J9g1/tJKjMfc6V0E299WQK+9wYTaVFgrzmbydTFBhQwUym57mknVb/c+EGFF4v9rglQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOBkZtYEEYC6xsmQhTbQrTqOYQSf+n5e+gTYpxGGGPs=; b=Kq3kcEGPMMzAkMNgZQx52DaTG24rvhGBKmV05J67CeHVBzRG986GSOgvteUamLf1sNa3j9iYMLbbbHduM/3mwoUx1EUcGEmWm/bKuq5EHzQgMGCl9GOiJzpgEK/aIY48173jL2/STI3nOU2h7iPXyX2ezQauAggI7dslbfhU2OfYU1zZ0ZsVY1W+5DIjiea2dfj9ids5SQRXRnVZojfdoTAZMkGb7gJ75xbbuFFO6yCRkUmLRvDBm4Y5jYJb/7olxi6Gxf1XxfCsWq+JWAl+g4P6gXbC9kKXKCYX1gB8O7DvR6Plxxs7q6iVGiMteBjsAIp9HDNgbM3yPKRD+LkNpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOBkZtYEEYC6xsmQhTbQrTqOYQSf+n5e+gTYpxGGGPs=; b=Yih2dM6Gd7hYhOFw9jxTbY+ql8/cswRX0AnkOzb7gp02KEwufEftAJWNybPd90ZFv0xfEz3FFvfZkaRWBM1Na4C1qYbJb/FQBTXeuEf0vs81aLBVsWSB2ajOTgKLpDo7Bc7t7uak/i1Mymszlsxc3b7VB+smobwmIj9LskR+IXvB/StuIV7b/jNUwrduJSFL58Ai9SePYsGgPlcA8APByFaH44v4OslAgkPdMfW3ZxxSXq4HpcAyrT8kOhm41dTgsNhJET7Zd5C+eFzZS9PW3MHR7zcCciJpeIQaWoFeS1WbOZ4CPg5yBMiScudLZ3f7dPp2cTS+ce7Xfd/wz0JSmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:37:13 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:37:13 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 8/8] mmc: sdhci-esdhc-imx: fix resume error handling Date: Mon, 13 Jul 2026 12:39:04 +0800 Message-Id: <20260713043904.4144172-9-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA5P287CA0224.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1b4::16) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: 715ddee8-2dec-4389-255e-08dee0986935 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: HmOAN6Gc8V6A2tiH8EUnAHUm3nx8xk7kodQThPzzY1LMfTeI0faSpu1X7rLctQd7GteJpZtBpq6q54/xS9IQ9E0PoYLgg1xcy75xN/6aSWF6CIxUIjGHYqh8y9b0S/a3RakzV+jAExnJGWMPkGeqcxbMTyf4XCUk9rxfSCzvEL5vpAxNl3etVumXz4bDLDqU7/e/BWL0VujjRdcb9YbKPvAtEC5UYjJW7rtxPEZw5UXXU1nV1jVXazp+t5OJ0LobM/1ruFqjT3S9wzoXcPt4nJufT5G5cKEOhhCKpgYq6djO2rhyhL0NmGBAVvMASKyvRSpqIylYclLModIYAdanTrknA9sdCSc3T9elCwkAMdRLYDjzUxZ/4gHIhcDxFx9ZmeWXJg7W1Cpll6sAY+WocH6YBzZKxxiT1M35pCXNmVy7cdwXbnKSS9A62AP0GGuvF4PkDqhyXSjIMFBQOF57NbHsSkSThPqBdgn3FGS7QyyYTIc63F5St7s3x6R3vXsfF0KIkUz1HdoBGxR0YIEj7zYrczUZXsR6+HsLw2smPcPjO+/pCAkv9/hvSgP91AktyLFnIcOyJq/LRVnogljg3eYOmlEtIyD38GNGSRotghC070kpLgHv2YR+syAM2EO0BxZG/1R0RtvSBbxWwDLUOKTaGaWLEfK4vxPPxxS4Agw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7NMbs4kqIyA3lZprm5EYy3Aw55tM6RDxBPOIFnj8qi0ZB5e1iukC5U2W8o8+?= =?us-ascii?Q?au+saSXGq8wHL9pT9G3mh9AC0dhReJKySKd/p7vR7Oyrt3ZVKJf+fdLS5GQa?= =?us-ascii?Q?rI+QMVdUC6G3EttOlMRZtu0A/gsKcFBYV2xR0ZFXoCCSe0aMt4EsBl2SJs4C?= =?us-ascii?Q?dlYq95Gno9VQ+AGvmvgatxnPXubhD4x371vcrqs9t4KaBP4m49eU69bQUbI8?= =?us-ascii?Q?UOrwgFFwe0fG+9Bcaj7wqB+jmuo4mNYtWZMxe+7vFJ313YKjV+HH0rUy48e3?= =?us-ascii?Q?t2y0vl3LTv2XisKVY5JYs8iQbjdcY7rvcBSsnn4UEkiQVqXmEYLl4n97qDFD?= =?us-ascii?Q?6rRbwOBLUbA67d6qzwHDZ114ZJiRW6qo9i8PNaJ8Lu3Ult4gseuy6l0BDWih?= =?us-ascii?Q?80RGehzG0c1mRqgSs82FMPdLORtC6IVx9n1tsVwIojRIJyqshHKj1Ms/uF1C?= =?us-ascii?Q?k4J+JkC9sVlquYiDyBPWAhrE0zxTU4D3snNxXgJB9lTYa4QSom2+9YlxAYbn?= =?us-ascii?Q?FeHHK0plGMa3Jj2y1xo/85tCRlqTd85GjQgxj+ugtMsP9GkcOF6gkY9eU+1G?= =?us-ascii?Q?kkKUgWhfbpcC5fNaMPNDE7ZEGyFcO1n/f1P8xb1FMZJDK7nnUx2SsjDSwggO?= =?us-ascii?Q?rbOCWA++6rigctG5znJDyVQDWoVzKZt6/fFWsQU1COCqoppDVaL04yjiILuz?= =?us-ascii?Q?sN5pJid2YBxRJCzKIN5j/k/lME2itsU7KILQPpQYXBIS5BxgMA/vvcR2vbBH?= =?us-ascii?Q?O4HMxIiVHNkkkS0DKyG4qZmFmKQituv3SjL56d4kPtbrRsWAxnSy2Up6SxSL?= =?us-ascii?Q?5Bkx9Uh5vc092FrBq2kiNuWnopcRMXiGS+1nFmAlmzCC9ai3dklwDPEOxsEJ?= =?us-ascii?Q?KTOrR4xY2UnMrQ2ngZSJD+hRdid4jqvMrhD4gk0pdTUh6xbt5k5C5jA5+sbz?= =?us-ascii?Q?Sn/XySj0xBHLx2wV70D5vYduTHwH+uPZ7GgX3iLDANSjZmqRV/J6rO/FhNBj?= =?us-ascii?Q?6BAeOw9vGcYwb5I6jv4nDRObchfRIcvn9QYFw5QA37DJod6KL4oVNBuO3BGg?= =?us-ascii?Q?kvP/7SbbEtfLOs/NcBICirGytw6k7IyWKh6ok9PHTBLBNflNJJgwbq9LDKVH?= =?us-ascii?Q?kOCCXJr3AUgPLkhGdJsSEPqPkixODaHqMQYkiddD3SH3S/AbTzj+Oz+djSmk?= =?us-ascii?Q?mMj8ifYlcRdfuusdDXdQtrRGMrUhSn5QEuog4m+0herriaLP3b+tRzeoA01S?= =?us-ascii?Q?PxeXioq8Gyl4vz/vbA4uHxLRjQK6ta/Rwc9ZZ318sozNuTov/nYEcA2emeyl?= =?us-ascii?Q?VlJXFXr5LWyPj9PtnCpxsxkl2NZ1f1sVTe81/flyZ3hRJSbPa2YkLnsQP6WU?= =?us-ascii?Q?rjBvHK0nEHNpKeoN2rLh1lxKY31nBtYLr+wAE25iDluvxcpDt5NweqpEMEUL?= =?us-ascii?Q?GTA5JDTumkL9i8W1m3+fKbwfbdYso05Kwe2bnUeE6y+8K3/r5vehcxoCBiAq?= =?us-ascii?Q?n3UaXtvLik5FT+QkVxkSzEJEMxWNfVu2lx5KcvypnXOqAaP7SBjdCio5pE5k?= =?us-ascii?Q?7+MP+u/VZThK6Tmyfw+FPQdhzirOejruuPdmlTU4Nlz+R3XcsrXo9p31U6iG?= =?us-ascii?Q?2OvWAeI4I85sYCau8NuYIDhpRgULEXJYn2byt2VfYWQvjMi69YtaoRjIJEyR?= =?us-ascii?Q?ivCF1X1YfWMt2LqzDRM3vHNa2c9e8+zmZjmgz3EILUm14DVLrgXRUkTxmNUo?= =?us-ascii?Q?h2kneZsb1UBnK1ixOSDjPsfS09Cpamgo+5NPp6rQN1LxaV9ATyBvmJhqRLZe?= X-MS-Exchange-AntiSpam-MessageData-1: 9uxA9SP4u9FHug== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 715ddee8-2dec-4389-255e-08dee0986935 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:37:13.8850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sz+WyM0YhEnHZKR9wyTSR4jSxZW42XHADDtdOH/Qb0n8Ki7xTFOewLhSDKAiEXItVBqbch+PzK/jMjt0CiNv80S+2m0p6lMo7qTf5QhXA+tAyf6+xkf28mLzMCGBGHYu X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 Content-Type: text/plain; charset="utf-8" From: Luke Wang Check pm_runtime_force_resume() return value in resume. If it fails (clock enable failure), return immediately since accessing hardware registers on an unclocked device would cause a kernel panic. The early return intentionally skips enable_irq() and sdhci_disable_irq_wakeups() because the IRQ handler reads SDHCI_INT_STATUS, which would also fault without clocks. The PM runtime usage counter leak only affects this already-broken device instance and is an acceptable tradeoff to preserve system stability. Remove the return value check for mmc_gpio_set_cd_wake(host->mmc, false) since disable_irq_wake() called internally always returns 0. Also return 0 explicitly on the success path instead of propagating stale return values. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM lo= gic") Signed-off-by: Luke Wang Acked-by: Adrian Hunter Reviewed-by: Frank Li --- drivers/mmc/host/sdhci-esdhc-imx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-es= dhc-imx.c index 6cb84690fde4..f4bfb14423e4 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2126,12 +2126,12 @@ static int sdhci_esdhc_resume(struct device *dev) dev_warn(dev, "Failed to restore pinctrl state\n"); } =20 - pm_runtime_force_resume(dev); - - ret =3D mmc_gpio_set_cd_wake(host->mmc, false); + ret =3D pm_runtime_force_resume(dev); if (ret) return ret; =20 + mmc_gpio_set_cd_wake(host->mmc, false); + /* re-initialize hw state in case it's lost in low power mode */ sdhci_esdhc_imx_hwinit(host); =20 @@ -2158,7 +2158,7 @@ static int sdhci_esdhc_resume(struct device *dev) =20 pm_runtime_put_autosuspend(dev); =20 - return ret; + return 0; } =20 static int sdhci_esdhc_runtime_suspend(struct device *dev) --=20 2.34.1