From nobody Sat Jul 25 22:32:23 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0C4240611 for ; Mon, 13 Jul 2026 03:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783912538; cv=none; b=JIIno5g0R0khQBJS7P+pszmHCsmQnPTCaguMGXDUMd4h7+z8P+pMwPl81r4Yaa3q9gd4pP5UI/y+kYABse9An4410GqOVIhVCABQ7M+L1fedH7c44oF/H9kQZOrocG/tEMeRFlvxf5CjIWPo56NVpPIYt/v6skW2Ft9WsV7Zg+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783912538; c=relaxed/simple; bh=t8oA++ofkLjSUHQVdPztiR1tlyz354IWY+FPVWWxlwc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YDZk9dDs+8eg2LABcSW4t3MIXmnF9uui0eicaiALy3yIr1oYgbijlI8wTLhjjQNW7keAmW7wXpMmpJK95N8+MnJUAQo/mY4uBJDaHXK34Jth3VxJbjdUNpyjfS36TyDzhgFEkNcqx8LRcDlaDQCPoy6TLtirjonNhCHXETEeyPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VF2eS70x; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VF2eS70x" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-ca766c1c9ccso1387304a12.0 for ; Sun, 12 Jul 2026 20:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783912534; x=1784517334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lGBnUHO0f4jIfHxe2uWJUDkRQrU6rmLu0sMXefsRiuQ=; b=VF2eS70xv/0DxZX+d/BqC1aD6jvQ62DSSZQHP8/6DgEO7b5/CByue4+9W9WDt7aPZC nhWYywZuU53h6z1rQst0d5m5y4mpR0nFjGOZaD/s3fUueXjo0KD7nNEpXHhqfuOY3X18 jOuf7IFPk0hhWF3UF4hExqvCULcNcwfCPmWBfsP15XY77O3QspguCz+mr5698VTHc8Ft I42uy8bsmjYjelw+nJsaahOBf0sqMSk5i0lTksHKScD6jJMdFKryEuQMAoNTxr5J//9F Tv3CCOeL8lX6AqmCFkhqixfTa/QJrLgKiinXXNM1YPuh/6iK1dnO/uQW09LF+em82l4U UYhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783912534; x=1784517334; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lGBnUHO0f4jIfHxe2uWJUDkRQrU6rmLu0sMXefsRiuQ=; b=Y0tKXvgESKG20nZCNrgXZzWLCRMX0AvR2rrpgZ7BfYYIupnEqA5kh9PZgXuf+zcIab gn3/iSkDOyLqeTlJxQtrv6QGtcRqzW84UXK1dw2LTWPZZ+UVG89nERomUFsTy9IrC3uK gLY3hGJWZy6Wl0rZ6sJESdjjoxIQ7+TRSLdYqsbA6Q/gUl0OgISUlqYo+pMVAM+wVBhC /aa5LZE83AwU474f7wlgT57SlVdd3Z/yo0iaJzn9y5QFJJF3RO4QQ8RKa6gtP/8pzz9D xudCRenQyGfUjd2x696var6DFyoXSN2rBgDe7/INNV9/ekeZvYz1fUo5LQO9xKKfup1p 0MDw== X-Forwarded-Encrypted: i=1; AHgh+Ro+TiSCYKS0RnHF5dUN2nEMmlB++vuFUNv3fjy236OnVzb069PXFGkXmrlVrLwph8pgAbn4gmtbBQur4MI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1ghKoSEz+sadVyfc/XQrCPO3f+NgTNfbB3v7vKOyob+/xhbV0 wANgppRctFXoJF9j3Lrs07FwXYOi0vXUJzArZniL2/ZVtB2G7IBxJzuk X-Gm-Gg: AfdE7cnTpuAXeIydii1iRv+WcvDxfQghg+PODhAgvVCm+aZAuiDzsev3romYU3M3ZyX 9ORxlUgUdZr+QJnzaGq07vFcgpdPR5UxGY4chAGvET5nGq9gWYpkHYPdngPlb6LL2NwK0ICMHzh pZGHlSDzMqfl8zDbTmu5m3BuFA9AVuwiNpzmmNCIW/L493HEZmbyulWG8sLXUnGY6sm5uQoyxZJ dNPFZMb2A6qp0GG+L8diuwMKp7O6NvEGH21zxF+hvxeR0Fa9Jm/aQ3COfBsLmEMSwUrOp+OGRks bYJJGr/qlJQCCYVoDR+YPUnPg5SPIMHYTmUJCFaqAFugfUQbyrtYsSdYmr+wGdAnwcAcSMEGZq+ CzohNpsFtGvC34I2ZZdnSGGYc2e8JIPUiwG9LiTmhGQh7OtJnlZKut6SnjRQNn+0EyKGCAFaeBg UNiFA5L7TCSO0RkuRaaKCxK+VQaeiPpvzVX8n4ebMf5/AgRF1Kfef9+f1Ed0TToWMGfyoy3Qiya HJgF5slaxgQBfvOwj80JDr0kiRHlczX2sOr6ONoDAKVa33z9b1Ldj3awj5mJW8VWuI1tmXMLhat X-Received: by 2002:a05:6a21:468a:b0:3bf:b68f:4682 with SMTP id adf61e73a8af0-3c11062ea08mr7111178637.7.1783912534078; Sun, 12 Jul 2026 20:15:34 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af7d58f3sm7686767a12.1.2026.07.12.20.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 20:15:33 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Srujana Challa , Bharat Bhushan , Herbert Xu , "David S. Miller" , Boris Brezillon , Arnaud Ebalard , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2] crypto: cesa: switch to non-devm IRQ to free it earlier Date: Sun, 12 Jul 2026 20:15:32 -0700 Message-ID: <20260713031532.2458000-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch the IRQ request from devm_request_threaded_irq() to request_threaded_irq() so the IRQ is released explicitly, allowing it to be freed earlier in the cleanup path rather than deferred to device teardown. Add the matching free_irq() and irq_set_affinity_hint(NULL) calls in both the probe error path and the remove function to release the IRQ and clear the affinity hint set during probe. Fixes: f63601fd616ab ("crypto: marvell/cesa - add a new driver for Marvell'= s CESA") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- v2: fixed Fixes tag and reworded commit drivers/crypto/marvell/cesa/cesa.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/marvell/cesa/cesa.c b/drivers/crypto/marvell/ce= sa/cesa.c index 75d8ba23d9a2..57c9295be711 100644 --- a/drivers/crypto/marvell/cesa/cesa.c +++ b/drivers/crypto/marvell/cesa/cesa.c @@ -511,7 +511,7 @@ static int mv_cesa_probe(struct platform_device *pdev) writel(engine->sram_dma & CESA_SA_SRAM_MSK, engine->regs + CESA_SA_DESC_P0); =20 - ret =3D devm_request_threaded_irq(dev, irq, NULL, mv_cesa_int, + ret =3D request_threaded_irq(irq, NULL, mv_cesa_int, IRQF_ONESHOT, dev_name(&pdev->dev), engine); @@ -540,6 +540,10 @@ static int mv_cesa_probe(struct platform_device *pdev) return 0; =20 err_cleanup: + while (i--) { + irq_set_affinity_hint(cesa->engines[i].irq, NULL); + free_irq(cesa->engines[i].irq, &cesa->engines[i]); + } for (i =3D 0; i < caps->nengines; i++) mv_cesa_put_sram(pdev, i); =20 @@ -553,8 +557,13 @@ static void mv_cesa_remove(struct platform_device *pde= v) =20 mv_cesa_remove_algs(cesa); =20 - for (i =3D 0; i < cesa->caps->nengines; i++) + for (i =3D 0; i < cesa->caps->nengines; i++) { + struct mv_cesa_engine *engine =3D &cesa->engines[i]; + + irq_set_affinity_hint(engine->irq, NULL); + free_irq(engine->irq, engine); mv_cesa_put_sram(pdev, i); + } } =20 static const struct platform_device_id mv_cesa_plat_id_table[] =3D { --=20 2.55.0