From nobody Sat Jul 25 22:32:29 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010061.outbound.protection.outlook.com [52.101.69.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 543032D3ED1; Mon, 13 Jul 2026 02:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909942; cv=fail; b=UyMqI22m3Y7/wYsoUOysa7YBQ0Eszq+xtgqgI5+yBwaRRzDhPQOZ+LmLLxT+IT8ej6Q5uFZ1r9XuBQFKN3SNY3MsEVv5Fsth4y84zV8IRiFHx1/PG4tkQMrY6zM4Q7YwRAUCKKIxTYdh6EtxVcxXEmN/Ybd234Nk83E7ZCCLypk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909942; c=relaxed/simple; bh=CS1iB37UB/JrPkzbi++v97asRnuCRDk0Fpyfp/pvgfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=WgjpdlmcklEyb9/uqIp8czPIT+/Nh5HQLfQBcmanoYAGgbhxWAUvA6YD1CZXTzNtJ5EbKxTlmXqyBJDjuX12qIvgrTqnH0djxrr8r9RuWxAzIzP3lDATLs5ALgr/uwURsGxCJ1gtMsinWZezrbOXHDe1AUCWW3aocvNwelAJ71Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Qjsz8IhC; arc=fail smtp.client-ip=52.101.69.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Qjsz8IhC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mfm5s3Hk18tymw3f3QznW6YMLAjCF36Zz5AzjbNNNLDc/YeHZ94WTZXzFkBX2AwKnlUjjLiCwyio0DkBbYpX4E0KFXvXfKKVVUNk1Tkk7DNbbAQDDpo5PRsVQVOTOmweG83zxuD2xybGl1ejhBGrSxQERjsziOu/JdoUsXiSONzigDIQ4hHMSoBy6apmBp4MM+WSBQrrHrPCPFcid4vy/NBH5DoH2emv8mYho+S53W16q9CmuLC5F4h1s6G4ejBb6jEy7S+Lv/kVegUbL9tjptJy3dBFMj/1PsgresmATQ6p+mmqRXSNfd9m8HkhIhH7MzvZ3RNn/sG9UgZTzE8UCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I7BzagAjsEF4KP8iHoexNzNMNILJNF9N4rwnI+PLUHw=; b=UWS3z+rWJfFlJ17ZFTr5clyvcMuF4SyP/88bzSbmDxXnwBdrs0PznMDqNwuSbQrVdgx8nE0R3syit7ebfEife12k7RIbu1tnmwUzLyQioXWpcMtZzUo2ZRkqvEEvbLPkTErSJ1M1t6BybhLg2bNj0YV8SRXzYWTg2v5lABJaIJJedVt7yPAfibHyGRCi0+GwGvXZWbRSdO5V8M2haQfUvvSnDNqY5CivCeW7qxGJN100OjJUCMA+BbvEIrvR5RoChz0LAxhCjyLhFFKnTvCqPtSflEXok1w4+SqGF7zbAB0V6JsHlknBYiQHRxTBRiJVI5ifCdO22IsNXgNwt6O6ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7BzagAjsEF4KP8iHoexNzNMNILJNF9N4rwnI+PLUHw=; b=Qjsz8IhCbwvhZOEbjdmZ30+opkAjHkI9wR7JBTpKC2jZgF65ern7e3UcYlR6fysJWfRY5hc7uhaIRRJyUZt5nvAY3LVuKGG1NUvsQwTKjmz2Vjd0FL8wCJZ7n4Pv6HQC4iNDmcccNEoG8HlQdbDr1w60feuNI5KuPDsQnrR//wipTUrJzgZ/VbPOuBYZ1i2YCMI4oPxgcimh/pbjh2rR7dN43SY8DDjqR+57/uH/TuOtIsQeGG/ycJ2PTH9nxOKMbA83KZCDiwiaNbBFd3DfzO/5+doTW4HcuV6VO0cAqchFSPRZXDbBmLqI5+A2JZY6H2+4gW4dxUWUQQ/Q97EXrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) by AM9PR04MB8810.eurprd04.prod.outlook.com (2603:10a6:20b:409::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 02:32:17 +0000 Received: from VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be]) by VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be%5]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 02:32:17 +0000 From: "Sherry Sun (OSS)" To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org Cc: imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, sherry.sun@nxp.com Subject: [PATCH V6 1/4] PCI: imx6: Move pci_pwrctrl_create_devices() to imx_pcie_probe() Date: Mon, 13 Jul 2026 10:34:32 +0800 Message-ID: <20260713023435.235765-2-sherry.sun@oss.nxp.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713023435.235765-1-sherry.sun@oss.nxp.com> References: <20260713023435.235765-1-sherry.sun@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0005.APCP153.PROD.OUTLOOK.COM (2603:1096::15) To VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11276:EE_|AM9PR04MB8810:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c74b4c5-3a2d-40b8-779f-08dee086f4d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|23010399003|7416014|376014|6133799003|18002099003|22082099003|56012099006|5023799004|11063799006|921020; X-Microsoft-Antispam-Message-Info: HATTUeoOAwociBtDKlAjeSJGHRuUSAhY/kparKUzXPs3KCtG4t/MWPvoWbTOUrVZGjg94i2tGlFR4+/0ORj6F4t2SY9QsDazeKwXoSIHciGEZaLI3vweoRR2RL79rxRDYXCd4xWTK5K4krY0nS7u+Ezq5cZy2hK48McNnYTflkXsjohmV96ZRliMt9SPHTLQCVnyIkQTU/vDm/nWjAYOmYnGle7HKiG4ej4Jv5nOSYpCyr4rzz23ZK/tKSuD5irl9VZBLcn0x9nLt5qkS9rxDIyfpy2VZrPbV9qeBRUJayRLZ8JguXCkhAC9uj3ueWuBBDO59J/87AyS1ROXT+qCeBfdg6+nuf853S30jd8M+jLF4UrllnSX5sMHvPhdJkGlYlvVMJc6lEwMwPmIpmhu0s0/Nk2/oqOgsXkJfXW+Efnx2UKQmN7H6rpTnPpzbniLes6UIh4q1/lo+vNCEevml+hAc45sBqb5Jl4bbNwWjoc/CxRSzp0LnkytO/V5FtjRp3ZXuPDP8onVOKxKIOUQ5KuTPED1b3kM2KI4pkYsWJG4R/vGigSaoGxlI1f3/7QWbHvP1yq8jfHu4nMoKp/wYiMcfXRCmW/+7GM1CTW0/tAX6DfwpakQ5ezQvFcrn1KwLaNS4IxB/7CB/Mz8WydtpMw3cZPbYj3bvAO7OEGpWoXHzCVx4LUkafdNQDwXkaCwPyXmHGne6V8BbaU6Todq6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11276.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(23010399003)(7416014)(376014)(6133799003)(18002099003)(22082099003)(56012099006)(5023799004)(11063799006)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FLXbFYUO8EXyZ7/9q9yxiUgLu7St/GF7zETBQyQ8YWBVcC1ieBB1fjkroJEH?= =?us-ascii?Q?PqZou0AW/5TMm6hnXkSwidJMkweUAYBh9l24Tl0bz92w5BkprejXnAwUzQgN?= =?us-ascii?Q?fMNcCNdxYTO0rznHcSPqFNslXWX0BgIakqGyS7GS1t+Bvumdj8GE2gOARmQk?= =?us-ascii?Q?PqejjA1gOp7XltRbWB+p4wtwhdomWGBdYT4ybawxGO+ATm7cdf7xuFLx8a+I?= =?us-ascii?Q?Xq+ejWjJmwJZ8wfWdXxwj4JvXcFu1GddtCWTl4fNMAX/0ZhOnbmv48b1WNdu?= =?us-ascii?Q?nL2qYqqznKZG5DtUO1GxcorrhbOYHt0Wh7H4/4Mvd+rMkquoAofsP3+Fh+FF?= =?us-ascii?Q?5AgGSrvgsNijHLptqpTfESkjSk9bJDz6k61SEtVjD4fhaOEKyvqr+UymzI3h?= =?us-ascii?Q?ChlKQJ8dy4DjpuL01rHFl8ncsqDFqMD+j3XSnY/qW3u1AuptIcJOMA0jrh4Y?= =?us-ascii?Q?c72yHlRCuJvaQp6Rw6juhOZnbYZooA1Js+Mfq5XMlMBgjAYhgAXk2j6u6I9Z?= =?us-ascii?Q?NDC9x6UZ187pm9u4v4z89po5y5zfrRr59+pLB3ynwS42uHMU3EMHJCCE/8nR?= =?us-ascii?Q?Jv7aAY+6Ep6RqToEnS/gK6TPETTJVdoQme4CHNg+j3cIndcsHrNMw7bMQ+Mf?= =?us-ascii?Q?sS8zRJ/OYbhf5j8/Qn6z/CUYdNgIf4VGJNx3AmVhaEL/SveuPeNKJfPLgO2a?= =?us-ascii?Q?6ZayRs1pwtSL35x1UmaYdRuM0lknEMqR2rt+Mn8QIPMeUtSWewQDAnZeXMp1?= =?us-ascii?Q?vyljgzG6ozOj9SVyAY1MczMsFQqHb+Tq3xkzPQofDG+45yAGArHRn4E72vEn?= =?us-ascii?Q?1qlsK3FOqgLgTuapOHdpmbV9TvLRayQSSMF8lEPqGIMWZnlR1RXtZNEYJh8f?= =?us-ascii?Q?gqMulpL5Goq+bEcdmWFOPjuOtzcVO8cwZSxG+45Xb9RnQvNVZkikWAUHusph?= =?us-ascii?Q?sGzNUF+2uYrMDtJ6FtmCR4U6Aan/1iLSZ8dOi01GPUpIUO7Vsp9G0QSKXavL?= =?us-ascii?Q?tg5kMXs38+QlRkzrYjNlekBc/4AQRdAZhh6oBsVoRu6vN7lvFx7ePQb7Hs9u?= =?us-ascii?Q?oC/qka81dxnuGQQPHtmTxU1x6+ZtH9JYN68+dpuDlPTS4Jua25+h/GBTL5So?= =?us-ascii?Q?ZK+JziW/6KR6Y2Ree0dqNboxNGXNN8mkfp2iGJpY+R3uaPSmlH+QCmsyk9Wa?= =?us-ascii?Q?x+BXM6In0nZAiEN/9uqzIk105/KiGU94Tm0fwaZElPE4XcwdkdsFkBEwZlDd?= =?us-ascii?Q?OVDHmHZ6yjm/dVprxPMzjps221VLfV9ODZvKjYKyfy3UIKCOkvaqor+UUz7C?= =?us-ascii?Q?JITTuuar7+OXyahTI8aFQNHtfQ+bzK5Yqcf0hfkKsKA3nc468QfNtqrfGQmN?= =?us-ascii?Q?eT7s3WH9UZOreKG/F/HaNjzCA23RO6v0Qx8XjkNfxTls8NHlRiUemK6zdQy9?= =?us-ascii?Q?B8+xyjJ1pjmqhV+Dcy0SIeJIdh/6i2pCzUPPlr5hM9xZmd7gxYmtojx5XaNc?= =?us-ascii?Q?3MiLtxbmmZ+6uy7jrGRYkyOx1WG0Oaj1ZhYjNJ62YCHz76sNo1u6ZXV8X96a?= =?us-ascii?Q?oEZ6P88CmTvxetDFXMPsgShqbys66XxswCIUurJYyhKCZ1mleTDP7irh7nnh?= =?us-ascii?Q?VuA1H3lNlHe9jtD3AKrnv5EDz7iOi03oL54zaBiZ0ipkiNftL/ZjtrS9eNhV?= =?us-ascii?Q?qZiPsmb7KHR66AWPR3YxQTlWFnWnT47sC5L8DxSWjw8Lnex3QgxhEx6s6siW?= =?us-ascii?Q?vy392ebuIwJ/p+SDaQ2mEeWCI9P9s8PnjD6IW5BkJeNWHGMO3/LT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c74b4c5-3a2d-40b8-779f-08dee086f4d8 X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11276.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 02:32:17.2489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mD3XqLy7Kni7tt1xYY2bzdW9usS0chVxyapvQojTVXtpwGpaIFDEizCA2BMYqOFd7nbry2XKtta7mEJ0blc1AiX4Mw3tfoUK3sLTZO9UvYsoAu3XrIIEzfUPMF/p5CjG X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8810 Content-Type: text/plain; charset="utf-8" From: Sherry Sun Previously, pci_pwrctrl_create_devices() was placed in imx_pcie_host_init(), which is the .init callback of dw_pcie_host_ops. This callback is invoked not only during probe, but also during resume. This caused pci_pwrctrl_create_devices() to be called multiple times across suspend/resume cycles, which is unnecessary since the pwrctrl devices only need to be created once. Move pci_pwrctrl_create_devices() to imx_pcie_probe() so that it is only called once during probe, similar to other regulator_get calls. Signed-off-by: Sherry Sun Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index f55a68f60eea..92f8e4a299e8 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1382,16 +1382,10 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) } } =20 - ret =3D pci_pwrctrl_create_devices(dev); - if (ret) { - dev_err(dev, "failed to create pwrctrl devices\n"); - goto err_reg_disable; - } - ret =3D pci_pwrctrl_power_on_devices(dev); if (ret) { dev_err(dev, "failed to power on pwrctrl devices\n"); - goto err_pwrctrl_destroy; + goto err_reg_disable; } =20 ret =3D imx_pcie_clk_enable(imx_pcie); @@ -1461,9 +1455,6 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) imx_pcie_clk_disable(imx_pcie); err_pwrctrl_power_off: pci_pwrctrl_power_off_devices(dev); -err_pwrctrl_destroy: - if (ret !=3D -EPROBE_DEFER) - pci_pwrctrl_destroy_devices(dev); err_reg_disable: if (imx_pcie->vpcie) regulator_disable(imx_pcie->vpcie); @@ -1954,11 +1945,15 @@ static int imx_pcie_probe(struct platform_device *p= dev) if (ret) return ret; =20 + ret =3D pci_pwrctrl_create_devices(dev); + if (ret) + return dev_err_probe(dev, ret, "failed to create pwrctrl devices\n"); + pci->use_parent_dt_ranges =3D true; if (imx_pcie->drvdata->mode =3D=3D DW_PCIE_EP_TYPE) { ret =3D imx_add_pcie_ep(imx_pcie, pdev); if (ret < 0) - return ret; + goto err_pwrctrl_destroy; =20 /* * FIXME: Only single Device (EPF) is supported due to the @@ -1973,7 +1968,7 @@ static int imx_pcie_probe(struct platform_device *pde= v) pci->pp.use_atu_msg =3D true; ret =3D dw_pcie_host_init(&pci->pp); if (ret < 0) - return ret; + goto err_pwrctrl_destroy; =20 if (pci_msi_enabled()) { u8 offset =3D dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); @@ -1985,6 +1980,11 @@ static int imx_pcie_probe(struct platform_device *pd= ev) } =20 return 0; + +err_pwrctrl_destroy: + if (ret !=3D -EPROBE_DEFER) + pci_pwrctrl_destroy_devices(dev); + return ret; } =20 static void imx_pcie_shutdown(struct platform_device *pdev) --=20 2.50.1 From nobody Sat Jul 25 22:32:29 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011046.outbound.protection.outlook.com [40.107.130.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2E0318B9B; Mon, 13 Jul 2026 02:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909953; cv=fail; b=UuLGOGHoYRsK97YxfwRwf/b6iaxqgiUS2coD28T+PNe6KAR+eaXLbzJ/w7WSD37z7B/2AZeS2+aTZ7faw7rlqddgKURSbQmxNFvmXiAYpwLiPfkpHbMaSxEO02OVsfXlqMfo/kmPrx+NwI/gJVsqFsJUjB+S8+8sBDWSDwBRiig= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909953; c=relaxed/simple; bh=lxgQ+eU8nE3MlN3l0xUv9lnVo4bVfUgnVtFPnWMBct4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=atVzGJXhrAdvwcb4RxHnrkF/WmtOCb7hWikgHVcC/dfze4/PIn96JGsCj604FoFR419zN4dlb9Een2mfajdWUXoVmoxmlyPyB6XzZxPi9+h9p4VRk6+hFYqnQJJUaoNgMDhE4y3GWAA6LqzQAmstdAIQ1BnZtp92mb+BE4VF6QM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=JtLfQzbv; arc=fail smtp.client-ip=40.107.130.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="JtLfQzbv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K0Fk18qTPVOQ7weWfRfZcIbYVrp39+OU9GB6hVFK4KcpJhfMzjImGMDlnwtl4KjPIHOGx46YHu4Xp680Qeq/SkBNbhJkHhuq6Jjrj1lhyC28vvUN83AncFrUf9J5rM+K0sb8BtjKryRNiRVW/maqHbdYrozTzKnQX2zSds04n72ULqLSeJ9lxdY/+EsdjwIZtEkGokcuoQojQll1+1NCLtD8LlLbK75xZxYJOGxJSTufai6zwnCi8Cxej633G2sdER+dfljHYbMdWg064YLdlmZYn//ZaeNIwzs74NHpo8TECM1BvMonpcJ0gBa8Pe5tLoNlyOWR6U+O/e3lwLtzSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxFoTxT5QQqje+oE/KCQbvRkw65a9YSAM9FGmAc5evo=; b=yhkog8E686MXOIUZbvCSr65se/J7NG6Q0YRU0VwHBLeJ0OvMZnSshBoF8qlrwgUp67ISWRRyl+QEk6wFxrXDYCGoszwwTnHQVhzVP2DapKkdfx5aoKM0UI0imjxC6kqcfkU3ng7+tUV4VIjXE5QQi5hFcUQ/3026/EdPLhNvgO0VFPeWCBf1cAJJmlyno3YhUPHQpIKuFpzyfNgpMrPpOA0NBSUwLVld+loZw94qE9q0zLQJwV+/OqC/ruw3fAQPwrGRr0vS1g11U8O44hl0xvI9beDxdV/bBtLQdQePxjK+ESMi7Fv/PRgXv925d/+aUXViYoRBRKfP2HGQ8KNqSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxFoTxT5QQqje+oE/KCQbvRkw65a9YSAM9FGmAc5evo=; b=JtLfQzbvf6qXcyDA/hr/3Qoke24QvNgmcKAP0gU9H1Eazh9mWGpqqfJgpXJDmcWNGPRtz5/ywUy1Z+GUNIEIOKS6mejQWDYj8SaL3HYatoHPTFsE5Mn9ENNfjGI5bHIS8+xPvF0+p0k+xVVT0hQukwhVLbU/KAv5fpjIjN+oSLWwFOh54CW7tf4Ko7jXlR/pP5V1dTvCuGGnD6Vc+1lNHfR1aYbVYyNgTfdEHZZUt7MbD8WzDrWbKFowhonC/Aqu7ahl1RAeZLMSqSSNnp3IRmfhqomjVWXY0Bub3Mpb85Ns2lj5MqnBRz3ueW5sIcQahNvziblQJXp4Zvrn90yQCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) by AM9PR04MB8810.eurprd04.prod.outlook.com (2603:10a6:20b:409::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 02:32:25 +0000 Received: from VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be]) by VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be%5]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 02:32:25 +0000 From: "Sherry Sun (OSS)" To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org Cc: imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, sherry.sun@nxp.com Subject: [PATCH V6 2/4] PCI: imx6: Add skip_pwrctrl_off flag support Date: Mon, 13 Jul 2026 10:34:33 +0800 Message-ID: <20260713023435.235765-3-sherry.sun@oss.nxp.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713023435.235765-1-sherry.sun@oss.nxp.com> References: <20260713023435.235765-1-sherry.sun@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR04CA0004.apcprd04.prod.outlook.com (2603:1096:4:197::22) To VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11276:EE_|AM9PR04MB8810:EE_ X-MS-Office365-Filtering-Correlation-Id: 91e03a6d-dacb-4615-57ec-08dee086f973 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|23010399003|7416014|376014|18002099003|22082099003|56012099006|11063799006|921020; X-Microsoft-Antispam-Message-Info: GbK+idxBU2AqTNHc0ijRVwvtGaKoe+/oj4PhMpXB8v+rYgG9xiumSjR0Rb9ADB0lGKWEItqsm0jRYtUPSpGJqz8M4RXYYKYck3HJo6Ols54oIq1QeUmOpicsre11pc/cCEj8TAiC/U1i1CyWNQ5Nqd1pLAyv/thW5i94Eyeu4LQFn1uzQATGd7JlSVhSJRFMkWmfSjjIEy7WQB4uEu5cPlkjqbqtzU5WOenYVwivM72baYo6/iIpIKbqksm55lgcKG9CB+nAJ0/Rzsux3dh//93m5IuvNHPGw9wers6E/5/uznZfperguUCtazuADjWwGOf0qAZI7amy9aPc/qeZzvOYtRVF0BFm7vsRUXs4BSXzaid90z0Hs5Z9+Y/GwycDp4JCP8kUWb2JYPw2Pn4FWuGY80jf8+7ZCIJx8zQwYRGqBEb6H3sTyccs7qvE6lregX13hOxi/5II8Y32OftOC7rVzi1vjGkGW8tt+KYw8OJ2bGgiJ9xszoRaKDgMozMFKNUSlAYZtCid51VXW1xFV0qfKznXW1SMd/90wp56L2AuGm0vkv5ksHJu5hk6BNwfmqovmxAy265sEbNvqhA1PK6X6eDtydhsi3JR0FPgMAj0Vsueq8K0wnG/SG5Xgos+y5j3XEuMwFhrYnSTMg8JBBorXA7AKcMy5QZoVjOoRJ+7LEyeDVp9f9isQ4uI1+urjeINUiE2xAWosqe1jBlxrA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11276.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(23010399003)(7416014)(376014)(18002099003)(22082099003)(56012099006)(11063799006)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6tjDf3duxTReyQMfSUpHbplUjTRKQJrIDpKcbs2mJs9R9EViX1SvofVuqov0?= =?us-ascii?Q?zB2qiVjFrZKuGa0rkzvNhWXvWzN96GeIA1MvnlKa400deRetZFEPwTAmiSad?= =?us-ascii?Q?xiJ6WTpUYVznynFWHhL6TZRfRjFIeQRNj7KXIB1VMJq3xFRoe175+ErQs0GE?= =?us-ascii?Q?AVL9Lr+dVdqzEDGcow2s6nGUQzu7EIWsCWELlHSY+clmB7sw0cWSPC3ejSgb?= =?us-ascii?Q?7tlYNEQYWiNOnuCi3lqMFGKUwnDrZ5fS7BC7mL6dOgeLnyB829Dh0sDg1UoF?= =?us-ascii?Q?BBRy9nEW25CM8Gf7QH5jsFxOuXtYP5Jn3jFH7Afjp6V1QVTMamw3kJurFQmC?= =?us-ascii?Q?oY8cXxZSa/y53Sr95vl+nan+epGYmQbeGt7yHGYFa4CzGuGSb5vARHOi6gOY?= =?us-ascii?Q?dYd/59IK6sboOI9jiqhUDkx3PPMDXxPVsHsyZgajz3levZ5AJs6gxTXiy/Wt?= =?us-ascii?Q?6K/xcuSUZ2UX0+m/XvIZyRuiP3KlH0caDviZaBDhCVuykF1k+xjRC9UCCN0u?= =?us-ascii?Q?0GwoV1eE0B9r05t9b02Z3DkWfNHgdM5DogzEuJY6qbO2z7Av5z7b25OVsNWf?= =?us-ascii?Q?rUdkAWH2FesR/q1h8ssL3v3t4lH6DSGAy47PNPzbELee4Qtvhq7YAVuj0VqE?= =?us-ascii?Q?+8EffwY8u7J1efQfLByfBN9fXJjU+x5o5b9klP3q7IBBcZDsgSXia5M1lem0?= =?us-ascii?Q?46HcuSYuKRwHZlzMm4kYnQsWggdrmHHvuLAsjOCI3+1z0Y/Xvm8pzw/SXWpK?= =?us-ascii?Q?8g383E1vkqvzfYJQvJ2axKjCDE+CusBUXmA+Ex5jHpm3cJg+ornQU6bMRy8e?= =?us-ascii?Q?wN3o4I21J6pu7NYlo4gKuLPPheRinIApGJ3oMxvJvEJKUtDNmPieF2kSzrxh?= =?us-ascii?Q?C8p2TbOH+gdhNHqSQDT+JBDlgFqSwIFreuCH/0s0HP8QQWQSl3IC8lQHMH7Z?= =?us-ascii?Q?gMfAJ6URiYVVdJlNoal/RZN5CaHYN5VFz7PKRKIWziFkXrmBrgInZBgYGXPQ?= =?us-ascii?Q?RjWQANTFcMBMkq+9vJv6YZQF21mHrdEoukmy4w8UEBmN5VjXCHsbC17GoRSQ?= =?us-ascii?Q?acHVOH0o4QeQLuwzMwVYeIOYak1tLuw0hsaaUSrATmAsSO97IS010fxC99pq?= =?us-ascii?Q?BwEsDXgFi04nb/tk71ezFhopYUHusy0LwbsDZyO73daWVVJi7Rjk+6aaHe5d?= =?us-ascii?Q?oJjf2M9nTEWsYGD5FDirAFpbHegAe1AsHfu4lMRAKk7s7jQXrCBHBCReLwQk?= =?us-ascii?Q?nKW6CRMfIEOVpUt0hWq7OWVR4nd247C/ANLRlx3Le0jkXe+XKr0RJn16H29Y?= =?us-ascii?Q?bo+tbv5l36YigZjbtmrkeXfOCWJB2mRx5K/CGhXki24VhSQrLdu0wyrCN/bM?= =?us-ascii?Q?0ibzslQtZ1iInBmHXbmd9QXY8810rdAnkyiFa2iEEdOFsRR/nivXbV2Ru9kt?= =?us-ascii?Q?qnARgI/Dzd6fChbfHis94Wu4cl2JjPubK1HrMWbJ60no7g4zMpDC4v8FJyR6?= =?us-ascii?Q?t6xGaiUtsEBft2bETJj0c3exq/pGzJIh5yhnLbOSWQgHnS/XvWqCWmD45egG?= =?us-ascii?Q?IAEozV8+zf3rdwSWOaOjF2E/mNGqIq2R4sFb8G9Tz6S4ALo1A3Uqnas1Waju?= =?us-ascii?Q?xMxOpLsUoc5B+zdu7jPAbYg/P8KEj+d/sYmZYLPOD+DV8kSDz6KjMo1EWndU?= =?us-ascii?Q?I2ab5aBCplTWuOPchGU9XxvLlNAaHVQjbRRH7qMMRGPs19f/H4bvWmwpnPbZ?= =?us-ascii?Q?pLuKEKarmgsqRQcvVx3K/K84CE7VYsFow5vjZLC42P+P5uuwijWH?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91e03a6d-dacb-4615-57ec-08dee086f973 X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11276.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 02:32:25.0377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k2ffq1h3WNsngWlR4jQRii+ZsAXXC7eHUeVnVzG12fxaEXi1JupG9Y7ghFO1IJGeAK408m3pwTybOiN6j5Zut4lU+tZ1MnA6N52joZBSGUsGLNbPL7pEjqaGiLEDd2xH X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8810 Content-Type: text/plain; charset="utf-8" From: Sherry Sun Use dw_pcie_rp::skip_pwrctrl_off to avoid powering off devices during suspend to preserve wakeup capability of the devices and also not to power on the devices in the init path. This allows controller power-off to be skipped when some devices (e.g. M.2 Key E cards without auxiliary power) need to support PCIe L2 link state and wake-up mechanisms. Signed-off-by: Sherry Sun Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 92f8e4a299e8..afcf3b6bf3cd 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1382,10 +1382,12 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) } } =20 - ret =3D pci_pwrctrl_power_on_devices(dev); - if (ret) { - dev_err(dev, "failed to power on pwrctrl devices\n"); - goto err_reg_disable; + if (!pp->skip_pwrctrl_off) { + ret =3D pci_pwrctrl_power_on_devices(dev); + if (ret) { + dev_err(dev, "failed to power on pwrctrl devices\n"); + goto err_reg_disable; + } } =20 ret =3D imx_pcie_clk_enable(imx_pcie); @@ -1454,7 +1456,8 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) err_clk_disable: imx_pcie_clk_disable(imx_pcie); err_pwrctrl_power_off: - pci_pwrctrl_power_off_devices(dev); + if (!pp->skip_pwrctrl_off) + pci_pwrctrl_power_off_devices(dev); err_reg_disable: if (imx_pcie->vpcie) regulator_disable(imx_pcie->vpcie); @@ -1473,7 +1476,8 @@ static void imx_pcie_host_exit(struct dw_pcie_rp *pp) } imx_pcie_clk_disable(imx_pcie); =20 - pci_pwrctrl_power_off_devices(pci->dev); + if (!pci->pp.skip_pwrctrl_off) + pci_pwrctrl_power_off_devices(pci->dev); if (imx_pcie->vpcie) regulator_disable(imx_pcie->vpcie); } --=20 2.50.1 From nobody Sat Jul 25 22:32:29 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011046.outbound.protection.outlook.com [40.107.130.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A581311968; Mon, 13 Jul 2026 02:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909959; cv=fail; b=kqsHEd4qWhCPk+3DejtfRxf5Rb6LU7cUvQttsFF/50SXX6uzTD49l92soK5VpQa7xBj2Am/N1D1ktsFwnSb++vEvgSGkjBy+iSKvjWvKIcZl3lLItUpIVx+wTZQ6+E9zD/oMx7Gbgg5IH41bkEih/Eb5UvaM5wImNL7qJg3IZS0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909959; c=relaxed/simple; bh=VMaAgKbRGA1hzQArIteObBK/Z1iQtpHh/xqA3drxe2U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=aeghVCG824d8/lBQ4e3bvmD6SIqXMeGQezf+w9ESssdFQ+pEDvaqGHzQ+XbAFL2lpuGmShvoa3EbM4+vsa/YL80LnNtAOi7k1oRO7b76DM4EPCt0cChwjrGTyB7TRnf2LttmJJL//0cmPiSlMlpa09feF1s1XGlLExJn8M0gMN0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Av4uTjeE; arc=fail smtp.client-ip=40.107.130.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Av4uTjeE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RSjzBBUDhdVzcSNldEfUmHZSxcETSoURbCJJW5ic1T6bDenjrHutLIHkOqUqtYXMr8PmqE9C6IdWf1dWXRGa7TtpWhbhGG6e3tYk8XwE77yHQIOekWFTrsJTML86TNMkNZrp6+kdhOxG7p21fJYECPEgLIQDm5zsaLKoAJNyGNY+5Hdh1zMVmiUVDHj5h6rTlj1i9Gy04MImk90+KsqdBBmJnrcFwunNJhjHUak6fnAtCySqAKkeYl6gsKsPm4Ex0O8Qx2edLeWyq1b4Lvys039Vii4mr8oFbZOAHvgZMscUq7wzVL7mc7L4Ntfa7GPVRD6Dk0Y/s/kkQLzRuumGpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n9nOR5aMN8UyjB12uPh6f/wGG3WxMwoPeEaP/jLnL4w=; b=nkMU4lKNGkIp9M94UwP0ySw5Fc07fDlqQi72k074CnI38+lmOVkMdrtbF/NOqJqQKBq6tvmjLVggkBunr7pmA0FuSSq+B05iuzzcVrs1cr3cL6DfMCsHeMxIDe43vhfjepeml+w5mWqG+4i5TMqvEH0jZQxN570tF1I+J7Z44QTaSxNPI8m4t2aCQ+XxqrrNEW/o9HaRD/HEZIv5uq+r1wK584kyVCxrsUYoLp0JDxZ8jHQXeTj7jRKc8LOZcu//wxN51f5/YsqTCbw4qMpuuncQHlBAv1SxnxZZKofnZgHz3f4APQ/0esajy2YlCM+eFEOzMTlobE69qWVBH1mAhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9nOR5aMN8UyjB12uPh6f/wGG3WxMwoPeEaP/jLnL4w=; b=Av4uTjeEaEpj+/Hh0zd8jaOsQFhScEH1Zt/X3JMg50NsOJG7KVIytdtvhmPvEZTluVkUhcseKRN3NKlrdVEDEVtdDjmPSOQjCPu/NVeyi8bHcMTAV6stUlAY2D23KWanEF2abILwgxhmkt3b3UJdmLR3kRWgYE5NUrMMowBSXs3bCTbL4G5yqbVeWHNbcDJ0Zl7+ABPSNLYIGhzQGq3JRCE1pPawU6Y2p3PybnDp07UkeXe1VukNFl18fWlAVVhGPFSwIAoybBXUkDNVhtgRjj+10R6gbXuELucfTmPZC1DOuyITCeGuPNC4qOnE0up/ooht5NSeSdQfj6/UQTYUbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) by AM9PR04MB8810.eurprd04.prod.outlook.com (2603:10a6:20b:409::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 02:32:32 +0000 Received: from VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be]) by VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be%5]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 02:32:32 +0000 From: "Sherry Sun (OSS)" To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org Cc: imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, sherry.sun@nxp.com Subject: [PATCH V6 3/4] Bluetooth: btnxpuart: Add M.2 Bluetooth device support using pwrseq Date: Mon, 13 Jul 2026 10:34:34 +0800 Message-ID: <20260713023435.235765-4-sherry.sun@oss.nxp.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713023435.235765-1-sherry.sun@oss.nxp.com> References: <20260713023435.235765-1-sherry.sun@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR04CA0013.apcprd04.prod.outlook.com (2603:1096:4:197::6) To VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11276:EE_|AM9PR04MB8810:EE_ X-MS-Office365-Filtering-Correlation-Id: 1332d335-e61a-40a0-4c56-08dee086fd90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|23010399003|7416014|376014|6133799003|18002099003|22082099003|56012099006|11063799006|921020; X-Microsoft-Antispam-Message-Info: mjYgzIsiOafMIIpg29NnRmOfLKC7hRohiemxFUKTFRZrIK0PY8qwz4vhDcseG44mo+67S0bW6dMDxznkIUWBDaWnt/2nZFUdrrWbCI+qMfS/hsY8Jg7SBDKTRjktQ2KFmHsFpEsf+XlcFgqiDAD2hip0DKvq0jNK5B7TZMi8LIFtpTte8duOehjXBJzMQAAxOaPymXVhN81ukg4TOx/vl3WUg+Ts7gKoJ5qURcZ54pMVzNaRwTMZv8P4Qz/RrvMzHZW94bzFrXX8JxCexYYaqW9oHyMdSXBCrjiTJD+F3UlXc/vApaqaPa8/jmDHtuZvZitnBQyEj+F+Z+oxDjfvSlEivQacQq0pmIP7fCTMgXyhvE1zRzfzYgJsHus6+dCa0ufb6Yehl0dQdqrdzngstXU5mf24pxdjfySNndU5tArmrzkowW8g2aJL9oC6yByejN9iOd+jZPYZMSqRRWIMIltYLMNON+D3jduTDNzd1D5w3yPpqHpxjSreV464N8Mv5X3If3e6Iu9qCyj8z2g+dzRIjgoVa+EneOwe4ZbikgSkOkhnMQnQk3LdO95emkxFZVmQwg/klLMJihiRMoYE8LBelp6NBV2kn6TcaCT6ooUD+F6gsuRHtd4tkP75puD2MFLCatE9rOsmTJ+PVYbLo4rmBK1aQZAca8cv/c0jaH/ODW6Qyms/lfq+BGS8VvlUk64Cfu/A+B2BgNYPzUoyvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11276.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(23010399003)(7416014)(376014)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2PhXkrO6OqTK9cmy1Zp/J3SmdDYMD2JAa5yI/uyEfk4MTqrqnKrH5r4sTVgM?= =?us-ascii?Q?7Tj/7bcodKO40h6146NFTzFaRwma+R9oI16hU0mE2s8//Q+kzgSQA80Wubpe?= =?us-ascii?Q?KdVKXI3ZhePjnOT6MG0fsgQ7MayWxvLVDDCO+YFMUMPVk1/C4aFvDfIM87fy?= =?us-ascii?Q?87CVIxpAmGoLD6DhQeSOTe1jI+ak8MalttU1zYgimHnQXoXnQj/yzNTYu+Ma?= =?us-ascii?Q?Ab0XyU/51AL/0ChoqJtnh8m8gYbLvVCU9aKtrBlG8tS9o12LVkiyhMeDvG2w?= =?us-ascii?Q?sFQ5RhKeGaMV1r+UmmBJTKCynq0Zgi6Xm2259ex7KAkv0ontzC/KW5AAqPvo?= =?us-ascii?Q?oqqMZFfq3pFvaypPWyKObjeJrSRGCZnI4iLm3YY24wcQRCWOjDbY8gfuljb9?= =?us-ascii?Q?CL983IsvJpH16MV1KItwQm6tjsxftObpJw+dulvEg4yV2PRIKP1wr5pZwcoB?= =?us-ascii?Q?QuQRGqLUVNz0ee/V7n85M1pYrH9hvEnblrtqg+vX/8f7YUjWthPowcGxUXPy?= =?us-ascii?Q?AMxcWnxrdM1AxWsIREYyuBhmYksfg5SdsC7MA/2tlN/gTGVqFptIR7jH+j7s?= =?us-ascii?Q?R5Lwq9lZVz1bVOKnlOzuSW6q/PYAMjU26GzibJLJwjfVGPDCNe6OzMqPhlNW?= =?us-ascii?Q?vOeRQtMycPYo51BmgCI4ar8ov9obU7OAfgzBGn8gifA12fjmRMKX2YTmwjsM?= =?us-ascii?Q?35hx34+d7tygg5hYB0EFwufih3WBxHs+MNgRP8DCvEOPG/EZLt3C3MklspPn?= =?us-ascii?Q?kbyICZcCjuLdDM+0KU1JrGeTRpm+MsP1KuSTwp7xM7j2BDrXTr7pDwSm8r7Y?= =?us-ascii?Q?s2gdPS7jeoKFYBBx7sTlyxmbLWEzobVsQ1kGdzLg9BHWJRuj7BZ0lTtRejAT?= =?us-ascii?Q?iqFhEceUU0kQrZO4VyEFDf4LWlEWafUU/EeVXsKcNIm8Y3ruX7fXgRRptz9z?= =?us-ascii?Q?4OIbTnTo6ImABwpBOqUcj18ZxHn84KBE2coCRv+umpY9oho2Nft78oiTp/dT?= =?us-ascii?Q?sHQPuXQlEWd3xMlWxZyaYiXW0mbrs2UFdARCdmqo+HuYb/DJ17V+0jKKnLtR?= =?us-ascii?Q?R6D42qWIIheGlb5kGsQNavgfyLuPgjv0S6EcgfgJ+Zmh38a0G568OmjChBEs?= =?us-ascii?Q?mogzL2ce3DEfQeIyPm17hoClhTg4vY8juD9Y75cF+Uxr1imMFVw/aaxq7Lzh?= =?us-ascii?Q?sFgydgJfdzWxYgQNcobhmL1p7y4dZPsrUiXqRnuRKPiBC+siEhjHxllUuiAw?= =?us-ascii?Q?Kllv+zQtqGiK5E/h0oScM74wUbfyo34JgkhM/O3HhqTGGNWuvwDmu4lBw68C?= =?us-ascii?Q?GGBh/6d+nf7u9wB0Z+pf8kwSCty2Rjv6pRKb4Ygpid2OuaFUreY6tPyJ0IY7?= =?us-ascii?Q?mTcjZWYLo1vQd2cZVZSJEOuHAl7buRtlO9ARW6NyyU7rhh6uW/N8eiu4d/It?= =?us-ascii?Q?aHugIusMr+zois2/4ZqBXGwSscltdutq5l/M2rCpy+QjbTnWQVmgDnLUb+BC?= =?us-ascii?Q?bhc7Y8sq8tTw+UGCTj5Iu/FIt5/5KC9WxXOAnMDFDmneiC3WEQJsnsuTe5Cx?= =?us-ascii?Q?4Oi/CuzLNTSTBObVlLBOLCBx3bemvhlk/96rn20tupcPw4L1nMhRGoYsOMMZ?= =?us-ascii?Q?xhxfmLQdMrENM3XUYNl2CopCf9GP0Tu0R6SkjvRvzg8vNopTtlT7qdw1obW9?= =?us-ascii?Q?+KdzBXrDN5JxtWBHQmOp6ZlYFWO6PoIFXHpl0zE5uI7rY36etm0C1Ik591kG?= =?us-ascii?Q?FvNiX+B977Ida8JdFe8blSzYYDJEDpMQDlnFUUkq/8ou6ZNX1OS3?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1332d335-e61a-40a0-4c56-08dee086fd90 X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11276.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 02:32:32.0183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sRz1DzvVT8VyHngZ7pUKmIVVbWbB650vE+h2/zzY6INf2MHNEK83FphY4LX8loTO6dMLZDBlHkdSqGP15seSWy/VUWFpsj/CUQOIKDmq+ByNyewgoGCuUiWGsF290mfk X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8810 Content-Type: text/plain; charset="utf-8" From: Sherry Sun Power supply to the M.2 Bluetooth device attached to the host using M.2 connector is controlled using the 'uart' pwrseq device. So add support for getting the pwrseq device if the OF graph link is present. Once obtained, pwrseq_power_on() is called to power up the M.2 Bluetooth card. The power sequencer descriptor is obtained via pwrseq_get() with the UART controller device (serdev->ctrl->dev), since the OF graph link is defined on the UART controller node. Also add the explicit pwrseq_put() call in all exit paths, pwrseq_put() already calls pwrseq_power_off() internally, so no separate pwrseq_power_off() call is needed. Signed-off-by: Sherry Sun Reviewed-by: Bartosz Golaszewski Reviewed-by: Frank Li Reviewed-by: Manivannan Sadhasivam --- Hi Frank and Bartosz, this V6 patch using pwrseq_put() in all exit paths to fix the power sequencer reference leak issue during BT driver unload and reload as reported by sashiko. I'm keeping your Reviewed-by tag. I can remove it if you think it's inappropriate. --- drivers/bluetooth/btnxpuart.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 0bb300eef157..81a11ac05114 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -9,6 +9,8 @@ =20 #include #include +#include +#include #include #include #include @@ -211,6 +213,7 @@ struct btnxpuart_dev { =20 struct ps_data psdata; struct btnxpuart_data *nxp_data; + struct pwrseq_desc *pwrseq; struct reset_control *pdn; struct hci_uart hu; }; @@ -1872,11 +1875,26 @@ static int nxp_serdev_probe(struct serdev_device *s= erdev) return err; } =20 + if (of_graph_is_present(dev_of_node(&serdev->ctrl->dev))) { + struct pwrseq_desc *pwrseq; + + pwrseq =3D pwrseq_get(&serdev->ctrl->dev, "uart"); + if (IS_ERR(pwrseq)) + return dev_err_probe(&serdev->dev, PTR_ERR(pwrseq), + "failed to get pwrseq\n"); + + nxpdev->pwrseq =3D pwrseq; + err =3D pwrseq_power_on(pwrseq); + if (err) + goto err_pwrseq_put; + } + /* Initialize and register HCI device */ hdev =3D hci_alloc_dev(); if (!hdev) { dev_err(&serdev->dev, "Can't allocate HCI device\n"); - return -ENOMEM; + err =3D -ENOMEM; + goto err_pwrseq_put; } =20 reset_control_deassert(nxpdev->pdn); @@ -1907,13 +1925,16 @@ static int nxp_serdev_probe(struct serdev_device *s= erdev) if (bacmp(&ba, BDADDR_ANY)) hci_set_quirk(hdev, HCI_QUIRK_USE_BDADDR_PROPERTY); =20 - if (hci_register_dev(hdev) < 0) { + err =3D hci_register_dev(hdev); + if (err < 0) { dev_err(&serdev->dev, "Can't register HCI device\n"); goto probe_fail; } =20 - if (ps_setup(hdev)) + if (ps_setup(hdev)) { + err =3D -ENODEV; goto probe_fail_unregister; + } =20 hci_devcd_register(hdev, nxp_coredump, nxp_coredump_hdr, nxp_coredump_notify); @@ -1925,7 +1946,10 @@ static int nxp_serdev_probe(struct serdev_device *se= rdev) probe_fail: reset_control_assert(nxpdev->pdn); hci_free_dev(hdev); - return -ENODEV; +err_pwrseq_put: + if (nxpdev->pwrseq) + pwrseq_put(nxpdev->pwrseq); + return err; } =20 static void nxp_serdev_remove(struct serdev_device *serdev) @@ -1952,6 +1976,8 @@ static void nxp_serdev_remove(struct serdev_device *s= erdev) ps_cleanup(nxpdev); hci_unregister_dev(hdev); reset_control_assert(nxpdev->pdn); + if (nxpdev->pwrseq) + pwrseq_put(nxpdev->pwrseq); hci_free_dev(hdev); } =20 --=20 2.50.1 From nobody Sat Jul 25 22:32:29 2026 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013012.outbound.protection.outlook.com [52.101.83.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36D5A3264DD; Mon, 13 Jul 2026 02:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909973; cv=fail; b=n/l6WXdorERJpAXrZa/vNu9Werx52Yfiui+sZXTdM/buwFr24QwD6F3az1GlmCeDOoM8DNXJeF08JR9mhkG+hXzVqrxVFsmXyQ9iwBVhUwWKo30tQnnVf8SXsyr7YDy0vsI/xw7zeskHhYeWrc30A6p9dLM99vCWL6W0uc13svg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783909973; c=relaxed/simple; bh=gaVlYUmID78Qdg0bjv4Rny3c5Q9MZrWFZqAysR8gksY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Ip14GCjp98XSE70fK+zbikXCqMBHp3NeCKpJx/SDFq9Zx3qtmK4G0UhwgNeGe8qBw5GuFszuXBxXFtA6CrUDWFLbvz5EBPNKl0UmEohiYyN1/tNv6tGrPmLUUF+zYIo6QYJhaucfsXyhOUZOug6MGeqzrv+nL+8ozA/tyb8NnK0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=UPqofFh4; arc=fail smtp.client-ip=52.101.83.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="UPqofFh4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dH7Kc+8FOIIi6JKyAo76qGJL6LaM/y3LNqt8z2CyF5BbvBno9dSbWgaEaZXkIRUM54QeJFRfWqUfeX/4HOrX+XJvFeieaX6YuZP0Sh8IK4akQX8Bs4nvUtpxsXUtES7tVrQHTh8F895flGDHCR08zhwHV294A7oSBTIXDgeITY1djQ/TfsdW/rAvm4VRYQLUV5JUk0prbJt0njRGKXbW1Kus1Tfd/wCvXrZ0sqi0CcI1usiaBcZTWWDfGIOqb8FmuPZ7fRR+blGGX2Hi1Q3vTjIP1atXHTvbIU5siy4U3pVFun14n7CnmZu4Ja9W2jEjrwijyrcF8mj5R/JlSWvhwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cmSlTgbiYGe/2JPvw3yUOYyOATLeHJ0hM/0WUrpKlK4=; b=eLUoWbNmXwuuKR4VB3C9XRiTU8j6VsibohBqmMVp7lP+J0kjQVg+v5UWMbVg4eVaUmyGEliY5dy7ldpSoHtaPMkzfxhAIj+cEvHXStE9orP62cNSxTlKJXwILa4OcUHxig2/GzuIcEj2jeYzJ9iOdVM3a94IeF0wbB36FLASvHUj9Y+O4uf8JGIO1XTVrxhN58szuh172gyL+Nk3y5GXjN3AFO4rIg4VGF/1hspBdOkFcqa9GtWrm19fumc59hfXsVEFtEjmoEAY0HdBcF5iJlvN+zYu69lmucJvd0JOpfAKQRRzdidAM/U4YUlDA3zx/M+1f8PMSuU4JROuIIp7Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cmSlTgbiYGe/2JPvw3yUOYyOATLeHJ0hM/0WUrpKlK4=; b=UPqofFh4nY1Yphu6H8JvsftBklHCWStPAfRRSRNPrRwckGwPMYQMitNib2oUVJXbpnHfb5LUDQ5MJQ8J4np2gHQVkQtdBi33FCtaKEinWP7L9mY9d+TNxMmv8rlXikTH5Nq1zY2knWapFXoAK0CkzCGzWs8qJ875q6h/KStBQhIfMwfcRL7tR9MG88/Diqu6m0JI9pp9FGc0V8wD6HqdNsRh3vUjucgnUFqz4SCJ2w/sTC/JrYr6RvueiBft9wbL3hpMiZsez5hbgN2uvNLmhLELza4+dpixeULKJGUGM1bK3ZXziJ7ghOQPL0G5YvT5Eq6YPE3IAzPmfYqIFHYJfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) by DUZPR04MB9983.eurprd04.prod.outlook.com (2603:10a6:10:4d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Mon, 13 Jul 2026 02:32:40 +0000 Received: from VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be]) by VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be%5]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 02:32:40 +0000 From: "Sherry Sun (OSS)" To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org Cc: imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, sherry.sun@nxp.com Subject: [PATCH V6 4/4] arm64: dts: imx95-19x19-evk: Describe the PCIe M.2 Key E connector Date: Mon, 13 Jul 2026 10:34:35 +0800 Message-ID: <20260713023435.235765-5-sherry.sun@oss.nxp.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713023435.235765-1-sherry.sun@oss.nxp.com> References: <20260713023435.235765-1-sherry.sun@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::21) To VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11276:EE_|DUZPR04MB9983:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a579bd1-18d7-486b-b055-08dee08702a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|19092799006|7416014|1800799024|366016|22082099003|56012099006|11063799006|18002099003|921020; X-Microsoft-Antispam-Message-Info: 7aRg6Cs6XkoHDqBhjteKS/rK1XLB0w2FeAwMfQO+HG5qpF4IpTl7bu+Xd9KI86aozTNn+vax8UFIa72IH+z5Pjfb1rZlmt0jReJ+P5EujE11aMtTqDOS4vD1ulH7bbVpNmV904b7n8WldxyOr66mJeSgACa4T+y6mIbiO7GnBaT9DAeHKtoM3PzEXG5IaM0VXHy4YBCHAkAEIFF3I35b++z+7E5wrHQV/kGLplHPoytkr4CaFDf5FJVE9JJGExWbI7LOUu/if6060tlLUqtk9vRnoBWHTgUQ6xVYEL3sg81DzB5woYJAOdj5r7y8CVBmZtPqqXc+lX3M928RqM4jfDuZJCnD5Tkeyet1wH1qw9CzfMrGQ2eyEMfeVbxgs0jCFyxJku7N/oULe7JI2KSUNrHw+UhH3dZg81vAfuk/WrByHJhIQlqxbwKxbvpYH0zTYWPaGT9HcYmcHyUBMrlgM8u1ACP1vO2FSHqLUHpHGjHcRXLS9xOs7Uq54tgFwbxIMKENwlDaSXrrfl4MIFCElizLIuybm2rHPyBSmFw/A7Ns1WVteIv0c0VeafE8sOEpmktlCsePriHxn71lrnihGMbj8zJ6qnhN2uriuhXFeCjyPCYDiSKOIGJoonqB32P3KdvbiO6m3wvQuzvSLmeh/yIAXHe1RQ2MiINAy+fDWCnT23S07pOiRie3jlNZMd6Ec2z8zbGpSxDGjsAdUWFiCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11276.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(19092799006)(7416014)(1800799024)(366016)(22082099003)(56012099006)(11063799006)(18002099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6hGSMH4mI3szqgMSvlHtZQ/3gq7n85Mq34FbgInroLpMe3EmjAPVgu9ugO5p?= =?us-ascii?Q?2bCmtVxfdNpz4aU2mnQbE4MuRBbYJQ10PvWfe8maJ1pX8u0AGVhj7Y68Pv+W?= =?us-ascii?Q?vGDUry9yxpth/PWi4ykPfXLChWvDku/l6i9nnFCG0Fu9JUsF2ay2szbK2s81?= =?us-ascii?Q?WsOzAiAq25uABBvkI5MNWOZ/nCz4w9HTTLKty3XoPXfra/d9gna6vhTRsU88?= =?us-ascii?Q?et7ZHUJb/SX5nBzg4RQyF+hBwjIcPZ6b/+owziMILpK/VdKuZB/sjUWqEb7o?= =?us-ascii?Q?pzc1zxV5ZP8C/s/OQ0DQVkfZXqa6ZpfMqbeAkfOkzB7rGvY9VWgXfsemwAsL?= =?us-ascii?Q?AbOmAA95O9J9s5R/n+sswxVVU5+BJtHMmckUDX+Bs4WTgdu67zyb/gdTYNGs?= =?us-ascii?Q?aCWXxvH9vqnO5x0QxgnGvuLxhTGRhuFQBGkN33hNCASs1e3kfnJ7sjnNYkTp?= =?us-ascii?Q?hCSRCkx0AsSxr0JwqlznjwL3fmP4vbcA8ecbXD0QO/iUgiyAgvpXhjW0YpSh?= =?us-ascii?Q?FQKmFtwm1meyoLkDrtU45c5yitcEdUZ9xoeKLWjesa0KRjwJClFJk2hP9NLv?= =?us-ascii?Q?J3iRcjOKs+k0gLwoVLG/Ykwpsppz361yHggf6syNCDupzjbRmeaoFaQoarMi?= =?us-ascii?Q?LCld853tyInsO+l00VPS06wmB+WUw7S+dDbROL8RzHiTyIT4Oxuk4eY3FiKY?= =?us-ascii?Q?oGYo+eQHyqEB0tFydkg/086LpXqCbr7g3i3hy6a0rnJs500skiMaSROGe10k?= =?us-ascii?Q?M6iSw4seCuoRqug1cIS82/URbW39wBx/M9Vft6rJkESBRo2LBZPUP1gEBbjQ?= =?us-ascii?Q?MSfInArFU7Mr9LQ61JzcVsCvLco7CtzvfKz/KDOHLzK3kFLxZ82eM/Idy2o9?= =?us-ascii?Q?wLGt2bgVO3yYYbx5ED6LXq+zzUBuBGd56tlwanEIcx8DS4f+bKHCHZMMTMI2?= =?us-ascii?Q?cHdJTwIHKh2eIZKQm/9Gi9Zpul0wHJUlP+vMf+r5TNanklbznEpA1FVTTBWu?= =?us-ascii?Q?Bz8o8Sl30zuhEJefxKdbA7vaIq1rp5nUDnKZoi37bP63atBSsB1SeTFZ55Db?= =?us-ascii?Q?F6IDORKd2NAwbTMUfysLUh64euRvextZXxs0jIN2bUdwC5PWj7mvFsfKohJ1?= =?us-ascii?Q?ua/QoBQoPPVQlH8wobw7VKoIPXpJmDv58PTs1A4TtLx6Ndw6zuvUaX10R5vL?= =?us-ascii?Q?tsGsDw2KcQ9/7P/llXIHf33C/+adM+Rb2QEqJIKu3pIoEPOC7MgU+MdLiDNF?= =?us-ascii?Q?kl6NMU1Pfs/FqYy4u3c9MRsUcs3zMbpYUKRIedUr0Ht7lqZZuQ+b3GZ4HU7s?= =?us-ascii?Q?+MYKpUo0qef9NVI1Fi/7NiDpIKhCbJatGarnwugQhOAZRncTnlIAQddTnO9/?= =?us-ascii?Q?1a6C9ctzWSYK3NlLhGpxuGZC2RvF5ThQ3qVKuMiP3RDUX/GotlcbbAj/TtTr?= =?us-ascii?Q?DszoFF0Nc2eTGhNy1MJCyFYm+2TPa+38CBKUL0eWSe/fiJmmaG0mYRTpiplU?= =?us-ascii?Q?TVtwAUUsN3Bp+vPYKS9qnFcrjZ8HWXugrjnaiv8Bd3FDRxEqhnjLR7RjDBY2?= =?us-ascii?Q?DoURVMW4SscRG3i+GcZAdDNxNsuRaAdaIE+u5IBF48Zk5WaKqAow6ClyVs5v?= =?us-ascii?Q?u6APeILQk4auEoLdG3xYABIneKQzJJCtoj1nTetgfFue4QBDhDDRNJBUflkQ?= =?us-ascii?Q?OOxqsIL24vgWg5SdYoQEA21PF1PdHauAnlwUB7anPPgrYZIq0w7WRyD6DbCQ?= =?us-ascii?Q?ablzlef3WYlWkIl1hpNrupQOwnaYVw9MZuvQnaQN6kCqz3Krg2oT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a579bd1-18d7-486b-b055-08dee08702a3 X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11276.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 02:32:40.3814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Buzj9FagtqOm8oMRPMrPrOBVmwqhFBvlDjgWZYOXm6B6HQjW33Hbgd3E7j3AG38sGNniWA2QSqQMd7ecFBX+ra6juZMSiOvUw35siXLPbFObE5/QfIBjO0dicLSLzn6m X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9983 Content-Type: text/plain; charset="utf-8" From: Sherry Sun The i.MX95-19x19-EVK has the PCIe M.2 Mechanical Key E connector to connect wireless connectivity cards over PCIe and UART interfaces. Hence, describe the connector node and link it with the PCIe 0 Root Port and LPUART5 nodes through graph port/endpoint. Signed-off-by: Sherry Sun --- .../boot/dts/freescale/imx95-19x19-evk.dts | 55 ++++++++++++++----- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64= /boot/dts/freescale/imx95-19x19-evk.dts index 340ab0253ec2..1ed1a8282edc 100644 --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts @@ -57,6 +57,37 @@ memory@80000000 { reg =3D <0x0 0x80000000 0 0x80000000>; }; =20 + m2-connector { + compatible =3D "pcie-m2-e-connector"; + vpcie3v3-supply =3D <®_m2_pwr>; + w-disable1-gpios =3D <&i2c7_pcal6524 6 GPIO_ACTIVE_LOW>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + #address-cells =3D <1>; + #size-cells =3D <0>; + reg =3D <0>; + m2_e_pcie_ep: endpoint@0 { + reg =3D <0>; + remote-endpoint =3D <&pcie0_port0_ep>; + }; + }; + + port@3 { + #address-cells =3D <1>; + #size-cells =3D <0>; + reg =3D <3>; + m2_e_uart_ep: endpoint@0 { + reg =3D <0>; + remote-endpoint =3D <&lpuart5_ep>; + }; + }; + }; + }; + fan0: pwm-fan { compatible =3D "pwm-fan"; #cooling-cells =3D <2>; @@ -145,16 +176,6 @@ reg_m2_pwr: regulator-m2-pwr { startup-delay-us =3D <5000>; }; =20 - reg_pcie0: regulator-pcie { - compatible =3D "regulator-fixed"; - regulator-name =3D "PCIE_WLAN_EN"; - regulator-min-microvolt =3D <3300000>; - regulator-max-microvolt =3D <3300000>; - vin-supply =3D <®_m2_pwr>; - gpio =3D <&i2c7_pcal6524 6 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; - reg_slot_pwr: regulator-slot-pwr { compatible =3D "regulator-fixed"; regulator-name =3D "PCIe slot-power"; @@ -477,8 +498,10 @@ &lpuart5 { pinctrl-0 =3D <&pinctrl_uart5>; status =3D "okay"; =20 - bluetooth { - compatible =3D "nxp,88w8987-bt"; + port { + lpuart5_ep: endpoint { + remote-endpoint =3D <&m2_e_uart_ep>; + }; }; }; =20 @@ -555,8 +578,12 @@ &pcie0_ep { =20 &pcie0_port0 { reset-gpios =3D <&i2c7_pcal6524 5 GPIO_ACTIVE_LOW>; - vpcie3v3-supply =3D <®_pcie0>; - vpcie3v3aux-supply =3D <®_pcie0>; + + port { + pcie0_port0_ep: endpoint { + remote-endpoint =3D <&m2_e_pcie_ep>; + }; + }; }; =20 &pcie1 { --=20 2.50.1