From nobody Sat Jul 25 22:33:16 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25CC17080D for ; Mon, 13 Jul 2026 01:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783907333; cv=none; b=GA/XAL55f6JdrazeocbGoYlE5Eg5xdot4J4RebWWXaRW8kWWdrrl5jCCE9a029/pOeAkWS8BHvsfv96gqPNyb61ks4hOjuJ/BkSs2HYYe2Ce1dZ29emE+0qVC/390ZNt1cKLn/dGDhcv5q4d3ox01yyh57Vn5DunhTY7KeQXjD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783907333; c=relaxed/simple; bh=gHK84wzFP3ILiE1a7LUbZwFtn0pS2ONbTkslBJfArd0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=aC9/WiiqSDgjwqM8bHHudrW/BmsIEfCA41v81RwfIV947gR3R+hECGg/4+Svnx6dpTPNZnLKf7GDdwQBHa8xbDkS5mIe9FnSWJEmW/SfD7ktxKnO1X5d56O5mRwrOdNwIp5p+FeaF8HB+7xSrXxRygPxfZGdlnuesZtytShFRKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: f8964ae47e5c11f1aa26b74ffac11d73-20260713 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:37285a2a-020d-4cff-93fc-76cf3109648a,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:e7bac3a,CLOUDID:acd1ecc9a18f14a309e819678c549fcb,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|136|850|865|898,TC:nil,Content:0|15| 50,EDM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0 ,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: f8964ae47e5c11f1aa26b74ffac11d73-20260713 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1369605824; Mon, 13 Jul 2026 09:48:39 +0800 From: Hongling Zeng To: yannick.fertre@foss.st.com, raphael.gallais-pou@foss.st.com, philippe.cornu@foss.st.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, benjamin.gaignard@linaro.org, yannick.fertre@st.com Cc: dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zhongling0719@126.com, Hongling Zeng Subject: [PATCH] drm/stm/ltdc: Fix clock cleanup error handling Date: Mon, 13 Jul 2026 09:48:35 +0800 Message-Id: <20260713014835.23995-1-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When clk_prepare_enable() fails for bus_clk or lvds_clk, the previously prepared clocks are not cleaned up, leading to resource leaks. In ltdc_resume(): - If bus_clk preparation fails, pixel_clk remains prepared - If lvds_clk preparation fails, both pixel_clk and bus_clk remain prepared In ltdc_load(): - If bus_clk preparation fails, pixel_clk remains prepared Fix this by adding proper error handling to ensure all prepared clocks are disabled and unprepared when a subsequent clock preparation fails. Fixes: df61c776657f ("drm/stm: add sleep power management") Fixes: d80667642b0f ("drm/stm: ltdc: support new hardware version for STM32= MP25 SoC") Fixes: b7243862f82a ("drm/stm: ltdc: handle lvds pixel clock") Signed-off-by: Hongling Zeng --- drivers/gpu/drm/stm/ltdc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 95fcfa48d8be..ead9e87bd719 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -1907,16 +1907,25 @@ int ltdc_resume(struct drm_device *ddev) ret =3D clk_prepare_enable(ldev->bus_clk); if (ret) { drm_err(ddev, "failed to enable bus clock (%d)\n", ret); - return ret; + goto err_pixel; } } =20 if (ldev->lvds_clk) { ret =3D clk_prepare_enable(ldev->lvds_clk); - if (ret) + if (ret) { drm_err(ddev, "failed to prepare lvds clock\n"); + goto err_bus; + } } =20 + return 0; + +err_bus: + if (ldev->bus_clk) + clk_disable_unprepare(ldev->bus_clk); +err_pixel: + clk_disable_unprepare(ldev->pixel_clk); return ret; } =20 @@ -1962,7 +1971,7 @@ int ltdc_load(struct drm_device *ddev) ret =3D clk_prepare_enable(ldev->bus_clk); if (ret) { drm_err(ddev, "Unable to prepare bus clock\n"); - return ret; + goto err; } } =20 --=20 2.25.1