From nobody Sat Jul 25 20:10:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8FBB3812FE; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999718; cv=none; b=hOZuY9OYmIZBWIIjeC2COgFEe2HyP84yObiZ/62Y2FDTXZ1pWwf8dpX+HBtLwcjXlSo5j6mGUVd+u1gfSHTWdM+BqfSZRiLg2TxR+WJmwEHLCFvkX0l38okSWLHKcbh4+6CeY67JZwpI6XpIweWEOIvHJtA5kxwS6/N5pVpAPyw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999718; c=relaxed/simple; bh=PbOq557Ft8YIJ9bXL+Q3CTGy+D0w/GsR+9j5qySpM+4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Oy7JdeqKCmdSr0taumuIx4k8+jR4bVlk/9cVaVR/2g+S//3nRz9c3QVl76oR4WPF5yzMtA6hAJg9nNJU9QUu3CqcN62Uxxkz8jacE+dzdItrZUY878T3OWS1YybcGq7unPUdkJtXdUZFdN4F50xo1wPu4sDYdNXJDGqIpehOy9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vHh3+chi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vHh3+chi" Received: by smtp.kernel.org (Postfix) with ESMTPS id 63F2DC2BCF5; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783999718; bh=PbOq557Ft8YIJ9bXL+Q3CTGy+D0w/GsR+9j5qySpM+4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=vHh3+chiv/sBRNehBe6ZuPUWfoEST7kLght1ib+EOF7rTkekDrrzdwrYLhDdBsOBK tb3NGTULFc/BYo6hb3oPlxhByeh8AJepk24FBQ8aaBBfjDT6j3EtW58OJc3EnQ0mCG cO+ibNYJ7cRlw7F1EkKgZ1eEfbO5/WyWtsuC9QEcRXx771wc+35gp5CUzk/TXEePtE gGtptSEzkNc+/YAYKaJQyqen9hayATlJgKch3k8y9Vt8aFeDRlqm1bt2NZgU5JECs/ yu+x2cY1FbbHJJGytdzr6i87r8lBkil1frcdc+awL0eBTXopAAsja25zcezwima7f2 jDARUlzcq98Eg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42656C44508; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) From: Esteban Urrutia via B4 Relay Date: Mon, 13 Jul 2026 23:28:17 -0400 Subject: [PATCH v3 1/3] clk: qcom: dispcc-sm8450: Fix disp_cc_mdss_mdp_clk_src ops Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260713-sm8450-qol-dispcc-v3-1-56fd05822270@proton.me> References: <20260713-sm8450-qol-dispcc-v3-0-56fd05822270@proton.me> In-Reply-To: <20260713-sm8450-qol-dispcc-v3-0-56fd05822270@proton.me> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Dmitry Baryshkov , Jagadeesh Kona Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Esteban Urrutia , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783999716; l=965; i=esteuwu@proton.me; s=20260622; h=from:subject:message-id; bh=vJQi+hh68A/9zQqjnQhNDpQToorMCC98uuTiE+EDBpg=; b=69njIyVN6Bg2SvOWougSW0JtbBOvtf3urGyNAIUgO/GiYz3QE7Gjn7oPJftY574hrUhlFgpWq OM0+hhhZ52HC4qZ2Ez2AgHHHoRF7TOQrBd627rZTfAzrqWyk9lS8RFz X-Developer-Key: i=esteuwu@proton.me; a=ed25519; pk=wToFt4mOAWkzbqb15Ye1hrhevI13vK9BcMUFiQ/me1M= X-Endpoint-Received: by B4 Relay for esteuwu@proton.me/20260622 with auth_id=835 X-Original-From: Esteban Urrutia Reply-To: esteuwu@proton.me From: Esteban Urrutia If the clock frequency is changed at registration time, a flicker will be visible at boot. Switching to clk_rcg2_shared_no_init_park_ops fixes this. Fixes: 16fb89f92ec4 ("clk: qcom: Add support for Display Clock Controller o= n SM8450") Reviewed-by: Konrad Dybcio Signed-off-by: Esteban Urrutia --- drivers/clk/qcom/dispcc-sm8450.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/dispcc-sm8450.c b/drivers/clk/qcom/dispcc-sm8= 450.c index 3af120e54cdd..c7e04bd315d5 100644 --- a/drivers/clk/qcom/dispcc-sm8450.c +++ b/drivers/clk/qcom/dispcc-sm8450.c @@ -613,7 +613,7 @@ static struct clk_rcg2 disp_cc_mdss_mdp_clk_src =3D { .parent_data =3D disp_cc_parent_data_5, .num_parents =3D ARRAY_SIZE(disp_cc_parent_data_5), .flags =3D CLK_SET_RATE_PARENT, - .ops =3D &clk_rcg2_shared_ops, + .ops =3D &clk_rcg2_shared_no_init_park_ops, }, }; =20 --=20 2.55.0 From nobody Sat Jul 25 20:10:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8E7D18D636; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999718; cv=none; b=p/7rJYPjSxW6qHbqJWnC/IDfim1d2kQ/c6MuaWMfsES/3uWnvJ5zD1SIjNZUzA4nfED77ilDhXpgcnq4aYXRn7I44tqyPGfGf61DNAcb3S5VWsYl8LfG03UxlrtC3qLoY6vk5nCErbpDPp3qYE/hUkoSXJ6djggUIpb1+9S26KM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999718; c=relaxed/simple; bh=tuOyGc2HvqsLhhkEBIqIuJ5wQ1fqizUe9vaqx38ybbk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mgy1VKHl1nP7KvQu+LOSiJx1cCNnQmZ707lFE619OgyBRVlQ1OV2EtmAQPU2s7lpYLGYvCPaQQOhCWdotS7GjXCyvaxW3vstnpNIgxG9/ZXJSS8icVVhz+Ks8fEvQGVAQ2bgoakYwqSFtOt2keobKXrz/pyimeKyPCi3MunzI7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mqef01Uk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mqef01Uk" Received: by smtp.kernel.org (Postfix) with ESMTPS id 70055C2BCF7; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783999718; bh=tuOyGc2HvqsLhhkEBIqIuJ5wQ1fqizUe9vaqx38ybbk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mqef01UkobXMx7cBupSiuGbj2JnGgxFaxzbq+2sQN2AzWBcTgAe0UskH4u6fIoMND ie4C2JTsnDoQ2Y9SdgpmtaJkA1bWL+iFgd+mzOy5AmCc7kZ8J71fY5DzZiBFGlwk4c ik54x/midVfTpUe01FDhT3IXKFd7Q2AiveyMH5ei7qzsSFZJnbWNqWjpG8LTvr6Yya L6yRoj+sdb81QFu6S5fuuV6Jh3MvsmK4Mk9bJu/P0V3gdb9Y9EAp/+4Voe2TxW9pMR lBXkYjlWOCgpgegTRHzgSdeqcMxeJ7DbhxzvZTw3kdrqytkO0WXGbBK8xuTI4kRpgx MqScvwCa1FRIw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54408C44507; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) From: Esteban Urrutia via B4 Relay Date: Mon, 13 Jul 2026 23:28:18 -0400 Subject: [PATCH v3 2/3] clk: qcom: dispcc-sm8450: Migrate to qcom_cc_driver_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260713-sm8450-qol-dispcc-v3-2-56fd05822270@proton.me> References: <20260713-sm8450-qol-dispcc-v3-0-56fd05822270@proton.me> In-Reply-To: <20260713-sm8450-qol-dispcc-v3-0-56fd05822270@proton.me> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Dmitry Baryshkov , Jagadeesh Kona Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Esteban Urrutia , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783999716; l=2981; i=esteuwu@proton.me; s=20260622; h=from:subject:message-id; bh=Jbnp8p29U7ihTi5nzGMIrBxFlgzT7kH3/JhcN7BtyIQ=; b=fP44rtzAgx+pYQdrFCgjsq+g5In/H5GO93GUDY8+TCs1kWxhPt+TMwL+PeYzvO77jEhEIK7Oj R4ZGbcf7QKNDewMBceIhAYdqOkN+s4BSBYxICimdeSXj+da/4Pgc53q X-Developer-Key: i=esteuwu@proton.me; a=ed25519; pk=wToFt4mOAWkzbqb15Ye1hrhevI13vK9BcMUFiQ/me1M= X-Endpoint-Received: by B4 Relay for esteuwu@proton.me/20260622 with auth_id=835 X-Original-From: Esteban Urrutia Reply-To: esteuwu@proton.me From: Esteban Urrutia Migrate to qcom_cc_driver_data, which is used by other clock controller drivers. Reviewed-by: Konrad Dybcio Signed-off-by: Esteban Urrutia Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/dispcc-sm8450.c | 38 ++++++++++++++++++++++++++++--------= -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8450.c b/drivers/clk/qcom/dispcc-sm8= 450.c index c7e04bd315d5..facbf040ab9a 100644 --- a/drivers/clk/qcom/dispcc-sm8450.c +++ b/drivers/clk/qcom/dispcc-sm8450.c @@ -1778,6 +1778,29 @@ static const struct regmap_config disp_cc_sm8450_reg= map_config =3D { .fast_io =3D true, }; =20 +static struct clk_alpha_pll *disp_cc_sm8450_plls[] =3D { + &disp_cc_pll0, + &disp_cc_pll1, +}; + +static const u32 disp_cc_sm8450_critical_cbcrs[] =3D { + 0xe05c, /* DISP_CC_XO_CLK */ +}; + +static void disp_cc_sm8450_clk_regs_configure(struct device *dev, struct r= egmap *regmap) +{ + /* Enable clock gating for MDP clocks */ + regmap_set_bits(regmap, DISP_CC_MISC_CMD, BIT(4)); +} + +static const struct qcom_cc_driver_data disp_cc_sm8450_driver_data =3D { + .alpha_plls =3D disp_cc_sm8450_plls, + .num_alpha_plls =3D ARRAY_SIZE(disp_cc_sm8450_plls), + .clk_cbcrs =3D disp_cc_sm8450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8450_critical_cbcrs), + .clk_regs_configure =3D disp_cc_sm8450_clk_regs_configure, +}; + static const struct qcom_cc_desc disp_cc_sm8450_desc =3D { .config =3D &disp_cc_sm8450_regmap_config, .clks =3D disp_cc_sm8450_clocks, @@ -1786,6 +1809,7 @@ static const struct qcom_cc_desc disp_cc_sm8450_desc = =3D { .num_resets =3D ARRAY_SIZE(disp_cc_sm8450_resets), .gdscs =3D disp_cc_sm8450_gdscs, .num_gdscs =3D ARRAY_SIZE(disp_cc_sm8450_gdscs), + .driver_data =3D &disp_cc_sm8450_driver_data, }; =20 static const struct of_device_id disp_cc_sm8450_match_table[] =3D { @@ -1823,19 +1847,13 @@ static int disp_cc_sm8450_probe(struct platform_dev= ice *pdev) disp_cc_pll1.regs =3D clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_OLE]; disp_cc_pll1.clkr.hw.init =3D &sm8475_disp_cc_pll1_init; =20 - clk_lucid_ole_pll_configure(&disp_cc_pll0, regmap, &sm8475_disp_cc_pll0_= config); - clk_lucid_ole_pll_configure(&disp_cc_pll1, regmap, &sm8475_disp_cc_pll1_= config); + disp_cc_pll0.config =3D &sm8475_disp_cc_pll0_config; + disp_cc_pll1.config =3D &sm8475_disp_cc_pll1_config; } else { - clk_lucid_evo_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); - clk_lucid_evo_pll_configure(&disp_cc_pll1, regmap, &disp_cc_pll1_config); + disp_cc_pll0.config =3D &disp_cc_pll0_config; + disp_cc_pll1.config =3D &disp_cc_pll1_config; } =20 - /* Enable clock gating for MDP clocks */ - regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe05c); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8450_desc, regmap); if (ret) goto err_put_rpm; --=20 2.55.0 From nobody Sat Jul 25 20:10:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB97739F162; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999718; cv=none; b=uUwAaQTH5NoWUSH5cEumrPSTxU+O5zLxlyIkFeXsklqitQcKcclozYBw2J9qcHhX4pBprqL0D19AkseJ1+g44lPxAIANq3bCGGkKpvCM2/jxphAzm3SIEoX4eDPBfsUhZay6svJ5OEClhLJgDeKd82iehUfoyrD8DwhSRGyuDm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999718; c=relaxed/simple; bh=tQ+NiSln41kIEiTdEZzg096lDi2b4x36FAPAdGwm71A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NaSuYSeumRb932dFUMcV0z39Ausvi+2TpfdEMP2CPrWNSXCXMJpWhJ7aQVNkETh3uMCv2u5IN1nAiXZvrhBTnsroHymOVWn0d6TqzF+bHFtG0zzO0cK9L4Et1BCH1Hpdx1Rs7XrekG1zpctl46heXzRq1LDCdlrfijT7rYpQveQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p/ODHIJu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p/ODHIJu" Received: by smtp.kernel.org (Postfix) with ESMTPS id 81D58C2BCFB; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783999718; bh=tQ+NiSln41kIEiTdEZzg096lDi2b4x36FAPAdGwm71A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=p/ODHIJuW9lDcltRCdOxpyZtyidMFwf4a46OOI2eByC7CWVRMmyNok2H/EyzeIi/V VMbe/b4mrSmkmTQ5dioyj92HHHi/syV0cnzdOipDysyKjF24cLM5TMMXJaDdN2MY8g fh+/5Iq22YlMt+rvg6sojJFk820mvsjXYycvbif7b97BcZzmKKyqGvD+YyCMNrJE6o 7Pqkj0WbJ6b5S19LKs9rePnRYDM6TsjMP2oEvrkO5E6IbrknFA/T1rzrWp2N+0a5WA h2NTaopA7ixkmEK7SZNjqxOz1jmS4j3kcXHye9G4npJmScZ3/w8QIEHlXOJZ8GWlHW 3eyIiLyJeABJw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65566C43458; Tue, 14 Jul 2026 03:28:38 +0000 (UTC) From: Esteban Urrutia via B4 Relay Date: Mon, 13 Jul 2026 23:28:19 -0400 Subject: [PATCH v3 3/3] clk: qcom: alpha-pll: Check Lucid Ole PLL status before configuring Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260713-sm8450-qol-dispcc-v3-3-56fd05822270@proton.me> References: <20260713-sm8450-qol-dispcc-v3-0-56fd05822270@proton.me> In-Reply-To: <20260713-sm8450-qol-dispcc-v3-0-56fd05822270@proton.me> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Dmitry Baryshkov , Jagadeesh Kona Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Esteban Urrutia X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783999716; l=1223; i=esteuwu@proton.me; s=20260622; h=from:subject:message-id; bh=GhaCSfwi+m8HFFTiT0PN4OP31ZAcFq2cbK1k4hgXMNo=; b=1PrS4k9a3/d4gCxJxTpsPJ2dM9iDEe0p3/63VdlkKQKp5Dzm13w416iuD2rPKLOdP+eTtx8T1 VDP1KW19Bv4B1rW2BNv7g9EAmuueSsKUuRvsQtCATcNhuxWuHX0DrlR X-Developer-Key: i=esteuwu@proton.me; a=ed25519; pk=wToFt4mOAWkzbqb15Ye1hrhevI13vK9BcMUFiQ/me1M= X-Endpoint-Received: by B4 Relay for esteuwu@proton.me/20260622 with auth_id=835 X-Original-From: Esteban Urrutia Reply-To: esteuwu@proton.me From: Esteban Urrutia On some platforms such as SM8475, not doing this may result in graphical glitches when the mdss driver takes over. This fixes the aforementioned issue. Fixes: 3132a9a11e57 ("clk: qcom: clk-alpha-pll: Add support for lucid ole p= ll configure") Signed-off-by: Esteban Urrutia Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/clk-alpha-pll.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-= pll.c index f8313f9d0e30..60173b076cc5 100644 --- a/drivers/clk/qcom/clk-alpha-pll.c +++ b/drivers/clk/qcom/clk-alpha-pll.c @@ -2373,6 +2373,15 @@ void clk_lucid_ole_pll_configure(struct clk_alpha_pl= l *pll, struct regmap *regma { u32 lval =3D config->l; =20 + /* + * If the bootloader left the PLL enabled it's likely that there are + * RCGs that will lock up if we disable the PLL below. + */ + if (trion_pll_is_enabled(pll, regmap)) { + pr_debug("Lucid Ole PLL is already enabled, skipping configuration\n"); + return; + } + lval |=3D TRION_PLL_CAL_VAL << LUCID_EVO_PLL_CAL_L_VAL_SHIFT; lval |=3D TRION_PLL_CAL_VAL << LUCID_OLE_PLL_RINGOSC_CAL_L_VAL_SHIFT; clk_alpha_pll_write_config(regmap, PLL_L_VAL(pll), lval); --=20 2.55.0