From nobody Sat Jul 25 22:32:23 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A373B3BFA for ; Sun, 12 Jul 2026 20:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887906; cv=none; b=BsPk26ePIRqK+60aLd4r9fbSivWw6DuLjsOvsXJQj8ZazwDiBfyRwvRUjWzQ0/GvJZ0MGjBfkNXhxcGV/0S8fP0zR3u6+k6YKXz7XJdcvCcEwsfJawY8MpUQI4NeDzjqx7zDWDrP1Q1cH/j6Gqd3ApJ31Iq996n9LMEYpw17fPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887906; c=relaxed/simple; bh=9Uv79NmVh9eY/kXN536i2ek90M/WLPrQWFXW/X5gzzA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WlTD8Pp8sx7LxvEdzey1I+QgfBb1Q9ZKse3PDuQXkThjX/V1aWlJzJJRMcUlDD99EpXUnGN9vH1n3lhDHp0txw3s2tghqwGUNgmqyZeRg91B52soJTsLxymawfdR6qTT3FXyXpb+k+wp2q+mZ+HwZp1WKjIsaYiIkcAKXFf+aUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m2tCmRvG; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m2tCmRvG" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3825c406ffeso2346524a91.0 for ; Sun, 12 Jul 2026 13:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783887904; x=1784492704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t1Yo/I8ZgIt91EkcMTcsXR68fdAvToPUpH4oydF0Wx8=; b=m2tCmRvGNv/Vf1Ib3GElLmwymIZdr3ZbWWkPpT//p6H/jfHtRykzqq241ZKIWURP5m aqQEVe8nHVz0/GxwTYE9hMemgtvbzo4/YUCRNne9QG3kPihSu1WrZZJSC0rtfCarhliD +/b+hwu0Y5+DMG8bgWs/54obXYNQahmVD+/C9zJafH5Xw43ZM4Vit1784gdgtJjemdY3 jCM0jKwiODZr2W8jRWRegcjntnOSXVMa0FCiV4gDn+0f4/SCavqkOs03rgnHb0M1Jzod GKGZJb6/M9mC51BlqwRsJLzO+7FpTRq23D7jJhvmptmwxSFwlYEfIV6OQGzaA0Xcy+Sb mqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783887904; x=1784492704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=t1Yo/I8ZgIt91EkcMTcsXR68fdAvToPUpH4oydF0Wx8=; b=ZOJl8gKybHYxQuCiIr0dY3aXN0QkTJEkeIn14TNaofpx4XWIhzGV/+wT/x55QGKjau pSruLta1EX37fKf1mwo6neY9AAkRFyMpLlWHKXVddoMYrcGkSuiDEPKCtnWSOnQjlcXw wb6xRl1wGaGv07mcvNAyNBCaX4TfGlaLvn2I5ZlQc0BBLHuHIF4PUI2cEDyzTgFkc8pw 3vl+QXXjXA+7F+fQhfffi/McalVA2ga/DwE3xvKXCPCIhvatBwFQwfXeOIt50bWEDC2u oOyxb0meZXuuWncd5IQmTSX0n2gmx9MNd9+GssePznTY4CTjgmfvjRrNCpiRBTsV0ASR 8jTw== X-Forwarded-Encrypted: i=1; AHgh+Rp7RhYOwHzWj31ISu8lBekv7KlAoD1K+mtsrG+XABU7o7fW5JXzbG81VewOnuJdAOLTv/1qLbn4jB1qqMo=@vger.kernel.org X-Gm-Message-State: AOJu0YyH0S2ZyO+6D9Ji9i5WZrfeSxiF0MXsfKx4Umln1PHQ2oZgQfca ztkd7/7b8qm0bDI+nm5YsI42M2RHBiUQVav6Y0nEqYHHj41f22uHLBTvNkPhx4w= X-Gm-Gg: AfdE7ck0X2Id7sdZ9S2zK3z/5IfTK7Ni0EiBlDERocz0piceRrHYgxYYGsmlS3H6iid E9DZ9u96+BnPSESnjNUcwsV5TVwRhVGCEwyAhk9MsC2MUU1ahWi4+wXAQy6KeBMvugYoyRZ4Xk5 NJ4/7tBMrb2OPyjxIcA7CnAOLt+KF1hAkxjHtCcyI8o9dNpGq1bWqIA0Ft/ylWg/NC1S3Mgb4Qp HleknWK5BQ5Tv/BcIMYB2rSdPYo+/5jBedXThXaJqojPETzxeZCQMHEa3ZSRXQ6ftCoLrSFeMuI V0miYxYsdYUR6sywSJPvP19gjp2UCvrAbgJZoo8D0y9GtNfdJh62xyUEC3gUvsrWsy/ta3VH81q 7VA9n5LcjbzFSe9VXFGBlnJiIF0V00wZXPduPBc5ZJgGE/TH6K3Ua8x9viBgryhjhCr8Di7yE8d TbxzXk9KaHn8U9X5PLZqYcnlmbro80+U5Y72qQShV54+znrF9Xkjpy X-Received: by 2002:a17:90b:5687:b0:36a:8240:2477 with SMTP id 98e67ed59e1d1-38dc7608a0fmr6218318a91.19.1783887904009; Sun, 12 Jul 2026 13:25:04 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm58833648eec.4.2026.07.12.13.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 13:25:03 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 1/4] iio: light: opt4001: Fix read-modify-write of wrong register in power down Date: Mon, 13 Jul 2026 01:54:48 +0530 Message-Id: <20260712202451.20822-2-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260712202451.20822-1-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" opt4001_power_down() intends to clear the operating mode bits in the CTRL register but reads OPT4001_DEVICE_ID instead of OPT4001_CTRL. The device ID value with the mode bits masked out is then written to CTRL, corrupting the conversion time and fault count configuration. Read the CTRL register instead so only the operating mode bits are cleared and the rest of the configuration is preserved. Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index ba4eb82d9bc2..f2cf496cc243 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -228,7 +228,7 @@ static int opt4001_power_down(struct opt4001_chip *chip) int ret; unsigned int reg; =20 - ret =3D regmap_read(chip->regmap, OPT4001_DEVICE_ID, ®); + ret =3D regmap_read(chip->regmap, OPT4001_CTRL, ®); if (ret) { dev_err(dev, "Failed to read configuration\n"); return ret; --=20 2.39.5 From nobody Sat Jul 25 22:32:23 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91AED3B2FF7 for ; Sun, 12 Jul 2026 20:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887910; cv=none; b=tZqBbv2AvkXp7e3O567jIQIftqbOM8oI++NAV896mV+m9gna+k8sl+S5DXxXWj27tSSl5GtetNR7RItWziiVvDMhBcgf0hozaRqPIvTMWfpbGdhRNKsugrc0awhgMS2aRFIMHJwdtT0yxor/TjXhDZob6JJguKBi45Jk34QQ2f4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887910; c=relaxed/simple; bh=LA4IXDpuC9u0QiPddMFLuzDnH4o5N4TD7ifw2M6c/48=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VU+A2Fx+IDC4FzSBYr27gWZBZiW9il0lxPHC9ajy89tWf3qKZAlv1aY+Gxf/vIcTJLlxsYb6zDKLOjeCc5XSw5KXLrRZe4VUCsUH0y9mKezVGl+MqAEG+NC+kCEa2fUNfQt2X4X+f8/4awB0qz1JsAPcKC73jfTkeMQqkufI56w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z62h9GSX; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z62h9GSX" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-381ed661712so2953548a91.2 for ; Sun, 12 Jul 2026 13:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783887908; x=1784492708; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WE0EEtBOg65KudGIfJulYxabJqSO2+QxavCYGvUf9nw=; b=Z62h9GSXqXn/Tj+gXtiXQSJ4ul699TCa8uczCCB/11kwKrDZDaw1zESkBDoOqOws+h REZQBKvVIGwrhEHKwDCeQifezQbLuVpU3GRsPNv4f2cdUdqs+BBdKnDWBAnWSPVEQqfF Bo8EjocHAi0R55t3bjIcFTlMMwtuHH9NuqwKJiWw5SnIqcQu5UrPJq9EzVHMKcmNRn4J Cifh51iZvwJrpmjBwHDu8HRlgXisGSN08TALSleCgev7NO68YotzVLwqJJV0tEqiEfRC 91vzLg63Vf3rZm5Xm7ng9LZ4OcsN2DCny1/h0tu3ChZELXJsw+wVdQF/D0Uc89WeCwQ4 riSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783887908; x=1784492708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WE0EEtBOg65KudGIfJulYxabJqSO2+QxavCYGvUf9nw=; b=ADTifZW4yW/2GiKaA1oXpeHNWviwXvqHqzBeN/oudz/jSloPS+uwxuzyYgsipCc2x6 75n5QnymlixILowBWej4dskirqTK681mnCdqH9iaBmAdzx/jlZftzFRyTdbHvEx5cGi3 KxBljTJg5ap1XCfbsqrjRClk67lmRJqf3bFOSCmgU6mvD+4tX+IQwl4OJ/rbQzk5wETe mCtb6U14uQWiP02CczfqQRaYheeNzoDCvqjnvPMQqmKzEFgnUzq3SjxNQ68hxoZVgSjB tAS8Qax3D8KrAOq5t0u0fAoaN5b+0l4InGvmLPUIsBFNXcbfJi7CmTAF4rQSHhl1mk+o B3QA== X-Forwarded-Encrypted: i=1; AHgh+RoWiJTqZRCVBQe0Y2Re6BrYcLBBo/2tJRQILIdqAjND3wqE9pRnBHSea1RCsJGeh5wKdFIkyjdB5dRqpFE=@vger.kernel.org X-Gm-Message-State: AOJu0YzdOAcgHjJyD1jrcdk7dPRKebs6Kfg0KzxpF6+6LZyXn5n+MELu jsvZK0/auehGh2+Mp8Dk3hq5ogxnf+s5eGtThFj/WoCs0IYfPNbvZaA= X-Gm-Gg: AfdE7cla+z1iz18L/z0ZVRS8leQgWtlq8k1etYqy7mgFjESK9KSQIrUnHj7q+qvB1ee P9MpHFZ7HInevfMipMfylp3vxQb5UaLOcFzWYoX/JGdlZjhHlrSD3PsscgX7lFVuyqacEMqn0L7 tywYoGVCN25Si5/xbKKDMc1NJW65inzLYqZqxQXE7Z/D4ibO2bKRu3gy6nCHHclUOf8pcIX1wqG 9TLnqHxcAzbllNetOZUbf/XJr1CKBCBv2M81OWrFkBY4yCBpiCXqZw/JDFxN/DTT7Hpd6ar2UvJ clfuXmR2z/dl0M6QQrYk01lU/rbCh5LJL8N9OFU+Ve/2QyV+IdKHuJD9HeR3BjDZb9IUt8WViM6 1JM/a4pmoPqvvKxbqPwsCTtRUj9Xi06a09me2j/qimn1mfkAPX4brr+cWjSvyCPbX0tmvnKGnPg 7r2Qwwh+kOBCjbZ/ylMQc/e8/4CGUAWLIfb7E4MvsbM2xt/hZqewA4 X-Received: by 2002:a17:90b:5585:b0:387:e0bb:57f4 with SMTP id 98e67ed59e1d1-38dc779922amr6312878a91.37.1783887907835; Sun, 12 Jul 2026 13:25:07 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm58833648eec.4.2026.07.12.13.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 13:25:07 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 2/4] iio: light: opt4001: Fix incompatible pointer type passed to div_u64_rem() Date: Mon, 13 Jul 2026 01:54:49 +0530 Message-Id: <20260712202451.20822-3-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260712202451.20822-1-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" div_u64_rem() takes a u32 * for the remainder but is passed val2, which is an int *. Use a local u32 for the remainder and assign the result to *val2. Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index f2cf496cc243..bdb1eadbd450 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -173,6 +173,7 @@ static int opt4001_read_lux_value(struct iio_dev *indio= _dev, u8 crc; u8 calc_crc; u64 lux_raw; + u32 rem; int ret; =20 ret =3D regmap_read(chip->regmap, OPT4001_LIGHT1_MSB, &light1); @@ -199,8 +200,8 @@ static int opt4001_read_lux_value(struct iio_dev *indio= _dev, =20 lux_raw =3D lux_raw << exp; lux_raw =3D lux_raw * chip->chip_info->mul; - *val =3D div_u64_rem(lux_raw, chip->chip_info->div, val2); - *val2 =3D *val2 * 100; + *val =3D div_u64_rem(lux_raw, chip->chip_info->div, &rem); + *val2 =3D rem * 100; =20 return IIO_VAL_INT_PLUS_NANO; } --=20 2.39.5 From nobody Sat Jul 25 22:32:23 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4952A3B42C0 for ; Sun, 12 Jul 2026 20:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887913; cv=none; b=MGzCMW3eRDQeY7yuGI2XP3LW3nvR8KYr8TYoRl0anuPS65maHaGvKoJYAzf9k3XsEraQHSyo47LOb1gYyxTG+HB9QaOh4qTLgqSvPd4ewgszFTHFZMf8eJXYaSWedW5mmdZ5PN+q0TZHvm0UqubhYbZ1e+sHf46tIvV2iO8ZnDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887913; c=relaxed/simple; bh=Ie4QE5BtziviDMAyslSY0sDbsQrtqCcEe/nHREKcIUE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EqL1tDGx2MzYFsR553XOxf30teH5+m89Q+k7ASfy8jsjsAIvjS8tgLqX9PjXllABzrIpwJr+uf4jF4wYVt0CRgbJigJf5dPsYMo/W50ooI2rrA85IhwJf1dOi4WULoAz9Bo3R47ApRI/TNtWMtX/ESpHonXO8rK+PO7VzI9KwpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jvqUcCBw; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jvqUcCBw" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3811074a8c5so1829642a91.1 for ; Sun, 12 Jul 2026 13:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783887912; x=1784492712; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S0dLTgYy+mXCVxclK16Wz025jqN47A32NMw101nFP40=; b=jvqUcCBww8/rSFKWhw2zpe87tmyOX8QTX//EMGRjTg4vvwXgV9mIYQtoq4C8Bt8nH8 AblKWfigBWwRyu2IEpS3jOFyak0eakWzrcHZmKaduM7b03lO2ed8Q+qjhO0x+1Yyhvs0 Z39b5B/ek/ezUiX2T0hhZCuwZ5+IPWEtMTFWFUbRMMP8r8M2KeIxb5+2ODTau/vRXCKA uWRKqE8p74UiDjQBtMSxLq9j939bRhOxQleXFX70XOhZaQptfKnlE1UNeh9lsoqxFsCN 1y+cSkGBzBs+LaDLlYcD/c40Qef4boH5hqLxGg/8WNv8FLjTZVQi/w+t3AblhqDsiJY8 L8og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783887912; x=1784492712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S0dLTgYy+mXCVxclK16Wz025jqN47A32NMw101nFP40=; b=N2FSgEv5gbayqTplvun8vCq9Nonysa6z7pNlA9aNG8+3gh2StLotb4JSJuOOW45tIj fnhhe36kEY5zEEKGFusYAKturf53hbPlUTfh9h1pBjqmKXE3RsgnDertsvEAkGhjNGaU XniT/e85TQaXKB5Sm9M4nNTSwGLkIV4qNo+Ws8cBFdLxsHNuVv0y2QU7n9y59c0NzZ/h /337XFdlIyGOdE9Uzt+DU/a3B8I3Q3BNxro7Ucj585PZDpzE/0fKClcv461PI54pJgVQ 3NnLqzu7WjPAJoOZfeWqip+ZacKDognh2EJFEUeqpJBYELZd81AqbKzlcrbNARqrNZmQ yuqA== X-Forwarded-Encrypted: i=1; AHgh+Ro/yDoR9iHf6551AxLzHpj3eRnbgKROvijcaTEDT+IlKRzuF1/dV1SdNMNWZpJuVVZfUvnVZTkY7ujWiYI=@vger.kernel.org X-Gm-Message-State: AOJu0YyBxd12i4KO1qp0eI5obIoRGCSpbGSntmaSHiHIOID5KpjRQF3K HGNzMSkdcfzQSC+g1rGK/dBgNd0DjETGL7bpF0FaRkWGaiHGquUpKkA= X-Gm-Gg: AfdE7cnS7VYAfCgESb/ZlhrhevsegLnufeIRuArLu8Lrw9PSujKKGesy/ku3byqS284 bNOGfufzRYUgr9dpg0pmdV8IZlQpVXKUGamLT1YpnuNP21UmFMlKAAFCpsfYamMFvhLp5OVcI9m KqtWAgPDgvCpioLoHPdoH0gfMNJkdSMhSYN7hZeesNn4RgWbSrlYrctabkWSjyzpGMybkCi50Dm hrN2fJmDb/OgFQu13v2EU3KQFqLRJUc1Y73KMv4WZtzYnaNkz5PlTCuLHKZ5EBm0joCLWu/MIKf TB5W8IUmTQ8EutHExBMwQZO0+gcX+aKgx54Pj0+X32QXabvPs4tD3qp4FGZbmBu3eDNASq1CZ0R 0XWOhE5xfBaC2nqjpn+E4JzXbEufTGWKB/4DIgwxUCBgOw1+sQf1yeajNfjcSF7c8SDCtDxT/lu aHwCTI9+55TjkApnAbk6M9WWpgz/3RhF8b9GRyKMvFyhB5tvE/9vqu X-Received: by 2002:a17:90b:3c4e:b0:385:d033:d9f1 with SMTP id 98e67ed59e1d1-38dc7777d37mr6876741a91.28.1783887911546; Sun, 12 Jul 2026 13:25:11 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm58833648eec.4.2026.07.12.13.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 13:25:11 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 3/4] iio: light: opt4001: Reject integration times with a non-zero seconds part Date: Mon, 13 Jul 2026 01:54:50 +0530 Message-Id: <20260712202451.20822-4-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260712202451.20822-1-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" opt4001_write_raw() only looks at val2 when setting the integration time, so a write such as 1.000600 is silently accepted as 600 us. Return -EINVAL if val is non-zero. Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index bdb1eadbd450..31a5397926eb 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -288,6 +288,8 @@ static int opt4001_write_raw(struct iio_dev *indio_dev, =20 switch (mask) { case IIO_CHAN_INFO_INT_TIME: + if (val) + return -EINVAL; int_time =3D opt4001_als_time_to_index(val2); if (int_time < 0) return int_time; --=20 2.39.5 From nobody Sat Jul 25 22:32:24 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8EC3B42C2 for ; Sun, 12 Jul 2026 20:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887917; cv=none; b=BLcXzVUv/EVWvrMHVWa05SuU7DOMH7N9Xh79JWg6+0Q1RDuGgHAMvn8HEOW27/D1qvPno21TDNAyrsA5T8V4Ipe5SbTR70ACZapFGK+ASKjGIq7EPRJxbonHgYlvnoTdguLw9Vm2BYBakeLrcwipwfNqJR+E5lvBPcrmrVmdj1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783887917; c=relaxed/simple; bh=B9oykJbY1MY1CnaQH33h0JVuWS2mpWhoqz0M2Lji6Wo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=u48EMnjrBYF1dEIinUgDti6zIzyGwBrPHFN7X0U5/V+B91OqUJHLH+bnGqLCGOCg1d07wo4RShXij14Zx1t+tE5TfEexMMwEWncj5NNzuy2il6ECupVTnvRD89g43o4lZKkEUo1LSZnzZ2KrTHgUfpnNmb9/9RKQh6Fb4LKAjDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PG1HQp1K; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PG1HQp1K" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c9cf07d2df6so1618212a12.2 for ; Sun, 12 Jul 2026 13:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783887915; x=1784492715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MhB40GX9r2MWq3eX2ITmrKlJx8RApsn1rpbCSOUkYAw=; b=PG1HQp1KL1Q1uUGdrfBrWZwa9F6ufBeIJNHOZ8LksIZ3jDK7OXn9PDtdXCuI+nq5FS 8NCyQZc4E+oClHh5mvwt9WkJC/iPRuCXuqLNcSpfW1N6S58W0BB6GdABZZdSq/JHGhkS poLhaqpNB8ctzz4Gs1a7K36HaGkZbEfUqtxyr+Wjt74n+gOqftaphkuFpqXqHo8eDEpB pFGuk9lkOmgS9aditzlviav3VCr59ybCB9vkhfGMUIOlYZGCv8DvMH7s8NPrGqTYwfW/ VOS75YCvAUg2e5PriLsaCfJlqsvPELI1ONhOLbX9FQqtN/vaF2Spbe9+//cE7lJxeTgT OKAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783887915; x=1784492715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MhB40GX9r2MWq3eX2ITmrKlJx8RApsn1rpbCSOUkYAw=; b=f06+K8E0dwEPnWoLzOHiDULxUgiD59M5pbL7xonB58xQZmY2uuCHoysCq4VsSpImKb 7xejpcSUN6QbMUIDkOoC+DrssiMsDozQjZJ78qFTDKXW2Y+WAb7Dh4dm3zIyFZC8/GUx b2S3XELType4XasERJoErjb5EEXeN+sJBlBwUBx33CpMjFR5SMbPID8omUhm1C3PlMkC KQWcPATJgzt0RxYpk+YkcABIQDBhJnRofHuO29yi7txAA7NibPoz/RERYWPNmlFfpq27 oA3QEe50hYf/HvoHcHRBr3ti4CuaEDJ15FAu6KEB6fkxJdv1He49yvgvVDUGxpD7PXKT B0Yg== X-Forwarded-Encrypted: i=1; AHgh+RrzPdX39cpyXd7thEp/eYmquBadA16OcS3UuoAryIIIaqjzXtH3IyUzpYr14GFywuaPV3oV3Py4Nqw0ng0=@vger.kernel.org X-Gm-Message-State: AOJu0YxSTaUntH61iz34RsUopdli6LtY57XrTCOK1iF59BjYJiG0lUtD lLe/QtBNJo1/THmNgsu8Rzk+Ib02nlKyB9CIWxOmsCJkupPRlgkOHN1cRlJXZIk= X-Gm-Gg: AfdE7ckXwDWHBbApPRna16B/A5gX60gMf0lWzKihH7Z7CxwJAQ4RW4jamqS3+UwTmaq fGxYH1LRrMVyBPsPbP534F3ZtokyqZdUegnGMVAFehvPnahBU+AhgGbUwVovwIhN8+duETvzeOn 4rds59fqeL9VpI4n9GfbmfaJTYke5YEtrUMadHOOIyGz92EMHnR8pVq0nTkRUX32hYy67O3pM7b tTr+ffYTz47Bkh2knhQNkQFOeAdUGhbclvneKLLQ9St77hVwxJuNdXelGeBxsH/J+BGkeKMHbzG iyA+Z7C0cEwcuu2b6z0To23GltJPHPh/jigZRyJytaq7HKWeoQOiIUcdiKXgMc70A8XZyvTVv+p pzkWcepxWAg9kBIolGSDFyjYIhYoyhCwAQEm6xqKw4RT+CKP7pwqo2nGKi2ro0VJ7BPcE1hEI29 RbDlVGiZlWz9mL+pxgN94xlzHWRJpcrAta4UHM3G9nxbU+rWXmdT/d X-Received: by 2002:a05:6a20:c5a7:b0:3bc:5284:4859 with SMTP id adf61e73a8af0-3c1109e29d1mr6726693637.13.1783887915255; Sun, 12 Jul 2026 13:25:15 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm58833648eec.4.2026.07.12.13.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 13:25:14 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 4/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Date: Mon, 13 Jul 2026 01:54:51 +0530 Message-Id: <20260712202451.20822-5-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260712202451.20822-1-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(h, l) requires h >=3D l, but OPT4001_CTRL_FAULT_COUNT is defined as GENMASK(0, 1). The define is currently unused so there is no functional impact, but fix it before anyone builds on it, and add the _MASK suffix for consistency with the neighbouring definitions. Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index 31a5397926eb..294532bcbc50 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -39,7 +39,7 @@ #define OPT4001_CTRL_OPER_MODE_MASK GENMASK(5, 4) #define OPT4001_CTRL_LATCH_MASK GENMASK(3, 3) #define OPT4001_CTRL_INT_POL_MASK GENMASK(2, 2) -#define OPT4001_CTRL_FAULT_COUNT GENMASK(0, 1) +#define OPT4001_CTRL_FAULT_COUNT_MASK GENMASK(1, 0) =20 /* OPT4001 constants */ #define OPT4001_DEVICE_ID_VAL 0x121 --=20 2.39.5