From nobody Sat Jul 25 23:03:58 2026 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F0232BE7BE for ; Sat, 11 Jul 2026 15:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782361; cv=none; b=X5VBl+1pEZOTGQWdrisf4j5LoM7aiqOB1hjL4sCTbxx2pAaxLy9XZopCg8deUbpboKnDffPZForlYiPtOHQJ6/t31+QurKq1/64FOYrrx24kQT/QuT6wJoD0Eo/SwG4GIgroXg6VkdkZH23eupnlS1GOTkPc+V0P7nMrGlGXURI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782361; c=relaxed/simple; bh=k+E/AHBP+Zx+ARWbImRQV03XJYhigmgrMOmIGmqx1Hs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BsKwjNyv6k/jzN7kV15j+QwjKf+0FYxJFMmUQhAMwGJfaNthr6D48BLvx3nXRYnWwaEUHCz9mxKVQEqfb0s9eB6Up0FJ3p4F0xw/HS6s/0ZanaRknmzHsbf2ER+e260nDQhlhbGgeyX7vHiN5GaAf/ptDC+jssPWKDHFUKy2TYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yu2cwe9C; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yu2cwe9C" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-9030f8ea3b3so14479466d6.1 for ; Sat, 11 Jul 2026 08:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783782359; x=1784387159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EAx8OQB6mwEunipzmDLE3fqBbjdRzmKEhIwMzOXLjyg=; b=Yu2cwe9CgjNJcezcO2S9Wp5HtW7MDg72sEj4Fvk+AsL9oB97DPCJpfmq2URFboPnSZ VEA2bYF2qE9Nd5BIkLWYfJkvI5zVrkfG9mOCJeoSBeR2oYpQF4U/R3wnbEPVksDSMnZE yZ5IY4wr9KtDgZMTJpkd3h9zWBML/YyLAKc8dALb14kI/6ie4SJGcIgQdYW95atC3ZFS Qxd4RsGd6AubRgrYec8uJrnPjyraw9mG+eemTI0G/rvIXlh9MEZk4XQrJVg1VrZt09Ec rLj8NDwJtpm7OIvMMPEijdMRK273/sEkVdGnFBsCluS+TBOyDpCj/Q5PgZSnjDtMEQFr 1xCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782359; x=1784387159; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EAx8OQB6mwEunipzmDLE3fqBbjdRzmKEhIwMzOXLjyg=; b=l3DY5gsGO79O63ZFr09pAX7WM+ZCmxNLemeJ98iRUdwZHzxjeTgWWbUZY8S5c/3ahu LB2IntPg4iZvEuICeUx1LCqx2dyL/iuq4y8Ygchzq7aCU46ZeRsmt/PUswN2jSKEARpd qQi5JMb5i4EgGKdRZxK3A84JF8C4ZXdiqi140HSayU0hwSLz+sIyJZMnRgV5Aaza+2Bl 2tFoZuq09qb4efcBDJgbVHrhAVLodwsCIWK85juJsFqAeL9DG7DFBpq1L7fWXEy5aP7p BUyatMN7jhZF8Aqi742vwytny+ThPrP284AjFJQ/BYGnBWIWl8KMNAWvjjGTjWlPb41Y ZRGA== X-Forwarded-Encrypted: i=1; AHgh+Rq44LivZpWvzGYeHUoVYFjvMr/Y0YJGS4NMPFyNE8+nRh57qncTAxT5NPnug4Oe8jc8QxQDyDN7ulL+G/E=@vger.kernel.org X-Gm-Message-State: AOJu0YyxkFRaNVP2G5gK30tJXqtffaQFGfAZhox4WLmln4QNMTz5avI/ 29lU0/q+uKp2iVTtMdKeDxfdJN6z2a7Vh5HstU2usHUImsVVFV5Qtbp1 X-Gm-Gg: AfdE7cnzZ7j/zNpLBqw/lksuAuOEHdI9Ppw8XvyqdrdwMhg88uxD9km6hfJnPNEUdH4 XtBi/NDiey1OqT0+5Zd+c/QJaIH/ciWbkeLKYHo59UYwIgjnC9y1PWUti6AizZSXRgvwAi9lk6u q6voTaZoOHWdxv6H9fm8gTRxK0DUPogw/ZW35EsdxFiSQDAfZYujHA6UiKHPZH6N4Lf9CD0RVxn NI0fJrH4nB/EOkkU1UcUiH6I0kF6nrFaVuBmMgWiicJY8sl6h0HTiAjFT5HY12TXNE/2PJqe9UB lbo52DIoU4612KbSZPlg9BgF0hQEBJEF014uIblO6Ij+fctinZj9P0gb6elNGq/PqFeBLUXy2Z5 8JlnEs1tZjdcT3Qqtb6n9joKYLl8AORmGI1IDksZoB89cQvoVrGpRyR8VkDqHhErN2LmQXfcfzm pPYvGdHcA7N1mlwEHgmxhvNWDfHHxU1Jwv1l9MccWc/POOmjcQPh9GTk48EgcWsDkkVBmZmfFME DO4gFoeVg== X-Received: by 2002:a05:6214:509a:b0:8fd:6e22:c7ee with SMTP id 6a1803df08f44-90402e69077mr35450716d6.63.1783782358994; Sat, 11 Jul 2026 08:05:58 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd56c4b91sm68559686d6.19.2026.07.11.08.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 08:05:58 -0700 (PDT) From: Michael Bommarito To: Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] pnfs/blocklayout: reject zero chunk_size and volumes_count in GETDEVICEINFO Date: Sat, 11 Jul 2026 11:05:47 -0400 Message-ID: <20260711150547.2912006-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nfs4_block_decode_volume() in fs/nfs/blocklayout/dev.c decodes stripe parameters from GETDEVICEINFO XDR without checking for zero values. A malicious pNFS server returning chunk_size=3D0 causes a division-by- zero panic in bl_map_stripe() via div_u64(offset, dev->chunk_size). Separately, volumes_count=3D0 passes the existing upper-bound check and causes a second division-by-zero via div_u64_rem(chunk, dev->nr_children=3D0). Impact: a malicious or compromised pNFS blocklayout server can panic an affected Linux NFS client after the client mounts/uses the server and maps I/O through the poisoned blocklayout. An in-kernel parser/mapper KUnit reproducer is available privately. Reject both zero values at decode time with -EIO. Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing= ") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Michael Bommarito --- fs/nfs/blocklayout/dev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c index cc6327d97a91a..fc60669db3ec4 100644 --- a/fs/nfs/blocklayout/dev.c +++ b/fs/nfs/blocklayout/dev.c @@ -183,8 +183,11 @@ nfs4_block_decode_volume(struct xdr_stream *xdr, struc= t pnfs_block_volume *b) return -EIO; =20 p =3D xdr_decode_hyper(p, &b->stripe.chunk_size); + if (!b->stripe.chunk_size) + return -EIO; b->stripe.volumes_count =3D be32_to_cpup(p++); - if (b->stripe.volumes_count > PNFS_BLOCK_MAX_DEVICES) { + if (!b->stripe.volumes_count || + b->stripe.volumes_count > PNFS_BLOCK_MAX_DEVICES) { dprintk("Too many volumes: %d\n", b->stripe.volumes_count); return -EIO; } --=20 2.53.0