From nobody Sat Jul 25 23:41:46 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B60F31B824 for ; Sat, 11 Jul 2026 13:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783775035; cv=none; b=ZNHVIIjvKOjVFKc7lWon4uAgSe5n27wt9e3tF+6Uac2In9oJKjbN3WuGNnguXVUFW0q1VMF7Tl41IxgC7Y2RaUIL7Jp6Lsb939Mk47kG/FEtWI733ov0hRBV993BTiKONh7SfAaTtW+Er7SFwO2Lrsg1rBgq2Et7RGe4BUIb+I8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783775035; c=relaxed/simple; bh=OLzgpu1tZ9PtLVYftNagb8/uH/C3WWzEvjLtfdmx5iE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rhCING84593sMu56hehWGcZHXvpLqx5Phe/hw44n0UE9PTM9duktMhdkWOmYAYiS0V2oYYicNiIWw9vBTKZYY8QUBMCFE+UmRQ+94NELJzxsitURAyhMUeoTVFETwfQY+TRqovfcPWjOk0LFWQlxC7IEWNJxV06ieqXw7vp1zIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jHdpR0sG; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jHdpR0sG" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493e8d4f4dcso14655825e9.0 for ; Sat, 11 Jul 2026 06:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783775033; x=1784379833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l1tQiLCOsNZmwMbEn9d8godlFevlQ5fjRrw82uOwbdQ=; b=jHdpR0sG365ss98GVkA768/G+xiC68j8p0G3aSQB3UPIxg4wypbIdC5JjCf4R2vbtb pA2C1nHTFGBmj2GBlyYYqGWyLXNl6D//HvpHlqniIY8IyQgsfhZTSUVMEwQsQiAK/UV0 5hfvaYNQBowLfKO4YYRvnSnuQ+oEmT27l7nly0A5Ul9aB6YaiBGIqpPTU1IR5uCzUTPW O2R2vIhBt89B3JPAMdVTZxbbRO16ZXKqdZ9MDPjIMl7Yva7pUioJNIKcgfDpvsY7Plo0 qAJaTkhq6vapInENyRqxId/2+NQaEZ4dM6QdIKUJlMIhUl58bJe8jlY4wPAoqbG2bhHH 8+1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783775033; x=1784379833; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l1tQiLCOsNZmwMbEn9d8godlFevlQ5fjRrw82uOwbdQ=; b=LBfZkge/srjlH86ffAqWaTNoWeOWgPTDIMPJSJHpeJh7iXWy6Wd/JJv2wCiobF0rNl fK5jljKL9LhZLSyg9ZbGYEl/0ztfw5LxFUaSDnq+i3/UgGhAFIFQxCSuJAyVBhPI+jcZ wHI1lGuPqEn0NlChu1jwN7fCUFOttL0/Y5AbkwO9I1b1bPy+cs6MTaJDOeBJbzO7hwEB FVlXfGaw6qXKS2MGXwIRM7W4pzw8FNjbVnXtdvJewB/5UN2Q8Y4BeJwbD+sQGgflQa1g qiMm6lPC8D0iPcPuMN1xTQ9q3v9o6Xn/IrvpSChMnbCHFcItnqj/hTcaivQTTesRnm/u C6nA== X-Forwarded-Encrypted: i=1; AHgh+RpzrQMsaQT8GbocSCf+IbrF6IwNln9jS4HXSOaYClZXZlNkPRkoB2nikAl/atY1bJAUl0EsREQtUl6qRf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxhf8XbQGPYyGcquX4Y1gTyk+8BTCEnoXFOVr/2TuDMKqSyt+Tp l6SmZ/9ygrEvXqklMzfYCb8ASOsHJrjEJmd1/6FSRvSlDvN1iJ2rhXmo X-Gm-Gg: AfdE7ckc8pLNHVWjIi5nmeCRFY0g0iXWrOf95jR1FfxnmduGFvYe8vkxICWt61uAxUg 2c6YohO5iJEt51io8JHvIOdaThsrmApS/PPxZ34wBG4rm043QEqUR6R8Cv47gKCRpLC5vPCKJj6 Nv4jLTokzrAXPURBFMNfGvkLNc2rlmqhVvybAHRBFqxMpv3S2CmMKcbLTNIx/9GcfSOK+7tqyp1 60DteG5r3zMzqi7RAIMInE78r/02W+PJDoOGspfG4cOaOVHIjEdEAAdkk8YntZlFJPsDQkfvDq4 2yPH4wGZ9+z7bR6Xar75G7dfyGUELFH5E1VzmANuL2VdIOCDEyGZcmMzK9dE9RREAbWNHrUBr5x +3/uratZXcIjlnGbdfeYA+Vzuyus214YzFj9xUri8qKa9IQyvpm/EHZzNyxKnloQtID6auflx8k 3o7JqYS26raiBbpD72ZtXqRTlGOAun9SaLPA/ms05m8yi0m3YGnXlrYz4nEOHoMNURbADxvDXQp iPjS0vKkIPzMBw= X-Received: by 2002:a05:600c:6592:b0:493:bc4a:fb55 with SMTP id 5b1f17b1804b1-493f883d859mr23928025e9.38.1783775032510; Sat, 11 Jul 2026 06:03:52 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6ccaf1sm375141585e9.2.2026.07.11.06.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 06:03:51 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: b-liu@ti.com, gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE Date: Sat, 11 Jul 2026 14:03:49 +0100 Message-ID: <20260711130349.592545-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'select' does not work on config options in a 'choice', so currently it is possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE. Replace 'select' with 'depends on'. This dead select was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha --- drivers/usb/musb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index f56929267eaa..f8ff2366f59f 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -116,7 +116,7 @@ config USB_MUSB_POLARFIRE_SOC tristate "Microchip PolarFire SoC platforms" depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST depends on NOP_USB_XCEIV - select USB_MUSB_DUAL_ROLE + depends on USB_MUSB_DUAL_ROLE help Say Y here to enable support for USB on Microchip's PolarFire SoC. =20 --=20 2.54.0