From nobody Sat Jul 25 23:41:45 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B4435AC1C for ; Sat, 11 Jul 2026 07:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783755019; cv=none; b=khaE9YhlLoC1dNKaYxpvjiltZS8GnNph3vu+XWxlVbjqtrepAgOqfim2ZvA/U6Wf8FDlKxKnhQ+UkG30nEd/mH4oQFWGkWYrCqDc/tC5RDOVx8rnxAVgW4L3zuPwhmc2nWEXPTOPLIXujxHlXX9OzLr3xm+l5W3CxfGVvZ6lN3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783755019; c=relaxed/simple; bh=GXjcU39QWcSzGAd3hgO5Q4UtPpQ/TQXwXEGgMc1w11M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kf39JsXjIDNtMbMmm+Rq2OqoTlYPZbx1KqavyaXrubducf/zw+TcKfCu0qBG1TxN+P34etbDyY5YZlsvKWoeH1BTu1dTBeuKSe5vTzEsyTbHxssNLohWe0wlHEf+GVstozNcQkcNf3R3zODUje8CmZipQQDC5j8JR27bHoRx90M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=wuOoxcAl; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="wuOoxcAl" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47c2b362ee2so1500150f8f.1 for ; Sat, 11 Jul 2026 00:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783755015; x=1784359815; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0XIBIITeNYjqyCVK5ZSVvlqGN7ycrHDwBqsn43mkLj4=; b=wuOoxcAl09quC24LTzY/PtdNcxDi7SW9yHX4Wn0HBtpyiU0mz9wVhLqpEADZfVioY+ 2dgUiGXm5uqoXJnUEo5MQ1/2Il9u9u3jBlPWFr4fpWFi1rCr4P4NOw2LX3RUJ8F7LPAl vDoqDAUBkDhsL0I7hE/ksXkqIUYEapd/MsRmvhye62g10SZ/MfqYIppkf7LccfiF1DRL eq02kvOa0Ta6wu4V8wjYmevZ8Zryi5uUx7KJkStyytCXAkujUTb38/FxVtwVkY77fY/d 8fYk1Wo9yM+02xnV9EIAexhtA98jg3k8dDbf/Vch5WDgdQkwJRdy6I22UTEYRgbtmRB0 RCyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783755015; x=1784359815; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0XIBIITeNYjqyCVK5ZSVvlqGN7ycrHDwBqsn43mkLj4=; b=OGNy3II82SiLQ+pYBMgSHKLnPDC9N0LsDgXsivthoXg3FBvAqqzeK4yX5HHlaP79Kc o9RpCfyhvxCCMyqeQINepLxSBs8OOdtTeFLxb3UmUVxo/wA69Nv1v87Q/VH2Ez0ZV7Oi D2OW+gTyXzQ//zLx2fcqqolnfP6WsLis/M1GF/O6smGjm+pOk/eYxlkHk2ZdS+ZSXqrP u7dXb1WhPpF3u2ljd/Cq/h8zmfHcVdPYkzB/afeS7rYiYajGFrFZLUCekdzksoFjM5Wa Fra5TbDXFdGB4w9ncNbTwVzXvRwolKHlGXzDOtsaHArGj0S6lDEIGMHbgM036KdHrawr 5tzg== X-Forwarded-Encrypted: i=1; AHgh+RojbpAIbPBEpUmGigYk7SrE5gEsp1E5wayD4ncJmgQyQ1nc64e8hnZ2PGKg5yPIe9tv2jq+RK0kxWmYPwY=@vger.kernel.org X-Gm-Message-State: AOJu0YxNNDf7EupQQNQb4Wqp1PQFy1e/oT9DtTdCVCmrxZ6AZju+hc2F LqWHzDzmkoUSSO7GYRf9lR85IVWK1xJ3yNO/lgIMk9W9t+/g/MJFzBfMbr5zIio1aN0Z X-Gm-Gg: AfdE7clrQ80JvxrhRgLsCJ3GH90KYtCfnZ2skf55r2h2k/y5wJYfceJn0YpBaldsCjq EHwqp9Q/lbBYCS2OSr7/2ZQiwcxatrWPaW4o9mF4gkDcGI4P37uGO3B1RfVNx81QVHeBhbsIEWf 5iAsl26b0Ca4cuoq4I2QNSHiRbbiyB/lUwMyjMb0rbMggT94x0vJPMBAbBKHD85+0LOsyLgrIs0 q3cjYfENKMIbIvr4etx+rlgsAE0MArjqfdFdlCW4uGFpsaMqgTGKI8+LZIjUZo2az9juh2OOKR3 t/E+1i4e/YFhFACcbyPN6Izxi7zVSyLHL9ZIfns21DQYdeiQZn+2jxv1i2W0KkdEiYz2vLUU8TI p/0TFotCmhxAWgS/iJoYCrybAwy+OTkqQdNqjQhGLkEqJjhuQLpxLxJf7imERylSB2myZa31lgr 2OJPVY3utkNJ43NyjZcO1kRDkgRrmivMSmINArJM43Kwbt0z8N4Y6i4RQE0KrzwxzDeDRCtXRFw zCN/lxo2Lyr28Yi/kpohdq9ZgvyTt9QKWQ= X-Received: by 2002:a05:6000:1885:b0:474:13ac:a91b with SMTP id ffacd0b85a97d-47f2dce7c33mr1900118f8f.32.1783755014528; Sat, 11 Jul 2026 00:30:14 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ad69519c2sm71148700f8f.37.2026.07.11.00.30.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 11 Jul 2026 00:30:14 -0700 (PDT) From: Doruk Tan Ozturk To: david@ixit.cz, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: horms@kernel.org, oe-linux-nfc@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Doruk Tan Ozturk Subject: [PATCH net] nfc: llcp: guard against short PDUs in nfc_llcp_rx_skb() Date: Sat, 11 Jul 2026 09:30:12 +0200 Message-ID: <20260711073012.71066-1-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nfc_llcp_recv_connect() and nfc_llcp_recv_cc() pass skb->len - LLCP_HEADER_SIZE to nfc_llcp_parse_connection_tlv() as a size_t. When skb->len < LLCP_HEADER_SIZE the subtraction wraps around to a huge value and the TLV walk runs past the skb. nfc_llcp_rx_skb() applied no minimum-length check before dispatching, so a PDU shorter than the 2-byte LLCP header reached these call sites. Drop such PDUs up front; every LLCP PDU carries the header, so no valid frame is shorter (a SYMM PDU is exactly LLCP_HEADER_SIZE bytes). Found by 0sec (https://0sec.ai) using automated source analysis. Fixes: d646960f7986 ("NFC: Initial LLCP support") Cc: stable@vger.kernel.org Assisted-by: 0sec:claude-opus-4-8 Signed-off-by: Doruk Tan Ozturk --- net/nfc/llcp_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c index aed5fe1afef0..e3b3077e0e83 100644 --- a/net/nfc/llcp_core.c +++ b/net/nfc/llcp_core.c @@ -1481,6 +1481,9 @@ static void nfc_llcp_rx_skb(struct nfc_llcp_local *lo= cal, struct sk_buff *skb) { u8 dsap, ssap, ptype; =20 + if (skb->len < LLCP_HEADER_SIZE) + return; + ptype =3D nfc_llcp_ptype(skb); dsap =3D nfc_llcp_dsap(skb); ssap =3D nfc_llcp_ssap(skb); --=20 2.43.0