From nobody Sat Jul 25 23:06:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F08C27A476; Sun, 12 Jul 2026 03:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783826005; cv=none; b=phWZvM7q6n6XNaR1H/sv29hW8fJ7P8YBXLWH5l5JCo8QFEnmLMIlKEXTwJoQvM8DZLJVm3goXYqKSN9GWLjW2WpdlgXClTvglUSxW4GP+h9m6JAUWxZZoXR5j9OKuxSLTTg4e5v18JFHz8kBS5DSGiA8CR5zI2bjLyuGuksS/34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783826005; c=relaxed/simple; bh=DKPMlvVzmwc1lG5celyEdrQ0cGNAS6Srx+f2rta+Lic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dSp/XZ0Pcb5Y2YR3hH4E+TUWs3Y/2648IJ2YMJoMgrRHEzOdfy0/Ec4UdXPfl0ngeD2okKBxzah/2HQ+5Ue4YwuenPzjdX2BBh7oDSX0jlC2fkChn3fx8sgzLG973WMFC5GkmnklAklxo57vk+h8YqcdA3Tzzx2KZYSAatS+uq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nYX0lFSd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nYX0lFSd" Received: by smtp.kernel.org (Postfix) with ESMTPS id 44D10C2BCC9; Sun, 12 Jul 2026 03:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783826004; bh=DKPMlvVzmwc1lG5celyEdrQ0cGNAS6Srx+f2rta+Lic=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=nYX0lFSd+ZhEPeU0iTdOcIJPFOwpwYcX9iaZMJSsydM56629yjn/I+bMiJVXZCTJh Lk/u6F2Qu+cC1j+NUeR9/q3R67Do0E3FUBdP2u6QZ6iBZOvTXlOpRjWPzVduTcqPK3 XQQVJAdOpUL7CX+TQA7Hdnlo7Xgka1ufhc1NEZrowudhgT7TZ5wunabqS9X12bQG3m Cd/ftCSB+VXOu2zRp1lCR0Hr0LPJyG5hlaRCFLOjocG8K3AEVQYvpJuqdkTATDZGoU j8mhmH8c6BzGKWJviKQDMsZC1s3OdawSQa5aqop1O2XZ8Hmnyki+u0xyG0FC8/cuwu sSMHkiPFKLTcA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337EFC44506; Sun, 12 Jul 2026 03:13:24 +0000 (UTC) From: Esteban Urrutia via B4 Relay Date: Sat, 11 Jul 2026 23:13:17 -0400 Subject: [PATCH v2 1/2] phy: qcom: qmp-combo: Correct pre-emphasis table for QMP v4 DP PHYs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260711-sm8450-qol-qmp-v2-1-d14353bd6ff4@proton.me> References: <20260711-sm8450-qol-qmp-v2-0-d14353bd6ff4@proton.me> In-Reply-To: <20260711-sm8450-qol-qmp-v2-0-d14353bd6ff4@proton.me> To: Vinod Koul , Neil Armstrong , Dmitry Baryshkov , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Esteban Urrutia X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783826003; l=858; i=esteuwu@proton.me; s=20260622; h=from:subject:message-id; bh=ttOwHTqD5JdqKOp7yycqD22zqZB91giULaJsKWEhUOg=; b=okopUU6ct22uAyQBjs0owdIiioEOIrEhqKrIr1KVHvVpz0useNbiGQNX9x27TuH89XfR2pG23 7yPnCez5FIoC1ydOEbM1E4q+5j5y1JMdAdgi2kpqYLbN9h009Wa+rBM X-Developer-Key: i=esteuwu@proton.me; a=ed25519; pk=wToFt4mOAWkzbqb15Ye1hrhevI13vK9BcMUFiQ/me1M= X-Endpoint-Received: by B4 Relay for esteuwu@proton.me/20260622 with auth_id=835 X-Original-From: Esteban Urrutia Reply-To: esteuwu@proton.me From: Esteban Urrutia Comparing sm8350 and sm8450 tables, this seems to be a typo. Fixes: ef14aff107bd ("phy: qcom: com-qmp-combo: add SM8350 & SM8450 support= ") Signed-off-by: Esteban Urrutia --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualco= mm/phy-qcom-qmp-combo.c index cdcfad2e86b1..a72c3b9654ec 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2108,7 +2108,7 @@ static const u8 qmp_dp_v4_pre_emphasis_hbr3_hbr2[4][4= ] =3D { static const u8 qmp_dp_v4_pre_emphasis_hbr_rbr[4][4] =3D { { 0x00, 0x0d, 0x14, 0x1a }, { 0x00, 0x0e, 0x15, 0xff }, - { 0x00, 0x0d, 0xff, 0xff }, + { 0x00, 0x0e, 0xff, 0xff }, { 0x03, 0xff, 0xff, 0xff } }; =20 --=20 2.55.0 From nobody Sat Jul 25 23:06:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA14367B88; Sun, 12 Jul 2026 03:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783826005; cv=none; b=ee+0KKYlSCN5R1K+dnE+iG7X1RlhAbRWMRqTKXrNg8IZ2RYiEvYJXrV3dZP8Z9XcXq6vID+3Dwjx2nXRYIgT6KRXzHkuKJNG1D1kszU/SMShLaSi0LPKGBTLp3g8fHqKRgjmxTjwiEAW2J79BqPWBFty69ZAjmG3KozlRBAzRoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783826005; c=relaxed/simple; bh=x5KI9xBhGsLY1nX16Hu0YrPAjW4HJNwJ8zZ+sAlguvg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aLkPhTnz0zbvvV5U6rH2oo9DjJNagIQTA0VMk1aQ48z2VT4uMOWuPm0SIrDVd5WCZZ5d13yYxvmdpqdxtjW7wjbLvl0QmP+8fXIB8KUnovBh7XP3fvGBZXRV2N9XchyVbF6eEx+0wkeBMRjQLeSBb1zYU5pDlY+toQ1WY/iKDeA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MqWH2a9M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MqWH2a9M" Received: by smtp.kernel.org (Postfix) with ESMTPS id 517C3C2BCF6; Sun, 12 Jul 2026 03:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783826004; bh=x5KI9xBhGsLY1nX16Hu0YrPAjW4HJNwJ8zZ+sAlguvg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=MqWH2a9MSxgnwMeZQpOQ8PwEb2BfmeTDU5GECOK/5JRHPYDPR2E5pS7MiauviAK8j 3b7wsP2lHBu9ypTo6bPNCfVnQMjNZO3r/5uU93iIyd6Dx0cyDGuh4Wet9VOOe6td7/ M8olpEtaluJtGFbpYjrZF0WKJ/ynO+fxVrf1uKVV/WXfYOgk5x+sJN8XmXJPaIdQA1 BzZsZKm5pNKhZlCb93M7HZkLIGL9x4WLcyI9HxmZ5Q3tIuLXWKTiTjvXcQO2pAnEKd RisRjIusi0pkWLMytKiJ5z9v8eTw2RF5xk5YWEniiO7y4/679orpgZ/D1Z3S1GqFdo 6tCQV0AWAPZJg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F42C43458; Sun, 12 Jul 2026 03:13:24 +0000 (UTC) From: Esteban Urrutia via B4 Relay Date: Sat, 11 Jul 2026 23:13:18 -0400 Subject: [PATCH v2 2/2] phy: qcom: qmp-combo: Drop qmp_v4_calibrate_dp_phy Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260711-sm8450-qol-qmp-v2-2-d14353bd6ff4@proton.me> References: <20260711-sm8450-qol-qmp-v2-0-d14353bd6ff4@proton.me> In-Reply-To: <20260711-sm8450-qol-qmp-v2-0-d14353bd6ff4@proton.me> To: Vinod Koul , Neil Armstrong , Dmitry Baryshkov , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Esteban Urrutia , Dmitry Baryshkov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783826003; l=6562; i=esteuwu@proton.me; s=20260622; h=from:subject:message-id; bh=wKUTfzWF98obGb2By7Mg953jLV5lY7NFjqUaUlrnhQw=; b=w65Y1pej68eXgxcGQQOjjV3You6L0nVEpgbFFDmb4oj154c9Pe/xZEZsvhPQD7DYQJLQrjC4M 4IA/rgRQKKcDSIdfmyoDY9Jnup07Pu60x9dgh44qiZbbzXuQkdjYvrF X-Developer-Key: i=esteuwu@proton.me; a=ed25519; pk=wToFt4mOAWkzbqb15Ye1hrhevI13vK9BcMUFiQ/me1M= X-Endpoint-Received: by B4 Relay for esteuwu@proton.me/20260622 with auth_id=835 X-Original-From: Esteban Urrutia Reply-To: esteuwu@proton.me From: Esteban Urrutia There are no downstream device trees that specify five values in the qcom,aux-cfg1-settings array. Plus, after cross referencing both downstream device trees and entries which refer this function, only 0x13 is specified. Since 0x13 is written at initialization time, drop this function as a whole, and remove now unused variable assignations. Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") Reviewed-by: Dmitry Baryshkov Signed-off-by: Esteban Urrutia --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 31 ---------------------------= ---- 1 file changed, 31 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualco= mm/phy-qcom-qmp-combo.c index a72c3b9654ec..5b278fd54a16 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2325,7 +2325,6 @@ static int qmp_v3_calibrate_dp_phy(struct qmp_combo *= qmp); static void qmp_v4_dp_aux_init(struct qmp_combo *qmp); static void qmp_v4_configure_dp_tx(struct qmp_combo *qmp); static int qmp_v4_configure_dp_phy(struct qmp_combo *qmp); -static int qmp_v4_calibrate_dp_phy(struct qmp_combo *qmp); =20 static void qmp_v8_dp_aux_init(struct qmp_combo *qmp); static int qmp_v8_configure_dp_clocks(struct qmp_combo *qmp); @@ -2466,7 +2465,6 @@ static const struct qmp_phy_cfg sar2130p_usb3dpphy_cf= g =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .regs =3D qmp_v6_usb3phy_regs_layout, .reset_list =3D msm8996_usb3phy_reset_l, @@ -2603,7 +2601,6 @@ static const struct qmp_phy_cfg sc8180x_usb3dpphy_cfg= =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .reset_list =3D msm8996_usb3phy_reset_l, .num_resets =3D ARRAY_SIZE(msm8996_usb3phy_reset_l), @@ -2650,7 +2647,6 @@ static const struct qmp_phy_cfg sc8280xp_usb43dpphy_c= fg =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .reset_list =3D msm8996_usb3phy_reset_l, .num_resets =3D ARRAY_SIZE(msm8996_usb3phy_reset_l), @@ -2696,7 +2692,6 @@ static const struct qmp_phy_cfg x1e80100_usb3dpphy_cf= g =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .reset_list =3D msm8996_usb3phy_reset_l, .num_resets =3D ARRAY_SIZE(msm8996_usb3phy_reset_l), @@ -2785,7 +2780,6 @@ static const struct qmp_phy_cfg sm8250_usb3dpphy_cfg = =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .reset_list =3D msm8996_usb3phy_reset_l, .num_resets =3D ARRAY_SIZE(msm8996_usb3phy_reset_l), @@ -2834,7 +2828,6 @@ static const struct qmp_phy_cfg sm8350_usb3dpphy_cfg = =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .reset_list =3D msm8996_usb3phy_reset_l, .num_resets =3D ARRAY_SIZE(msm8996_usb3phy_reset_l), @@ -2882,7 +2875,6 @@ static const struct qmp_phy_cfg sm8550_usb3dpphy_cfg = =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .regs =3D qmp_v6_usb3phy_regs_layout, .reset_list =3D msm8996_usb3phy_reset_l, @@ -2928,7 +2920,6 @@ static const struct qmp_phy_cfg sm8650_usb3dpphy_cfg = =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .regs =3D qmp_v6_usb3phy_regs_layout, .reset_list =3D msm8996_usb3phy_reset_l, @@ -2974,7 +2965,6 @@ static const struct qmp_phy_cfg sm8750_usb3dpphy_cfg = =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v3_configure_dp_clocks, .configure_dp_phy =3D qmp_v4_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .regs =3D qmp_v8_usb3phy_regs_layout, .reset_list =3D msm8996_usb3phy_reset_l, @@ -3020,7 +3010,6 @@ static const struct qmp_phy_cfg glymur_usb3dpphy_cfg = =3D { .configure_dp_tx =3D qmp_v4_configure_dp_tx, .configure_dp_clocks =3D qmp_v8_configure_dp_clocks, .configure_dp_phy =3D qmp_v8_configure_dp_phy, - .calibrate_dp_phy =3D qmp_v4_calibrate_dp_phy, =20 .regs =3D qmp_v8_n3_usb43dpphy_regs_layout, .reset_list =3D msm8996_usb3phy_reset_l, @@ -3316,7 +3305,6 @@ static void qmp_v4_dp_aux_init(struct qmp_combo *qmp) writel(0x03, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG7); writel(0xb7, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG8); writel(0x03, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG9); - qmp->dp_aux_cfg =3D 0; =20 writel(PHY_AUX_STOP_ERR_MASK | PHY_AUX_DEC_ERR_MASK | PHY_AUX_SYNC_ERR_MASK | PHY_AUX_ALIGN_ERR_MASK | @@ -3345,7 +3333,6 @@ static void qmp_v8_dp_aux_init(struct qmp_combo *qmp) writel(0x03, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG7); writel(0xb7, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG8); writel(0x03, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG9); - qmp->dp_aux_cfg =3D 0; =20 writel(PHY_AUX_STOP_ERR_MASK | PHY_AUX_DEC_ERR_MASK | PHY_AUX_SYNC_ERR_MASK | PHY_AUX_ALIGN_ERR_MASK | @@ -3605,24 +3592,6 @@ static int qmp_v8_configure_dp_phy(struct qmp_combo = *qmp) return 0; } =20 -/* - * We need to calibrate the aux setting here as many times - * as the caller tries - */ -static int qmp_v4_calibrate_dp_phy(struct qmp_combo *qmp) -{ - static const u8 cfg1_settings[] =3D { 0x20, 0x13, 0x23, 0x1d }; - u8 val; - - qmp->dp_aux_cfg++; - qmp->dp_aux_cfg %=3D ARRAY_SIZE(cfg1_settings); - val =3D cfg1_settings[qmp->dp_aux_cfg]; - - writel(val, qmp->dp_dp_phy + QSERDES_DP_PHY_AUX_CFG1); - - return 0; -} - static int qmp_combo_dp_configure(struct phy *phy, union phy_configure_opt= s *opts) { const struct phy_configure_opts_dp *dp_opts =3D &opts->dp; --=20 2.55.0