From nobody Sun Jul 26 01:07:51 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012000.outbound.protection.outlook.com [52.101.126.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50339410D37; Fri, 10 Jul 2026 10:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680844; cv=fail; b=nos1C8p6Ada51x6AVwUt6S2cBGjbL0z2p9e5xiI7Dr9tSASVr/Svk0+vNaqckBzoZpwBmONVVb3EcRGxCM/tQhhY5JA3ATfySc7VkdxzCWODnVxvt7WyLyM8Qux6gtnLsN/zibXB1sGca2LHyhY6AmZo6TsoAMYBaJRJxWMGKCI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680844; c=relaxed/simple; bh=dV7MyjrNaymEZQk91wVHQ62HWa+XNTNsmPcMyNny42w=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=RA88YB/llwwZ+16yv2Wa0Cpx30PCIbPU5wyXCOc9Ju16w6mlzaqEvGgQyvhpO0QRPvwwNpV29GC4mXq11m2mm6GBrGSO/sJPhQVV+jzAsbENb0kMx+6wk5r/e+FJZwFn/hRPKQzsTDqezhWH8a6BGtGU28yN0madzAz5GtrtK3E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=LI6Zi3xh; arc=fail smtp.client-ip=52.101.126.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="LI6Zi3xh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RoZL5Z9ToRx/f8kviD9CyKaiC5FVV0S6HJv5HVsNVGS9SMyS/LqnFdICPsZHpud+BEMkGJPBlOfdi1I0+dHxI/ZGaUrJbBn0zCEs0j4qTZ5DzfmbDjyqJeApTwBXk76N9O7gD2spw+iLfW1h4zuNRQXTTOrdNqyAAsi7euudiLzmFquyU/BIAlde+Qahg0NlvZ95PbtffbPJYwcEqpwhU/kBKPRAyOj/GoLfTth01XQK4qgNjL+9WIua8og2EbDnmeDiavLDfyBWeHgzdrDxL1i2jMI9CnK2xe4u50afLBKJQ/h/qvEvkyB69NTNqrLEJENTXxGjKFAM7rNB1rm44g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=acT5XmYocSZ19UIykLwYP24NTpZzoE7fRl0T7yJJVm4=; b=AmFZMjPP8uzbxoOzupTD/1c7sg+ORQow7dxpseCc9zjGw+cuiNxvPkAUtyY4ldHlmfCehVGeAad77tYzYK5rfqf2xO2o+PZtlohbFoyIZPRD7CM6tpmj9BQh4wikkMFZHY0gs47kToN8zYT//s3lJAHu0XAxFL5FCGFaFHvTL1WdKUJmWek81CgEkZYa2yHgFm79jIo08TsZf5JqasEyksC1RXoj5lOHZT0LJ+zx86dCm3cl5Is2DNqVnhLEj1DTDeZTwdUIs6xXxTzK23FyFoHSd+b8ywLFNPniW8JJW03ZJiRgBrmRX2yfnGd26eosw6pInK3R56+fWb4z81aoGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=acT5XmYocSZ19UIykLwYP24NTpZzoE7fRl0T7yJJVm4=; b=LI6Zi3xho7J7F1PXdKE1Lp4HEIJtsm2Xpb86kNmUG29lNvrEOAsccEnnDtAQgjwDS05lkyCHdohKe2jKVp6J5Gxtjgzj80cRyBlZBJkpOkfOEQAgX+rdMHo01gGnxztOc+yKApTr55I3FziEKqOK8LZCJ+5l/o3f0IvP73yKTAJAyS0jqRseXP6/nTPpj9iXPVq1L8MpGuNgKbiroitYdpYCD2NUNc2Kcs87wJZDMD3uYXGrf+GU+P2luLBRtm/kLVHiDfQxxc8rcK9kN/IvHBDEOLK5pEG8rkZoDKaln1ibbSYoha6lgMA7igcQmjrjKNJhl7fiTIYUNXgKWWIjwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU4PR06MB8388.apcprd06.prod.outlook.com (2603:1096:d10:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 10:53:55 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0181.016; Fri, 10 Jul 2026 10:53:54 +0000 From: Pan Chuang To: Olivia Mackall , Herbert Xu , Hadar Gat , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jia Jie Ho , Deepak Saxena , Pan Chuang , Takashi Sakamoto , Bjorn Helgaas , Danilo Krummrich , Aleksander Jan Bajkowski , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , linux-crypto@vger.kernel.org (open list:HARDWARE RANDOM NUMBER GENERATOR CORE), linux-kernel@vger.kernel.org (open list), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE) Subject: [PATCH 1/3] hwrng: drivers - Remove redundant dev_err()/dev_err_probe() Date: Fri, 10 Jul 2026 18:53:06 +0800 Message-Id: <20260710105318.376496-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260710105318.376496-1-panchuang@vivo.com> References: <20260710105318.376496-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0021.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:5::12) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU4PR06MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: 18eb0684-099b-485e-7771-08dede71892e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|7416014|52116014|1800799024|366016|38350700014|921020|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: d1tBzrkNJ45/yKtXut+HoMebFWBA6BxkyK2/WfD2bXFlizGM8HssHs4WRsyBdaeFvqJXybEYTQvr1ihfFf58zURQhJ1WEtZ0XL0KoQcs2EnYR6YadwVf/YufTV0d5aYaSNfx+WijwGBMaDFXuv+h5Wo5x4N+Xa/UkgBdLXMNlTpGxWaLSQ1xieWDkIpsOacE5p3aXUnbVYvNujjjLcxDrSLlsEqHHL3Digib0llFxRjQZpPvLc4uKJE8uSmvov3MBPQCemS0WnDX3ts6zG56yCnUpbsIsec/nRjJV0tLoFEwMnXAur4qK3ZenzpiCtrzJSRn2elA+D+fa4JFgC93m62/zFBNFw0vBaLRRsB5hVbPDdF2JpllA3ceaIi3E8q2NbObaTMcphEgDl10G/hJXNy4sfBlE1tozhPkWtoxPCzftxlF6PuIBwGAORdp3TwcnKhvUhYJnyNi7JwnlNXJAoORiizbxgCpmaV1g5td1ebI/rDJNv7BdKAlaQkTAfFcvP65DgY7Mij6NDiQ99Piz/vdWuL6pT5hV4j66GvoA3+k/HrNLQ6U1iCdsWsEQbRfPUnuftKMv5PD9xy9N+zSKm6c/Wb7o7KmtlLV48Ys3UsnUDZr4tH5M4OMIKaIABXsbsDFv+uWByDWyg5vEGrb7F5VWN3ZnK/sEGJPs2DmmBc0d9KAiy1uTVcKRRylxDH0dS4A+/3agyFB1EeCfgc59YUQWAyzfopS2nf7pJ6cuxGsAWnwH7BO8BAy6V+5UOAx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DtZ46Kgo9hv0SEQ4OwcIJ52Uc4p4icVuU1Wl2IdjsmkHPvBtUdGaK964LCnC?= =?us-ascii?Q?xLAhpy8+3tGE3dAXUHLuPcX7z1/KRSWu0jLfHUsQIBnFkIEEKsbmkIoa6B17?= =?us-ascii?Q?jmwLs+ZTa4koR4je4E7+V3b99gK1e7quFqFfozDiglRv5x2io9riztmC+Tpm?= =?us-ascii?Q?JlOuokEtxj37xhPTd2C3odZmXxsBmB7kXyLC5LraX3d+lpx8rDPz/048ykxM?= =?us-ascii?Q?AEnSRptIBQttlFP11GWiaBfMfxSDa3WpNIBuY3ST5gY+G2Fp9rGLPtHx8PLh?= =?us-ascii?Q?69gO54EgoYjCl9/iQA0q1DFIZYi6qhSlzd26fp1Zl9/ZpcCP90f0rw+GFh19?= =?us-ascii?Q?iLEhsWMb4M0c+abGNAldbZsU20jv6eiciew2P3TuELm/en5xAv+v+Bjb6LSB?= =?us-ascii?Q?Lm0qjKsGqA0W0bmggYCjcHkwFsvY51NAVSHmnwtIa1nhF3pVVZjBuQZqrQSu?= =?us-ascii?Q?4ZJAXDov5qevbjLPZ/kVt2PUfMUSaHEBsLX4EarQrzH8ULXuNUymFbD+dlkC?= =?us-ascii?Q?RYl05BjGwrUtVEoKvpL/vTbGduWItrfZxJ5QhSEDQ9/ezNKOKGuVQbXMCrsj?= =?us-ascii?Q?YKnJY0rqG9Tshoi8vHra4Z8Q/DrzRBZ07xhlBUGJGrxBJY5tYcCgPCU7sw1U?= =?us-ascii?Q?xE5aX+XIzcP3Yvflt7AQOLXvaaFUHL0c5wzCriA9tLdhTvmLHR+eQ4tLOq4C?= =?us-ascii?Q?aBNnXLxL/IX3NcF9WHIte8UyrFbZ12S2AgcEWXgSvixq7sZzPDNm8AzlhrqM?= =?us-ascii?Q?8pGg3kESVaYxImxzodgrwmH9EL98Lok/35qdgUvt8CsIp+HsqElGNcirUG1t?= =?us-ascii?Q?FMvFPEMTkpP0SyzXoktMMOxja02T76sP7zICN5zGcN46pAG3aoJRovV3kux8?= =?us-ascii?Q?F6qrEORu/4HkT99AbOKPhcgYA94OaS0fW+5bu+cQZs0ybgYZ+7NofnwJHv6W?= =?us-ascii?Q?xyD1JqE8SK/1/MWGYiRjIZl6Kdq5F0Z7E23mpz7Y/H8t8Waq/DbkCLPsjup+?= =?us-ascii?Q?rUJ9xzNCXxjHFpCQ+DIkxugsjNqwIe8dR0iVt4itNt0+8P4Ty3mTskoMQLCq?= =?us-ascii?Q?ZZQBKndk8YVI9onhoqJRoPKPsr+WTjS6UciwFWIQiwbQbyDnXgx3gbNtX4At?= =?us-ascii?Q?IGuzX8M/Lp0Q8X6YsOL6sKm4gwfZTFiv+gF4MpamMpUgYQAjzn+41Q/djWTz?= =?us-ascii?Q?NXeoQwQ2rqq9LWNlN6nOBVJXjk6lxv4+cdIV6zgK6LWYiia7ZxCWuF76QP6Q?= =?us-ascii?Q?qS1dQHrjXhECLFrbB2s+1MXF3kEglj82iH45e1/wgCslQ7X/KcAPzcYd9ob/?= =?us-ascii?Q?plCa0x9lRnQzPiqKzi/27r+6nBIpKZhvZaBlbafhhKZa7LFi/w62nW2/+l7K?= =?us-ascii?Q?AXXfPUOFP/oD64kq+tDhpIYFEhBQ6146czwJ6G13vABsxKODzaaj1jMAmhqr?= =?us-ascii?Q?gcE/C/AiTsEYfexkbg3COqTB8LviL5z1JFl+9Z5Q1qn2hgV2BAeoRoVE1IZr?= =?us-ascii?Q?9xkoXAmBoVTHcg9Oapda5nfp+V4LrH2d6VfwLPxg4g/68ggwc/PclD9AWmiv?= =?us-ascii?Q?N0GwotO/lmXl4miQG7p8G2zAAIvrWaUFyv6ahRdNOgu20j6TagKXoO/ysWvV?= =?us-ascii?Q?LWtLtXB1a03/ARBDRXpceMDNlOBcIvp7U9+GKteDlNHFaMUzyR1jVzdDf5eI?= =?us-ascii?Q?wu+CEBa7eqrMhbhECnStZdWoGdpSqCB2D355CIMirRZWnO8Uik3Ag/HcL4pB?= =?us-ascii?Q?8kwPIYkkKA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18eb0684-099b-485e-7771-08dede71892e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 10:53:54.9027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PYAF9rw1aranB6LDSTlIeX0ASHZBG3a8QHepiwSef7H09Viz6taMW/5FnwCyAewgU9XbQoNFP1Q4JbfOn/EZCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU4PR06MB8388 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/char/hw_random/airoha-trng.c | 4 +--- drivers/char/hw_random/cctrng.c | 2 +- drivers/char/hw_random/imx-rngc.c | 2 +- drivers/char/hw_random/jh7110-trng.c | 3 +-- drivers/char/hw_random/omap-rng.c | 5 +---- drivers/char/hw_random/xgene-rng.c | 2 +- 6 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/char/hw_random/airoha-trng.c b/drivers/char/hw_random/= airoha-trng.c index 076519a2f100..98c131ee9891 100644 --- a/drivers/char/hw_random/airoha-trng.c +++ b/drivers/char/hw_random/airoha-trng.c @@ -186,10 +186,8 @@ static int airoha_trng_probe(struct platform_device *p= dev) airoha_trng_irq_mask(trng); ret =3D devm_request_irq(&pdev->dev, irq, airoha_trng_irq, 0, pdev->name, (void *)trng); - if (ret) { - dev_err(dev, "Can't get interrupt working.\n"); + if (ret) return ret; - } =20 init_completion(&trng->rng_op_done); =20 diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrn= g.c index a5be9258037f..a6925211c3b5 100644 --- a/drivers/char/hw_random/cctrng.c +++ b/drivers/char/hw_random/cctrng.c @@ -509,7 +509,7 @@ static int cctrng_probe(struct platform_device *pdev) /* register the driver isr function */ rc =3D devm_request_irq(dev, irq, cc_isr, IRQF_SHARED, "cctrng", drvdata); if (rc) - return dev_err_probe(dev, rc, "Could not register to interrupt %d\n", ir= q); + return rc; dev_dbg(dev, "Registered to IRQ: %d\n", irq); =20 /* Clear all pending interrupts */ diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx= -rngc.c index 28c56c2d1bf6..bae8cdca13fe 100644 --- a/drivers/char/hw_random/imx-rngc.c +++ b/drivers/char/hw_random/imx-rngc.c @@ -296,7 +296,7 @@ static int __init imx_rngc_probe(struct platform_device= *pdev) irq, imx_rngc_irq, 0, pdev->name, (void *)rngc); if (ret) { clk_disable_unprepare(rngc->clk); - return dev_err_probe(&pdev->dev, ret, "Can't get interrupt working.\n"); + return ret; } =20 if (self_test) { diff --git a/drivers/char/hw_random/jh7110-trng.c b/drivers/char/hw_random/= jh7110-trng.c index 4712c3c530e4..aee12caab578 100644 --- a/drivers/char/hw_random/jh7110-trng.c +++ b/drivers/char/hw_random/jh7110-trng.c @@ -303,8 +303,7 @@ static int starfive_trng_probe(struct platform_device *= pdev) ret =3D devm_request_irq(&pdev->dev, irq, starfive_trng_irq, 0, pdev->nam= e, (void *)trng); if (ret) - return dev_err_probe(&pdev->dev, ret, - "Failed to register interrupt handler\n"); + return ret; =20 trng->hclk =3D devm_clk_get(&pdev->dev, "hclk"); if (IS_ERR(trng->hclk)) diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/oma= p-rng.c index 5e8b50f15db7..327643ba971c 100644 --- a/drivers/char/hw_random/omap-rng.c +++ b/drivers/char/hw_random/omap-rng.c @@ -391,11 +391,8 @@ static int of_get_omap_rng_device_details(struct omap_= rng_dev *priv, =20 err =3D devm_request_irq(dev, irq, omap4_rng_irq, IRQF_TRIGGER_NONE, dev_name(dev), priv); - if (err) { - dev_err(dev, "unable to request irq %d, err =3D %d\n", - irq, err); + if (err) return err; - } =20 /* * On OMAP4, enabling the shutdown_oflo interrupt is diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xg= ene-rng.c index 1f4b95341c2e..629dc85c3741 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -336,7 +336,7 @@ static int xgene_rng_probe(struct platform_device *pdev) rc =3D devm_request_irq(&pdev->dev, ctx->irq, xgene_rng_irq_handler, 0, dev_name(&pdev->dev), ctx); if (rc) - return dev_err_probe(&pdev->dev, rc, "Could not request RNG alarm IRQ\n"= ); + return rc; =20 /* Enable IP clock */ clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); --=20 2.34.1 From nobody Sun Jul 26 01:07:51 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012000.outbound.protection.outlook.com [52.101.126.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95944071FC; Fri, 10 Jul 2026 10:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680848; cv=fail; b=Vy0EbDjPoijfZrGi39w0NcmeGwdW5JJ/4FTuSLtLDaANVc8ln7k9DvaKpWrfs+oEtvNfoyX0aNLmqEPHySw95IxlLFnzIfoSMFAOtmBYx6v2VekSiLGP18xcb1PcYdUoYO7+gSW2J//8k0csGmeyNxpr/XLcpxSZ2hdP5S3647A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680848; c=relaxed/simple; bh=YH9WFb2x/MltxmV/bV/b0n41sq6OEkmsppTe5pi2wIk=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=VB0qyQgnP6RxTMBk/Lk2/iCncE1x+VmGXZbNa/455E1hud9gX+yFdRbvrjvgSDmjUsg/Fsrz91ndZclyjTX+qj8J6y5DetHigHKJuFWVRAmgtlM0HqHE/NZYMcybqR0yZWVv0ytNkHsfTg5ED6YEIdqj0KifeQtf/Uwz81jOh4I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=HSe4zVYi; arc=fail smtp.client-ip=52.101.126.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="HSe4zVYi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pH6u/MNKDQeOF6s58ueD3jzSl2L9Ou1BY4ItrAjImDIUj7iez4j5q3zt98lD+IRFlqXoH6PBxpXVL08ThpovbjDlvSBiUdKDSze0FfoRi9rMfzPrkiplb9J/C5WqDwm3UbU/W/cypf68KZGSBeo4UQM63wn8TeJvVIDDleMloRRE6X4k+btR9/1n+PpZ6EW8KEQgDRWRJpP/f98HUhxC+ys0lgZqWlW08AZ1vQ6tWRVG+hlqH1HX/fzi5fTYDQN8JgxWbrX32kkGuU1CRlcenfCUyWNSAr9MIXSiE/OHVvbJW+9DR3v0yD76xul35kMEwHlK+4UgAaKqtMo0P1mXrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j4DEigpiyrlFxcUmRo16+xR6jEtg5yDwqbvSd2rqdgg=; b=tLTWcxGZcZUhx6D484wDkXgQogkiDsLqvPvLWZfCvwycTnfIucn7ggjzTDEFAPsOwAd81ZQ7bugYNYMD5TrBfZHGakiJziVvEuOocLB+W4K0jSbD0NQVBVD92L/07bezP+mSyrnS/ckaDFsNiOP2sgRi+Fx0jbQu+9qCOx0JY0HU9P78ylkc4Y14OFXtrKuuiN1GSqN0O8rIMOQNibJsh77r31rdgHbavaUX99XPg7LsOMUiFBpRxutd66qzHJv2+du1cHr905roSI7fuiPWt5FHvwG9H2P09R4WnctOcFlF2wz9sV2u/xTN8s8eWVYhkTaQtmNwcOLBIm41wEgqYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4DEigpiyrlFxcUmRo16+xR6jEtg5yDwqbvSd2rqdgg=; b=HSe4zVYirlRs0YUWx+lsXdGMWzR/fHA+9NfwjkKS+juB1rSZgPnaxjbkXAoiT/DO9OsCYNTWKKvMHa2ARIN+ZRVlZiP96xyPrnelfRwCFB8BEG29+uLfsCln3d8nhEVIByCzv235pVW2L2yrEeEVVcyI2rO46JKwNdCBk4e6V7Q0bc/vZ2tuo0tCS+bebS4DKMnNy0nzuCLrMIacSBd1fiUeiVkHFHmTPhkxMbZKmG3wSPFJIZNa7KSZzK6Oe0mjvCd0nwbmDgudShRNMu+lvd+xgIZ7wRa0w10DABbEErxhVvAiHt7dvrFC4zKPWhDfJt/g6LbCU5NOGPiNwMLSsg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU4PR06MB8388.apcprd06.prod.outlook.com (2603:1096:d10:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 10:53:59 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0181.016; Fri, 10 Jul 2026 10:53:59 +0000 From: Pan Chuang To: Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Stefano Garzarella , Alper Ak , Pan Chuang , linux-integrity@vger.kernel.org (open list:TPM DEVICE DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] tpm: Remove redundant dev_err() Date: Fri, 10 Jul 2026 18:53:07 +0800 Message-Id: <20260710105318.376496-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260710105318.376496-1-panchuang@vivo.com> References: <20260710105318.376496-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0021.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:5::12) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU4PR06MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: f72f5094-c67a-4e9e-331d-08dede718ba0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|52116014|1800799024|366016|38350700014|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: HPM6K2RjhOkggsq6Y8zEMtdxZgLEsWSWdzJoRppWqdHunFER7Ux0j/EsEXPGODMQQOu/8QozJOcLTwK2JDJo66M1guDhhiln7amR5/699kGjubUL0R7mJKBIks9IC9CpfVlkYuyrcwj9NY0cCV/S5S2HzSNzWMkVjEgqbw0n5J0dMeggW5Lk8a1/XkwMta9qjuJF4GvtYUt/UL72KI3q1RIfXW2G4F/qH1hFkiIFVFXmMaSODFukX/Qu61ksjU6+r2TFLXjQhwRA4vn0rTNqqJ/K9IZaIchTAlKIFELrAx1COshp38Va5ttosx1wm5XTIDwp3MRKzXtyQe5rmRe32ylcm0DUFXxl7l0dSHgV9VMfd+GQ3lf2O5Guovpba+bnmEINViRfdZbhtI1ylIa5zeWhgcMVdhUPtFdCxpGGaLBKdI+S+Dd+ax9Pcmj0dHJzUgGLwjqSNkKKMJD4b0gorGhoY9+xphZEbM+q7zXsHYjBtpXFNPCcD7Ewaqh0HKx3LNnKqCPcsWwdAy6Ze5xDt0ezUV5sZFN0oYtDiAGLPxHfZ7vWY4thZ2bjihJ/Sy8C7y36Ng2hGG68pZ8Q4z8HehInjkgErxAPQRcyFgGCT8QUjvf850erZk5c5hj81wxthdmT6hl/m58jUxs7VsXvruKoaDsZdr0WzOkqWssrJ0xU21/30wxYAAAFpEp/JQ+gnoys51mnog56GIXbzG/oNfhsrEglLI3XmtiBNOD3jZk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(52116014)(1800799024)(366016)(38350700014)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eqbGfDj6GM50B8QoqMzbrHZTF2U4eegB0fRK4ctaS1bgDgYZF8BUYgBf1mZv?= =?us-ascii?Q?ZiRiQ8zvhsZKp6MxGXjo9cUsltG7O/quJcoejpi9z6ke7fHlChVxFucFTWSy?= =?us-ascii?Q?+nHcpLRe+gDEfT95iL1O2NMdxV8G9tmeeNGZ6FwywBn4aGnwbjhzg16NBHWV?= =?us-ascii?Q?na5wKzMt+TZyR7/R5cWGUNXanpWvYBbj9KTkGhSJv9+RFYAPeoYaj+uWmTGL?= =?us-ascii?Q?ECHIx2uha4/Ikg4lyGlf5UwcQsv+QIuxwaAA5/hrOMtIt4kWeTsr2gam9tVm?= =?us-ascii?Q?TVaFk66Ym3QiuVx27ErBNKEN4E8mpfYRUdaO6vANS5VzBZPWb5Wdsf8A1MMT?= =?us-ascii?Q?DozL8yg1P/Nf0douuPKzXHCQP8nd2BF9tZBfehEp/6kCFKETUJEN4pG1o50a?= =?us-ascii?Q?GiHjrMH8cJMuXIUfr5INB3HbPTVuantAXZfgvi3b9ijA+oTt+67CmJe8liMA?= =?us-ascii?Q?CFvpQnISK0k2ERUiRrZW8qy9ATPMaW8+EkbLvoeSsylr8HKNuoYjJmOJD8F9?= =?us-ascii?Q?icneKLVN7UH0cOPGVgX/KL6C1MIRQ5ajmlw1hN5Ccjo5IEolghSPIVlMN6u+?= =?us-ascii?Q?IjNwFusYLZn1FE6oRQFkQuWPfeqWsDA/euxygWVoabRq/td67DU7iSk3vlso?= =?us-ascii?Q?XkLBlzobHYfmU37m2J6pvtwfWl3VnCFAzbjPCNx3osGujMPnXBUbVsUN2a/S?= =?us-ascii?Q?fyHsVHjlKG0y0quNoo1prJ5gzCpRlMjfpO8kyC36xb9L2XoJ3P1rWyyRmvmT?= =?us-ascii?Q?wp15tB0tGSUBVujYcUW7zIPmsJt/OjY+rWqkjxZ9l1wRMCiDLN7/UAJ6cOV4?= =?us-ascii?Q?3CVy8PnJoCOseHGUsKAeSwYkRwV9T/EMIq1S1YBGJRPLCPLh80t3OBeeN8vc?= =?us-ascii?Q?cmKCDKp5bEolHOr80EgL2pZp6Po4n/AXkeQiO7TrEidtaZphYniF3bJgw+/z?= =?us-ascii?Q?HufggxwMEK07aVjQAWzkckXzsw33FFzYfOAlPfrxfdsmQx6vh+sEl4z9XSHI?= =?us-ascii?Q?japKxProuiEwEE4gwTJYbHsazOolzhpI1X3rzF/zKqtFlz46yfS3d6fAC4lF?= =?us-ascii?Q?qhQJpMtc0mskz9EB8LbcS4Nx2buVomv9lIc7g0ZQEAi/h6hsRD6WOTkjaomQ?= =?us-ascii?Q?Xt8WFppcIvSxaCJateb6gVmavCQCJ52PNP2Q1rlCQo0+q3vRuJwXsej7BuPV?= =?us-ascii?Q?wooRfwQx5Q94cYDs0qv3NQwObgiAdKYE/9WjOOms84oNv6Y10iqA/Erf9dir?= =?us-ascii?Q?4LkNiGCEUiHoJZpAWyny5uJofcZ3rPJD5hXO91Kmt6zkPHcMZ6/A0xdCjyGY?= =?us-ascii?Q?buD1Uno94Wi+9FIYKOU0sIfystFI3T3s0FpufXLF8vG73s4kcFtU7CxV3b1+?= =?us-ascii?Q?VV68YmW377lwvCTVSW2yKEi8scthBL/bKUCwO2+HgiL4Nm/YU6q+NVtuEMwx?= =?us-ascii?Q?5QaFB8286Sg8vVsUGvF5R34BAJ+DR8UPfVGR1thtGdMKKfZUsJh+l0Bvq4eq?= =?us-ascii?Q?2ytBUX33R8enDG0he5vkrasdgZ9dheY9HCrz/n/BpAimiVHbNjclrUb31vWP?= =?us-ascii?Q?OPC37cwwWYV/bGPYtXLweFzESkxCdXT+G86NbCn19kS9TVdQucsQPiEtp8tc?= =?us-ascii?Q?MTbgzhTsyi/F7e3hbgS79X11jzCLUH1IMyhk3UNkKAiWR3M0bhU/fWx9VV9S?= =?us-ascii?Q?/SmXSPnJZjfWF4sgWjBAASL/kG8qOPYrfUs3vUuXhUKZLgqcoiO7L2IJ5hQZ?= =?us-ascii?Q?/X6L7JDqng=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f72f5094-c67a-4e9e-331d-08dede718ba0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 10:53:58.9936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VaqDIYbXDD00tkdINPt7N3XE0gWaPbu4UcrwSrbiX5/35cujoHoy3AwAS4m6hy4624+85x3bN/0t895fDyfBTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU4PR06MB8388 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Jarkko Sakkinen --- drivers/char/tpm/st33zp24/st33zp24.c | 5 +---- drivers/char/tpm/tpm_i2c_nuvoton.c | 2 -- drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +--- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp= 24/st33zp24.c index e2b7451ea7cc..8d5179367eac 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -506,11 +506,8 @@ int st33zp24_probe(void *phy_id, const struct st33zp24= _phy_ops *ops, ret =3D devm_request_irq(dev, irq, tpm_ioserirq_handler, IRQF_TRIGGER_HIGH, "TPM SERIRQ management", chip); - if (ret < 0) { - dev_err(&chip->dev, "TPM SERIRQ signals %d not available\n", - irq); + if (ret < 0) goto _tpm_clean_answer; - } =20 intmask |=3D TPM_INTF_CMD_READY_INT | TPM_INTF_STS_VALID_INT diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_= nuvoton.c index aa3673002f3a..c84afb29d548 100644 --- a/drivers/char/tpm/tpm_i2c_nuvoton.c +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c @@ -576,8 +576,6 @@ static int i2c_nuvoton_probe(struct i2c_client *client) dev_name(&chip->dev), chip); if (rc) { - dev_err(dev, "%s() Unable to request irq: %d for use\n", - __func__, priv->irq); priv->irq =3D 0; } else { chip->flags |=3D TPM_CHIP_FLAG_IRQ; diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis= _i2c_cr50.c index b48cacacc066..7f828fae70d3 100644 --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c @@ -751,10 +751,8 @@ static int tpm_cr50_i2c_probe(struct i2c_client *clien= t) rc =3D devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler, IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN, dev->driver->name, chip); - if (rc < 0) { - dev_err(dev, "Failed to probe IRQ %d\n", client->irq); + if (rc < 0) return rc; - } =20 priv->irq =3D client->irq; } else { --=20 2.34.1 From nobody Sun Jul 26 01:07:51 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012000.outbound.protection.outlook.com [52.101.126.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A7741168C for ; Fri, 10 Jul 2026 10:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680852; cv=fail; b=pfS1JrE9VX5+BEF9DzuCONfBHK2Cwjx5LbkKjKW/guT91T18AP+xMxPz1UOoOBR6/pAL5gfVPGT0uJiRyvJ9b8h7at2axURDCtZzWFAhnpRQzPkTMBLUybr4WHmXSgAu1pjVkJ2TR4VA31NbEwH+8b5YzE99ukciz/GfXIqnGBk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680852; c=relaxed/simple; bh=l5JwS64xqOxDl/2tI7oNOLtZei4rgW1MkmU9pCVgJps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=o1nitf4OYPxJXWsWdwFhBxaJ+7OxiNnKzrBOfgPBXAmz+UsJP/Rp/sqQDpdXpkqv34G9HWJDsJ1CpzUYnn1WcPRrd6j4RudIX9jDpGGWuq5zTwSaE1dQgB4qj6dDodlcuyAiJhSh9LbN8cRo6dJ8KdGkqCty3ZF4p9p/kEtweEY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=JFbwikqn; arc=fail smtp.client-ip=52.101.126.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="JFbwikqn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q0B3uzPP/acvM59LCkE7NlkjsVyPGhMTpuvDLL+/oK7VqaZWLunzAFWbrm1sc3KgTxeyKE4snS74PNYbXLpZauBmso4BEBOvL/OFN+av2XRdZ0YNfOw+PU15jDWmKWKbpmvl+6zOL2/ZH7lKXOVWUuGJbsrLQLAcmwkcKi6mwFNyBtU9Q02+Fa1sqcdLb0KELwQtlGK66Q8en3uznRFYd0QegKo7nmnBeaXQNwva9gmoz2sAh6Iqsh2euf4whhbBnN6P7l+XZKyVxGyJFHMgILKQD2sL2Se5/pxrBTB3/MVg5SkAGtcOk0gJIdc8TS2Yt95gG8/TlxdNwgj5xNjYww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nTJ4b4Phy1+NpVa7xhIBePP0s74V2ApHDJe0ZLomhfA=; b=aH0tDz45uuz9Op8/QP0KMx936BCN+ooqq+e0bM4AsdhnNyIg98WxsOpQcnFdNWkXsBR1VjPXqjw2QOyWWHuvFBS6K5nKBZup4o9tdeapJEe2/M1rR7wWuykuRL/9L1MtIsJ3/+JfR9RGCblnoIPGGQsmTtSToTN33Ism9O0FvSEcGD2yniS5XF4uZyS8D8n4igXQchEgAqwfUxoH5OqT7L9+W4AGJStSzN+UttlL8m25uJPcg/Mg+3C9mqaUyMTCwkXuR1yOXsrFm5uNtdHQW6vr1psVC7yNkV32cNnbFin6y6TIh3uU48lnpaYYaZHBB+9pi4bxtHma/IpnSXEORw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nTJ4b4Phy1+NpVa7xhIBePP0s74V2ApHDJe0ZLomhfA=; b=JFbwikqnsOr/M2xXKFHS8W5xgvpijnMUe+7CrUw6nAnyJHGrm6sww/dN+Otj+ZH46VTw2+zaqllpY9dUav+OPN2tOjc+7/ZQ1fCAaCKwlDKwGZvb/srLGQ1X08GAD4/qDFutV1rWNx0GC6NfTF54Y+1z57Cuf5qvf/ftQcjN1krlB9DmZbkNCGc5eIr+qzPEIaUQVmYVgQXmyNMd4AUsmn3jSkvehCfrzV1qLFB0o4kEQYgEH8QpPRJ8jOlR8nzdeLDCB71xOOSC0F35+G/DmnXv3pF9fTig0EZAyd7cjTZi0x4RX8IrGDz+9NnNr9c27vlXShJfDKKidVJ4B584gg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU4PR06MB8388.apcprd06.prod.outlook.com (2603:1096:d10:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 10:54:00 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0181.016; Fri, 10 Jul 2026 10:54:00 +0000 From: Pan Chuang To: Eli Billauer , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org (open list:XILLYBUS DRIVER) Cc: Pan Chuang Subject: [PATCH 3/3] char: xillybus: Remove redundant dev_err() Date: Fri, 10 Jul 2026 18:53:08 +0800 Message-Id: <20260710105318.376496-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260710105318.376496-1-panchuang@vivo.com> References: <20260710105318.376496-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0021.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:5::12) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU4PR06MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: f3e2134f-59ef-403e-37cf-08dede718c78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|52116014|1800799024|366016|38350700014|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ROb+yv1lCx5M0lXi6krpmzpGTxDLs31VwwJjlJe4nANWih8kAIahals8RgqkGvAFnuYdDqeqb+VAjkdVSeQ8eEZRFEswbTmb4VVD2GOzxzlJfvXVthb8cL2mq348+KmC9j1D0Am+XCPXBw5VxbMyLWCsmLIz9PhlZWNpjeDGF3TN8x+nH/aT5Ks8Ky2Q3MCa2WxfZBRIj7xTyMcoJly7tuzl/BpMftn0hPy/4Kip2MaYUiDiJmW7rVw3/yk2nXbmjHQxypVrS9l4vytYc7lgG3BdIk8rO5IeJkSoPtI7CULhd4RhNiFwueDjhOxEpIzumAcUnYAp4zYHjvXipIwiI8+uPRfu0AbyohEgdgU50rttGNE8YwbHw/MqJWnN5JukJaAvRDUL7YSfgouwrHzuIiQ4o+9sBvoAlYQQYXQhQ8ngJF+Cv1ONQ8FbE0XYgexY6LvcxtQNi7PmkYXowlwk3caZF3CMHUbFP1U/ohQVvvBKpakgDW7HR8S9u8M3cpz8oLx5hlm/0TVCHZCrj1FNRDJgtTvr1rpgJfuaEx3Yzuh5GDT530egZsVbY84LsT6ejJ0GPLUvLqjVVBF3Q7Ry4URGdB9RSJg7RlCrcB3jZpz7ukiL4ujQF+EJff0HA+dx1jd+kUieQLHSzrQp3fhNh3CDxa9PIlrlvbGnXNij76eZx8W/rfy/fZbSKJ/U9mpjcZIrcHY3+QnFtVPTIzcX/LTQIGgoUSeN/tVqbeE9be0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(52116014)(1800799024)(366016)(38350700014)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j8ePMA2mrABOwbEAnhcOKthLi1rqDomwTrCmHe6h+pAbHaS074XdjUPeSdzq?= =?us-ascii?Q?x864Yi9YHr2FhXGvejQifI1JQ0eaRUSGDczmxP4D8BvFTw/REYjImCB+ABay?= =?us-ascii?Q?REfgQFUq+9+Z7zrUJxvq4pPNyfK9S0MXEIRdPwGG4OhR3SuX25X7z7SRvWy6?= =?us-ascii?Q?OxO2SC0ClqJRqAlL35x5VIXEOQHxtGqlfjs8Y//eJM4NIzSzjtbjZ7h+tfHw?= =?us-ascii?Q?2OwUPkHsLTCAJkOXm8uhvRwZgL1M7bw3VsF3zkANGIvb+7ewNqId+ek0knEF?= =?us-ascii?Q?eYVWzX6u2Q8Nwwg5kv9u0LYE46azaKqQgdtIFB56QMmuDlk8fIrnY+TpotjA?= =?us-ascii?Q?JZneBir+s7lgdKxwPsG0V9qHhheQEVS0RiPUCqi31OqyibA9ZSkL6ao4ba3O?= =?us-ascii?Q?BENWLr8OjWTI9GDkTGjfwvp9hNKIMV5U+i33DUlWjuMYNwejvRQqzlhDAw8u?= =?us-ascii?Q?WjVolgKIhxsgpC/mnSXStsBr76XwpwKJzv38sQPCuhEcF2cJgxhVXXUgkbCD?= =?us-ascii?Q?d0JuNhrtmDqTZJAb8pmbynuZq6DFAa42KLYhU4A8amwpVA7HKHSd424EmbGM?= =?us-ascii?Q?ZeLuJtBD7D5v2XNwtI6yBIK6lDH+cQEzJB2aDsDyo4oHsVFerLxPIVyAnwcD?= =?us-ascii?Q?A4Qc7Tc2FRr7EF4qlo+3yTBYJxdg12nxezdDXPrGt9+s09Y9YufJzom5bNiz?= =?us-ascii?Q?PLD+B8sPbF0GHBXfGQnZMY7DIMEvj5VGRO2UN1xlWpWXSIKnegYKCW5KKY7k?= =?us-ascii?Q?mctTjSW7CnJvssHaT66RaMeJ8Ic7kb8eSXIej6/3ZBLcK/v9tQM/TuGKobMh?= =?us-ascii?Q?bk3TiiFMWqgy4287wM0oeAQ6WDT7dgttfuvcBigF6t+C5BB3gCCwfUp+211r?= =?us-ascii?Q?1ArbeAR6ZfvNb1O5sw7tPOVmcRyeL+cd/VrSDU+AJTNqP/FafWBpgY6QbIoZ?= =?us-ascii?Q?Mn64CQqY2t0zvhnPYE7SYMjlLI7UJq2nys0ZU2TNRjgVINqQdiGSePaWRuzj?= =?us-ascii?Q?6bAFzImV2VAAok96uqqt8zy9w6T911Bu78Vz0yHnL04xku8dGqwkOYoQN1sy?= =?us-ascii?Q?HEjmP/DOcQW/9Ca8onxMrklxgVWzplTOb4tgIsHe3GA3V2NTCIWXHqB2zdgF?= =?us-ascii?Q?f+uwZpdjMzjDhRleY55ZrSc9RsKRl/p8iCBuve2kslvQo4R6S7OIUfalev4H?= =?us-ascii?Q?kFshmm38EQNxAjYvI6YEqHE4U1hhXE49aqJcJCZ8bP5rH7y22T+J7QPWHbJq?= =?us-ascii?Q?aAUrDxYVe6a9v16PDpZcARjMZlfd2XYeIZXsAgHD3wdJAFuEe12EVxHjOqG2?= =?us-ascii?Q?st/+q5t08r/coDX4hAMbI80UNwD2/mrrkQvWxzqqiyqcZohPvs25SiVMzCca?= =?us-ascii?Q?TjEEQOJXxFK/0Kry1+KZgVCdTqT14hCz+QpAQqap+dwJcDlUz1KezzCnI4ah?= =?us-ascii?Q?z/HEXfoL92+PwCjXhZP4toPVj7WDwL2QgareH5Z5dkj3KiU/S91sjtBv/VDu?= =?us-ascii?Q?b7N5vXtiS6K87/+TxuvLvvhuMsy5wxhdnSwKTE4fvzxtuBMGGskcIh0rU8z3?= =?us-ascii?Q?xWkxLusxck/3JJxfzlP4DP+FiCYUIZ8q8uU43Ttp/jM/qu8QDLubdap/1vJg?= =?us-ascii?Q?MzGpxyQ5uuJLQDofdf/PvBpDd4JaCqbO/TPrEra1goSSCgOdKyq9JS5AA3AN?= =?us-ascii?Q?HsmFfq8HWDUpk+hhger9kEwBwBVLKqA1oXMRQzAZTI295SC+C7JWpmM+urxM?= =?us-ascii?Q?T7VOK4yw8w=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3e2134f-59ef-403e-37cf-08dede718c78 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 10:54:00.4273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bqH97zECugA6DRoENGppJs+dMb81bdxxiBkz+kTCftGhNPU+0weFlgquO2OCTFLsHuLmFljlGIgy0VJwZkHXaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU4PR06MB8388 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Acked-by: Eli Billauer --- drivers/char/xillybus/xillybus_of.c | 5 +---- drivers/char/xillybus/xillybus_pcie.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/char/xillybus/xillybus_of.c b/drivers/char/xillybus/xi= llybus_of.c index 1a1e64133315..46e1046abfca 100644 --- a/drivers/char/xillybus/xillybus_of.c +++ b/drivers/char/xillybus/xillybus_of.c @@ -55,11 +55,8 @@ static int xilly_drv_probe(struct platform_device *op) =20 rc =3D devm_request_irq(dev, irq, xillybus_isr, 0, xillyname, endpoint); =20 - if (rc) { - dev_err(endpoint->dev, - "Failed to register IRQ handler. Aborting.\n"); + if (rc) return -ENODEV; - } =20 return xillybus_endpoint_discovery(endpoint); } diff --git a/drivers/char/xillybus/xillybus_pcie.c b/drivers/char/xillybus/= xillybus_pcie.c index 9858711e3e79..32064b6c7627 100644 --- a/drivers/char/xillybus/xillybus_pcie.c +++ b/drivers/char/xillybus/xillybus_pcie.c @@ -83,11 +83,8 @@ static int xilly_probe(struct pci_dev *pdev, } rc =3D devm_request_irq(&pdev->dev, pdev->irq, xillybus_isr, 0, xillyname, endpoint); - if (rc) { - dev_err(endpoint->dev, - "Failed to register MSI handler. Aborting.\n"); + if (rc) return -ENODEV; - } =20 /* * Some (old and buggy?) hardware drops 64-bit addressed PCIe packets, --=20 2.34.1