From nobody Sun Jul 26 01:05:23 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5CDF4071F5 for ; Fri, 10 Jul 2026 10:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678924; cv=none; b=MjN2yKY0OzAzttwtJgfG1cUbiTY71kMzTxHW3HFNzgH/TO3UHxqwoMlKcBlqeO1029a2yyG2cjw6QSXi8ochQNs7lLf4rj3ooTFAt3P0L9npacAsN0VDVVtMc/aQjnyifbahnn3syfvnOwbDTNLR3J90i86lFzKJh4hnTL/My7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678924; c=relaxed/simple; bh=/lWqMzub7I/4pmp2JnBqOYFglVzfcpTB6DebdmZGAy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DAzlZqc9dogddZEa6I6mBF3Q0YKEMDoYKXth8ARGczZwrBFWiz0WMfJGWVk3hg/F7OFHvpw/NDIyZPkGLqSapL99f+HRbQcN3rK3xesb5qYQZnLEPLBwK/aBMxfQBOfzqHjHyGJZ3QwXpBZ2EhWKf9cjEA7nHwSsdhcesLiaJbA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MnyJJBN9; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MnyJJBN9" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3825c406ffeso798030a91.0 for ; Fri, 10 Jul 2026 03:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783678922; x=1784283722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V6S+nvthRJHE/gqft8+ojzysfQduu/D47Hr0LnA3Vlg=; b=MnyJJBN9kUJ7AAfFPA7rFS87pBQeQDi4u8NE6PCCyHTIPAD4EMUVoQ9sdeTGA+xnnz d90Gr0U/y3lUWc//GRlX8XwUsn2/W79IwHmKJ6FyosQt6/roBKgdcJgOwxj8ULDqIFWW Ek8jvxbSXaP6YMIo2iIS68R/KzqXxkr7U7/S8QyCil6fPKdV6JWj+9Hpf63j4eoeVPCI JTeG6hFozAr0FAse8WjkkwGsayE+o62SC6nTzg7u9JHph3iIXFs70WheDARNEP4teoxs +b1pj43Ya2vuUuoH6xxGznbSOXOI2fbMwxXFEIUU5nXdhRpDRzOdyGTDkpMiXx7wiflE W4ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783678922; x=1784283722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=V6S+nvthRJHE/gqft8+ojzysfQduu/D47Hr0LnA3Vlg=; b=cB7yak03sUqkY2Pkdvrzo2cNOr78qDlLubbu/i32FDZmDOg97w53E456LZbDaqSGCC iVub6fZiNz9mPMhEHFNU1XsMIDCAaOWkeXVQNyRbEplexUb0WG5ZRpigOrhjJN1kXciL k7Xl0/ZWR14aRJ0lYuYmfBRb1IqdYAhH+7qIWU9qaVhtbRj0m548KBCZZ+C0s9LWePuT tMaQrwHIgYr05SXSuPtBYrKEE94kzC6icfLnP7yzUDhwmFP3cN3Jv3eF7CQaclobaDJK 0DMGBRiwomIxET1hnPI0HyzWvp4t+W68R2kB7rJvAlmnPtAHYdPImthbj30OfZZ279zG /xkQ== X-Forwarded-Encrypted: i=1; AHgh+Rq4Wy1XiD2yuQG7WbWFjLdB+9l/XbJh+MylSJxAmig4lQTDvY9NMKjU3KLNteKlvWwYJkX0iO1LEoGBII4=@vger.kernel.org X-Gm-Message-State: AOJu0YyeQcN0gI9Gj5iCmY7V6sURcm2aV9W5vJsv+LsDQwNj8yxSAJU/ lnpcgiZRmLNdubvlEQ7RTrdX61TAlcCfHGpu8d419TxqTV5v86DVJNKQQUZkRQ== X-Gm-Gg: AfdE7cnphiLgDiNDM10hCcR0H7fxHHYc6CYk0ipFj3oCvLr6lSLnW4mjLwcS9IeKoQE X4waR7CjP2RjdsHaorjnOmaAOq5SgrQqDgm/xtu8TstpnY5yGQy+JdRjM5GyQtBdiwJKAR3b6Pm Xj6c9DygI5LqlnOeb1VIVAFH6xELrhnghRthxaCjB6WesrV77lU9ytct1Hwr6j3p6uOJ0ZLhaak CtyKvoubXXofAbEI5aij+vZO57Fk0dO3YqWxdltqLtHOwMEE2Ge6RFP1+ZgAMqAQlTHlu8UYM3w sbVKXNdjlHJ7RYOlmc2IvJlB4TcLn81FsylHEH/Xaj/nCFPw1N86q2vbOl/IqK13jkqHOmpFbNG qYtPX8oJ9RAEGhUqDn823gndkcuoQPkArdMJGa2a7ZGFc47ToT+DhLOnWMUGKvmGYk3sqefA6hN EI2xBIOnMgWoRJDUJLGP+zu9s6fAIo/EKW1EWoBZ7kCkfn6NS3nVaS6fB2tQ== X-Received: by 2002:a17:90b:560b:b0:381:bc6c:25b9 with SMTP id 98e67ed59e1d1-38943463158mr9847157a91.31.1783678922024; Fri, 10 Jul 2026 03:22:02 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5516abffsm2490240a91.4.2026.07.10.03.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:22:01 -0700 (PDT) From: phucduc.bui@gmail.com To: Vincenzo Frascino , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Michal Simek Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v2 1/3] ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error handling Date: Fri, 10 Jul 2026 17:21:36 +0700 Message-ID: <20260710102138.29347-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710102138.29347-1-phucduc.bui@gmail.com> References: <20260710102138.29347-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() for probe error handling where appropriate to simplify the code and properly handle deferred probe. Also remove redundant error messages when the called helper already reports failures, returning the error directly to avoid duplicate logging. Reviewed-by: Michal Simek Signed-off-by: bui duc phuc --- Changes in v2: - Add the Reviewed-by tag. sound/soc/xilinx/xlnx_i2s.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/sound/soc/xilinx/xlnx_i2s.c b/sound/soc/xilinx/xlnx_i2s.c index ca915a001ad5..0676da122edd 100644 --- a/sound/soc/xilinx/xlnx_i2s.c +++ b/sound/soc/xilinx/xlnx_i2s.c @@ -185,17 +185,15 @@ static int xlnx_i2s_probe(struct platform_device *pde= v) return PTR_ERR(drv_data->base); =20 ret =3D of_property_read_u32(node, "xlnx,num-channels", &drv_data->channe= ls); - if (ret < 0) { - dev_err(dev, "cannot get supported channels\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "cannot get supported channels\n"); + drv_data->channels *=3D 2; =20 ret =3D of_property_read_u32(node, "xlnx,dwidth", &drv_data->data_width); - if (ret < 0) { - dev_err(dev, "cannot get data width\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "cannot get data width\n"); + switch (drv_data->data_width) { case 16: format =3D SNDRV_PCM_FMTBIT_S16_LE; @@ -233,10 +231,8 @@ static int xlnx_i2s_probe(struct platform_device *pdev) =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &xlnx_i2s_component, &drv_data->dai_drv, 1); - if (ret) { - dev_err(&pdev->dev, "i2s component registration failed\n"); + if (ret) return ret; - } =20 dev_info(&pdev->dev, "%s DAI registered\n", drv_data->dai_drv.name); =20 --=20 2.43.0 From nobody Sun Jul 26 01:05:23 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BC7D407CDE for ; Fri, 10 Jul 2026 10:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678927; cv=none; b=YN+EUcxkwDGuBYLY67DVQxfZi81ujDSUCfYoIZBvHSl1fSeGLv1tKIXnFhantZjdWRipw4ON6kD73eB8ANMXqYaZ15uxw/k6yj07h5F0t3xRUyS34inGNg5wyl7V+NKVJREpi7NjdOfzDv+p6EulmWT55ND5bG1RNSZ440trahI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678927; c=relaxed/simple; bh=1FZVoSjzKMyVRnA+73pI8+UhFeytlac2ubKrBiaTzGQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nCQMZPWQb02444Lshd+CVBTeQiOJrol7tmlCx8zji6ZI/hnw1Rzs6GJlZaBJ7HNsq62edAshykiLqZxBZ+PxBkiL0cN8YYEFXkpd5qXv3LNGKcsMh1ALOTB0ksfmfTFkV7XXD6IV1M/omWyPQ374Ukg0eXzE0ovrWCjXLcVfG6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XPpil9Cs; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XPpil9Cs" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-37e0a189b0bso737566a91.1 for ; Fri, 10 Jul 2026 03:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783678926; x=1784283726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4RFOqWcsEwd6ePMQdZZ8QPUfPlo/GmYQwqUASim0itw=; b=XPpil9Csi1AwGks8HRKtC+TgroO0KPOlEAZWyrrzaO3oF2LRHvFnErRiR3iAy90o72 b3QAwLBgBwOj9uocxs3bzDJ3skZLZPF5KTmbXbGeQj1P7yuaJ6H9BIbVK+OojaU6yLL7 AbZ84dAC/f2ACv8RNpBEyqFve6S7sOC+iKBSznbqqfCrQ37wn2Ny0p8o7gr5WeSL/1mT xb+TOqJDntXLID29dmT9rinccz7+UzfURibFKSqyS1MKKdNs/ZCcb6jqg/+CXGYUkmBH oUN9uM7WxvqNG0jkhTVWWr+etR0L0GeqhxH3aXQBH2oDjMuK61feIBwWeTdGb2EN+6Pc CBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783678926; x=1784283726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4RFOqWcsEwd6ePMQdZZ8QPUfPlo/GmYQwqUASim0itw=; b=gem13IhMo8mQa5SChXoibY7ecylE/OHRbo7TGuOYXBAjuMD2e8geVEoObXJwnU3wUn yvVRQRj3NSEsl0ND0MBe4QizA0eKKjmWIngNXkCExWtqnkpxN+UzSG8uCtYLZed0p71e 2FayQlshAc+JgUoXfbFTReY4uwEy4GFfT+NxWKxvxgHu6C8HEtXxwf1lUD3DR3ol8qF7 7Dpj1CxcY/15V971b+Ekfzhjq1JvVFrRHSpKLSlGSgI19Xz0bkRYl+oiDil0698mb9Dn 9X7ymI3An2MflieIj/Rk4b8wLw2Og510KN8VHbeAWlS/4B2BSy3rJx4NuSbt4gONEiGU bGZg== X-Forwarded-Encrypted: i=1; AHgh+RqyhtG7O8qct2nzEow9wF5S3bMvAGumUueaSvqut1z4M8/nNZ1p5cmBli8vwTtF3X8B2yLXt+TjIBijBFo=@vger.kernel.org X-Gm-Message-State: AOJu0YzKNQFdGzr5mCptn1Zki3YzK0AY3aDmmoAkvnQ8GQvq01Qzesdi WOr8TQDl3ju1prLM81IH/C3UcM7qqrMm7sMxe/IOw7NmbraQfpisBxpa X-Gm-Gg: AfdE7cn1QJzeHHvIcgIb7ZCzcBmducYhJ1GJGW6szGUzUZn2PXIgQr6jpiPSHiqIJiS vTIf/ikfUXLT9yZWG9I8k4egB2duQV5hJsrLI8UQHEXH/oc60QBSeKV+pmg0quSzTBfLFI8Hywb beZF8Sk1xATYTr2bAihPU62XL3KiScPdhIFstBLVPLFCnoWVWmr2+ut6Sfw+Qmy73ANFuz6hoMj vEtE/mifafixoyfqdG2kX3nsbGunoeTWukKgIjis/6TOEpEfkPKJhV/rC/jTfUq/PDK8Haq8cnf OZFdiYvxXDAA8ATO0sXvCSSoeNdm0aKtX6jOswFacWf2yDH1Xnkgw4cekCBaPyNADi6Bndv1Tr7 ueqfpCtdIo/82SU3d+2bN405jQ/M+1ueqlit/H/cqMAmgh9WjEzwrMkBsI7eSiwlzvWBN/L7YkP FXMZ7hdRaLruPP7uhFhZWbl9d0CBr/EEgTtRQW9L9HwbbBXS8= X-Received: by 2002:a17:90b:2586:b0:387:e0db:bc30 with SMTP id 98e67ed59e1d1-38d6d1eb86cmr1754316a91.38.1783678925820; Fri, 10 Jul 2026 03:22:05 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5516abffsm2490240a91.4.2026.07.10.03.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:22:05 -0700 (PDT) From: phucduc.bui@gmail.com To: Vincenzo Frascino , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Michal Simek Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v2 2/3] ASoC: xilinx: xlnx_spdif: Preserve devm_request_irq() error codes Date: Fri, 10 Jul 2026 17:21:37 +0700 Message-ID: <20260710102138.29347-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710102138.29347-1-phucduc.bui@gmail.com> References: <20260710102138.29347-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc devm_request_irq() can return various error codes, such as -EINVAL, -ENOTCONN, -ENOMEM, -ENOSYS, and -EBUSY. However, the driver overwrites all of them with -ENODEV, which hides the actual cause of the failure. Also, devm_request_irq() already reports failures internally, so the additional dev_err() call is redundant. Return the original error code and remove the duplicate error message. Signed-off-by: bui duc phuc Reviewed-by: Michal Simek --- sound/soc/xilinx/xlnx_spdif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/xilinx/xlnx_spdif.c b/sound/soc/xilinx/xlnx_spdif.c index 017a64ab9f1e..deb7225c1b4b 100644 --- a/sound/soc/xilinx/xlnx_spdif.c +++ b/sound/soc/xilinx/xlnx_spdif.c @@ -274,10 +274,8 @@ static int xlnx_spdif_probe(struct platform_device *pd= ev) ret =3D devm_request_irq(dev, ret, xlnx_spdifrx_irq_handler, 0, "XLNX_SPDIF_RX", ctx); - if (ret) { - dev_err(dev, "spdif rx irq request failed\n"); - return -ENODEV; - } + if (ret) + return ret; =20 init_waitqueue_head(&ctx->chsts_q); dai_drv =3D &xlnx_spdif_rx_dai; --=20 2.43.0 From nobody Sun Jul 26 01:05:23 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647F4407CFB for ; Fri, 10 Jul 2026 10:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678932; cv=none; b=FTKlCHf+g2mivIDP8vK7BudYOzlAIDgPbOhSbHUEbuHR1FlbT8dM6XtH8DDARRZy9l2zLzwPThw+Clhti8920Q13KIEQG5Tl0LGZzWwmc97giMRsmYrRHPD1lu2b7i0h7rshZJUGqFfyv8tdJGLoFwICcxg0g7x+wMvArFHWWSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678932; c=relaxed/simple; bh=0A+xKWEJw2IA5pPYAvSYhbSRxxQoM65GpKdqqKapL+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=seS3H+QN+/e87MJxHzLMrODr+HLvlH0MSBz9i2A128R6zFAntwh1vUtkj9uPgXnyPqjp+Lv2E9BlM6rf4QRRhuWr9GkGHCYfp2CsKseRIL+y0Fu/L6F7i6ZA0uZpKVJTapzFGPocSohJ8rj8AUcgDK8GhdN6vKOZW40FO3VGAEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SFXifyhN; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SFXifyhN" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-37df72c9984so1267375a91.3 for ; Fri, 10 Jul 2026 03:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783678930; x=1784283730; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Oh5hIJ+7O2JY7qrrtymOMkiruUIettb3qb3leyRUg7M=; b=SFXifyhNokJMKjkBNTnr0phEIpAVhD8blKsSrDwhwbmhi5c7aNwBMcmz6nZVJTw0qo tZI+v4Wimmd9EYVeN3/o+1/QJ7ZxO5m8w/hVSOidIpUz3SXfhbJQv955A2o8wzpvM006 XnFtW1ubkq6In3cas4f5pamVTqSkdXY0nNfzK6aluLJzB36wqmrKOkHVHCQsBGjGVW1J U/9+Untnzpkuhf0u6VFWc2/Z69HSNg9zvJLGge0fe2SIJ5+X8pdhcfJ2th2cbQm63BV2 sQH8RSlwfHOv8ms1QnfVJ9lEJOMzxJLDBcD/RyIFDTPWoGqNDrkcETOBJPmokslxIqgp H2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783678930; x=1784283730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Oh5hIJ+7O2JY7qrrtymOMkiruUIettb3qb3leyRUg7M=; b=RGzHS4CczN4D62GhZ06e39zlPFEnUJ3AzPHdW9cbjpPtsLcXzcCccLzgBuGTaW3+L+ yiqTQj58ZpPMUQY8T0g7sZ0axUT5rOZRMgcGDtMr/nmgizwYoHqp+p7P7iukc3fIRhUv QplV1SnfEGXAu/UC08yzp0wfLhr1O8QSFhtz6vXAkhQLLq4PBfHLmFl2LeiS7XZSRArV HWDDU48qUEemTv+nu7t4MFyK1r3wC7UYYIL4wbaMchfdTOHegT8iea7gwlyvU7h5G+Sg my/Xth93Ufs54/MzgwB+fGGoulv9zUmoRL1ndOk6zRjwHSIDRVGttVUZ1jp1PzTF9svz KuQQ== X-Forwarded-Encrypted: i=1; AHgh+RpRNsx0PehF9oE9+cprlrgv3ImEjZrCAlrJF3AWBkXSyVwpcRtT1gfXds0I8Gae0ptbsoy1VXvyjh6AOPs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5Ma0QfPlY2+Q5fFlWoV+R1HpAedhIIS7YLlyVTUkb3FkOBC0h 9XDdl/XD+zz0188Omnhi4309jLEOyH0G4X8xGJ7hENdMTiEEnx3rzt+v X-Gm-Gg: AfdE7cnIvA6g2jQDPCYieuEnxWulWNHKlm7frrQrmThmO3XIsUYwxaCJ8vAcBXz49am OWvX2FNubw11IdzWRhh9Ykj0D0sbVo+mUiZSb4sG7vl+VB7ywh/lmFDFMCRvD0XtNvbUS/H8Mlb R5MdYLlFRR2euXblYt5RhUivLcsVbjHOd/V1nxA0L5d1fQ4S+k2jjpPIUEXGW2ZX29MrxX1W8OL 6jCABmAf0xV0qfIxgLC2lQvbOl6+tN+5JdQcb+QtK8dMduibMfKmOVcoE0mG6gdEgtCkMAA6/l/ ARmSGQ8gmCE2O5/ifwwgpjqRQM6cqC1cJJc5B1zyIrcPfaBlWEVv/pBR4/LDiGkB26KaFF6RCQU NJ1ntcNhw5awL+WlxUabKCii0W81XKU+Uq006TRJvJAcl5pSFo4mtrAOcXs/fxpzWHq4ER1hR5Y GmFxeG5mfWc56TJR2SjTg/yvQmQcBIDNSuOIAjG0rOVfbsKLA= X-Received: by 2002:a17:90b:3b45:b0:380:71eb:4014 with SMTP id 98e67ed59e1d1-38940731d1bmr11115641a91.15.1783678929613; Fri, 10 Jul 2026 03:22:09 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5516abffsm2490240a91.4.2026.07.10.03.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:22:09 -0700 (PDT) From: phucduc.bui@gmail.com To: Vincenzo Frascino , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Michal Simek Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v2 3/3] ASoC: xilinx: xlnx_spdif: Use dev_err_probe() and drop redundant error handling Date: Fri, 10 Jul 2026 17:21:38 +0700 Message-ID: <20260710102138.29347-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710102138.29347-1-phucduc.bui@gmail.com> References: <20260710102138.29347-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() for probe error handling where appropriate to simplify the code and properly handle deferred probe. Also remove redundant error messages when the called helper already reports failures, returning the error directly to avoid duplicate logging. Signed-off-by: bui duc phuc Reviewed-by: Michal Simek --- Changes in v2: - Adjust line wrapping. sound/soc/xilinx/xlnx_spdif.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/sound/soc/xilinx/xlnx_spdif.c b/sound/soc/xilinx/xlnx_spdif.c index deb7225c1b4b..ae05818ba064 100644 --- a/sound/soc/xilinx/xlnx_spdif.c +++ b/sound/soc/xilinx/xlnx_spdif.c @@ -249,21 +249,18 @@ static int xlnx_spdif_probe(struct platform_device *p= dev) return -ENOMEM; =20 ctx->axi_clk =3D devm_clk_get_enabled(dev, "s_axi_aclk"); - if (IS_ERR(ctx->axi_clk)) { - ret =3D PTR_ERR(ctx->axi_clk); - dev_err(dev, "failed to get s_axi_aclk(%d)\n", ret); - return ret; - } + if (IS_ERR(ctx->axi_clk)) + return dev_err_probe(dev, PTR_ERR(ctx->axi_clk), + "failed to get s_axi_aclk\n"); =20 ctx->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ctx->base)) return PTR_ERR(ctx->base); =20 ret =3D of_property_read_u32(node, "xlnx,spdif-mode", &ctx->mode); - if (ret < 0) { - dev_err(dev, "cannot get SPDIF mode\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "cannot get SPDIF mode\n"); + if (ctx->mode) { dai_drv =3D &xlnx_spdif_tx_dai; } else { @@ -282,19 +279,15 @@ static int xlnx_spdif_probe(struct platform_device *p= dev) } =20 ret =3D of_property_read_u32(node, "xlnx,aud_clk_i", &ctx->aclk); - if (ret < 0) { - dev_err(dev, "cannot get aud_clk_i value\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "cannot get aud_clk_i value\n"); =20 dev_set_drvdata(dev, ctx); =20 ret =3D devm_snd_soc_register_component(dev, &xlnx_spdif_component, dai_drv, 1); - if (ret) { - dev_err(dev, "SPDIF component registration failed\n"); + if (ret) return ret; - } =20 writel(XSPDIF_SOFT_RESET_VALUE, ctx->base + XSPDIF_SOFT_RESET_REG); dev_info(dev, "%s DAI registered\n", dai_drv->name); --=20 2.43.0