From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020113.outbound.protection.outlook.com [52.101.229.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C0B43EF0A4; Fri, 10 Jul 2026 08:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.113 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671325; cv=fail; b=k+peyVHG96unQ6VCHr3o4fdt10icdevj++0wDbxEuk+xSiVvzklBAf7gKRCC0G0MvAbcVcPP+Sa2mzCpvYTZfVO3kpxP1A+HYmWiTrXJEKoLiqwzSTAmBq8sylf4fTlvmVKN2Kk4aF5ahgA1b57MRNPnrW69DtsY7QcLANRMGM4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671325; c=relaxed/simple; bh=FXct80RiQtwmL69ryA3inHdFfh0FY5rJ5BbnMSKqfKY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=eQqgjqnU8QIUu52NSv/0tm4BwDHfUY3PgsS2Z+bDD5sFHYv6QGRJp3GMHf7ZuQxDXocRhwEuuP1ChU2Ev10Jw5c4vMrwXc01Tk95QMQi5P3UH1MIG51jmfBNChmgzWW0yXJAu+L+aTb6QL7Errpsds2fYlVim1rGp9l1aeM+B24= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=QdbAiDOe; arc=fail smtp.client-ip=52.101.229.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="QdbAiDOe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PAbkh2SiBFD/jhrPfyBMwrXg6a5/o+K7qJhocUC7GUaG/cUrnGS44RdTVCTrTcVgcysN1E1Gx35Z6BAyLjgIHyJRWqhca6a1Va7w4OWffesNiSOVAZXmai7btIAMwuI/72ptFgXljVl73P5mnzxP9Hv8ARtLj+5JQlCNImn1UWWfzFI1G8M/gsc3sQV1Y7Yky7u9/0o0fuEeY+2YiMbmV0x6wmVVNAKRv08KEblw+UI0n/D0lEwzCPknKMWCev2wfdaJ96PCodMGqNAB91WaRbTQQShgTK9GNsHH61Qq58uMOWmaCUqw1rcmUVZXwp/uvOI+Bt8PLDQghzmnvVN/sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gpRR6C4VAWl+e6BXnkSZz6l8XwK7W/6BOWR/jQIgsE=; b=Ok2nyWgOGF8Eic/Fy1VinSea/Npz9cGMBY665CPm+M8Dy/hpxyOm9Cxl2XXQYEoSBQ05cgGBINxwNrqIGBbms6XpoHr7iN1l6znkH3tgV+BsdAK+WN0TP1HV8JYstzgaDYwWFdl3BxLhZd2lkICMlH2nYzHx6cyIotGSBt1XGfbiwlAdPfxum1CSAj2ftPkZnigST2m8VUJH9Ju01XWFWx+wP14hla9ZONQbQPjBS6hBEw0DA5lTR+w8urz2hvKg+BYc16uKna6MmCSlE6YH/afD0CJJkl+o7Ho5DlrqeF+Zk5EHkxm49iVkKieAqhZOAfSDCIlvumQ+CFMAtkRY3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3gpRR6C4VAWl+e6BXnkSZz6l8XwK7W/6BOWR/jQIgsE=; b=QdbAiDOeEMiGbqGtckQP69K7LZxJmclNlGQpgrIu0Hvbxry1K9tPICt5M9fFb8Gw6d79jt5EAbn5WWK5J5NI1POi+3pYq4Bxm/zhf09ARJvYdOdEQfn0hIiZ0Q06svm3LoWCSx1I0ku53GfzReMrucdDFF5m2uttgZ0hWmH1r8I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:21 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:21 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 01/14] dmaengine: dw-edma: Factor out HDMA interrupt setup helper Date: Fri, 10 Jul 2026 17:15:05 +0900 Message-ID: <20260710081518.2394357-2-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0090.jpnprd01.prod.outlook.com (2603:1096:405:37d::8) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: 33f6bf2c-31ee-44d9-11b8-08dede5b62d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: IG5vOWzcsEt2HTgoseVO3LIbx9/sccGysapfbzKINISCFxIbkh/37mOuE4Xd19v3zWT6kTc/2K0+gSO+01MyN8nICPVb0VJ9lBGp1zulz+ca0Hiqrmjm3tMTb7nWYSTbXk/6HYoNWK/XGWldTqYWtCoCZduE9+9tHsx4OIiXZ7LjZcdbo1uTtpS2cu4o1QWNAs+w0k2x+pIG1JfVH6gKNyfOjCm0gU2XCTRHeQae62CGm8AIFVRpxZS5gz24O4WAVWf1jnVEljfBFYKPnnAnZ4iZabBLNWPs3R2VhSwonrNwWFJH7hznFbqmbb6+s8IKh7OO3L/7852XMXBsxOHTAv6OEacT4UwyX3oZhnE4T/lGG6ZhraUwlpQ+zP+tcOBfNGgxXv53eMFDbZ2ZnKJ0HA0hn8YNI5z63K1rE1ufxbhlv+plgXe4bZ5Zf7YQ2S6aXqDDzs8ds8VUznaam/A/5/P0qqEGwNog4kPSbprc8EMaGKJAkx96fjPCF5QuI0sFJA6VPLNHndxpzCE0/Vo6+ZNIm3wfbbKyEJJtq+HccVMck7KIk/hnQIBHMW766aMO2Fu1dkrrXBZbN8xO5Vgnc4rNY7NBVvWR+p6tQ98TCzFsbJEbOW6lGAs7BTGvh0cT6Lj5kqUeQ3nH1BFDyAA98MWcH8N/+wBdYwcePFrNE7w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ek229Gyryj07bRluMEMwMf7a4h07tBx3QFrTdXkkJ9O/M3Uzd8RXwINKLOhQ?= =?us-ascii?Q?9nuIw+bNEwb+z88JwfXsiDQ6RSyL1M3KTmrwJLDNAmZsx1PnD3XBYSTgsDF8?= =?us-ascii?Q?oNuq0KoJ/WYNtp4Q/1xub8L7rTDanN/Tr6zOuv/F8ABRdmBHaDX3+wibr2ak?= =?us-ascii?Q?zfUMQiqpMRY0A98fWuahRnhxlVvPIuoksm4F1qxabFG3wkAVYVlFkThdNRb/?= =?us-ascii?Q?XgPiSGIZw+pY5vhLFgLteFqtPsEps1rLWA0EtXA8z6/CuqEIH857VVpelfd5?= =?us-ascii?Q?6JJrwxFV1aiyYW1aszNCYNM1sieS9DJt55f/YR/u+Sxexzgc5VN3vteaxZYb?= =?us-ascii?Q?wwDkJj32v0f36h6gYNQCDHpjNKXQlnUZdXux6+nYsAFb3jTJUm6Pqcz4Yp+X?= =?us-ascii?Q?wSqBt8MiFK47d6VNItGK2a11fukFkPC4PwaCF10dCUxVGtPMksYCMJyKTmoR?= =?us-ascii?Q?eeFwFkTyc3GgJLC8Mej4Ab9sTgt4fQd1wMFK731uJ3n9ikXiS3mixGtOX2HK?= =?us-ascii?Q?I99fz58SMEpJCja+TVlsbt8V0DizLPZGgv6xBibDIwMqKgpAzfiNS/0tYvr1?= =?us-ascii?Q?q7KYIxkqW2PY80zHErl8AN32WbxTuWA3/B7jDuh/vzq4uGNryuyOTMYR5Wt1?= =?us-ascii?Q?qH/rHiy3KAChe2QzqJ2W2+N0V5Xv2Ml2HhDQWen9SWgdEDfwWhkACLKIzUGd?= =?us-ascii?Q?Lp9o4+AHkfJ801z7HhWx5Plhruk/pVMk91jkPgEML+yJjW2qp2vTpZQGJiWU?= =?us-ascii?Q?kQ79cKbRbO30LNDo6hmJ2Z+fIYFSo/oGiz+xDWvYR3bURpEWPWPxGACR1dFb?= =?us-ascii?Q?Mjfe5A/pCtAV61LGNFJ3Y/SgG/W3jtlLxXL0kpxvaFWKuqjTIzE5T4OKnCjE?= =?us-ascii?Q?6uifZ4M23eXuMF15+w2VHXkwAT2s+NLWuPd9hZnBAUWKeVwcVO+RzM61mgIv?= =?us-ascii?Q?s7fLR5FxaKgE0m2vrmUWZL5Llaw2SfUn5tvlra5FmV9HCr5EKDRNyyEcWd0e?= =?us-ascii?Q?8Y3S9Mz/q7FPwSQ0kXv+awIp0zPkatx6Eeac3HTo5wOS1pdf8NK1FjEDDdAa?= =?us-ascii?Q?uqnw+mVXrUKPTdVhDxDecbwHk8JrxRAWlHkIf6iPM7hkKST8by1F5+AKpbcT?= =?us-ascii?Q?1mVbZaWt1lFrJmDRmEBTg9ViTbKxho4KrNvNXSspv4JHa3w0F2WXY9ipP1tz?= =?us-ascii?Q?2ZvRFb8yaOSgxyM9RlLlx0IaUFyviFSO6uPgee8h/RQXTGaGlxOPHdwIHxC0?= =?us-ascii?Q?3tcpL7ojEpqDE/XSgdikd6PfDeLeEWuAs12LJp35T4R54rGrVMraorZ2h79+?= =?us-ascii?Q?DlIQBHJUVlGqqhUOqLI/zY03pqBLyuL7FDndbzAUMmUDKNLtH66aCPrDGidi?= =?us-ascii?Q?DOC6+t7JbFmxmCQQ3anMCyLy8jqfHZ8It9XBp0PeGeFYd8yCscI5IH8lEXxL?= =?us-ascii?Q?JnDJFeZt4PJw7VCmBGQQ1kP6My/7lPtEEXG+LQ46HA3F75PVSTfFxvbdqUJk?= =?us-ascii?Q?KdWPQlSrSgrV/FFpip+vmZ2O88zHhAl4i83BgOlt8oGQrZ3oYMCJ1waS8KB3?= =?us-ascii?Q?kGcQ+1vKfDnJCvYxtMNx5ed4nB1dJ0YqoKWxWPJtpd8jpQT2Ch3zTKQR1oLX?= =?us-ascii?Q?XcUFwdjVPnlCnnwc9o4VOBkG+0G/Vo0K7DOSAGk2v2Zc/zADM9TRpsjTvBtI?= =?us-ascii?Q?9GBlHar1sJXzFQzdhxYZpCJUAULm0Aj8uGrijygxeaKIuEDJCPBr9CyoLYNf?= =?us-ascii?Q?Fz4hj1D7aPhJ+vcH/xgejtvKsO0liE447thXH971Mp2sgrnPSmjS?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 33f6bf2c-31ee-44d9-11b8-08dede5b62d0 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:21.5053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U6zLJsHORn22aSI8aWLRS9YoMIlkeWZ8DAwVHh26aqV3ehsiRaHf8RgbIHWELnoUpdjc3mMGMp30OL+wM+DMPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" The HDMA linked-list and non-linked-list start paths both program the stop/abort interrupt setup register using the same local/remote enable policy. Only the interrupt-mask handling differs by transfer mode. Factor the common setup into dw_hdma_v0_core_int_setup() before adding per-channel interrupt routing support. No functional change intended. Suggested-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - New patch. Factor out the HDMA interrupt setup helper before adding per-channel interrupt routing. (Frank) drivers/dma/dw-edma/dw-hdma-v0-core.c | 34 ++++++++++++++------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index 2beec876b184..44e7b6c1263c 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -50,6 +50,21 @@ __dw_ch_regs(struct dw_edma *dw, enum dw_edma_dir dir, u= 16 ch) } while (0) =20 /* HDMA management callbacks */ +static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan *chan, u32 val) +{ + if (chan->non_ll) + val |=3D HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK; + else + val &=3D ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); + + val |=3D HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; + if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + val |=3D HDMA_V0_REMOTE_STOP_INT_EN | + HDMA_V0_REMOTE_ABORT_INT_EN; + + return val; +} + static void dw_hdma_v0_core_off(struct dw_edma *dw) { int id; @@ -238,11 +253,7 @@ static void dw_hdma_v0_core_ll_start(struct dw_edma_ch= unk *chunk, bool first) SET_CH_32(dw, chan->dir, chan->id, ch_en, BIT(0)); /* Interrupt unmask - stop, abort */ tmp =3D GET_CH_32(dw, chan->dir, chan->id, int_setup); - tmp &=3D ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); - /* Interrupt enable - stop, abort */ - tmp |=3D HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; - if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) - tmp |=3D HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; + tmp =3D dw_hdma_v0_core_int_setup(chan, tmp); SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN); @@ -293,17 +304,8 @@ static void dw_hdma_v0_core_non_ll_start(struct dw_edm= a_chunk *chunk) SET_CH_32(dw, chan->dir, chan->id, transfer_size, child->sz); =20 /* Interrupt setup */ - val =3D GET_CH_32(dw, chan->dir, chan->id, int_setup) | - HDMA_V0_STOP_INT_MASK | - HDMA_V0_ABORT_INT_MASK | - HDMA_V0_LOCAL_STOP_INT_EN | - HDMA_V0_LOCAL_ABORT_INT_EN; - - if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) { - val |=3D HDMA_V0_REMOTE_STOP_INT_EN | - HDMA_V0_REMOTE_ABORT_INT_EN; - } - + val =3D GET_CH_32(dw, chan->dir, chan->id, int_setup); + val =3D dw_hdma_v0_core_int_setup(chan, val); SET_CH_32(dw, chan->dir, chan->id, int_setup, val); =20 /* Channel control setup */ --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020113.outbound.protection.outlook.com [52.101.229.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD883EEAF8; Fri, 10 Jul 2026 08:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.113 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671329; cv=fail; b=gAwj7fMiYmS47PE+m2cw1/b22u1gEkSy82gmiQA7y+Y4HCIXHIeyKX0UFEvC/eOqcHU+1h9k5aqmyDb5vNBgTrHpWJ9epxpG9eI0FPq5+ccOeLt38OIlPtesNyAZL0zC3VjwZwdlybwFBSfurOhJdGeQPfD3NCY7Ifl//xJ8fD8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671329; c=relaxed/simple; bh=JaRFpR0IAKujDYdT3drbkPWtCiMhrql/GH0fPJnWPLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=pp+D5frcZgnH8pfavy74HdU3TfBgce/1tfmkczI2241pp7rVc/puV0wIaZtudBccENtUvOG5zsGymksjBjLoaCJz5RHazTTlrDy9aI5sj2CNSCvlKO+dehRThrzJAafZykLhWEduRNd/tVK492Jhx1DNd5Zxx8YYT0PcCFlyd2o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=PbixA+bb; arc=fail smtp.client-ip=52.101.229.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="PbixA+bb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vUTK5Hpj9hGeCPbuyXF/aINibL/RPpB1jJJ8K8ILPvr2edoNuF2eqrTePeX8mafVIFmRU+z8ncp/6oQPvA/yHzxrnQvyBvsFM9GBNcZa4s/H9vD1D57G+uvMs9e26ARIO3GjcEeVvizZBE1eCKI33FiJwbwR8sP5MHXgCBVUXm5kmOBvZ+FogbjcuMfBmfPzEbE0NFs4rNdHu9DplpCeiyHregHQsHviFfk+2NFJMDW1LtUryA6Ed701l7jEPliarCGXqoQMzKdIZ8QmSUMQK97nJ18sYgTKy66a7bjhStqKOQdzqnZ/PRj7pzBI5Y+Yr4faa/AVaEGNQ8Gg8S4+MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8VFhAouUSDfsZ6di4Wy9JZbjD6EcSxLsHy9NBMy+RE=; b=sGULJXIe14so+2YGQHG3pG0JZwWcWYGC6nIXLlKas7nH9b8bnGUSdQxzHBRN86DyBD/F0ZWwaqo7OFMLNGU3XbAcEr9kxAm1TGPKSynqL80JXZBlqnhhptA/AiTdhWYV9hunC+98yQlFU3v91AcuHifc4geimIZ+8paDwXR6NwRRqmF0iPXCt3EXd600nGmBM/IO2VfCUXIQm9exGzBHsCJsR0y7Mh6FChvNrx9PI5is/JrlB30RMgnNs906QwTN2jrcAM54TXDQuxL0ClzMAjpBYMfYusW0qegV8CfcGWnmb9/MxArRQ7lNkvvOB5B6O1OW3FifWgNiiv7UVfj8kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V8VFhAouUSDfsZ6di4Wy9JZbjD6EcSxLsHy9NBMy+RE=; b=PbixA+bbxgPk052L223uTGpaNAeRGNtwOaMHIRCXlCjGkF6P3EtnAMMQ5mMw3WpJuM3yRV2LuyXL9frBFAZh3NU8JZ5hrEZdb3F4v244SZbyB0ZF9g+hDpT3Ucu3CM70m/R+9C3R7aKfb43ZVZ4TEYmtdiRpSYeiJaeI/rpDOBw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:22 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:22 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 02/14] dmaengine: dw-edma: Add per-channel interrupt routing control Date: Fri, 10 Jul 2026 17:15:06 +0900 Message-ID: <20260710081518.2394357-3-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0118.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::11) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: c042a292-28bc-4360-2de9-08dede5b6349 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|6133799003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: iUTqwChWSWTKSrj64EYbG5vh6hRNEA/eMJru0Tn25YS4VkX+Y6XyrlRWTPd8VOy+AO+KUylKhpWQudIpUKAdY0wWZvx0Wgc7ebzYZ+rJzaVEg/DFHNOzVuaOv6xsH9TzI47IHk+eGSjj1fqRQyZL9jzqsbETkvTCrDLwlwWMwaKxMpU1t3wHavFoHfl8b+oIwhiBVKDaRvi03O0gviYz2i16sCsHPPj2DU249djkz26Kqq/hRoFlQrQQcs5Gl1JZ/r2WsyhnuUwUAo2o6WoW2Yri+GdAkMOFDtX332HQqakADqCfmzlCy9vRZGvFtvPslaCM9wQse2NcnGVZSCwHJSzCntKDPy13SHLP1oNvz2BtXDcbXqeqg0jSNPhMRBmGtVhGV9XnPiHSn94jgtOIfLfOE3EiZ9yJMBUYvyv3twDayxgMY821YYN+EFn2khuWUCvvZx9Zi+j/MpUMFJuaB4V0UNa1Hcwe0mtmCfVZS/IJUVgDham68belJH6Fo2a2B60tauMYd3bh7stp3z14ZRnHrBkPeZDuoWi5Q3XEkrMM7ygFMCgHS0nUVZRs9oyuipP3ETr661Yw/UfxThs4A5ifhlb6sdqLbPxiu76psQz8vdvzaPyC6QTIlCJcRweUztc8XH4mH5a5GG/3zyDkER/sl3KM+BFAQVLo11ZotUI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(6133799003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DABWbN7j6aPo4AY2uQn6GKy8Gll1iCMFtoY3F6yfogiyrDsIwofErDlKOSqc?= =?us-ascii?Q?cKIfcEJdxQK24kc3cANldjo/Y0TT1bOa7JkznUqOfQ2a2Qd7MziQ7o58aGAw?= =?us-ascii?Q?zdG1o6PVtM1MtMo7b7C/7MlK5V3ZS6f6nK7Cu5Yi7C1KVsG3cSp/oms+UzhD?= =?us-ascii?Q?oy7khiYaX67QQ9QVe/uSZfd/J0buqpoc1MBLHKAOA0ZcVINA0K1mC492HCYO?= =?us-ascii?Q?9pqXh0+iFA1ze3EB2d/grTx833EKIsNT94XSGh5L8RaX4GvLTE2aGyJULKak?= =?us-ascii?Q?ecDUh6Lox1fQRZfmfrBPwxQf4ruEnkPVtzIgwkFBJ6KeXXycACoaFRnpCkuW?= =?us-ascii?Q?6a4KAEc7+LUQkcOMX/91Co83wZ5d3ByUIZsmXVvQB5GVbj71am3EDAViqjD4?= =?us-ascii?Q?nSxC7S7nssP0oSAqf5mPWBJ77pFy9l4mYqf+q2TROEG7moPjPJ6KbIKd0U9j?= =?us-ascii?Q?19kJd0+qbDQuqYXouienx5C1QzSYnIe1/8t/WefeK7e7ma7R1ESQ83AzVjBI?= =?us-ascii?Q?Wgn2ekaVYNPHRVMlCy6WnzR3pM0/mjQvbjE1+dE4n3Txym9WNnIYjEyeaRfU?= =?us-ascii?Q?n/GSiDRh48KnRyq1xoG55Zii8E19mRVQkZmxqi/8qpovNVzdKhpxowJYyUqg?= =?us-ascii?Q?4w/XRfbJZpfYQtavf23NZVlSWafBiLoso/6/IGV2KlLWuY91vcybcUqvh3qy?= =?us-ascii?Q?hmBhvhUbxeYlT3ZDs0eQDDxR1/mz0I74f3gkPlufD0mCntXpm0wWEiu37nkG?= =?us-ascii?Q?D4jjymmVeBeJrJe/LrWbuKxcG0TF/udbTFPopSSyCQPrJy0G5/4W8K8OVX/7?= =?us-ascii?Q?afYaaiLvIXxnxYrd1l17EwdmiH23UQayvW0SpNT6g76zbujeQirgmpkVrmUe?= =?us-ascii?Q?DPrQP2VCR7pjifkwSKg3wqns56ZCXu0wAX+GV0uX6KkL02RqxYGW8NuDTjsc?= =?us-ascii?Q?tf5nODwvygH105lDk/RaPfblaPMvcML+Um5PSpdfv5228myFtPVlcpCyKRp6?= =?us-ascii?Q?xu4z37I6QNNHeNUz1qK+kkYyTcAWBuzVpRdqawlpuSsYeYFvvbAMZdZAyapp?= =?us-ascii?Q?uzblVdzLib8vC1JPzFAe3Tz2TesF5EldtfCOfshPM/Bb6WymKKb5DHSZyOv9?= =?us-ascii?Q?115igHUxbXCnuaxznrE8ZxlpYmNK0oCw/qJG8glb5zrCXjTLzi2+uo4qOwwW?= =?us-ascii?Q?QnUFYkoSYyTn21HMEjZl1vPtr8CNp8SmTUqoJJ/wu+fZEJfHX7lb4D8O3Rtc?= =?us-ascii?Q?jMf7gq1KOnqVwrACuBVht4fSqzJnviKPkS7wS12p8x5cztYyl0QjGZ/K7SXe?= =?us-ascii?Q?MvClSJfKl2mPUS2U81a5v34iEZPLj1GcDpS2w0VU7p3wtayScAIdDYPcBa3a?= =?us-ascii?Q?jcmFoxNXdodphC5cn3DJzqLxlTivbZJ43yAWlRMnIz7QHWzauV4v1mgIpU+E?= =?us-ascii?Q?pmtFbxd9rSoCy6zOqFe9f0rj3jnCb8laVbdmuBsVTzS2+QhWt2W23PUmJjRj?= =?us-ascii?Q?r8JWie9m+Gwl2gXDk9uHj2ZWs4LdroJ1L8ZsZ8Zfz/xkGOXna83tGnsvhHcr?= =?us-ascii?Q?6xcuJiIiRD+yrloYKKjkJp0NaemBDesmxdIsWV/2EgBdxovOMu/q+vQwXiP0?= =?us-ascii?Q?/ZF2peJJ/1AQHq0URaCQQR/Lsp2QcKsxGn942d3zZlT4zFZsaupy9Ma0nt5Z?= =?us-ascii?Q?+ZaiEH0xro2n3FSY4rEVrN/ygiR4nXGH4v5vzWmlauN0mmHbK5NiwtRj86YC?= =?us-ascii?Q?IK9r6U2adD1v1pi9t7fQ3qkgQnnFepCJGsgPyuhsg0YdcKbPKp5X?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c042a292-28bc-4360-2de9-08dede5b6349 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:22.3228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rrJj5tKgkNASbs68Nu2lyIsbIZxqCkximpKNZOpXmPJ1zEvT27H0v0vSAHQaOGz8KleluEavH0dHeqdK0AQ40Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" DesignWare eDMA can signal completion locally through edma_int[] and remotely through IMWr/MSI. When channels are delegated to a remote frontend, the local endpoint side and the remote host side must not both service the same DONE/ABORT status. Add channel interrupt routing state and initialize it from the controller instance configuration. Update the v0 eDMA and HDMA native paths so linked-list interrupt generation, HDMA non-linked-list interrupt enables, and DONE/ABORT masking follow the selected mode. For HDMA native non-linked-list channels, use the dedicated remote stop/abort enables without local stop/abort enables. Keep the existing dw-edma-pcie host-side instances in remote interrupt routing mode so their IMWr/MSI completion model remains unchanged after local routing becomes the zero value. Note: - The routing mode describes where a channel should report completion. It does not by itself say whether this dw-edma instance owns the interrupt status. A local instance must ignore remote-only channels, and a remote instance must ignore local-only channels, even if such interrupts are unexpectedly delivered. Otherwise the non-owner side could steal the interrupt from the owner by clearing shared DONE/ABORT status. - This drops the stop/abort interrupt masking that non-LL setup has applied since its introduction commit b7560798466a ("dmaengine: dw-edma: Add non-LL mode"). The databook's non-LL examples program the masks to zero in both directions, and with the local enables now cleared in remote mode there is no local interrupt left to mask. Remote-driven non-LL users keep the same delivered interrupts: the local pin was enabled-but-masked before and is not enabled at all now. Cc: Devendra K Verma Suggested-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - Document that a local instance never drives a remote-routed channel as the channel is handed over to and programmed by the remote side. (Sashiko) - Rename dw_edma_get_irq_mode() back to dw_edma_get_default_irq_mode() and simplify its implementation. (Frank) - Drop redundant dw_edma_get_irq_mode() call from dw_edma_alloc_chan_resources(). (Frank) - Drop unnecessary new-line drops. (Frank) - Simplify by just using DW_EDMA_CH_IRQ_REMOTE instead. (Frank) - Drop unnecessary chip->irq_mode. (Frank) - Revise int_setup for HDMA. drivers/dma/dw-edma/dw-edma-core.c | 10 ++++++++ drivers/dma/dw-edma/dw-edma-core.h | 13 +++++++++++ drivers/dma/dw-edma/dw-edma-v0-core.c | 28 +++++++++++++++++++---- drivers/dma/dw-edma/dw-hdma-v0-core.c | 28 +++++++++++++++-------- include/linux/dma/edma.h | 33 +++++++++++++++++++++++++++ 5 files changed, 99 insertions(+), 13 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 704d8f9746e8..1c6db2c381e2 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -255,6 +255,15 @@ static void dw_edma_device_caps(struct dma_chan *dchan, } } =20 +static enum dw_edma_ch_irq_mode +dw_edma_get_default_irq_mode(struct dw_edma_chan *chan) +{ + struct dw_edma_chip *chip =3D chan->dw->chip; + + return chip->flags & DW_EDMA_CHIP_LOCAL ? DW_EDMA_CH_IRQ_LOCAL : + DW_EDMA_CH_IRQ_REMOTE; +} + static int dw_edma_device_config(struct dma_chan *dchan, struct dma_slave_config *config) { @@ -1016,6 +1025,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, = u32 wr_alloc, u32 rd_alloc) chan->configured =3D false; chan->request =3D EDMA_REQ_NONE; chan->status =3D EDMA_ST_IDLE; + chan->irq_mode =3D dw_edma_get_default_irq_mode(chan); INIT_WORK(&chan->irq_work, dw_edma_irq_work); atomic_set(&chan->irq_pending, 0); =20 diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index a6a9ed09fe1b..3ea384706b1b 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -83,6 +83,8 @@ struct dw_edma_chan { =20 struct msi_msg msi; =20 + enum dw_edma_ch_irq_mode irq_mode; + enum dw_edma_request request; enum dw_edma_status status; u8 configured; @@ -236,4 +238,15 @@ dw_edma_core_db_offset(struct dw_edma *dw) return dw->core->db_offset(dw); } =20 +static inline bool +dw_edma_core_ch_ignore_irq(struct dw_edma_chan *chan) +{ + struct dw_edma *dw =3D chan->dw; + + if (dw->chip->flags & DW_EDMA_CHIP_LOCAL) + return chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE; + else + return chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_LOCAL; +} + #endif /* _DW_EDMA_CORE_H */ diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index 377812eaa110..14700ac42fa8 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -254,6 +254,9 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, for_each_set_bit(pos, &val, total) { chan =3D &dw->chan[pos + off]; =20 + if (unlikely(dw_edma_core_ch_ignore_irq(chan))) + continue; + dw_edma_v0_core_clear_done_int(chan); done(chan); =20 @@ -265,6 +268,9 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, for_each_set_bit(pos, &val, total) { chan =3D &dw->chan[pos + off]; =20 + if (unlikely(dw_edma_core_ch_ignore_irq(chan))) + continue; + dw_edma_v0_core_clear_abort_int(chan); abort(chan); =20 @@ -329,7 +335,16 @@ static void dw_edma_v0_core_write_chunk(struct dw_edma= _chunk *chunk) j--; if (!j) { control |=3D DW_EDMA_V0_LIE; - if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + + /* + * A local instance never issues transfers on a + * remote-routed channel: on CHIP_LOCAL instances, + * REMOTE routing denotes a channel handed over to the + * remote side, which programs the linked list through + * its own instance. + */ + if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL) && + chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE) control |=3D DW_EDMA_V0_RIE; } =20 @@ -406,12 +421,17 @@ static void dw_edma_v0_core_start(struct dw_edma_chun= k *chunk, bool first) break; } } - /* Interrupt unmask - done, abort */ + /* Interrupt mask/unmask - done, abort */ raw_spin_lock_irqsave(&dw->lock, flags); =20 tmp =3D GET_RW_32(dw, chan->dir, int_mask); - tmp &=3D ~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id)); - tmp &=3D ~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id)); + if (chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE) { + tmp |=3D FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id)); + tmp |=3D FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id)); + } else { + tmp &=3D ~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id)); + tmp &=3D ~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id)); + } SET_RW_32(dw, chan->dir, int_mask, tmp); /* Linked list error */ tmp =3D GET_RW_32(dw, chan->dir, linked_list_err_en); diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index 44e7b6c1263c..cc908ca24061 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -52,17 +52,25 @@ __dw_ch_regs(struct dw_edma *dw, enum dw_edma_dir dir, = u16 ch) /* HDMA management callbacks */ static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan *chan, u32 val) { - if (chan->non_ll) - val |=3D HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK; - else - val &=3D ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); + val &=3D ~(HDMA_V0_LOCAL_ABORT_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN | + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_REMOTE_STOP_INT_EN | + HDMA_V0_ABORT_INT_MASK | HDMA_V0_STOP_INT_MASK); =20 - val |=3D HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; - if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL)) - val |=3D HDMA_V0_REMOTE_STOP_INT_EN | - HDMA_V0_REMOTE_ABORT_INT_EN; + /* + * DWC PCIe DM Databook 6.10a-lca06 remote non-LL examples + * program LSIE/LAIE=3D0 and RSIE/RAIE=3D1. Use the HDMA remote + * enable bits directly for stop/abort routing. + * + * This is unlike the eDMA LIE/RIE and HDMA LL LWIE/RWIE paths: + * those pair local and remote enables and mask the local interrupt + * path, but HDMA stop/abort has separate remote enable bits. + */ + if (chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE) + return val | HDMA_V0_REMOTE_ABORT_INT_EN | + HDMA_V0_REMOTE_STOP_INT_EN; =20 - return val; + return val | HDMA_V0_LOCAL_ABORT_INT_EN | + HDMA_V0_LOCAL_STOP_INT_EN; } =20 static void dw_hdma_v0_core_off(struct dw_edma *dw) @@ -147,6 +155,8 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, =20 for_each_set_bit(pos, &mask, total) { chan =3D &dw->chan[pos + off]; + if (unlikely(dw_edma_core_ch_ignore_irq(chan))) + continue; =20 val =3D dw_hdma_v0_core_status_int(chan); if (FIELD_GET(HDMA_V0_STOP_INT_MASK, val)) { diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index 1fafd5b0e315..1007122d4123 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -60,6 +60,39 @@ enum dw_edma_chip_flags { DW_EDMA_CHIP_LOCAL =3D BIT(0), }; =20 +/** + * enum dw_edma_ch_irq_mode - per-channel interrupt routing control + * @DW_EDMA_CH_IRQ_LOCAL: local interrupt only (edma_int[]) + * @DW_EDMA_CH_IRQ_REMOTE: remote interrupt only (IMWr/MSI), without + * delivering local edma_int[]. + * + * DesignWare EP eDMA can signal interrupts locally through the edma_int[] + * bus, and remotely using posted memory writes (IMWr) that may be + * interpreted as MSI/MSI-X by the RC. + * + * For the v0 eDMA linked-list programming path, DMA_*_INT_MASK gates the = local + * edma_int[] assertion, while there is no dedicated per-channel mask for = IMWr + * generation. To request a remote-only interrupt, Synopsys recommends set= ting + * both LIE and RIE, and masking the local interrupt in DMA_*_INT_MASK. Se= e the + * DesignWare endpoint databook 6.30a, Linked List Mode interrupt handling + * ("Software Programming of an Endpoint's LIE and RIE Bits for Linked List + * Transfers", Attention). + * + * A local (DW_EDMA_CHIP_LOCAL) instance never issues transfers on a + * remote-routed channel: REMOTE routing on such an instance denotes a cha= nnel + * handed over to and driven by the remote side, and the recipe above is + * applied by the driving instance. + * + * HDMA linked-list watermark interrupts have the same LWIE/RWIE guidance.= HDMA + * non-linked-list mode has dedicated local and remote stop/abort interrupt + * enables, and the remote CPU programming examples use remote enables wit= hout + * local enables. + */ +enum dw_edma_ch_irq_mode { + DW_EDMA_CH_IRQ_LOCAL =3D 0, + DW_EDMA_CH_IRQ_REMOTE, +}; + /** * struct dw_edma_chip - representation of DesignWare eDMA controller hard= ware * @dev: struct device of the eDMA controller --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020113.outbound.protection.outlook.com [52.101.229.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E971B3EF0A0; Fri, 10 Jul 2026 08:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.113 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671335; cv=fail; b=LwthneXSkIiQgUTlOAagmKfAzSQdcbgzaMovUtQFZm4y166If5c+8rDKrcBHmRVFcDEEgTQt7f215UappLJaSreH43pTikXvGvo2hrWf0udh4OZFbHkvOYrsW+I8Fyaz4UCuGYc4JjSbpIL5LSXsfR3475afnkEOkn1lxyQxpok= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671335; c=relaxed/simple; bh=VVFnefC23ht7ed5Z8EvWeMmABltwyziozoQ91nmPUq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=HWDMmH/wRR+rkeXHuIvYMDXenhuozqueDv5GU/GWuJIiaUMwuBA2PMQF5C+SFiO6qPHIYAuxJVXMS5rM0vas6VWnNLXBkYYpiLq5drzxlffqmrnYikuitC9SCCOjK9juhXStEGt93h1kUCMWOv0G+3ZlrtDKJIaB47wseZEOCws= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=JIgiQJb/; arc=fail smtp.client-ip=52.101.229.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="JIgiQJb/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mh8krzVRmGBhuQBlFFUrRnilHVPztbbb6e21ZoLdoBS2suRiCKhgElJJVsnLnIiWmkbqrlsyBkTjsSlJ9uBVXlVZHg1o5Bkv9CfRvVZmLqgNiO4S9p1kbWX3Pw/gmPrZA61yXo9a+SqHJ0lz+AxaD8cd5ugFX/4g8AqVybNQd1DmjpeYH3CT2I1Eed05ZNRpDA4fXudQmsrf5J5FfxW2u9g6ldIX9IneASBnkwaJLEMCw1I+7zOfp0lBAcEmA8zK/Dm05Z7/7nEkuLvziRDknEjbWTeOMOySGp1G37cW8DAJ9dym4KvR2bYA9NnRQZ7zzeRP4bkhgA1XEFRoZv0+jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0jU7ei+6EImx6Vqpqc26AiUBf6tlF0kgTb/Ebs/4LaQ=; b=ccyVB/A7s5vCYtfIH51ww95FxXorFG3yxJ3kYhby9u131WfVgUZPXVK018fI+UkoyZjnB2/a/kQg+z46mH5zycNo0JdOlCHnV0y5sjJMREB9wFITi9H7OFjMa//PRhS4yKHkFaYclPR+wzIJJ58kCYpvWo2LH8XMNs/UW98EXhyZ8LPFV4SJ9BOHUDkiAcABt8g6PN+IxUigGYv807OHaIowzQmgdfZHMS7irzm3/JTRDJoREChp20wqqgJdiSCk5EBpNvDr2gqZYNMg6yVNdjPlE69xDaxZkxKNeGetnZdJ4TaXsPR1GiexRVFIZClALVsxyODGiSd1NWcKJR8/bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0jU7ei+6EImx6Vqpqc26AiUBf6tlF0kgTb/Ebs/4LaQ=; b=JIgiQJb/x5ac3/XO1/00mNybem8pf4/oNTKc/NumK8O0AmMCFtxW/U2PuUuREiOwpsesdhEJZp+YZPwoc6ouTcmmPz2/ojcS8i6KWwMbyS/Q+a2rEB0XzM2VY8rIC3G2jNWXK113d2KpfEqsfg1urQKMqcEi5mRTGfKRC2fmFzM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:23 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:23 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/14] dmaengine: dw-edma: Add core quiesce operations Date: Fri, 10 Jul 2026 17:15:07 +0900 Message-ID: <20260710081518.2394357-4-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0097.jpnprd01.prod.outlook.com (2603:1096:405:37d::10) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: b3bdc1ac-5810-4443-8a9c-08dede5b63c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: dkC60PmsZ1JeR0ogk+PXU9U6D4SXHgwGMJJ25YVZ6fqoHXY5S2+k34Int2OYpI0kRy0XnUqMllkQgz5kj8Tqh3DBtsUEm3U/HHLOLJGXrCstxTI7Zd/oli/PviPXFgz5ab+Mqabd06j+CNv6S+j1TJKFXdvOWhLQ8UgEoOV+qFBBDXZEk3/oXPVqqembWhqogCTMRrFa0YZskKNiY1jtKlPXj52P96/HsJjQkJ8h7lgSKz+H24ZiNlH2edOo9mOpQ+VKy48e8tdUUzVz+lAVY7nKGW4Xc+98VzW/49E/0ny/HPqdC4L3DkG9Ku307TAzGQG+ZwJTXd7B/7v3qVsHuECjJgqj9M00QinTrmaLco/p/kRMZyWoj8oz29obMnAG35jcNdgKLuTiFNSzhpoNSo5IvKxbOhWCItPweNjNliJKekc6f+jThax+PaQ/qWcG5Va4EK0nVNK+T/iZCwtl+HPhIw30FGqRbHTFj0UrYrlVcAE9U/1FOScx4goToyPhrHWWooVRvBeL1l/N1WTWFHYNzwC+WltYo98Op5y/dw00YV05IEtLaZ3pSj0zxuUOqxhMZ4kBZ5JyK32+FkkLQNxhPzQKBmNBkLv6UKX3l4eQK9mt16sdl89gxEQLHzoTfwCmYezcsyKNidVrA1o53kCRDKjuYRX8pp+QeohfJz0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AFFoP2GzzyAG7TZv6vwHcIpVtukazjzkKbR3s9M/NIDm4BaXuCewcZOVWDvd?= =?us-ascii?Q?D+fObYu0ZGLyhxF1qDBZ+Yc+7Tn2tGW1T8n9kPiql7xfHweZq6ob/LG1pmIy?= =?us-ascii?Q?nA6AqWT9/9lybFHx/JkqmVDupo9xZZuWG9qyrOF7JsnrMsQ9kcL7DuTyPdSx?= =?us-ascii?Q?7LSXMN+W191BSsXOxwDdisc+3JB7boaZj7ofmZjPWhL8oaB9uoaExb50frYH?= =?us-ascii?Q?MDMwFXozBoJI+5kzyDU/ytrp2zVPxxvHUfCpFIdVBboao18MZjRsxfItOckN?= =?us-ascii?Q?oz+ifmpYSOsJeOn+STvayLP67U+4pWTQi23LY4qNqyocbxg1gD7l3+mgWKzA?= =?us-ascii?Q?xL7+MRQGG9XtE/d+AFU7ficFSyeW9bg4PtNwToZ4oZ91+CVJlfoSfKOzVNSr?= =?us-ascii?Q?ItTbhwEx1ZlVJlDaMlQAhxPfL0AFhD91XxoTATbXXa6KM3TjE4r/JSQhNoqC?= =?us-ascii?Q?bUUo2Es9VNG54nHbtJPLXJ3P+GKRwnY25WTYG+cIO5EnPwU87nUnqVM9ETJ/?= =?us-ascii?Q?JZeQQ2kLlHfhc2dkpUjyyvoiDXyIZWD7pVoGUMxvsz6Xra3NBTDlcNhatnOu?= =?us-ascii?Q?68I0QUMI3I5gJco8vxJN23C5/4PJ0RuuWdt0Y5SvbteQpUNFULdjyisz5GLn?= =?us-ascii?Q?/5/ZFgIOgSZiin55DPXYrHbo6mZiHB5+PAfR05RdineXQfnQWMpzivHgprCO?= =?us-ascii?Q?bbpF3rP73vBOS+vteNYstJu7XZvLWmMaI1spzxDog5y2zA9Ufz9jo1ktWFu1?= =?us-ascii?Q?kJ5IC1I0D9Erv/H2TuSuFNHdF355ehpfj0ZJnWRowjrLOkQeovbvHcLwVC/F?= =?us-ascii?Q?5ToWhjP83RYNKCXnJC5cz0LnMIMtWJc6vaBNP5tf9v1EqYc1vxnCfmhsi/6c?= =?us-ascii?Q?0pnwje9tdkg4fnGiNpTR5GAj0lc4oQaxIB1VM98kO4+3Qcr5x4KWkRECMGM6?= =?us-ascii?Q?GnvVTEddElGRDaxHB4+OBNRKr70sBMvKg6yBOoa4gl6EZWEBeSp9J1fwAJD6?= =?us-ascii?Q?aOMrJOwHjJu5Wl1E1sWgb7uFH+E0rddCP7wCePmfEPWhELnjkR1txVoY36bq?= =?us-ascii?Q?iyb345ACL+DCpjXr8wwFNdZlNOmYoefXaZjAHgaHX/jhBR+H+sEw6nEWy6fJ?= =?us-ascii?Q?mf9lIc5QgqbSdJWZdK7Ow757A21SnVJXHuVXrACDe1djUq1/okov7RK8simo?= =?us-ascii?Q?hzEdTiDlGFGrOFpwg/zk5hdLYbr94rpO3pg9IGw4irMmbZiZSSkJ/8wQS5EV?= =?us-ascii?Q?bqi2732JbwCk0KhmNY++nQSLDdUIvhtMbuKp9mmmALzP4iINwKDvdTzwJaLg?= =?us-ascii?Q?lcX2Ci4HckRydW0nPGzvPGc8V3ASWfZzOsRRPIWTxHJOBORoIzl/dvmxD5Ip?= =?us-ascii?Q?oPXtNytN9+MVrm9dcWqbAzhInFswNqDoerZ1ZwAyzoYbfeKNEC9ewI+c985c?= =?us-ascii?Q?HL7mhed3ORb9zulDdqVUP7ijiSpQLekR9sGO7sJeCPocdtq28NxKvwwJV3gK?= =?us-ascii?Q?s8d9ACrol9vrUEwvlO7Dra4Vi9WOp1HQ29oKEY/RPDK9adkvXReV5yUulZ+k?= =?us-ascii?Q?OoxEDKc2AlzRRaDC/hPed7W+61aSsxzR4Yy21mFhzjtMA0KZHeap1ir1ul9+?= =?us-ascii?Q?WBOxvS6H5JUneN/wJh9xRdvWW1Q3CT9+L38kKEXy+eueMmQYEonREsD74QQ3?= =?us-ascii?Q?7GuvaR6V7nc8ddpbrVlmRnfvx4/U3Xo0aQKfnus9gabzejmilFAnmXa3ljlH?= =?us-ascii?Q?Np2VqhQEg95DE9SeBc0f5k5qJHliXqPIk275+XaYacWrV/f74vu0?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: b3bdc1ac-5810-4443-8a9c-08dede5b63c4 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:23.1017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ywrf49FK9KiV1eaQx6tz7cMRA6oDCoQvkCYFxDUnNPr66Y203BDhHpaq1RC8xDrr1J3zBG1Ra4ILY5zk1UuLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" Add core operations that quiesce only the resources represented by a dw-edma instance, separate from the existing full controller off path. For v0 eDMA and HDMA compatible register layouts, quiescing one channel must quiesce the whole direction because the enable and interrupt mask/clear registers are direction-wide. For HDMA native, the operation can quiesce the represented per-channel registers directly. No caller is added yet, so this is a no-functional-change preparation for delegated channel reclaim and partial-owned remove paths. Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes in v4: - Mask and disable v0 eDMA/HDMA channels before clearing interrupt status, so quiesce drains status raised during disable and avoids stale DONE/ABORT/STOP bits firing on a later re-enable. - Drop R-b tag due to the change. @Frank, please take another look. - Document at the v0 ch_quiesce() implementation that quiescing is direction-wide and callers must own the whole direction. drivers/dma/dw-edma/dw-edma-core.h | 14 +++++++++++ drivers/dma/dw-edma/dw-edma-v0-core.c | 34 +++++++++++++++++++++++++++ drivers/dma/dw-edma/dw-hdma-v0-core.c | 28 ++++++++++++++++++++++ 3 files changed, 76 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index 3ea384706b1b..8657275d2484 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -134,6 +134,8 @@ typedef void (*dw_edma_handler_t)(struct dw_edma_chan *= ); =20 struct dw_edma_core_ops { void (*off)(struct dw_edma *dw); + void (*quiesce)(struct dw_edma *dw); + void (*ch_quiesce)(struct dw_edma_chan *chan); u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir); enum dma_status (*ch_status)(struct dw_edma_chan *chan); irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir di= r, @@ -186,6 +188,18 @@ void dw_edma_core_off(struct dw_edma *dw) dw->core->off(dw); } =20 +static inline +void dw_edma_core_quiesce(struct dw_edma *dw) +{ + dw->core->quiesce(dw); +} + +static inline +void dw_edma_core_ch_quiesce(struct dw_edma_chan *chan) +{ + chan->dw->core->ch_quiesce(chan); +} + static inline u16 dw_edma_core_ch_count(struct dw_edma *dw, enum dw_edma_dir dir) { diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index 14700ac42fa8..32df5d13ba8b 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -160,6 +160,20 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw= _edma_dir dir, u16 ch, readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name)) =20 /* eDMA management callbacks */ +static void dw_edma_v0_core_dir_off(struct dw_edma *dw, enum dw_edma_dir d= ir) +{ + unsigned long flags; + + raw_spin_lock_irqsave(&dw->lock, flags); + SET_RW_32(dw, dir, int_mask, + EDMA_V0_DONE_INT_MASK | EDMA_V0_ABORT_INT_MASK); + raw_spin_unlock_irqrestore(&dw->lock, flags); + + SET_RW_32(dw, dir, engine_en, 0); + SET_RW_32(dw, dir, int_clear, + EDMA_V0_DONE_INT_MASK | EDMA_V0_ABORT_INT_MASK); +} + static void dw_edma_v0_core_off(struct dw_edma *dw) { SET_BOTH_32(dw, int_mask, @@ -169,6 +183,24 @@ static void dw_edma_v0_core_off(struct dw_edma *dw) SET_BOTH_32(dw, engine_en, 0); } =20 +static void dw_edma_v0_core_quiesce(struct dw_edma *dw) +{ + if (dw->wr_ch_cnt) + dw_edma_v0_core_dir_off(dw, EDMA_DIR_WRITE); + if (dw->rd_ch_cnt) + dw_edma_v0_core_dir_off(dw, EDMA_DIR_READ); +} + +/* + * The v0 register layout shares interrupt control per direction, so the + * whole direction is quiesced. Callers must own the direction entirely; + * partial ownership mode validates direction granularity for this layout. + */ +static void dw_edma_v0_core_ch_quiesce(struct dw_edma_chan *chan) +{ + dw_edma_v0_core_dir_off(chan->dw, chan->dir); +} + static u16 dw_edma_v0_core_ch_count(struct dw_edma *dw, enum dw_edma_dir d= ir) { u32 num_ch; @@ -554,6 +586,8 @@ static resource_size_t dw_edma_v0_core_db_offset(struct= dw_edma *dw) =20 static const struct dw_edma_core_ops dw_edma_v0_core =3D { .off =3D dw_edma_v0_core_off, + .quiesce =3D dw_edma_v0_core_quiesce, + .ch_quiesce =3D dw_edma_v0_core_ch_quiesce, .ch_count =3D dw_edma_v0_core_ch_count, .ch_status =3D dw_edma_v0_core_ch_status, .handle_int =3D dw_edma_v0_core_handle_int, diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index cc908ca24061..be22f9f811ca 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -73,6 +73,17 @@ static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan= *chan, u32 val) HDMA_V0_LOCAL_STOP_INT_EN; } =20 +/* HDMA management callbacks */ +static void dw_hdma_v0_core_ch_off(struct dw_edma *dw, enum dw_edma_dir di= r, + u16 id) +{ + SET_CH_32(dw, dir, id, int_setup, + HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); + SET_CH_32(dw, dir, id, ch_en, 0); + SET_CH_32(dw, dir, id, int_clear, + HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); +} + static void dw_hdma_v0_core_off(struct dw_edma *dw) { int id; @@ -86,6 +97,21 @@ static void dw_hdma_v0_core_off(struct dw_edma *dw) } } =20 +static void dw_hdma_v0_core_quiesce(struct dw_edma *dw) +{ + int id; + + for (id =3D 0; id < dw->wr_ch_cnt; id++) + dw_hdma_v0_core_ch_off(dw, EDMA_DIR_WRITE, id); + for (id =3D 0; id < dw->rd_ch_cnt; id++) + dw_hdma_v0_core_ch_off(dw, EDMA_DIR_READ, id); +} + +static void dw_hdma_v0_core_ch_quiesce(struct dw_edma_chan *chan) +{ + dw_hdma_v0_core_ch_off(chan->dw, chan->dir, chan->id); +} + static u16 dw_hdma_v0_core_ch_count(struct dw_edma *dw, enum dw_edma_dir d= ir) { /* @@ -365,6 +391,8 @@ static resource_size_t dw_hdma_v0_core_db_offset(struct= dw_edma *dw) =20 static const struct dw_edma_core_ops dw_hdma_v0_core =3D { .off =3D dw_hdma_v0_core_off, + .quiesce =3D dw_hdma_v0_core_quiesce, + .ch_quiesce =3D dw_hdma_v0_core_ch_quiesce, .ch_count =3D dw_hdma_v0_core_ch_count, .ch_status =3D dw_hdma_v0_core_ch_status, .handle_int =3D dw_hdma_v0_core_handle_int, --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020111.outbound.protection.outlook.com [52.101.229.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 503053EFFC7; Fri, 10 Jul 2026 08:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.111 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671338; cv=fail; b=nCpRgOe0BjpChucr0uggBhq9uStQacks42FyBBF9ZB0r2DPlNvRiDuZolmAchXt4HHYUjBZvOr+1tzQBlNT1gPdYqiqpmWFk/hgtzoPPd0IN8jEGq8q8fDf3zbUQYxgP7CZLprkhITz2/DPBmTfh0Qqwp7gtcvbrQB/HSlzE/mA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671338; c=relaxed/simple; bh=ehdL/epgviMIfAgSOm6H8ZVAZr8fvD6dhdL6tVF9dfs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Q1+VL6WbcF8nRjCITul8OToWXkMixbGLg1bZh+gApYSnrIXloZtg/fyRf+QHizIpf2+UE0jJ224eLN6TEUjyA7pPZa875PBJBJgJz6MgWIOR7wUrqtsWXAiSI61n4XGrnmGbO1yjS5iVdt9J7plJ0Oe2eUq4YCMwX6h1gVXqkB8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=bNGU+tVJ; arc=fail smtp.client-ip=52.101.229.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="bNGU+tVJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hKBTwpXaHhX2tgbpaqzYZswrRj4oSVhL7R5/o+YGVBIv0A2Dp2yPTdn0a/WjRKuAO9mCekvNYOjtRmZbE2xIqgegJZX+v963D7IrQj/iOfZv9btXn1NXOMeGbj3g4XfOxnFY04K1WH502LSkHxjSBHVSERPHqu3Jv/6VUlW761sb5hAEaKhfFHddX/nLJzMgwxZ3SxzylD8ZqiNv6Zxr5F45UxjngnrahWoG9ITzGXvaX8Br9aasrRh6sWLgKbucyPGKqNpJudtGPF+UQpliNg1Rjz99N+eGikT1kmCNSOl+Z8zKU8ftsOFSgwI/u01KwO0d3jHhfeRd4y3VAOuz1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TB7xHegX3arrokMwyfvY579x40bqxOfIFXIj7/Uskhw=; b=FMpO8GMfFEA8prklXqaP9c3PXTF118+TMMgmOZDBOHRA07MYtX2O442im2xnIvwtGLY4wzIGVbLUZjcgMsRZNoT2Hm+ey9h4pRCTeOA3H3ULaAhfme/Stshd0Bn9yJRRrrGNkIK20lpY3kJi4W1Vmd/JEXKR0mBIopitf0Fw8UP6kW3O3J/Uczwo9pwgTeJ5jFBiQEZBUNNV+TlQiBn15LbKH14rZt/knryIzhRgS7YLtiOrNGVmqd+/6QHb6DDtfiKm+uhoxreJW4u6JOb7RkH7FUcunRmdH5x2dESfaeGWQeUdRr92CEjNVHoQiuMGgqZ8Bey7/JHqJuyZhOQ9Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TB7xHegX3arrokMwyfvY579x40bqxOfIFXIj7/Uskhw=; b=bNGU+tVJKMK9aoBn32HNBt3BWG7KkNTNptzAqH8HgWW41vGPju7uychE1qv2I5BT4y9rYieB4u9nzfTVQxWeDBatgm0mZaD4E0pOuEKMGDK4SedgsXMVvPCLb64R7hclSDwBgXaK8E47vM6p4N0oZiq7EXrJp87SdDj97j+mAe8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:24 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:24 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 04/14] dmaengine: dw-edma: Initialize IRQ data before requesting IRQs Date: Fri, 10 Jul 2026 17:15:08 +0900 Message-ID: <20260710081518.2394357-5-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0089.jpnprd01.prod.outlook.com (2603:1096:405:37d::16) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: 171e8bdf-1aba-4ad1-9bbf-08dede5b6443 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: YaWPfztWjlOh2HwmnftRMuD9Lp3MiWT+q73vCg/eCeasiECUGnzMttQMyK25mKAKpfX2Z5eFJJo11TupWaXS6uoDQ9RrCey9RDNR/7H3g1YOtvUZT1VAB+/HZ7sReQEip8nT8wqHKDFZPo/FbiqHWHK2xshGKuLo81UTDDQXxaBc/O+xmTifZ34Gly7Puw4gQym9PEaXm8N07gaZdNOlGTS5m4CRlp2qWuMxDfKhWOXqpCtAnXwnFSnmt6JK81/qzllOZqV/87dI0ZDTk2SXSbdBnCj2ShWF+I4mI4ygXrVuH7Z51tRKd6nskDjKicF1UZP2aUDBdZICTZyXsJ7QJJXQ0J9cQKtVlklUO35ogmtFdsNErkZiCJiPNbWhTzH8cLw8tjt720PACVQ7oLsx43Ng8uerXekRDJhTCktHtKd3qRogmlhlqPg/CMCnaJ+53trun6q2sxs8qo1DFgDBUw6Pw/MzjaVubGTrQnfT7DOBRpY4/sh1HJRW3CNNFD0s9n45mRVL23140fvTHn6XhRycnTlz58f6Ltfmuap6q2/PaKfLUHXTv5ibNLA0xsyF1eg+pphhou+/r1Dq6+8M9DeD/QnnkB+OuCrzbbS0kS30p4t8yuQ+JMNjSm1o09wWiqYsGci2WUfMTd3+imN694B3j5e6X23NyauhO7wuvjU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3VHxNYkVSmbDZQSb/eS0DSZPsDdDQzjmtzNJb6Go0TZ12eZ2fkCkIfuWM+rK?= =?us-ascii?Q?z2AOqb2jHJoJKlCuR3Hl3mEFEt7TU8Ay0RxooxODqRGdYFHtjP3C0bqfHP67?= =?us-ascii?Q?YpF7B9q0PrTcxLZpJFHb7eFXk8PvI6+dTNV9HNiKGQYe6Z+e4w0tMgOCs6sX?= =?us-ascii?Q?EIhrUOl7oeLdhR91S2W0Cycp6K70sofNaSx97engTYshHWkavYnIdIq7q4dh?= =?us-ascii?Q?z+4KSuCZVMznlDZAq3cL0UdD0+Jnm701PmjrTg6F3zX4reAsdoQ1nHkBML0N?= =?us-ascii?Q?As1DC9IDmG8le21gl9IVgC/7OEUTSZmnYL2rMVwhDLs2ICYCLpIqjSETUYjV?= =?us-ascii?Q?TEE04ga7lp8frWuSKR38HOQ1+DZlTJeknQ2lltXb9f15vqG0TkxfWVWm0Ojj?= =?us-ascii?Q?/W5mzM+cF70rDcwpvhEMxnh3NiOh5gCUOy0hzpPZ6PpDe9L54vlR5IC9a1bJ?= =?us-ascii?Q?lXoZ2yvKYd5Q9Sig6211cb18L0uslE/v89Pv53I+E/Aq2V4tf+VMjwpvsDio?= =?us-ascii?Q?u9UIwdSasgLk+WhuTm9uCqrbtlGIXFAyN4eTUKq5QdHvxSAYOBDOKS0KrhzL?= =?us-ascii?Q?IAMuTbZdXPnRjjpe/N3Ua0Bmxz1Ng96FECcoMnd5UCYS5fuW4uY3NP/YwPnK?= =?us-ascii?Q?+ZCNlOX6HMZaxaBWkX1YXInb2b3pnouYjeoghcocuvx8jXF+iuuuW59pp6Zc?= =?us-ascii?Q?3hd/a/T7+lEd/HFL7MPDc3BhgZj88ql5Gk+uIcAcWu0YID5nDurANSKarYBg?= =?us-ascii?Q?mqzvkEUjjfzyNN/ZBf0pezSKuQGsfy8xVMBJ4ZeMZhIKlhyV87SoHGoJ47jg?= =?us-ascii?Q?xE45z5cjEWXhuPxOPm2lMnTxpnYekH2EuDHU6ZLtR6T3rb4qqwSZVP15KCKx?= =?us-ascii?Q?IwflR3Bi6HzquS/9sv75e2Kv5We2UsZQ/IG+eCvCv1+xRszL4bage1O7GCxG?= =?us-ascii?Q?eqngUD0+VrjQbGOHuHentapy4YajZ+llfm0E39rydLZMXKqqYPE7J0fKtt0f?= =?us-ascii?Q?/CtmLRJhK4gAMkEv6HY+6lixhucf218Kn5PRvJMr73sj9za2Iqt3gDUXT+zH?= =?us-ascii?Q?5wJz7X4WkaeWeFmN9ja5zqP5fWWsuDdt7gC3fFrx735cODyhXDCTMRAuNM39?= =?us-ascii?Q?lEJw5EZN3PlMjB0NM2Ibw82tFue5/OzZhBHhsWvrbVrbgfKVrnhW66AAfDP+?= =?us-ascii?Q?0Oj7QUfnMPCPbJ/DgtbjM/xmbMFZ+btp5Wilyn/yx+CuYkHFT8YVngx/sPX8?= =?us-ascii?Q?zNtC5JSZl7WA8fKG2lGHs+2HTnHjpb/xPqfDEdDNEuKKW7ex7+2gzDghZKcf?= =?us-ascii?Q?R0ZHFCr8d2g11PHSTTJJlWB1/Ny1wZs2ipTZNjwGE5El+gGYdOiBlGZfJ9aY?= =?us-ascii?Q?IyT02e7K4VayL+Fjpi3mVi1IKE9KfD+tUq2XKCt7yQRrcmTNXxxp/XofPB+N?= =?us-ascii?Q?B4mz/418CkKuPoXRKU4zutEXQAchcLSBplcK9MhWz1e3zL89QMhbt5dGInuC?= =?us-ascii?Q?jR155t/NuaHC5yP8zsRy/EPrXxn+5F+xZr1eaNoH4zYkPnmRWDgL8vS/dc+9?= =?us-ascii?Q?Y8T6WNmcOQtas2mNb/kFUnObc22rH59nsFAeaAsDj0uDhjZzYsTKaY1+qNHF?= =?us-ascii?Q?vuBHAUnMiTu3+Oxlihlk+XErZxd1pyNB0JwGH8aYBlpdZ5+1Co44tP1+oAMs?= =?us-ascii?Q?FYEDCWzjo6YmLnjqoEFPb1Vtxg5Qg+kx8bGg41M1R9K737ktTCkTaRQ7jF60?= =?us-ascii?Q?X1IQMOfgmb1GopkpFeKnsUnRN2t1r19BxwBMZ7hIeonlIxjAPoo5?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 171e8bdf-1aba-4ad1-9bbf-08dede5b6443 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:23.9553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yRaqFaOkQwr51ZSG/B0KZQTaUJQwyy1Wai4lY6O82w75/E/uTSBG7gd5p8bYg3bWEjTHEH3BSjlfQBlC1x/ulg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" dw_edma_irq_request() passes struct dw_edma_irq to request_irq() before dw_edma_channel_setup() fills the back pointer. A shared interrupt can therefore enter the handler with dw_irq->dw still NULL, leading to a NULL pointer dereference. Set the back pointer before installing each handler. Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") Cc: stable@vger.kernel.org Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 1c6db2c381e2..fb17074917df 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -1053,7 +1053,6 @@ static int dw_edma_channel_setup(struct dw_edma *dw, = u32 wr_alloc, u32 rd_alloc) else irq->rd_mask |=3D BIT(chan->id); =20 - irq->dw =3D dw; memcpy(&chan->msi, &irq->msi, sizeof(chan->msi)); =20 dev_vdbg(dev, "MSI:\t\tChannel %s[%u] addr=3D0x%.8x%.8x, data=3D0x%.8x\n= ", @@ -1135,6 +1134,7 @@ static int dw_edma_irq_request(struct dw_edma *dw, if (chip->nr_irqs =3D=3D 1) { /* Common IRQ shared among all channels */ irq =3D chip->ops->irq_vector(dev, 0); + dw->irq[0].dw =3D dw; err =3D request_irq(irq, dw_edma_interrupt_common, IRQF_SHARED, dw->name, &dw->irq[0]); if (err) { @@ -1157,6 +1157,7 @@ static int dw_edma_irq_request(struct dw_edma *dw, =20 for (i =3D 0; i < (*wr_alloc + *rd_alloc); i++) { irq =3D chip->ops->irq_vector(dev, i); + dw->irq[i].dw =3D dw; err =3D request_irq(irq, i < *wr_alloc ? dw_edma_interrupt_write : --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020113.outbound.protection.outlook.com [52.101.229.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5E273F0744; Fri, 10 Jul 2026 08:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.113 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671338; cv=fail; b=Sdhinxa1aktUS6xAxjZAqxirmvxTN3NN+5Du0tKfxgZ5aCcagYrw19LbWTSK8+QdZ4LWksBiMqD6+mwEkr6xR4oXDgnUdM53uoYJPagjYxZEGCVfoP7JNGmEY3aKSPeyEY4rOx0topb7o6Nep+ItV3tebvcUuxNcE4nqBgZZwa4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671338; c=relaxed/simple; bh=U1gW0Cmis/dUrqFBi/K4J2fVNAqHyoccpO06glM66Hk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ICq6kguMPdU2huPRbvZfKW1+4AE8oEK+p8REaYdPnxaSMtk8r4Qh8OG2kwUPGH4MKgeKYQOLluJ0ISM0DQaSAMq1N6FRJs6V485EaLKpr4gnZrvlPltulrTnnavrifa6wnSQcXZ5BsKODteY30lf7YWFLFUJjsQcb7+kTH6A7kE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=K67sQeHY; arc=fail smtp.client-ip=52.101.229.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="K67sQeHY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x/KdKsnhx1+9subHlpO+60KESwnYeZ1hyTMPUNFLtL1rk1IW5KUtXEwGSjH9Vr181G4cRN40RvCxrgKlh3qqYXrZPsRIHLqjY2q4ftoQZ8WPzXHraiXxMsFvU/VaGKfmXuK2XtF8LmPOogKDW8lbI6sTP2NbvvMUaeBhe3n5LdS1cd50dWRdVzRqWkxoNUZqZSFoty/rOEcNVSbAJGjIdzn2bFoEMH4MtcEW7821ElzkWh3wmpoJUfdVZ04X+xce1jTmsoax4I8V8pS1lWJ1S5BlrcTXKZWnBcMxmaRnpPbkbfgKdYvTwY8c9jrp/OWnu/16pIYHLgiUIucNGU8fdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0/Y55Puc6OsRzJPv8/5TRpmxL6Ov7DZ/7saBpzy6NIM=; b=deikwjqTl9h12IfxqFlTL+Cws0zqssmKd1um7OPC4Oy7D3MtuoR4oL/I/XYxq224uDW1EWQZQnt2p0t2H3gz1/6bP1g3iU8h9wUeyljzfXTSlTPAKT6GyvExHV2hLiSlfll57c6y8L+sWm0seCbI8JfHN7ny5sRJjdIX4dBMxyz4BdLcU8XxmRnpDHtRsQUmVfMQLnDS2IzJ8MMXfTN00D2IpnlmFVPp8sCUXUUQSKzSss+dXAkb7nOwwmUCSxe2p7UuzoipmLmLQPd96F9TO6kUbGrF2Bd70YRiBSxEkx8tFj72aKWv6+YDWp2mrDJ17cjb0ssuyYSChA/mvA8VAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0/Y55Puc6OsRzJPv8/5TRpmxL6Ov7DZ/7saBpzy6NIM=; b=K67sQeHYvo+VY8W5sG2V04AbistHtebL1LdHMq5JolLtdFleGXJZSsxBdrOlQ1Tw/wu0+U2xR4KXUEg4WGJ6vTjzhflkZeMcmElzpLmWjVy3CRf3hjw+6WvQI0HiPN2ggOXyer9s+/MdKDUsu32MIj4i/mwQe/kIy6TJC61DjVc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:24 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:24 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 05/14] dmaengine: dw-edma: Add partial channel ownership mode Date: Fri, 10 Jul 2026 17:15:09 +0900 Message-ID: <20260710081518.2394357-6-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0114.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::12) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: 948a9032-2f76-4e73-0898-08dede5b64be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|6133799003|18002099003|22082099003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: 7QSFMYShTum7b4ZwZmAyy44fKzW9hS1PfK1MT/+/BJsr8dnomXkYHJ9QPMBZLpvHk/dg6lFcTjQ6IRIYfXguTCIb2/yEyPtLiELC6wztUs0WAgR3ReSVyyACYxu13+LPfKxIFEn3wyBW6otbnv43MAwQ9JFpVLRklhVpSK4ApHSH/Y06lprzKgzb85aE6ZcZiPn/uzGBs2By9cGFdBUWqViAvU5OJiSltopI+c7BC3Gnjdr07lxv99lA7t1zQ/buUYcs4aUMgviAgL6Sr3tx2eUauDfz7PAjzPoF1WSbvnrOJ6flLbFcdHWlXmJ6yzR5z+MrG7+gGpJ9G3ZdvzDuaGwpx7nshQXlh0nNKEhrxyKZSDP3I7WFQgTIjbRxzcrTCFbC7ErxL7hi4zw0f2D84E25+z9ChDytudPhVhEhybdJyfmLjq6+YsLAK64rfvelPoKzjmRGm8r3g7okVBOx7f3C4TFa7aHxXga9ZNGRqmynS1n6/R5rGC1REA1/BvcrXEuqQi0yQ4vfPirj1PVtpAqvUtXxo0K0iQsTTvhAq1RPNSmtaWyvnSZv2C3Sq8zSXfXUW3g2xYmUoNMgJuarRQT6DOa1SvjzRFSqKk2rJ/5DZkpC4ESStn0Of8Fe+QWpdZ5dV2qHp7D8N+MmANtDAoMXhSw57KMxFkF9SwZXF30= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(6133799003)(18002099003)(22082099003)(3023799007)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BcL52Nd3YTQuVPfXpLN9yBiKUUJQlBSnX5euL0kxe5wzDnHjNv/vrDDuEkEe?= =?us-ascii?Q?dAHCN2n28NSdArCbetgeM5Tg+6VhCSVeN426NCYUr8EN6vSfF40Ld2n9IKtO?= =?us-ascii?Q?jdz2/WmtaNIYd7oS5a/t2c4W5gN4rREbZk0BBuxwpdn59ElH5P2TyM7iDIor?= =?us-ascii?Q?2VJgFo+VzgG246Kd2bv/4NDsOBUhB/aQmPAYP/138SKB1TPvMEaB6tQQdhWn?= =?us-ascii?Q?xgs+CYrT2OEhCOcRbdyO7osE0FasYysFnQ0u7fuxYGSGP0hi+UASnrLINU7C?= =?us-ascii?Q?vzok4PXT1mevk6unwj/UfBi9TXYCJtRja50/NX22hiUUCNA4/qHXfF4quijV?= =?us-ascii?Q?ooIEJCdvOHnaACCs7YFHP9+tJfBR7AXTXzRs9sGIuD8JYJ/nUJsYPGESl0Or?= =?us-ascii?Q?2W/V7m8OTQdRnBDpe34hdT6W0yTwBzxvvVldzf1JS+sKHWvrV8J6xcVBJmlT?= =?us-ascii?Q?CXvGq+s/bXA8sqXko6y2PIi1ZARGRFintLnnSuKwyWvzjSV+tfHH7EgBh8fc?= =?us-ascii?Q?zMR+59CMR8ulf3KcWlK+17aMcJs/dVPmEzuE+2acwiNgOkyg3hUmif/soumG?= =?us-ascii?Q?h5wMGFe+/7xatuRljpolKfe1/CmHm/aKYV+tFOwgBiReAYXah3Oldf2xOpwY?= =?us-ascii?Q?R9fubvpbMpw5DcP0VJkMFwADxgHHljHUOCs48T5lgFSoUHyQW/3hDZHb/I9x?= =?us-ascii?Q?MXk3j5BPBCJf0mxK+XIqcjlZt1MGaV0YbvH/iPrqa9bzHA+DZV0Vlc7TlOJO?= =?us-ascii?Q?pSpQbMNMJzTo1MT7AMLyq14g7LXRlKuTMZKCthhIX8eJZvotimlCCDpukMVZ?= =?us-ascii?Q?woHJuaBfeDNvP3aiDNHDWO0x2DORjFqgyw7EuB3oI+SSvKlcTSq74IJ8TjTz?= =?us-ascii?Q?er7zrZMNF4NIRM3x5+WQeqVNXVjLFnpv3ydcEqpIqIPDnuMBs4MeWMqKdDU2?= =?us-ascii?Q?fnuKvY4hS7KKaMYj2g3SPX0o6LAJrHg9JSFTp042o+wRx0Y2WioHzFa3RP1U?= =?us-ascii?Q?aT8qFyHN1b9827w1S70F/6iB+9CIDERP26q7fM7L6IdqCeEkS2mhqG2y0IJr?= =?us-ascii?Q?ivBUcM/uIBPXij5HEDdz8hujNoYSvo1MlR6pi1d08qk5PUGvc4NuRqNvkumU?= =?us-ascii?Q?xEdeMV+NSG/OtvJk0W1ljL3n/FNR+XnpFKilo0yD0RBMhO+s/7i8LHOoyCXG?= =?us-ascii?Q?GGbFTzjAIJP8j4PVzmep8BO5NvSRZM/icBvhF9QcLZOCBJY0UG8tMG3/nYXE?= =?us-ascii?Q?z/Oq5XbNyJO4KSgXjnv0EQuBd1qjOrgfD20d/5hX/EvZAO1vR+6yVKxuy/k2?= =?us-ascii?Q?oSw7JObkrU6BqQ5LAMGNGJNkxMTp1hPsOq3qvyjvAVPVZZgVlKLwCLc+sAu+?= =?us-ascii?Q?n9kULohtdGJsrcHTrvwzHpyHlJTbd4pVQmaW6i8FvmcrKUbtQptIOkw++hmj?= =?us-ascii?Q?oZwZgGJppwF0VrIc8j2riYAydaorVJAoaGkP+RcTfjSYaVo8mgcM2nAhkczE?= =?us-ascii?Q?sjC/YBUVdMFBkV4YWA4KwMQmszhYo5//yd1373Hk3IvwSPw0lFYN8ngJd0eA?= =?us-ascii?Q?oArzqkUO9zOBBU8RSRTLmXdCF98IaP0Temk2Li01Hn3T/ZnoAJ1FHpdgzhO6?= =?us-ascii?Q?arrng4U5Pqg5SOD+uYIB31DyfnrVMKEIOkVDyjwQQxlOKwO7IUIolaHO+Ktw?= =?us-ascii?Q?aJRYQIjPy0XcyWryplaiiAFxzdrtOUiTPFr4KtB7R3EYpxsOqy5uK5RWZOQf?= =?us-ascii?Q?SjKWp+IMnrMHMdpitNw4VvOGF88nLNK7g3aAf/qYGDNeSjaQkC5f?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 948a9032-2f76-4e73-0898-08dede5b64be X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:24.7412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PG4itI48us2N0d/SBqZpwbHSeucSNcQSvz9p3+U7pL+mL1BKA7LuDm4O4iUcjonZ3na3IzZyI+94fxltrLNCLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" A DesignWare eDMA instance may represent only a subset of channels that is also initialized by another OS instance, such as an endpoint-side OS. Add a partial ownership flag for instances that must preserve controller-wide state owned by that peer. In partial ownership mode, dw-edma skips the initial core reset and uses the limited quiesce path in probe() and remove() instead of the full core-off path. The flag also makes the driver validate the ownership granularity required by each register layout before registering channels. Partial instances also skip interrupt-emulation doorbell allocation: the emulated doorbell is a controller-level resource, and a partial owner must not claim it on behalf of the whole block. For EDMA_MF_EDMA_UNROLL and EDMA_MF_HDMA_COMPAT, the driver programs per-direction registers, such as DMA_{WRITE,READ}_INT_MASK_OFF and DMA_{WRITE,READ}_INT_CLEAR_OFF. These register layouts have at most EDMA_MAX_{WR,RD}_CH channels per direction, so the capped hardware channel count still represents the whole direction. A partial instance can therefore expose write or read channels only if it owns every channel in that direction; otherwise two OS instances could update the same direction-wide registers without a shared locking protocol. In contrast, HDMA native uses per-channel registers, so it can be owned at channel granularity. Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes in v4: - Fix and revise commit message. (Frank) - Move partial-ownership validation into dw_edma_check_partial(). (Frank) - While at it, add a small source comment that explains why local variables hw_{wr,rd}_ch_cnt are introduced separately. - Quiesce represented resources during partial probe as well as remove, draining stale channel state from a previous owner without resetting controller-wide state. drivers/dma/dw-edma/dw-edma-core.c | 75 ++++++++++++++++++++++++++---- include/linux/dma/edma.h | 7 +++ 2 files changed, 72 insertions(+), 10 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index fb17074917df..0d38de4480a0 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -831,6 +831,9 @@ static int dw_edma_emul_irq_alloc(struct dw_edma *dw) chip->db_irq =3D 0; chip->db_offset =3D ~0; =20 + if (chip->flags & DW_EDMA_CHIP_PARTIAL) + return 0; + /* * Only meaningful when the core provides the deassert sequence * for interrupt emulation. @@ -1188,10 +1191,33 @@ static int dw_edma_irq_request(struct dw_edma *dw, return err; } =20 +static int dw_edma_check_partial(struct dw_edma_chip *chip, + u16 hw_wr_ch_cnt, u16 hw_rd_ch_cnt) +{ + if (!(chip->flags & DW_EDMA_CHIP_PARTIAL)) + return 0; + + if (chip->mf !=3D EDMA_MF_EDMA_UNROLL && + chip->mf !=3D EDMA_MF_HDMA_COMPAT) + return 0; + + /* + * Direction-wide registers are shared by all channels in that + * direction, so a direction must have a single owner. + */ + if ((chip->ll_wr_cnt && chip->ll_wr_cnt !=3D hw_wr_ch_cnt) || + (chip->ll_rd_cnt && chip->ll_rd_cnt !=3D hw_rd_ch_cnt)) + return -EOPNOTSUPP; + + return 0; +} + int dw_edma_probe(struct dw_edma_chip *chip) { struct device *dev; struct dw_edma *dw; + u16 hw_wr_ch_cnt; + u16 hw_rd_ch_cnt; u32 wr_alloc =3D 0; u32 rd_alloc =3D 0; int i, err; @@ -1203,6 +1229,17 @@ int dw_edma_probe(struct dw_edma_chip *chip) if (!dev || !chip->ops) return -EINVAL; =20 + if (chip->flags & DW_EDMA_CHIP_PARTIAL) { + switch (chip->mf) { + case EDMA_MF_EDMA_UNROLL: + case EDMA_MF_HDMA_COMPAT: + case EDMA_MF_HDMA_NATIVE: + break; + default: + return -EOPNOTSUPP; + } + } + dw =3D devm_kzalloc(dev, sizeof(*dw), GFP_KERNEL); if (!dw) return -ENOMEM; @@ -1216,13 +1253,21 @@ int dw_edma_probe(struct dw_edma_chip *chip) =20 raw_spin_lock_init(&dw->lock); =20 - dw->wr_ch_cnt =3D min_t(u16, chip->ll_wr_cnt, - dw_edma_core_ch_count(dw, EDMA_DIR_WRITE)); - dw->wr_ch_cnt =3D min_t(u16, dw->wr_ch_cnt, EDMA_MAX_WR_CH); + /* + * chip->ll_*_cnt describes the channels exposed by this instance. Keep + * the usable hardware counts separate for partial ownership checks. + */ + hw_wr_ch_cnt =3D min_t(u16, dw_edma_core_ch_count(dw, EDMA_DIR_WRITE), + EDMA_MAX_WR_CH); + hw_rd_ch_cnt =3D min_t(u16, dw_edma_core_ch_count(dw, EDMA_DIR_READ), + EDMA_MAX_RD_CH); + + err =3D dw_edma_check_partial(chip, hw_wr_ch_cnt, hw_rd_ch_cnt); + if (err) + return err; =20 - dw->rd_ch_cnt =3D min_t(u16, chip->ll_rd_cnt, - dw_edma_core_ch_count(dw, EDMA_DIR_READ)); - dw->rd_ch_cnt =3D min_t(u16, dw->rd_ch_cnt, EDMA_MAX_RD_CH); + dw->wr_ch_cnt =3D min_t(u16, chip->ll_wr_cnt, hw_wr_ch_cnt); + dw->rd_ch_cnt =3D min_t(u16, chip->ll_rd_cnt, hw_rd_ch_cnt); =20 if (!dw->wr_ch_cnt && !dw->rd_ch_cnt) return -EINVAL; @@ -1239,8 +1284,16 @@ int dw_edma_probe(struct dw_edma_chip *chip) snprintf(dw->name, sizeof(dw->name), "dw-edma-core:%s", dev_name(chip->dev)); =20 - /* Disable eDMA, only to establish the ideal initial conditions */ - dw_edma_core_off(dw); + if (chip->flags & DW_EDMA_CHIP_PARTIAL) { + /* + * Do not reset the shared controller, but drain stale state + * from resources represented by this instance. + */ + dw_edma_core_quiesce(dw); + } else { + /* Disable eDMA only when this instance owns the controller. */ + dw_edma_core_off(dw); + } =20 /* * Deferred IRQ works are queued from the hard IRQ handlers, so the @@ -1296,8 +1349,10 @@ int dw_edma_remove(struct dw_edma_chip *chip) if (!dw) return -ENODEV; =20 - /* Disable eDMA */ - dw_edma_core_off(dw); + if (chip->flags & DW_EDMA_CHIP_PARTIAL) + dw_edma_core_quiesce(dw); + else + dw_edma_core_off(dw); =20 /* Free irqs */ for (i =3D (dw->nr_irqs - 1); i >=3D 0; i--) diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index 1007122d4123..3c33d12d1cdb 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -55,9 +55,16 @@ enum dw_edma_map_format { /** * enum dw_edma_chip_flags - Flags specific to an eDMA chip * @DW_EDMA_CHIP_LOCAL: eDMA is used locally by an endpoint + * @DW_EDMA_CHIP_PARTIAL: Only channels described by this instance are + * owned by this driver. Controller-wide state + * must be preserved, and layouts with shared + * direction-wide registers must only be shared at + * direction granularity. Layouts with per-channel + * registers may be shared at channel granularity. */ enum dw_edma_chip_flags { DW_EDMA_CHIP_LOCAL =3D BIT(0), + DW_EDMA_CHIP_PARTIAL =3D BIT(1), }; =20 /** --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020113.outbound.protection.outlook.com [52.101.229.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F01FF3F0AB8; Fri, 10 Jul 2026 08:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.113 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671340; cv=fail; b=gRkH//KwMOVfp5QTlJr/AhJnj98rLvbqTLisG9gcImOCBi4FbQbQZTzYKfiHxJWjxv4s+ah2ZdwMkI2kpqhNXxojKXVbRs+rFubcEtOiHysoF/oSGZ+9zBy7vcHGqq8QKR+eL22BqT0lYepBUVzupDqBgSQAzPc+gW20TRSLk/Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671340; c=relaxed/simple; bh=rOlcjd4e7eQ8VmI6GEBprr4bALLHQ6wLyeVAW/lGWR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=u19G5cA0LIVXAFI2PJPaAD5VOstB8fbz7bzN+iDCTsBF3rElt99f+4KaQJVxrsGyO/3d9vwDdbsRhp5mD2JEyDv7kEmUSlbPK3hqT091cmY3DYfTjumHj+KvxZgi2scMYebcY43x71Ri7o1ZdzESWLClU8R3p+BoQY3IgyTzzSo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=ufVKQQ+Z; arc=fail smtp.client-ip=52.101.229.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="ufVKQQ+Z" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rMJpN11xJde1OVoj7QepFoMPdBqfNcw1SWRzgRJv1Fx4Tjsejnsyc3aHqBmYqzFSFOVhfPZC/84ebhJKKUABG5ijgdodDkgO+XB6NGnWeUTbVG87QkI1cUNAp5Xh6RgCyL2eg4wgEjyW92RpcDaRVh5Vy84Zc6mVFkxVXnNbUkWMSYuZA25nEhyy0AQG/9vg8KaaMo8Vowesw4e3UKcOO3ZP28J4Bpb0xY8lwHQz4aQ8en3NyFZnbCoINWDmmLyuXLfKlk/9NhRNl1ORDcQPEPYDGToIxNp5bmSH1mb3FGIJjD2dmya3/qEFDX5q7dLbKXoB8c1xoZs0UmlQgbmuXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S8rZz6JhYSvJ9wICLgDuiHg5Vtn54stL4s0WHFfg8S8=; b=tEfJbmbKup355yCK3Kd45oUD7IIpi+RLkof7Q6WR4mwMI54jvvEF9mN8q28JkpkU5QfpxB8boffAefI7J1DvpUCkbloPCEY66tLOhansv1Lm8UjDQBe6dQWAtr8rPoy03VfAbYI6H9qAJv/1Qm19N/Ivf5vGp6wEnY/fHtqXAACg/i40Z9nyAJLL//Stcfcp0PSshcOHrSHa9kjKcvk/c++VY0TkO5fm9s9wYtS17bJWXG0mQlBEQ6eZ6WWHbcmkGWL71PnzZR3mRr2OTtGkepOnNdYsI/4EwQ6ViV3wFwH3K3i8tFZYI4q1PTMLZ3U3DiIzAz6kxNkv5sS7Fw7kEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S8rZz6JhYSvJ9wICLgDuiHg5Vtn54stL4s0WHFfg8S8=; b=ufVKQQ+Z4IM7Pda5/6FVG63+XHNCT2wt8yDDWSxArh9WjNKJ9EoCN6dorqhdbnz3GZ0l0Bfc59JJn3E6vCNJ3mMa6qT46m0e7wvcoZy9cswDk0Soxr9YJ4Qri4VGKPAKC6oZDrooVQWLcrh4dkvE+eIXD/9ilTZJzQvUSqfEQSE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:25 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:25 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 06/14] dmaengine: dw-edma-pcie: Track non-LL mode in DMA data Date: Fri, 10 Jul 2026 17:15:10 +0900 Message-ID: <20260710081518.2394357-7-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0112.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::7) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: bae9e22a-bccb-430d-a267-08dede5b6536 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|18002099003|22082099003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: b1F02ABg2Z+8+A9jHR8YrVfGeQG1RPK+8Odz5oJYUofy0DJh0e6FPiguwxBqqsTFrQiwtr+y4kFbij0NwO44JR4WmZDiCOzi3hRbnkZSnsdhPUMIzeaFXZuhmegZ73oFuhJCurX/P5Hz1hNfhd8XwQgd6YwGfn3AbdTArFEiiTzz8jEMBhRcLXKZo+jQfsqXofI+ZrQzjyXB0gEJUooLwf4rX0mXSmc0SnSDh55lT5kaG9okwX6xzpFoGXiVyMP/ajbD55SZ7ouX1MB6u/bbEG4SXCP7Pi29C31t2lywWZeaGNSQZGFl86tzvdC9NL0U4RnS1QiUPSMsxYGmxakCmkG1S/isWIXiA+7ncSZIKj1NapD0sQwqYSnfancSaZm6zrkcHsHPRbvE2kMYozzcQKH9KxsSt76RhWlB2TZ9P4/ZZO1CaFZYTKz6KwKYXCv0SN8oQ4NIeUfCQGxFO0l5ZsNYXLgUWxPlzCFI0Ka46+rjnBpJm8ShdStahSJdSVqzIDZCMSS41rRhGjPZ9j3KIIRSi5uiDtB2RChs6jGHHhdexWNFh7L5zj71EfY9PldekYkiHjg9A2l2sWSzuCtn/oTNK58z8bipeXED/rbAjLc3sU0hByo4KwefRxzJmVaT2DQ5sRsYIaU8p1Wb4VZPp0aH90MzQaeFvFv1OB9VOws= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(18002099003)(22082099003)(3023799007)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TymQIbuA0B+z+zTl2pcis52KAeHZziUxY23PzddCj/PLbl8CSbPo81NEV66k?= =?us-ascii?Q?16nYDTrRHNwyyKgAPKrRAsMey1C/NZvlHshCgw9Cov1bNv3YoiSoXyh952k1?= =?us-ascii?Q?1ts3k/tpyosLh1RtQMeF6lg9B+TV9TufQEzwjmftMgqQCnlyl5tr6xDBZflu?= =?us-ascii?Q?woG9aMNlFRXwJrk/6f6+dmQIR98UR5ZpQhoHPz7z25BGvKRhqEOa2x3z3uV/?= =?us-ascii?Q?kSNRo3nEP8VX5izqGsv4cyeAV4Vwyd9aUQ3Me0fCh+NV56N3VYKwoDrHuzAG?= =?us-ascii?Q?Ou8SI9jYBvJQPhguJNrz/Jwj0zTU3x48M8b1pIoIBJT7OySKuxZ7iEvOd76s?= =?us-ascii?Q?4d8/85GO8YaduAsQRoEfFfi6CUfJ9Z3rkPbHwbLIUcmVYwmVjo81SFJOf/bt?= =?us-ascii?Q?xz8krj2LNrqY0/fMN2jwkRdU8lyC3bhoYohjxzM7YASHIvJbKniBCWTn+oTw?= =?us-ascii?Q?SVVXiHEbdaANhSMjXPETlI6ncuA4qfDIsUASl4C9G2oDXLzsIZuqNDArLUjf?= =?us-ascii?Q?AhAhhQwjq/QBOMRE1CX1DcbfQugPetG14OIecjWOQTWpK439+RIiz+GLd2L5?= =?us-ascii?Q?axB1ispT5mCkXIWh6bYoDZVTD8Le421US+zzDKwc9OyhDnQKTxqJB6PjRJst?= =?us-ascii?Q?G8prdooYccK3T8ppk5LkMDRtOfLDpb2WasWt8yGEpH/5onqZx8nvMJ7U8Tb7?= =?us-ascii?Q?ar0Gjr6nSSLZqDcSH93l8dQnLFCYpSfeUdpSoxXMIzqNUNQnTqEVhjyVeOPB?= =?us-ascii?Q?HheXGHnDp9zn0FogaDrmZu+r0M/cpvr/6j9ej7rUGcJTaYcjHs2JowRBj6nh?= =?us-ascii?Q?M3TA3KufxcEiztALilTkyw0SiDAlmXd7F55eczcZiNf1MZdFAxibuzC758Xn?= =?us-ascii?Q?+TgPDVCd0T1cVYGfSNGVu+MhOBIhNKypLcxFFOwrNt59SpQ0KzBIW2/189bQ?= =?us-ascii?Q?FxXEZqqRzYidS65Cs7j/umZ1eqsYr5YN+x8fYb+pHeLHXN7SNCKrWADZW6BZ?= =?us-ascii?Q?XbveU2euQx+Zg1mrKSSz3sjvZhEJmalM5UByQ6nLqHb1g1pUQ2W5VPt5cOBp?= =?us-ascii?Q?NeHVe6GZYm/VPXKi01G296B+eGVh+fVq5ti5hv84uDRoxTuHJnBKC9LeFF7F?= =?us-ascii?Q?3NZ+MRAF6VHARGdpxZ4gM1icpB42GTAAjETJQtKaZj3tc0dVAC7ENALqSRiS?= =?us-ascii?Q?JUaktJGThVR9v/W8gWnlyq4KH799P/vcElM8zlFiLIbvjwTq/WFGtew4hrQJ?= =?us-ascii?Q?XmdyP2lUQ+zcvjTF8/EABmuDQcRan6Dcgt04eum+0EoWMqQHWMx98O2X7FkZ?= =?us-ascii?Q?ClYOQqTyBZD7r4wjorwDG0yUSAV8RGkrShWvX6R0iMGa1wfXgKe/NDwDN6Sl?= =?us-ascii?Q?0atty41OrUX5X64V8o5iY2oOaPJEQleDjlVuasPKkGiCOTQTJUyxXCCavy1a?= =?us-ascii?Q?PTu+Kkag6Qi4O7bzmHudJ51gEyMfu9vSwVbloTCgvLTvpjUnaiav5ezdxYn7?= =?us-ascii?Q?fUDoUcfNQrQPWN8dIHrGTmBejwyEMHFf2W1T4puLAxKs5a5oiArRwtwBxWEi?= =?us-ascii?Q?nU+AfRFUT4VQNGO0ud6k28mjD497t9ejiJlIgyV2nYAEVzr7stiFmtJ/zykP?= =?us-ascii?Q?0MgSHrBdSddxXVLXrvUOhXMVLB6o50kSMp/pxu586fkklHy9prDBGfkPEJF1?= =?us-ascii?Q?2bXoihHOGOiii8qnZwn3ISoTQgCa0mwourfyVO+GPxW9Eta0R0aW2JOn/JqU?= =?us-ascii?Q?4z4uM8DfmfqrNV+7V9Neook/IgcvHgqUkcAulgD2Hi6LXU9LbbSv?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: bae9e22a-bccb-430d-a267-08dede5b6536 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:25.5627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WToPfkmDOBjEGbkE9UssYv3bpTkzZfbrdeEvensXzXOU+wyeqKdCyiHEBYYx+S5d3p2B0bdj0pyYwc2unkxTBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" The dw-edma-pcie driver copies static template data into a mutable dw_edma_pcie_data instance before applying capability-derived updates. Keep the derived non-LL mode in that copy as well, instead of only tracking it in a local variable in dw_edma_pcie_probe(). This prepares for keeping capability parsing behind match data without a separate non-LL output parameter. No functional change intended. Suggested-by: Frank Li Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 5e81a433a957..8ecf67828a52 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -73,6 +73,7 @@ struct dw_edma_pcie_data { u16 wr_ch_cnt; u16 rd_ch_cnt; u64 devmem_phys_off; + bool cfg_non_ll; }; =20 static const struct dw_edma_pcie_data snps_edda_data =3D { @@ -326,7 +327,6 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_chip *chip; int err, nr_irqs; int i, mask; - bool non_ll =3D false; =20 if (!pdata) return -ENODEV; @@ -361,14 +361,14 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, * the HDMA IP. */ if (vsec_data->devmem_phys_off =3D=3D DW_PCIE_XILINX_MDB_INVALID_ADDR) - non_ll =3D true; + vsec_data->cfg_non_ll =3D true; =20 /* * Configure the channel LL and data blocks if number of * channels enabled in VSEC capability are more than the * channels configured in xilinx_mdb_data. */ - if (!non_ll) + if (!vsec_data->cfg_non_ll) dw_edma_set_chan_region_offset(vsec_data, BAR_2, 0, DW_PCIE_XILINX_MDB_LL_OFF_GAP, DW_PCIE_XILINX_MDB_LL_SIZE, @@ -421,7 +421,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, chip->mf =3D vsec_data->mf; chip->nr_irqs =3D nr_irqs; chip->ops =3D &dw_edma_pcie_plat_ops; - chip->cfg_non_ll =3D non_ll; + chip->cfg_non_ll =3D vsec_data->cfg_non_ll; =20 chip->ll_wr_cnt =3D vsec_data->wr_ch_cnt; chip->ll_rd_cnt =3D vsec_data->rd_ch_cnt; @@ -430,7 +430,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, if (!chip->reg_base) return -ENOMEM; =20 - for (i =3D 0; i < chip->ll_wr_cnt && !non_ll; i++) { + for (i =3D 0; i < chip->ll_wr_cnt && !vsec_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_wr[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_wr[i]; struct dw_edma_block *ll_block =3D &vsec_data->ll_wr[i]; @@ -457,7 +457,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dt_region->sz =3D dt_block->sz; } =20 - for (i =3D 0; i < chip->ll_rd_cnt && !non_ll; i++) { + for (i =3D 0; i < chip->ll_rd_cnt && !vsec_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_rd[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_rd[i]; struct dw_edma_block *ll_block =3D &vsec_data->ll_rd[i]; --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020111.outbound.protection.outlook.com [52.101.229.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 261933F0ABC; Fri, 10 Jul 2026 08:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.111 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671341; cv=fail; b=KLEG++65Zm7kUSFQUQOF2II8X9JBjg/qvUMYUUKQ9UporLYvLy6wdQHM/khGM20K9thsGPquu762rmYASGuMOqnmVjea2qqby1s5Q4DEIumNoLmAlWCefOLGvItpznSlg2zAfbliYONnMxnHwMxJHZf6JMbaJbo/MZHLKkLJ2pI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671341; c=relaxed/simple; bh=J8ba0MGKvCjFYpthvauY/D0Mbg0D+kkUNoUxh4m3Ye4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=g2FPb8aSJI9GUZ8gVZrN69fhe46gjstJMVuWgFwICBnLEyfasiLOBYDVtnPK8Z//vYNfilg5k8Gr57ZrSmMSYmQI+3VQaDY3lOnEzVASxhTovSyKK8fE9MzZNcNrlFZ8A/uAZv6+hbmNnG6xK4iN6SMvynmi4TnRs1hLCyCJ5H0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=Ble5kMEd; arc=fail smtp.client-ip=52.101.229.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="Ble5kMEd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F5E6/uyx1ubva854lfDqRwpsFfS3+SPTsyhsge6fT7wcNcKcSyjkKxn/IM8+KDueR03X1yq58+ZtsKJW+zhIy7aI1/Zo9s3ZDmVxF2NxvR3sxkeTYTl8BQi9dx9kNXMNg+kYczGFQRYdEypOKiNAFIRVnn87pl1O2ochs9IHcmcrM+g9Xgl+FktrERNhdqWCUmkr/SmmZDTHLXeg8dARpKcFrIvVPixXof4JDbINR1UjN8d/ndA+Jn2LUxuSyLFMx88R8bJDhGy1fTy65UnNTIEoQAF2ykq+vxwuCDWl5RDIm8rKkXSuQmuYWC32AtEO9tmIpSaLcm0P0178cfbHSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZMg3OxXIUvvzuO1Joy6NPZNluoGwZZqhOVdI4Te1Yqk=; b=HoKzSk1RddXCQqaJZfiayunIQP752PdZgD3RxUpg3ks9/BW/T2TG3QPdgLW6qLyvXRicsBqv/TglbsgAVemf8CRZcV627eaBrGqSzMGMFN5BSDgiKC3zVf55mq05iKrYy5HMMvHceaehrhAmIK1Wbuc8Rc5sgGVQMPhim6xVvyELU/9UP4DeyeUKm718JIeZRPmPT9uFCiozLa5gS3CT4X/FTDhQ1OkPEUqCdfVXNBCdZIHIscaAkWwJ97rC5iIlpxS3NQ6lQE6Cm45XsoCxRblFZ75KP6hTMX5SL3irE70tmdnoyFmBE00WKLAA48lTiIxWjHcu54TkxARo++zXSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZMg3OxXIUvvzuO1Joy6NPZNluoGwZZqhOVdI4Te1Yqk=; b=Ble5kMEduhlq4Gff0e0gTaBUbmA5nJvQpO0ifNKq+Z8bABH2gvgpFKQeXnzttNgmWnlIiLlanJd0EFo6Lt0UH8S5smI5A4c7gweSrhx/lM+BfrJDmfLvNW7Nad8P7VSV0lIGoKiKlIKM4WrgCUDYazZe59ZUk8U9BjuN/qd81Ac= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:26 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:26 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 07/14] dmaengine: dw-edma-pcie: Add capability match data Date: Fri, 10 Jul 2026 17:15:11 +0900 Message-ID: <20260710081518.2394357-8-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP301CA0008.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:386::6) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: e17a6035-8fd2-45c3-16dc-08dede5b65c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|18002099003|22082099003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: MB8vvVXISJsoxbqvN2wyKbHkrc3mwGGUrVDcOfZ7q203F+0PQkTdUQxBr4qxHzSAL1dcmVT9oaB2/xiYWeNnVClNWGpoPLQlIwdVVOJboWOwjep40bizkos4nfWnzZL2ExzadblgIq4mxlV3BW+EI3RzRHUkhLcQHlFNvbh3+BScbR289wrhMR/hMBrktcllQrBOa65AGfNGAE6VoXD70BYIP7TS/+UGpURfBQpuUxzWn5AQMR4Z3OH9tyb5i4TWU2uIour37ZkQoBxG6ut2N9AfjeKWaffnBweLucLdfz/I4rqjrQfzTiZdxaGSn22CAtzUYNImxBsfhwTIp7SuK3pWXHORvAk1TZ6WTNfQt/t4DKuMbfXW7SR7sxi3dXP/1cCOETsmkfac3iN/9kImzKaLL9LPHnDKCokWyl6qciCZe7x1KEb14hMoFTuc4+u/ze3XTN5i75VRNrEglVhOaiYAg9cvP8DhhgJTR1Rpnh3fllKzBbGFbRxWKJuKr6pWinO/2w9QAmnzlJa5wrCaPizJ0LMk64KemD6lXNyw7zTtkdfSFr4AGSVzBuF36NYdv5A2Q9+VZKgrUXnv+GYoP5FPAbOzy7clSjH2522zGcpn0AzAp/fZnwKI0fok4QUxzgGFqshJ5auXJRaWin5Zn51/c9x+iVfVGfk19U3pr/k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(18002099003)(22082099003)(3023799007)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FTjmQgYSfwBXrYUxpp9Azrim4O5wfghNAdXMoFu7wt3VyzplFdntcZ2VM/1P?= =?us-ascii?Q?mh4MHdY/s37/iYPH8Aq7IKfZqeRbUPJQD3lFkmGjpfWLMuJWrzzpi2oT1FT/?= =?us-ascii?Q?gejzwYkKmMwfblLKZEJrmLWlPE5SwSO2aTznyzdp8nkLglEMeMLIrb9YvjYt?= =?us-ascii?Q?QKFlc7iLXU5bbLFs2mntQwls0sGdwQGgZWnRiwCtF4pfy2zb9761xDaFAttO?= =?us-ascii?Q?+e38u4NV/Zvu76iIzyXCzIgmbnc1xcXxGteQHfjePq5bh4cUsRaXmo5dlDPC?= =?us-ascii?Q?E+oYnPyt3BcHUz5khR6ndKbAUX5L43ez/YWY2m3EobRxo5RPuGTtiXAKXgMp?= =?us-ascii?Q?itfljgVDGaeb8la8+mzQRTPiUwuHU83+NaPX4IPwFjLfUB/MZrNf02U+6SOF?= =?us-ascii?Q?xyLCOek0ipz7JYeZAWOWVYATL2+oGohL8HfEZDVv17eA7BpvtNx0BYIXqGBw?= =?us-ascii?Q?4awSVgbUiAc1q1xF5l0xtXYz5rzMyjSOL0cuJJouJbEJljczn5UMh+IOdG2L?= =?us-ascii?Q?x3lS7ZJVxTNMV8yTEiw3YVZiR1NI8eYp133snO4OdfCZtKT+o9rdFDKmUCyO?= =?us-ascii?Q?tMNkJNGX70lC2Q9OqAZkwn23F6q10sxbmrA+QwGrck/PlVdKk1cne/kJ3iPS?= =?us-ascii?Q?dRvJZSwWN1ikd4SKa/I6mV/WdqD+XW4vKk6UoN4pHsRYCWNKtXUJ9MlAxYgf?= =?us-ascii?Q?dbUacfwkCRyQoojCiDYW1YWVdYZM7RvypG7MJB7XrsyfNVw2I3UOMBGbcztC?= =?us-ascii?Q?O6uJxSyJlRI+CtxKGU6iYB2nyIIycu6egoxjko6K2tn9eKjQ2Vkz0RJgo5yn?= =?us-ascii?Q?eWLz4CEBn0tJ+NTks8IdMODJDs9T7tClwUr7ZQUnpM+NC3e/u/8rUCYnCPfo?= =?us-ascii?Q?MTgnnv+IXPWxXIzChpue3IJ8974v0FxVCbtHpuRd2b6GJjNGSMfpzFsz3ydP?= =?us-ascii?Q?hWkVHYEdtqy1/h/UmSL0/gQk0GyxWtZOx2cb5tVUZ3Z5M5fgrfKiux3NB6Xr?= =?us-ascii?Q?idgPkTk8LFRlB7vvo430OzLH3jFGm6yMyO06k4Q45CNwevXH3OJJDz7sxbMS?= =?us-ascii?Q?b6b5wKR2S1PDXa9JoXkoubf1LMMICtivkhScZPUMSuZlVMbmOQvE6PKV86gB?= =?us-ascii?Q?bZ+M/fNqmp2FS8MgjB4W2jUVg9EV4giO4WbilXMrQEA7lGZNj1u1bfBm/hau?= =?us-ascii?Q?C0mtuN7fXrbtEEMmUxymRCFVLOcH86/tZeXUYiDG4FrDSkmW9NtD8jZs85/F?= =?us-ascii?Q?wqe1wFYKilvqffPB3DmB03m2sPCuDxEgXmGxPJXSvzz6M65op/jxYVY2xP4d?= =?us-ascii?Q?UVwzPbzj3GQIFcycYSupJKEVYgvFJLccou3VMV3EvHRFRB3MQnONg5abuFbU?= =?us-ascii?Q?q3+O3DX9c+u6pRwhaAi5pJPuPb0Tsb0B5Ezvx5PG+q6iK0YLnemDiOc/ZCEX?= =?us-ascii?Q?rBqGZFFY5e37vHjbRGKB/tMq2SwRcg0ijJBurqkr3/LbHnLcrAhYplwRSXYD?= =?us-ascii?Q?yIYs6OkGZBS4jp1CiJETto6flYfX8cGBM4B8XrwWWoQh4kC9rCVppO5GxMJW?= =?us-ascii?Q?zmn+JTOYQQhUfQ+JHUVG812Qp7DrS5EMpMyBVohmLPIgIJaXliGKbGMErn1D?= =?us-ascii?Q?0pdP3D4fwDumlOWRyWc+Z38SAJ52blG1/TcjJVh1aw/dl4IXrTGGX6yK2L2J?= =?us-ascii?Q?UxnGFw78Kcz2yVrHOULu6MEx0j647gGsAIgOFnQ7pAxSzOtCn0k0YHlJRF8s?= =?us-ascii?Q?DhbxPJRD4zaelb9/0WSQ9qZiXnpAcnkkX+cxIZSjoJ6qtkE1GmP3?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: e17a6035-8fd2-45c3-16dc-08dede5b65c7 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:26.5062 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aO5l081zjVB3sDaDwl/U2Lcolp3BUX9pzBB2KMn4AINg0xGQNarWrDl8pYGfwniPW6SAv4Oczjhjm7fC+bx3xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" Move device-specific capability parsing behind per-device match data. The existing probe path mixes two decisions: which static template a PCI ID uses, and which device-specific capability parser adjusts that template. Split those decisions so device-specific discovery can be added through match data instead of adding more vendor checks to dw_edma_pcie_probe(). No functional change is intended for the existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 matches. They still copy the same static template data and run the same capability parsing logic before BAR mapping. The AMD (Xilinx) MDB/CPM6 entries also keep using endpoint memory physical addresses for descriptor windows through a new match-data flag. Suggested-by: Frank Li Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 139 ++++++++++++++++++++--------- 1 file changed, 96 insertions(+), 43 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 8ecf67828a52..22e3efa6b365 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -76,6 +76,19 @@ struct dw_edma_pcie_data { bool cfg_non_ll; }; =20 +struct dw_edma_pcie_match_data { + const struct dw_edma_pcie_data *data; + /* + * Mandatory callback. It may leave @pdata unchanged when the static + * template already describes the device. + */ + int (*parse_caps)(struct pci_dev *pdev, + struct dw_edma_pcie_data *pdata); + unsigned long flags; +}; + +#define DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF BIT(0) + static const struct dw_edma_pcie_data snps_edda_data =3D { /* eDMA registers location */ .rg.bar =3D BAR_0, @@ -310,24 +323,70 @@ static void dw_edma_pcie_get_xilinx_dma_data(struct p= ci_dev *pdev, pdata->devmem_phys_off =3D off; } =20 +static int +dw_edma_pcie_parse_synopsys_caps(struct pci_dev *pdev, + struct dw_edma_pcie_data *pdata) +{ + dw_edma_pcie_get_synopsys_dma_data(pdev, pdata); + + return 0; +} + +static int +dw_edma_pcie_parse_xilinx_caps(struct pci_dev *pdev, + struct dw_edma_pcie_data *pdata) +{ + dw_edma_pcie_get_xilinx_dma_data(pdev, pdata); + + /* + * There is no valid address found for the LL memory space on the + * device side. In the absence of LL base address use the non-LL mode or + * simple mode supported by the HDMA IP. + */ + if (pdata->devmem_phys_off =3D=3D DW_PCIE_XILINX_MDB_INVALID_ADDR) { + pdata->cfg_non_ll =3D true; + return 0; + } + + /* + * Configure the channel LL and data blocks if number of channels + * enabled in VSEC capability are more than the channels configured in + * xilinx_mdb_data. + */ + dw_edma_set_chan_region_offset(pdata, BAR_2, 0, + DW_PCIE_XILINX_MDB_LL_OFF_GAP, + DW_PCIE_XILINX_MDB_LL_SIZE, + DW_PCIE_XILINX_MDB_DT_OFF_GAP, + DW_PCIE_XILINX_MDB_DT_SIZE); + + return 0; +} + static u64 dw_edma_get_phys_addr(struct pci_dev *pdev, + const struct dw_edma_pcie_match_data *match, struct dw_edma_pcie_data *pdata, enum pci_barno bar) { - if (pdev->vendor =3D=3D PCI_VENDOR_ID_XILINX) + if (match->flags & DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF) return pdata->devmem_phys_off; + return pci_bus_address(pdev, bar); } =20 static int dw_edma_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *pid) { - struct dw_edma_pcie_data *pdata =3D (void *)pid->driver_data; + const struct dw_edma_pcie_match_data *match =3D (void *)pid->driver_data; + const struct dw_edma_pcie_data *pdata; struct device *dev =3D &pdev->dev; struct dw_edma_chip *chip; int err, nr_irqs; int i, mask; =20 + if (!match) + return -ENODEV; + pdata =3D match->data; + if (!pdata) return -ENODEV; =20 @@ -345,36 +404,13 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 memcpy(vsec_data, pdata, sizeof(struct dw_edma_pcie_data)); =20 - /* - * Tries to find if exists a PCIe Vendor-Specific Extended Capability - * for the DMA, if one exists, then reconfigures it. - */ - dw_edma_pcie_get_synopsys_dma_data(pdev, vsec_data); - - if (pdev->vendor =3D=3D PCI_VENDOR_ID_XILINX) { - dw_edma_pcie_get_xilinx_dma_data(pdev, vsec_data); - - /* - * There is no valid address found for the LL memory - * space on the device side. In the absence of LL base - * address use the non-LL mode or simple mode supported by - * the HDMA IP. - */ - if (vsec_data->devmem_phys_off =3D=3D DW_PCIE_XILINX_MDB_INVALID_ADDR) - vsec_data->cfg_non_ll =3D true; - - /* - * Configure the channel LL and data blocks if number of - * channels enabled in VSEC capability are more than the - * channels configured in xilinx_mdb_data. - */ - if (!vsec_data->cfg_non_ll) - dw_edma_set_chan_region_offset(vsec_data, BAR_2, 0, - DW_PCIE_XILINX_MDB_LL_OFF_GAP, - DW_PCIE_XILINX_MDB_LL_SIZE, - DW_PCIE_XILINX_MDB_DT_OFF_GAP, - DW_PCIE_XILINX_MDB_DT_SIZE); - } + /* Let device-specific discovery override the static template data. */ + if (!match->parse_caps) + return -EINVAL; + + err =3D match->parse_caps(pdev, vsec_data); + if (err) + return err; =20 /* Mapping PCI BAR regions */ mask =3D BIT(vsec_data->rg.bar); @@ -441,8 +477,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - ll_block->bar); + ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -451,8 +487,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - dt_block->bar); + dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } @@ -468,8 +504,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - ll_block->bar); + ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -478,8 +514,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - dt_block->bar); + dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } @@ -557,12 +593,29 @@ static void dw_edma_pcie_remove(struct pci_dev *pdev) pci_warn(pdev, "can't remove device properly: %d\n", err); } =20 +static const struct dw_edma_pcie_match_data snps_edda_match_data =3D { + .data =3D &snps_edda_data, + .parse_caps =3D dw_edma_pcie_parse_synopsys_caps, +}; + +static const struct dw_edma_pcie_match_data xilinx_mdb_match_data =3D { + .data =3D &xilinx_mdb_data, + .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, + .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, +}; + +static const struct dw_edma_pcie_match_data xilinx_cpm6_dma_match_data =3D= { + .data =3D &xilinx_cpm6_dma_data, + .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, + .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, +}; + static const struct pci_device_id dw_edma_pcie_id_table[] =3D { - { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, + { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_match_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), - (kernel_ulong_t)&xilinx_mdb_data }, + .driver_data =3D (kernel_ulong_t)&xilinx_mdb_match_data }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), - .driver_data =3D (kernel_ulong_t)&xilinx_cpm6_dma_data }, + .driver_data =3D (kernel_ulong_t)&xilinx_cpm6_dma_match_data }, { } }; MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table); --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020113.outbound.protection.outlook.com [52.101.229.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E50D23F1AD5; Fri, 10 Jul 2026 08:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.113 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671343; cv=fail; b=IuSQDI4lFEk/cp7C2dwPGPcZbDS7Ifgw+tloifBsZ2tpsiqSPhFWM9ZEKPueqi/xaxSbJ8OpBQkvlnG9gbrc5KV5dzIqqJ8RdaaTUxWSN69PnQWEW3QEKAQYniYBRYPyXJ9OgEs1Y79FeNXeV3huJ8zknJ7USq4jdakDNh8JrcA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671343; c=relaxed/simple; bh=NRXcuhPohlh7kJIND2/c8PPECWMdwJ9KA53+zkwuuR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=qqpoJDd1p7nGWv9l5O0eEN9LzHQO9+JPvLBgemJ1SakRCLfwq6ZzZANjrzU6lUOD5eUbN5t9JiexfecDi6Fr+cVAzltGjIp3cw732WTOQp3ZmlVItAt4gsIjlIru8VwKbH1gSgBjOnje2XPiw9d0rXJv8RLyCmzE0jTU6WdezwA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=E7oz+P4R; arc=fail smtp.client-ip=52.101.229.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="E7oz+P4R" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BV5f+HmbsAsM/dThIsn3ICbWRZVJhlfggZo8fOfT5QXyvUn6O6mCZdjwHFi0f9KXMS6kfLAmLrS2Vu2m6B9J/gwm/eeP/WnVQotQj+1cakCF43K/rjLjXzQd8zbnx26q8Dn/SI/ngJed77P2rocbj3IzWxMMBc+v2+XA3AQI2e8ggNDb+5XrktB5YEsaaqlhLo/y/CjLz5yG995FDZol/XbWnieGM+mlREL54zY1SKkBM9zzqiUNcz6IaJohrb4iU1NG99DIFA4JHNziQCK3AYPljlCeTym271geSUudgfQIZBVn1wnH/WKqujcY1OStWgfFe6mmel6rYWihpVC5DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vw4ZCMkMqb0AQLjXGOZ9t0j4tBQyEmdisgCi8ZIZET0=; b=ObWA+VVm0W8QS/EZIehaIx4p1TApH4kKsDsL+YC0C1CawpLuMyDCJ2T1iFagBjCnqHIK48rkvy8ct0yrdw5DsnyViJq4mo39iCwJPVPSbA/r/zf/j7jaNF0toJ/Z55KsRvkAwxIMHCq3qZ3l2ijxO0jn+0DUpoFI0rK0A2rRm98a/jXM+9MWOylgiKP+I9mSz72zvNBvqTvJHysX0F8je8aIeU1nNRhWgzg+SmNXebWg4rb310ad8gc2zSiFKE1QyfBR06JSEN3Om4aYCTTAiqzMK9OhsgZ1bNUF34Ip7kFSM357/PWE06z1RChi0kmFjk1Nh4XS0OWIzuTlkGz6Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vw4ZCMkMqb0AQLjXGOZ9t0j4tBQyEmdisgCi8ZIZET0=; b=E7oz+P4RC4DKaPyD467As/c9l0YqyPFUekRDBFwF02qWssATsXVDKpT9xSKbqDJD9HCiNvGwHZXHGXIus0+kXS6wIH4GdHG4YU1RN+7J6I5dbav0ihHKhdxmCIRbS3GL8fGzD5aYbiP1+wY6KmKAJQbLxOrLztgLuZvNgzoApOM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:27 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:27 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 08/14] dmaengine: dw-edma-pcie: Rename vsec_data to dma_data Date: Fri, 10 Jul 2026 17:15:12 +0900 Message-ID: <20260710081518.2394357-9-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P301CA0047.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36b::10) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: 32aafd80-52ea-469d-7814-08dede5b6649 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|6133799003|18002099003|22082099003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: xFc0V4F80i4tMnHPo/MeIbF7BTla6v2D6DsAgUgJjJmr5VhJC5tM1f52jax7LgeFs8OUPuTG668j4jMNOqPw41n3rkMgnKWkT1j9TJ7yQV5lxcc5ANBigqFb6i0w/oR49q/mAt4/IOj0atjN1HyzZYzRO4CTlaefbY4URgrkuaPQF6V/1U43PBGsNR0ATjJoJMovCPlZVOelfXvcQ9KbOQYTDGmSfxq90pqPQc5FqYFsU9u1qemZhgdDUoCNEjN5Wvls/jFR+Hseie2OQrOHMdHMsthPUlEGsyPlcPNBEavUjWNr641H7MsxHG7OmI1w3MpRfsJfyNe40jKP3tHNxBroe9F444UzJVB61d36gUNpZZUdJoVGQ/VLcOGYx+wVBH9SxHG1TZUDKZr7Z0cIsexDB56kKGUOo+XcLhx5ztO10CA7/h0pZQnGPlkPcWCGS/KMO23tXa9oI9wJRx8Hyp+YQVGl7vAnRR6kPT1IjocLlPR8EDlSa9Ha7a4jTKE2ETaYJmLdo9//iBbmbSPCs3hfCGYHZha5Ab8ifC1FhwdWxiwcILKDTht8bTuPtIlvOtn0FvZDv1m7aokPmV9HhP6Iaus/wz89Bqy+15OCnCWROg7HesyawLUOOIlLMeRm2lSMro6v3cAG7JHOFPMVXSTwI5lNQj63/0MVqNigO4U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(6133799003)(18002099003)(22082099003)(3023799007)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9o6MwRN/aeNw42GztHF/yeuOZqZuk+f2LT5PRKg+rSt4sYHS3YV5qNIyC9+x?= =?us-ascii?Q?tacF56wW6oB4ks1Vz74nzBnY/3gSK2vja9sQIehcQ7IjDf0WNbuBVXU2VbRz?= =?us-ascii?Q?0X4NMgDQcucg2ILBH+Qp+vE1WGNw0yfdSI5xLSmn1MQcCo2+m/mE/mxnBD+W?= =?us-ascii?Q?B6kYUem4QzY27xTpZcMpbcDXdAOAxOmAyGnB0/A8EjcnS4R7U/7MedH6MzxB?= =?us-ascii?Q?y1KN/rJ8gX8uRcV6gYmqMIw7XvxxR1NqnnPf9UbgnWmVwSK1evoiMG/+BRCn?= =?us-ascii?Q?nagDj9miBZtn9prhT9VSE9y/dfOTdyLGeYuKTCFnN/VfF5qjZhOeite/yOec?= =?us-ascii?Q?vNFIyBjZE/3KSt9NCTRkvsrLnEsOEZhfcTHnaPgAsoHCHtVjEBzixDAOLbnc?= =?us-ascii?Q?0SEDv9Csrwc9F9K+qhKs2Gr5y1JvreVDNGk4iWftMCbGdkcB21XHwHm+OfUe?= =?us-ascii?Q?isW3p/ODXJjczjx0UZLlTsANyrdHUTa5CANyyzgCiTf3EAfcVCDsBt28G13t?= =?us-ascii?Q?fGVzwLvGzbCdo8gqx6Ljhg7ZspFOV0X0I4OjCLrtJQp6wLiXU/zUsFj+Gu9w?= =?us-ascii?Q?HFomF+2OtUe8iui8QtoLqc4TFV5I1XWvxsMXsweeCC4ql4sWs24yhd/iKUMF?= =?us-ascii?Q?wFS3WUTvJ1SM9voAcBB7okUyxvc6jRLLQR27FyixmUs9IIaZD1oepCdnk4lG?= =?us-ascii?Q?yf1H9yy9JumwaHLAJbfkraGVYXMihXD7iNjjfrL12UoD85BsP8kXmCbUS2hd?= =?us-ascii?Q?WNriAWZuJTZceHE9x28+v/PICrXcdbCJnutVAYb8K0z+JdRgusRQ4sKW1Im1?= =?us-ascii?Q?l5jHdX7wKQTRyb73HJZA2GZCvSxz1tweCXRO45tmyU6TRKYGPbM5eDtjubl+?= =?us-ascii?Q?rDGq9bIhcGASDysJwaHzdd2+M3O19+31sW9ht4/iw1poVddx3VnDpilB4FVp?= =?us-ascii?Q?1YgKlOpz9731bdrNteEpSaOBkgizfuv0VKiD8pAWAjcsCNI5WOfAmXludpXV?= =?us-ascii?Q?231oPpivtX74zh+QAdpL3MEdcjSl6n1oAWdCiz6D68Oa6tKMOBb1w73eBtLq?= =?us-ascii?Q?P3JRJcOxhVsxlhl+e1fNa3eU1Xc+lo6EDayki7N+qGhYnJd0H+9yuohVn9jJ?= =?us-ascii?Q?M9HZUQuzthRVmW8Cki5C/FVjLGR0Nc+B/kAMDg9QDd2FbUF6AnAvOPrnoenY?= =?us-ascii?Q?pzN3JpuDKgC5d+TqtdnAlVDvlinje7A8EzdZy2PlPkTmDx+shJ5aN0LEl+Bc?= =?us-ascii?Q?0+dyOP9Q3+cxIy6UxdMRCGvPA90Hk8v9ogLhAFX/2gpPThUO56vRDZ49q2aB?= =?us-ascii?Q?tYeciHvhuADw/KxB0nr5vg1dU22Z9ldRdIjAKvvG8/BaVtBbXJKjmZXsBlC8?= =?us-ascii?Q?ARrzSydYnXcq8hOVQtHOfnfP2sL1j5RrYZrYuHKlcWq71VlCIeLtv2iQM2VG?= =?us-ascii?Q?Hzv1rnyI1tDmHVkHQ5BaEWeNDE8V54mCRoF5Z+bnldEUWk7dTfVjlbkDWPKi?= =?us-ascii?Q?VjiDPo3VP4S2efBv6KtEuGbFhozmIZal1hBeL7N9doQmpwKdXAhbM67pR6sH?= =?us-ascii?Q?Fw4tL6MpvG0lqVfzNWphTd2OIKg80uNipKrY7pHZFZ0o/qRcQpoEKoBgGS+b?= =?us-ascii?Q?YyEWVHaETRXAj/EmbKTFj9Lxh2JpfWgVR/SHlAXYBa+vSm7zzEdj+ZwPhtmD?= =?us-ascii?Q?C35nnyVjA1XO0qvLBdB1xiQJZrrcBW0pgXMV+5l0Uv0perCLuoAx06OjO2Dw?= =?us-ascii?Q?l6J0N5YBPc2uEir0FhoZ0FNVoYRrM7cN/5mzwXCuHCuJLBojCaoU?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 32aafd80-52ea-469d-7814-08dede5b6649 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:27.3398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tZn3VafhMO9AmZesHR3VinqWarf7gwiledXwMqopLdfAJ6xz5Adi56xDRInSIsVk0Gy13O3OAadWB5biZu+viQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" dw_edma_pcie_probe() now obtains DMA layout data through device-specific capability callbacks, not only from PCIe Vendor-Specific Extended Capabilities. Rename the local data copy from vsec_data to dma_data before adding endpoint DMA BAR metadata discovery, which does not rely on VSEC. No functional change intended. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 74 +++++++++++++++--------------- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 22e3efa6b365..41ebe96ed31a 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -390,9 +390,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, if (!pdata) return -ENODEV; =20 - struct dw_edma_pcie_data *vsec_data __free(kfree) =3D - kmalloc_obj(*vsec_data); - if (!vsec_data) + struct dw_edma_pcie_data *dma_data __free(kfree) =3D + kmemdup(pdata, sizeof(*dma_data), GFP_KERNEL); + if (!dma_data) return -ENOMEM; =20 /* Enable PCI device */ @@ -402,25 +402,23 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return err; } =20 - memcpy(vsec_data, pdata, sizeof(struct dw_edma_pcie_data)); - /* Let device-specific discovery override the static template data. */ if (!match->parse_caps) return -EINVAL; =20 - err =3D match->parse_caps(pdev, vsec_data); + err =3D match->parse_caps(pdev, dma_data); if (err) return err; =20 /* Mapping PCI BAR regions */ - mask =3D BIT(vsec_data->rg.bar); - for (i =3D 0; i < vsec_data->wr_ch_cnt; i++) { - mask |=3D BIT(vsec_data->ll_wr[i].bar); - mask |=3D BIT(vsec_data->dt_wr[i].bar); + mask =3D BIT(dma_data->rg.bar); + for (i =3D 0; i < dma_data->wr_ch_cnt; i++) { + mask |=3D BIT(dma_data->ll_wr[i].bar); + mask |=3D BIT(dma_data->dt_wr[i].bar); } - for (i =3D 0; i < vsec_data->rd_ch_cnt; i++) { - mask |=3D BIT(vsec_data->ll_rd[i].bar); - mask |=3D BIT(vsec_data->dt_rd[i].bar); + for (i =3D 0; i < dma_data->rd_ch_cnt; i++) { + mask |=3D BIT(dma_data->ll_rd[i].bar); + mask |=3D BIT(dma_data->dt_rd[i].bar); } err =3D pcim_iomap_regions(pdev, mask, pci_name(pdev)); if (err) { @@ -443,7 +441,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 /* IRQs allocation */ - nr_irqs =3D pci_alloc_irq_vectors(pdev, 1, vsec_data->irqs, + nr_irqs =3D pci_alloc_irq_vectors(pdev, 1, dma_data->irqs, PCI_IRQ_MSI | PCI_IRQ_MSIX); if (nr_irqs < 1) { pci_err(pdev, "fail to alloc IRQ vector (number of IRQs=3D%u)\n", @@ -454,23 +452,23 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, /* Data structure initialization */ chip->dev =3D dev; =20 - chip->mf =3D vsec_data->mf; + chip->mf =3D dma_data->mf; chip->nr_irqs =3D nr_irqs; chip->ops =3D &dw_edma_pcie_plat_ops; - chip->cfg_non_ll =3D vsec_data->cfg_non_ll; + chip->cfg_non_ll =3D dma_data->cfg_non_ll; =20 - chip->ll_wr_cnt =3D vsec_data->wr_ch_cnt; - chip->ll_rd_cnt =3D vsec_data->rd_ch_cnt; + chip->ll_wr_cnt =3D dma_data->wr_ch_cnt; + chip->ll_rd_cnt =3D dma_data->rd_ch_cnt; =20 - chip->reg_base =3D pcim_iomap_table(pdev)[vsec_data->rg.bar]; + chip->reg_base =3D pcim_iomap_table(pdev)[dma_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; =20 - for (i =3D 0; i < chip->ll_wr_cnt && !vsec_data->cfg_non_ll; i++) { + for (i =3D 0; i < chip->ll_wr_cnt && !dma_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_wr[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_wr[i]; - struct dw_edma_block *ll_block =3D &vsec_data->ll_wr[i]; - struct dw_edma_block *dt_block =3D &vsec_data->dt_wr[i]; + struct dw_edma_block *ll_block =3D &dma_data->ll_wr[i]; + struct dw_edma_block *dt_block =3D &dma_data->dt_wr[i]; =20 ll_region->vaddr.io =3D pcim_iomap_table(pdev)[ll_block->bar]; if (!ll_region->vaddr.io) @@ -478,7 +476,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 ll_region->vaddr.io +=3D ll_block->off; ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, ll_block->bar); + dma_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -488,16 +486,16 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 dt_region->vaddr.io +=3D dt_block->off; dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, dt_block->bar); + dma_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } =20 - for (i =3D 0; i < chip->ll_rd_cnt && !vsec_data->cfg_non_ll; i++) { + for (i =3D 0; i < chip->ll_rd_cnt && !dma_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_rd[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_rd[i]; - struct dw_edma_block *ll_block =3D &vsec_data->ll_rd[i]; - struct dw_edma_block *dt_block =3D &vsec_data->dt_rd[i]; + struct dw_edma_block *ll_block =3D &dma_data->ll_rd[i]; + struct dw_edma_block *dt_block =3D &dma_data->dt_rd[i]; =20 ll_region->vaddr.io =3D pcim_iomap_table(pdev)[ll_block->bar]; if (!ll_region->vaddr.io) @@ -505,7 +503,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 ll_region->vaddr.io +=3D ll_block->off; ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, ll_block->bar); + dma_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -515,7 +513,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 dt_region->vaddr.io +=3D dt_block->off; dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, dt_block->bar); + dma_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } @@ -533,31 +531,31 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, pci_dbg(pdev, "Version:\tUnknown (0x%x)\n", chip->mf); =20 pci_dbg(pdev, "Registers:\tBAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx bytes, add= r(v=3D%p)\n", - vsec_data->rg.bar, vsec_data->rg.off, vsec_data->rg.sz, + dma_data->rg.bar, dma_data->rg.off, dma_data->rg.sz, chip->reg_base); =20 =20 for (i =3D 0; i < chip->ll_wr_cnt; i++) { pci_dbg(pdev, "L. List:\tWRITE CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%= zx bytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->ll_wr[i].bar, - vsec_data->ll_wr[i].off, chip->ll_region_wr[i].sz, + i, dma_data->ll_wr[i].bar, + dma_data->ll_wr[i].off, chip->ll_region_wr[i].sz, chip->ll_region_wr[i].vaddr.io, &chip->ll_region_wr[i].paddr); =20 pci_dbg(pdev, "Data:\tWRITE CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx = bytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->dt_wr[i].bar, - vsec_data->dt_wr[i].off, chip->dt_region_wr[i].sz, + i, dma_data->dt_wr[i].bar, + dma_data->dt_wr[i].off, chip->dt_region_wr[i].sz, chip->dt_region_wr[i].vaddr.io, &chip->dt_region_wr[i].paddr); } =20 for (i =3D 0; i < chip->ll_rd_cnt; i++) { pci_dbg(pdev, "L. List:\tREAD CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%z= x bytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->ll_rd[i].bar, - vsec_data->ll_rd[i].off, chip->ll_region_rd[i].sz, + i, dma_data->ll_rd[i].bar, + dma_data->ll_rd[i].off, chip->ll_region_rd[i].sz, chip->ll_region_rd[i].vaddr.io, &chip->ll_region_rd[i].paddr); =20 pci_dbg(pdev, "Data:\tREAD CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx b= ytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->dt_rd[i].bar, - vsec_data->dt_rd[i].off, chip->dt_region_rd[i].sz, + i, dma_data->dt_rd[i].bar, + dma_data->dt_rd[i].off, chip->dt_region_rd[i].sz, chip->dt_region_rd[i].vaddr.io, &chip->dt_region_rd[i].paddr); } =20 --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020111.outbound.protection.outlook.com [52.101.229.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62DEC3F1AC6; Fri, 10 Jul 2026 08:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.111 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671342; cv=fail; b=fQeUwPuqDi1dhNCyFYkiR2YYkmu4jbKEvd35tILP8jKuUl7nD+0TsmkGPPzSO9KjuKgZdu415JZl5MCMX2ul4dxe3MmeSQ8wSHYZidQNP0t6Hn0yBuhCBDyTjCsSqreNtFQr4aa1JydcdK1hyywygNn8+3a2yMztjvM1DatS984= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671342; c=relaxed/simple; bh=svzBUK4SWZ1YQfHZcUORpl7kMD9bFJCDH8o3NmD474s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tm9Udp95ASime85DdoZ7tPuqzZT1b5AYZG9tzeY0PCNrBwikNQu9j2s+JeCThrVCmWvAC0wJCWzcXOB6WQULjajoSn7S8O3VimREJ7TC9ZjkwVCuOGOSKZn3at2hCGkJGdXNWq7eU6UugUv/3qAf96VSdFUuYiyxtz5CyRuBlvE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=Z4r6snkU; arc=fail smtp.client-ip=52.101.229.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="Z4r6snkU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u8zka7s3+HK9FVaKQ//wFf5uyt570gPn0yEtiLHRIZPUpvqNqNUuFSWFojzltW2+3eT95BvtaIMaqQPiDkEILIKe4lmqqmOw1p+gwXbnaFN9ONaKD3L3+04agMl6lTsVK9N3Z4q3rLpfzXxf4PHI41JlqWywMU13nvEBbN3ab2wT6gliA5TcB8C4Ck2Y6J7dpaOPyckPsg6wURoa192zs4wjrsPn/js62XJcaEJEeSk7O8TfWYBnFt+thUW8E66yt0C30TNKSASSfDE0UsA9Lcb7hp7ej8x6zAZOATPY+fxiaR1w2LvUhFV4Z43coW8PG5f9Jkscg3KS28WoXcauBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XF6dcmyUlKXXZ/5H+1koITrjHHfh8NP1BsDVXDdzpdA=; b=RerGhLgjMggCs8ES0ux2NPOHIulZyvPYSeiJY92lgaP/G7bQmZtg3dsE/S208eVx6ICZ+bGktHRFdsoKUIPN8CsEo7Bo7pFVFN5J8luHwC1C+Kd7Q6shZaOp+4BCRoUYTbdfgiiBcPEhqpY9itFHrDGfJK/deNDJZB92eK1XeSQ58p9fxceqJSwYASwdHZdKxsVyeDwE2oQCvrNQuJzvbxqgsOEWrZWpcxVu4uUz3Z+Ulkv6kMW8HvpcK895Bo/ddAoOo20rYwRY9D6iFduX2mK5N3w/BU2gaA5ngULppJX7POPKoYa5xp1sZWl+aprbwRNqFJK/VtW/oFhc3Nlxjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XF6dcmyUlKXXZ/5H+1koITrjHHfh8NP1BsDVXDdzpdA=; b=Z4r6snkUdq+F/VZULHbDOSRDEVxbxs4sj2pEf+K5iGY/QaJ9X2j+TIRQ0GBwwiPkeB0nE+vuOs75cV4eM1Hrdi23/Hv9W5+rsgkhOhNevrElz1qhiNstmsPYMDhvp+9b2+y9Xnz2TQFwkayoDjHmj+0X8IijQXYuLgAaSXsyCeE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB6307.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:409::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 08:15:28 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:28 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 09/14] dmaengine: dw-edma-pcie: Add platform ops to match data Date: Fri, 10 Jul 2026 17:15:13 +0900 Message-ID: <20260710081518.2394357-10-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0138.jpnprd01.prod.outlook.com (2603:1096:400:2b7::17) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: 11640edd-c1cc-4336-237d-08dede5b66e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|23010399003|376014|18002099003|22082099003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: QzLoxglVvsyhL1esauohaZQxQx6eTHB3IwgTtJZ38Yo2CohS/CczfgeGEYw8s06iGmhwOHQhYhWE90DzT+R13gjOwDJ/o0WHWqNwwLRM5nM6JPfGEHVhy5PhxCoUKP6SrAaRXlSdAs0io7ZPUwJyOSRwi1uiAiLwepc1z54pdCYKmQE2wZ3wpEtL1X+mkzR9hdAXqZZU6T6yZKitxtRxhd8pH1WHp1Z8OxAF+jR+fk2RYLY44aQUHDgMfybdBBhDCtvXI2Sqyv8nKH39Eu2VJ1CRVst/grXwYhP7q/ulfrlSkwxjScDXxbjg2Knwtv+NU95KSRGEbkkqYTcYoj4Lst+rlioXlUYTjB5WuzZnkTYqkwJdp3miGnn8Zxl4n84UwG6L74+sv1mSXt+a7xFRQKkA42EBZcLSA+vfhz5M8d2P1s4d/pKj3gTYpjDyvlnQsDUtzoZhHlrdgMQkIAnOwsHPHLLd9yFbQN6Q5G28GNMhWImkvWoVQCWuQQt6llR7D9GO/4xnxJl/xQi53zyToWeqlg2Kzn8Ig2ndb/bmxd2cNJf1nylKPh6sqVVSBYqJJ95mK/Ipvdyz1hQ6WDszdBVfno8Jb8SpUzguL8xD6Bf+fVA83PrXKb/L631Qq8+ymaSsQpPEa0EOTQmDcRk239Xt4ZKwGzjRXEmySHzdJcw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(23010399003)(376014)(18002099003)(22082099003)(3023799007)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+OWvdARS5XEF5JYjeLkLUl5FDxBch8RdOiaVyNZT3qcaRHj/0/YTKDaijq1l?= =?us-ascii?Q?sjwsoX2BIKW9JsESfVVkfKplmNGJ7im3tpqYyks+5e8WCjKHs5WugRgd9Opf?= =?us-ascii?Q?ljuHML1ws2PkDYjj4vDY1qsM6jgz0LSBzUBS9ZqrobU0ndtkexereFJzd7IA?= =?us-ascii?Q?gAMWXIMtpvXdek9TYWVMSr6ja4BJlfk/l2j+ari/aipQfutGcX3lsa+OHG3L?= =?us-ascii?Q?WduSUoDAsOJqRs1rTWBcaIBgrOeXIrPJpU8xvBXjV+nvsH46SDkPd25U9Czf?= =?us-ascii?Q?fVSTw3XGXZGG4flu0SUyY6YDP0mEXAUqu9xCJ0GvDG0a4h1yb0g3Q+WxSkcH?= =?us-ascii?Q?Z7gbipJZe1bMaz7lZ/bxgZXPZ62k0WeRCSGUx02qGK92j4vW25d7Qod5ZD9n?= =?us-ascii?Q?xyjl6RKWcrBhKP4vAD84Lkd251qpmTvcXrxFUPqUapl9yCZwqsj6Z7+1t6N8?= =?us-ascii?Q?l/gHzRR+TrIcQ8+6IOW9MXmJlF//ooKXkjg1h0APDlBh8VoHFlLXwSwVQzJZ?= =?us-ascii?Q?ELACZeNF4gd/DpVJnPe8Wl42nk/8ngRKi+JfI4aXBTd2Gd5wQSq25a7fdd7/?= =?us-ascii?Q?GSHVF4F6aNhepDGiPAey83Au+XM9TDmQu1/kLpCiI8r4TqWbz5rbaO0lGnxp?= =?us-ascii?Q?DkihHPgiP2dkI6PDiXyiFx8mVjHjPf/miyEtvrnSTn/Ktf+1gqwtRNJGyH+a?= =?us-ascii?Q?p6X5ua0nmgDZiX8z8x6Eh+bd7YWuRHdg0PAi8NMAcXHFlOPv4kDK0Q0Pkck0?= =?us-ascii?Q?MoO6T9zLWctrP2hwWov7SHr4JcfqvcQS278fZugBEz/3FmSxB+TR8rFreAUM?= =?us-ascii?Q?/jRtEKJ6u29/z8qBo8wELQ4b/Faw0hKszxWHaVzXE4riawHcPfT4rFPJvd1d?= =?us-ascii?Q?0ikgi4cg/B4hwtAuIEwrmB10nwcIvH/d5EibvoYFefvHxfnk1Bwj43lvuS1X?= =?us-ascii?Q?o4I61CA/B2RFO+Dxim3xdeRFVUCgEr8YMaXxiIGFbUVPZ1XKhK8HYD2tloWS?= =?us-ascii?Q?jNP+Z16jh/U0uY260zIcNHEWLR/7pvoln3Oflrp64vYxPw7Da30WSt2tAPO/?= =?us-ascii?Q?l4EnbHmtCzgxKQXIO0T0Rvk9px9ZLWLtQlSXsZuF8Nz9jB/hw1t5sw2lHpY2?= =?us-ascii?Q?ukp6xGWTq7oP7ySjWiSdMUs4Sh+fEVUcT0dwsSX8raEJL30BzMoZmAIGILfk?= =?us-ascii?Q?J+Pa+rXcSIhOBki/GadDjwQ3SN/vVMq8POMgmKLtD891aOb463t35KtpSakp?= =?us-ascii?Q?9MfKu0qeM6J/h8N7Y3VukJAP9xJpLLRkD6znduNIZfaC4io4hX+IaDObkSST?= =?us-ascii?Q?VVsESr7Z/G+pQ3VIy4CzFtPvotF8h1Avm9kJr80QuA5qQC5ZT+SN/DgGlc0S?= =?us-ascii?Q?bZoEJftIbBvBn8Uezct2bdbaFI8qFmpk21UFYV5npyLY6GXoVMxGLLXXdOh9?= =?us-ascii?Q?f9lwCfb1mQXyQWQ/PaMZKA86nd3Nmjo9LXNOkCgRG1UaFJmQvKe4X+/al6Vk?= =?us-ascii?Q?6UDYpVVPqlZdKgK36dU15upxq6WLEbBMI4CTYVypWiLeb/KoxGSAbIgoEJHd?= =?us-ascii?Q?ChOg+KSCdU+jtmSqDWZIOC5nvpknYS1gIp7bFXNkRRSUzt/yuIab2psc4hQI?= =?us-ascii?Q?gzGrMnJ3ZSPG2/swKXeA5O8rkAxeD5Sp2LZohIJ08fTW69oh7T3teqRXNCF7?= =?us-ascii?Q?0yqOVT82gERtNmWmjEE8b2ZdEKnpWt2d4GArj7a7kko42GgXGdm0MQ0wfErh?= =?us-ascii?Q?dCJnzYyung95+EMQnxYVFoHupdKG1HwOL2Vi6dXyNjB0XfkqoNIb?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 11640edd-c1cc-4336-237d-08dede5b66e7 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:28.3586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wBY0CcAZQTwMq3SQMIT6pz0CayrpUJLVzKuKCre/T9GySV/JlEtfYWklLy49rKNOGvO/qz9bQN44cE0WDjqFqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6307 Content-Type: text/plain; charset="utf-8" Move the platform ops pointer into match data. Existing EDDA/MDB/CPM6 matches keep using dw_edma_pcie_plat_ops. No functional changes intended. Suggested-by: Frank Li Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 41ebe96ed31a..36b18032c835 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -78,6 +78,7 @@ struct dw_edma_pcie_data { =20 struct dw_edma_pcie_match_data { const struct dw_edma_pcie_data *data; + const struct dw_edma_plat_ops *plat_ops; /* * Mandatory callback. It may leave @pdata unchanged when the static * template already describes the device. @@ -403,7 +404,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, } =20 /* Let device-specific discovery override the static template data. */ - if (!match->parse_caps) + if (!match->parse_caps || !match->plat_ops) return -EINVAL; =20 err =3D match->parse_caps(pdev, dma_data); @@ -454,7 +455,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 chip->mf =3D dma_data->mf; chip->nr_irqs =3D nr_irqs; - chip->ops =3D &dw_edma_pcie_plat_ops; + chip->ops =3D match->plat_ops; chip->cfg_non_ll =3D dma_data->cfg_non_ll; =20 chip->ll_wr_cnt =3D dma_data->wr_ch_cnt; @@ -593,17 +594,20 @@ static void dw_edma_pcie_remove(struct pci_dev *pdev) =20 static const struct dw_edma_pcie_match_data snps_edda_match_data =3D { .data =3D &snps_edda_data, + .plat_ops =3D &dw_edma_pcie_plat_ops, .parse_caps =3D dw_edma_pcie_parse_synopsys_caps, }; =20 static const struct dw_edma_pcie_match_data xilinx_mdb_match_data =3D { .data =3D &xilinx_mdb_data, + .plat_ops =3D &dw_edma_pcie_plat_ops, .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, }; =20 static const struct dw_edma_pcie_match_data xilinx_cpm6_dma_match_data =3D= { .data =3D &xilinx_cpm6_dma_data, + .plat_ops =3D &dw_edma_pcie_plat_ops, .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, }; --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11021109.outbound.protection.outlook.com [52.101.125.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE80A3C8194; Fri, 10 Jul 2026 08:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671333; cv=fail; b=agVk1tdgySgbVjjzgNs+57mJHWXoiDIbxzjc+6+QncBdnBAiuCMTykRMmT9xT09QJlsQv5CuSoGcRYePHXPrd2paB1Z9qZ3PSsqTRYGE70iTiotRT84+YacRVlM0XhK1b2DOJniAkCw7TVRXemkyBn61l9QdKnhtwy4eGktyjfU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671333; c=relaxed/simple; bh=VYiznSJ5b6U8+milqKeqwb0xdXW4FHuZCGEaIcYkXxI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=IXAoYglozMy5uzkOluDkl84VeZgqOiZQXWIE9TSvvoPO/MJbkzmlw4DFUoaRub9aXXT+bC3bbg2/oLVI66KEhxqECzlTfc3DTsqgp1A1XxlvtQ8d1AOcfowpdcZY/nbd9R8aGHzoKeU9fusn03gmaJ3IMfEO/pCuugUEqa1GNdI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=W7JQ68Mu; arc=fail smtp.client-ip=52.101.125.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="W7JQ68Mu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VVrLExOc723CLMxmiu3N1cvpvn3VA79QwhIL2Vdb6kcTT2jTW+o/j28fIKtLVyLAxGMxaRbOWQYTa1fNMknPu24WcVnToue//rd3jVhYm45N3YdyUSSCDij/RA3BtULFd5JdKa7fmuDuP7Efq4ED8PwsZKxcLXZNqb3cgwthUyeX3YTk51ufUSLabur54ucKsfeBj+gYHwyaSxEoPPxpTrP8wwAyESKQA6Szgkdo0SeWZrS4q+5wcRFD9cpKuTcTFGua7RoTObiUOCaVhss/uaHI2chNPZ6RDsSneCNdQN3ir+fsw4pg13upP6rM9E/8biKRhkVEwyih3wxMCE3fZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sYavP4i8j7E2welPB9qurLaFZNHKTCoTxlhl1TrKQ6s=; b=BGWCVLfB7ElJao0Q+B+e+KR19sn+XzVbOBvCy8NPP6BviPPIRhzoYhBMXy1a33/OG91gvGWy060w9d9R/t0M1i5RVUObiFniSC5JZ5J5VXdvPbwM00bDlhZLRmhLdWdVKNKhrUuXlyeB2E2wpKubxmMuxU4sMmRJfTL4uT3SBfOxWPt0da1y/h6IM6gD0vApIOFm+Oxs5Ar+yMgUcQda/pAAzRY0hui71+HfVow17xruidlZDfspNn/j2ANwwq1tHEm2cBCZ1U38zBZd8cAUo7cN4C1nukxRLkMRtUx+BxqwmftXtOpmNWedH6ImeA09jj44vcUWjfv9VREwKKqzBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sYavP4i8j7E2welPB9qurLaFZNHKTCoTxlhl1TrKQ6s=; b=W7JQ68MuY9h2B28acw+VKkFMuWvuGSdQgO5/gOgTZAwyCWZeyQK4R1YwwTMCX1SoRi9S1txAPfajWHMSfphdFvEhuvWkspkESrgFpsTzsL0FFTrbK0J9j2GCcSUQuF+0gB/vBhFMJKORReKoWfgm8/GZaxvTEwhNqpKeAlDUfIk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB4074.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:15:29 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:29 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 10/14] dmaengine: dw-edma-pcie: Add register offset match flag Date: Fri, 10 Jul 2026 17:15:14 +0900 Message-ID: <20260710081518.2394357-11-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0293.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c8::11) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB4074:EE_ X-MS-Office365-Filtering-Correlation-Id: 39ba278d-47bb-448e-685c-08dede5b6762 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|10070799003|23010399003|366016|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: RYdiVEhrTv7+W/+xu+72hW331kXxnosKPfTgf0ZPO3xCM0bK31/evEGmNJezNecM3F+AXa/Uf/PDQQCii+Hj97CbmXGWPOZNmUOXdAI2wypJAeH6YOCwDH0GrRmpZIlas46S3tFGJSgKe1gcca1W/U3ywrCExmtBOAT3X6a33Hozxm02sUDyj8jWeEDon48UO/e5Mf2avoDCtf5EAK0ko4er8+uN6OVNt+9cu35QGF783+OJEbGCcvP4/WN7c5CFcxOWcTm6B78nzFayiRZSwWiZ2M0JFEnU6h1iU1zwknhPr1AAm8mRIJVl3UxdTzPoFGq7RUwDqqhm5cThecVlR6VCBXKzWKpEFFkA3SP7o7omh4HL8xks3Ly+Dy4eV2QpzaZGumq47pgVxLpKf3zaxDX0pAfu5KZXCojzNBZMOW6er0pRfMDSzuIYYKJ//9oTry4evWyvtPk3OxRuVERVdi8DvkuEMcX/l2qp6SVVZTYZepT4n2+I83nfJjY1yUYNCGDDPKdMg93ZxjciHVjMFQby4liMmZNOBE7dv/PyYiYo9Ul31xN255iv0RZs1IQ/9corPpMi61hrJuivReY2Hb/5BlE61rC9dnASvTk2OR9jP9rxWP/5YnIATZ2JP9uEvEat4mZyo9CwLvoOMxT68tLX/Nu9XevyUbPG4u2E6vo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(10070799003)(23010399003)(366016)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JgvX+6MtIPtSwC8KXeHVD5t6zUc1x55QYPbcabv7t4cm3Rm6GumzKd/X81CS?= =?us-ascii?Q?nXTHQ98a118+cmbUhlaIICZrQEi6Omq2y7yrOTvkXbZ1+I6KQe+muZ2/Y6NC?= =?us-ascii?Q?jwamt4XZBsXjNlfP5oGRQnlgyNNb59qdQOMF7PSeSVrqZl0OSHYOarJBkxI+?= =?us-ascii?Q?6mvu7I8ncRYKBeqBvw4HVtKwOQK1aNzKTXyGw2p36+dtRzPr7lp1pt07Zuf9?= =?us-ascii?Q?3GnJEn8e/JICpfo/TIt1ZOySLxAAmxLxbs5L8bJdX684VmhAQ+g7SvvFB/TC?= =?us-ascii?Q?QRE773/0KGo8IcvQfaogbAWKTGpcZBr6NoP0BYXgRHpaF7UX7u+DlOKT6o/t?= =?us-ascii?Q?KmQmd2sSKXy3Ga3eLkRfxxfSwf0BMMQhZ6DJeQLxK0G4WI8oA73RN9BgUs48?= =?us-ascii?Q?85FqWUPp6VWUxC+Rm1x1NVSpq5lTVeCOEuGP9BNovwvFCr2Lfpu81fKNyJP0?= =?us-ascii?Q?pkXGl8iFmeomCe1Y4iRzYtP9rzQ9Jt5gC3rxdIwRhQeQZbhWYSlnYsrLykNa?= =?us-ascii?Q?vzUQ8Ye4gV4kw7ISu2yyDhgzCoq5OXWNnmdeB3OgvPKL8eWVDRtgg+ey3d80?= =?us-ascii?Q?jWjCer21fdC1P39Abh/qqXIV1WmrGJMiIdJLDG1rJyLdvTNCrqIPRe/MZFqE?= =?us-ascii?Q?39o9Pd93vfrQN4SO9FVfgqjFdW7K0T//RZmlAM4iO4cRPO/XZiWH4wjZg28/?= =?us-ascii?Q?U0N8b28gGA4aqIVqnJc1K2W/Nd35NC9SbOfE0k04O2ZAs7wxTj7O9gLi84sV?= =?us-ascii?Q?lZv8NrXGcTd9/sBNWN1LLedSIfTu2AKlKaDwB/6AtwlXAGOqugUc2nrYY4va?= =?us-ascii?Q?ZSWHD6yLKICybTmzkFk4s1BgsrWEUCDk2GnBB8WpZRbwGW/VB8MGPWIuLZJq?= =?us-ascii?Q?rrBwNVAaLVwWmXjeBOCdBz+PEpa0kiWnK67zRI7LGWGixMnSN44s+tLjPDPR?= =?us-ascii?Q?3RBLaiFTmn/sV35gtmqAB5l/nmMYV5zb3jE3+Jwn85OQ9iAO6+B6aYFCkzb5?= =?us-ascii?Q?LqhNCxh1NJMPOIXMgRKPr8wT4xg5a1xzmaQxRFr9vQyb7f42BByF2TqOTXh4?= =?us-ascii?Q?uP93+LFIcznKUisKZT5BG+4ZseLTqVkqmy7TINTZW9AhHOW/uRMolL9m0SI+?= =?us-ascii?Q?YYOY67YTnMYEI8Yj//OJ6VEPiorASbEwobDiJVNsUrGGhSKo8ID38ntksWkR?= =?us-ascii?Q?/8rngnba+OM/wwX3sGsyjDY7Qgg+fPwerm06Qs3a/gT8qQ9AYjOleissFHPD?= =?us-ascii?Q?u+APIkFKPj2CnHRX4FK6xeOiO1lK/u1E7/QgLItA5KTVgqNotj9zUyU8kyAQ?= =?us-ascii?Q?MSzYYZIjsUHw99VJGEPvBWCL+nQ5eaqcJOc6X3723Jl6u9vntN25GQpDFPmJ?= =?us-ascii?Q?mJbPXXUjeXLwBYpjk11M8wuq7qvtitzB+HWz+f8mpf7EAS121GKdIj8YpOo9?= =?us-ascii?Q?WtuvqlYgbJhCkxd2BShgK4TS2bt5i8Itmgd/ERPC5DMlSdwvVebz1iXkSa5Z?= =?us-ascii?Q?bgVKOBN3EqzPZU/aVqCKq6NFBjDV7PWNsHE8+ETV9i8KccLL8VXxYt55skUk?= =?us-ascii?Q?81GxTppNIUq9syHBeMZ3oZQ6s4OwaTOg5yvhIaAy6C0GWGLq9W77AR7wp0bS?= =?us-ascii?Q?vRF9PSyHpI7El0mBt4oSnvNTzbKDur6ozORowXUKyTgERkFo9WwJsmZCtuuh?= =?us-ascii?Q?1WeY46jbOgBqBM3XHQgWDRrPzqo0xDyhcS3G88nKCrXT2LaHjyhXuUOE0syX?= =?us-ascii?Q?hLNA+/Hf1vXwe1HT/u8Uhm8gSGWuRK0i3erzcd7fntQZQY2215Pw?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 39ba278d-47bb-448e-685c-08dede5b6762 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:29.1721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uUpmPwFBEoe2OwCKWU7NcXoaS3cNPxv4raW+kMjUlbwNaEzdDK/iDQ5tKETjwscv4rxyJnO8Uzu7DYxSF5YmSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4074 Content-Type: text/plain; charset="utf-8" Add a match-data flag for devices whose DMA register block starts at an offset inside the mapped BAR. Existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 matches keep using the BAR mapping base directly. The offsets handled here come from static, trusted match data. Later metadata-derived offsets are validated when the endpoint DMA metadata path parses them at that trust boundary. No functional change intended. Reviewed-by: Frank Li The offsets come from static match data and need no bounds check here; metadata-derived offsets arriving with the part 3 discovery patch are validated against the mapped BAR size at that trust boundary. Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 36b18032c835..a19282c15644 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -89,6 +89,7 @@ struct dw_edma_pcie_match_data { }; =20 #define DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF BIT(0) +#define DW_EDMA_PCIE_F_REG_OFFSET BIT(1) =20 static const struct dw_edma_pcie_data snps_edda_data =3D { /* eDMA registers location */ @@ -464,6 +465,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, chip->reg_base =3D pcim_iomap_table(pdev)[dma_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; + if (match->flags & DW_EDMA_PCIE_F_REG_OFFSET) + chip->reg_base +=3D dma_data->rg.off; =20 for (i =3D 0; i < chip->ll_wr_cnt && !dma_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_wr[i]; --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11021109.outbound.protection.outlook.com [52.101.125.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A633EF640; Fri, 10 Jul 2026 08:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671334; cv=fail; b=PJITzpJ3cRJrMkjSgba2ThduZcnGSpvboXHGUT2JPQdIG8cZ0hjaiob3tQGD1GsHrdVLfxg8E8KUmixVpKfDnReng/QudPFyoIFGeBvKtzJGvHazBjC2kn/nloqQaPppYV/kBOXssDy0VZrGZltr7nenKYJY+cW3ovHq4bX2lWI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671334; c=relaxed/simple; bh=OOPlHPQP1fObd0eYNPRpT/wWhmXGA9mzDeaVEIE7lZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PTKWxqp6J72vfSLoCEEx3IKhGIExcNP0RccfARAdaAUs3Jb80A/Mo/qvRbWhIFDf0wO7noAdCfmwGVitBU31RgoPZJJlmKXkrbU9r1F2+roRz1cV18vt4NXmyBmYx79Cm2Eez5gDPXwOapI2kc8iiA4o+HKBDNXp/7XpsxuH/Kw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=tSpnaA5w; arc=fail smtp.client-ip=52.101.125.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="tSpnaA5w" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jy9/JSDui4iOri9edShOaJMfoIf1Bj24xBJAKBKUGvEC9LavSP8+Ki6In6FU7nCiyFzne/MKE0uYSRwOGM/GcvSBO0w9k7jp5FeOclp1i84JzKZsygeQPdWr8ueOlxqb6uUlN9nN+4Rx3YumGB3vxo8B0rairxDyC2ntXezYttwN3unbIHKcZT/BwBtjsYpQqgTzDxKI/PhrWaSwHHRPrSESIfcfv1SKbfeb/TRy56YsEElzlXdnCYiOj9/86JhxO78o7HnFMMz9/FYsrp44wgmNZNn/pDq6vTGqJ255wwjS0wlnDEFre+0MkyX4MZXozQIiK2r6QAkdtUnRsjKGoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhom6lqtHa8GXDIUugC67Y2EAA6CJCcOr8PWx1abFSg=; b=SNnrhfZ8fZMr1qLaWBT8nvsppYQ47x+m92qQt6JvyLv59cyaVew5+LirCz9RoGNSO4C8+Fr0GO+YPP54JaDqP98J+amndHFUYS0qaH2KslUx7pCp2hD2OIEk3YaqlPv7CDXaIyPEsR8LbpQVp0vdmdpQOCOkmoJDYjYi79Vo+GX0F1iIuyeiAGSh4cok+dLsYY/b+RklADC202hmh1AQN1i2jk3nuWSEWyu040Jxa+ONmGYgs0a1/SmSnGRcfJkG5UMehsfC2K3Jt7FgXoKg3ZYDxGwDwNg5ejU7pHECxVPymKVoO/zTc60V9s4rLb7PERYSBoTXtAxbxSkEiyh3zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhom6lqtHa8GXDIUugC67Y2EAA6CJCcOr8PWx1abFSg=; b=tSpnaA5wSbz0WQ0HjV/U1AVygrHcx2fJQ6YONj/8uUm2AOG1ySD22mhnvkyJGuAQDkcLbw+qhfdY5ixu5y1ttIsKgb8RIBV9xhfz60R88WsDia4/bFe7vJAfABJtV3Gr0qIGYZzrnD52wAamPFWLp3Uf5AzDGxQiBdnOQS0Sb9U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB4074.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:15:30 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:30 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 11/14] dmaengine: dw-edma-pcie: Factor out descriptor block address lookup Date: Fri, 10 Jul 2026 17:15:15 +0900 Message-ID: <20260710081518.2394357-12-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P286CA0124.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37c::11) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB4074:EE_ X-MS-Office365-Filtering-Correlation-Id: 4050788a-29d5-403f-0c90-08dede5b67e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|10070799003|23010399003|366016|3023799007|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: qgrgH9NdILqdeBuIzrA0H6YXHwV8mAUoSUtpmp9by/t7XI9ptWNNbJ1g7faJFLONAw7zRzZAtOZgHmf+B++UQ74InYBOWJ1ofXcgeHquRiNLFgZfP4ebTkBCc4dMAg2heBV5oxwFEJlgq+Jyqwnbc3AFOfEVO2br7aeMjN6Wdu8O9ndBhwTzkNrhumP7yQXAqJGmHzPD8HHuHRBPwlfqNylozeZDp+QZU5v4tCYh7f3E3bJXwBecXAlsMYoiDT2qtufEUSCuesWq+Kko2gIm5zhv84cDmW0yu7Eqh6a9FCV/Oy2IDKaXBzsQLRvKqM3QqZOzLF2IzplzuvJmPCsRC7VG+62jIZ1XS5cKgpsb1MJ0BXa1H2qc2iIWufhxI2px5Fr3YD1qtrOvAW/qWuoW0TCJb+y04gUr4BobIFZtCBikbOJ+gUXEvPtLaqLrhx30JvQe0cK570bk9GW0VuubRbUzK4xiZGFprab/+WEUJN1wJXj6F0rmR1z8XbQ0LI9UbifEsqTUD80edUwDOPoOQOpHHx15+GA+DkAS+TKNuAz5hHS0DUpzzEYyfBdLQAUgLajYdXFuQNRK3KxuKTZDIhJxa4AKcvtZ44pIP4cBQjMSLWhgEXAOGuwVF2km43lOU6zfVh0tA95GF6RCHD58z2hDElDGfN+SoHuM4yaZ7UE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(10070799003)(23010399003)(366016)(3023799007)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5AzM8TzekulNUgEeRUtQZ6MzjzFprjmPqlN3PcErcJEwXA+wvGU5vv1Yr1Mj?= =?us-ascii?Q?k0ZnoatqjMT1eIue1nqRD6iM7zRgmU87UFw9yqWsf89KWNnOppfiWY7oXoZU?= =?us-ascii?Q?wJnAlzJm8GID+IsIXcotROOPZZty8yHyRi5JYAuRJ1PSkEtQKtbVxXDDKlTA?= =?us-ascii?Q?b1YHImaCZrKjjmHVWlY5ChTqh4rQAvVCYXKnGsAdYLjQkY6X0qTdUUZf4tTa?= =?us-ascii?Q?/MR+EsgiDfohWjj8VwvdwVvmtMNqlaTO4hKu9SwxczBCcVwXqWqg31rRyyBS?= =?us-ascii?Q?ncXIxC4NzF5BnfqkL+bbRLUXTAJAgCSV4Ebra/01NszucuPX4ekph6DLfLQE?= =?us-ascii?Q?bKD2ntnZ8NQrFx4IKsCWL+ybrgH9Dt1mloELPJ0HqaL5IzUcgpYCyhetReBb?= =?us-ascii?Q?b1JOse4nEKme8GgenvAWQWLfIO7DN6pgQeJ2MLlIvEHBYthuyCBf3Oot5o+f?= =?us-ascii?Q?pQHm+LsJieLzJVOufF2oMWdJ/NfFU3rTsQ9QJF1kWkkW0SL0Rgx6B+nFEpHz?= =?us-ascii?Q?PhYkdDZ1zltA91KQMZISp9lLINN9g8FBk9Nwkez3JInYMNmRc3A1fMu6LXl4?= =?us-ascii?Q?cPxBq7SiW99bCdqrT20qklr9Fm3wIZM0B6NGu4YgEX3QHxdQBUGbRda0t3kY?= =?us-ascii?Q?clzSyLbrS1VaueD9UYo6iD6s8OaUGZf3vO0nvIJbErOeZINbW6REaaB7DR/3?= =?us-ascii?Q?f3JBopM9dRy1c/xizGi5QKnaE3OjmszVPKIIwt19Bwe2RMrFOEBZGJ3KvzHe?= =?us-ascii?Q?s6+ipg/MjrXbGGHn3ARM4l9A4OhOC9aRrwHk8SccAW56esHJJ1bYoLPtdsG/?= =?us-ascii?Q?MgRsrJ+Q58+yAidEY/jpaxFd4K8Di7MaVYEk9dfqbmp40HpRwppJfy4xENcd?= =?us-ascii?Q?vS5dL8rvswNizPX9fNbxOvZV1LwNJlDbtI8Qv4ivLG9Koz6QoRSpu2NhHXEJ?= =?us-ascii?Q?pdOCW/KKwv6v1k4TFS8n0JPWoMk1g6bQxManMl9D66HoWkgEw5H+E2Vgb1TN?= =?us-ascii?Q?rxfpc6P1lXRCcKeI352rGeYpbuOcL4BqS/z4tfKVfPW9Gxu9lm3vWBWS7x6B?= =?us-ascii?Q?o/pRbT+MR3vvoxIWMs0vn8avRnN8a/dJsNYYg71QxQBLSK0QOp3AIvtZZZW8?= =?us-ascii?Q?4WSWjl7m+2x2x0aggvcKItYAFSFfajPXBOjZd69hFYDCA6VHY+SBxClAlWpv?= =?us-ascii?Q?3O18cvwM+c9nHQF8zY9CM5VUc/Wetx761tPhJUfZLT6M3w4048G2uH5Chxbh?= =?us-ascii?Q?Hy24QREWWrJZXyOO34fnERIEenXUnedQx4h1c5tVZ0fw3p8cTWCAh8gZf1b6?= =?us-ascii?Q?Pqq0HIaA1dZvxKikFbk1375S1ovPCuCuKoTCTwXYE4UM3lVmGhHr+yERH9ur?= =?us-ascii?Q?s7A0vlQ5fl/nxSLCLNZYxkZQ1KGXDy8dYV9aASzSOWklqJzVgQi0ZrnsMzmQ?= =?us-ascii?Q?L0UWwuLoq8zH3vlYAqQSv+vvGdhO6r1YNzKnqxaejInIEIcF0xpyLcWwe1bV?= =?us-ascii?Q?+i9+D4BrzVbNLw77YVcGOTMg5mek72MpJTTIInWzL3ReuHso/SAfh5xxsvsG?= =?us-ascii?Q?kQvnX14oI4uFelr6cFtaj71L5aXLLZ7aO1ixos9XCyxM2mM0LrdDn63GR0gN?= =?us-ascii?Q?Wz9t0nM8hvTxEjHe9+UDHzJ6yb1xBmF5v/Jt2cUrDzqYUnSEJYDe+fE2CzLd?= =?us-ascii?Q?Nwo7jCYtE0RaW+YJHanEVLsOYqB0Bqac26NE1vDNLBvgvt+2CyBZEyMM133I?= =?us-ascii?Q?nX/P4yHUEiB2TUPZpwnnYGfkXS7mdMhASp7NKyA2wipIig0/P3WJ?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 4050788a-29d5-403f-0c90-08dede5b67e8 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:30.0567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G+J99Td8zhKsEIBKjw8xF1fG8eadLDwhMdeHQGv4OFKBMCuweViEQcgax4IpbYmdhQwtmCBmHCy14LQhr2hK3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4074 Content-Type: text/plain; charset="utf-8" Add an optional physical address override to struct dw_edma_block and use a helper to compute descriptor block addresses. No functional change intended. Existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 block descriptors leave the override unset, so the helper still returns the same values as before. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 34 +++++++++++++++++++----------- 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index a19282c15644..06c52819059f 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -55,6 +55,8 @@ struct dw_edma_block { enum pci_barno bar; off_t off; + u64 paddr; + bool paddr_valid; size_t sz; }; =20 @@ -375,6 +377,18 @@ static u64 dw_edma_get_phys_addr(struct pci_dev *pdev, return pci_bus_address(pdev, bar); } =20 +static u64 dw_edma_get_block_addr(struct pci_dev *pdev, + const struct dw_edma_pcie_match_data *match, + struct dw_edma_pcie_data *pdata, + const struct dw_edma_block *block) +{ + if (block->paddr_valid) + return block->paddr; + + return dw_edma_get_phys_addr(pdev, match, pdata, block->bar) + + block->off; +} + static int dw_edma_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *pid) { @@ -479,9 +493,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, ll_block->bar); - ll_region->paddr +=3D ll_block->off; + ll_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + ll_block); ll_region->sz =3D ll_block->sz; =20 dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; @@ -489,9 +502,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, dt_block->bar); - dt_region->paddr +=3D dt_block->off; + dt_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + dt_block); dt_region->sz =3D dt_block->sz; } =20 @@ -506,9 +518,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, ll_block->bar); - ll_region->paddr +=3D ll_block->off; + ll_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + ll_block); ll_region->sz =3D ll_block->sz; =20 dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; @@ -516,9 +527,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, dt_block->bar); - dt_region->paddr +=3D dt_block->off; + dt_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + dt_block); dt_region->sz =3D dt_block->sz; } =20 --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11021109.outbound.protection.outlook.com [52.101.125.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB5763EFD15; Fri, 10 Jul 2026 08:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671336; cv=fail; b=mGFgUUfKSvrLcOOegw+g4bXyijsXh7hjLTZFKGHDeMObCnSbXcicEORu5SzOaEsG/UfaYLnoqrClogCRsG8ekj6Du+TH/8j8/XjcEHNHELHhZ9QiuXJZN+Fk7nRwTjJCLNtPmYf302No/rLJKDcIMFm1TdmP0PBA1dnL/pepDb0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671336; c=relaxed/simple; bh=bDvple806ASGqGthIE7SO12nJ/Sxn4mAjZgZ2e9Qd1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=WMQ4N8bAQwCLL3awND9c847jsHpLDPyWKaVxhJ2fO4CIvcToIEVOZbZmsV8BBfEAYwnKXKn+H3DzD0IFlehBXcp5pReeIcmd0PvqOXaEu7AoxJs1k+gM60eEBOTYGV6CFVIgoK6iulthhOX6A+O5F2dvQ3XdmfhmG6bcCEIut/M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=MlncsMwr; arc=fail smtp.client-ip=52.101.125.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="MlncsMwr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UnpFCSpo1ODfPtJZs94I/nOpQH5Re6KAWWCLUcibsD5uBMNJJmieGiPSaZr/tL4x81WSSOClbPxLcBSOK11FgurLmjdMZOUwNqTIk6KQUlo63LHf43r35Mw5Z0qYsUARrdP4Kxuq5o9sP7fsbMzf8YBoCKLmRNQo5VOSX3ofpAkAmI4cCHg4M1OXYuOdX2iFTaNbE+zU+13bOz7wdEFtRKkrM/LNLxu/hhP4F2JIo7q1i8NA8Mb3KSiJ5RXXwoMCRuJd30taNF0IhE/sO/EfbiIOqR7r0jkNKicS+ZiFHkLLRR069fVuRkSBHLfIb9VniP1KlBsbk1bu8IhYq71L7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8y2Qb2uRIA4aEB/DZvrhUqf1j72RpHu29giNqQUg8Y=; b=p0PxZ66SJXYco3dn4B3TJgSWkfdYOhPwk1nDrx89InjTuav0sHHKX+Qzz1rTJHBEqiVRC7lCiQSJwKO3w5wHLMR5h1HWbrfafvKr9mDo14Lq/BorGh4/zWiMPVp68pUKyvWNfnw6sVBzHlEclhupB5nQj8e7MUdsvfrqqq+/98CWQr4+qz6giAvpavtWdDDX8+oleZXcOjPyPyKDxN6Fy+Gw2nxGrADrayyqLo9sNT9IE4aJSisz3FZ1iMazIKw6pTsXymfyJov0ForZQtuQoGB2v7m8AOVTX9BnNHsoCZ5B7V0mYgEAJBbFbh2g5/tY3n6HOPvlWaTcfsNXmUpdlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l8y2Qb2uRIA4aEB/DZvrhUqf1j72RpHu29giNqQUg8Y=; b=MlncsMwrWTWviZFO6ha7poYJF8TYD+VbgANExAsu7Zl4OzFOY/ztOsH/f4uWIO1of1FU21mWoHoBQv8q+tzLG2KJMVgHYeH88HViZ4G40BaaYMvCbdpalIvK1YuhnPtxgTVpTJumNteA8BZZmVqJWvh6hmoCFCZX8TUpYuouQhI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB4074.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:15:31 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:31 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 12/14] dmaengine: dw-edma-pcie: Handle optional data blocks Date: Fri, 10 Jul 2026 17:15:16 +0900 Message-ID: <20260710081518.2394357-13-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0097.jpnprd01.prod.outlook.com (2603:1096:405:37d::10) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB4074:EE_ X-MS-Office365-Filtering-Correlation-Id: 39a16159-4661-4471-a0b9-08dede5b6877 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|10070799003|23010399003|366016|3023799007|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: xJEc3AQ8RK2ZNawNlJ/OBsMWciXgtwFNc9p7cpyGdpVLlu6bfQbrRx2AL/eomXwYbqvIz9HbubJuEXjCXYWlkNH3uktqj7C6a/970FYfXBHVXjjg7uI8o6KWlf9J5deQyvNvMW4NHiIl/GtXffUiX9d1OgFPoEGu0YPn/kR782kJ62Z47y/b5+xkSCmQodyOyQ0a2SjsCzs52HC//wBqkUMK8Noe9Xb+y+wqHrFgSkFz1RMiVNt56AIxqlE10SuatZlZSjDsqweiZ4mXBw+5NcRol9e2dF7mawCbt7HFMuNX2ODeua8OZzDwjkxv26SYi46vUWUOImHvUJiGz19h/ybl627yN16ce3Ea4RVeaWTzKad0itgsug9iSNAENAm+olCg1GMFuX1MLuU8a0W7kXi1VQjMwn8OMgH4mMIVzqUqp53Xx68nq3S8jPJhk/1n1Mcan25VGj69QopRZaJU3Kbg+zkZr1j0LpJ/M0kuCadsky0w44LmJ0o7Ql1nTDdu/VhQzVNC1pbESZl3ROLlQgUGHrd++7eUBsuNuw4bc2yJP20GfYgm7s3WNV+ZPhzCyoYisSaL5l6v+Rbm/SSHpxEzkwkcxgwSYD+ho5ZY8kjDh+HttN15bq3loc00N/2TXOpim8/rCQkzKlaXpKqGI/iFHoaoGLCG/Gg0T6RrDsk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(10070799003)(23010399003)(366016)(3023799007)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uKeC46UolobSzNOM3iHy51BAuKaMHqJGNcHLcU4FhgsRObNFVn5KU4axLUSh?= =?us-ascii?Q?t7bW+30v8saG0z1xt3ZkGXo6QKBamHd4sGch4293lmPgjYAgUZUMJIrl2WZf?= =?us-ascii?Q?SB9JnWOAvxSihqF+TrMjRwVTCBZv2oKAm79ZZIQMIZYWMbB1XK4+uUI7eKCc?= =?us-ascii?Q?DFhjK8cL1JZFSng/bo+2jbkhU5jvNfLK/CU/dbAE4oghSYYmgEbcY1Q5+rac?= =?us-ascii?Q?EIESONQ9FVCGSh/45H86uWM2gGQ2BYc8FWNlBG38Vo08O1pjbLRh9oWLe3B/?= =?us-ascii?Q?EJjTWSXIOdx8+myXXXaMw8TkeVpBjOezoQReBzKET+UE6cvo6F3C5BEon3Pk?= =?us-ascii?Q?pEPC/LZSfSTaHojcB3dVnLdHyekWxdGWpJYB527tNZTS18eU4aON1k446c3O?= =?us-ascii?Q?oV7+b/i4iu8ZIeMuJz6a4LR3h+s5oxfsptKDJBszDRvJFe4R+7d1XgOc9fRe?= =?us-ascii?Q?6bAIIwQ71RkpNz+AU2XsCydiufEXIj3S8ctj0xtYnCxK12luTWHVKf+QWo/h?= =?us-ascii?Q?qo9ZkPC+pbIhHmmYMvqWxOGVpP9qTFONzMwpEr+lSfJGNi+BYM0YaljY5RND?= =?us-ascii?Q?VBvyVjME1LnFr2QY9wo/hrf6jyYdUn8I/hxhT4LX/TEncNWZTlBn52MSHMyN?= =?us-ascii?Q?vxKoUcF8RdwnO7RuuNDysgBJFgxoasgcZ/YaMfhqagEOzgg9CMsy0Be8EnCq?= =?us-ascii?Q?+5z78PaHSEjNzP2/V4EixD/vN5uzSGFQj4huPbEm7JDidbGn7P9bSV0Cc2jk?= =?us-ascii?Q?edGEymFOBlb/up51g1jZ0vP9kHR0lqFYZxr7GitWsu3apA5pcDT4epWQkEjJ?= =?us-ascii?Q?Y0i1/X1zfex6FdFICdYR5iGGW1lMWW7bIAPYedAtdmzSDIUJizRuZ58wXsmB?= =?us-ascii?Q?cRQi/w2UUcQLFMS6ytur3+XgqC/bkeiL4x6cY4JoP3GYwkq7U+kopfdJ8znI?= =?us-ascii?Q?1lJwiESD4q13ZJJOBjJUHqwXdYltCHPvBG+PnpN954PKrALwb//1QwfllEPv?= =?us-ascii?Q?jyUBHcakbvAhhHNTXmpq8fCxMPN5o5jF1ERVPl56ytJEFABPp6mLJ4X6KbMn?= =?us-ascii?Q?dPqSlab9lHTXkpeQNfKP3vI6NX4LuV+qlLWbrSwEoNJo+1LmeMsdEDGcMsKs?= =?us-ascii?Q?4DluUkoC2F1wcMhuib/LVf1BDmK08V682ZJreP6S9sfu0zsow732S4yvg0wo?= =?us-ascii?Q?BhuJCZ0PopSDw373OynNhUoUykDjZRFz6vV5kQNDh7/xU4uoQC9ILvdPF08Y?= =?us-ascii?Q?i6U6Pv6AquSgbcGEfCOx/En1z1BHIsmTrNdoxMDc2jO4zwvB07UaQxVh+eXu?= =?us-ascii?Q?m+Z8UxAeA0ydzFio87aJBkBt2shvj8cXCg4y/pH2xtHRwJR6yqALvEtBqv/l?= =?us-ascii?Q?c0N4ZJBjv4+P/Qz5asWZv1Yqsw0voiRo5GP4B+J3A1eJsY8xPWIwBnxL+dmZ?= =?us-ascii?Q?uSwVUaJYgTsHzObyTQxg1liFeQn8+FxXdUQlOUZKL0mhMjP8rEVKhjelVG7z?= =?us-ascii?Q?QZ9D09ufHmavGeGr16XhHq0mrc3uQAu4hKPyPH7vATVoQTQw4pJSoSr+f1AQ?= =?us-ascii?Q?uKiLdxT/wgWe+7bTygRsXyvWDOwSnUF3poBLdAs4kFSxmFqUeWGpN1T8VSwK?= =?us-ascii?Q?xjt9MZW3wg8ZK/QBmQqslQyynjiCgIubt3oheiL3Zj3W6CiV3gGmXWY0lU5G?= =?us-ascii?Q?Ct4QWoi7o5cvU3Mvhg/LpBCRFNpg9dz6/1T3kJ5YD0p76Nz4YA40k1XNSOgi?= =?us-ascii?Q?lk8pX49MGFAhMJkVb8YapI7+CatrjDQ6HJ/Po4vRRzDvbFuqEVo4?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 39a16159-4661-4471-a0b9-08dede5b6877 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:30.9950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vqExaBtzFha3qwoIQ0wQ/bSFqI74P9z0Mp8mYI6vr03eavQesCNGnDMWwL6aY0luTosRrleEK3OJGvaGOcY1YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4074 Content-Type: text/plain; charset="utf-8" Skip data block BAR mapping and debug output when a channel has no data block size. This lets future providers describe channels that only need descriptor memory exposed. No functional change intended for existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 devices. Their static channel descriptions still provide data block sizes where data block windows are used. A zero-sized data block now means "not present" for future metadata providers. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 06c52819059f..d72c0a19c604 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -430,11 +430,13 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, mask =3D BIT(dma_data->rg.bar); for (i =3D 0; i < dma_data->wr_ch_cnt; i++) { mask |=3D BIT(dma_data->ll_wr[i].bar); - mask |=3D BIT(dma_data->dt_wr[i].bar); + if (dma_data->dt_wr[i].sz) + mask |=3D BIT(dma_data->dt_wr[i].bar); } for (i =3D 0; i < dma_data->rd_ch_cnt; i++) { mask |=3D BIT(dma_data->ll_rd[i].bar); - mask |=3D BIT(dma_data->dt_rd[i].bar); + if (dma_data->dt_rd[i].sz) + mask |=3D BIT(dma_data->dt_rd[i].bar); } err =3D pcim_iomap_regions(pdev, mask, pci_name(pdev)); if (err) { @@ -497,6 +499,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, ll_block); ll_region->sz =3D ll_block->sz; =20 + if (!dt_block->sz) + continue; + dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; if (!dt_region->vaddr.io) return -ENOMEM; @@ -522,6 +527,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, ll_block); ll_region->sz =3D ll_block->sz; =20 + if (!dt_block->sz) + continue; + dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; if (!dt_region->vaddr.io) return -ENOMEM; @@ -555,10 +563,14 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dma_data->ll_wr[i].off, chip->ll_region_wr[i].sz, chip->ll_region_wr[i].vaddr.io, &chip->ll_region_wr[i].paddr); =20 + if (!dma_data->dt_wr[i].sz) + continue; + pci_dbg(pdev, "Data:\tWRITE CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx = bytes, addr(v=3D%p, p=3D%pa)\n", i, dma_data->dt_wr[i].bar, dma_data->dt_wr[i].off, chip->dt_region_wr[i].sz, - chip->dt_region_wr[i].vaddr.io, &chip->dt_region_wr[i].paddr); + chip->dt_region_wr[i].vaddr.io, + &chip->dt_region_wr[i].paddr); } =20 for (i =3D 0; i < chip->ll_rd_cnt; i++) { @@ -567,10 +579,14 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dma_data->ll_rd[i].off, chip->ll_region_rd[i].sz, chip->ll_region_rd[i].vaddr.io, &chip->ll_region_rd[i].paddr); =20 + if (!dma_data->dt_rd[i].sz) + continue; + pci_dbg(pdev, "Data:\tREAD CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx b= ytes, addr(v=3D%p, p=3D%pa)\n", i, dma_data->dt_rd[i].bar, dma_data->dt_rd[i].off, chip->dt_region_rd[i].sz, - chip->dt_region_rd[i].vaddr.io, &chip->dt_region_rd[i].paddr); + chip->dt_region_rd[i].vaddr.io, + &chip->dt_region_rd[i].paddr); } =20 pci_dbg(pdev, "Nr. IRQs:\t%u\n", chip->nr_irqs); --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11021109.outbound.protection.outlook.com [52.101.125.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AE8F3EFFB3; Fri, 10 Jul 2026 08:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671337; cv=fail; b=LOsyFXx+nZ9Z1YwUJKMOQUQlcAjoI3SjDbyrCKwaembAdSSWIyFKKdsr40CnpJhlqlL93rkEQssxjPgfRC8rkJiaIIC1A+F/1K9DYeafu4rdXTYiwzl3dNb1qJLDhEbIGZ7CxaSz3l33/wnwZvTMaNnpaelSe5Ius+V7+e0U/Fs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671337; c=relaxed/simple; bh=FmfbJ8ukZuMn54MPbGIX2QYrmT06ebMhCquxyIN7i1c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nh7b7k/YaHEX0EPxfA773QwFEnGoP9hWOCY/QGr/ac8kTIWuYGErBAEDi8ezldQLRv7Oz1Ss92QaCEKxCBmG8U7DnbpVr82Txgoeg7NfC+ZYsInrWs7qDQLkaSRkVMd3ZA1sqjqQCNnxPpgneN495qz1b0FFFEABIwzC4rv3vMw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=spqnVR3G; arc=fail smtp.client-ip=52.101.125.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="spqnVR3G" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yn1I5FOiaPB86XgGb31bh22erd0o2UheQz+adS9D5iwqi6jBEyoMmoVnPDvselFaMTH07OTiQsTFq0srBnmDHOlvwbYuo47S3MA2dpx2ejl8ggcJXim+CFicuhYHm+HdoTAAaQPwxttGwyCx+qWwUiBofAaUpYavGcyF8JXA0OUGuqK/jqCsS6kT8FGflFBH/0l9Fk5mu0JzQs5CxEV3tjR0x9h9a4DiQexSj2hZ9tog4QETVyaO2FoRdz1WCS1GI7/KOJ6RinY7cum2EZvWggaPJT2XKFpqNNfN0SvrCI2ys2N4opsmP6KKIdqRrodDf0SmfoeOqepBoiqjJpfF0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EmDkLmoAK/q12AWqUCZybTTQE29negPan0EGZ981gCs=; b=ThDmxOTMSHTypDANfInlOmd/CLyaDrzbsB9ad3NebxQ2mHc4E4JR764MG4sGu68IsZKu5K4S0WsPnShsirOm2Aj+yLiX6wBDsTUWObdl68BF9dOvT9teLo2LOzs7lxpx0djebwUu28hYU/D3JabM4HoaDJ7qs924oBfVjFUpCDO6yWSEbEMQ5zMNhiH7L9qHJFLJJ2a1u/Rf+Tn5msO80eSNTC/7kOQEBbr2hHmamrc7eIJbUTSttTFeQbXzsX09ToLiFZ+W21U4Fk4hKcVKPh9qhyYs6KYfXXHfeiz9yOLBVIPTZji19neA3nlS8IzdB78TUfqFJ42ypcfqOg7SMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmDkLmoAK/q12AWqUCZybTTQE29negPan0EGZ981gCs=; b=spqnVR3G2wmX8vVVu8q/liK7Zuk5ezjE/ffeghlevxz6BK1DwNFlNh78eGSVaaVXKsLVGjeYtOK4KRBu73siQlaaLpjjQwS0XJMXQoPv7r4NcyPOpmLaubfZNVswAB+lQqRDH3JXfsV+cbR+zY7vOcekUglclCfm9S+wOny+oec= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB4074.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:15:31 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:31 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 13/14] dmaengine: dw-edma-pcie: Add chip flags to match data Date: Fri, 10 Jul 2026 17:15:17 +0900 Message-ID: <20260710081518.2394357-14-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0298.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c8::12) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB4074:EE_ X-MS-Office365-Filtering-Correlation-Id: 6bac8f4a-c1ac-40a3-59a0-08dede5b68fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|10070799003|23010399003|366016|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: rpn8UW1ttvaGIcO00GRfhMQRNalFr7Iltcu9IwCj/fYWz8kO9+E/4BUnjoLUm8C7HajaJzgkoLuaTjPw5DHek6PogK5buxLuYpPwpNBDCAXA+QOTOgQJWusSX/isrHehhgRT2pt2Sr3QvlIrD0r1cCyrlOmAjDr8pCUSfqmY+pPPPCZqWj3eU+afqkqB8X4KEdVWVoWhxiyZlIMrfIX5dnggEb6mTEq6Qs75DXucjqbO1FksdvYR4Q/bCQM6IH9sNWZu0tswtFsLtriubNpr1907iMsgC0ncANU6mVHI8JEGKP4Z06OmYk1Ypkey4jvhrgEbrHKTkzsR/6HHJE59S4zIX92swjjq7gWDgmbr/3NRlmXI1P9SXJhWV08KoI8wtRZSrw36ltKxFS09a3kxidvDJy0uMEZw1Yl3k0N3Sq84sDdgclvDnJc9CexrAHSlisUYScXHUIoGflLvS3jU52mL1yg4ue/Gu/FxVQ7J2rk0KhjMnMN+yaVD6OFAbZrusoELFci7i9A7o6GeMz+tar5BNvuYBLniWXgYiDnG8SB/sO+T6vSA4J5/BNfxqS9Am33JeoKyOm7OSQb8nyqHXvfFT8GQOsun5OS5AJ0nluGjO92p2PPpBfO/EQstZgpmoSHBNRYyKUGjJ6rGk+5J4HSjX8ITThO7Q/7bqeBEnJ0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(10070799003)(23010399003)(366016)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LVJ8U/yHd9RN8VHAXyrPq9uiS6ARm9YgTkfREZvfabKYF6uUB5RgowNCzh0X?= =?us-ascii?Q?AiG5U81076zWRgIS/K6j1nNRlfh5S2a3xPyKBYEXtDHOx0S8BFHvGlIE0uIA?= =?us-ascii?Q?XOaryX7/L6w3ZR8eCB0g/dTOOkkFLR2aUHi6ZGyxXGe9n++HvwPZMNrPRQZy?= =?us-ascii?Q?2kViyuS2Vk9TGs4TaIO8uB8JGQszpOUxBWszuB0df5Iiq4GWJNXqUTApWe3s?= =?us-ascii?Q?vmCejKuli1FPhiOexr/BJzIz2xEyEn1h3aCFdRKJa9+zApoRgcANuiYNaUiI?= =?us-ascii?Q?2rYIq0azT4/GtLhfj/FxEyIayCJvn+V+83FtmH6yl4WzTu38gpuLBOPTOe0v?= =?us-ascii?Q?4R5c185TZlo1sgdsxvsV8mvnQ90tKMN2A/nYhfNnBNWq4Zd7fFAHdPOitXBH?= =?us-ascii?Q?IEm17ylKsAJowjELlsQnGsMwqTezVvaXxTebxmrR/ksEpMBH4XzOeIKHF9Ho?= =?us-ascii?Q?dTyyJFNQ1+9q5Wc8dpPpl/anQyZrF7rFhXg0W08au8LwN+xVuu+6Cphz3oAr?= =?us-ascii?Q?bD+uPJ94mw/QVSown4yBEdGUQvaMjUSSZhFS4Y1s0AQJunVrve/G+pMEeDfs?= =?us-ascii?Q?Y8c4pVKM3vwZ8TB4n5C8Bm5kxp1jmj+EljMqWr0cfHNr00jB7+a40m8T2D3L?= =?us-ascii?Q?poKrUR/dE2p9aar4sjhsWof8d4zl87meiP2gjUGXolmJelXZ51fh0V3zEpM7?= =?us-ascii?Q?cMsWpe8q0864dDhmva68R39YjpB51NTJklZGBf0cPSAukf7KE77c4T1XcuFa?= =?us-ascii?Q?+CrCeLQ93ALgAMciUZCtYlMeYutISeMWjQfjiTdVdy0HVXahxlqhmBnoo0B8?= =?us-ascii?Q?xPF4PwiESpVqsnJpt0F6N/gCs9ZabVxoV6QBJ2n8MrQzkHviOxZO6gK6CO0d?= =?us-ascii?Q?x9hwA62250gSr3QMGRJSp1etr+rwviDmq6LcI/d1gUFW8zaZCp2CNreTGuLA?= =?us-ascii?Q?1CNlkSPOmIRpI+4Vxhg5jUhBaINef9TXsozryNlMvzuL40EjUfZpcGkTSfuT?= =?us-ascii?Q?9EME3LARNi/Wx4IU608M2c7DzU28AWQ7aJUDPKXhwL9sgeHRxf3H4vxUQYWq?= =?us-ascii?Q?GPHWZYL46IgaJbr6QgNxeYYgu6jcq7ZuHDaug6uVEjcLLCfVln+2eQ3d4wZO?= =?us-ascii?Q?CUIvSZ4C2xinpJB5tfEhEQ7nbiPheCMqYCVY+pF3DWtjPpIAVi2VDEBKUEaW?= =?us-ascii?Q?nJRZ4OxNYBGVjywVd8ZaKH4W18d9WuntuDhYatFOmo0GeN+avaQekxELcT7I?= =?us-ascii?Q?Kwfb+iqAH6JPysIsvif+MoFd8tC8I1hiGFOfWDPEYQH7mpJ68oEWIWQs9wgq?= =?us-ascii?Q?rvX2YgWwBZYFzxtcOEm/OK2mTp1hK8JZCZBQ0+2S/5NfGlOubk06x7Y1tzR6?= =?us-ascii?Q?ugZrVdNAYsp1RwMWHV5BGgFH2V9t4ROg0UQCDIlkfDJ4tOOogQ0JcUu7HsOp?= =?us-ascii?Q?mmndARAu9oSImdidRq8HCY1xoaL8gDt5O4DO67iCPyJqvzm3rYpQKfvxqGzQ?= =?us-ascii?Q?Dh47PndhrbiXBvjo8K8sHyPl+SnPMqT2CBCt8nuAvZ6rQ67mv9Pp1gA4ABoq?= =?us-ascii?Q?Rcv2PpsTP2IZfzPpUZa81nA8TAz/npa+vNeQJu0bKUy19VMTLvDny1hZrTA2?= =?us-ascii?Q?/NzqueKozvUBKMQ+4pEEpQh2OLNEEExMoXjGZW6SebwZ6X5uywC5fUIdbxB3?= =?us-ascii?Q?mK1RQBF71xB3AodGCLOTUvyd4GRaev6/fGAk4z6KOx3pbR+87S+ps/VHOFqN?= =?us-ascii?Q?+RRoPc9akHCBqJhA2HR3ab32GNM/uzLryrSG1d/hEIhcEryGB+nB?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 6bac8f4a-c1ac-40a3-59a0-08dede5b68fc X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:31.8665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EuLwHU2yjxfxYZkAtRAmtetUNzC8HqPbzB0dJZqcHd1bOCavK6VKhnOopQEwFBn04meo+bRxYyT58QPKYvM/4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4074 Content-Type: text/plain; charset="utf-8" Allow PCI ID match data to pass dw_edma_chip flags into dw_edma_probe(). This keeps per-device policy in the match data instead of open-coding it in probe(). Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v4: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index d72c0a19c604..c1585c8ce11f 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -88,6 +88,7 @@ struct dw_edma_pcie_match_data { int (*parse_caps)(struct pci_dev *pdev, struct dw_edma_pcie_data *pdata); unsigned long flags; + u32 chip_flags; }; =20 #define DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF BIT(0) @@ -471,6 +472,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, chip->dev =3D dev; =20 chip->mf =3D dma_data->mf; + chip->flags =3D match->chip_flags; chip->nr_irqs =3D nr_irqs; chip->ops =3D match->plat_ops; chip->cfg_non_ll =3D dma_data->cfg_non_ll; --=20 2.51.0 From nobody Sun Jul 26 01:50:07 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11021109.outbound.protection.outlook.com [52.101.125.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C373F077C; Fri, 10 Jul 2026 08:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671340; cv=fail; b=PBbmTJ3A24qDpmi+yvKJfIRoZM2eoI00Du+5BaFzn98Kewcox45myWchZuRbhnCjNmy8EBAHFu/CcF8Ew82B/qh3Elw9nzPCTHDjw4ryrT5UZ257w0YomYnvsXV6w3Mu7uLUbr6Ph9R7+OMLV+UdwhjoUw+EB2NOzmiIlFla1sI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671340; c=relaxed/simple; bh=87Mi56zs6x+/foTeWZbyEoxJB5+XmWVMnc0D2d6xJzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XcIbfMQ9adA1+tUt7D9dPtlC4j/YNlulMACqA1Gz4OhO8sf1lgdJo8Kk37v9KRBrlPUqG9momxunbb1JtTkTKU0hEXQkvU7hL+5Q3y8UjJIzRVAR2fFFOJN+wZ6NMVXKHRJC8EGgP9lke94zDxI4iOxb5Tj+8ZcrYDjp/Evg2zk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=iDpRMSLM; arc=fail smtp.client-ip=52.101.125.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="iDpRMSLM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I/+glu6fRDXl6F5QzGo4kdIJqYK7sMqyLQXPe5Tb1ProTiTimWgTRs2hVxXyXWjuRWU7gHU2pwaW+rPAao40Qvvu3/YKwfenJqiO0k8SBNe8M2+vzbDfGE3rTmpYzjUzPgke9RUeSsFoYOCKRGUzjly27xnr6iJcndkHic5c2WO+Tz5ElLns1NkjNbIFGPaByLu1+UYPDRi9iqqayyN08fWqO9QKnsQBuGjjM0ykh1JBhEANJGbKfgwWVxcsLrjRZofOIjUxhFUtkCvakNSK2U/6CTwaRben3UnAjX76N/jZ11H7yhAQB5L0VZuT7zNo4pNsDoHIgMhxgw5JaNR0Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vnwah8BwHU6jK9arv+L3swOkgV4SpS0huuco/+51LZ4=; b=JT1fki+qJZ8zOjqsVaEzKdxDgefdk9e9SZU0APdO/fNE2nrjmpgUwjxDNO8e3RUZizOGolHIccwgijRIJHw/go9b/FDNgQVtERMWxA4cePC5G8eML8qBkcz1y/nODIR3S+E11qiVJTyA0/KxFUVwHAjuXlxluEnm0nAA+fQpO7w2mQZOyK4XdBN154zkJ1Ud739eHkKuQvt/8k2DwyASNH6TUTxdPkjGqMg8rOlPEOxudzMRPr6nMo3UdQ2KnkFlJrtyemRqJtQd04jDKMcto7cGbxHqv3PM8+rQHztg9mNzWwOK0ykyNvQ550v06Bqd+nCq3XdLKt0FYXHa6YsaSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vnwah8BwHU6jK9arv+L3swOkgV4SpS0huuco/+51LZ4=; b=iDpRMSLMFDO1A2fFj1DusH/Qf0349E52WA3JFBy+1aV4okmDsG/K5oARE2fNOIr7yuQoA5AyfJk89qUzvtlf8fgF3MTxUHXtG91JV+j3AaOkldpOrMA62vytN3MMv/4RX2Zp7UM8S6KMiI/wPOqdr/nW4ObeQTnqNsgBwNFHlPw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by OS9P286MB4074.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:15:32 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:15:32 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 14/14] dmaengine: dw-edma: Program endpoint function numbers Date: Fri, 10 Jul 2026 17:15:18 +0900 Message-ID: <20260710081518.2394357-15-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710081518.2394357-1-den@valinux.co.jp> References: <20260710081518.2394357-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P301CA0019.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::13) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|OS9P286MB4074:EE_ X-MS-Office365-Filtering-Correlation-Id: a65dd1f4-40e1-4e59-56bf-08dede5b697f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|10070799003|23010399003|366016|5023799004|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: /5Ouw9D8+EMStllF8Syfxvf9QsxDP92mjyhRV0+qqT+7Ux5arBaF9DUBOGSVMXRSArHdRSvMuvK+0Q7uf6wuHcAce4FxD0kEKJt3I2ysL3bsMQ2PzetOa+GHmETTm2J4/eKAE6BMtIr/6uP483NMes/5Gb5vJdwH1Gw+4KDDxBJdZoUZinDfD3xBlajt67m1YLgBLCxxaTf09Wl4dudZmDYwcW9huSbKpoCYYphBY2i5lWCvOgEBA6FftEoPccXlJyjTPCaX7RZGgZY+ee2Yk9MdYz9ajufeQNUXLN5RpI3rW7ekvvnj0k/6O5lF3McKphStx2s22xmUqKMgynE8Os7YEUELLYpQ8SfLDNuozD1s7Bk/8CSBX+S3d5l/1/Rhapo+4G1rbxH6yJqDqs6Lvzj+BUc07Ao/irngBrl/Ozca7LXyZioxWyTduZR5Gdwo+9hmiMiGwp7D5zVWgKy17GnsY0HkRosshCNjQOW+QYGmVJVMzv+s1qQxD2e3uT3sx/ZVcNnKzCiWsc5DXtwSGfT52sURn1LpbP2AlwtOZZky6bsOBJXN2m/4kJqoyrqTBGDUFleSsa33N1xjcONbMWKrhgDDxqzodzEVlZ9rLOQMYTzig4f/ms005UomlINk1sYzw86JljNc8V3MideH/sxzaVmI9/0eVZuwlQN2/Xs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(10070799003)(23010399003)(366016)(5023799004)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5SDGRg5sZcrV3JYkUOgPp/04lPLIF2FX5Q6U6nJyrE1zPmEymcmn0tSwK8BU?= =?us-ascii?Q?8VvYhk/kOJYIDWNcmh7FSSnIZAcfz7kV2FOo2511A0hd/yOSXGlwoI8GQ89H?= =?us-ascii?Q?lEaGgTFdrf5sUrAT+h/jVSVWAjwmEmMmZx52lEHklKUCC/zLOERRUVgKqD/y?= =?us-ascii?Q?FIWUmQWC8dhT4vZGzJrwVXVDvAvpoTfOIMlqZUy5g+gdatqeoWgdl3xNdzcV?= =?us-ascii?Q?hqDqSIj5DGZFmB49GaQZ4y+xoz7s68njIFMaTkHquYkAotq2qdw4NygP/U0G?= =?us-ascii?Q?gYLaaETRd986+pxSm5tytYy4LYb4oZxRTHrRzoIj4JIJru9c1tTigcHglsEI?= =?us-ascii?Q?+itio9L/Gfk/5dtTvnwt2pNDcnGN+B9iQf7v/qPt6OmgSCZHv7lT3aY3rcZx?= =?us-ascii?Q?12VUhhSs77HjA5O2Hb8OAf3F61VfHBFtgGjeKQh7WqtE+vdnRapu7Pu2VTo9?= =?us-ascii?Q?/4kyhphh9VSw8heQexNG03z1VjQITi0iN4Ow8c0DfJXMHK6GSBAIuqfaTGF+?= =?us-ascii?Q?uB1WxYcv2lYPeuEiO5jZd1Awo16VTfD+/TCwzADAnMHb4ktNG9F17XXw6yvc?= =?us-ascii?Q?gGJ95WTA6hndLp6AUMx9uISv4p/kpa55EfbYvH4HFqLxHTDg1HmFPvjkBfF3?= =?us-ascii?Q?uoPoYY+dIRa9G95P5+BHETBakXKoYQb4Lk6q/vYyLiyj9VKNDHrXaan1PmWl?= =?us-ascii?Q?T0R6W3CAoLks0W8D2vhlNQAa68mUVVQfJWqqBbab6aySrv/UeMwdRAkPre8v?= =?us-ascii?Q?ctpEmseep4NwJvoAxtN1W+uqnjrXTgV8OnquQTiw1mpqr8ELg5Yy1NBE7FIx?= =?us-ascii?Q?cwprcbUTyUqzhNDVAXrF3fPnHP61HqK7uRflR8NeEz10Bbfx2KzgNenScAcN?= =?us-ascii?Q?uFCCmt583rsme7mdjX1Kcjy7odgmT0Rw0qNeSfARwE6Q1hfeB+Ra+i8F+wp0?= =?us-ascii?Q?XRsb2URKHzzVCgNugRyEk93CMXGa5HxhHDMCIiVYWkaTZ5LNqbZX6QgrUa2M?= =?us-ascii?Q?WbfbqKLMhxGB67GaEesBK1FPfxdAhMDqsBldayC/G55kJLLNeaNag68o9t7b?= =?us-ascii?Q?c8QZqPJ6m+m9YVRAxPwKML30Ru7PI/pbfwMibEwWC6aym6yz1OULbB6KUtOQ?= =?us-ascii?Q?mKWcmxDjrn4G1VALqe7UlmIhkEYWLSMqiwuFZSMvkd9R9TOH8oyuf8wu7Kx7?= =?us-ascii?Q?z4ZaTtJYnYEdOw7yxtLaPLwlKvqCTGzAyLzOCM4LqPP3XoCBOB308rXkOm9r?= =?us-ascii?Q?8tspni8jxe1/Kc4ZXxwGJicnoh8c6TLwDddstPlD+nZfOK2CaIReYAGdWwXk?= =?us-ascii?Q?9qtvgKtBGyX8UHF9pyEfjnjQ4BZgqPx6LpvBevUUdtsRBl9yrbVk33CbIosI?= =?us-ascii?Q?sU2n+8ZKgepZQPLAIrhhAaFPPSkpxtDWdSK7LJpSQfbQD2H1QWUKc+9bdTmx?= =?us-ascii?Q?F/uWIejE9+p24L/mYP+wgSF0zEqcQIXAdTk8vx9hh9WNAa/PD2ZIfogWk+0w?= =?us-ascii?Q?ydJeFXwVU9RY4KmEAfTwpQE/x2eNj1HSJjrmKisAhbxYDacKYNQoHf/Sglcd?= =?us-ascii?Q?iANiO5bK8pxJfnnnM402x3MOtscdE6gRrz/tqafndxo14nOe0jl3hSJ+ThgI?= =?us-ascii?Q?9ockTUQExNpCUPMN7HdByyOSVL6kYqr9hooztHFV3BjULgUn3av+7Tj6zQHt?= =?us-ascii?Q?1GJUiOptNWZNlaUXvGrdBg2mxnrOXJiYdIwbgKK67aavuto3zzZsS2mVg6xE?= =?us-ascii?Q?6MXIt9Yfxr3OtiEltAn+eGNmQKLUHn+0AF/zT6zdUUHq51xoUhgB?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: a65dd1f4-40e1-4e59-56bf-08dede5b697f X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:15:32.7170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TzGJdrgvl366FL1sIrBqEbzIBQkG25JDk688WNt5zSsEQx8DRX0dlNt3JW8LEJInm/wEXZ+BuYTjniepXeeElA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4074 Content-Type: text/plain; charset="utf-8" The eDMA/HDMA transfers the driver issues carry a requester function number in their TLPs, but nothing ever programs it: eDMA v0 leaves the FUNC_NUM field of the channel control word zero and HDMA leaves the per-channel func_num register at its reset value, so every transfer is attributed to function 0. That is invisible in single-function setups, but once the DMA block serves a non-zero endpoint function, its requests must carry that function's number for the host to attribute and translate them correctly. Record the function number in the chip data (PCI_FUNC() of the probing device for dw-edma-pcie) and program it per channel. Endpoint-local chip instances keep func_no at 0, so transfers issued by the endpoint-side driver remain PF0-attributed. Delegated channels are programmed by the host-side dw-edma-pcie instance when it takes over the channel, using that instance's PCI_FUNC(). Signed-off-by: Koichiro Den --- Changes in v4: - New patch in v4. drivers/dma/dw-edma/dw-edma-core.c | 1 + drivers/dma/dw-edma/dw-edma-core.h | 1 + drivers/dma/dw-edma/dw-edma-pcie.c | 1 + drivers/dma/dw-edma/dw-edma-v0-core.c | 10 +++++++++- drivers/dma/dw-edma/dw-hdma-v0-core.c | 3 +++ drivers/dma/dw-edma/dw-hdma-v0-regs.h | 1 + include/linux/dma/edma.h | 2 ++ 7 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 0d38de4480a0..d1af44124075 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -1016,6 +1016,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, = u32 wr_alloc, u32 rd_alloc) chan =3D &dw->chan[i]; =20 chan->dw =3D dw; + chan->func_no =3D chip->func_no; =20 if (i < dw->wr_ch_cnt) { chan->id =3D i; diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index 8657275d2484..1cf95ab27071 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -78,6 +78,7 @@ struct dw_edma_chan { struct dw_edma *dw; int id; enum dw_edma_dir dir; + u8 func_no; =20 u32 ll_max; =20 diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index c1585c8ce11f..bb477dc0fb03 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -473,6 +473,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 chip->mf =3D dma_data->mf; chip->flags =3D match->chip_flags; + chip->func_no =3D PCI_FUNC(pdev->devfn); chip->nr_irqs =3D nr_irqs; chip->ops =3D match->plat_ops; chip->cfg_non_ll =3D dma_data->cfg_non_ll; diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index 32df5d13ba8b..441fa8f67d5a 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -25,6 +25,8 @@ enum dw_edma_control { DW_EDMA_V0_LLE =3D BIT(9), }; =20 +#define EDMA_V0_FUNC_NUM_MASK GENMASK(16, 12) + static inline struct dw_edma_v0_regs __iomem *__dw_regs(struct dw_edma *dw) { return dw->chip->reg_base; @@ -159,6 +161,11 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw= _edma_dir dir, u16 ch, #define GET_CH_32(dw, dir, ch, name) \ readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name)) =20 +static u32 dw_edma_v0_func_num(struct dw_edma_chan *chan) +{ + return FIELD_PREP(EDMA_V0_FUNC_NUM_MASK, chan->func_no); +} + /* eDMA management callbacks */ static void dw_edma_v0_core_dir_off(struct dw_edma *dw, enum dw_edma_dir d= ir) { @@ -474,7 +481,8 @@ static void dw_edma_v0_core_start(struct dw_edma_chunk = *chunk, bool first) =20 /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, ch_control1, - (DW_EDMA_V0_CCS | DW_EDMA_V0_LLE)); + DW_EDMA_V0_CCS | DW_EDMA_V0_LLE | + dw_edma_v0_func_num(chan)); /* Linked list */ /* llp is not aligned on 64bit -> keep 32bit accesses */ SET_CH_32(dw, chan->dir, chan->id, llp.lsb, diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index be22f9f811ca..ea9f18c8d707 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -375,6 +375,9 @@ static void dw_hdma_v0_core_ch_config(struct dw_edma_ch= an *chan) SET_CH_32(dw, chan->dir, chan->id, msi_abort.msb, chan->msi.address_hi); /* config MSI data */ SET_CH_32(dw, chan->dir, chan->id, msi_msgdata, chan->msi.data); + /* Configure the requester function number used by outbound TLPs. */ + SET_CH_32(dw, chan->dir, chan->id, func_num, + FIELD_PREP(HDMA_V0_FUNC_NUM_PF_MASK, chan->func_no)); } =20 /* HDMA debugfs callbacks */ diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw= -hdma-v0-regs.h index 7759ba9b4850..2bbcc7fabb0a 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-regs.h +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h @@ -24,6 +24,7 @@ #define HDMA_V0_CONSUMER_CYCLE_BIT BIT(0) #define HDMA_V0_DOORBELL_START BIT(0) #define HDMA_V0_CH_STATUS_MASK GENMASK(1, 0) +#define HDMA_V0_FUNC_NUM_PF_MASK GENMASK(7, 0) =20 struct dw_hdma_v0_ch_regs { u32 ch_en; /* 0x0000 */ diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index 3c33d12d1cdb..64044451d182 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -116,6 +116,7 @@ enum dw_edma_ch_irq_mode { * @db_irq: Virtual IRQ dedicated to interrupt emulation * @db_offset: Offset from DMA register base * @mf: DMA register map format + * @func_no: PCI endpoint function number used by DMA TLPs * @dw: struct dw_edma that is filled by dw_edma_probe() */ struct dw_edma_chip { @@ -141,6 +142,7 @@ struct dw_edma_chip { resource_size_t db_offset; =20 enum dw_edma_map_format mf; + u8 func_no; =20 struct dw_edma *dw; bool cfg_non_ll; --=20 2.51.0