From nobody Sun Jul 26 01:57:16 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020099.outbound.protection.outlook.com [52.101.228.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FB873E2AD7; Fri, 10 Jul 2026 08:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.99 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670960; cv=fail; b=f3XCrjmmRxMF6Jh3OaEA7JgIcf5U/1l4xrCUTHdywXDJjCjzNBMg7OZDvwDrdaDBuKIE5PYCe1/thMe3kxpi3B3aid9MS29qYzf+jY1FM9W7yj0icGTPS7gFP6CHXfMijI9+D/l1BM24aQl+z5ZyEqoaXQNdAwb2H7TltwRthr4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670960; c=relaxed/simple; bh=Zl5EJ+6od1lom5OI4o3WpwlyoB5LqoufO12Tytrs0Yw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hGpVNkwM2GgJFQ07JwdOWNIC2WWwfD6UkQ1/3UUkM5iUeh/3eGFXbIUcl8qHCPCHarPxyafTchBUS2vb+jhqLG/MQXvP5U8UftjXYrQ3E1izRzs/8mGjpQhikx9BdFK45P9vpaNfDIZ4QLhUfmKiOn+bYZCzDpIDYr6wLyafcCA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=k66zdhoE; arc=fail smtp.client-ip=52.101.228.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="k66zdhoE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FGAAXKWIlwf9FLi89zqDmC3YmJQaSZJ1Whc5FP6HHyJugHLKKzxegkEHyl//0Vu6RkzKdrRmHqA/zSfvmR35QglS328F4OhXVmr6l20z5KTRnmWZmk7pRVBqmw6L3js5UvQWQtY0SMWnjUJ1VHT+KAfBVcm+b167119D0A3j9vjmly/byh3WJzRs65ydoBQg1Fq/oIe+DtvgpGZripUq+h8oRbMo+QeEivymL/b4PJbO+MB00bwO9VVFB87RkJp0Hpw/Un42GTRON2OnzdRTXJfGR3eMJ2xXOo8MsMr2SSg/lWBEx7c78UsXKjsUF4ETXNBY3UMlKLEC3nY9KakqbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QCfcREcRESYitW2g4iibxkniDIgNYXPZLFZPwZaPh9s=; b=fHsFEmNrZoI/jdWzihM1AmHLIwb4EnLVgHv3tDbH+/yfOlVfmq2+P6nr+m+UH9Cp9ZuQRRTay6rXuY4kRcwvYKyFsYXljHG8eSnR/bxdlS02F065oJhxOhYzTiQUedfz5H/MfrnPlFtqexOfb/Li4n2ZUth2o2sD7Xh+mAqFX0zPE1FGoRNxCzzrXu9eFQH1YZHY8nTwwmBU5jrsJdMZlQjQTJJZyot7N9+W5Gwngq0pvd3rQAMVsDalb6e5CFlu4jqs4bBw5HT5Ka6gCrzDd594tcQ09KXVIMRaNMcu0Zu6EuNNmfLngFrdO/ZXiqfmN55uNhwUx1QM0i+qiq1g0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QCfcREcRESYitW2g4iibxkniDIgNYXPZLFZPwZaPh9s=; b=k66zdhoEV296aIccwgJmYBij9wJTInrpP7xDQ58bxe9qnALIDK+2g1w58xl9tVPOecbjdZvpZSIahrVb9H7ZDMA930ihrZjK1smG4zRP+Sy6DFF4OkgEtbTsYsS03DND5TZB2ZjW8Rd4RnA4/cWSSNHzziGb1DgIqArx4AbrzBU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:10 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:10 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] dmaengine: dw-edma: Fix HDMA channel status register access Date: Fri, 10 Jul 2026 17:08:57 +0900 Message-ID: <20260710080903.2392888-2-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0085.jpnprd01.prod.outlook.com (2603:1096:405:36c::8) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: 82317157-799f-4a4e-71a4-08dede5a85ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: OinTEYRc9QXSugTsP6LlcRT572QkHSykQPDZl/6wt3+1izvQPuas87NNN8VGWvW5Pu1nDdLu1T7Sc1oyfxzU506rxhd/PCw/4i646TqN4qqTuEC8eurr8h08gKOfPWLogzmuxBx7z/NjWWzRWAWdLnCjQfN8qE9RnjNzHuEb7ujJpTl8glUWOMICC7hEq2qJKRYyeVZjxcz8q6B9MMr1dWZ3cv/q52FZkB6a/t1LHW2OGCJc9fqvaDvrzz4l72lRClDFJGSvSTHhsjahbBkEOl7tNOgJETClv98OE1rDXnQbqq1+0mEGAqzhFN0ixj0zzKIup/PGJ8CuAyxdLBWXzdKxVVJTh6i8HEznS9WeUoqVoLpkemAchJHVzoll+WPxULRYrirZa3MH9LV0ou03XYmXPI/JoSbfrdra9rjj8Jp98MiS83HxchGb9wQyG2GuCfnIf40+FkJ862HIc4JTiIYpMqt28u6G8mi5WHWo88oYHylKQ+5fRRZiV5deZzvkSQEWADR9SMpqQ/f4x+tzAaJuD6uzdra8GlMrdyLKT3LxlSG+lmXm23mFu6ICZ0sB7YNNflR2hjbj7K4H3odDJFUw4McVxrR9GRNAKe3toAduv4eaXI3Q2vtDLNqmrGFAJgU1xtbhwL+xiMLTGYfPKn50+SxRF2BX/nJPRvjCQiI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x/Oa3BoNpucfCQYGwiFjvi/SWcrJ3u7rSCP0q+N143alL+/P1onpvoD9OVLr?= =?us-ascii?Q?sxmiWmowb/sxoC8zBEhZx4iarhVXFiU74/codDzD7lwpNVTyCRIy0gYihb5c?= =?us-ascii?Q?W4UNtz5NXOaiXoJfznBV6gZ5TLTTTnvbNfLj4L0Y6IGKsAc7XnayX1I2Yyox?= =?us-ascii?Q?kACoL4pghTcJVhg0NUP6BLmnEclnEtXqcPMunVgc9x3wtFPaJ76Vx4Rz8mEx?= =?us-ascii?Q?H3Sy8vzYmaBmQ9FDYz0eMyCHahl1LZspeKgeet849AJ/TWKBZg6YCoi+iKxK?= =?us-ascii?Q?WTYp9sWUgxA3ivSfSaoM1fvmCR8+5OGnrGIQnnGF789NHxo5QV3Fb2KfE8BL?= =?us-ascii?Q?oC87GToVbEuLp/JQsZUzRyss7m5fqp95U7tIRXLO+DSTTU2WcgDVPUMUfKsr?= =?us-ascii?Q?1VgDMX5pF6EBgvZ9XlkxXVv9sMPjnPcHgkzFM5KsW8vo1ozwWzCE2uf9sGfa?= =?us-ascii?Q?AhZ5uv1j9QpZdn6Yn2UylvEdKH3w9k1/uxDkQedihcYzQYMGdnNdNrFZfP0J?= =?us-ascii?Q?szo4RhB/1SymEGgpGu1JYHHIDBMGIFdk5Oy/Z/yuYjr05xFTWZi8tysYVv3S?= =?us-ascii?Q?ZHlwgi3yVMK8WtBoqHImZEIetc/asLBjgc4eTRJiGQIgsZAWhFVASU2JKmQG?= =?us-ascii?Q?78psgEyVvzIhumCWN6BNFaVUNEZcXAB9gc7XN636Jlt5WguVIZdepnkEYk5a?= =?us-ascii?Q?cNis4ZKkw9QOOtjzMrQ0lRS2AHO3OIkqbVK85MHdUcppcykR1lyL8ffXsQlR?= =?us-ascii?Q?gp6LDyIsD4utljCwHwpllSqGsRbuK74uxSE4/WUBs3inB5rt/HGLO03jzCp1?= =?us-ascii?Q?kzJh2vLqw+oNNOvxqFlg+j/x4R3lmFz7GIZP/sAzAbQM4+Dukg/u0cIvqo6V?= =?us-ascii?Q?eQjX3i/twiwk7AeKV4SfQgs/FuW8ToWfN6Y4v7cH+bNg5lSNwa0pyRNL46JP?= =?us-ascii?Q?XBR5kTfl0r0BD8UeuG6T6C1VHzO8NAjHaPPH99j6Fun5c3o+EGfE5DbUpI0o?= =?us-ascii?Q?6DxzZiVDOukyNKfXexWktGyHSRZ47Udsq5IutLWT6s+IOuKtxjYsJM5/wEJo?= =?us-ascii?Q?N0b7uBqTZlMvMoZrvWmVujT9wS/0zFPAOSnkIS4DqVLQz+Am/NaVqkDsvtnB?= =?us-ascii?Q?ca3h5GRXq4MF4D+/kwPF1QPphbCUhvtV419gx3drFaYDdkR43zw19BKgS4N/?= =?us-ascii?Q?NB7yXoAN1K6rtyr3s8rErkxsMEiIjJN0HM9+G+iu/ZwB2WN5w+XcUQIg/8GH?= =?us-ascii?Q?INsdqdLKu6bBwg74Wz6Ji/0IDeu8rFe0AdAEBx2SnK1OeUZDryaXOxcKqrAs?= =?us-ascii?Q?ACEbgBMj621tGWAxn7WrHiMwfjIR6JWfj+TkchHzd0zHeR2cwDBVA3+sOb8e?= =?us-ascii?Q?CEQYACADf7KRayXmPX/iaPwfBoW+GEDQ6DcaUnOtOJLAML4PO6VHAklCnrdK?= =?us-ascii?Q?KWhNihoET89IHinPIA45moJPOZG6SE7XsVBd75BHVWpqJRk+/RHBgyNmZjKW?= =?us-ascii?Q?xyVAMCj9R0w3Wv7f6DQNaDxjmXLrpfZQuswY7wsBFtg+7+Lb2T4NW1rDWJR/?= =?us-ascii?Q?zPFFfl+UxcKzHac2+fTBW9AuzrbEflWL7VXL/KVsS+zMXaTLzekKsyhTfgTe?= =?us-ascii?Q?RJYx80F7hd1FUS6pa30B9rlRjNNIMqKpmBQUayjaC5zD1Olq7L+cBSes2jWQ?= =?us-ascii?Q?UeyB41e7KFes62OoK85+3WxGI0M5ql8nBCeX7KuiG8QDrhhLnfy/+CwDjOEj?= =?us-ascii?Q?r17zsp0PDDrZP01FQv4JPt05qk1d8yJYYv77R4iWsK80Z+hFd1dq?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 82317157-799f-4a4e-71a4-08dede5a85ab X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:10.4723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r3Y0+ToNiEONt7HFQgd9aMssu/plnD/lAVTizmVCcB0B0UN8ABJ6mXzbvHCpJOwAq8e7O8GnVehQkUUkBbQAVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" GET_CH_32() takes the direction before the channel ID, but dw_hdma_v0_core_ch_status() passed them in the opposite order. This can make the status callback read another HDMA channel status register. Use the same argument order as the other HDMA register accesses. Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") Cc: stable@vger.kernel.org Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v2: - Split out into this preparation series (was patch 02/17 of the dynamic LL appends v1); no changes to the patch itself. - Collect Frank's Reviewed-by. drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index 632abb8b481c..2beec876b184 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -79,7 +79,7 @@ static enum dma_status dw_hdma_v0_core_ch_status(struct d= w_edma_chan *chan) u32 tmp; =20 tmp =3D FIELD_GET(HDMA_V0_CH_STATUS_MASK, - GET_CH_32(dw, chan->id, chan->dir, ch_stat)); + GET_CH_32(dw, chan->dir, chan->id, ch_stat)); =20 if (tmp =3D=3D 1) return DMA_IN_PROGRESS; --=20 2.51.0 From nobody Sun Jul 26 01:57:16 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020075.outbound.protection.outlook.com [52.101.229.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077193E7BB6; Fri, 10 Jul 2026 08:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670961; cv=fail; b=Tw6xxKrMLAXB6DWIOSDmUgqLKvT3QyBQqFptA5DGLAe+bFD1UXGxVtOAmQFML+bFIEJ2LMJW5MyyZl7XptXli2l8WZvEBJnuU2HsahInYhHz72o05jpCHJqSHZkMZmC63JZI2xirEORbbW46xEYZs4cuGpxa5Lcn7gMkfWQkD1I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670961; c=relaxed/simple; bh=JsEZQXKqWAEJktQtI5ErUHf+TAxz7DLzOrxnpvAwcrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=uIaj5uSCuYMbZsasZDELpirsPvxE7YM45uKBuSSKXImHJwjfa5ydDjzHYIuVmKTa+ZUHKbXSjzk0DjvJor/U2IHwxEZOwikUxzj/kR+SNn5MYrn52LN+AmfYgM+gWv/boPJuG6tWRbyCKQ+w2IDW4D4pHM/P8V8xT6k12I3h0Ts= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=wrtu7hWH; arc=fail smtp.client-ip=52.101.229.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="wrtu7hWH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CVbYQAk2rXk4f5M1V8frSWOLs9V0RsAZ+wvMUawc74Ev5bKpdxrmytDPkRl1nCfb2N/TLiKU6co74tXscoFcDeIXGjtyH0TCLXTGRi/lP3R3CEel2BXbOuFoHdlrFPDtBp5CPzjEhz2sYotvaLd9yt2WpCMRRS2cf9kui1Fjbxe6XykZUA97LFpYqqnjgOFR7AGy6zQITD545iOP885S6+aBZCqYWl16vBV73kZ/8Jp3clLAQhdC/2y3UnD+v+Gy5WtKAtNVI9rxskcfkYpGifv0JXpG5FKrKG9GQPBae3vQZfNX9kptsFZ14si+9njg4g6qf3ZyyaJR0Qds9Syaeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AN44N5sgwYpjX8s09akjVFtKRvtwRd6q7wZ5nyMdeck=; b=FzExeB5yCYEsDaGPiD1KvFAzhuOkdleprPklmByCpNAe2tYlu7pIrJJlIN1KiW4DvMcGnNR2LnYnq4oZ9/HVBLukDsKxo1AfFxq4JYVrFVXVUuS43fhMbQ2bfC5/dTCEMEc/NTTZEYFMTV+RaTz/5mZiZO4YPFg2ijWYysDtO5IiQUrgtNUIHl+dGgHYr3rKVRClTzT+UcAyxDzcM05GkbL1Nfetrn7BnhAT9KLTgV5eKP54lSKu/z9yfgIQG92SSH22H8n+BU6yd5kPb/Ibwt5Xh0Yle+eZuAQY9mFxOwtEBE9bvW6UM4Pl4grfQfk2sohpQCbyIpEYkbyPNIVNXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AN44N5sgwYpjX8s09akjVFtKRvtwRd6q7wZ5nyMdeck=; b=wrtu7hWHJ/90mKiZcVqo0kt0hnpOfpq13J8sqVrDZ1AaH5TMOk1m3Z6rwgEsYOlxdy2iC32wpWJrxJSSWnZIyzYQQA77QbLBxpHoQ0at3cqkcwVYuSw2CkllW/jSrYM/sY1RcTOq4qdOv1BNkBP9eH2YUbQAfbSqnCDp7aOl9J4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:11 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:11 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] dmaengine: dw-edma: Terminate STOP requests without callbacks Date: Fri, 10 Jul 2026 17:08:58 +0900 Message-ID: <20260710080903.2392888-3-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0155.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:383::13) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: 26c171a2-ac77-4b0e-d63a-08dede5a8637 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|5023799004|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: HgqpnwzTIo0sBm0J+/oRN47Q2NbAk1dcF8+rw38hCDBb/wf3e6oBKSkIDRidpQ6kzqWFpKTRSZM+Gtp9s23dMOPSwScEOhxqA1gMail0hBUOXn0rQicx3R8/T6vmSYlhpzwQQGS9jWP/5k/rcq54kkDVMPHuk1eZcJCyakM1nDvv6XhKX5MGfxgGHns0WCBm6xfIDXpj+WYM2vQ+A1ko00V++EtZIyY1NbD6RPoYx4g9A+1hYyWuVgYozDnUFKRU66VTqWNJze7l+A3ODi9INlpQImgm9FgO+LDhSojn3XJMPDCSJng602lwgNBN2DrCabsBr+/FAcTrU3D9ax0B+nw/IhQgvDFGXa2v34fFI4jOpawxQDia9rey/+a7xN8kXWOf6B5CwrniklYks4A6/7WCkfGHuwI7x3o24xtzFFqbGplbOr+KaypSYXtqu8/B4foi7r5wR5/P0LUAY0lLzbIUCuKyApfX4TeafDjW7tnTWv7eIYro55TM5XaKhPsOpcKf8nOjqtqt29Msm+rkDKSSecSSx8zHG6WT7cbjRJq7JDAJU+DJsp8fSugkW5fXn5GdYftusBgmlCkV4VEYOY6Gp5aWNovUuY9KYjRO904Niciq1UDRH+8A6OlDx2ZurHO+LV9BYS3rRrg9qrbatV0tgz+sttqdepNJ4un3j+U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(5023799004)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aF54AuJ8oV2H9BybHvGyWOMi2VCZZh+sg3YvL4ZccSM0pggsZ8v0YeXCSm2d?= =?us-ascii?Q?af7kOMhId0H0dt8ORk6SMiDDVppQnohJ/sCROkmmOoGZtQBUwU/jZ9x13+rC?= =?us-ascii?Q?EuBJ7kIH3iYK/r3/IgKf0re4DyZjFRzp337hV3xmlG0LDNDQnxR5Cnp/LbHs?= =?us-ascii?Q?vmEPADgqApRLxBO1KOcPNide+QcNhrLDB9CpeBZZndrDiprftnsJNCQ+gXkq?= =?us-ascii?Q?xDhpEDD78enbHPLIbVRgwS1gWEnDYydKH1Z5wIxogkZniZik5Lc1XVec0J2/?= =?us-ascii?Q?MTxsCXzeV28SgzP+2BpJJbUMHoHvykzyjY/u8paL+D6em3npAz2sv5fk+S96?= =?us-ascii?Q?6t7BC138/l9XVA0Y6vzUJjQebW076CA+IbVqwZ+Pz1FXcEi4iMO6w9L9+8PS?= =?us-ascii?Q?YLXBxIiofnRQch56t9wjn001wn6pfvvCluFOOe4h4gjkudepMUqRghGEewPY?= =?us-ascii?Q?tr3K28mpuwRYj707aBADowiy61UReXu7NGO4AyJyori3skPpvYfkbQI7JDR5?= =?us-ascii?Q?+81lCKepK5w8z+WchmzIivyMOOPf7c5vsaq4o2owWL756aTx++exQD/kyTE8?= =?us-ascii?Q?eLjrkAbQNVLU+3IWSQhtOK8RDrPxV07WILEnuwUFVz1Z+Nxo1RZobYErVahL?= =?us-ascii?Q?pLLFO8Whr5r/q2/UemV3kOmtVcgKlXUKwcdR6Nwa8fXToeqBkov/sMbP5cR7?= =?us-ascii?Q?lLnzYFOePKrp+CSJVSVsmHIh1/3v5AVcVo1oNcConQr4CRGsp7WQ/S9tgro/?= =?us-ascii?Q?rmVgEpaetb9NaSLvLAV1HLo6NaVuexMPm4olfsFlDnXhMWh+omKQjJsxSH/z?= =?us-ascii?Q?9KEQ3PokSSjo+FmXYKmx90U89Os8VjfW7dNN3cGfRFLuwx7RirNGGVRtPRVU?= =?us-ascii?Q?GWTgBrpVomltiWnErdmgyE8u+bHzejBp6Djl9U4ff4wkPe/ieT+J32REp1iE?= =?us-ascii?Q?Y8fIvEj1VxmptmBOo9ux1RnpR+dOMTfmaLhBEyZu1xj6Sn4eoznd6qeYKyL9?= =?us-ascii?Q?KXhYjKBtd9GQ86HEDmua8qzJA3U7noAgJskp57URAiUlf2uvfrC0Sbya0WAg?= =?us-ascii?Q?VqjjiwVOd58qhom2jEUZpbbKTQ8PsxG9jbjAIqbYgsDPITHKTJSK9Jbt+djh?= =?us-ascii?Q?xGuCOu1ToHBpAtWSAtLSIxGFO9FtOJsfMOBr4SuEgK9Fx6tDownwAOAMSZ7T?= =?us-ascii?Q?M1rw4y/yJJ8VeIBN43MAOxkuOmfytaWElamtOiifpKSXGL65sdFT5fJPzJ/r?= =?us-ascii?Q?rVLYvh/aLta89NL6dc14/lwrFM3jJFQXgBq1K51Vt2PkQJk1CQdKiO40yJYq?= =?us-ascii?Q?kfmivEjyCOcDhrY29zWrGDRffPOzJ7YRvms3PGiBKjrYf7uZ4edoep0LkCC6?= =?us-ascii?Q?Zb1k3+sXHjSbeOsWlu2ZIeIyEUgCYrDj8CDiF4r7dl584YHNHqetyzUZam7W?= =?us-ascii?Q?+Y+JUZoFKqpZ4r4GbaEFBPmgqH5L3NnOtcIQ7UYdz6OtxBWY1RmRTD6V5ws1?= =?us-ascii?Q?gWmrBDo0hlwrWe/7UEZEr8mRLc34O4IHqeYjfaKcdIicKJmdrRyYkcDcoakp?= =?us-ascii?Q?BWZBD9OWfqm4pR3O+h7TLwbwv9nxQni3hioVUND1g1CcM7CW+oO17a27jdqW?= =?us-ascii?Q?SNvLiVMXGwX9gNKfhaV5M4j86RwU55ULb7Jpp14IhvppfM9PMobVtti2WvI9?= =?us-ascii?Q?q2xGLK3q9yLcNj3nSuQ1BD77GApQMTwWaLnLct5U2Hx7IGknqoMNjfEy7YFv?= =?us-ascii?Q?DeSfAVTKZmZHvNSy7zHpRTwelv+n0BBFn1060twiA5AtJgrRXliE?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 26c171a2-ac77-4b0e-d63a-08dede5a8637 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:11.4057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hAyU2zV+3jdRGCQwUo0qNbVAoo145s0aSwSO63wtjdED4I2WOMYTje5xbyIgQxsTy1ch6bGoT5nb8Y8p6xoyvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" The STOP request path handles device_terminate_all(). The DMA Engine client documentation says in the "Terminate APIs" section of Documentation/driver-api/dmaengine/client.rst: "No callback functions will be called for any incomplete transfers." dw-edma used vchan_cookie_complete() for a stopped descriptor. This queues the descriptor on the completed list and schedules its callback. A late callback after dmaengine_terminate_sync() can dereference callback state, such as a request object, that the client has already freed. Move the stopped descriptor to the terminated list. Complete the cookie before doing so, so cookie polling observes that the transfer is no longer in flight, but do not schedule the completion callback. Add a synchronize callback so virt-dma can release terminated descriptors. Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes in v2: - Split out into this preparation series (was patch 03/17 of the dynamic LL appends v1). - No changes. drivers/dma/dw-edma/dw-edma-core.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 89a4c498a17b..4e0dc52397e2 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -201,6 +201,13 @@ static int dw_edma_start_transfer(struct dw_edma_chan = *chan) return 1; } =20 +static void dw_edma_terminate_vdesc(struct virt_dma_desc *vd) +{ + list_del(&vd->node); + dma_cookie_complete(&vd->tx); + vchan_terminate_vdesc(vd); +} + static void dw_edma_device_caps(struct dma_chan *dchan, struct dma_slave_caps *caps) { @@ -673,8 +680,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan = *chan) break; =20 case EDMA_REQ_STOP: - list_del(&vd->node); - vchan_cookie_complete(vd); + dw_edma_terminate_vdesc(vd); chan->request =3D EDMA_REQ_NONE; chan->status =3D EDMA_ST_IDLE; break; @@ -856,6 +862,13 @@ static int dw_edma_alloc_chan_resources(struct dma_cha= n *dchan) return 0; } =20 +static void dw_edma_device_synchronize(struct dma_chan *dchan) +{ + struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); + + vchan_synchronize(&chan->vc); +} + static void dw_edma_free_chan_resources(struct dma_chan *dchan) { unsigned long timeout =3D jiffies + msecs_to_jiffies(5000); @@ -968,6 +981,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u3= 2 wr_alloc, u32 rd_alloc) dma->device_pause =3D dw_edma_device_pause; dma->device_resume =3D dw_edma_device_resume; dma->device_terminate_all =3D dw_edma_device_terminate_all; + dma->device_synchronize =3D dw_edma_device_synchronize; dma->device_issue_pending =3D dw_edma_device_issue_pending; dma->device_tx_status =3D dw_edma_device_tx_status; dma->device_prep_slave_sg =3D dw_edma_device_prep_slave_sg; --=20 2.51.0 From nobody Sun Jul 26 01:57:16 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020099.outbound.protection.outlook.com [52.101.228.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8173EA955; Fri, 10 Jul 2026 08:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.99 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670964; cv=fail; b=K5P9xIw5sEGZTnbvxl+NhpgNdhKZsBtW36dbw9o6wwbsf8t4JzdlschzAL7oyLeetYSuBpFWkSO3MBZE5gfM5vlcdiNpEwnnuu5c/Le6kEnIEXfZ3UZjrYhLiAZ3Wu+dsvDxah+T1xF1ptdUDBeJp8xcmrOwxPirfFsn89iVYng= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670964; c=relaxed/simple; bh=na7Hl/1bqiiTvA+mw7LghLA1efiUAW7RGydcz2RqBXY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=JV00ofJgFcgP4WEoQ8o7GkyRB9wHBt1gTyMCHE5/1ZV6KJmeVVk501QBTl9GDBunxeMQ5AaBGoJr4rpNmQnbBZmSFZRUrnUM5G0fgBPi4mwejYLmkESsPagDU0ggE0/uzZ438h9JwB/lZqT3PkQV8fiMadt9Rw+rPi+EkGPI+i8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=Vxs3Ekh3; arc=fail smtp.client-ip=52.101.228.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="Vxs3Ekh3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eCVrShM9Pqs2ql49irYT/GQugksccbKOkd2THap+WThzhv8rLuyJvgdfdFKDQMQTMvcDo4pZoNUXNP7pNjoJTqpJN2aUp3ZAqEiVvAZ+yUyBjYG4Wq1bLHif2/uqXLWah0qlYXU67ONXbihmeML8ntoZnMn3vjA3CSMGmKh0fSjhIVdIrmlHdSEtvVu89WOgc5mBEa9gfXuM1C34MdQYJ2LzrsloT4iqR3UU3U4f988O9ok6sOOcLjkQGMqBhJF6Q6kTeD6HCYAuzFIXIX2CSv28KZ7h2Fnmr6IlDBPdqjSB+iH5SYukh8KqKLUKuzNTarQSHYOp24AazfDVKQpRBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2K3c3LnigU4qLRMcg0zSi2MugLZDbWu4CltYvh2Z+XM=; b=uODt+/203a7A3hf0sXEA4NIeh28BzuEWB/IxOZxo8IwT9Z8CdcljQkEww6OAIr/QDpNYWV0sN/kCq9H+X4siiYrYCU0lNnHB2WXUigWlpAsqD0xsg5zp/g22r6uTBT1CiP49WNLAFxYKkblVFsld1k3LEwmK/utU0CrdFNMkXi5Fd9LFqdO+evnLn9a8+hrtUglBabxPOFJ3KleNRa2cqw49J3/hxPR1VD7cgvc8CYBSu3ul7WS7NXSC6tRJxT2ZfN0UEuRDZFkeuAiH4PfF9SsxYSlGmC99iJoObbLfh8VndXPR/qECwaagyYt5omvgoppKcVnq0mkAtgJxR3owXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2K3c3LnigU4qLRMcg0zSi2MugLZDbWu4CltYvh2Z+XM=; b=Vxs3Ekh3y11NpUCsk0WZ7ZEfM1zp3C5uccOLdy9CH5+qxvrYEc2YxQQvm+EsUMncDr3gLQyJoChGfDQ6iPwVVreF0sBPqx/flN53QlK9WzTCinDopyVAyfTZbLeqpTCivLSnJr2G7yS/EzWSAyrjxa0aqNL59UhrP0rc5J/L/rc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:12 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:12 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] dmaengine: dw-edma: Clean up vchan descriptors on termination Date: Fri, 10 Jul 2026 17:08:59 +0900 Message-ID: <20260710080903.2392888-4-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0106.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::13) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ac8aeca-8410-4642-6918-08dede5a86c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|5023799004|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: +K/bmfCk5NEJrvjc9VvFjkkvbUN1joHX8GZA5UzhZ1TU1tRiF1aQ9hrv+HW8sPRH4yzNwK1UZSI4ss0bFJjU0m28zRUcQSiaZix6bHrVpTebjkrssSb/R080NkYKGn+HhTTCkQjumMH0paPwId29XY8lcta47C3qpYSauuE6cVGc7skeMPYwVrAoIWnJ7Ea4OkrfUgJKrHiLd7qPejrcsT8m34TkGe851gBoR+JRPKq/PmXrttYO9YAMYrrbAnwOF91UO81ElcWqsCNGTAHkockKPblvS5Lk0/SHnBnaWeWPmTFTwvi1hu2BDqo0FXLHjY25pQunPFoyGVsTQ3IU1B+h/aGT6FT+pKLGv8qtTjXh+hebcvODTiOp+JFLSFBUmYwZXSXcgCI8FvnulN1/nhvV7Z5NA9SzOCd9kWKEfFZ+FuSgJFPHmcH5KaYFUC/InX0NKL1J54GVgu0cVBnmxUTpab1RsA6bYmXrcs4u1a7sNccDATBE4yIlybk9q6EhwP0WVSoo/6aehx8YsloWFOP2l+WiKzX9y/9rz4nAsPeSe0+jgUKgO3QgZYdo3GFSUzadlgd2LQFcQZSpXVjzvp5NrkGfpRbH6IsR2Oh+P8J5H69inG2ASrcvpja8u34rpe+HWcgvT+bjyfc4KoSrUi1cvUuAV2isYyOjRiBcmU4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(5023799004)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oMULJy2ZEhXTRi5b/+QhFvSl3OO0kYyYth2vO6E1Dfx9w3YQNaLw7hllCaQX?= =?us-ascii?Q?r5TOwq3D6GXbIFf3o/79oHnRbxXeJwFqD8sIq7Yq5lofDTerjF+u0F1VvLl0?= =?us-ascii?Q?qTylHAf60Alquu/WINxi9hPVPa99rsWv2InDU+VyCCHLlZGB4ouRZ6dQRZAI?= =?us-ascii?Q?oIXmnmkFOmj9/YC+lx/g54Dzk4sjRzWzmVU/DBjkh2hKBhlXaQmBqcdTGrK8?= =?us-ascii?Q?oRhTcoSrWDv15ttg2FVoZOq+PjZVfGeuj9CAygjTOm5dbIoA+YF/o9uhsX2+?= =?us-ascii?Q?73v+D7GWeaJDT50yRgRE0NmxpnhHBlxIqT7BEtFfMN8Ov4HdPQ9alN0LE0iM?= =?us-ascii?Q?/Psph2ETAVyTT0RnW4H2bY4atlboEctifuewp1IlqF2gdx/Ug/BfxbyeVS0o?= =?us-ascii?Q?0uXTBeKXy+CFq5cDeQQXPZZHASL4VAe9OKcLOtfZ1TOoPE1FaDlDUs9n1Dcd?= =?us-ascii?Q?oN86/YYC0R/nS40bZQvSUK+qbxfmm7EZGZ2zWwTzyyCfM8G3/jkYg09SwyQz?= =?us-ascii?Q?Wex0OVc3uxFiMCKMFbZJi5zdb9UjZBnaoglLG+4SuqRE80gCjA9M4aNFJCg0?= =?us-ascii?Q?RSg84i8DinGUrlE3GbJJB8BZ12UgmznHqdXcHbo6Ipf2U+rs7gttiyffgZKD?= =?us-ascii?Q?YcPDkJtWfFLRot6/PwQvxaz7T3uNhjWeCbNzeD6ANPk61ZMx6bjGd2RZR3xZ?= =?us-ascii?Q?qEvjO2+ivJNV7jYVd8KtgfIdvCiGnZM9OGRNlM7yphrRDI6Xu/A872q5XQvA?= =?us-ascii?Q?gIxSuxFBh8JBlrCWfESOF1ADYxQ2t1OcTHSVJxE6k3jGpfTRa5WTvHBJf5Ke?= =?us-ascii?Q?cv6ZY8Tq1aViGVfGLbBqWji0+9ANzWYK59G/+laBMBhHR7QSocT/wDAM5MsD?= =?us-ascii?Q?hVWUj2RsOmPXmjFuHGyQDgY8/c6BeBuBc9PTETANifYyxhGFv6y7163C60Tr?= =?us-ascii?Q?NsRsowDWT88iRodfzseEH9GXeLXBcGu0zLK2c4zlSfflZbOJv5n6TQUIA5Hc?= =?us-ascii?Q?/JvorqoedX4Akcf91yEYt9mdUArPb93WKuzeF7xtmfF6T/3CLIrC4TbtXpmA?= =?us-ascii?Q?bOmq5C5vrS4hlvYDwzy4ZK8e/pJsKyVHdqgWEezHlgLzd8iv3WQTpUlVf88i?= =?us-ascii?Q?BwUguyz+Lq5LnBbPILV3EH74AKNpfvxnW25x199RGIOC3Fa+JF7XtnGgpLLv?= =?us-ascii?Q?j8rBXlEwyyps+k0CYx3IJKxYr8zpDJkA9ba/mOWZy52ccYVKSMUexzaVLiEb?= =?us-ascii?Q?rvJw1nuXBwMC6LkF12ZASkzyRnMSJc7rbSha4f/uHeq2Sr4jXYmUnOonVrJZ?= =?us-ascii?Q?YS000Ilzn/Z5UIlhy4LCjaWnzFXaoMg2vkxVTZ3lZ8BBsl1T/VitpvX/Gu4Q?= =?us-ascii?Q?AgLDCliRvr2k7+BE2AGQHQ84PEgOt1l3v05GbcB0ryjB5skNPTAtRkDjiyRG?= =?us-ascii?Q?G4zIFBxPzRXZald25q8jPVrJvXxZdOhJMXsd8R1+91tLFA42iRZQOGVicfKz?= =?us-ascii?Q?Ggr3UDGVP0hj3jtl+781/ngIOHIsQmnWWmMTjNMegmIdvgzlGfkkB+dXqL46?= =?us-ascii?Q?jXM+MdvATrhdEv79wZaLpFXdI69MdbHD1Pk4+BPsDp4DVjtF102DRO/8g+c6?= =?us-ascii?Q?x/TDgDBcLqpdC9cPJg8wHgZD8pzCqFw5lWLvxoaslsuJwzB39deI4ClGzQp4?= =?us-ascii?Q?4KIydusH6xxjUlvf86MqTmHNGOHbpww6DqOgqISbQYRw5Qhyy+np+Fh66dtN?= =?us-ascii?Q?wuEhhK0/h2qiUyZLLMnpIORnBNUOWgu2T+QKBCwdmpz+Qg4R1vCp?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac8aeca-8410-4642-6918-08dede5a86c4 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:12.3188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HsGAWKHmLdJpAecum/XPIR5RiYbU0WJejFjt9LERWJk2ukn9Ghaoce7nvNUywEWQ07ot9ZMvQn/amG2TbqHvNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" dw-edma resets channel state from terminate_all() paths, but pending virt-dma descriptors can remain on the submitted and issued lists. A later issue_pending() may then restart work that the client already terminated, possibly into buffers that were already reused. Descriptors that are never restarted leak instead. Move issued and submitted descriptors to the terminated list whenever a termination request completes. Also release virt-dma resources from free_chan_resources(). If termination was deferred because the channel was still running, wait until the STOP path deconfigures the channel before synchronizing or freeing virt-dma resources. Otherwise dmaengine_terminate_sync() can return before the deferred STOP cleanup has moved issued descriptors to the terminated list and before the channel is known to have stopped. The old free_chan_resources() loop usually broke as soon as terminate_all() returned zero, so it did not effectively spin until the timeout. This wait can now last until the existing timeout, so use cond_resched() instead of busy-polling with cpu_relax(), and warn if the timeout expires. Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes in v2: - Poll with usleep_range() (and include linux/delay.h for it) instead of a cond_resched() busy loop in the termination wait; each iteration does an MMIO read that is a non-posted round trip on remote setups. - Split out into this preparation series (was patch 04/17 of the dynamic LL appends v1). - Let dw_edma_free_chan_resources() reuse dw_edma_device_synchronize() instead of open-coding the same wait-and-synchronize sequence. drivers/dma/dw-edma/dw-edma-core.c | 79 ++++++++++++++++++++++++------ 1 file changed, 65 insertions(+), 14 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 4e0dc52397e2..1b493c104a5b 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -7,6 +7,7 @@ */ =20 #include +#include #include #include #include @@ -15,6 +16,7 @@ #include #include #include +#include #include =20 #include "dw-edma-core.h" @@ -208,6 +210,28 @@ static void dw_edma_terminate_vdesc(struct virt_dma_de= sc *vd) vchan_terminate_vdesc(vd); } =20 +static void dw_edma_terminate_vdesc_list(struct list_head *head) +{ + struct virt_dma_desc *vd, *_vd; + + list_for_each_entry_safe(vd, _vd, head, node) + dw_edma_terminate_vdesc(vd); +} + +/* Must be called with vc.lock held. */ +static void dw_edma_terminate_all_descs(struct dw_edma_chan *chan) +{ + /* + * This order must not be reversed. Cookies are assigned when + * descriptors are submitted, so desc_issued contains older cookies + * than desc_submitted. Completing desc_submitted first could move + * chan->vc.chan.completed_cookie backwards when desc_issued is + * terminated afterwards. + */ + dw_edma_terminate_vdesc_list(&chan->vc.desc_issued); + dw_edma_terminate_vdesc_list(&chan->vc.desc_submitted); +} + static void dw_edma_device_caps(struct dma_chan *dchan, struct dma_slave_caps *caps) { @@ -313,20 +337,25 @@ static int dw_edma_device_resume(struct dma_chan *dch= an) static int dw_edma_device_terminate_all(struct dma_chan *dchan) { struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); + unsigned long flags; int err =3D 0; =20 + spin_lock_irqsave(&chan->vc.lock, flags); if (!chan->configured) { - /* Do nothing */ + dw_edma_terminate_all_descs(chan); } else if (chan->status =3D=3D EDMA_ST_PAUSE) { + dw_edma_terminate_all_descs(chan); chan->status =3D EDMA_ST_IDLE; chan->configured =3D false; } else if (chan->status =3D=3D EDMA_ST_IDLE) { + dw_edma_terminate_all_descs(chan); chan->configured =3D false; } else if (dw_edma_core_ch_status(chan) =3D=3D DMA_COMPLETE) { /* * The channel is in a false BUSY state, probably didn't * receive or lost an interrupt */ + dw_edma_terminate_all_descs(chan); chan->status =3D EDMA_ST_IDLE; chan->configured =3D false; } else if (chan->request > EDMA_REQ_PAUSE) { @@ -334,6 +363,7 @@ static int dw_edma_device_terminate_all(struct dma_chan= *dchan) } else { chan->request =3D EDMA_REQ_STOP; } + spin_unlock_irqrestore(&chan->vc.lock, flags); =20 return err; } @@ -680,7 +710,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan = *chan) break; =20 case EDMA_REQ_STOP: - dw_edma_terminate_vdesc(vd); + dw_edma_terminate_all_descs(chan); chan->request =3D EDMA_REQ_NONE; chan->status =3D EDMA_ST_IDLE; break; @@ -862,28 +892,49 @@ static int dw_edma_alloc_chan_resources(struct dma_ch= an *dchan) return 0; } =20 +static void dw_edma_wait_termination(struct dma_chan *dchan) +{ + struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); + unsigned long timeout =3D jiffies + msecs_to_jiffies(5000); + unsigned long flags; + bool configured =3D true; + + /* + * dw_edma_device_terminate_all() may defer cleanup to a later interrupt + * while the channel is still running. Retry until the channel is + * deconfigured, which marks that termination completed. + */ + while (time_before(jiffies, timeout)) { + dw_edma_device_terminate_all(dchan); + + spin_lock_irqsave(&chan->vc.lock, flags); + configured =3D chan->configured; + spin_unlock_irqrestore(&chan->vc.lock, flags); + if (!configured) + return; + + usleep_range(1000, 2000); + cond_resched(); + } + + dev_warn(chan->dw->chip->dev, + "timeout waiting for channel termination\n"); +} + static void dw_edma_device_synchronize(struct dma_chan *dchan) { struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); =20 + dw_edma_wait_termination(dchan); vchan_synchronize(&chan->vc); } =20 static void dw_edma_free_chan_resources(struct dma_chan *dchan) { - unsigned long timeout =3D jiffies + msecs_to_jiffies(5000); - int ret; - - while (time_before(jiffies, timeout)) { - ret =3D dw_edma_device_terminate_all(dchan); - if (!ret) - break; - - if (time_after_eq(jiffies, timeout)) - return; + struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); =20 - cpu_relax(); - } + dw_edma_device_synchronize(dchan); + vchan_free_chan_resources(&chan->vc); } =20 static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_= alloc) --=20 2.51.0 From nobody Sun Jul 26 01:57:16 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020075.outbound.protection.outlook.com [52.101.229.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5B13ED3A6; Fri, 10 Jul 2026 08:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670965; cv=fail; b=EEP4daUHftnFeusm1twGvuX5z6v9FsdiVGV3oxqXDeH8HmHOYDUujb6+cboDLHuXTGJESk5DTuzeZC+j9RqXgYCSH6xq7SKAG4RW8SGVR+bNT2L8tuB5q5DxHFovBb2+K5GBiSQj6651kJvRY7WV8ec1+55VHGA0BNHLor9z2M0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670965; c=relaxed/simple; bh=+woOPqlh2Kwk2JOzgBZJtEqm8GJUk8rkR7Xi/ujAcTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PjLJjOj0vNVQtTlYrSURSNlKb3FMQvcgysTS9dS5EJKvcyX+tK62qwE4INDVR/ALpCagIaGk4wYGCit4MAvGgZmMxm7q2NZ/GCVSY8Dqn6IPqmlEEs/DepOXUYd3lUJZ9eCPaRtFYl/3GAnpfLHo406e5Jvzz+zMw789ouia+sM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=otAkkPtE; arc=fail smtp.client-ip=52.101.229.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="otAkkPtE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XDBuHrFVFEapCLOyCtjmX2j0Xf5zrr8h9jjr/ffyWTZcYcBs/PQjOBUgoFF4b5bQmBIg8GzfTNuH7F2q2xf4qv1d2w1PMkWKgdOjz663U3e51W7yVtz8vY+LtyaKNfTZGXLIXUDjAAvShovClGBNkxENbbAIAhuVn+DeH4Fl3ic5L9T1sBT+WG9Rjpi/4SAEF8f9fpZ6Z3ScueSuQHi/0lUmOF1JyceJ9ety5N03GiFhoZuMgr+uAPRey5/OaypXvC0G/xwVxUg3eJPzUePfI9O0rOaDobyNMsK8m3xx4lxHG9H8I2FdU0lZVAIbySUURlXeftF7KFbr9G5mJ6TSLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ozA9/2x5A2p2x+EiHrXATEbsNtUjWCtMtt3b5UAATA=; b=v+S8rk4qt0qjSOlpYM7YtHhF8UlOtPQpGwg0Qwx1/s+H2Sb6COxTpGNTlOCdxQKS62kq4JdF/zLNgzFyuT/qUCp30oyIlMRCSUP1ZPmv6rQKCGeTSxFAO9jKxTIzXtKEEvPnol+gFXQp2noPjbF6BWRY6php5zezholjSydYgeT96kfP8iMNgW37uXP/O4I0De55zPGahIFmBH+sjeywh14Y7+mJvCD7P8QV/TRFZ0IbiMlfcyMrNGKNRIf6o0oEqVmPkSiRgLqQOvIMV3b/Np5n0iiqrfGh2vBWXj1WQs3LGmTBEJHTazP2aJ+ek31JokqaBZPOorELlBWtn9/J3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ozA9/2x5A2p2x+EiHrXATEbsNtUjWCtMtt3b5UAATA=; b=otAkkPtEY1GftuQFldzrwAoLonH2ZLSGVxuaWb8+V/8EoYKuGbFxZwQmU/hxAM/jVa/+4VN/xQbCugsemrmb8fzXpKj2qcvoXnUYP+kgYUt9nBbH4URPxQZSeiyP7feISGnUkWPuvS6+7saUsiNEo7FLWWxsisJUOG8ONx4qspM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:13 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:13 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] dmaengine: dw-edma: Serialize channel state checks Date: Fri, 10 Jul 2026 17:09:00 +0900 Message-ID: <20260710080903.2392888-5-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0115.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::19) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: 49bf44c4-5b47-4b41-8f72-08dede5a8741 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: STuwUA4k/9cdYdOKFJv2CD4203xxFskL8lSEYOOkpB/0CIIIx5zAlLlAONPiTMTU2WIYuLYIFuGOil9x1gNVyRiYTIKK1FZe8I8BD38Jhhc7FsEyDTCcpedKRl2AvZVkjZ7CKwHWP/4EwdTwIlucCnL3MvylDTLGiLbNBVSeAK8cOBzx7VpfhfzoWNigbfR39DZhMY3E1Hs+tyG+Qha9/UfrAPqXiOLfzKgnoZA9Np+l8zcgUrG78OOLUMiIjDhbSIZ9epfSBekZZ3E4F/9sjDWfSiliQBIkKcgDZYap4tbmXSd9XS+a+vmCgXU70cbjdQEtFxTehTLrMr84B2edmgSjG09Tw4IyRxqzTzyPV/laZnbWFBs/5uIBDOYhGagxzEdjPrpID/0oLN2ELO7wdDpch1GdIBSlahY+0i08DJ8/hH/Q/uzTSdzJA+NRIqsrdPU1vRDqoMSBlV58GifPXjjdFAJPjfKe57JfU64ZqLG01farCh4C6iPTsb3W97U6vhsvRRDa90ojUZQ6eM2sjNP5ChMrk7uldI17FCMjOEHG3SV424HAjtsOQi9Z5CpcSDAU3AQXIYv/OsQsfBFYqkmNthjIHni+0yX0xcx1MdCBeIoq2WS/67QJI22yXL8jIaKFgxdhlN1IEopS2jkXo/wvg0r751cQdVJ4oHxT/lk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e/HujuEXqLMLPuBi+k1482LIu/WLdOyqr2oTA2G4JfLJ8GV4sDj99Qy1st1S?= =?us-ascii?Q?hhtMTYdNM2e8GpI9uxP+pJY184Rj9a2EUb7EL8AxHGUnpwYt01biVuZmXdWD?= =?us-ascii?Q?RKQl5hGI+kQlt6vKWqR04KC09u/C8lH0Bv8PHceELuPuFy8iP32bvzUUOGmE?= =?us-ascii?Q?3cIsntpmeGttnmgrKHMr+oZRSIUeI1uhAzxSnPSQGO+xdjpYu0pDJzimMycw?= =?us-ascii?Q?6aVXcIJG7xPifew+GtVuFaORq6KAnpI5arrcmrVo7QMaZqH2rcZp7Azg7ZIi?= =?us-ascii?Q?x49/nak1Otj/Moo1E+7RR5PE2NBh9OM42V5sV8E7G5Wr8qABAIWxzYYrYswt?= =?us-ascii?Q?G0HMWkrBh7KGzF+75Fm4+cMZ+ZgLIDhymuaWofIyG5B5UIWoqYmyXbVnoz+e?= =?us-ascii?Q?VLGi8FXtamNCspTAODlOQUJLY5U050s/ekecAi3/QmSp7r3uXqwxB2KsK8Kh?= =?us-ascii?Q?imyEI4DtK5BUPvjSSbQQzI2HYWkmxQ4owqlI+Bh6oSo0+KDtYhrGZ/quqzFf?= =?us-ascii?Q?f2sfG1EH89kutfnqR3WtAI5bP6hCgeN0S98Z/wFsdRxYCmLe41n6pC8QiAfV?= =?us-ascii?Q?SKkUrk44dA9t4fqW7zLZdRa6iooHWsQ06TYIn2BXAoDosXx5wHRFkaD+ANDn?= =?us-ascii?Q?j2Y6Kcw6JP+tNkdxWf9YrvuocgegiQfF8QmaURdh7juNlrqeoHmHweEtBCdd?= =?us-ascii?Q?ypPxbQ8POK4S7g6t50tyQR6G7A8Mx1NXaxmyaSOuuwkoJ9vpHWuXw70jwpen?= =?us-ascii?Q?jwKB2BEoe9LMzN39MmuvOcYsxKBUWylplAz4HXVuyExzV9NPK40Jw3Xsoou1?= =?us-ascii?Q?zfeRcd99C5zN7ooKoKUOAK8IBhaCXSMXHXggBFO0o6c/RO6depf2ICIE3bVT?= =?us-ascii?Q?UKWD++gfHt6TNk6EUgo+2iryTm4AUsxZCUuRUReK6wvlM9/YR4BjdD9pS2FO?= =?us-ascii?Q?ZqfsG6wN8cpiAKuyS8ZjCdA5KcG2fO5A99gbCrqoL6GELlQjcKPotIKeOhD+?= =?us-ascii?Q?2mzF9Uxsyxc3Cwi2GlR0Tz357KQRF+rdwxhg52AMaULofDKgk2iiofGFo8Gz?= =?us-ascii?Q?P7uuCo1l9nDhkxoHPim/24WRGaKzXCSp5m9AJ9BXJ1iqbZpAQV8CgaagNtbL?= =?us-ascii?Q?gTWEuS8ZkXH3A+BTdlxR63hz7jOP5eaHihZQnmpzJXzWdavEeea34s1AyRBE?= =?us-ascii?Q?kariqz6N9i8yPd/7gVzNKfBSsMSm5jPXWydY2OYtxwH8LnCvAN+jkSVMBJTH?= =?us-ascii?Q?MOGULKXOz80DhaCN5xwL6KM0/ALpWx04F0JX+l21r/QhEDg9qRIsRBR+AicR?= =?us-ascii?Q?ffkxfgR1o7Kd3qrFePfilSY2nNMgStU/LckXxwQ26zZYkXUXteFTVTuzkw+Y?= =?us-ascii?Q?329nVPM+aCyksOoX4OB3J2hJtuEOB3i+c5XEnHk+d3iQzYWgrnVUlCemblt5?= =?us-ascii?Q?jijx9upxrWCnLd93J50rm2+RDa2ui2qreU4GAK8QV+P4gLNZWBylQHATIABh?= =?us-ascii?Q?nG9SATCO6NAtex7ZVlMmud/kXRn4PYaYoWc/oKSvZk2wnprd/FIYC7LbBk2L?= =?us-ascii?Q?aupaJJ5YcJg5bq6GSr/YLC8BZYZCavCccL5S4X8AHDXYgp6UPn5y1XHgFMFE?= =?us-ascii?Q?JUO8omXwgAoy5rAbc0z9lPe3KQVh1bJxf7UwoFXhhpiIekaPIQOy0vGY6iLU?= =?us-ascii?Q?qSPibKSwPhV3X9f1iR915iXC78KLRZvfTnDBdxS70uGL4OeWVfZ3fD06CJJO?= =?us-ascii?Q?BoZIx6upF8DR+as8ibeYIdVfH9C7W31IetNNJLnFpHtIiFVqLsv9?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 49bf44c4-5b47-4b41-8f72-08dede5a8741 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:13.1370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XK67rardSI9HocxbENUK4FEdYLlwEYeJ9xQVKDnGv0MMXe6JJDN+NTdMyn2IcRLFpSe+brwWdVBbl3VGgsXP0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" pause() and resume() read and update channel state without holding vc.lock, while the interrupt handlers update the same state under it. Take the same lock around those state checks so that request, status, and configured stay consistent. For example, pause() can observe EDMA_ST_BUSY right before the interrupt handler completes the final descriptor and moves the channel to EDMA_ST_IDLE, and then record EDMA_REQ_PAUSE on an already idle channel. No further interrupt will acknowledge the request, and since issue_pending() requires EDMA_REQ_NONE, the channel is wedged for good: terminate_all() leaves the stale request behind, so even reconfiguring the channel does not recover it. issue_pending() already runs under vc.lock, but it tests configured before taking it. Move that test under the lock as well, so that the decision to start work is made against the current value rather than one observed before a concurrent terminate_all() deconfigured the channel. Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v2: - Split out into this preparation series (was patch 05/17 of the dynamic LL appends v1). - Collect Frank's Reviewed-by. drivers/dma/dw-edma/dw-edma-core.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 1b493c104a5b..5664421c6f15 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -301,8 +301,10 @@ static int dw_edma_device_config(struct dma_chan *dcha= n, static int dw_edma_device_pause(struct dma_chan *dchan) { struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); + unsigned long flags; int err =3D 0; =20 + spin_lock_irqsave(&chan->vc.lock, flags); if (!chan->configured) err =3D -EPERM; else if (chan->status !=3D EDMA_ST_BUSY) @@ -311,6 +313,7 @@ static int dw_edma_device_pause(struct dma_chan *dchan) err =3D -EPERM; else chan->request =3D EDMA_REQ_PAUSE; + spin_unlock_irqrestore(&chan->vc.lock, flags); =20 return err; } @@ -318,8 +321,10 @@ static int dw_edma_device_pause(struct dma_chan *dchan) static int dw_edma_device_resume(struct dma_chan *dchan) { struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); + unsigned long flags; int err =3D 0; =20 + spin_lock_irqsave(&chan->vc.lock, flags); if (!chan->configured) { err =3D -EPERM; } else if (chan->status !=3D EDMA_ST_PAUSE) { @@ -330,6 +335,7 @@ static int dw_edma_device_resume(struct dma_chan *dchan) chan->status =3D EDMA_ST_BUSY; dw_edma_start_transfer(chan); } + spin_unlock_irqrestore(&chan->vc.lock, flags); =20 return err; } @@ -373,11 +379,9 @@ static void dw_edma_device_issue_pending(struct dma_ch= an *dchan) struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); unsigned long flags; =20 - if (!chan->configured) - return; - spin_lock_irqsave(&chan->vc.lock, flags); - if (vchan_issue_pending(&chan->vc) && chan->request =3D=3D EDMA_REQ_NONE = && + if (chan->configured && vchan_issue_pending(&chan->vc) && + chan->request =3D=3D EDMA_REQ_NONE && chan->status =3D=3D EDMA_ST_IDLE) { chan->status =3D EDMA_ST_BUSY; dw_edma_start_transfer(chan); --=20 2.51.0 From nobody Sun Jul 26 01:57:16 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020099.outbound.protection.outlook.com [52.101.228.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA5AF3EE1FC; Fri, 10 Jul 2026 08:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.99 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670967; cv=fail; b=ls3NNty+16veQkUJnfNRU4H6i4cHu8boDL025OavUuYv0ylvDt4Jp1yPY98nZEspIUSNe0K1A2aNkZiaaTSitId4WKTGtax4MHkWdgqwHSiTcQg/wiOugopom7++pboIusN+Cu7wAiP463hFXPUPViZnpHRxT3piJJEdR6uCl+0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670967; c=relaxed/simple; bh=vOv2kKC2LFA6Tli6D9iDpJCtk5vmYCuwgpXP8c2vX5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ENmi3o0FOw7PffmnqhXn+FZvP/WkEUGr6SnIx7jqm9lVn5eB9kgP90q/jnLepOYlO3rBQ5S0L4W267dgGRC4Lj9l/7Rc14gJZcvQ5ll2hrhzDd13IesXnJ4r0YYJe5yO3onHhn/ULSxqlM6oAcXUcJlBv1LN4fyX8X9a1Lhj63M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=ppxlGIg1; arc=fail smtp.client-ip=52.101.228.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="ppxlGIg1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=px9JdPZKYR/OTOBxS30KYGgIkYVeJ004hwG1rm+x05Y0ShWwWt5s4TdVqaM028AXJ/f6S/wNxu2UTVFjGKfcTw7sDpdSuzPisZCBq+EyOb/57nOR0dVh2BgsYz1PMQLhp5TnlEAFGfTrN7k/lnq3BBMbdzTJV47i1FzCK//UTrhaC+DcVLqWS/4Ayd3G5eeOJResgin9ZB0E/UcbxOAaYCF8HcVSGVO702eGbOQMwVkx1a5CRcdkzOurOvmZPADw7A5xVTD9WqxCaZ8gXsrrryOqPLkABh3GqeAQOU1/zkhHyIdREdEzKb8zV3nULo5Pf2QQOg18+ho+NZpTA94fHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hAeP5J7XdG/Q0tPRAxAxfYaVyzGEJPW9lXjvXEVWYlE=; b=VgkkqG6V+S79eSgTDH3c/hV6WgVLOrm9Tzge53Z+h50Ew7FVWKQVwU9A/8/fGvDt+7uev8taJJtsEhYFm+KOAzi8Mcrz/w9bFTA8NpZARF3AJdcfVfgSWvuZh3iss6L7o3DH4F6iPZqDnms3EY82qsTPfSlBvQLHheQeU5P3zWCuE4Sew8ree0i7afN27ETO/9eGgiwpXel/fiXtTpxjnMCSw5a56EAgWZPl1RqMcU5NOfv/fHdispVC68b0bqU8XdiDJJZ4BIDYx/yEEZOsnRk/LvMniRnYAZBk75Ho4CYZRbUTU+oKDbCndF08q6GfEyN8GRNvBqNCVoyXXOKAjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hAeP5J7XdG/Q0tPRAxAxfYaVyzGEJPW9lXjvXEVWYlE=; b=ppxlGIg11XRFoaNoN5n+1VjRW1u/BSaVu3M3cAYVtxxo2l/sU/W/9By5hIEYI/mc2pQWclbIMIbCrpWTzBo0nwE873M481ueXPDrfF7ejOmIEnjCn/6FRy4JD/Qgjx0Rex92PWdfsdlZK8gUqL4mofnL/MseW5DgvZy8nLPAFtE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:13 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:13 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] dmaengine: dw-edma-pcie: Drop redundant pci_free_irq_vectors() Date: Fri, 10 Jul 2026 17:09:01 +0900 Message-ID: <20260710080903.2392888-6-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0084.jpnprd01.prod.outlook.com (2603:1096:405:36c::11) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: a26a52ce-aa3c-4af5-de46-08dede5a87af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: W0RwPk75u3URLnvPDTt8ttLfMQkuVpWND8/2hDPW4VTz5F4O5LZY7POJSeFazfO7M2L7B7U39WJiu5nL7i9ziqRSVLEC3WPA4E6BAYd97RRmQ/ZnTiBJRCPrMA0z6vDYCrsqQjZSocyAvDvxxZ+AsvWzeevI2AUwSbhVC8wgxVo26OZpyMtzY/A4JDj4/z3UzmCZ1Fy7/BtSa6rTlTYa7gmQakbkB1H4bD74LAccafa5mf+PW+uBJXorN+63vYJ+6d3tIxfgfWW8O3F6NV/4xspeeizNumjcQ0BgrHG7okyWw9mhMu2/0t/j6o96KriBNAcianBhug/iw9T9LrwbQs78BoERRIctpjQH/8Vtl8sH0uTKFvzgPoGTmU09sRAyxDsFoWBSYCO6Y85/6EFXGhMrtTrQf59mazInPBw0BBOkh9UE/+v21QhKj5ZVOuoRsc1FdPQRAenDKpY7yHHoOwmcwwTOWXaS7mUYJyqoFB7ZCsF65Wtv8ngUPxEhZyssDShXIFiE1MOeewns7/z8AKmXpOB8wPkeYkR6JrSjTujQJoGpxKfSlc8FxZJCe9gvuyLamys+9OmkTOKGX5qMJdpKJnjnSmEaS9bcZl9a2Uj48MGKSCS8s1nwXCjpNprxuSnDqgFQ0dTMWq0w78TayBymL4GaijyrWNlPzVRgDZ4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kn1xjEqJOPDE9d5ceDtMNUAMMlaFt9AkXu0Joa/oGnxhuCw284rGfq4reesG?= =?us-ascii?Q?VY1Z8jaeQ3uYu3H7iY5acdLHMYiIP1A6pFIbk0gsy5qia9XTmrDKQrAZv/n8?= =?us-ascii?Q?fm1JqpT3v3POoxaVPfrsXw/ju9ii3icEiGZH4q4yfsh4RIEVN3NdEtTUB0xV?= =?us-ascii?Q?fEWfUWyLnAMVMfyGWCsWpyUNdtXVDA2+h8H7A5C5x2darfQ5jljlIGOVND+T?= =?us-ascii?Q?CC5CnK5t9BF1RhIsKK1C0R7LrmcMbZJYI1Z6nD/lfUIh67ymbhB+n7y09Yzy?= =?us-ascii?Q?Rv27uo47uT7RciLmod5CYZ6xiCXnL1mX3D9LYXAv1Yz5pZnCwcd1tlzlVCwz?= =?us-ascii?Q?C6hE9/xHzvLUSmTRYGZ+dOuIHLP3mTYKosHbo7grSE118IxB6VDI+TAHSdAY?= =?us-ascii?Q?WqU1dUcYjDSMr7QwssbOtJhoaFNPNHh8ZEJozhPn4gDyZEqCW50QZs5qvptD?= =?us-ascii?Q?PsxjNruiRsl4fuiJcNIiefGNPQ1JybgLE37DCyGWBmSr+x8LOVbe76uXY9+F?= =?us-ascii?Q?+xH62oj6TgSgKS56/p1zeLyThUzToE0fair1L97Du/4RNTnWnAQvGQaMXeoC?= =?us-ascii?Q?KpuSP0lh6B4DwpgXxLuNMzukQaFYB02vs15zKetXlhrAUXJsu+wYjoKYljFX?= =?us-ascii?Q?TNxpHmzrOvBn4k70HUj1DZtHSYng4Xlov2pEAACUtRln9OJsLMMQ8s922UeC?= =?us-ascii?Q?fT7bk1GR6GBL6lHdrkR7ciql3msEMOO4pF9EgbHBabUSY/o5ti+z+WohJB40?= =?us-ascii?Q?gO1wYBTDhA9PHc0HynR5Oh3ISBnLjpdyciDpJFHeEXZg8U/lBlRjW/HwexnA?= =?us-ascii?Q?M4TustV4DVb/d60F0C4mRbYSWs5YyiT5qyVZ1e3LNUpYfy+fqDYiJyRZ147Q?= =?us-ascii?Q?TOiSuq3P924IH+BM0r2LgdqdRwDW3RH10auYuRu9LWT5Q27in+kbBYKmjPz2?= =?us-ascii?Q?Yo6a4ZD85sp5+biQAVL+a44b2R5Rx6Oy/m6fcNsYCFZiutirbD0HO8Po2kp2?= =?us-ascii?Q?gTGugJGDltQpI63kXAo62j3jXa5sXJoWOjOcW4X9dpgpIvQ1XGE2htNpdn6P?= =?us-ascii?Q?m/pJv0muEE1Z02FcI2YLqnmHUrO/4boDXKfPl32xn2tA/Yq1Qp3/ZGTFH1wK?= =?us-ascii?Q?nASwbtgpXvFZ1DY/KHz7knG3podvJnvdXGdrRr4/hoKbYXemQJ5wnXXmxCru?= =?us-ascii?Q?9s0FBd9dbUJ561VVss1vACPBKfnYwNp9/7Muf4K44BBig4pR5jmIP8E3OEl0?= =?us-ascii?Q?v9AHPwCrPsKn6joDR51moX3BkfbHpjfG/z+55Oo8JfOVRINozyvuuXL2wNuf?= =?us-ascii?Q?RUKgWyevyUbAJAWXXPbjbv3DaKDOUWFDbGzCGaLq1b7Jj1UNN1LRy/ercebv?= =?us-ascii?Q?7Q10xPI/Oas4U4Nn69ZlLQuj74PyYcdDo3kIaxY1gwlmCGlPoREux+vJk8xl?= =?us-ascii?Q?0vNmTXhfT+8n+MWlg/4FajjAdVQirLPA518S+pemrTpH/RC9MOvdborEL6mt?= =?us-ascii?Q?XgptYNpQ2kEW/t9zLkJXXPz9a6hEYDZmsESYVfcVTswJhUj4EjIao1gGGgzK?= =?us-ascii?Q?Nw+YcruJm2e0lXaMkglkQWDTLI1H0uS/U3sXmRbv2nms3p6tl1CKuo/IJWHk?= =?us-ascii?Q?xAobCBpbylysgLEXEHuQFT1fITR4q97P1zHh4n1HtAXlT5tUej7tLIFvNRD6?= =?us-ascii?Q?QOvgIyE4dpvho7xXifcOzmCVVVS1xocXHaITuneqzu9etFJWXeK2K7p7u/Hq?= =?us-ascii?Q?hs+yNtKpkVaBWXViZmFdH1sy1EorGKr7UOGIueohLm+fElLqtf2g?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: a26a52ce-aa3c-4af5-de46-08dede5a87af X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:13.8545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i5WYcBaDzFm2GTknxAS0qzTWJ5oXZb2cuaK0idbP/BEUzDyfuRJ86vhLp2psVbwy0ntXIUx9IgqIzRs+SPUPKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" dw_edma_pcie enables the PCI device with pcim_enable_device(), so IRQ vectors allocated by pci_alloc_irq_vectors() are released by pcim_msi_release() on device release. The driver should not call pci_free_irq_vectors() manually. Drop the redundant remove-time cleanup and rely on the managed PCI device lifetime instead, as documented by commit 03e4905402ae ("PCI/MSI: Clarify pci_free_irq_vectors() usage for managed devices"). Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes in v2: - New patch in v2, posted as part of this preparation series. drivers/dma/dw-edma/dw-edma-pcie.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 791c46e8ae4c..5e81a433a957 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -555,9 +555,6 @@ static void dw_edma_pcie_remove(struct pci_dev *pdev) err =3D dw_edma_remove(chip); if (err) pci_warn(pdev, "can't remove device properly: %d\n", err); - - /* Freeing IRQs */ - pci_free_irq_vectors(pdev); } =20 static const struct pci_device_id dw_edma_pcie_id_table[] =3D { --=20 2.51.0 From nobody Sun Jul 26 01:57:16 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020075.outbound.protection.outlook.com [52.101.229.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D3239B970; Fri, 10 Jul 2026 08:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670968; cv=fail; b=Rb2/NRqZbPn3SFpONwmmvUg9uCdIs6ngrwE4cMNSs7SqGn2xyE7lMFxKuCmBq75PMNIYET9+IZYukMSLZ5gngvpNEO+bVWvzRX6U7WLlQSuM0FIYM1hQ3Ql/oNit6heauZcEX11zhYpfF66CHgPMxLnmUxJjos1RiN+tMiMNRsY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670968; c=relaxed/simple; bh=eXH+uzCVRr+A8nYAA25q2v2aMBiD9PkLzbzi0UOUKiE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=TKB2uZGI5XhDD1VTeoHzgPTfy5RgIHV3x4j/jqSh5mqlzxSfBClBaSNaKyMJ0UD/duCH8gSKng9ftBWuLIObYbdlE8Q1iWd6UMMTyAx65AhsitkicO5l/Av2jAHyHzkU4HqCMIAJpjQB7yNJuZK7b24qudLjPxkFgKugVY6mIrQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=PjuUpxiF; arc=fail smtp.client-ip=52.101.229.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="PjuUpxiF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=utseYKQ1WfULorGrZ1w6ckH/jNZamOQmD29R3fOh6rAf4BuBwyV67C4lsux9mPUc6gs477rXBt018Lat3vM1bDnSbf01elp7DHz3rHLWbr6uQqTPCClE6gRnz+aPtHGkfRj84MgB04Pul5AKDpsIE/T56aXD58HAnUfb1zFbcKWt0z1tfd5ebaCR6reeknPuc1f9IgiHQYp1mda/upjDeehZIDFDJC3tifP2P/3iG3iqWkx+GWUg8LlAfic3FOK5ohB5wfQg8LINSN24QvcHdx4B4rxOsIQw6Vo4i0BPpyPJIgJJXAyakYOSLCyxIyelqxh8yJ+Kg3DGI0pC5ANY/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SfdeU72KqHLcsdNNpZU7QVB649xp/LEXXktUw9aIUFg=; b=JnsSldSZUk4skHnXamFpJ2BjFTpjb2pF4OrTHSIloLUJOqlbQ33irb17x+RnC6rB0zjRu76RFM5fAiWmbqErBcwfE4MwNeb4Z0/RRaiibJhaoORCAHgCfWT6nS5OnsmJiM+pNIhFJfbrf8VwvFfKNdgcSDTcE4hTunsshkMPxbdxJUB/WHR35fXF4eH74Ntm6gR3wA6HvUwd/nkoXyFZpw4E/plkQ4rYXnPlpOFfq2iUmQmXEf4Ud0PlQ6Do6RAbyy5e+fOS0Ge4yI9cbVt7wXdxQwOvrNfMLHpoiDm02H/VfzXSYt14Td7tTdWYU+fafC2ivJDe9s9Xu9mwq1IkHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SfdeU72KqHLcsdNNpZU7QVB649xp/LEXXktUw9aIUFg=; b=PjuUpxiFaNBW14w+W7og5f6pUlxE/I7WDjJJRe4x2uFE3E0fwp/rxuAyAa42fuW+dqro+K5foNqf0OIKylq5kdTraCTRmzpsIcX6AmpUAn5U8t0R7GOotfSFOG+61Oy2VZT4oTyYeUVti+e03l9KcvVIwxIhCZNsbngSFiEvKZk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:14 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:14 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] dmaengine: dw-edma: Snapshot the v0 interrupt status once per handler pass Date: Fri, 10 Jul 2026 17:09:02 +0900 Message-ID: <20260710080903.2392888-7-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0162.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:383::17) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: 94e506be-3eb1-47e7-9ab2-08dede5a881c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: NVJB6AlL3Kyad83unZ871tZfRQDS67ntuGEwqvvvcdn1CVzpmAJR/hdTNCQ9GS6F4qOAf2F2OQd8pSGvpc90diM0x3YDjZ86pw7pbZTuXmaA6aOQJfW/3CqvCk0vfPFxMSB5o+AXtSTrw6vH+6799h9Wb8MDerFLX+VZj8Z/E3YLSM3NsyWWnRuRc8fx/dPkCdqItK5QoVtg0DEgW5n9fFsV8uJ/Tru/ZKpLqHE4SUn2cJxwUpk3VlpY+D5YmPRFn2qc8AiXjprPQOo5zX8YTaJKJkgbybbqqhaU3Ekewgk7UWu9vOx8QMlDc9Q68lufZCZxoMyeld9i+XnoXRu4BIYjC6j9Gfdoq8MnBonKRyhZXTcWk2KKgDKQw2cCDtEyAsLBOi8etOFTiKhRjyI6sUXxwGwmrDQMI1WAOMLyDrE/4jGDCJ7ewGHpJqREXU1zHKGsFVfGJm+vSVCJ59/BzZAoSz8Ho9UyKcwDfagJNpTGl5lVQgaLxPayg7Fa/K4fTgr4kzz8UtEkbp10VHIwJWvHT0R0zBQnTt1MhZPoIvw5Rfyv9cmcnhYTkX2GmJKRFGjDNNZwHQrLnf9hUtfD9TQ8HjI7xT87UYouSj5obbUWMMZs8lUobfKnwRkQQjYnzFqVwhi1FuE4sYbfv4Zwwljahk2/4Tr+b/kMuDXBrE0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6BCnMav++UAV4Baxa1O5lFGlLEuTfTTTRJwKC5Utf8JHqjlIdIGf0OA6aabI?= =?us-ascii?Q?xS81LWsZyOzccokZmhD9W/x/toy9oqBkfyRQEq75sCsu/RXmgfgwyiK5voj7?= =?us-ascii?Q?9cBFAmjYguk09Nozn9ctvdoH3lY/t0Ur77oHTthS89yFLOgLJVFYFYIjhj4K?= =?us-ascii?Q?mK8oLG6JBgOyXypLQ4gXdlooKFmOGwIjONOpQKFOGcPtR/saNMQEYrksc0Ak?= =?us-ascii?Q?GA4FHb6wKhawe4R4xWQlabVog/VBqNRCi+qpz//1B42nMK7VFGbLLiPgajLC?= =?us-ascii?Q?eDirKDqUnAxQMWoXMC2zsveFkHc2+scAvwSrMBzNDoVDtjRgokxfI2yp0elI?= =?us-ascii?Q?V2eksCyAemV6urYVnMp7t1VQLJLpMPkCa49lPBipPunc5CMtTQC2wO7AZL5g?= =?us-ascii?Q?o9ICYY5l+eOXZecoza6CRRxO0LtiQrg84RZ+lGLFYVAgjeAsKbw8cmhN66io?= =?us-ascii?Q?SeflIHqrfGiVxAZAu7h0NI+jGuxYU4cEp2z2cHRB02B2idpEbnfN2e8FM+j+?= =?us-ascii?Q?6j3cdO2E3UstYedlJVFLDlVdFdPirFEuQwKjL5VpMDRB5YGViMyFbOhI3q9j?= =?us-ascii?Q?4CymHG02TIiREkHeviKxwNSEVxo+RdwZI1OKsyP5/cvEen0uWxh3KrJb+eIs?= =?us-ascii?Q?oIDrB7QSJWGw/dCDUr+ChbkQBpdE3ayuZkh6XHmjJ/TPtxG6LYaFmqm190ES?= =?us-ascii?Q?d1LAZMD8aKrs2UPcHHYGGOMN+BqbPwEvNd2szJ+t7WOA0ESrsL6ddDhmwApR?= =?us-ascii?Q?sRCKgR0cJTTrEFZ6JbgNFCfQKo698BXf+roQbjNVoIK8qNxuZfzgZopswi60?= =?us-ascii?Q?fa8EaDHU14EHtdaPywrCWdahd0Ekfj1r0a6ZCMz8FqjrANIV4OF8B7pW5Jd+?= =?us-ascii?Q?Jbn9n1YBeiKwvK0jeUmEpjcRaWegyMBS+QUwhNP51JOIiRpqo9d+4LPN1V1P?= =?us-ascii?Q?cHZnuM+ZNDz3dLkXnWZ46Zm6Stvbz+gqrbT0g5PrULHQKRiE30/L5KWuSS2y?= =?us-ascii?Q?o1tc5v0bNaSkCSxP1r1h4C8AGKMnPb+j14y+ulLFewETPksau6Anf+/Gm0k8?= =?us-ascii?Q?/gP1KpxAkgA9uNqmcARXHF2Vy49DVoa5ofRtZFA7kVukSHIGD9YgB/2No4Ty?= =?us-ascii?Q?Y37HVdTX4kx1IseOe6qnuVgaoS8WiuGA8+qo7Fw5ICxHOV/HlnWlV+gRd7UR?= =?us-ascii?Q?Yj3E4gbhUsS1zYlWyl9aPZq4fiGkCgrW4l3Va5M20ytMACrvBsQBLyvYsbgh?= =?us-ascii?Q?TMwfW6DlkHesKNS73tC7VrP7c6AC3yyj8M5IDr5rtuT9lhvgyC/yrUZmj5MF?= =?us-ascii?Q?c5N1rK9/FTFYLLdi9Ww2c1g2FUxBp7dF2DuF4nvrRuGEtH/BtkmGLJaPliNb?= =?us-ascii?Q?D3fWyeVIV4Aqs4YW6a7KDriJadgwnznWfcLxw43ET5U08UjC3qa0OLaG7lYN?= =?us-ascii?Q?6kDEUSZr3meY1L1G18vaDAnvIwKRSxhUwbDzPJwDVMFbkyjBb/HSzyg5UiC2?= =?us-ascii?Q?koggBPTQuMPLAr+G738SxNonQ2tElB334VAWXGMGPw9VvnHkZJIF8CCpD8WL?= =?us-ascii?Q?uwx5t4Z32ftkFU3J3Tal/4Zxs9ltCSVZpxzyvaja8ctBoIIkTCoqUM1DSXC5?= =?us-ascii?Q?LX3WUJ5ZE8Q1x27DmhEiQ1m2rH4kMktCc8PrZsZjYg/QA0rgvOi4Z1qrLat5?= =?us-ascii?Q?Oygh33XPAUNT3CHcOyVWkZGgoze9Y/GhiE5b4buEo3iIPVGJF1YRCMCOYYMM?= =?us-ascii?Q?AitQoKrHZEWDe08Eq2ZQ/qKO+dMfjISFAVdWjRimcp6JlxVb0VPU?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 94e506be-3eb1-47e7-9ab2-08dede5a881c X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:14.5949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BNXdXWcnEPaO+90LWpq48OPDjssgEjH4w62x0mLVxL6sxQYpzX7aNnZiA/7ltTLsiHYVzTlpJlkkHQknGkuXKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" The v0 interrupt handler reads the interrupt status register twice per invocation, once through the DONE accessor and once through the ABORT accessor, although both fields live in the same 32-bit register. On remote setups (dw-edma-pcie) each read is a non-posted round trip across the PCIe link costing on the order of a microsecond, and with one completion interrupt per element the duplicate adds up. As an example, profiling the R-Car S4 remote path put the handler at ~7us per invocation, dominated by such reads. Read the register once and derive the DONE and ABORT views from the snapshot. No abort is lost to this because the pass only clears status bits it observed, so an abort raised after the snapshot keeps its status and its own interrupt delivery brings it to the next pass. A second abort on an observed channel cannot race the clear either, as an aborted channel stays halted until software restarts it, and any restart follows the abort() handling, which comes after dw_edma_v0_core_clear_abort_int(). Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes in v2: - New patch in v2, posted as part of this preparation series. drivers/dma/dw-edma/dw-edma-v0-core.c | 28 +++++++++++++-------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index cfdd6463252e..377812eaa110 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -218,18 +218,6 @@ static void dw_edma_v0_core_clear_abort_int(struct dw_= edma_chan *chan) FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id))); } =20 -static u32 dw_edma_v0_core_status_done_int(struct dw_edma *dw, enum dw_edm= a_dir dir) -{ - return FIELD_GET(EDMA_V0_DONE_INT_MASK, - GET_RW_32(dw, dir, int_status)); -} - -static u32 dw_edma_v0_core_status_abort_int(struct dw_edma *dw, enum dw_ed= ma_dir dir) -{ - return FIELD_GET(EDMA_V0_ABORT_INT_MASK, - GET_RW_32(dw, dir, int_status)); -} - static irqreturn_t dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir di= r, dw_edma_handler_t done, dw_edma_handler_t abort) @@ -239,7 +227,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, irqreturn_t ret =3D IRQ_NONE; struct dw_edma_chan *chan; unsigned long off; - u32 mask; + u32 mask, sts; =20 if (dir =3D=3D EDMA_DIR_WRITE) { total =3D dw->wr_ch_cnt; @@ -251,7 +239,17 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq,= enum dw_edma_dir dir, mask =3D dw_irq->rd_mask; } =20 - val =3D dw_edma_v0_core_status_done_int(dw, dir); + /* + * DONE and ABORT status share one register, and on remote setups + * every read is a non-posted round trip across the PCIe link. Take + * one snapshot and derive both views from it. An abort raised + * after the snapshot is deferred, not lost: only bits observed in + * the snapshot are ever cleared below, so its status survives for + * the next invocation, which its own interrupt delivery triggers. + */ + sts =3D GET_RW_32(dw, dir, int_status); + + val =3D FIELD_GET(EDMA_V0_DONE_INT_MASK, sts); val &=3D mask; for_each_set_bit(pos, &val, total) { chan =3D &dw->chan[pos + off]; @@ -262,7 +260,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, ret =3D IRQ_HANDLED; } =20 - val =3D dw_edma_v0_core_status_abort_int(dw, dir); + val =3D FIELD_GET(EDMA_V0_ABORT_INT_MASK, sts); val &=3D mask; for_each_set_bit(pos, &val, total) { chan =3D &dw->chan[pos + off]; --=20 2.51.0 From nobody Sun Jul 26 01:57:16 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020099.outbound.protection.outlook.com [52.101.228.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 293253EDE40; Fri, 10 Jul 2026 08:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.99 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670972; cv=fail; b=oX3tQyui5JQoSNA7RJZUlqOzbo8UOUY79awcCwr5ma539FPcVc5i+3DjePMc3MlyoUxS1DfAeXONUiS4riJrOde6oYEETmz/xeelRd7AHIeZgr2KbNCBJiwEaxL4V+igmosAhCaQEMHEywDc+EatvjJF3mdxNYtToFzyIixi6VI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670972; c=relaxed/simple; bh=wd+xxdrnHj8oE4euNvkQnfc3szFzWPb/Eyufp42xKsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=OopX8toxzPYcmPTqjzrlRtpzuofKmyPCUIV7D9Gg4spvxaELYOtXd17Uav2C6TCmQ1x+Hit3yTFw22ZwoAGyATWY7Ggt3wPkxmGo4iLYTIfvlo3u5p8cFzxsEqnausrGzZ0s2zhNMWlSLMiVhHMZpM7CTamzn097O/fu7ka9FR0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=JIJgMxDi; arc=fail smtp.client-ip=52.101.228.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="JIJgMxDi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UPV0aEZZgpK8XtCteeMyJYcwsnVkz2Z17aNcIkQqvEjFUXr9NGIt1JPmOHHcTC5sXqoK5GaCLr7TLdEqoU4ELkUw5tOWaGVOOFf1FTjuU5MlrAY5F9JjNJidLLRY24Fr4emf3deLh6ATBtpaBAYngpv2E9DdhnIkf+6U1b539A/E9cmtqiq7HCjEuR6GYlRbv69iBgACL19i+/tFQWBkL6cwnjkH7vI3uEOIvmPnYeJI2f0zdl+CIrmlaLHCGd/YrWzB8sO91Y6QczDniqvJjdS8FGeTt5anEQxaMb3R6CA0/RyQTOaC21anygDJdIFZWCWLRK/JpUdmz4/IEZbNvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ovou42GCiulL2AtMFMxSDek9dtOmLR2AXcKcG91ccDU=; b=fFlNH5Zl0wmPtiBDMywa7JblcKLUPaO1Uw1v9NMaNQqOClo63AjBmI/J/PIKNsxcTtvlA2smHSS9CsdVZrBhpjPs5Gt6inPwSAYGyx0G6f+NIIyzCdGNbwQTS2e/FMhIYnlg9sYb/RxFipHfxwxEf2ejr04Ni30vnbQJzHPWDx9nf/AT5EDzAcRV3wtGoCfoLP53l/LTrNSyKzbpzsscHJYvquurkG+2UAOgsu8eSlFCWoI3ZuBeQm9NqoqhuKD0iRq8EThocKIRm+jlYeQ86piHfvgb/ny8AOEB5egRO+Z/R7bDogk67bp4fWQvzCSe/gk4POGUCWnsZPxtpblLgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ovou42GCiulL2AtMFMxSDek9dtOmLR2AXcKcG91ccDU=; b=JIJgMxDiuOlrLm0PtXpqOwWHdBzf6Qq/IDfM6ke9VxtHC13QB+lqwxsDjkx+oHHmYzG1vjmSPj6u/aVTk8cXg5un16nNUzPdQtjc2ma6mLs5CEYz8sRDdGVmHanPEr1LRzaApDr+KuPJCSp2SHnY1N2S2xiAlpX9Prx2ZavXQ7c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY7P286MB6374.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 08:09:15 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.21.0181.009; Fri, 10 Jul 2026 08:09:15 +0000 From: Koichiro Den To: Manivannan Sadhasivam , Vinod Koul , Frank Li , Cai Huoqing , Serge Semin , Gustavo Pimentel Cc: Devendra K Verma , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] dmaengine: dw-edma: Defer channel IRQ handling to workqueue Date: Fri, 10 Jul 2026 17:09:03 +0900 Message-ID: <20260710080903.2392888-8-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260710080903.2392888-1-den@valinux.co.jp> References: <20260710080903.2392888-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0182.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:382::9) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY7P286MB6374:EE_ X-MS-Office365-Filtering-Correlation-Id: 36d41804-fce2-4690-0b61-08dede5a889a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|10070799003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: K4uChymZU8WKA0Bvbhyx2g0NCSM4vr/Y83N2fq1azvgs6CUCQ1JPjn3/EAzbbcLmwtBohktGizrmDrgLHRZ1NwouwdpZT7BrElraXrIFVW44zS/P6U7kUWC3kjyUQe9o0AzmPYoWXdLHKS9+U5379DbKGv2g2yey8p9ncDAT/Frdt9pLLQf+o5hihJ5lTWm4NOGh3W+9SwDI+XrSeTLTcJTIbPKUEH488OJEPvnafvldxK4HsdpBh5kGEKX0LrcDDFFMm59Kk3LKmw7KqL7DySKYxQq2XmuLFm0ICPf0S6dIHFQM5FaB+XOhz1BaCkA4/KGCaznq5k4C4/vFpnQmfR5UHlkOaVyYFbauVZyk5JIRFR8HpdMpmKodztIxKmYUUGfwMNkp+ENqog/LszcVyqpTwZjFiogz/8rMv3IyDQTF5Zsas1DQG3LOrR98El2oM7ggpb/WCTr2hx3A6vUH7/1bD14NC0CAfIFJHsleBxsTE48iGx1b/69gGbM5AxXdTZYhpeP5m4q1yDMCYhg9kbpKo7gxluczNT+1VF6Eq7GyApf64oCJss7Ms6wGl8vjr7sKJniaDjORrPYEmAm7Lfa5a09E13dMM9wrXADBvZyIXeCVJgpUT05Nm+9uSOJjgTvV+8KLAbO2pL12NByKBtGReLYvlArAiaP3icPApZY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uEHqlXKfF+bwNwuxyJ1uH5RC00RnxlRUGI15yvdA3cXFCJHjqdRHK+1EsVyi?= =?us-ascii?Q?s8gwUf26NkLx9U8LlhxQ+AHPahkV3AVjyaETLfFkb6BzR8sl8OyihgNK8hZ9?= =?us-ascii?Q?dQF1WUbKnhzkuZzu1l0ARihyuhegIiexwPggcPW+DcJyJ3GBVIP0JAockodf?= =?us-ascii?Q?az44iexXKZnZUnl6G+xLFA4WYT2eqXaCVRiSjmZm4pcEEJmLr7X42R1p8d4V?= =?us-ascii?Q?Vouar7WPboYAluRzZN8UGr6IKjDZgtASiCrvEk0geFO1vJuTytvL+IQyt77Q?= =?us-ascii?Q?Nyppn55cFYFr40+zB/Cr6XhRhp6nX4OzMtn3D3FXCdAO1peD5CZC/FS5Y9Dp?= =?us-ascii?Q?bfCdVZ6zU+oeXtH89/V8fxqwwlJ+i1GIoRxDEskIXKDS3Pi5F8/4VJa3Ttci?= =?us-ascii?Q?pxyuBR9kfgKenRhYfl85G8Y7w/atxo011/qqKThhKc0AQMmcVkiN2PMIeHuN?= =?us-ascii?Q?C+fhZI72SiW/BoEhrFCf504u8pGmpeuvNZhbv1FOBMxxbk4SNRCkfIQmc1SM?= =?us-ascii?Q?AzK2vOLDvbPdz3dMJxim5Tb5HiJwIt4VY+pUo7gK5HtizUG+RVxtMExnXxSK?= =?us-ascii?Q?MVphHjEMbiIZc90PnBzLljTsVeFF8tFFFYfp5Glm9zX5XckUGxHjluzSb5AQ?= =?us-ascii?Q?NxrDbcNCkJS3FgHzXYUOzxFdhPOrhKe9FnZV9mVkt7V8O2JFxyu+tedWN/1R?= =?us-ascii?Q?hjutNxyVrR9tVsTw83MeYfNf5HlJdH1X2383xz8ftf43h7c/lATQxbP9oWvv?= =?us-ascii?Q?c9lQxCpq4DHxW8jwtSZMTLwekRt07a2TM6vtNcaoYap9KJvhQNSfoogEMugW?= =?us-ascii?Q?YRztSvVFPxUClTjynAUFWZjTy71HjgeJ7dnD5G6SUUCEDfSN/GKYl7mpdYes?= =?us-ascii?Q?WHbb2YtlRxQkLOlrCanLWr25pgu34ES7XbeYqOEqnQwcyqkryt59JG0bA6TA?= =?us-ascii?Q?HPV4uPbjE95nLXiHkz0J/1AaDCQvtxcQpD6wJQVbuI0cAGkuQzsmTcVVza50?= =?us-ascii?Q?tp6A6al8kOiELiR20+CAI44frZLkmXyRzAaFAlVfuBxKMTjjI0uCf2+ISA3l?= =?us-ascii?Q?msKpwnVLheRTCif+0yBlsMSV99zrv58TJEXs5gVzqKLtcEMSBY/Fa7PNODgU?= =?us-ascii?Q?t2bl8yPcy1jWqqnBHxztTliTldThQ6Ca6t9pio7nZ7JYI+Fdn+rX28tncfKe?= =?us-ascii?Q?gyiiZ/FJDxwALUPah/fh9cQzJDFCan9vN2cP/6YgfqfxMVdoUkdDWXAsx9Jv?= =?us-ascii?Q?MmgBlScmvhnF72NtG/zhFRgA8tqziQTv1Q1OCD0PG9tFcnZAVHrRmuIy8FTl?= =?us-ascii?Q?+u4gCmnJy4WVgxBy94ypZPAT1Akv693Clh/X5ERhSdfLRKbOBJvSqhX2LnST?= =?us-ascii?Q?i4apo6SXrf7JBC1kzQPmO44eJxulaLN63SjaV6lxrzZIuxXXlBEzuPQSYjIi?= =?us-ascii?Q?9+DZEWm1hjwjGr/P0RY44jnBQAN8six3aoLe8RAVjJuH5swOQs2VFEnCdmto?= =?us-ascii?Q?K11YRyNlvzHq30O1aowad0wyi8pwvu+SmTfAooYousbkgPy9GN6+Mo6+FuAX?= =?us-ascii?Q?FxLnVlTIkHx/Okz6qiNLLsksip33Nb8/GHsfFHOyK5ouyDWRaOXxjJIvdmYa?= =?us-ascii?Q?vWriM/QeUHpL89ZrKTH1lBQ4LRIoEXhB4Lv8KRnpQUfSXgLmmAo1YaNwdnEc?= =?us-ascii?Q?xdzOA/B2jEIcMNUlbDHeNqsGNqYLkyoEm63aAbw/ZKE7DeW8lsIdq4v2MKk8?= =?us-ascii?Q?56+08WHQUH1JeTw9kdtCUgPydHyZKOCNauJUrGx2Ae3Q8aAelxtH?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 36d41804-fce2-4690-0b61-08dede5a889a X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 08:09:15.4056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I9+KtWIP575hzNkd9RZQhiJWbFx+4vC7THVbEeFN5iAfq91jFlItha8wwIiPYgTbEgJnJlgPoKP/UiBmkQJ+ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6374 Content-Type: text/plain; charset="utf-8" On some SoCs (e.g. R-Car S4) the endpoint-side eDMA raises a single fixed SPI that is hardwired to CPU0 and covers every read and write channel. Handling channel events directly in that hard IRQ context serializes the completion processing of all channels on one CPU: descriptor recycling and refill, client callbacks (the vchan tasklet runs on the scheduling CPU) and the doorbell writes all funnel through CPU0, while the handler additionally spins on each channel's vc.lock. Especially under multi-channels heavy load, the contention becomes a performance bottleneck. Keep the hard IRQ handler minimal and have it just clear the status and dispatch, defer the per-channel processing to work items. A work item per channel preserves per-channel ordering while letting the channels be processed in parallel on any CPU. Signed-off-by: Koichiro Den --- Changes in v2: - New patch in v2, posted as part of this preparation series. drivers/dma/dw-edma/dw-edma-core.c | 73 ++++++++++++++++++++++++++++-- drivers/dma/dw-edma/dw-edma-core.h | 12 +++++ 2 files changed, 80 insertions(+), 5 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 5664421c6f15..704d8f9746e8 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -31,6 +31,11 @@ struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_des= c *vd) return container_of(vd, struct dw_edma_desc, vd); } =20 +enum dw_edma_irq_event { + DW_EDMA_IRQ_DONE =3D BIT(0), + DW_EDMA_IRQ_ABORT =3D BIT(1), +}; + static inline u64 dw_edma_get_pci_address(struct dw_edma_chan *chan, phys_addr_t cpu_add= r) { @@ -748,6 +753,44 @@ static void dw_edma_abort_interrupt(struct dw_edma_cha= n *chan) chan->status =3D EDMA_ST_IDLE; } =20 +static void dw_edma_irq_work(struct work_struct *work) +{ + struct dw_edma_chan *chan =3D container_of(work, struct dw_edma_chan, + irq_work); + unsigned int events; + + do { + events =3D atomic_xchg(&chan->irq_pending, 0); + + if (events & DW_EDMA_IRQ_DONE) + dw_edma_done_interrupt(chan); + if (events & DW_EDMA_IRQ_ABORT) + dw_edma_abort_interrupt(chan); + /* + * Correctness does not depend on this loop: queue_work() can + * requeue once the work item starts running. Staying here just + * coalesces back-to-back channel events into one wakeup. + */ + } while (atomic_read(&chan->irq_pending)); +} + +static void dw_edma_queue_irq_work(struct dw_edma_chan *chan, + enum dw_edma_irq_event event) +{ + atomic_or(event, &chan->irq_pending); + queue_work(chan->dw->wq, &chan->irq_work); +} + +static void dw_edma_done_interrupt_deferred(struct dw_edma_chan *chan) +{ + dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_DONE); +} + +static void dw_edma_abort_interrupt_deferred(struct dw_edma_chan *chan) +{ + dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_ABORT); +} + static void dw_edma_emul_irq_ack(struct irq_data *d) { struct dw_edma *dw =3D irq_data_get_irq_chip_data(d); @@ -842,8 +885,8 @@ static inline irqreturn_t dw_edma_interrupt_write_inner= (int irq, void *data) struct dw_edma_irq *dw_irq =3D data; =20 return dw_edma_core_handle_int(dw_irq, EDMA_DIR_WRITE, - dw_edma_done_interrupt, - dw_edma_abort_interrupt); + dw_edma_done_interrupt_deferred, + dw_edma_abort_interrupt_deferred); } =20 static inline irqreturn_t dw_edma_interrupt_read_inner(int irq, void *data) @@ -851,8 +894,8 @@ static inline irqreturn_t dw_edma_interrupt_read_inner(= int irq, void *data) struct dw_edma_irq *dw_irq =3D data; =20 return dw_edma_core_handle_int(dw_irq, EDMA_DIR_READ, - dw_edma_done_interrupt, - dw_edma_abort_interrupt); + dw_edma_done_interrupt_deferred, + dw_edma_abort_interrupt_deferred); } =20 static inline irqreturn_t dw_edma_interrupt_write(int irq, void *data) @@ -930,6 +973,7 @@ static void dw_edma_device_synchronize(struct dma_chan = *dchan) struct dw_edma_chan *chan =3D dchan2dw_edma_chan(dchan); =20 dw_edma_wait_termination(dchan); + cancel_work_sync(&chan->irq_work); vchan_synchronize(&chan->vc); } =20 @@ -972,6 +1016,8 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u= 32 wr_alloc, u32 rd_alloc) chan->configured =3D false; chan->request =3D EDMA_REQ_NONE; chan->status =3D EDMA_ST_IDLE; + INIT_WORK(&chan->irq_work, dw_edma_irq_work); + atomic_set(&chan->irq_pending, 0); =20 if (chan->dir =3D=3D EDMA_DIR_WRITE) chan->ll_max =3D (chip->ll_region_wr[chan->id].sz / EDMA_LL_SZ); @@ -1185,10 +1231,21 @@ int dw_edma_probe(struct dw_edma_chip *chip) /* Disable eDMA, only to establish the ideal initial conditions */ dw_edma_core_off(dw); =20 + /* + * Deferred IRQ works are queued from the hard IRQ handlers, so the + * workqueue must exist before any IRQ is requested. + */ + dw->wq =3D alloc_workqueue("dw-edma:%s", WQ_UNBOUND | WQ_HIGHPRI, 0, + dev_name(chip->dev)); + if (!dw->wq) + return -ENOMEM; + /* Request IRQs */ err =3D dw_edma_irq_request(dw, &wr_alloc, &rd_alloc); - if (err) + if (err) { + destroy_workqueue(dw->wq); return err; + } =20 /* Allocate a dedicated virtual IRQ for interrupt-emulation doorbells */ err =3D dw_edma_emul_irq_alloc(dw); @@ -1211,6 +1268,7 @@ int dw_edma_probe(struct dw_edma_chip *chip) for (i =3D (dw->nr_irqs - 1); i >=3D 0; i--) free_irq(chip->ops->irq_vector(dev, i), &dw->irq[i]); dw_edma_emul_irq_free(dw); + destroy_workqueue(dw->wq); =20 return err; } @@ -1235,6 +1293,11 @@ int dw_edma_remove(struct dw_edma_chip *chip) free_irq(chip->ops->irq_vector(dev, i), &dw->irq[i]); dw_edma_emul_irq_free(dw); =20 + for (i =3D 0; i < dw->wr_ch_cnt + dw->rd_ch_cnt; i++) + cancel_work_sync(&dw->chan[i].irq_work); + + destroy_workqueue(dw->wq); + /* Deregister eDMA device */ dma_async_device_unregister(&dw->dma); list_for_each_entry_safe(chan, _chan, &dw->dma.channels, diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index 6474cacf7195..a6a9ed09fe1b 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -9,8 +9,10 @@ #ifndef _DW_EDMA_CORE_H #define _DW_EDMA_CORE_H =20 +#include #include #include +#include =20 #include "../virt-dma.h" =20 @@ -87,6 +89,9 @@ struct dw_edma_chan { =20 struct dma_slave_config config; bool non_ll; + + struct work_struct irq_work; + atomic_t irq_pending; }; =20 struct dw_edma_irq { @@ -109,6 +114,13 @@ struct dw_edma { =20 struct dw_edma_chan *chan; =20 + /* + * Deferred channel IRQ handling. WQ_HIGHPRI keeps + * completion processing from starving behind saturated user load; + * WQ_UNBOUND spreads per-channel works across CPUs. + */ + struct workqueue_struct *wq; + raw_spinlock_t lock; /* Protect v0 shared registers */ =20 struct dw_edma_chip *chip; --=20 2.51.0