From nobody Sun Jul 26 01:11:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E57EA4071DD for ; Fri, 10 Jul 2026 10:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678918; cv=none; b=dCEj4cG6xSDivZ5XZeg9WbXsFEH6sPQbCnHXnXu67X+N3lVITMu8p4Y31rCK0ASYEf+mKMPmd5v90m9egH0zgamHr7RkqbV9bzoJmC+cAi6q4/8ELxtwtZ2owsVbiz4TAuro4C3CdOfBzua9N302huqSxxVbaiO2oKhoHtyn3Tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678918; c=relaxed/simple; bh=3WxbNsQ7mZ69Fc2jBNSJ2Td3Y+toTk0N0QW24jryalM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=bZeOzLOf5hM6Cme6ZXREkOgG2OaYfnxw3OHN9Avn6Y0aEtqNK8IXWJWJLd45eQNJafaoy6mdi80EfhEW93UD/0g8UKnD3kdJb5VOwG22IHcw0u9lCcKAOKsF7bsU5VOMbiqclmH8n1rF0GSMJaX9pBCDqFFDU31CCvZ2BCgohH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZleMJOds; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MuP1ymFw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZleMJOds"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MuP1ymFw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A9TTvT291947 for ; Fri, 10 Jul 2026 10:21:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=EZFxcAp6FNYb8Alm1yQTDT ica+rLWTyD4KSCLFaJ3ZA=; b=ZleMJOdseGTOZiB9IiastIj8GF4tJu0uJZdDHB YF+X/KpbGr6LDT0a+iYHRa9tnFKwRGvAq81NMp7gVUJG5pnokMCJjEhzV4iS2HJR ol4WT4DpziJWV6CN3DCICRC/UEzC6PwiF6BuDnkLYkV41Sdb/gcxBodZQip31uvd PZH70G9ix/qYbC+t3YujqufRMoae7kxyNfw0C0GHbuTW0/SxVOApxBRRp9S+3oTT i6X0lGBMWmFm9WnMMgD4PpZ7vtiV+w9S8AGHuoqUl7XiMm+YjhgRnXW4r/qpL3wQ X9oX7sk2rFbkh9CXhIF5goVbxaDbVgvx+4oJJRTgwP5H4ymw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fax5dg6kr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 10:21:56 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c894c1c4aa9so1146084a12.0 for ; Fri, 10 Jul 2026 03:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783678915; x=1784283715; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EZFxcAp6FNYb8Alm1yQTDTica+rLWTyD4KSCLFaJ3ZA=; b=MuP1ymFwgT1N3zH/VI3vdshTM4FE3lXeotKrpm8DxI1AP4LgO1AIc/eaqm3EyS66lJ sQ/rt0/U7g3vPJRkj6zNw70xgBKZu7sFMZsLnyEZd6RrKGZswW7ft5/hYQ2BrsbMzjIU XT+btYwL79NZeJ64WLFxg73HfFdz5iAhKT8CRQr7/zbWt3XiWDg3KLUNnxO6+irlpkRX m7h3OCkTOEk0JZuqbZRuB/UMA4sXxtsA1Ir7xYDLmoP1ivwTpMf+JFDnBIblbAo9EU/z KDP6/0ODXWO6MMc457wpwkdE9uJ5x/qeXW67j4Xj+HghvSiS1tIPMQ94yaQHDlxjUHfH twrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783678915; x=1784283715; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=EZFxcAp6FNYb8Alm1yQTDTica+rLWTyD4KSCLFaJ3ZA=; b=p1IR+fwwcthdEGLONvijX1kT/lxuSX0OLtrq3vWrEzCpov3kP5SUxhfc0kiJEndn8c kTsfd6tEF6M3OP973fzv16kPA0KFpfAAGwLPlxPcXs0fkjQE2m7UzzZB/RJ0omKlQNKG SMTrkvJ9nYE10u3qa6Sffz533pCVRcDbdN3jzIA/L/T9m7Ive+W98Trg6MA5vBySFa4y BWdO4uh9o6vkbEi40Vv3mqqkOzPwIPHo5iwQ+ecZafBnN49DMbsWSR6maOkSNpyEAi8b O0vSoUu6y4YS7yf47vNNBYbf1MM2eS4UeKbnvsHQZ7Py4kGOQ0se2dTnyfzpb0NNGQFa ha4g== X-Forwarded-Encrypted: i=1; AHgh+RomI8NyUELFy/kTHRC8BJII+O5uqszAIFrfkt2yqmeRb5c+jHrho+4ThzxSvggsRkiUxN6fE3pLb0OfMcE=@vger.kernel.org X-Gm-Message-State: AOJu0YzlyEZY9KpmNYjU3m66sunCwgdsUmFzYTINwEvT+ganriUw1tgp zvih3CW7kpjg7o7bgLgnzfgbj8tnFvtXpA+sPYfKXhBprrPqlOQdoIFv0wju456nJNNGs2ymtsh WJFkQIjkTvzI9QeGewrylV/+KD0Luc8OYwXvsyiFhMIgMmm7qFqRmeWH/P/hlnwA+4to= X-Gm-Gg: AfdE7cmCVRX+XFRehDxwaWM7uF6Gb1jrqK22m6mU8HACCXrBQsP8vQKoOWUDSiOusAe MegjnOpjHmxA2ba4bDN39mp7EzmQod74V/gkL6Oni7Bqw69lkG4+vWZDcw4DnPBr80hiLieeBmo IEvewgtfNe2TpaHER/L+fVf3H3jQETcLOVChO2xmMeXsijQGhNVZRNxshAoDyzs+h4FdbhhVrU8 yXO0j17yoaP7YPfepuYwcZsYRJD/aZ0iBI3uArM8lbmKbRSCORtc0D1So4qaAPdXAfVkYHPFbbH nG34OjHj41ylOJMDbSHAHVRFllTsJ3oQj8zhDDqLWaSbgL9IwrHQlvHjkbiXGMEQwSLs8p+vZCU KVWqPqP84PjeBfrBxkisroNfrHotuUQ== X-Received: by 2002:a05:6a00:3a13:b0:847:83bc:d2a4 with SMTP id d2e1a72fcca58-84842ed228emr10458910b3a.2.1783678915198; Fri, 10 Jul 2026 03:21:55 -0700 (PDT) X-Received: by 2002:a05:6a00:3a13:b0:847:83bc:d2a4 with SMTP id d2e1a72fcca58-84842ed228emr10458873b3a.2.1783678914642; Fri, 10 Jul 2026 03:21:54 -0700 (PDT) Received: from [10.213.109.130] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8485413c264sm2943435b3a.61.2026.07.10.03.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:21:53 -0700 (PDT) From: Jishnu Prakash Date: Fri, 10 Jul 2026 15:51:31 +0530 Subject: [PATCH] usb: typec: ucsi: ucsi_glink: Prevent suspend during UCSI notification handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260710-ucsi_glink_wakeup-v1-1-7d97ea628d92@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAKrHUGoC/yXM0Q5EMBBA0V+Red4mVVGJX5GNaA2GTUlHkYh/1 +XxPNx7AqMnZCiTEzxuxDS7iPSTgB0a16OgNhqUVFoWqRTBMtX9j9xU782EYRGyQG1alalcG4j d4rGj43lW39cczIh2/Y/gum4DVSDudQAAAA== X-Change-ID: 20260710-ucsi_glink_wakeup-07e6bd23256b To: Heikki Krogerus , Greg Kroah-Hartman Cc: Dmitry Baryshkov , Konrad Dybcio , Deepak Kumar Singh , Kamal Wadhwa , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jishnu Prakash X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783678909; l=3002; i=jishnu.prakash@oss.qualcomm.com; s=20251014; h=from:subject:message-id; bh=3WxbNsQ7mZ69Fc2jBNSJ2Td3Y+toTk0N0QW24jryalM=; b=MRZojahDR7WCNFa16OeapIuLBu3cvPvjMl9zQ1eWrymTMiJrx/WAu1o8a/Ur1TiAuR7XRQjZJ HLULj3iHCLXDak3NUYvCVqtXAhQcCbomYtMMKpYrLr6/neisw1Jywez X-Developer-Key: i=jishnu.prakash@oss.qualcomm.com; a=ed25519; pk=g89pXdLVwRjdTeQ+uX1QzvBO346E3hQAc1N7fcTXgmk= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDEwMSBTYWx0ZWRfX7jdiaIoFCAi6 bQyN9eO0et36R/cyZu9VI5ULrTUwoYZIxYKDnsJdgodrTqHPjtQIeS9ALKgE0aeWwAh1VNpBazY WIseUHLh8Ys0VSBqMKN7FlMdP1jYiCw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDEwMSBTYWx0ZWRfXwJeJykipVZh2 wZNFUz81zGfY9SqMvLevZDerQUE7orbQEFnov6j++xSMMznflAph1YDXb5lxTFhtHHCS1BRhg7Y Szi8ECmv7vZUjeVPmDoJ/g67I+TL9jMckWCZ+1WJHxIA6fNM2bHGsEcqje+35IpBW0f5LLS2zZg n4KxbESQ+YcfI2ns1ocZNCZMftkBZEGpOpp4EXJGpMNOWklrOuG1h9jOoGw5U5oq2KyLXWxOHcB rNSIA2ferq9hCZxfYi2Tn5rwNSpodcNajWKPmgZaL8ft8H/xTl5y+/tEhfwd9e0mo0IJbpNtNhE wK5OxEdTHPBLf+KH1gWdha4rrEM/QOHlQk55QqzbAxIpylrlLor1UtfIrH71nbgS0KxU5Mz3mhM apZp58s7UDg3oRnnIiAbF9gQs3WvzkiGHceN5Qe8o8rrWMC2mbKxoRkOHgTcnBifIhJvDwrol/s rL3dYmAZe/7ahtrsplQ== X-Proofpoint-GUID: 2Gwelf_gjlSM23g0pq0kgNbWixH5AmJv X-Proofpoint-ORIG-GUID: 2Gwelf_gjlSM23g0pq0kgNbWixH5AmJv X-Authority-Analysis: v=2.4 cv=M/x97Sws c=1 sm=1 tr=0 ts=6a50c7c4 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=Pr3NCNcdauOKfqzJXY4A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100101 When the system is suspended and a UCSI event arrives (such as USB plug-in), the GLINK interrupt (with IRQF_NO_SUSPEND flag) fires and it eventually cal= ls the pmic_glink_ucsi_callback(), which schedules notify_work to handle the connector change. However, since no wakeup source is held, the system can re-enter suspend soon after the interrupt handler returns, before notify_wo= rk has completed running, and the USB plug-in event would not be handled. There was an earlier attempt to address this at the GLINK driver level, by making the GLINK interrupt wakeup-capable, ("rpmsg: glink: Make glink smem interrupt wakeup capable") [1], but upstream reviewers suggested a different approach, preferring wakeup logic to be handled in the client dri= ver. To avoid losing UCSI notifications in this way, register ucsi_glink as a wakeup-capable device in the probe, and call pm_wakeup_ws_event() with hard=3Dtrue before scheduling notify_work. The hard wakeup aborts any in-progress suspend, and the timed wakeup source keeps the system awake long enough for the notify_work call to run. [1] https://lore.kernel.org/all/20240603073648.3475123-1-quic_deesin@quicin= c.com/ Signed-off-by: Jishnu Prakash --- drivers/usb/typec/ucsi/ucsi_glink.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/u= csi_glink.c index 12e07b9fe622..7fa039f0a2ba 100644 --- a/drivers/usb/typec/ucsi/ucsi_glink.c +++ b/drivers/usb/typec/ucsi/ucsi_glink.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -26,6 +27,12 @@ #define UC_UCSI_WRITE_BUF_REQ 0x12 #define UC_UCSI_USBC_NOTIFY_IND 0x13 =20 +/* + * Wakeup timeout to allow USB event notification processing to + * complete before device suspends. + */ +#define UCSI_GLINK_WAKEUP_TIMEOUT_MS 50 + struct ucsi_read_buf_req_msg { struct pmic_glink_hdr hdr; }; @@ -342,6 +349,8 @@ static void pmic_glink_ucsi_callback(const void *data, = size_t len, void *priv) pmic_glink_ucsi_write_ack(ucsi, data, len); break; case UC_UCSI_USBC_NOTIFY_IND: + pm_wakeup_ws_event(ucsi->dev->power.wakeup, + UCSI_GLINK_WAKEUP_TIMEOUT_MS, true); schedule_work(&ucsi->notify_work); break; } @@ -401,6 +410,8 @@ static int pmic_glink_ucsi_probe(struct auxiliary_devic= e *adev, ucsi->dev =3D dev; dev_set_drvdata(dev, ucsi); =20 + device_init_wakeup(dev, true); + INIT_WORK(&ucsi->notify_work, pmic_glink_ucsi_notify); INIT_WORK(&ucsi->register_work, pmic_glink_ucsi_register); init_completion(&ucsi->read_ack); --- base-commit: 2cb6eac064c8334418a76999468f68696a8dfe71 change-id: 20260710-ucsi_glink_wakeup-07e6bd23256b Best regards, -- =20 Jishnu Prakash