From nobody Sun Jul 26 01:50:06 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD5341FE451 for ; Fri, 10 Jul 2026 02:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651203; cv=none; b=HUqO5/5uw7tCsmK4jRUmZaMWmti1ovfktVoNPmg2LRpimNxFCqvYq9z7Q2cUDlj5ieTH5ZKp9YbyTcyqefM1hYtJYvB6f1PL9tHA4KtGHRKePbGtAL/2TQkdNLScKhzJLyoTpdemb8NxB1242lX943iJII/ElFH6z23FMRUH0OA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651203; c=relaxed/simple; bh=ltdgoUZ6tBDDcLfmDRkC7KQJz9iLegaPyl1qkMs19LI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WKT/sNGCjdbiOMi5xako+fn3etvD3LK5DLVc35hu5C76yEkSQEfIgM5b0Xx/NpyAHPRzVXP4BqVaNXoHvYa+UjpWIgbnP6uAM9oiyP42G7hyE4TlN/8uSddPjdYa7jXf/zcynL+oNCK5Pd4jJqo8eRrvE5r9ax4pzuovo4c+/nk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ENeThg6F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vckd+xk9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ENeThg6F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vckd+xk9" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669HX8Gu2563673 for ; Fri, 10 Jul 2026 02:40:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aJcLj0G6FGt0cvIQzEeMaFLLKWTNo1edV+7XI84Hxcg=; b=ENeThg6F0zqhVDJw wkzjiBPw9g/1cTEV0O25Gvu5jfU1Q2TJbE5nWugoE7sK2L/z6FIszDIny1Bwtprm mQLlr1JBkdLXkpO2CnnprHSNg7tPJ2wGP9QRh2AqKnvO8hoLkiHwOLWJW3krJ5Y7 wQukfNnVa415UqHLQdO8Y8R/G2b5iDsiS83zSHvdgL2YVc1nMQBe1zoFCRpL6sVc E1Y/2+Zy5VoK6EecrrIxwIDeQzf0llGOo1CnZpkCR2XMPni2AWDooChZvuqTX4fG 5YAkixwVVOHJ1TcisDSb142BW6d2+KAr32EXEqIPzCbxbXwGug6KqMG/mbV+7qA+ WLXcuw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faeg3jccm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 02:40:00 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8423f1fe39eso680463b3a.1 for ; Thu, 09 Jul 2026 19:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783651200; x=1784256000; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aJcLj0G6FGt0cvIQzEeMaFLLKWTNo1edV+7XI84Hxcg=; b=Vckd+xk9BBscsBk8eenBW/Ioxn3UrlELI1NjFqzms71fAhBGQ6zdUp+mdp429gd+Yf Bo4vTAsmc+aQ3sqYgQiWbr/OXlNBz9nbgnUpVbs28puEVXkPgsN/0EFIXEvCSvvGgGlZ f3UFmypHnvIkv/CHj4vr20/WB4mAneV0uKKpOLgAyilgbibNGx8cXhA+Th1MlNY6cWmh sWmhNzGHtJqlEIlm5+s9eiOkBHREaurT08v7X6OYmE6ZqTdhKlkJKTOC0GKgsZKaDTr+ cfuW/xl6UU3KRrRYVpn/6U4DAlIVDrIPswqOCKazGHaa/vEgIznHwTunJOb9iqRYdPhg ot4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783651200; x=1784256000; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aJcLj0G6FGt0cvIQzEeMaFLLKWTNo1edV+7XI84Hxcg=; b=BufJ0ISGRxBYFcqhPwxvJ3O/NIXyHtxEybhs49ivr8mr46POlmRiR20ZoW8tgtB7vX KQTgnX9l5kTsrPipkJQ7FgChd93AFu7Obzcyu9CrucmZ98FDT5VcHYduu5KHrBuNU/A/ vMbhNQNEBtAqTY8mVt6crMj0MPcLqTRL7yopCoSNDOYBWG/l6ixojH6FwPcrq2TaAWKD /TMcKERTEsyTeOtN1RYGdueKHjfM7b7/nJIHONTPpKGd7F8AaksdGEQ5W1fwdp089BFx 0PyBt05e9KZeLo6HDqanDrlL0Z1M9Y5CgjzrkAe0RtHBhE0oMVsfArkyq8oerUVjzziz p3yg== X-Forwarded-Encrypted: i=1; AHgh+RpuBrJCsKXQIxphsDqCIyXIyWVylXMx2I/w6xBg/VaEzawd/M9TF+DMCoCCOfTHoonEMC9+w3ouNyEcDeo=@vger.kernel.org X-Gm-Message-State: AOJu0YwDGZMyDkfmaVWqaIBv9jepR+wwQCAjCm6kfeh/iObfX9Oot3Ec GE1JUiDzOFMjzpjbmvXVa2k50NppUM19ZIEgvQWwplk1lSOHX2SQGgHBqunfYDiVhIBi/FX0e3y evzIVDefbviIhUO3EdUMpbKmCJ6fPjbeFsNyiCvfbORD+x0X3E5vrzrJJLiJDPHh4EK0= X-Gm-Gg: AfdE7cnC6BtTF1Kp4b/BcqK/0p4mRBffQXfk1aHvgTfBiWe9HvXCcxwGE/Jr+tVZCKQ hX1qXQC7Mjz03ZLT1IAaRW7vDg35rGrdbQGhcjrWfLP0bQ7m+NVx9bfKJIHZS6W2TjjZhvpcyhP hWPsH83n2rAL2rGF0oMtTCl4SnhannvRYls7klcOcDCBgMLIkyr2VV2edQajT/fcrgmqvddvSKJ +t1Ac4XiKZPHO0F/bpHo7iPmkBgGdGJimOROTOMcFCU7EpiSiowHC+XtJIU+LS49G9EuZbnJTyK lfHfIxKNDDDj9WoPn7e5nkLwDxcFt9RwbpMfca8Yo1adH7G1Nu30rwEH9EM+we07N87xIe34KYZ znuisn+Kc1xxN/+1e+ofaJUBMpR/nJqWo/qw48Kh8lrG9ZPtjiaBadCwS5VneFcEfKje5i0h6+Q == X-Received: by 2002:aa7:88c9:0:b0:848:60a2:4e9b with SMTP id d2e1a72fcca58-84860a25381mr4199182b3a.42.1783651200310; Thu, 09 Jul 2026 19:40:00 -0700 (PDT) X-Received: by 2002:aa7:88c9:0:b0:848:60a2:4e9b with SMTP id d2e1a72fcca58-84860a25381mr4199155b3a.42.1783651199850; Thu, 09 Jul 2026 19:39:59 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af6df87fsm4517611a12.5.2026.07.09.19.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:39:59 -0700 (PDT) From: Jie Gan Date: Fri, 10 Jul 2026 10:39:00 +0800 Subject: [PATCH v6 1/5] dt-bindings: arm: coresight-tnoc: Bind on platform bus instead of AMBA Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260710-fix-tracenoc-probe-issue-v6-1-41eb36fef8d9@oss.qualcomm.com> References: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> In-Reply-To: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Jie Gan , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783651186; l=1904; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=ltdgoUZ6tBDDcLfmDRkC7KQJz9iLegaPyl1qkMs19LI=; b=x6U8ATUjYt1nTIesdNn0TIKfMVJvoPUBd42Ap+ISOb1F/nvyCx0LKIGzdKwP1HDzxEC34he3i 1Fd0UF3+A89D2tnB7KwCVWId/Xb42XoWIJGeTXBLOngreWA7K3mLQJw X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfXyhTCr4HUQQWo 5NNywFwV37AXjULVUTJDyhFSmOHZ4sW1l3BPWRZ8xT+ZSSTFdR/kSHq9Ort7ymvocrnHU6s+8hZ XEB7mMXyvb+k3Jb12oIhocd+iSzKtRhPNNeuSaUQQtd97oIibZ+pAlMgkS4FDos7EhwBzlV36If bmrvCebew6YaUzkQVFEQrA2tze+SafpjAr1yimg6KxZYpvfgj4IVA51lJev+Z0LDajf4mdka+Gz 8rtEO9dWINMupgDcPYWi35eTkSBMDAOef8HNTTCN1B/fOpu3UQVWBlGvR407xwhR8Pm4v5VtkvO juLKANtZ2VNWph2uVgRbKVm/6fEbtusfgErjSGU9N/rk5r515LKzUXzR2Rdg2uAhox1UBmodKE5 y93U+LLEZ3ftYa2zzNGjoBSBvCHe1WW+Jkti6sL1x4iEb1YMKv0hOHW5OMa7OtAQAokska4ZWQt FR2pelODsffFR73zw+Q== X-Authority-Analysis: v=2.4 cv=ZcMt8MVA c=1 sm=1 tr=0 ts=6a505b81 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=vX9vLbfq_6l8qkBHxBYA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfX+tkjV8ENpl7j xXxxRapMgNdSKV79gddQwAG5GQ0PvZRisn1uCjSTDSutFjcebiMnM+V9xfJLY1RjEkdbhigAoxl N5tksJOhbWgsLK29tG4//pUrmYp0Lbo= X-Proofpoint-GUID: kY5FPE-Vo4il6hXtwrRSXjJdrNjQ4tR5 X-Proofpoint-ORIG-GUID: kY5FPE-Vo4il6hXtwrRSXjJdrNjQ4tR5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_04,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100023 The Aggregator TraceNoC hardware exposes CID registers, but the Component ID value returned by the hardware is 0x00000000 instead of a valid AMBA Component ID. As a result, the device cannot be identified on the AMBA bus. Describe the Aggregator TraceNoC with a dedicated single "qcom,coresight-tnoc" compatible instead of the two-string AMBA form "qcom,coresight-tnoc", "arm,primecell". This creates the device on the platform bus so it is bound by the platform driver through its compatible string rather than as an AMBA device. Signed-off-by: Jie Gan Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/arm/qcom,coresight-tnoc.yaml | 16 ++----------= ---- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml= b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml index ef648a15b806..72fb1210e22e 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml @@ -22,24 +22,12 @@ description: > =20 Note this binding is specifically intended for Aggregator TNOC instances. =20 -# Need a custom select here or 'arm,primecell' will match on lots of nodes -select: - properties: - compatible: - contains: - enum: - - qcom,coresight-tnoc - required: - - compatible - properties: $nodename: pattern: "^tn(@[0-9a-f]+)$" =20 compatible: - items: - - const: qcom,coresight-tnoc - - const: arm,primecell + const: qcom,coresight-tnoc =20 reg: maxItems: 1 @@ -83,7 +71,7 @@ additionalProperties: false examples: - | tn@109ab000 { - compatible =3D "qcom,coresight-tnoc", "arm,primecell"; + compatible =3D "qcom,coresight-tnoc"; reg =3D <0x109ab000 0x4200>; =20 clocks =3D <&aoss_qmp>; --=20 2.34.1 From nobody Sun Jul 26 01:50:06 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2B231F9AE for ; Fri, 10 Jul 2026 02:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651210; cv=none; b=UyHh24lmvCtow4DFN+y9bWIuNk0LSr244Nn49wzWfrf7AjSZko0adOv/RfqstG3p9GS/AaeY1ghz5vNsVeLJP1P9km2KxWTiOULP6pcKdNMcyWDLg/YxriQeTEzN2tsItCk6vwbWu4RENtVMd1L6CQ3r6cyw39hiE2PczsNgD/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651210; c=relaxed/simple; bh=/VrMOAI7RMTSpCjPO+MrxGESmI6mgxV1a4rVfM8UdWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZdUfeB1uyK9Op4gxjPL+H8b4xhY0p1Ki6sKk3SGqiOkPaRylykQ6QChkEc9V79cP9D/O0F7km0gGUW6nH9hJ9u9zWGpbpzl+lsKwwUw/iYyIe/pKsphumpoOy+SRt96I1VtYDk6PBIPDLWqSJKSHVafsA8Pjzx24FEHNlCsexUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kj6kZy5F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UMtrYiuC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kj6kZy5F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UMtrYiuC" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A2W58k2374378 for ; Fri, 10 Jul 2026 02:40:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M0XjIK3l1QlrdTu9yiIymA0sMB/2Qxsvll0XOYQf5Pw=; b=Kj6kZy5FuHVLnZ8t YufYnucsng3n+1HWl5vfM4wLn9WIVMJE3Vz8C96eULHsKBSio1DIHlM34OmEw8Kv gPTnrByXiYXcWRWAyKUsIBhTZxe0UcTlPBwTvSOto6wNQpZdN9PNyiz9zKmwrFTg xLLAKpFn5X2e/sJ2zDsFmIk/JDqC9wPz0pMdZVrTxhjDa/U3dag3SyoTSWvGlVgj 46BYg856Mfi5Y2r40ntyIVa3kOt7MkTmqy2MwK3nG6c6pxfe7ZwG+EC+hkJiJbqC t5QMfOlOABuGHCxoEfij5jXY6zh3PF5I0tTXTyKuR2IEqmGk7k0MXyL90c9AblFQ wL634g== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faeg5jc21-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 02:40:08 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8485d853b08so839078b3a.1 for ; Thu, 09 Jul 2026 19:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783651207; x=1784256007; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=M0XjIK3l1QlrdTu9yiIymA0sMB/2Qxsvll0XOYQf5Pw=; b=UMtrYiuCwSh9nhH669kn7zSwlBnnf7kHUoVIS7iYipSvy0IFNF8CkqaNM7mD53Mrha ZTeuHZ9i/9adxN2teLpJ783KP8T/IsYQqqIftOClroDOmTtEGftzRU1kacZYdhy7VC64 322Jdf/yi5OEq/1C4y53VcJtzQiee0EXmdnFQVzfOv8+jQF7v2SaUvnIVz4f12mXE1J9 pyL1cBXyoxUn32AoP1Quy1CTMp2kqPpJ0O/AYgm9Bko8CGpZRPLkrlydNi5k7+bFG/JG 9ymiVB1vPTgD+PW0KpyDBntZjRj1rxkdax2FnjIm8WAyLQA73zUqmNOavu1SkC2ffgeM oB8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783651207; x=1784256007; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M0XjIK3l1QlrdTu9yiIymA0sMB/2Qxsvll0XOYQf5Pw=; b=Hxi624K8jmocuX293NGwRp4oLgvBt1DwsiJyV3oLqkAffjV8RTsYaZIx1rhJIjhJC8 cJQVaaVRjXbAq9EELcUjUKMK+Z4Sw0ZoLF0qXGgFJrLaYO/4KxN4NfUl41eWkwdB3VVo /wYSRieWN/d1Hpd+jfDQElp/YH3OTTet591ZiJrxeO3Ecl2HTSwHROtBlImnPAwPJUja EMtDkQ7JJYuwtaMrADiyqEXFMjbXERqdF8kINMhCYT74VtfxCLDSaIiN8hg0vXSh2tUn 6ZysqQwsL5u/nbj2tXsYWblE7xlHlvfftSsG45+1MJBW0B7aPJ+cE/QjnrjD3BD2JJXq tGFw== X-Forwarded-Encrypted: i=1; AHgh+RqJjsxiPiDQbvN5ZLpiIu2p/5PQw0NHILJHz8d4QyPvLAxxpZ0hzTskYcW8hjmQc0mzGPBqLEJe7FXs6Ls=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+DxJjrH+TXnu8Llis2nQWOQfB9trLJeQ1hqXm67MBlT1aul7N bn+kccJ4Ei/XBPsnfKOv6oIsIH2thWbpS14GaVd+yxMRdI0Id6PhnF7jDQhw/oGHhFkRtIWeh2o agqiJmjuBiQrt0wIv9L6fUls8f2MOymAk6ZYvfpWdo0tdELuWnX0QUOyj3K+Z9Afy63Y= X-Gm-Gg: AfdE7clkCpxLI8ZPczS+l9bPCxiAvuw0FiUveNFlIRj14NHP+iaSxcy7Wy/YtqoaPF1 FbxdHaSjKo/GUMwnhzuclqMdvqgRzmkH+f6L0uZxvrfwLHXzVY+6SUqM/VWRliRJPdKJINQ+9X2 TTSOtXM5yR72KUv6TYbrZlNeaHHiGREuakzwyOw1Vn95h1I7/8yGr1dHNDqirKVycdQBS/vNcwn K3tyri8M+TvlvHwX7mR+AU4uHVcrxCrDJ/Z4apQ7V0dSRg9nNYBf30RjWluTDj6moOX1VTbTICS J74OhKNJx8T7eMMce8AVHH/kbdO4Uoo+aQTdTgrjA4sa1KlsMAHZerxnq4CQHJ2pOChBQQr9vJe Opm8eFf0irBpPv8opynitMLrVlTwKFYKKWK5qKivA+Ovn+ymcD5EJUoqHefJHUNn3Rgj8z0e7lg == X-Received: by 2002:a05:6a00:3e12:b0:848:411f:3969 with SMTP id d2e1a72fcca58-84842ee66f7mr8113037b3a.20.1783651207326; Thu, 09 Jul 2026 19:40:07 -0700 (PDT) X-Received: by 2002:a05:6a00:3e12:b0:848:411f:3969 with SMTP id d2e1a72fcca58-84842ee66f7mr8113004b3a.20.1783651206712; Thu, 09 Jul 2026 19:40:06 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af6df87fsm4517611a12.5.2026.07.09.19.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:40:06 -0700 (PDT) From: Jie Gan Date: Fri, 10 Jul 2026 10:39:01 +0800 Subject: [PATCH v6 2/5] coresight: tnoc: Bind Aggregator TNOC on the platform bus Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260710-fix-tracenoc-probe-issue-v6-2-41eb36fef8d9@oss.qualcomm.com> References: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> In-Reply-To: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Jie Gan , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783651186; l=5005; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=/VrMOAI7RMTSpCjPO+MrxGESmI6mgxV1a4rVfM8UdWg=; b=6y3FHfzbxUki4D5drjaSM3YVMMezRawMOVbPyF0uw93CA5mqU+VVMTAN9itU9nQTEeBfM3Ge9 JbnbH3GHH9QC5rzvF/iwh9LByMKOs5B8Boq5siOOZ85twB8UCsUaqE/ X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=FN8rAeos c=1 sm=1 tr=0 ts=6a505b88 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=SM-CJC9rQbeaPTssbJMA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfXx1BG62YNnIM8 k7qc2MHlTX0GgrkmMYUjQVIfShps8MPr4aOOOKuTXDXBr1/j7FZCZECI938HW/23EwKRH5lexW/ S3mE3hxJdfs2j2I0+5pDbeQY7DCLf3g= X-Proofpoint-ORIG-GUID: Z7BHn3Jee54B9NeO3uYE75RnlzEjh0na X-Proofpoint-GUID: Z7BHn3Jee54B9NeO3uYE75RnlzEjh0na X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfX3dgRViCM4rfA M8Gqs4E7YHcD0scJy2S6o/qBKwAiG/xw7/Vgzb8Lk2gdP3VpdH8A5xrY2mLajMeLEwhAAxNC/FA ZMMxie8XkhN6r0qsL5U3fW9IrobIhXONrMLwUpm1awYjkSMppZeekAognwSE0BDrcO/4umHKT87 gUMvM+tdSFmQHMsEZzZjJ54f6XXnFAsQOXQ9+gM7QkTYHF9rHeVuWMjUens0HqCa/3eGSIU0lIs jkaJTTjUJpTINIM91HUmWJ1sW9+KF91sWGy2UFwp0PoIfpi901Ga3rkjCVhg7uw7TyQDQrROGWo j7aa6hcVjnzhcq30GJxKDTPigaPBa44sQzYyGgOyjsam2Z9+Rg+gxHSI7nouIUdyta0oaWZQhaK NHQQE9vIcl/U6+go2TGg5iY5IKVzLWGZGTfqS3y9ye7ZrZ3i5F9GNUBx+T+XQBsOIkFLE4XI8/Q osHQV5zs4Ta5Ad8MhFA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_04,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100023 The Aggregator TNOC is bound as an AMBA device through the "qcom,coresight-tnoc", "arm,primecell" compatible. The AMBA bus reads the peripheral and component ID registers to identify and probe the device. Although the Aggregator TNOC exposes the CID registers, the Component ID value returned by the hardware is 0x00000000 instead of a valid AMBA Component ID, so the AMBA match fails and the device never comes up. Bind the Aggregator TNOC on the platform bus instead, where the device is matched by its compatible string and no component-ID probing is performed. Add "qcom,coresight-tnoc" to the platform driver's match table, and rename the platform driver and its callbacks from the "itnoc"-specific names to generic "tnoc" names, since the driver now serves both the Interconnect and Aggregator TNOC. Update the platform driver name to "coresight-tnoc" accordingly. The ATID-unsupported handling keyed off dev_is_amba(), which disabled ATID allocation for every platform-bus device. With the Aggregator TNOC now on the platform bus, that check would wrongly disable its ATID, even though the Aggregator TNOC owns the ATID that tags the whole aggregation path. The Interconnect TNOC aggregates trace within its subsystem but carries no ATID of its own, because the downstream Aggregator TNOC already owns the ATID for the path. So base the check on the "qcom,coresight-itnoc" compatible and let every other form allocate a trace ID. Signed-off-by: Jie Gan Reviewed-by: Leo Yan --- drivers/hwtracing/coresight/coresight-tnoc.c | 37 +++++++++++++++---------= ---- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtraci= ng/coresight/coresight-tnoc.c index 9e8de4323d28..737cc802aefe 100644 --- a/drivers/hwtracing/coresight/coresight-tnoc.c +++ b/drivers/hwtracing/coresight/coresight-tnoc.c @@ -130,7 +130,7 @@ static int trace_noc_init_default_data(struct trace_noc= _drvdata *drvdata) { int atid; =20 - if (!dev_is_amba(drvdata->dev)) { + if (of_device_is_compatible(drvdata->dev->of_node, "qcom,coresight-itnoc"= )) { drvdata->atid =3D -EOPNOTSUPP; return 0; } @@ -278,7 +278,7 @@ static struct amba_driver trace_noc_driver =3D { .id_table =3D trace_noc_ids, }; =20 -static int itnoc_probe(struct platform_device *pdev) +static int tnoc_platform_probe(struct platform_device *pdev) { struct resource *res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); int ret; @@ -295,16 +295,18 @@ static int itnoc_probe(struct platform_device *pdev) return ret; } =20 -static void itnoc_remove(struct platform_device *pdev) +static void tnoc_platform_remove(struct platform_device *pdev) { struct trace_noc_drvdata *drvdata =3D platform_get_drvdata(pdev); =20 coresight_unregister(drvdata->csdev); pm_runtime_disable(&pdev->dev); + if (drvdata->atid > 0) + coresight_trace_id_put_system_id(drvdata->atid); } =20 #ifdef CONFIG_PM -static int itnoc_runtime_suspend(struct device *dev) +static int tnoc_runtime_suspend(struct device *dev) { struct trace_noc_drvdata *drvdata =3D dev_get_drvdata(dev); =20 @@ -313,7 +315,7 @@ static int itnoc_runtime_suspend(struct device *dev) return 0; } =20 -static int itnoc_runtime_resume(struct device *dev) +static int tnoc_runtime_resume(struct device *dev) { struct trace_noc_drvdata *drvdata =3D dev_get_drvdata(dev); =20 @@ -321,35 +323,36 @@ static int itnoc_runtime_resume(struct device *dev) } #endif =20 -static const struct dev_pm_ops itnoc_dev_pm_ops =3D { - SET_RUNTIME_PM_OPS(itnoc_runtime_suspend, itnoc_runtime_resume, NULL) +static const struct dev_pm_ops tnoc_dev_pm_ops =3D { + SET_RUNTIME_PM_OPS(tnoc_runtime_suspend, tnoc_runtime_resume, NULL) }; =20 -static const struct of_device_id itnoc_of_match[] =3D { +static const struct of_device_id tnoc_of_match[] =3D { { .compatible =3D "qcom,coresight-itnoc" }, + { .compatible =3D "qcom,coresight-tnoc" }, {} }; -MODULE_DEVICE_TABLE(of, itnoc_of_match); +MODULE_DEVICE_TABLE(of, tnoc_of_match); =20 -static struct platform_driver itnoc_driver =3D { - .probe =3D itnoc_probe, - .remove =3D itnoc_remove, +static struct platform_driver tnoc_platform_driver =3D { + .probe =3D tnoc_platform_probe, + .remove =3D tnoc_platform_remove, .driver =3D { - .name =3D "coresight-itnoc", - .of_match_table =3D itnoc_of_match, + .name =3D "coresight-tnoc", + .of_match_table =3D tnoc_of_match, .suppress_bind_attrs =3D true, - .pm =3D &itnoc_dev_pm_ops, + .pm =3D &tnoc_dev_pm_ops, }, }; =20 static int __init tnoc_init(void) { - return coresight_init_driver("tnoc", &trace_noc_driver, &itnoc_driver); + return coresight_init_driver("tnoc", &trace_noc_driver, &tnoc_platform_dr= iver); } =20 static void __exit tnoc_exit(void) { - coresight_remove_driver(&trace_noc_driver, &itnoc_driver); + coresight_remove_driver(&trace_noc_driver, &tnoc_platform_driver); } module_init(tnoc_init); module_exit(tnoc_exit); --=20 2.34.1 From nobody Sun Jul 26 01:50:06 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CC33319852 for ; Fri, 10 Jul 2026 02:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651217; cv=none; b=DkU5Y6gIOMujqHsL2+M+telPSr1eVTif7+RpghWtsR/7IzuEZ5+Yo29/HFkLTLsEEvBwncMuqHGKs3FugVjHh+icDWdXmXwNA6r1Lx1BYBbyprCsRHJLWHl7w9CNZfQGGeMBwpXhhtxxI+Vrt8GrcDWZOYWrelvAJM+Zb4hfxcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651217; c=relaxed/simple; bh=4MVQmgwxUQUw39D/a4v3zOkEzV18aEDsQ8FTgHlTgXk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nFmzQQV2Z6PyGRyzMEBDLmNCzYY2fbCLaGaUEUB9pFyLRaW4uWhTvj/VSkkfNHAwT9bIDzsqtH8Gm2ij5bTG/b706MCyOWbEG/Gty6+tzfdyYsrmk1BNhhep29NQom4qzyvrTx4Gj/ggtcuIsNduufy5+LWKnya2HhWqSv8vTtc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OdkRUdt5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iH5FLYpK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OdkRUdt5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iH5FLYpK" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669HWqQK2563407 for ; Fri, 10 Jul 2026 02:40:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8mNKTHss5RCMjCMw1FqMWARAA+Av+jdGhXhUgfnnAQ8=; b=OdkRUdt5AGZY24Ac D4wv9Hd+nCoQCg0YwCcAWBYSpCx9Ce3ulqn9brMuqYEE6EUh+CarLNIE73FUEEbb /B8U6Zuk5IryQaDigiKSULvrHc63C9oB6RSAevvp8RySHR/IIEgCyT9WVbTZqqu8 LMEOGoCeYQwi/g//w8LwhdKYt2g1AVvdVy8TJ84sMS7r1/nv0+t2GEmMIrQlXLss bIeVw4FIUvFpHB2FY65TX81Hs6AI0dfUjC2LsbltpQDSmI24LSAJmd92/xLyXGpa wFqppkAgqcSMGCTksXm+CUhfSIqnUVz0+CuYwerHVlJGoD2jp805i39/8KJxtMWV 5Mfg/Q== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faeg3jce4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 02:40:14 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-847ac21582cso501393b3a.2 for ; Thu, 09 Jul 2026 19:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783651214; x=1784256014; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8mNKTHss5RCMjCMw1FqMWARAA+Av+jdGhXhUgfnnAQ8=; b=iH5FLYpKvxX8O9PJfRXIOWSOahdIH9pKNP5cQL/+auAjg5udt37q23nFWqRAFC49j2 SBx1MSrwcJ6Aicgs957Wh8ldtzKf8wK8Yna7WhKI0Ha5WhM3FpjwV5FnO3elFnETTgBL aoZxFaHJSh4xTZXhggB9H71gC8dLrKaglQUNS/E5wXBEQVUEOR6I39dKw3ptoNu/xNk/ 1Rh1f50jur274GS0gIR484nuJR4y9coictySVRXK7+PWuHwlfo3v9MXXfz7nL2uvmXWW GLuhMS+LOJ/my3A96NkaiUdG1B95OS4In/lPf1DE255DAIrEgAgIBcBP7AxvE8lmeLNr 1MyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783651214; x=1784256014; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8mNKTHss5RCMjCMw1FqMWARAA+Av+jdGhXhUgfnnAQ8=; b=DWqqb5DuPH2f001+j1qVlYlALvXCwfsIalpPx6etCCnsMyM9JdGxf4xoj69xTNGXpk EWcaMULoOldMj2UPS0e0E8VBMbNhQZas2s+AxHOqXlhQrjcNh3y33bqrRKcanpSQcuH+ B8yvFreGhJQHLcDZr9cJrn8RLTjSgjh6lPL4ULVfbxxotHpB/fp5u4NLMb77zzWTj1B0 nyIsxb8iK9zu43oZqgjpfB0oMRBPhGb24Xdk2MdLUApKLlcqqBzbhfyd6Btb9gdW6Cat /EtDXPN19433qAVSilpZomV4OmwSZtuWz5pVn0nXGCLgTKNy5Buvir3qTe1AzfPsAMEr QQDw== X-Forwarded-Encrypted: i=1; AHgh+RoNoLS/AZRs7RXZelywf/4N3gB2bowVMx7sGOehVgu33bAxjclkld8ISVY1u0wbhB4M3dw5FmmnRqnTMzU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLUNfCzT7uEm1essiFqnEqnjtwZJA9yrENROsRmPyr5+XhzJ9l 38W3mhgvu9oallGlp4RLR4PZGBjd1B/26yZT3df6rR6eMALvFlsfdb3O0JjGdEKJ023zZhOdzbT 0C2jN+0x9tlp/UVGT+PwbXcWG1TNdwPKNkOfom9vMwUcLO/gtScglLZW31RGoiou8ftc= X-Gm-Gg: AfdE7clRuw6NkigHhN5hjPyD2E6IOENGMxrDXMXQY+ziFasmNsq0YOMLB5jvtZCZsyG +sM60Hx7C2MEvJ2HSuNmHZoO7yJGf0kMPl06+ERfhr3zspSUr7hG5+XTcmGXbPl6a12QzOuJqpF v0mA1pyrjYUZ07tLo/X4P2QLE6Tq254PfY7yKgmLSs/didrPRW09lavfniKVLlY6VajGU8EDG9/ wPY1rm2tZFow1/Ixyk0y3kFCXrNf+Qnik8zlcm8vGYODhDnKKb3smP/25VjZLBQayrwpjtYWFEN rAXoFjhmOK2ZgD68nxiPyed/xX6sFFSZzCnFcs20edaUMvsLORcL6MgUn/aVkF3udY8nwT+zr7Z 9Q+2cl6/DygesRETrhyAM0JPiC8Jdnd7HIR38J1bP7DL6OGIq5DP//pH6Eo1NQ4L9drXL4M4NRA == X-Received: by 2002:a05:6a00:b90:b0:847:439b:ae30 with SMTP id d2e1a72fcca58-84842edd72amr9032045b3a.20.1783651213885; Thu, 09 Jul 2026 19:40:13 -0700 (PDT) X-Received: by 2002:a05:6a00:b90:b0:847:439b:ae30 with SMTP id d2e1a72fcca58-84842edd72amr9032022b3a.20.1783651213435; Thu, 09 Jul 2026 19:40:13 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af6df87fsm4517611a12.5.2026.07.09.19.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:40:12 -0700 (PDT) From: Jie Gan Date: Fri, 10 Jul 2026 10:39:02 +0800 Subject: [PATCH v6 3/5] arm64: dts: qcom: kaanapali: bind traceNoC on the platform bus Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260710-fix-tracenoc-probe-issue-v6-3-41eb36fef8d9@oss.qualcomm.com> References: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> In-Reply-To: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Jie Gan , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783651186; l=1634; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=4MVQmgwxUQUw39D/a4v3zOkEzV18aEDsQ8FTgHlTgXk=; b=9id1mYjoy80wRtGxcFyPA7kI5SvnAWvY6ixcWCAoVlNUvjuYNtKp78orzdxBYjBm3CXiuwuyC YYkFpe+JU/eBbIMC4Qiu2TzEhjOIALL95aS8NE6B/Vnki47ITGNGYJF X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfXy0pL1vxQ5al4 teRkr/unmmUia0MPTy9umYSsfHiOwApX8R9al9i84xu2/gWkGWlxmkTdX/zkDn+cJpclhuDF6mv M3seBjOmo77VBV0do32xkayqymTuG0UKOeqmfGl753DXJZ52D6Mcrn/VdXIBT4ljKyyDFnw3Esq CJSHwlkTNg55JuT4ar5ltIa+N1vEAFpYgVy6MOgxTjewg4HH/i38GH7D7zALFL1shZpLrsKArmd Dy4p9JMxrE8AMXb8UrFg2txAC2HPPj6qGFlC2cLZYwEyUOgTn/fgWPyZ0CC6kXUeOow+BU0jRvG AStydi0ZOI9YpcVl/lTyQhxHPWImHLAXvRZFc0CsZgTNfhdfHEqhZmxJ2PQ+DOTHrjUM+y5et6m LiouT6mwhyfez0dYeM3V8J+2TW1Pna1gCrieve9gB8bzDU/WLJR6/2LCNRk8IY8lIaBIyzyFNcQ ekvqg9d8j8jrUeN3/eg== X-Authority-Analysis: v=2.4 cv=ZcMt8MVA c=1 sm=1 tr=0 ts=6a505b8e cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=7Rut49xxg77_icr6qwgA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfX2A0D0J91AZ5T 50S4wG7ve/wKGhoGX/cxPiBGysGw3KcU5AUw/RRtnDQXSk3f1N6y2JRZygUHWtc+uBBmkFwCc8R jNWub5A/M45ss96DXR8HpzV7MB1jyqE= X-Proofpoint-GUID: sLgarM2jfN5hkhjAiHQlyPJfwWS8TOUK X-Proofpoint-ORIG-GUID: sLgarM2jfN5hkhjAiHQlyPJfwWS8TOUK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_04,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100023 The traceNoC node used the "qcom,coresight-tnoc", "arm,primecell" compatible, which places the device on the AMBA bus. To bind an AMBA device, the bus reads the peripheral and component ID registers (PID/CID) at the top of the device's register block and matches them against the primecell ID. The traceNoC exposes the CID registers, but the Component ID value returned by the hardware is 0x00000000 instead of a valid AMBA Component ID, so the match never succeeds, the AMBA probe fails, and the device is left stuck in deferred probe indefinitely. Drop the "arm,primecell" entry and use the standalone "qcom,coresight-tnoc" compatible, which binds via the platform driver by compatible string and does not rely on the component ID register at all. This lets the device probe on hardware that does not return a valid CID, while remaining an Aggregator TNOC that retains ATID functionality. Fixes: f73959d86c15 ("arm64: dts: qcom: kaanapali: add coresight nodes") Signed-off-by: Jie Gan Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/= qcom/kaanapali.dtsi index 7aa9653bd456..5d0e7e8c2e58 100644 --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi @@ -5004,7 +5004,7 @@ tpdm_pcie_rscc_out: endpoint { }; =20 tn@111b8000 { - compatible =3D "qcom,coresight-tnoc", "arm,primecell"; + compatible =3D "qcom,coresight-tnoc"; reg =3D <0x0 0x111b8000 0x0 0x4200>; =20 clocks =3D <&aoss_qmp>; --=20 2.34.1 From nobody Sun Jul 26 01:50:06 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0F131F9B1 for ; Fri, 10 Jul 2026 02:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651224; cv=none; b=NC9F4HFs9hoBTJf4Gu9nMY1d7QtpHKFMtri2KLtVjUA82RDxxgNHRgcuTZJmosdEZRkvgedlfWRlny09IajCjCg/PtTDCSMXFuPxSAWPKSxMtj0s7H8NXJsnZ9elKR3qnNOT11qdsOrjQ9jBTHccwce/cOMJ40he0Z3D1wLNWw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651224; c=relaxed/simple; bh=kUxtfu2GkKubtJdHqbDaFenuC/gQXoog7GcvX2P9CYg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NGaWXMkEz/H/Aq0HYkzj/NhdHIfHLmGaIaBN+rdsL0rPcHxbsE9raKcISU8ySSnwC9NpwSFI2nCYI+QTW95RM63Gh0Dlv+LFqCeom0tm3WBDjjaXlPWLtU+2ut5+bE1evXoT6bYZHOyH1byEtQBHCMo7gNzYblMxfsfJHCac+2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QCAslgIY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iJJLjA8J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QCAslgIY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iJJLjA8J" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669HYeeP2476012 for ; Fri, 10 Jul 2026 02:40:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mY27m7v3cEAaQpyiABwCbYqFFK/jPd97b0pHI8E07Gw=; b=QCAslgIYZyTntJHk MLk8ssPfTuu9MUEiM2pcq5i6a+5rJvYOVB5TJPcRChhLm3pDWMe9u4gOe8G0RsR4 jgzeNpKET7Bri1b3fTb6IC/1Stdwr0lAzmAc2YvKpjkCsp/8ymF2viQHp1WKZDSd rvVfbTGNqRB4kcoaS+wEfA6sRK2lVqwQ8IPCtFX1o1Li6GX1Czy/w6mj9xut01u8 zHEPKW9eQr9T4ZnhRBaygCENQG7I4lujyONwxeSWes53py73tVarEFJ0gaeMA7/Z IzjvlK8AxvaYm9s8+n1VrZ15R/WygIx9DsOCRWQxt10mnc5wI+X3Je3z2vXbI4dA TiXxlg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4facqpjwk2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 02:40:21 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ccb6823efcso4022615ad.0 for ; Thu, 09 Jul 2026 19:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783651220; x=1784256020; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mY27m7v3cEAaQpyiABwCbYqFFK/jPd97b0pHI8E07Gw=; b=iJJLjA8J5KDaf1DJ/duVpVwBEGfg0mqirKz+RggVa8Q0SANIK8nJ+pKZcM5KpSSa8O BmH4eEjUW96z2M1R3hZVAGUKtpjufnvswOz0qTQQmyR7zEUzamFTZbgajsdDGWm+76Tu 1jGP5B4UJB87c2WvUcis/PUCA94yKzFg7GFpReEKsPV+6GnV8lmrhpk0oARgfVUPTykQ MZ9yNLLqZ4pkzTf25H7eyqusdhhTzmMuhR59iVuDw2CF/UKaIOfYaMmZgu1Cwpl+vKiA nsXgyklq00OVeRJCRpHazD6HplKNOMxyCiLROzKvctTaW62RsG/oQr4gOjsB3zP0msB0 gD9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783651220; x=1784256020; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mY27m7v3cEAaQpyiABwCbYqFFK/jPd97b0pHI8E07Gw=; b=MyntHKxu/j90jt0SW6A7a9gLdK5DCmcPLJM7BYqJXngC0fEGp66fpodHDEz4wvbK1T 37gkG3v48rKhJ72sOmiTh8643MMEcZytMsX7oWk+MfPjXodSVjUkV+w3+3tFLxzmDSWb 7gaGcynfwi75x7H17JbHbqnZYJir2k6i8QIXt1PHKA2bFggdJ7txWWk0kInFA6u9cfpK Ds80OLs/Rwy6l2FXzKXzGC098xulbYXqEH6i/Xj7svXhXCfAaFi3Oz8JVXt1Fid4S0Re Ywnvcmb3Shi8jPXDbICrMNrtCKYdhMiQZaKYuqD88u4Yo0LqYH+xaCcBhJUYsJz3wNEh 6qDQ== X-Forwarded-Encrypted: i=1; AHgh+RrXeOktucmVCtUwgvXgYwr8OqXyRSxbon3Cd6L7wlkG7/DlnrTK6TaVZU8/rRlrc09MWpOYY6bNxrzo9aI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1e2bWIspMjC0Rqzv6xmciVlotIxHfrivBZOmKzLomXFnBIk4F yoxT/0APHDcv2OsLyTG3PEqZoz7UOLPINjzyo7g/Jl69ZgD/1Fl3IflU7PXDY8ziTbKPIRJwhtv 4+lcRFNj0U1WA0pVZvw98E3SrmSBBnvaMgHL000SZl4xO21zY+55dBG6Y1fKbWnKEDos= X-Gm-Gg: AfdE7cnif1VKEoZOuUKCatrpSpq4RnDx06EowTLy+TeiP/NomEg9sRQHE2jVbxIwtX4 ockipxzmpxnbp0qYJrwHrzn3b+5C+jpw94dd7Tb0zFkpmgwOFi4MTX1a7z57lIt2Wlm7gCPJ7px 4bH+ANjzIz1I3VtfHBsh3wbyn/ZhGgSi5rFaPQjIIbma4Oz4c5Dvhti/X54tw54DKf1vQqgIkOX kb0hzmGllg8yDQ3DmGJZrOLYHpfNx+m2KonusRpefCCTPjWywPnUYaWOAf72Ke7vTch3VSsPPoX LWI4UJLcTOOJe4Ly5yAk1IdwkaX2kbKGC+OBniC//YwMsgH59hCOFhQ5PkV+/P5hqTU2LT06SwN 2DkT6Ez6Mozb15QH1fxxdU3KXd9ZS8hGPpLWs7lxFLno/tZHh7YS2Jt6/hquraNqg9B2FhH8r9w == X-Received: by 2002:a05:6a21:4c13:b0:3bf:5539:f8f with SMTP id adf61e73a8af0-3c0bd0fa84emr11841147637.37.1783651220450; Thu, 09 Jul 2026 19:40:20 -0700 (PDT) X-Received: by 2002:a05:6a21:4c13:b0:3bf:5539:f8f with SMTP id adf61e73a8af0-3c0bd0fa84emr11841093637.37.1783651219984; Thu, 09 Jul 2026 19:40:19 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af6df87fsm4517611a12.5.2026.07.09.19.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:40:19 -0700 (PDT) From: Jie Gan Date: Fri, 10 Jul 2026 10:39:03 +0800 Subject: [PATCH v6 4/5] arm64: dts: qcom: sm8750: bind traceNoC on the platform bus Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260710-fix-tracenoc-probe-issue-v6-4-41eb36fef8d9@oss.qualcomm.com> References: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> In-Reply-To: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Jie Gan , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783651186; l=1616; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=kUxtfu2GkKubtJdHqbDaFenuC/gQXoog7GcvX2P9CYg=; b=hlg9blVs46R5OiJ16+aISTtFikhio7y1TA4JxSn81vWK6bQvO1MyWoU4RGnN5Kjasstk+58Id xNgxcCOpTOqDrJ6K8vWSPiIWE7O0Etl3i34zOsebsMTQ7McjP4QlPxA X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfX0u2gLU1f77C3 eCWi8GmHFxfEPI27MYKvq5q94VQ5mR4epQgV2g3JA2ekaDTnEfa0zmBqtvEyh7eH3rSvFTVhxnx OzlaKbDmTG4vPWxdurjf92VXCtJ/VOWRWu+SP/TBkSclZ6Z4MzbFumw7JaLGGbQguZOyfCDv74A QSRRXdbOkfWK5J8vjWmWo02NfUt8cbJTikaFf6h/NL5yQS7KTCKpS1+bkSXP/cJFHDweRcNHFyO Fc25g3rggSs+UbrnSNrxn+VHZWrAXtAEsTxTltDUjdS4FJnTREzBMrn/m6YPTDzXW6ZDT78cOfR w2KdgQcv117iyvF3Ez8f9F1HmDtz+Pae/tC5eAX6k5JUsTAFV3TkOtRJZ5R83zteKuFVOCI9JQj 7wmeB61OrrK8pwjKu8mEfYYi7PHrPRXe3wCEe6x9cCEMBr0D+JOl9W5ZlcdKLjFYXTvAnP7MTfI agd8me5jW9y8FTGkJDw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfX5KfdUQy/PR9Q zC2nC0ct4eaH+XkxrSlu3X3kfTFfGG2DNso+PUXMSurz4uaHD2KPlp8z51jM1yU//tTITINh3Ew qEmVlaMnK0WTrPU8G0fYvx2BjQtSqWQ= X-Proofpoint-GUID: FmaHt3ICZ0RmjL3cHwLGnkbAJS2en6z- X-Proofpoint-ORIG-GUID: FmaHt3ICZ0RmjL3cHwLGnkbAJS2en6z- X-Authority-Analysis: v=2.4 cv=GJ441ONK c=1 sm=1 tr=0 ts=6a505b95 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=i4VRK_AS-aeX222KLmsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_04,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100023 The traceNoC node used the "qcom,coresight-tnoc", "arm,primecell" compatible, which places the device on the AMBA bus. To bind an AMBA device, the bus reads the peripheral and component ID registers (PID/CID) at the top of the device's register block and matches them against the primecell ID. The traceNoC exposes the CID registers, but the Component ID value returned by the hardware is 0x00000000 instead of a valid AMBA Component ID, so the match never succeeds, the AMBA probe fails, and the device is left stuck in deferred probe indefinitely. Drop the "arm,primecell" entry and use the standalone "qcom,coresight-tnoc" compatible, which binds via the platform driver by compatible string and does not rely on the component ID register at all. This lets the device probe on hardware that does not return a valid CID, while remaining an Aggregator TNOC that retains ATID functionality. Fixes: ebd1eb365cae ("arm64: qcom: dts: sm8750: add coresight nodes") Signed-off-by: Jie Gan Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qco= m/sm8750.dtsi index fafed417c66f..1e25be41aef5 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -4687,7 +4687,7 @@ tpdm_rdpm_cmb2_out: endpoint { }; =20 tn@109ab000 { - compatible =3D "qcom,coresight-tnoc", "arm,primecell"; + compatible =3D "qcom,coresight-tnoc"; reg =3D <0x0 0x109ab000 0x0 0x4200>; =20 clocks =3D <&aoss_qmp>; --=20 2.34.1 From nobody Sun Jul 26 01:50:06 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6102D5C7A for ; Fri, 10 Jul 2026 02:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651229; cv=none; b=g78IWmtV6W5yUFPgrSzBOjoXK9VcVhaqS7JrdKzi8K5/+D3Tkbq7SYgrUerZoBZkG7qz8eYPfJWwYShTqH2BiCJRpuMYQCp1N/StlH02O1Kx3LKyXnLU2SKpl6bq4/tIFPtsgKv2EVZhZ++oJowc+9cyo5WTp8tUVwHPkvVfPVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783651229; c=relaxed/simple; bh=6SxIbCzVB43Q5gQOLOs5yrmATRLuGa4fNKmIn7mrhsg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZnapvC4QQW4F7I5atdPuwjuMIM4D6q/g6oSzVbt8VMfapBjw3d+w9UXqk7MfDgk9GGgjemVjZw//qCIZUTOp/WjTULI2DZ5W+dX8k/apsWB2YG1v7s1fBNP2k0JsEcoZnLuKsI2HpB6+mNBKke5bxyL0lCXJkqHsmjZo4KW3kOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kzGFM3fh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JXZZ8zkx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kzGFM3fh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JXZZ8zkx" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669HXHSI2375963 for ; Fri, 10 Jul 2026 02:40:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fmLmkU1YQaMHOUF56Fxlmr/AeBRPhfqt1YSrM4LteKE=; b=kzGFM3fhaAn6jTjX 53uhY/ZgHBfQh6PzZV2cU/6cRJV/qV0eow2t+6nK325ahKFczpnL+7NgJLyWRD7j 76/EgfB/+ZeR7TPfFy9SgPE9JdcTqaafLAO0qlY2ekQ7xLwU2YX5HByCQlvOdvd1 8zVPImqgJ1jb9z8Iw/pu3pENbNhMwQyXi+c6JHc8vaI3jLaRQKosK3S4Pjii0fWZ xNkpQueE3f5czDJMYPyROHy0mwYNJj5KmEWl0lV9i3TUhXDMyg7CLvsIGPWs4BnV 1CgmquQBY6DyhYTJfF/xy8/FJzWbVK1SCXe+jlJhTAcm7nV4waKMqGeQWSCec+Kz 4SXFBg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faeg5jc3p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 02:40:27 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8486c3411c8so588412b3a.2 for ; Thu, 09 Jul 2026 19:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783651227; x=1784256027; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fmLmkU1YQaMHOUF56Fxlmr/AeBRPhfqt1YSrM4LteKE=; b=JXZZ8zkx5YXX3yiGY3C98pLMjJRlYnDKQNY70dYn8TCUPmAHVYWMpm6Vfl2mZ5CoWD oTGLEQUaBLZCPBHGgTcl6xMsvxY7H/UVmreC387W/m8cUItHoD91s9wDyrgFdhykGn3B f1llsNY9EluVD5oBgXEsJfqXfyuJiwtiRBsMCKTByZN/2fOlRX/WIGl4zNbHU0xZkKxf 8C4+9Fro/r/Z4JAElopH6RqI51t8USRD0uuJqMMKlDqCKFpCEt0uU+KP2JHCbQcbuwsX 67AY2VSeT9mzw5FUdcbLy1uJh5ZJQtIcKMgLfZaMU7H77GVSxlc2o0RNUUA7hXE15mlG d99g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783651227; x=1784256027; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fmLmkU1YQaMHOUF56Fxlmr/AeBRPhfqt1YSrM4LteKE=; b=NEU3SPT2j7e2wRENl7bBOjZXdI8wdVBcEapG9KuKAopMXum1mYqrx6hikwCxw6Nmnl UKTUVm8QnOjjf6FsmzhbP6Yb5/1lq5yVFI2bl731g8cGoo9Fo/sopH6NFmWj7MA8Fd/L PQwC3Has2X4bW8k8Ipb+mwZ3QSEjfDGq6JgRqdSBPO0ThcjbGGhsfWzFbomOo+u7xEFt CR88vDBVH7lJwwWkuRHl1iugpZK3LvE8fc1K8CPOjIgxOob0fT6+StAM1PnDvqU4YF4l 3e09Q8XkABrawWpNDgosbS4YhPR1d3F6Ub4XqCaGV08dIihirYwDXNK7Kqf+JNSmId19 yKwQ== X-Forwarded-Encrypted: i=1; AHgh+RoDbbcvocorj/IAyLFmofg9FAlZvCRKTfWPCIWP0GeMJg/ULJnCKzyW7zOGAnTVdGPm78kBhnSF7cIDZZE=@vger.kernel.org X-Gm-Message-State: AOJu0YycOSu9EdZKVpB3YCl27vEvazNQFcV1d7abVqE9fqADDCff3r70 jeGIpR2ZC3wXFER2h0tQ9Rtf7Cok4H1CKIxDIfmhS9l1Vzu1d23LwAyISMCYJYhZYUEIkUEVPKI HHyFULhDbtj0fF2u3cmhcYEhHMaBrM6TGji1BTZZEpU6D5KjG8cJUUTsS3PzomKxAD9Q= X-Gm-Gg: AfdE7cnEJP0EXiorPX3C4NAlUGBoAWQRC7Lgw3NXQnxIUyiV0SuXtnF5rnSaCeTVT+T +VtosAFDnyU4SdIP5YQiUOCl8Onyr6etA6004jwLYH1eR53qrEDSsIhD/z4DPZdINEf5BrdAZc7 pjiG041di2uQgrtLMJ3Mvhl6PM7qC0v8h9AeIkgtMFd8Fj5k+opH+LPY69TXcU6Vota6uj/gwlx RdG1IhnlOkLYoaAyVMHEd56PlSM1xCEfPYCi4+jToecWrEK6ma5CsZTnxP333HziosPLNvC947A CkA+PVkB6PurvhXKndh0eo6R26zbIwI86BIroUMPDgYXL1cS/KHbRxNj8zemc+MBTvVSHyjikPe q9qURmjU7KwvZdhfxiIQgMAQHRUSs/tqD9yXMPYP4pgawWBgFDRBjzrhPnhwVQxWOjZoJC+fI5g == X-Received: by 2002:a05:6a00:8c8:b0:82f:72e6:ed4 with SMTP id d2e1a72fcca58-84842e8f2b6mr8945874b3a.0.1783651227048; Thu, 09 Jul 2026 19:40:27 -0700 (PDT) X-Received: by 2002:a05:6a00:8c8:b0:82f:72e6:ed4 with SMTP id d2e1a72fcca58-84842e8f2b6mr8945831b3a.0.1783651226566; Thu, 09 Jul 2026 19:40:26 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af6df87fsm4517611a12.5.2026.07.09.19.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:40:26 -0700 (PDT) From: Jie Gan Date: Fri, 10 Jul 2026 10:39:04 +0800 Subject: [PATCH v6 5/5] arm64: dts: qcom: glymur: use Aggregator TNOC compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260710-fix-tracenoc-probe-issue-v6-5-41eb36fef8d9@oss.qualcomm.com> References: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> In-Reply-To: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Jie Gan , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783651186; l=1699; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=6SxIbCzVB43Q5gQOLOs5yrmATRLuGa4fNKmIn7mrhsg=; b=dbHuilsW4KxM+/xj3xUsen5J+9wy2lfD6bFh1ZEENRS60E3sUsXMnDUWzpcow2ZRroA77ut4o rtUALoX0HXrCQjChr6r9g53qvCpL4ZowiOj+mgLseTGDwJJ9VRM3f2S X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=FN8rAeos c=1 sm=1 tr=0 ts=6a505b9b cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=VopqNUcg1dr8wGNk0jsA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfX/d3L3LoJicQN QrULNaqQFfmaB+6j5ym7M+gw5Wf1F/tTDYI2elrJiMJxKys1hCAtOISh2iPqd8qHF84OyUqyHRw Q2QjQk7P8Ua+Xj+kkjPvSrx/F7iSSAg= X-Proofpoint-ORIG-GUID: 56BK8gtKmIX4QOeNxxfwDaAaOYHplMif X-Proofpoint-GUID: 56BK8gtKmIX4QOeNxxfwDaAaOYHplMif X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDAyMyBTYWx0ZWRfXxZrWG+2D/h2g PlLKGOtE3WJqnMH60icI8nnNEZgY7lBmAi8QE6cBbhBBMOupGx4lspM2QBBgn55reDw70Y1xMPE +23O7C+sR5nmtCZKuG6daSeTZuBdtWou5SV/ZVAMixKkQnol19wXmzOuCNxPwQ4juT182CfUIFF 6KxQxXJO6O0DizHvAWMfChiPhpDmdsN5idp4t0lWq/blNC+rvo1P88NGJ5r0wjOwKDIgw9mUrT+ aHNjGRygh7bMtdvDD6Ri1GVRvfpnS/h5j51n1dhpZsrbkDhIhP4Q/7TEce6bw1FW2r06VR5igiL tYNZK8UvXPFjzaUs8DRx4bSFi4EZVR5IgEx3Dsg3Wq8ym1/bdyvm7rOt7ougzYOGnJ3z8ZhXweV rRqnAZk4ulrK5qTjgRFVggB8uLhHpHnBvCQdUfB3+H0dB26faZBr9+a1nKFpkF5+NotMga3s4sC 1Hiy9V5QLDlrmkcF9oQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_04,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100023 The traceNoC node is the system-level Aggregator TNOC, so it must own a valid ATID that tags the whole aggregation path. It was marked compatible with "qcom,coresight-itnoc", an Interconnect TNOC, which is never assigned an ATID. As a result the aggregator had no trace ID and could not tag the merged trace. An Interconnect TNOC is a subsystem-level aggregator: it merges trace from the ATB sources within its subsystem (TPDMs and other ATB masters) and forwards the combined stream to the system-level Aggregator TNOC. It carries no ATID of its own, because the Aggregator TNOC downstream in the path already owns the ATID. Switch the node to "qcom,coresight-tnoc" so it is described as the Aggregator TNOC it is and is assigned a system trace ID. Rename the node to "tn" and use the "apb_pclk" clock name as required by the Aggregator TNOC binding. Fixes: 1f7d0c42a08d ("arm64: dts: qcom: glymur: add coresight nodes") Signed-off-by: Jie Gan Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/glymur.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qco= m/glymur.dtsi index 20b49af7298e..0c04dca5e557 100644 --- a/arch/arm64/boot/dts/qcom/glymur.dtsi +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi @@ -6038,12 +6038,12 @@ qm_tpdm_out: endpoint { }; }; =20 - itnoc@11200000 { - compatible =3D "qcom,coresight-itnoc"; + tn@11200000 { + compatible =3D "qcom,coresight-tnoc"; reg =3D <0x0 0x11200000 0x0 0x3c00>; =20 clocks =3D <&aoss_qmp>; - clock-names =3D "apb"; + clock-names =3D "apb_pclk"; =20 in-ports { #address-cells =3D <1>; --=20 2.34.1