From nobody Mon Jul 27 19:38:44 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 955A83F12DC for ; Wed, 8 Jul 2026 15:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783525475; cv=none; b=miBit/NIUxlaXCULs8hTeGU5L8W0uJWmm6PtCbrc8uijfV4AxjPuCE1E41p+79kxFHwucQfP26rbcpZFPDKKZdk5NDiLpfeWL6C0yqFGME6qLag56fI9zxbWD9Z63PJ0MNJ8oY96g/2Sjm6NjpZhTOEbi56t1XE5zsc9pANwA+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783525475; c=relaxed/simple; bh=Dj1OMxrAwOcaATK7Yw0zk+F7nLdCP6BeW65BWVUG9Bw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KEXKb4J4LaXAAMpZHWZdK4FjfgRf70YRcJF4JQsRZYKtTU7g6M/Q3VcMxjE2yc9EZ6hpk/ZVmxXnkQrtYT42ZLPXFWEvLKO0DGeuaV6HH5pQAogUXCL2PrzD+meKzuKvAamgCdYdPilNzAALRIdU1KwKI6AKwWqCjMgBDmRcjXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BWPvEA9O; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BWPvEA9O" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-ca7c1176317so355538a12.1 for ; Wed, 08 Jul 2026 08:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783525474; x=1784130274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RLs6HG919lQIdIHJU5oQosncGb0LHNC2V65hfQ2rlQw=; b=BWPvEA9ODZkuEzZ6II/vkLEobXKWHvZgdLxRQaMlMj851mH0i38K5k9gWCpoWYAKEW aPiRjgiwzgN/L2LdsdQKcv7Wiv1O2rGYl9bbCUZ+QNVQK0jY8Yy1fQQH04ZIgyb3RulC OalFegLWU69rUxVzQk0ZlspX68Uk+y2HRT/JkARBqX3sidMvHRkVQt9ZWCSg3tZaTwSF prA+88YLQDwcaqkBoPlUU1cPIk1dZGdIIm/cFhoillLPgI3YckZLOBTx7toSLVeDrNuK Ql7I7aLTd9TccT6evUABni+bLmCg1XBvGvzFrdi/V58nITFGJdEQBUdBQs/2lcX786Dx mRRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783525474; x=1784130274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RLs6HG919lQIdIHJU5oQosncGb0LHNC2V65hfQ2rlQw=; b=T648uKu4nranTFHuAsdIet9cy8bPlDDouWN5baCXLSnkVU8KJ91WhsKmp/RXq2Wjab Jgq/wDgRIvuQ8oDHlqN+s68Qj3CZ20p71VmvNTGC+02tMnJiS6Nr3kzbDU1bLdDClBYi CxBjj6EpjWPb3eYvgDLUqXB/FQP5ItQsMGNrtfeaqBRs9uz1Q9KUNum2JnL29ZharNcn RAmNcSw7Qos1eUtqUsaFko8nJluqdF4ZIM47kYad96uu+E2OaKh9gL/LgPmQjflayoy7 7UQt0XcsihyMnp17kdX+bzqmflp2XkDl1ad9IcXdkA8JDtcXUeiRXbGyQloh3GrS0QGc HaWA== X-Forwarded-Encrypted: i=1; AHgh+RpJMO6RJU08ZvBtMqCP67EdKYpDg1BxTbcPPgh8BCUryx2wfyzB0Ugx65rFR3OsKyWPKmo+ZSsEMAEAja0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8SG/bACzqNCQRsJxuyI2SdH8gvP62bfq73BEF7o61vX0r9wpl CE5v4qMQjt9l6DEoTVdBi8WL4WL1M/k2qnak/NnLh3V597b1UPN/3mdd X-Gm-Gg: AfdE7cmUUl+YXpTVbtVF29DTn9a119II8lao5IMApT/2tswFY7oyg9OkGXvzezI+pE7 Kage/KNkXEDcCUkrTRHqqsnrIq0cNDxw7oKPHIQ1DcDz87FotpILBo3EMFCNOos+8BC0hjAd9wA k4fstC3Ff/i/Ew42pXhLx44Is0zkyq76M0FkKdYeTMyBWOg27R+Me8THaBaJKgd9vWdveHM3yAs tnfMq2sFvxdSTVbL31RwicX7G/Ft9qlUYvUiZIRwmvBBjnhF1DYPvl2UrjIdXUvt7o6OCJ7ASZd n0DG4ggge4vAb7nGsBQ1HIhxwl34DpdTXsumNRrm+X7Ydw/Qr86Z+6nwOOEyyxGQNkGKv8LfMeL UjSwZImLsLQHHAH86NLSapof3usEKaQQIxA7KAQ5kT6C8DjAX5IOyNHFIyRoeiQu2I51NybBVMX U4SOErhqQcl2vPVzh/oDcPr7fxSCFcRcAKkA0zdySupU2LDA+61tfL0w== X-Received: by 2002:a05:6a21:670b:b0:3c0:9c19:65b5 with SMTP id adf61e73a8af0-3c0bcc3ae41mr4057315637.61.1783525473909; Wed, 08 Jul 2026 08:44:33 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6594f6a9sm22396749c88.5.2026.07.08.08.44.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Jul 2026 08:44:33 -0700 (PDT) From: Biren Pandya To: jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , mchehab@kernel.org, sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v4] media: i2c: rdacm21: Fix missing media_entity_cleanup() Date: Wed, 8 Jul 2026 21:14:21 +0530 Message-ID: <20260708154420.51617-4-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260708154420.51617-3-birenpandya@gmail.com> References: <20260708152929.50074-2-birenpandya@gmail.com> <20260708154420.51617-3-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If an error occurs after media_entity_pads_init() is called, the media entity is left uncleaned, potentially leaking resources or leaving it in an invalid state. Similarly, the remove path misses the cleanup. Add a dedicated error_entity_cleanup label so that media_entity_cleanup() is only invoked on the error path when media_entity_pads_init() has actually succeeded. Also add media_entity_cleanup() to rdacm21_remove() to ensure proper resource release on driver unload. Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module") Signed-off-by: Biren Pandya --- Changes in v4: - Rebased onto latest linux-media next branch to resolve a merge conflict i= n rdacm21.c (as reported by Media CI). Changes in v3: - Added a blank line after media_entity_cleanup() in the error path (Sakari= ). Changes in v2: - Fixed a bug in v1's probe error handling where media_entity_cleanup() could be called on an uninitialized entity. - Added Signed-off-by tag which was missing in v1. --- drivers/media/i2c/rdacm21.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c index bcab462708c70..531b71d0a94df 100644 --- a/drivers/media/i2c/rdacm21.c +++ b/drivers/media/i2c/rdacm21.c @@ -588,10 +588,13 @@ static int rdacm21_probe(struct i2c_client *client) =20 ret =3D v4l2_async_register_subdev(&dev->sd); if (ret) - goto error_free_ctrls; + goto error_entity_cleanup; =20 return 0; =20 +error_entity_cleanup: + media_entity_cleanup(&dev->sd.entity); + error_free_ctrls: v4l2_ctrl_handler_free(&dev->ctrls); error: --=20 2.50.1 (Apple Git-155)